Re: [ovs-dev] [PATCH v2] netdev: fix partial offloading test cases failure

[Ilya Maximets]

On 2/26/20 5:46 AM, Yanqin Wei wrote:
> Some partial offloading test cases are failing inconsistently. The root
> cause is that dummy netdev is assigned with "linux_tc" offloading API.
> dpif-netdev - partial hw offload - dummy
> dpif-netdev - partial hw offload - dummy-pmd
> dpif-netdev - partial hw offload with packet modifications - dummy
> dpif-netdev - partial hw offload with packet modifications - dummy-pmd
> 
> This patch fixes this issue by changing 'options:ifindex=1' to some big
> value. It is a workaround to make "linux_tc" init flow api failure. All
> above cases can pass consistently after applying this patch.
> 
> Suggested-by: Ilya Maximets 
> Reviewed-by: Gavin Hu 
> Reviewed-by: Lijian Zhang 
> Signed-off-by: Yanqin Wei 
> ---
>  tests/dpif-netdev.at | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks!  Applied to master and backported.

Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2] netdev: fix partial offloading test cases failure

[Yanqin Wei]

Some partial offloading test cases are failing inconsistently. The root
cause is that dummy netdev is assigned with "linux_tc" offloading API.
dpif-netdev - partial hw offload - dummy
dpif-netdev - partial hw offload - dummy-pmd
dpif-netdev - partial hw offload with packet modifications - dummy
dpif-netdev - partial hw offload with packet modifications - dummy-pmd

This patch fixes this issue by changing 'options:ifindex=1' to some big
value. It is a workaround to make "linux_tc" init flow api failure. All
above cases can pass consistently after applying this patch.

Suggested-by: Ilya Maximets 
Reviewed-by: Gavin Hu 
Reviewed-by: Lijian Zhang 
Signed-off-by: Yanqin Wei 
---
 tests/dpif-netdev.at | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/dpif-netdev.at b/tests/dpif-netdev.at
index 0aeb4e788..12e468744 100644
--- a/tests/dpif-netdev.at
+++ b/tests/dpif-netdev.at
@@ -371,7 +371,7 @@ m4_define([DPIF_NETDEV_FLOW_HW_OFFLOAD],
   [AT_SETUP([dpif-netdev - partial hw offload - $1])
OVS_VSWITCHD_START(
  [add-port br0 p1 -- \
-  set interface p1 type=$1 ofport_request=1 
options:pstream=punix:$OVS_RUNDIR/p1.sock options:ifindex=1 -- \
+  set interface p1 type=$1 ofport_request=1 
options:pstream=punix:$OVS_RUNDIR/p1.sock options:ifindex=1100 -- \
   set bridge br0 datapath-type=dummy \
  other-config:datapath-id=1234 fail-mode=secure], [], [],
   [m4_if([$1], [dummy-pmd], [--dummy-numa="0,0,0,0,1,1,1,1"], [])])
@@ -434,7 +434,7 @@ m4_define([DPIF_NETDEV_FLOW_HW_OFFLOAD_OFFSETS],
   [AT_SETUP([dpif-netdev - partial hw offload with packet modifications - $1])
OVS_VSWITCHD_START(
  [add-port br0 p1 -- \
-  set interface p1 type=$1 ofport_request=1 options:pcap=p1.pcap 
options:ifindex=1 -- \
+  set interface p1 type=$1 ofport_request=1 options:pcap=p1.pcap 
options:ifindex=1101 -- \
   set bridge br0 datapath-type=dummy \
  other-config:datapath-id=1234 fail-mode=secure], [], [],
   [m4_if([$1], [dummy-pmd], [--dummy-numa="0,0,0,0,1,1,1,1"], [])])
-- 
2.17.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev