Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

2017-11-30 Thread Numan Siddique 
On Thu, Nov 30, 2017 at 11:21 PM, Ben Pfaff  wrote:

> On Thu, Nov 30, 2017 at 11:02:23PM +0530, Numan Siddique wrote:
> > On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff  wrote:
> >
> > > On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote:
> > > > From: Numan Siddique 
> > > >
> > > > In the case of OVN HA deployments with openstack, it has been noticed
> > > > that the 5 seconds inactivity probe interval is not enough and
> > > ovsdb-servers
> > > > do not get the echo reply back from the IDL clients and disconnects
> the
> > > > connections.
> > > >
> > > > This patch
> > > >- providdes an option to configure this value.
> > > >- creates a connection row in NB/SB dbs and sets the target and
> > > >  inactivity_probe values when the node is promoted to master.
> > > >
> > > > CC: Andy Zhou 
> > > > Signed-off-by: Numan Siddique 
> > >
> > > Applied to master, thanks Numan!
> > >
> > > This solution isn't ideal so I hope that we continue to evolve it.
> > >
> >
> > We are seeing lot of timeout issues with tripleo deployment with OVS 2.7
> > and this patch is required to fix this issue.
> > Is it possible to backport this to OVS 2.8 and 2.7 branches.
>
> OK, done.
>

Thanks Ben.

Numan
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

2017-11-30 Thread Ben Pfaff 
On Thu, Nov 30, 2017 at 11:02:23PM +0530, Numan Siddique wrote:
> On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff  wrote:
> 
> > On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique 
> > >
> > > In the case of OVN HA deployments with openstack, it has been noticed
> > > that the 5 seconds inactivity probe interval is not enough and
> > ovsdb-servers
> > > do not get the echo reply back from the IDL clients and disconnects the
> > > connections.
> > >
> > > This patch
> > >- providdes an option to configure this value.
> > >- creates a connection row in NB/SB dbs and sets the target and
> > >  inactivity_probe values when the node is promoted to master.
> > >
> > > CC: Andy Zhou 
> > > Signed-off-by: Numan Siddique 
> >
> > Applied to master, thanks Numan!
> >
> > This solution isn't ideal so I hope that we continue to evolve it.
> >
> 
> We are seeing lot of timeout issues with tripleo deployment with OVS 2.7
> and this patch is required to fix this issue.
> Is it possible to backport this to OVS 2.8 and 2.7 branches.

OK, done.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

2017-11-30 Thread Numan Siddique 
On Thu, Oct 26, 2017 at 1:41 AM, Ben Pfaff  wrote:

> On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique 
> >
> > In the case of OVN HA deployments with openstack, it has been noticed
> > that the 5 seconds inactivity probe interval is not enough and
> ovsdb-servers
> > do not get the echo reply back from the IDL clients and disconnects the
> > connections.
> >
> > This patch
> >- providdes an option to configure this value.
> >- creates a connection row in NB/SB dbs and sets the target and
> >  inactivity_probe values when the node is promoted to master.
> >
> > CC: Andy Zhou 
> > Signed-off-by: Numan Siddique 
>
> Applied to master, thanks Numan!
>
> This solution isn't ideal so I hope that we continue to evolve it.
>

We are seeing lot of timeout issues with tripleo deployment with OVS 2.7
and this patch is required to fix this issue.
Is it possible to backport this to OVS 2.8 and 2.7 branches.

Thanks
Numan
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

2017-10-25 Thread Ben Pfaff 
On Mon, Oct 16, 2017 at 03:12:07PM +0530, nusid...@redhat.com wrote:
> From: Numan Siddique 
> 
> In the case of OVN HA deployments with openstack, it has been noticed
> that the 5 seconds inactivity probe interval is not enough and ovsdb-servers
> do not get the echo reply back from the IDL clients and disconnects the
> connections.
> 
> This patch
>- providdes an option to configure this value.
>- creates a connection row in NB/SB dbs and sets the target and
>  inactivity_probe values when the node is promoted to master.
> 
> CC: Andy Zhou 
> Signed-off-by: Numan Siddique 

Applied to master, thanks Numan!

This solution isn't ideal so I hope that we continue to evolve it.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2] ovn pacemaker: Provide the option to configure inactivity probe value

2017-10-16 Thread nusiddiq 
From: Numan Siddique 

In the case of OVN HA deployments with openstack, it has been noticed
that the 5 seconds inactivity probe interval is not enough and ovsdb-servers
do not get the echo reply back from the IDL clients and disconnects the
connections.

This patch
   - providdes an option to configure this value.
   - creates a connection row in NB/SB dbs and sets the target and
 inactivity_probe values when the node is promoted to master.

CC: Andy Zhou 
Signed-off-by: Numan Siddique 
---
 ovn/TODO.rst|  9 +
 ovn/utilities/ovndb-servers.ocf | 27 +++
 2 files changed, 36 insertions(+)

v1 -> v2

Set the INACTIVE_PROBE_DEFAULT to 5 seconds instead of 60 seconds.
Added a note in ov/TODO about this issue.

diff --git a/ovn/TODO.rst b/ovn/TODO.rst
index 0b883d4d3..d0e62bfbb 100644
--- a/ovn/TODO.rst
+++ b/ovn/TODO.rst
@@ -211,6 +211,15 @@ OVN To-do List
 Multicast_Group table entry in ovn-sb database into Mcast_Macs_Remote table
 configuration in VTEP database.
 
+  * OVN OCF pacemaker script to support Active / Passive HA for OVN dbs 
provides
+the option to configure the inactivity_probe value. The default 5 seconds
+inactivity_probe value is not sufficient and ovsdb-server drops the client
+IDL connections for openstack deployments when the neutron server is 
heavily
+loaded.
+
+We need to find a proper solution to solve this issue instead of increasing
+the inactivity_probe value.
+
 * Consider the use of BFD as tunnel monitor.
 
   The use of BFD for hypervisor-to-hypervisor tunnels is probably not worth it,
diff --git a/ovn/utilities/ovndb-servers.ocf b/ovn/utilities/ovndb-servers.ocf
index fe1207c22..3f3008700 100755
--- a/ovn/utilities/ovndb-servers.ocf
+++ b/ovn/utilities/ovndb-servers.ocf
@@ -8,6 +8,8 @@
 : ${SB_MASTER_PORT_DEFAULT="6642"}
 : ${SB_MASTER_PROTO_DEFAULT="tcp"}
 : ${MANAGE_NORTHD_DEFAULT="no"}
+: ${INACTIVE_PROBE_DEFAULT="5000"}
+
 CRM_MASTER="${HA_SBIN_DIR}/crm_master -l reboot"
 CRM_ATTR_REPL_INFO="${HA_SBIN_DIR}/crm_attribute --type crm_config --name 
OVN_REPL_INFO -s ovn_ovsdb_master_server"
 OVN_CTL=${OCF_RESKEY_ovn_ctl:-${OVN_CTL_DEFAULT}}
@@ -17,6 +19,7 @@ 
NB_MASTER_PROTO=${OCF_RESKEY_nb_master_protocol:-${NB_MASTER_PROTO_DEFAULT}}
 SB_MASTER_PORT=${OCF_RESKEY_sb_master_port:-${SB_MASTER_PORT_DEFAULT}}
 SB_MASTER_PROTO=${OCF_RESKEY_sb_master_protocol:-${SB_MASTER_PROTO_DEFAULT}}
 MANAGE_NORTHD=${OCF_RESKEY_manage_northd:-${MANAGE_NORTHD_DEFAULT}}
+INACTIVE_PROBE=${OCF_RESKEY_inactive_probe_interval:-${INACTIVE_PROBE_DEFAULT}}
 
 # Invalid IP address is an address that can never exist in the network, as
 # mentioned in rfc-5737. The ovsdb servers connects to this IP address till
@@ -101,6 +104,14 @@ ovsdb_server_metadata() {
   
   
 
+  
+  
+  Inactive probe interval to set for ovsdb-server.
+  
+  Set inactive probe interval
+  
+  
+
   
 
   
@@ -138,6 +149,22 @@ ovsdb_server_notify() {
 ${OVN_CTL} --ovn-manage-ovsdb=no start_northd
 fi
 
+conn=`ovn-nbctl get NB_global . connections`
+if [ "$conn" == "[]" ]
+then
+ovn-nbctl -- --id=@conn_uuid create Connection \
+target="p${NB_MASTER_PROTO}\:${NB_MASTER_PORT}\:${MASTER_IP}" \
+inactivity_probe=$INACTIVE_PROBE -- set NB_Global . connections=@conn_uuid
+fi
+
+conn=`ovn-sbctl get SB_global . connections`
+if [ "$conn" == "[]" ]
+then
+ovn-sbctl -- --id=@conn_uuid create Connection \
+target="p${SB_MASTER_PROTO}\:${SB_MASTER_PORT}\:${MASTER_IP}" \
+inactivity_probe=$INACTIVE_PROBE -- set SB_Global . connections=@conn_uuid
+fi
+
 else
 if [ "$MANAGE_NORTHD" = "yes" ]; then
 # Stop ovn-northd service. Set --ovn-manage-ovsdb=no so that
-- 
2.13.5

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev