Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 16 Mar 2023, at 7:51, Chris Mi wrote: > On 3/16/2023 11:37 AM, Chris Mi via dev wrote: >> On 3/16/2023 12:40 AM, Eelco Chaudron wrote: >>> >>> On 15 Mar 2023, at 11:07, Chris Mi wrote: >>> On 3/15/2023 5:28 PM, Eelco Chaudron wrote: > On 15 Mar 2023, at 4:40, Chris Mi wrote: > >> On 3/10/2023 10:02 PM, Eelco Chaudron wrote: >>> On 10 Mar 2023, at 13:11, Eelco Chaudron wrote: >>> On 1 Mar 2023, at 8:22, Chris Mi wrote: > This patch set adds offload support for sFlow. > > Psample is a genetlink channel for packet sampling. TC action > act_sample > uses psample to send sampled packets to userspace. > > When offloading sample action to TC, userspace creates a unique ID to > map sFlow action and tunnel info and passes this ID to kernel instead > of the sFlow info. psample will send this ID and sampled packet to > userspace. Using the ID, userspace can recover the sFlow info and send > sampled packet to the right sFlow monitoring host. I started to review, but the test cases are failing in my setups. Maybe you need to re-base your build as some stuff has changed related to flow statistic updates. On RHEL9/Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) 3: ./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows type=tc,offloaded | grep "in_port(2)" | grep "eth_type(0x0800)" | grep "actions:userspace" | grep "sFlow" | sed -e "s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst= [a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/" --- - 2023-03-10 12:59:37.008456662 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout 2023-03-10 12:59:37.007186662 +0100 @@ -1,2 +1,2 @@ -recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:10, bytes:840, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 +recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:19, bytes:1596, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 4: ./system-offloads-traffic.at:191: check_logs --- /dev/null 2023-03-08 13:28:57.628323765 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout 2023-03-10 13:04:47.167727980 +0100 @@ -0,0 +1 @@ +2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv failed (No such file or directory) On Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) >>> More tests are failing with your patch applied in offloads, it looks >>> like due to the same error message as above: >>> >>> 1: offloads - ping between two ports - offloads disabled FAILED >>> (system-offloads-traffic.at:60) >>> 5: offloads - set ingress_policing_rate and ingress_policing_burst >>> - offloads disabled FAILED (system-offloads-traffic.at:217) >>> 7: offloads - set ingress_policing_kpkts_rate and >>> ingress_policing_kpkts_burst - offloads disabled FAILED >>> (system-offloads-traffic.at:265) >>> 9: offloads - check interface meter offloading - offloads disabled >>> FAILED (system-offloads-traffic.at:339) >>> 11: offloads - check_pkt_len action - offloads disabled FAILED >>> (system-offloads-traffic.at:439) >>> >>> >>> Even worse (almost) all kernel tests (make check-kernel) are failing >>> due to this error, which is not a problem with out your patches :( >>> >>> system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 >>> 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 >>> 46 47 48 49 50 51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 >>> 71 72 73 74 75 76 77 78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 >>> 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 >>> 115 116 117 118 119 120 121 122 123 124 125 126 133 134 135 136 137 138
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 3/16/2023 11:37 AM, Chris Mi via dev wrote: On 3/16/2023 12:40 AM, Eelco Chaudron wrote: On 15 Mar 2023, at 11:07, Chris Mi wrote: On 3/15/2023 5:28 PM, Eelco Chaudron wrote: On 15 Mar 2023, at 4:40, Chris Mi wrote: On 3/10/2023 10:02 PM, Eelco Chaudron wrote: On 10 Mar 2023, at 13:11, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the right sFlow monitoring host. I started to review, but the test cases are failing in my setups. Maybe you need to re-base your build as some stuff has changed related to flow statistic updates. On RHEL9/Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) 3: ./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows type=tc,offloaded | grep "in_port(2)" | grep "eth_type(0x0800)" | grep "actions:userspace" | grep "sFlow" | sed -e "s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst= [a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/" --- - 2023-03-10 12:59:37.008456662 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout 2023-03-10 12:59:37.007186662 +0100 @@ -1,2 +1,2 @@ -recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:10, bytes:840, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 +recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:19, bytes:1596, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 4: ./system-offloads-traffic.at:191: check_logs --- /dev/null 2023-03-08 13:28:57.628323765 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout 2023-03-10 13:04:47.167727980 +0100 @@ -0,0 +1 @@ +2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv failed (No such file or directory) On Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) More tests are failing with your patch applied in offloads, it looks like due to the same error message as above: 1: offloads - ping between two ports - offloads disabled FAILED (system-offloads-traffic.at:60) 5: offloads - set ingress_policing_rate and ingress_policing_burst - offloads disabled FAILED (system-offloads-traffic.at:217) 7: offloads - set ingress_policing_kpkts_rate and ingress_policing_kpkts_burst - offloads disabled FAILED (system-offloads-traffic.at:265) 9: offloads - check interface meter offloading - offloads disabled FAILED (system-offloads-traffic.at:339) 11: offloads - check_pkt_len action - offloads disabled FAILED (system-offloads-traffic.at:439) Even worse (almost) all kernel tests (make check-kernel) are failing due to this error, which is not a problem with out your patches :( system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 167 168 169 170 171 failed Can you please run all unit tests before submitting a new revision? Let me know what the change will be to fix all of this, so I can incorporate it in the review. //Eelco I thought github actions would run all the tests. So I didn't run 'make check-offloads' manually. No, the datapath tests are not run. So before you submit a patch like this you need to run make check/check-kerne/check-offloads/check-system-userspace. OK. I reproduced the "recv failed" error. The following diff can fix it: diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index 510ba922d..70ba45f99 100644 --- a/lib/netdev-offload-tc.c +++ b/lib/netdev-offload-tc.c @@ -3451,7 +3451,7 @@
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 3/16/2023 12:40 AM, Eelco Chaudron wrote: On 15 Mar 2023, at 11:07, Chris Mi wrote: On 3/15/2023 5:28 PM, Eelco Chaudron wrote: On 15 Mar 2023, at 4:40, Chris Mi wrote: On 3/10/2023 10:02 PM, Eelco Chaudron wrote: On 10 Mar 2023, at 13:11, Eelco Chaudron wrote: On 1 Mar 2023, at 8:22, Chris Mi wrote: This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the right sFlow monitoring host. I started to review, but the test cases are failing in my setups. Maybe you need to re-base your build as some stuff has changed related to flow statistic updates. On RHEL9/Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) 3: ./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows type=tc,offloaded | grep "in_port(2)" | grep "eth_type(0x0800)" | grep "actions:userspace" | grep "sFlow" | sed -e "s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst= [a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/" --- - 2023-03-10 12:59:37.008456662 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout 2023-03-10 12:59:37.007186662 +0100 @@ -1,2 +1,2 @@ -recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:10, bytes:840, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 +recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:19, bytes:1596, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 4: ./system-offloads-traffic.at:191: check_logs --- /dev/null 2023-03-08 13:28:57.628323765 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout 2023-03-10 13:04:47.167727980 +0100 @@ -0,0 +1 @@ +2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv failed (No such file or directory) On Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) More tests are failing with your patch applied in offloads, it looks like due to the same error message as above: 1: offloads - ping between two ports - offloads disabled FAILED (system-offloads-traffic.at:60) 5: offloads - set ingress_policing_rate and ingress_policing_burst - offloads disabled FAILED (system-offloads-traffic.at:217) 7: offloads - set ingress_policing_kpkts_rate and ingress_policing_kpkts_burst - offloads disabled FAILED (system-offloads-traffic.at:265) 9: offloads - check interface meter offloading - offloads disabled FAILED (system-offloads-traffic.at:339) 11: offloads - check_pkt_len action - offloads disabled FAILED (system-offloads-traffic.at:439) Even worse (almost) all kernel tests (make check-kernel) are failing due to this error, which is not a problem with out your patches :( system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 167 168 169 170 171 failed Can you please run all unit tests before submitting a new revision? Let me know what the change will be to fix all of this, so I can incorporate it in the review. //Eelco I thought github actions would run all the tests. So I didn't run 'make check-offloads' manually. No, the datapath tests are not run. So before you submit a patch like this you need to run make check/check-kerne/check-offloads/check-system-userspace. OK. I reproduced the "recv failed" error. The following diff can fix it: diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c index 510ba922d..70ba45f99 100644 --- a/lib/netdev-offload-tc.c +++ b/lib/netdev-offload-tc.c @@ -3451,7 +3451,7 @@ offload_recv(struct dpif_upcall *upcall, struct ofpbuf *buf, }
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 15 Mar 2023, at 11:07, Chris Mi wrote: > On 3/15/2023 5:28 PM, Eelco Chaudron wrote: >> >> On 15 Mar 2023, at 4:40, Chris Mi wrote: >> >>> On 3/10/2023 10:02 PM, Eelco Chaudron wrote: On 10 Mar 2023, at 13:11, Eelco Chaudron wrote: > On 1 Mar 2023, at 8:22, Chris Mi wrote: > >> This patch set adds offload support for sFlow. >> >> Psample is a genetlink channel for packet sampling. TC action act_sample >> uses psample to send sampled packets to userspace. >> >> When offloading sample action to TC, userspace creates a unique ID to >> map sFlow action and tunnel info and passes this ID to kernel instead >> of the sFlow info. psample will send this ID and sampled packet to >> userspace. Using the ID, userspace can recover the sFlow info and send >> sampled packet to the right sFlow monitoring host. > I started to review, but the test cases are failing in my setups. Maybe > you need to re-base your build as some stuff has changed related to flow > statistic updates. > > On RHEL9/Fedora 37: > > 3: sflow offloads with sampling=1 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:133) > 4: sflow offloads with sampling=2 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:191) > > > 3: > > ./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows > type=tc,offloaded | grep "in_port(2)" | grep "eth_type(0x0800)" | grep > "actions:userspace" | grep "sFlow" | sed -e > "s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst= > [a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/" > --- - 2023-03-10 12:59:37.008456662 +0100 > +++ > /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout > 2023-03-10 12:59:37.007186662 +0100 > @@ -1,2 +1,2 @@ > -recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), > packets:10, bytes:840, used:0.001s, > actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 > +recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), > packets:19, bytes:1596, used:0.001s, > actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 > > > 4: > > ./system-offloads-traffic.at:191: check_logs > --- /dev/null 2023-03-08 13:28:57.628323765 +0100 > +++ > /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout > 2023-03-10 13:04:47.167727980 +0100 > @@ -0,0 +1 @@ > +2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: > recv failed (No such file or directory) > > > On Fedora 37: > > 3: sflow offloads with sampling=1 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:133) > 4: sflow offloads with sampling=2 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:191) More tests are failing with your patch applied in offloads, it looks like due to the same error message as above: 1: offloads - ping between two ports - offloads disabled FAILED (system-offloads-traffic.at:60) 5: offloads - set ingress_policing_rate and ingress_policing_burst - offloads disabled FAILED (system-offloads-traffic.at:217) 7: offloads - set ingress_policing_kpkts_rate and ingress_policing_kpkts_burst - offloads disabled FAILED (system-offloads-traffic.at:265) 9: offloads - check interface meter offloading - offloads disabled FAILED (system-offloads-traffic.at:339) 11: offloads - check_pkt_len action - offloads disabled FAILED (system-offloads-traffic.at:439) Even worse (almost) all kernel tests (make check-kernel) are failing due to this error, which is not a problem with out your patches :( system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 167 168 169 170 171 failed Can you please run all unit tests before submitting a new revision? Let me know what the change will be to fix all of this, so I can incorporate it in the review. //Eelco >>> I thought github actions would run all the tests. So I didn't run 'make >>>
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 3/15/2023 5:28 PM, Eelco Chaudron wrote:
On 15 Mar 2023, at 4:40, Chris Mi wrote:
On 3/10/2023 10:02 PM, Eelco Chaudron wrote:
On 10 Mar 2023, at 13:11, Eelco Chaudron wrote:
On 1 Mar 2023, at 8:22, Chris Mi wrote:
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to the right sFlow monitoring host.
I started to review, but the test cases are failing in my setups. Maybe you
need to re-base your build as some stuff has changed related to flow statistic
updates.
On RHEL9/Fedora 37:
3: sflow offloads with sampling=1 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:133)
4: sflow offloads with sampling=2 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:191)
3:
./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows type=tc,offloaded | grep "in_port(2)" | grep
"eth_type(0x0800)" | grep "actions:userspace" | grep "sFlow" | sed -e
"s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst=
[a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/"
--- - 2023-03-10 12:59:37.008456662 +0100
+++
/root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout
2023-03-10 12:59:37.007186662 +0100
@@ -1,2 +1,2 @@
-recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:10,
bytes:840, used:0.001s,
actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3
+recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:19,
bytes:1596, used:0.001s,
actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3
4:
./system-offloads-traffic.at:191: check_logs
--- /dev/null 2023-03-08 13:28:57.628323765 +0100
+++
/root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout
2023-03-10 13:04:47.167727980 +0100
@@ -0,0 +1 @@
+2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv
failed (No such file or directory)
On Fedora 37:
3: sflow offloads with sampling=1 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:133)
4: sflow offloads with sampling=2 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:191)
More tests are failing with your patch applied in offloads, it looks like due
to the same error message as above:
1: offloads - ping between two ports - offloads disabled FAILED
(system-offloads-traffic.at:60)
5: offloads - set ingress_policing_rate and ingress_policing_burst -
offloads disabled FAILED (system-offloads-traffic.at:217)
7: offloads - set ingress_policing_kpkts_rate and
ingress_policing_kpkts_burst - offloads disabled FAILED
(system-offloads-traffic.at:265)
9: offloads - check interface meter offloading - offloads disabled FAILED
(system-offloads-traffic.at:339)
11: offloads - check_pkt_len action - offloads disabled FAILED
(system-offloads-traffic.at:439)
Even worse (almost) all kernel tests (make check-kernel) are failing due to
this error, which is not a problem with out your patches :(
system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 22 23 24
25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77
78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104
105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124
125 126 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150
151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 167 168 169 170 171
failed
Can you please run all unit tests before submitting a new revision? Let me know
what the change will be to fix all of this, so I can incorporate it in the
review.
//Eelco
I thought github actions would run all the tests. So I didn't run 'make
check-offloads' manually.
No, the datapath tests are not run. So before you submit a patch like this you
need to run make check/check-kerne/check-offloads/check-system-userspace.
OK.
I reproduced the "recv failed" error. The following diff can fix it:
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
index 510ba922d..70ba45f99 100644
--- a/lib/netdev-offload-tc.c
+++ b/lib/netdev-offload-tc.c
@@ -3451,7 +3451,7 @@ offload_recv(struct dpif_upcall *upcall, struct ofpbuf
*buf,
}
if (!psample_sock) {
- return ENOENT;
+ return EAGAIN;
}
for (;;) {
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 15 Mar 2023, at 4:40, Chris Mi wrote: > On 3/10/2023 10:02 PM, Eelco Chaudron wrote: >> >> On 10 Mar 2023, at 13:11, Eelco Chaudron wrote: >> >>> On 1 Mar 2023, at 8:22, Chris Mi wrote: >>> This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the right sFlow monitoring host. >>> I started to review, but the test cases are failing in my setups. Maybe you >>> need to re-base your build as some stuff has changed related to flow >>> statistic updates. >>> >>> On RHEL9/Fedora 37: >>> >>>3: sflow offloads with sampling=1 - ping between two ports - offloads >>> enabled FAILED (system-offloads-traffic.at:133) >>>4: sflow offloads with sampling=2 - ping between two ports - offloads >>> enabled FAILED (system-offloads-traffic.at:191) >>> >>> >>> 3: >>> >>> ./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows >>> type=tc,offloaded | grep "in_port(2)" | grep "eth_type(0x0800)" | grep >>> "actions:userspace" | grep "sFlow" | sed -e >>> "s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst= >>> [a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/" >>> --- - 2023-03-10 12:59:37.008456662 +0100 >>> +++ >>> /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout >>>2023-03-10 12:59:37.007186662 +0100 >>> @@ -1,2 +1,2 @@ >>> -recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), >>> packets:10, bytes:840, used:0.001s, >>> actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 >>> +recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), >>> packets:19, bytes:1596, used:0.001s, >>> actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 >>> >>> >>> 4: >>> >>> ./system-offloads-traffic.at:191: check_logs >>> --- /dev/null 2023-03-08 13:28:57.628323765 +0100 >>> +++ >>> /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout >>>2023-03-10 13:04:47.167727980 +0100 >>> @@ -0,0 +1 @@ >>> +2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv >>> failed (No such file or directory) >>> >>> >>> On Fedora 37: >>> >>>3: sflow offloads with sampling=1 - ping between two ports - offloads >>> enabled FAILED (system-offloads-traffic.at:133) >>>4: sflow offloads with sampling=2 - ping between two ports - offloads >>> enabled FAILED (system-offloads-traffic.at:191) >> >> More tests are failing with your patch applied in offloads, it looks like >> due to the same error message as above: >> >>1: offloads - ping between two ports - offloads disabled FAILED >> (system-offloads-traffic.at:60) >>5: offloads - set ingress_policing_rate and ingress_policing_burst - >> offloads disabled FAILED (system-offloads-traffic.at:217) >>7: offloads - set ingress_policing_kpkts_rate and >> ingress_policing_kpkts_burst - offloads disabled FAILED >> (system-offloads-traffic.at:265) >>9: offloads - check interface meter offloading - offloads disabled >> FAILED (system-offloads-traffic.at:339) >> 11: offloads - check_pkt_len action - offloads disabled FAILED >> (system-offloads-traffic.at:439) >> >> >> Even worse (almost) all kernel tests (make check-kernel) are failing due to >> this error, which is not a problem with out your patches :( >> >> system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 22 23 >> 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 >> 49 50 51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 >> 75 76 77 78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 >> 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 >> 121 122 123 124 125 126 133 134 135 136 137 138 139 140 141 142 143 144 145 >> 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 >> 165 167 168 169 170 171 failed >> >> Can you please run all unit tests before submitting a new revision? Let me >> know what the change will be to fix all of this, so I can incorporate it in >> the review. >> >> //Eelco > I thought github actions would run all the tests. So I didn't run 'make > check-offloads' manually. No, the datapath tests are not run. So before you submit a patch like this you need to run make check/check-kerne/check-offloads/check-system-userspace. > I reproduced the "recv failed" error. The following diff can fix it: > > diff --git a/lib/netdev-offload-tc.c
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 3/10/2023 10:02 PM, Eelco Chaudron wrote:
On 10 Mar 2023, at 13:11, Eelco Chaudron wrote:
On 1 Mar 2023, at 8:22, Chris Mi wrote:
This patch set adds offload support for sFlow.
Psample is a genetlink channel for packet sampling. TC action act_sample
uses psample to send sampled packets to userspace.
When offloading sample action to TC, userspace creates a unique ID to
map sFlow action and tunnel info and passes this ID to kernel instead
of the sFlow info. psample will send this ID and sampled packet to
userspace. Using the ID, userspace can recover the sFlow info and send
sampled packet to the right sFlow monitoring host.
I started to review, but the test cases are failing in my setups. Maybe you
need to re-base your build as some stuff has changed related to flow statistic
updates.
On RHEL9/Fedora 37:
3: sflow offloads with sampling=1 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:133)
4: sflow offloads with sampling=2 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:191)
3:
./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows type=tc,offloaded | grep "in_port(2)" | grep
"eth_type(0x0800)" | grep "actions:userspace" | grep "sFlow" | sed -e
"s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst=
[a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/"
--- - 2023-03-10 12:59:37.008456662 +0100
+++
/root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout
2023-03-10 12:59:37.007186662 +0100
@@ -1,2 +1,2 @@
-recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:10,
bytes:840, used:0.001s,
actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3
+recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:19,
bytes:1596, used:0.001s,
actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3
4:
./system-offloads-traffic.at:191: check_logs
--- /dev/null 2023-03-08 13:28:57.628323765 +0100
+++
/root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout
2023-03-10 13:04:47.167727980 +0100
@@ -0,0 +1 @@
+2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv
failed (No such file or directory)
On Fedora 37:
3: sflow offloads with sampling=1 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:133)
4: sflow offloads with sampling=2 - ping between two ports - offloads
enabled FAILED (system-offloads-traffic.at:191)
More tests are failing with your patch applied in offloads, it looks like due
to the same error message as above:
1: offloads - ping between two ports - offloads disabled FAILED
(system-offloads-traffic.at:60)
5: offloads - set ingress_policing_rate and ingress_policing_burst -
offloads disabled FAILED (system-offloads-traffic.at:217)
7: offloads - set ingress_policing_kpkts_rate and
ingress_policing_kpkts_burst - offloads disabled FAILED
(system-offloads-traffic.at:265)
9: offloads - check interface meter offloading - offloads disabled FAILED
(system-offloads-traffic.at:339)
11: offloads - check_pkt_len action - offloads disabled FAILED
(system-offloads-traffic.at:439)
Even worse (almost) all kernel tests (make check-kernel) are failing due to
this error, which is not a problem with out your patches :(
system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 22 23 24
25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77
78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104
105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124
125 126 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150
151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 167 168 169 170 171
failed
Can you please run all unit tests before submitting a new revision? Let me know
what the change will be to fix all of this, so I can incorporate it in the
review.
//Eelco
I thought github actions would run all the tests. So I didn't run 'make
check-offloads' manually.
I reproduced the "recv failed" error. The following diff can fix it:
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
index 510ba922d..70ba45f99 100644
--- a/lib/netdev-offload-tc.c
+++ b/lib/netdev-offload-tc.c
@@ -3451,7 +3451,7 @@ offload_recv(struct dpif_upcall *upcall, struct
ofpbuf *buf,
}
if (!psample_sock) {
- return ENOENT;
+ return EAGAIN;
}
for (;;) {
Test 3 "sflow offloads with sampling=1" also failed. I changed the test
based on test 4.
Now it sends 1000 packets instead of 10. After this change, the test
result is stable.
Do you want me to submit a new version to continue the review?
Thanks,
Chris
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 10 Mar 2023, at 13:11, Eelco Chaudron wrote: > On 1 Mar 2023, at 8:22, Chris Mi wrote: > >> This patch set adds offload support for sFlow. >> >> Psample is a genetlink channel for packet sampling. TC action act_sample >> uses psample to send sampled packets to userspace. >> >> When offloading sample action to TC, userspace creates a unique ID to >> map sFlow action and tunnel info and passes this ID to kernel instead >> of the sFlow info. psample will send this ID and sampled packet to >> userspace. Using the ID, userspace can recover the sFlow info and send >> sampled packet to the right sFlow monitoring host. > > I started to review, but the test cases are failing in my setups. Maybe you > need to re-base your build as some stuff has changed related to flow > statistic updates. > > On RHEL9/Fedora 37: > > 3: sflow offloads with sampling=1 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:133) > 4: sflow offloads with sampling=2 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:191) > > > 3: > > ./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows > type=tc,offloaded | grep "in_port(2)" | grep "eth_type(0x0800)" | grep > "actions:userspace" | grep "sFlow" | sed -e > "s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst= > [a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/" > --- - 2023-03-10 12:59:37.008456662 +0100 > +++ > /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout > 2023-03-10 12:59:37.007186662 +0100 > @@ -1,2 +1,2 @@ > -recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), > packets:10, bytes:840, used:0.001s, > actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 > +recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), > packets:19, bytes:1596, used:0.001s, > actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 > > > 4: > > ./system-offloads-traffic.at:191: check_logs > --- /dev/null 2023-03-08 13:28:57.628323765 +0100 > +++ > /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout > 2023-03-10 13:04:47.167727980 +0100 > @@ -0,0 +1 @@ > +2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv > failed (No such file or directory) > > > On Fedora 37: > > 3: sflow offloads with sampling=1 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:133) > 4: sflow offloads with sampling=2 - ping between two ports - offloads > enabled FAILED (system-offloads-traffic.at:191) More tests are failing with your patch applied in offloads, it looks like due to the same error message as above: 1: offloads - ping between two ports - offloads disabled FAILED (system-offloads-traffic.at:60) 5: offloads - set ingress_policing_rate and ingress_policing_burst - offloads disabled FAILED (system-offloads-traffic.at:217) 7: offloads - set ingress_policing_kpkts_rate and ingress_policing_kpkts_burst - offloads disabled FAILED (system-offloads-traffic.at:265) 9: offloads - check interface meter offloading - offloads disabled FAILED (system-offloads-traffic.at:339) 11: offloads - check_pkt_len action - offloads disabled FAILED (system-offloads-traffic.at:439) Even worse (almost) all kernel tests (make check-kernel) are failing due to this error, which is not a problem with out your patches :( system-kmod-testsuite: 1 2 3 4 5 6 7 10 11 12 13 14 15 16 17 18 19 20 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 167 168 169 170 171 failed Can you please run all unit tests before submitting a new revision? Let me know what the change will be to fix all of this, so I can incorporate it in the review. //Eelco ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
On 1 Mar 2023, at 8:22, Chris Mi wrote: > This patch set adds offload support for sFlow. > > Psample is a genetlink channel for packet sampling. TC action act_sample > uses psample to send sampled packets to userspace. > > When offloading sample action to TC, userspace creates a unique ID to > map sFlow action and tunnel info and passes this ID to kernel instead > of the sFlow info. psample will send this ID and sampled packet to > userspace. Using the ID, userspace can recover the sFlow info and send > sampled packet to the right sFlow monitoring host. I started to review, but the test cases are failing in my setups. Maybe you need to re-base your build as some stuff has changed related to flow statistic updates. On RHEL9/Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) 3: ./system-offloads-traffic.at:133: ovs-appctl dpctl/dump-flows type=tc,offloaded | grep "in_port(2)" | grep "eth_type(0x0800)" | grep "actions:userspace" | grep "sFlow" | sed -e "s/used:[0-9].[0-9]*s/used:0.001s/;s/eth(src=[a-z0-9:]*,dst= [a-z0-9:]*)/eth(macs)/;s/pid=[0-9]*/pid=1/;s/output=$P1_IFINDEX/output=1/" --- - 2023-03-10 12:59:37.008456662 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/3/stdout 2023-03-10 12:59:37.007186662 +0100 @@ -1,2 +1,2 @@ -recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:10, bytes:840, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 +recirc_id(0),in_port(2),eth(macs),eth_type(0x0800),ipv4(frag=no), packets:19, bytes:1596, used:0.001s, actions:userspace(pid=1,sFlow(vid=0,pcp=0,output=1),actions),3 4: ./system-offloads-traffic.at:191: check_logs --- /dev/null 2023-03-08 13:28:57.628323765 +0100 +++ /root/Documents/reviews/ovs_cmi_tc_sflow/OVS_master_DPDK_v22.11/ovs_github/tests/system-offloads-testsuite.dir/at-groups/4/stdout 2023-03-10 13:04:47.167727980 +0100 @@ -0,0 +1 @@ +2023-03-10T12:04:35.938Z|1|dpif(handler1)|WARN|system@ovs-system: recv failed (No such file or directory) On Fedora 37: 3: sflow offloads with sampling=1 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:133) 4: sflow offloads with sampling=2 - ping between two ports - offloads enabled FAILED (system-offloads-traffic.at:191) //Eelco ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v24 0/8] Add offload support for sFlow
This patch set adds offload support for sFlow. Psample is a genetlink channel for packet sampling. TC action act_sample uses psample to send sampled packets to userspace. When offloading sample action to TC, userspace creates a unique ID to map sFlow action and tunnel info and passes this ID to kernel instead of the sFlow info. psample will send this ID and sampled packet to userspace. Using the ID, userspace can recover the sFlow info and send sampled packet to the right sFlow monitoring host. v2-v1: - Fix robot errors. v3-v2: - Remove Gerrit Change-Id. - Add patch #9 to fix older kernels build issue. - Add travis test result. v4-v3: - Fix offload issue when sampling rate is 1. v5-v4: - Move polling thread from ofproto to netdev-offload-tc. v6-v5: - Rebase. - Add GitHub Actions test result. v7-v6: - Remove Gerrit Change-Id. - Fix "ERROR: Inappropriate spacing around cast" v8-v7 - Address Eelco Chaudron's comment for patch #11. v9-v8 - Remove sflow_len from struct dpif_sflow_attr. - Log a debug message for other userspace actions. v10-v9 - Address Eelco Chaudron's comments on v9. v11-v10 - Fix a bracing error. v12-v11 - Add duplicate sample group id check. v13-v12 - Remove the psample poll thread from netdev-offload-tc and reuse ofproto handler thread according to Ilya's new desgin. - Add dpif-offload-provider layer according to Eli's suggestion. v14-v13 - Fix a robot error. v15-v14 - Address Eelco Chaudron's comments on v14. v16-v15 - Address Eelco Chaudron's comments on v15. - Add two test cases. v17-v16 - Address Eelco Chaudron's comments on v16. - Move struct dpif_offload_api from struct dpif_class to struct dpif. v18-v17 - Rename dpif_offload_api to dpif_offload_class. - Add init and destroy callbacks in dpif_offload_class. They are called when registering dpif_offload_class. v19-18 - Fix a bug that psample_sock is destroyed when last bridge is deleted. v20-19 - Move buf_stub to struct dpif_offload_sflow avoid garbage values when ofproto proceses the sampled packet. v21-20 - Remove netdev dummy for dpif-offload according to Eelco's comment. v22-21 - Address Ilya's comments: - Remove dpif-offload-provider layer. - Remove process_offload_sflow and reuse upcall_receive. - Introduce sample id pool. - Introduce netdev_offload_recv. v23-22 - Address Ilya's comments: - Add struct flow in struct dpif_upcall. - Add handler id in recv() and recv_wait(). - misc changes. v24-23 - Fix checkpath and actions errors. Chris Mi (8): compat: Add psample and tc sample action defines for older kernels ovs-kmod-ctl: Load kernel module psample netdev-offload-tc: Introduce group ID management API netdev-offload-tc: Add sFlow offload API for TC netdev-offload: Add netdev offload recv and recv_wait APIs dpif-netlink: Add netdev offload recv in normal recv upcalls netdev-offload-tc: Add offload support for sFlow system-offloads-traffic.at: Add sFlow offload test cases include/linux/automake.mk| 4 +- include/linux/psample.h | 62 +++ include/linux/tc_act/tc_sample.h | 25 ++ lib/dpif-netlink.c | 42 +- lib/dpif.h | 2 + lib/netdev-offload-provider.h| 14 + lib/netdev-offload-tc.c | 693 ++- lib/netdev-offload.c | 35 ++ lib/netdev-offload.h | 6 + lib/tc.c | 62 ++- lib/tc.h | 12 +- ofproto/ofproto-dpif-upcall.c| 16 +- tests/system-offloads-traffic.at | 101 + utilities/ovs-kmod-ctl.in| 14 + 14 files changed, 1057 insertions(+), 31 deletions(-) create mode 100644 include/linux/psample.h create mode 100644 include/linux/tc_act/tc_sample.h -- 2.26.3 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
