Re: [ovs-dev] [PATCH v5 3/5] ofproto: Fix mam page for tunnel related commands.
On 22 Feb 2023, at 11:29, Nobuhiro MIKI wrote:
> These commands already support both IPv4 and IPv6.
>
> Signed-off-by: Nobuhiro MIKI
> ---
> ofproto/ofproto-tnl-unixctl.man | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/ofproto/ofproto-tnl-unixctl.man b/ofproto/ofproto-tnl-unixctl.man
> index 13a465119a90..0c0a392820fb 100644
> --- a/ofproto/ofproto-tnl-unixctl.man
> +++ b/ofproto/ofproto-tnl-unixctl.man
> @@ -1,8 +1,8 @@
> .SS "OPENVSWITCH TUNNELING COMMANDS"
> These commands query and modify OVS tunnel components.
> .
> -.IP "\fBovs/route/add ipv4_address/plen output_bridge [GW]\fR"
> -Adds ipv4_address/plen route to vswitchd routing table. output_bridge
> +.IP "\fBovs/route/add ip/plen output_bridge [GW]\fR"
Here we still miss the pkt_mark option. Maybe we should also align the
parameter names with the ones in the in-app help.
534 unixctl_command_register("ovs/route/add",
535 "ip_addr/prefix_len out_br_name [gw] "
536 "[pkt_mark=mark]",
And/or update the in-app help.
> +Adds ip/plen route to vswitchd routing table. output_bridge
> needs to be OVS bridge name. This command is useful if OVS cached
> routes does not look right.
> .
> @@ -10,8 +10,8 @@ routes does not look right.
> Print all routes in OVS routing table, This includes routes cached
> from system routing table and user configured routes.
> .
> -.IP "\fBovs/route/del ipv4_address/plen\fR"
> -Delete ipv4_address/plen route from OVS routing table.
> +.IP "\fBovs/route/del ip/plen\fR"
> +Delete ip/plen route from OVS routing table.
> .
> .IP "\fBtnl/neigh/show\fR"
> .IP "\fBtnl/arp/show\fR"
> --
> 2.31.1
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v5 3/5] ofproto: Fix mam page for tunnel related commands.
On Wed, Feb 22, 2023 at 07:29:50PM +0900, Nobuhiro MIKI wrote: > These commands already support both IPv4 and IPv6. > > Signed-off-by: Nobuhiro MIKI Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v5 3/5] ofproto: Fix mam page for tunnel related commands.
These commands already support both IPv4 and IPv6. Signed-off-by: Nobuhiro MIKI --- ofproto/ofproto-tnl-unixctl.man | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ofproto/ofproto-tnl-unixctl.man b/ofproto/ofproto-tnl-unixctl.man index 13a465119a90..0c0a392820fb 100644 --- a/ofproto/ofproto-tnl-unixctl.man +++ b/ofproto/ofproto-tnl-unixctl.man @@ -1,8 +1,8 @@ .SS "OPENVSWITCH TUNNELING COMMANDS" These commands query and modify OVS tunnel components. . -.IP "\fBovs/route/add ipv4_address/plen output_bridge [GW]\fR" -Adds ipv4_address/plen route to vswitchd routing table. output_bridge +.IP "\fBovs/route/add ip/plen output_bridge [GW]\fR" +Adds ip/plen route to vswitchd routing table. output_bridge needs to be OVS bridge name. This command is useful if OVS cached routes does not look right. . @@ -10,8 +10,8 @@ routes does not look right. Print all routes in OVS routing table, This includes routes cached from system routing table and user configured routes. . -.IP "\fBovs/route/del ipv4_address/plen\fR" -Delete ipv4_address/plen route from OVS routing table. +.IP "\fBovs/route/del ip/plen\fR" +Delete ip/plen route from OVS routing table. . .IP "\fBtnl/neigh/show\fR" .IP "\fBtnl/arp/show\fR" -- 2.31.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
