Re: [ovs-dev] [RFC] [PATCH 4/6] port_group: ofproto: add port_group definition

2017-04-21 Thread Ben Pfaff 
On Mon, Apr 03, 2017 at 11:40:58AM +0200, Matthias May wrote:
> Signed-off-by: Matthias May 

"sparse" now additionally says:

../vswitchd/bridge.c:973:26: warning: incorrect type in assignment 
(different base types)
../vswitchd/bridge.c:973:26:expected restricted ofp_port_t [assigned] 
[usertype] port_group
../vswitchd/bridge.c:973:26:got unsigned int [unsigned] [usertype] 


which means that you should use u16_to_ofp() to convert the
configuration data into an ofp_port_t.

Thanks,

Ben.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [RFC] [PATCH 4/6] port_group: ofproto: add port_group definition

2017-04-03 Thread Matthias May 
Signed-off-by: Matthias May 
---
 ofproto/ofproto.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h
index 1e48e1952..29d7cdb91 100644
--- a/ofproto/ofproto.h
+++ b/ofproto/ofproto.h
@@ -402,6 +402,7 @@ struct ofproto_bundle_settings {
 ofp_port_t *slaves; /* OpenFlow port numbers for slaves. */
 size_t n_slaves;
 
+ofp_port_t port_group;  /* Group of ports to forbid loopback */
 enum port_vlan_mode vlan_mode; /* Selects mode for vlan and trunks */
 uint16_t qinq_ethtype;
 int vlan;   /* VLAN VID, except for PORT_VLAN_TRUNK. */
-- 
2.11.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev