Re: [ovs-dev] [dpdk-latest PATCH] sparse: Remove dpdk network headers copies.

2019-10-30 Thread Ben Pfaff
On Mon, Oct 28, 2019 at 10:00:45AM +0100, David Marchand wrote:
> Now that dpdk headers annotates the network header structures with
> endianness [1], we can get rid of these copies.
> 
> 1: https://git.dpdk.org/dpdk/commit/?id=7eca7f7fd09d

Oh, lovely.  I was never happy with those copies but they did allow for
a clean build with sparse.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


Re: [ovs-dev] [dpdk-latest PATCH] sparse: Remove dpdk network headers copies.

2019-10-30 Thread Stokes, Ian




On 10/28/2019 9:00 AM, David Marchand wrote:

Now that dpdk headers annotates the network header structures with
endianness [1], we can get rid of these copies.

1: https://git.dpdk.org/dpdk/commit/?id=7eca7f7fd09d

Signed-off-by: David Marchand 
---
  include/sparse/automake.mk |   6 -
  include/sparse/rte_esp.h   |  65 --
  include/sparse/rte_icmp.h  | 106 --
  include/sparse/rte_ip.h| 490 -
  include/sparse/rte_sctp.h  | 103 --
  include/sparse/rte_tcp.h   | 108 --
  include/sparse/rte_udp.h   | 103 --
  7 files changed, 981 deletions(-)
  delete mode 100644 include/sparse/rte_esp.h
  delete mode 100644 include/sparse/rte_icmp.h
  delete mode 100644 include/sparse/rte_ip.h
  delete mode 100644 include/sparse/rte_sctp.h
  delete mode 100644 include/sparse/rte_tcp.h
  delete mode 100644 include/sparse/rte_udp.h


Thanks for this David,

seems OK to me, tested locally and with travis CI. No issues seen.

https://travis-ci.org/istokes/ovs/builds/604905322

Please note I've re-based dpdk-latest with master for this testing. I'm 
going to push the re-based dpdk-latest branch today along with this 
patch as DPDK 19.11 RC1 is now available.


Regards
Ian
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [dpdk-latest PATCH] sparse: Remove dpdk network headers copies.

2019-10-28 Thread David Marchand
Now that dpdk headers annotates the network header structures with
endianness [1], we can get rid of these copies.

1: https://git.dpdk.org/dpdk/commit/?id=7eca7f7fd09d

Signed-off-by: David Marchand 
---
 include/sparse/automake.mk |   6 -
 include/sparse/rte_esp.h   |  65 --
 include/sparse/rte_icmp.h  | 106 --
 include/sparse/rte_ip.h| 490 -
 include/sparse/rte_sctp.h  | 103 --
 include/sparse/rte_tcp.h   | 108 --
 include/sparse/rte_udp.h   | 103 --
 7 files changed, 981 deletions(-)
 delete mode 100644 include/sparse/rte_esp.h
 delete mode 100644 include/sparse/rte_icmp.h
 delete mode 100644 include/sparse/rte_ip.h
 delete mode 100644 include/sparse/rte_sctp.h
 delete mode 100644 include/sparse/rte_tcp.h
 delete mode 100644 include/sparse/rte_udp.h

diff --git a/include/sparse/automake.mk b/include/sparse/automake.mk
index 8f3e12d..073631e 100644
--- a/include/sparse/automake.mk
+++ b/include/sparse/automake.mk
@@ -1,11 +1,5 @@
 noinst_HEADERS += \
 include/sparse/rte_byteorder.h \
-include/sparse/rte_esp.h \
-include/sparse/rte_icmp.h \
-include/sparse/rte_ip.h \
-include/sparse/rte_sctp.h \
-include/sparse/rte_tcp.h \
-include/sparse/rte_udp.h \
 include/sparse/xmmintrin.h \
 include/sparse/arpa/inet.h \
 include/sparse/bits/floatn.h \
diff --git a/include/sparse/rte_esp.h b/include/sparse/rte_esp.h
deleted file mode 100644
index 7491074..000
--- a/include/sparse/rte_esp.h
+++ /dev/null
@@ -1,65 +0,0 @@
-/*-
- *   BSD LICENSE
- *
- *   Copyright (c) 2016-2017, Mellanox Technologies. All rights reserved.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of Intel Corporation nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#ifndef __CHECKER__
-#error "Use this header only with sparse.  It is not a correct implementation."
-#endif
-
-#ifndef _RTE_ESP_H_
-#define _RTE_ESP_H_
-
-/**
- * @file
- *
- * ESP-related defines
- */
-
-#include "openvswitch/types.h"
-#include 
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
-/**
- * ESP Header
- */
-struct rte_esp_hdr {
-   ovs_be32 spi;  /**< Security Parameters Index */
-   ovs_be32 seq;  /**< packet sequence number */
-} __attribute__((__packed__));
-
-#ifdef __cplusplus
-}
-#endif
-
-#endif /* RTE_ESP_H_ */
diff --git a/include/sparse/rte_icmp.h b/include/sparse/rte_icmp.h
deleted file mode 100644
index f4844ed..000
--- a/include/sparse/rte_icmp.h
+++ /dev/null
@@ -1,106 +0,0 @@
-/*   BSD LICENSE
- *
- *   Copyright(c) 2013 6WIND.
- *
- *   Redistribution and use in source and binary forms, with or without
- *   modification, are permitted provided that the following conditions
- *   are met:
- *
- * * Redistributions of source code must retain the above copyright
- *   notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- *   notice, this list of conditions and the following disclaimer in
- *   the documentation and/or other materials provided with the
- *   distribution.
- * * Neither the name of 6WIND S.A. nor the names of its
- *   contributors may be used to endorse or promote products derived
- *   from this software without specific prior written permission.
- *
- *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT