Re: [ovs-dev] 回复: [PATCH v2 1/1] net: openvswitch: reduce cpu_used_mask memory
On Wed, 1 Feb 2023 21:35:15 -0800 Jakub Kicinski wrote: > On Thu, 2 Feb 2023 05:09:51 + 陶 缘 wrote: > > I guest you are pointing to the field "From: taoyuan_e...@hotmail.com" in > > the patch header linked from "Headers show" section in the patch page > > > > > > https://patchwork.kernel.org/project/netdevbpf/patch/os3p286mb22954422e3dd09ff5fd6b091f5...@os3p286mb2295.jpnp286.prod.outlook.com/ > > > > I will fix that accordingly. > > The From is correct, please look at the entire email Jiri also > commented about the code. > > Two more notes: > - don't top post on the list > - reply in plain text not HTML One more thing, please make sure you read the process information for Linux networking: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] 回复: [PATCH v2 1/1] net: openvswitch: reduce cpu_used_mask memory
On Thu, 2 Feb 2023 05:09:51 + 陶 缘 wrote: > I guest you are pointing to the field "From: taoyuan_e...@hotmail.com" in the > patch header linked from "Headers show" section in the patch page > > > https://patchwork.kernel.org/project/netdevbpf/patch/os3p286mb22954422e3dd09ff5fd6b091f5...@os3p286mb2295.jpnp286.prod.outlook.com/ > > I will fix that accordingly. The From is correct, please look at the entire email Jiri also commented about the code. Two more notes: - don't top post on the list - reply in plain text not HTML ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] 回复: [PATCH v2 1/1] net: openvswitch: reduce cpu_used_mask memory
Hi, Jiri: I guest you are pointing to the field "From: taoyuan_e...@hotmail.com" in the patch header linked from "Headers show" section in the patch page https://patchwork.kernel.org/project/netdevbpf/patch/os3p286mb22954422e3dd09ff5fd6b091f5...@os3p286mb2295.jpnp286.prod.outlook.com/ I will fix that accordingly. Thanks for your time eddy 发件人: Jiri Pirko 发送时间: 2023年2月1日 13:44 收件人: taoyuan_e...@hotmail.com 抄送: net...@vger.kernel.org ; Pravin B Shelar ; David S. Miller ; Eric Dumazet ; Jakub Kicinski ; Paolo Abeni ; d...@openvswitch.org ; linux-ker...@vger.kernel.org 主题: Re: [PATCH v2 1/1] net: openvswitch: reduce cpu_used_mask memory Wed, Feb 01, 2023 at 02:24:39PM CET, taoyuan_e...@hotmail.com wrote: >From: Eddy Tao > >'struct cpumask cpu_used_mask' is embedded in struct sw_flow. >However, its size is hardcoded to CONFIG_NR_CPUS bits, which can be >8192 by default, it costs memory and slows down ovs_flow_alloc. >This fix uses actual CPU number instead > >Signed-off-by: Eddy Tao Eddy, looks like you missed my second comment to v1. Could you please check again? Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] 回复: [PATCH v2 1/1] net: openvswitch: reduce cpu_used_mask memory
Hi, Jiri: I looked into v2 content, both "From" field and "Signed-off-by" field are 'Eddy Tao' now, in the CC list, 'Eddy Tao' was also placed automatically/correctly >>Hmm, I guess that the name should be rather "Dddy Taoyuan" ? Please fix, ==> >>this is point 1 I guess and it has been fixed in v2 >>also in your "From:" header and preferably email client. ===> this is point 2 >>==> i think "git config --global user.name="Eddy Tao" also worked for this >>point More about 'email client', smtp-mail.outlook.com is the smtp server and git send-email directs the patch file to to the recipients. I did not have further email client settings regarding to name spelling. Could you clarify more about the 'email client' part? Thanks eddy 发件人: Jiri Pirko 发送时间: 2023年2月1日 13:44 收件人: taoyuan_e...@hotmail.com 抄送: net...@vger.kernel.org ; Pravin B Shelar ; David S. Miller ; Eric Dumazet ; Jakub Kicinski ; Paolo Abeni ; d...@openvswitch.org ; linux-ker...@vger.kernel.org 主题: Re: [PATCH v2 1/1] net: openvswitch: reduce cpu_used_mask memory Wed, Feb 01, 2023 at 02:24:39PM CET, taoyuan_e...@hotmail.com wrote: >From: Eddy Tao > >'struct cpumask cpu_used_mask' is embedded in struct sw_flow. >However, its size is hardcoded to CONFIG_NR_CPUS bits, which can be >8192 by default, it costs memory and slows down ovs_flow_alloc. >This fix uses actual CPU number instead > >Signed-off-by: Eddy Tao Eddy, looks like you missed my second comment to v1. Could you please check again? Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
