Re: [ovs-dev] vlog: Destroy async_append first then close log_fd.

2024-05-17 Thread Ilya Maximets 
On 5/15/24 18:01, Simon Horman wrote:
> On Wed, May 15, 2024 at 11:28:21AM +0800, hepeng via dev wrote:
>> From: Peng He 
>>
>> async_append stores log_fd, it should be destructed before log_fd
>> is closed.
>>
>> Signed-off-by: Peng He 
> 
> Acked-by: Simon Horman 
> 

Applied to main and backported down to 2.17.

Thanks!

Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] vlog: Destroy async_append first then close log_fd.

2024-05-15 Thread Simon Horman 
On Wed, May 15, 2024 at 11:28:21AM +0800, hepeng via dev wrote:
> From: Peng He 
> 
> async_append stores log_fd, it should be destructed before log_fd
> is closed.
> 
> Signed-off-by: Peng He 

Acked-by: Simon Horman 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] vlog: Destroy async_append first then close log_fd.

2024-05-14 Thread hepeng via dev 
From: Peng He 

async_append stores log_fd, it should be destructed before log_fd
is closed.

Signed-off-by: Peng He 
---
 lib/vlog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vlog.c b/lib/vlog.c
index e78c785f7..59b524b09 100644
--- a/lib/vlog.c
+++ b/lib/vlog.c
@@ -411,10 +411,10 @@ vlog_set_log_file__(char *new_log_file_name)
 
 /* Close old log file, if any. */
 ovs_mutex_lock(_file_mutex);
+async_append_destroy(log_writer);
 if (log_fd >= 0) {
 close(log_fd);
 }
-async_append_destroy(log_writer);
 free(log_file_name);
 
 /* Install new log file. */
-- 
2.39.2

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev