Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-19 Thread Joe Stringer 
On 18 July 2017 at 15:53, Joe Stringer  wrote:
> On 10 July 2017 at 12:39, Eric Garver  wrote:
>> This series enables support for layer3 tunnels VXLAN-GPE and GRE in the 
>> kernel
>> datapath. It includes new system-traffic test cases. The first two patches 
>> fix
>> an issue translating packet_type from flows for the kernel.
>>
>> Note: VXLAN-GPE depends on a fix recently posted to the list.
>> https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/334788.html
>
> Thanks a lot for this work, Eric! It's nice to get some more coverage
> on this packet_type handling code.
>
> I've reviewed patches 1-2 and suggested another approach, once we
> figure that part out I'd be happy to apply the rest of the series.

I applied that series, then patches 3-10 of this series to master. Thanks Eric!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-18 Thread Joe Stringer 
On 10 July 2017 at 12:39, Eric Garver  wrote:
> This series enables support for layer3 tunnels VXLAN-GPE and GRE in the kernel
> datapath. It includes new system-traffic test cases. The first two patches fix
> an issue translating packet_type from flows for the kernel.
>
> Note: VXLAN-GPE depends on a fix recently posted to the list.
> https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/334788.html

Thanks a lot for this work, Eric! It's nice to get some more coverage
on this packet_type handling code.

I've reviewed patches 1-2 and suggested another approach, once we
figure that part out I'd be happy to apply the rest of the series.

Cheers,
Joe
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-12 Thread thomas.morin 

On 7/12/17 2:17 PM, Thomas Morin wrote:
However, as per our discussion on irc yesterday [1], I wasn't able to 
have this working (issue on reception) on an 4.8.x kernel, even with 
the openvswitch kernel module provided with OVS. Is it possible that 
another kernel fix/modification is needed that is not in 4.8.x ?


Forget the above: I did the test again, and on a kernel 4.8 with the 
openvswitch kernel module provided with OVS (in my case DKMS compiled), 
I could observe properly receive and transmit for standarad compliant 
MPLS-over-GRE.


Again, it is great to this ready, with the last pieces now very close to 
merge (I hope/guess).

Congrats and many thanks to all the people involved !

-Thomas







Eric Garver (10):
   netlink: Add function to filter nlattrs
   dpif-netlink: For non-Ethernet, use Ethertype from packet_type
   dpif-netlink-rtnl: Support VXLAN-GPE
   dpif-netlink-rtnl: Support layer3 GRE
   system-common-macros: Allow passing config to ADD_OVS_TUNNEL
   system-common-macros: Add macro to check for ip-route encap support
   system-common-macros: Add macro to check for VXLAN-GPE support
   system-layer3-tunnels: Add basic VXLAN-GPE ping test case
   system-common-macros: Add macro to check for L3 GRE support
   system-layer3-tunnels: Add basic GRE ping test case

  lib/dpif-netlink-rtnl.c | 34 +
  lib/dpif-netlink.c  | 48 --
  lib/netlink.c   | 20 
  lib/netlink.h   |  1 +
  tests/automake.mk   |  1 +
  tests/system-common-macros.at   | 21 ++--
  tests/system-kmod-testsuite.at  |  1 +
  tests/system-layer3-tunnels.at  | 99 
+

  tests/system-userspace-testsuite.at |  1 +
  9 files changed, 197 insertions(+), 29 deletions(-)
  create mode 100644 tests/system-layer3-tunnels.at

--
2.12.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev



_

Ce message et ses pieces jointes peuvent contenir des informations 
confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce 
message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages 
electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou 
falsifie. Merci.

This message and its attachments may contain confidential or privileged 
information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete 
this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been 
modified, changed or falsified.
Thank you.

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-12 Thread Eric Garver 
On Wed, Jul 12, 2017 at 02:17:38PM +0200, Thomas Morin wrote:
> Hi Eric,
> 
> > 2017-07-11, Eric Garver:
> > > Inserting an important note for reviewers/testers.
> [...]
> > > 
> > > Note: This depends on vport-netdev changes to allow L3 netdev ports,
> > > kernel commit 217ac77a3c25 ("openvswitch: allow L3 netdev ports"). So
> > > you either need a 4.10+ kernel or use the modules provided with OVS.
> 
> 
> I was able to successfully do MPLS/GRE (without TEB, ie.
> options:packet_type=legacy_l3) with this patch series, on a 4.11 kernel with
> the openvswitch kernel module provided with OVS (DKMS compiled), and with
> the kernel openvswitch module as well.
> 
> It is really great to this this work today!
> 
> However, as per our discussion on irc yesterday [1], I wasn't able to have
> this working (issue on reception) on an 4.8.x kernel, even with the
> openvswitch kernel module provided with OVS. Is it possible that another
> kernel fix/modification is needed that is not in 4.8.x ?

I tried it on 4.8.17 with the OVS modules. Test cases pass on my setup.

Some things you can check:

1) make sure you're loading the right OVS modules.

2) make sure OVS is using the upstream modules. This is required to
   use the rtnetlink interface and therefore layer3 support.

$ grep USE_UPSTREAM_TUNNEL datapath/linux/kcompat.h
#define USE_UPSTREAM_TUNNEL 1

3) You'll also need to have the ip_gre modules available in your
   kernel. If they're not there then OVS fails back to the
   old/compat interface which doesn't support layer3 tunnels.


--->8---


# uname -a
Linux dev-rhel7 4.8.17 #21 SMP Tue Jul 11 11:31:40 EDT 2017 x86_64 x86_64 
x86_64 GNU/Linux

# make -j3 check-kmod TESTSUITEFLAGS="81 82"
...snip...
## -- ##
## openvswitch 2.7.90 test suite. ##
## -- ##

layer3-tunnels

 81: layer3 - ping over VXLAN-GPEok
 82: layer3 - ping over GRE  ok

## - ##
## Test results. ##
## - ##

All 2 tests were successful.

> 
> -Thomas
> 
> [1] https://botbot.me/freenode/openvswitch/2017-07-11/?msg=88419890=1
> 
> > 
> > > 
> > > Eric Garver (10):
> > >netlink: Add function to filter nlattrs
> > >dpif-netlink: For non-Ethernet, use Ethertype from packet_type
> > >dpif-netlink-rtnl: Support VXLAN-GPE
> > >dpif-netlink-rtnl: Support layer3 GRE
> > >system-common-macros: Allow passing config to ADD_OVS_TUNNEL
> > >system-common-macros: Add macro to check for ip-route encap support
> > >system-common-macros: Add macro to check for VXLAN-GPE support
> > >system-layer3-tunnels: Add basic VXLAN-GPE ping test case
> > >system-common-macros: Add macro to check for L3 GRE support
> > >system-layer3-tunnels: Add basic GRE ping test case
> > > 
> > >   lib/dpif-netlink-rtnl.c | 34 +
> > >   lib/dpif-netlink.c  | 48 --
> > >   lib/netlink.c   | 20 
> > >   lib/netlink.h   |  1 +
> > >   tests/automake.mk   |  1 +
> > >   tests/system-common-macros.at   | 21 ++--
> > >   tests/system-kmod-testsuite.at  |  1 +
> > >   tests/system-layer3-tunnels.at  | 99 
> > > +
> > >   tests/system-userspace-testsuite.at |  1 +
> > >   9 files changed, 197 insertions(+), 29 deletions(-)
> > >   create mode 100644 tests/system-layer3-tunnels.at
> > > 
> > > -- 
> > > 2.12.0
> > > 
> > > ___
> > > dev mailing list
> > > d...@openvswitch.org
> > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-12 Thread Thomas Morin 

Hi Eric,


2017-07-11, Eric Garver:

Inserting an important note for reviewers/testers.

[...]


Note: This depends on vport-netdev changes to allow L3 netdev ports,
kernel commit 217ac77a3c25 ("openvswitch: allow L3 netdev ports"). So
you either need a 4.10+ kernel or use the modules provided with OVS.



I was able to successfully do MPLS/GRE (without TEB, ie. 
options:packet_type=legacy_l3) with this patch series, on a 4.11 kernel 
with the openvswitch kernel module provided with OVS (DKMS compiled), 
and with the kernel openvswitch module as well.


It is really great to this this work today!

However, as per our discussion on irc yesterday [1], I wasn't able to 
have this working (issue on reception) on an 4.8.x kernel, even with the 
openvswitch kernel module provided with OVS. Is it possible that another 
kernel fix/modification is needed that is not in 4.8.x ?


-Thomas

[1] https://botbot.me/freenode/openvswitch/2017-07-11/?msg=88419890=1





Eric Garver (10):
   netlink: Add function to filter nlattrs
   dpif-netlink: For non-Ethernet, use Ethertype from packet_type
   dpif-netlink-rtnl: Support VXLAN-GPE
   dpif-netlink-rtnl: Support layer3 GRE
   system-common-macros: Allow passing config to ADD_OVS_TUNNEL
   system-common-macros: Add macro to check for ip-route encap support
   system-common-macros: Add macro to check for VXLAN-GPE support
   system-layer3-tunnels: Add basic VXLAN-GPE ping test case
   system-common-macros: Add macro to check for L3 GRE support
   system-layer3-tunnels: Add basic GRE ping test case

  lib/dpif-netlink-rtnl.c | 34 +
  lib/dpif-netlink.c  | 48 --
  lib/netlink.c   | 20 
  lib/netlink.h   |  1 +
  tests/automake.mk   |  1 +
  tests/system-common-macros.at   | 21 ++--
  tests/system-kmod-testsuite.at  |  1 +
  tests/system-layer3-tunnels.at  | 99 +
  tests/system-userspace-testsuite.at |  1 +
  9 files changed, 197 insertions(+), 29 deletions(-)
  create mode 100644 tests/system-layer3-tunnels.at

--
2.12.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-11 Thread Eric Garver 
Inserting an important note for reviewers/testers.

On Mon, Jul 10, 2017 at 03:39:50PM -0400, Eric Garver wrote:
> This series enables support for layer3 tunnels VXLAN-GPE and GRE in the kernel
> datapath. It includes new system-traffic test cases. The first two patches fix
> an issue translating packet_type from flows for the kernel.
> 
> Note: VXLAN-GPE depends on a fix recently posted to the list.
> https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/334788.html

Note: This depends on vport-netdev changes to allow L3 netdev ports,
kernel commit 217ac77a3c25 ("openvswitch: allow L3 netdev ports"). So
you either need a 4.10+ kernel or use the modules provided with OVS.

> 
> Eric Garver (10):
>   netlink: Add function to filter nlattrs
>   dpif-netlink: For non-Ethernet, use Ethertype from packet_type
>   dpif-netlink-rtnl: Support VXLAN-GPE
>   dpif-netlink-rtnl: Support layer3 GRE
>   system-common-macros: Allow passing config to ADD_OVS_TUNNEL
>   system-common-macros: Add macro to check for ip-route encap support
>   system-common-macros: Add macro to check for VXLAN-GPE support
>   system-layer3-tunnels: Add basic VXLAN-GPE ping test case
>   system-common-macros: Add macro to check for L3 GRE support
>   system-layer3-tunnels: Add basic GRE ping test case
> 
>  lib/dpif-netlink-rtnl.c | 34 +
>  lib/dpif-netlink.c  | 48 --
>  lib/netlink.c   | 20 
>  lib/netlink.h   |  1 +
>  tests/automake.mk   |  1 +
>  tests/system-common-macros.at   | 21 ++--
>  tests/system-kmod-testsuite.at  |  1 +
>  tests/system-layer3-tunnels.at  | 99 
> +
>  tests/system-userspace-testsuite.at |  1 +
>  9 files changed, 197 insertions(+), 29 deletions(-)
>  create mode 100644 tests/system-layer3-tunnels.at
> 
> -- 
> 2.12.0
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev