Re: [ovs-dev] [PATCH 3/3] tests: Add tests for performance library module

2018-03-01 Thread Jakub Sitnicki 
On Wed, 28 Feb 2018 13:36:34 -0800
Ben Pfaff  wrote:

> On Wed, Feb 28, 2018 at 03:17:15PM +0100, Jakub Sitnicki wrote:
> > Check if performance module is calculating statistics as expected.
> > 
> > Outputs that are currently not as expected have been annotated with FIXME.
> > 
> > Signed-off-by: Jakub Sitnicki   
> 
> Clang does not like one piece of code:
> 
> ../tests/test-performance.c:135:46: error: missing field 'unit' initializer 
> [-Werror,-Wmissing-field-initializers]
> 
> "sparse" pointed out that variables should be "static":
> 
> ../tests/test-performance.c:36:18: error: symbol 'data_sets' was not 
> declared. Should it be static?

Thank you for reporting these errors.

I will correct them and coordinate with Mark.

-Jakub
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/3] tests: Add tests for performance library module

2018-02-28 Thread Ben Pfaff 
On Wed, Feb 28, 2018 at 03:17:15PM +0100, Jakub Sitnicki wrote:
> Check if performance module is calculating statistics as expected.
> 
> Outputs that are currently not as expected have been annotated with FIXME.
> 
> Signed-off-by: Jakub Sitnicki 

Clang does not like one piece of code:

../tests/test-performance.c:135:46: error: missing field 'unit' initializer 
[-Werror,-Wmissing-field-initializers]

"sparse" pointed out that variables should be "static":

../tests/test-performance.c:36:18: error: symbol 'data_sets' was not declared. 
Should it be static?
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev