Re: [ovs-dev] [PATCH net 0/3] net/sched: Fix ct zone matching for invalid conntrack state
On Thu, 9 Dec 2021, Jakub Kicinski wrote: > On Wed, 8 Dec 2021 19:02:37 +0200 Paul Blakey wrote: > > Currently, when a packet is marked as invalid conntrack_in in act_ct, > > post_ct will be set, and connection info (nf_conn) will be removed > > from the skb. Later openvswitch and flower matching will parse this > > as ct_state=+trk+inv. But because the connection info is missing, > > there is also no zone info to match against even though the packet > > is tracked. > > > > This series fixes that, by passing the last executed zone by act_ct. > > The zone info is passed along from act_ct to the ct flow dissector > > (used by flower to extract zone info) and to ovs, the same way as post_ct > > is passed, via qdisc layer skb cb to dissector, and via skb extension > > to OVS. > > > > Since there was no more for BPF skb cb to extend the qdisc skb cb, > > tc info on the qdisc skb cb is moved to a tc specific cb that extend it > > instead of within it (same as BPF). > > The last paragraph is missing words. > > Please repost and cast a wider net for reviewers, you must CC blamed > authors. > sure, posted v2. Thanks ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net 0/3] net/sched: Fix ct zone matching for invalid conntrack state
On Wed, 8 Dec 2021 19:02:37 +0200 Paul Blakey wrote: > Currently, when a packet is marked as invalid conntrack_in in act_ct, > post_ct will be set, and connection info (nf_conn) will be removed > from the skb. Later openvswitch and flower matching will parse this > as ct_state=+trk+inv. But because the connection info is missing, > there is also no zone info to match against even though the packet > is tracked. > > This series fixes that, by passing the last executed zone by act_ct. > The zone info is passed along from act_ct to the ct flow dissector > (used by flower to extract zone info) and to ovs, the same way as post_ct > is passed, via qdisc layer skb cb to dissector, and via skb extension > to OVS. > > Since there was no more for BPF skb cb to extend the qdisc skb cb, > tc info on the qdisc skb cb is moved to a tc specific cb that extend it > instead of within it (same as BPF). The last paragraph is missing words. Please repost and cast a wider net for reviewers, you must CC blamed authors. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
