Re: [ovs-dev] [PATCH ovn] Fix typo in README.
On 4/18/24 14:10, Dumitru Ceara wrote: > From: Kacper Kamiński > > Submitted-at: https://github.com/ovn-org/ovn/pull/138 > Signed-off-by: Kacper Kamiński > Signed-off-by: Dumitru Ceara > --- Applied to main. I also added Kacper to the AUTHORS list. Best regards, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
On Mon, Jul 11, 2022 at 4:35 AM Dumitru Ceara wrote: > > On 7/11/22 11:23, Igor Zhukov wrote: > > From: Igor Zhukov > > > > Signed-off-by: Igor Zhukov > > Acked-by: Dumitru Ceara > > --- Thanks for the fix. I applied this patch to the main branch. I also added your name to the AUTHORS.rst file. Numan > > This patch looks good to me and it applies fine. > > Thanks! > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
You're welcome! I sent this patch via `git send-email` :) ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
On 7/11/22 11:23, Igor Zhukov wrote: > From: Igor Zhukov > > Signed-off-by: Igor Zhukov > Acked-by: Dumitru Ceara > --- This patch looks good to me and it applies fine. Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 21 error: could not build fake ancestor hint: Use 'git am --show-current-patch' to see the failed patch Patch failed at 0001 fix typo When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
Bleep bloop. Greetings Igor Zhukov, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Igor Zhukov needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Igor Zhukov Lines checked: 27, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
On 7/8/22 17:32, Zhukov Igor wrote: > Thank you Aaron Conole! > Sorry for so many attempts for such simple patch . > I think I know one reason why this issue might be: I sent this email from my > home email: fsb4...@yandex.ru > > I also resent the patch from my work email, but I can't change my name and it > is in russian. > > Жуков Игорь > > Is it ok? or "Signed-off-by" shoud be exactly match? The "From:" header and the "Signed-off-by:" should generally match to not trigger checkpatch failures. You should try using 'git send-email' instead of your normal email client to send patches. It should save you from most of the issues. For example, it will add an extra 'From:' header for you in case the email you're sending from doesn't match with the patch author. Sending emails to yourself first to make sure that they are OK is also a good practice. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
Bleep bloop. Greetings Жуков Игорь, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Жуков Игорь needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Igor Zhukov Lines checked: 27, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
Thank you Aaron Conole! Sorry for so many attempts for such simple patch . I think I know one reason why this issue might be: I sent this email from my home email: fsb4...@yandex.ru I also resent the patch from my work email, but I can't change my name and it is in russian. Жуков Игорь Is it ok? or "Signed-off-by" shoud be exactly match? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
Dumitru Ceara writes: > On 7/8/22 08:21, Zhukov Igor wrote: >> I looked at >> https://github.com/ovn-org/ovn/commit/23e203a3f30bd57ef8d0def7ee2698e588782d0c >> Found fixed typo: "webserer" => "webserver" >> I decided to grep "webserer" and found another such word. > > Hi Igor, > > Thanks for the patch! > >> >> From b1d7d16289ffa28f76c4a7803e369a5e287ffdc5 Mon Sep 17 00:00:00 2001 >> From: Igor Zhukov >> Date: Fri, 8 Jul 2022 00:40:42 +0700 >> Subject: [PATCH ovn] fix typo > > This should not be part of the commit message, it breaks the patch > format and causes: > > $ git am /tmp/git-pwtngnq9u1/ovs-dev-fix-typo.patch > Patch is empty. > > Removing these lines fixes the patch format. > > Also, I think this confuses 0-day robot (cc Aaron) which wrongfully > reports a green CI [0] [1] run even though the patch never really got > applied [2]: > > [0] https://mail.openvswitch.org/pipermail/ovs-build/2022-July/023384.html > [1] https://github.com/ovsrobot/ovn/actions/runs/2634362231 > > [2] https://github.com/ovsrobot/ovn/tree/series_308632 > > For this specific case it's not an issue, the patch is obviously correct > but we might want to avoid potential future false negatives for other > patches. This is a difficult to detect situation. I will look at it. >> >> Signed-off-by: Igor Zhukov >> --- > > If you remove the 4 lines in the wrongfully formated patch then please > also include my ack: > > Acked-by: Dumitru Ceara > > Thanks! > >> tests/system-ovn.at | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/system-ovn.at b/tests/system-ovn.at >> index 1cabf1f31..4a8fdede8 100644 >> --- a/tests/system-ovn.at >> +++ b/tests/system-ovn.at >> @@ -4505,7 +4505,7 @@ ovn-sbctl list service_monitor >> OVS_WAIT_UNTIL([test 2 = `ovn-sbctl --bare --columns status find \ >> service_monitor protocol=udp | sed '/^$/d' | grep offline | wc -l`]) >> >> -# Stop webserer in sw1-p1 >> +# Stop webserver in sw1-p1 >> pid_file=$(cat l7_pid_file) >> NS_CHECK_EXEC([sw1-p1], [kill $(cat $pid_file)]) >> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
Bleep bloop. Greetings Zhukov Igor, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Zhukov Igor needs to sign off. WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Igor Zhukov Lines checked: 27, Warnings: 1, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
Bleep bloop. Greetings Zhukov Igor, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: corrupt patch at line 21 error: could not build fake ancestor hint: Use 'git am --show-current-patch' to see the failed patch Patch failed at 0001 fix typo When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] fix typo
On 7/8/22 08:21, Zhukov Igor wrote: > I looked at > https://github.com/ovn-org/ovn/commit/23e203a3f30bd57ef8d0def7ee2698e588782d0c > Found fixed typo: "webserer" => "webserver" > I decided to grep "webserer" and found another such word. Hi Igor, Thanks for the patch! > > From b1d7d16289ffa28f76c4a7803e369a5e287ffdc5 Mon Sep 17 00:00:00 2001 > From: Igor Zhukov > Date: Fri, 8 Jul 2022 00:40:42 +0700 > Subject: [PATCH ovn] fix typo This should not be part of the commit message, it breaks the patch format and causes: $ git am /tmp/git-pwtngnq9u1/ovs-dev-fix-typo.patch Patch is empty. Removing these lines fixes the patch format. Also, I think this confuses 0-day robot (cc Aaron) which wrongfully reports a green CI [0] [1] run even though the patch never really got applied [2]: [0] https://mail.openvswitch.org/pipermail/ovs-build/2022-July/023384.html [1] https://github.com/ovsrobot/ovn/actions/runs/2634362231 [2] https://github.com/ovsrobot/ovn/tree/series_308632 For this specific case it's not an issue, the patch is obviously correct but we might want to avoid potential future false negatives for other patches. > > Signed-off-by: Igor Zhukov > --- If you remove the 4 lines in the wrongfully formated patch then please also include my ack: Acked-by: Dumitru Ceara Thanks! > tests/system-ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index 1cabf1f31..4a8fdede8 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -4505,7 +4505,7 @@ ovn-sbctl list service_monitor > OVS_WAIT_UNTIL([test 2 = `ovn-sbctl --bare --columns status find \ > service_monitor protocol=udp | sed '/^$/d' | grep offline | wc -l`]) > > -# Stop webserer in sw1-p1 > +# Stop webserver in sw1-p1 > pid_file=$(cat l7_pid_file) > NS_CHECK_EXEC([sw1-p1], [kill $(cat $pid_file)]) > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] Fix typo for validation of logical ip in ipv6 mode.
On Fri, May 8, 2020 at 12:49 PM wrote:
> From: Artem Teleshev
>
> Reported-at: https://github.com/ovn-org/ovn/issues/42
> Submitted-at: https://github.com/ovn-org/ovn/pull/43
> Signed-off-by: Artem Teleshev
> Signed-off-by: Numan Siddique
> ---
>
Thanks for the patch Artem. It was a good catch.
I applied this patch to master and branch-20.03.
Numan
> northd/ovn-northd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> index 83e6134b0..76b4a14ee 100644
> --- a/northd/ovn-northd.c
> +++ b/northd/ovn-northd.c
> @@ -8845,7 +8845,7 @@ build_lrouter_flows(struct hmap *datapaths, struct
> hmap *ports,
> /* Check the validity of nat->logical_ip. 'logical_ip' can
> * be a subnet when the type is "snat". */
> if (is_v6) {
> -error = ipv6_parse_masked(nat->external_ip, ,
> _v6);
> +error = ipv6_parse_masked(nat->logical_ip, ,
> _v6);
> } else {
> error = ip_parse_masked(nat->logical_ip, , );
> }
> --
> 2.26.2
>
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
