Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: avoid successive ct_clear datapath actions
On 3/16/22 15:08, Eelco Chaudron wrote: > > > On 14 Jul 2021, at 14:33, Eelco Chaudron wrote: > >> On 8 Jul 2021, at 21:21, Ilya Maximets wrote: >> >>> On 5/24/21 2:39 PM, Timothy Redaelli wrote: On Tue, 18 May 2021 06:17:48 -0400 Eelco Chaudron wrote: > Due to flow lookup optimizations, especially in the resubmit/clone cases, > we might end up with multiple ct_clear actions, which are not necessary. > > This patch only adds the ct_clear action to the datapath if any ct state > is tracked. > > Signed-off-by: Eelco Chaudron > --- > v2: Insert ct_clear only when ct information is tracked vs tracking > successive > ct_clear actions. > > ofproto/ofproto-dpif-xlate.c |4 +++- > tests/ofproto-dpif.at| 25 + > 2 files changed, 28 insertions(+), 1 deletion(-) Acked-By: Timothy Redaelli >>> >>> Thanks! Applied. >> >> Can this also be backported to the stable releases? > > Guess this email might have gone missing. Can we still get this backported to > make hw offload work better? Oops. Backported down to 2.13 now. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: avoid successive ct_clear datapath actions
On 14 Jul 2021, at 14:33, Eelco Chaudron wrote: > On 8 Jul 2021, at 21:21, Ilya Maximets wrote: > >> On 5/24/21 2:39 PM, Timothy Redaelli wrote: >>> On Tue, 18 May 2021 06:17:48 -0400 >>> Eelco Chaudron wrote: >>> Due to flow lookup optimizations, especially in the resubmit/clone cases, we might end up with multiple ct_clear actions, which are not necessary. This patch only adds the ct_clear action to the datapath if any ct state is tracked. Signed-off-by: Eelco Chaudron --- v2: Insert ct_clear only when ct information is tracked vs tracking successive ct_clear actions. ofproto/ofproto-dpif-xlate.c |4 +++- tests/ofproto-dpif.at| 25 + 2 files changed, 28 insertions(+), 1 deletion(-) >>> >>> >>> Acked-By: Timothy Redaelli >>> >> >> Thanks! Applied. > > Can this also be backported to the stable releases? Guess this email might have gone missing. Can we still get this backported to make hw offload work better? Thanks, Eelco ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: avoid successive ct_clear datapath actions
On 8 Jul 2021, at 21:21, Ilya Maximets wrote: > On 5/24/21 2:39 PM, Timothy Redaelli wrote: >> On Tue, 18 May 2021 06:17:48 -0400 >> Eelco Chaudron wrote: >> >>> Due to flow lookup optimizations, especially in the resubmit/clone cases, >>> we might end up with multiple ct_clear actions, which are not necessary. >>> >>> This patch only adds the ct_clear action to the datapath if any ct state >>> is tracked. >>> >>> Signed-off-by: Eelco Chaudron >>> --- >>> v2: Insert ct_clear only when ct information is tracked vs tracking >>> successive >>> ct_clear actions. >>> >>> ofproto/ofproto-dpif-xlate.c |4 +++- >>> tests/ofproto-dpif.at| 25 + >>> 2 files changed, 28 insertions(+), 1 deletion(-) >> >> >> Acked-By: Timothy Redaelli >> > > Thanks! Applied. Can this also be backported to the stable releases? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: avoid successive ct_clear datapath actions
On 5/24/21 2:39 PM, Timothy Redaelli wrote: > On Tue, 18 May 2021 06:17:48 -0400 > Eelco Chaudron wrote: > >> Due to flow lookup optimizations, especially in the resubmit/clone cases, >> we might end up with multiple ct_clear actions, which are not necessary. >> >> This patch only adds the ct_clear action to the datapath if any ct state >> is tracked. >> >> Signed-off-by: Eelco Chaudron >> --- >> v2: Insert ct_clear only when ct information is tracked vs tracking >> successive >> ct_clear actions. >> >> ofproto/ofproto-dpif-xlate.c |4 +++- >> tests/ofproto-dpif.at| 25 + >> 2 files changed, 28 insertions(+), 1 deletion(-) > > > Acked-By: Timothy Redaelli > Thanks! Applied. Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: avoid successive ct_clear datapath actions
On Tue, 18 May 2021 06:17:48 -0400 Eelco Chaudron wrote: > Due to flow lookup optimizations, especially in the resubmit/clone cases, > we might end up with multiple ct_clear actions, which are not necessary. > > This patch only adds the ct_clear action to the datapath if any ct state > is tracked. > > Signed-off-by: Eelco Chaudron > --- > v2: Insert ct_clear only when ct information is tracked vs tracking successive > ct_clear actions. > > ofproto/ofproto-dpif-xlate.c |4 +++- > tests/ofproto-dpif.at| 25 + > 2 files changed, 28 insertions(+), 1 deletion(-) Acked-By: Timothy Redaelli ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
