[ovs-discuss] connection tracking
Hi , Is there any reason why connection tracking is developed per datapath instead of per pmd? Just like emc caching /classifiers are per pmd not per dp. Regards, Bindiya ___ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
[ovs-discuss] regarding trunc feature changes for OVS_ACTION_ATTR_USERSPACE
Hi ,
i am not getting reason,why highlighted code is added for
OVS_ACTION_ATTR_USERSPACE.
What purpose it serves.
This code got added as part of feature "ofp-actions: Add truncate
action. The patch adds a new action to support packet truncation. "
Can somebody please help in understanding below part?
file :"lib/dpif-netdev.c"
function : dp_execute_cb
case OVS_ACTION_ATTR_USERSPACE:
.
.
.
userdata = nl_attr_find_nested(a, OVS_USERSPACE_ATTR_USERDATA);
ofpbuf_init(&actions, 0);
* if (packets_->trunc) {if (!should_steal) {
dp_packet_batch_clone(&usr_pkt, packets_);packets_
= &usr_pkt;clone = true;
dp_packet_batch_reset_cutlen(orig_packets_);}
dp_packet_batch_apply_cutlen(packets_);*
}
return;
}
break;
regards,
Bindiya
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
[ovs-discuss] Query related to invalid_ttl support
Hi ,
I was going through the code when ttl =0 and action is set as dec_ttl
for ex: TTL of the packet is 1 and rule in ovs is ,
ovs-ofctl add-flow vnf-net0 "table=1,in_port=1 actions=dec_ttl,output:2"
from the 2.11 code.
for this case it calls
for (i = 0; i < ids->n_controllers; i++) {
xlate_controller_action(ctx, UINT16_MAX, OFPR_INVALID_TTL,
ids->cnt_ids[i], UINT32_MAX, NULL, 0);
this in turn calls,
put_controller_user_action
This in turn will create user-space action. I am not getting where in the
code, it is generating message towards controller for invalid ttl.
If anyone has idea on this?
regards,
Bindiya
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
Re: [ovs-discuss] Query on DEC_ttl action implementation in datapath
Thanks. Is there any forum where i can discuss the design for same? Regards, Bindiya On Thu, Aug 29, 2019 at 1:22 AM Justin Pettit wrote: > I understand. This has been discussed previously on the mailing list. > You are welcome to submit a patch upstream to provide that capability, but > I suspect you will get some resistance--especially from the Linux kernel > community. > > --Justin > > > > On Aug 27, 2019, at 11:25 PM, bindiya Kurle > wrote: > > > > Hi Justin, > > > > Thanks for the clarification. I agree to your point ,but consider a > use-case if I have routing decision only based on destination ip then as > per current implementation, ovs will add 2 flows (in data path)for packets > coming from different source and if the TTL happens to be different for > them .This will reduce number of flows that can be supported with ovs. If > decrement TTL was done in kernel ,it would have ended in adding one flow > only. > > > > Regards, > > Bindiya > > > > Regards, > > Bindiya > > > > On Tue, Aug 27, 2019 at 9:48 PM Justin Pettit wrote: > > I think it was considered cleaner from an ABI perspective, since it > doesn't require another action, since "set" was already supported. In > practice, I don't think it's a problem, since usually a TTL decrement is > associated with a routing decision, and TTLs tend to be fairly static > between two hosts. > > > > --Justin > > > > > > > On Aug 27, 2019, at 1:11 AM, bindiya Kurle > wrote: > > > > > > hi , > > > I have a question related to dec_ttl action implemented in datapath. > > > when dec_ttl action is configured in OVS following action get added > in datapath. > > > > > > recirc_id(0),in_port(2),eth(),eth_type(0x0800),ipv4(ttl=64,frag=no), > packets:3, bytes:294, used:0.068s, actions:set(ipv4(ttl=63)),3, > > > > > > if packet comes with different TTL on same port then one more action > get added in datapath. > > > for ex: > > > recirc_id(0),in_port(2),eth(),eth_type(0x0800),ipv4(ttl=9,frag=no), > packets:3, bytes:294, used:0.068s, actions:set(ipv4(ttl=8)),3, > > > > > > Could someone please explain why dec_ttl is implemeted as a set > action rather than dec_ttl action. > > > > > > > > > I mean , why for different ttl one more rule get added rather than > just adding it as following as done in userspace > > > > > > recirc_id(0),in_port(3),eth(),eth_type(0x0800),ipv4(frag=no), > packets:3, bytes:294, used:0.737s, actions:dec_ttl,2 > > > > > > Regards, > > > Bindiya > > > ___ > > > discuss mailing list > > > disc...@openvswitch.org > > > https://mail.openvswitch.org/mailman/listinfo/ovs-discuss > > > > ___ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
Re: [ovs-discuss] Query on DEC_ttl action implementation in datapath
Hi Justin, Thanks for the clarification. I agree to your point ,but consider a use-case if I have routing decision only based on destination ip then as per current implementation, ovs will add 2 flows (in data path)for packets coming from different source and if the TTL happens to be different for them .This will reduce number of flows that can be supported with ovs. If decrement TTL was done in kernel ,it would have ended in adding one flow only. Regards, Bindiya Regards, Bindiya On Tue, Aug 27, 2019 at 9:48 PM Justin Pettit wrote: > I think it was considered cleaner from an ABI perspective, since it > doesn't require another action, since "set" was already supported. In > practice, I don't think it's a problem, since usually a TTL decrement is > associated with a routing decision, and TTLs tend to be fairly static > between two hosts. > > --Justin > > > > On Aug 27, 2019, at 1:11 AM, bindiya Kurle > wrote: > > > > hi , > > I have a question related to dec_ttl action implemented in datapath. > > when dec_ttl action is configured in OVS following action get added in > datapath. > > > > recirc_id(0),in_port(2),eth(),eth_type(0x0800),ipv4(ttl=64,frag=no), > packets:3, bytes:294, used:0.068s, actions:set(ipv4(ttl=63)),3, > > > > if packet comes with different TTL on same port then one more action get > added in datapath. > > for ex: > > recirc_id(0),in_port(2),eth(),eth_type(0x0800),ipv4(ttl=9,frag=no), > packets:3, bytes:294, used:0.068s, actions:set(ipv4(ttl=8)),3, > > > > Could someone please explain why dec_ttl is implemeted as a set action > rather than dec_ttl action. > > > > > > I mean , why for different ttl one more rule get added rather than just > adding it as following as done in userspace > > > > recirc_id(0),in_port(3),eth(),eth_type(0x0800),ipv4(frag=no), packets:3, > bytes:294, used:0.737s, actions:dec_ttl,2 > > > > Regards, > > Bindiya > > ___ > > discuss mailing list > > disc...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-discuss > > ___ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
[ovs-discuss] Query on DEC_ttl action implementation in datapath
hi , I have a question related to dec_ttl action implemented in datapath. when dec_ttl action is configured in OVS following action get added in datapath. recirc_id(0),in_port(2),eth(),eth_type(0x0800),ipv4(ttl=64,frag=no), packets:3, bytes:294, used:0.068s, actions:set(ipv4(ttl=63)),3, if packet comes with different TTL on same port then one more action get added in datapath. for ex: recirc_id(0),in_port(2),eth(),eth_type(0x0800),ipv4(ttl=9,frag=no), packets:3, bytes:294, used:0.068s, actions:set(ipv4(ttl=8)),3, Could someone please explain why dec_ttl is implemeted as a set action rather than dec_ttl action. I mean , why for different ttl one more rule get added rather than just adding it as following as done in userspace recirc_id(0),in_port(3),eth(),eth_type(0x0800),ipv4(frag=no), packets:3, bytes:294, used:0.737s, actions:dec_ttl,2 Regards, Bindiya ___ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
