Re: [ovs-discuss] Almost half OVN unit tests are skipped (ovn.at:xxx) - OVN_FOR_EACH_NORTHD

2021-05-25 Thread Han Zhou
On Tue, May 25, 2021 at 10:25 AM Brendan Doyle 
wrote:
>
> Folks,
>
> Perhaps I'm missing something, but in a recent pull of the OVN src,
> having boot
> strapped and built the code and executed unit tests as per instructions:
> Documentation/topics/testing.rst
>
> I see that almost half of the unit tests are skipped, seems to be any
> that begin
> with:
> OVN_FOR_EACH_NORTHD([
>
> Not only that If I create an empty test:
> OVN_FOR_EACH_NORTHD([
> AT_SETUP([ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR])
> AT_KEYWORDS([my-test])
> AT_CLEANUP
> ])
>
> And run " make check TESTSUITEFLAGS='-k my-test'" I'll get a report of:
> OVN end-to-end tests
>
> 623: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd --
> dp-groups=yes ok
> 624: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd ok
> 625: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd-ddlog
> -- dp-groups=yes skipped (ovn.at:26531)
> 626: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd-ddlog
> skipped (ovn.at:26531)
>
> ## - ##
> ## Test results. ##
> ## - ##
>
> 2 tests were successful.
> 2 tests were skipped.
> make[2]: Leaving directory `/root/ovn'
> make[1]: Leaving directory `/root/ovn'
>
> I'm not sure how I'm supposed to interpret that - am I missing something?
> Where are the two tests coming from?

Hi Brendan,

The skipped tests are for ovn-northd-ddlog, a different implementation of
ovn-northd from the default C implementation. To enable them, you need to
install ddlog related tools and also configure it "--with-ddlog". For more
details, please search for keyword "ddlog" (case insensitive) in
https://github.com/ovn-org/ovn/blob/master/Documentation/intro/install/general.rst.
If you are not using ddlog, skipping those tests is ok.

Thanks,
Han
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss


[ovs-discuss] Almost half OVN unit tests are skipped (ovn.at:xxx) - OVN_FOR_EACH_NORTHD

2021-05-25 Thread Brendan Doyle

Folks,

Perhaps I'm missing something, but in a recent pull of the OVN src, 
having boot

strapped and built the code and executed unit tests as per instructions:
Documentation/topics/testing.rst

I see that almost half of the unit tests are skipped, seems to be any 
that begin

with:
OVN_FOR_EACH_NORTHD([

Not only that If I create an empty test:
OVN_FOR_EACH_NORTHD([
AT_SETUP([ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR])
AT_KEYWORDS([my-test])
AT_CLEANUP
])

And run " make check TESTSUITEFLAGS='-k my-test'" I'll get a report of:
OVN end-to-end tests

623: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd -- 
dp-groups=yes ok

624: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd ok
625: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd-ddlog 
-- dp-groups=yes skipped (ovn.at:26531)
626: ovn -- my-test: 1 HVs, 1 LSs, 1 lport/LS, 1 LR -- ovn-northd-ddlog 
skipped (ovn.at:26531)


## - ##
## Test results. ##
## - ##

2 tests were successful.
2 tests were skipped.
make[2]: Leaving directory `/root/ovn'
make[1]: Leaving directory `/root/ovn'

I'm not sure how I'm supposed to interpret that - am I missing something?
Where are the two tests coming from?
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss