Re: [ovs-discuss] Confusing errors in response to incorrectly formed OFPGroupMod

2019-01-09 Thread Ben Pfaff
On Tue, Jan 08, 2019 at 04:04:37PM +0300, Artem Gromov wrote:
> Hi,
> OVS sends confusing error message to incorrectly formed OFPGroupMod message
> with OFPGC_ADD command and command_bucket_id set.
> 
> This condition (absence of else keyword and body) is probably the main
> cause:
> https://github.com/openvswitch/ovs/blob/master/lib/ofp-group.c#L2188
> 
> It should be possibly something like "bad groupmod msg" instead of this:
> 
> > 2019-01-08T11:25:17.476Z|00184|ofp_group|WARN|group command bucket id (1)
> > is out of range
> > 2019-01-08T11:25:17.476Z|00185|connmgr|INFO|br0<->tcp:10.0.0.6:6633:
> > sending OFPGMFC_BAD_BUCKET error reply to OFPT_GROUP_MOD message

I'd like to help, but I don't understand the complaint yet.  It seems to
me that the problem in the group_mod message is the command_bucket_id,
and that both logs messages point that out.  Can you explain why a less
specific message would be more helpful?

Thanks,

Ben.
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss


[ovs-discuss] Confusing errors in response to incorrectly formed OFPGroupMod

2019-01-08 Thread Artem Gromov
Hi,
OVS sends confusing error message to incorrectly formed OFPGroupMod message
with OFPGC_ADD command and command_bucket_id set.

This condition (absence of else keyword and body) is probably the main
cause:
https://github.com/openvswitch/ovs/blob/master/lib/ofp-group.c#L2188

It should be possibly something like "bad groupmod msg" instead of this:

> 2019-01-08T11:25:17.476Z|00184|ofp_group|WARN|group command bucket id (1)
> is out of range
> 2019-01-08T11:25:17.476Z|00185|connmgr|INFO|br0<->tcp:10.0.0.6:6633:
> sending OFPGMFC_BAD_BUCKET error reply to OFPT_GROUP_MOD message


Additional details are here:
https://sourceforge.net/p/ryu/mailman/message/36511822/

-- 
regards,
Artem Gromov
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss