Re: [ovs-discuss] OVS queues and precedence

2017-12-17 Thread Łukasz Rząsik
I've been testing different qdiscs and noticed sfq had no docs about
supported parameters.
I've just sent a patch with the docs. Hope it's useful.

2017-11-13 20:27 GMT+01:00 Ben Pfaff :

> On Mon, Nov 13, 2017 at 08:13:57PM +0100, Łukasz Rząsik wrote:
> > 2017-10-25 0:05 GMT+02:00 Ben Pfaff :
> >
> > > On Wed, Oct 18, 2017 at 09:17:53AM +0200, Jannis Ohms wrote:
> > > > Hi
> > > >
> > > >
> > > > I used the following command to create 4 queues
> > > >
> > > > ovs-vsctl -- set port s7-eth2 qos=@newqos -- --id=@newqos create qos
> > > > type=linux-htb other-config:max-rate=1000 queues:1=@newQ
> > > queues:2=@newQ2
> > > > queues:3=@newQ3 -- --id=@newQ create queue
> other-config:min-rate=200
> > > > other-config:max-rate=200,2=@newQ2 -- --id=@newQ2 create queue
> > > > other-config:min-rate=200 other-config:max-rate=500,3=@newQ3
> --
> > > > --id=@newQ3 create queue other-config:min-rate=200
> > > > other-config:max-rate=600
> > > >
> > > > Now I wanted to know which queues precede each other i.e. if every
> queue
> > > has
> > > > a token and a packet to send who comes first. I requier this
> knowledge to
> > > > address the latency aspect of my QoS.
> > > >
> > > > I looked into Linux tc-htb manpage (https://linux.die.net/man/8/
> tc-htb)
> > > >
> > > > They define a prio property which seems to define  the precedence
> between
> > > > the queues.
> > > >
> > > > Can I pass this as an aditional parameter via ovs-vsctl
> > >
> > > OVS doesn't currently support the prio (priority) setting, and
> currently
> > > sets all priorities to 0.  If you want to submit a patch to add support
> > > for this feature, I think it would be a reasonable addition.
> > > ___
> > > discuss mailing list
> > > disc...@openvswitch.org
> > > https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
> > >
> >
> > Hi Ben, Jannis,
> >
> > I was about to implement prio (priority) setting for htb but I realized
> it
> > is actually implemented.
> > At least when I set other-config:priority for a given port then I can see
> > it set correctly with tc class show.
> >
> > Am I right or am I missing something? Maybe you meant something else?
>
> Oh, that's funny.  You're right, and it's even documented.  I checked
> the source before I replied, but I must have been looking at some other
> QoS discipline.
>
> Jannis, what's wrong with what's there?
>
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss


Re: [ovs-discuss] OVS queues and precedence

2017-11-13 Thread Ben Pfaff
On Mon, Nov 13, 2017 at 08:13:57PM +0100, Łukasz Rząsik wrote:
> 2017-10-25 0:05 GMT+02:00 Ben Pfaff :
> 
> > On Wed, Oct 18, 2017 at 09:17:53AM +0200, Jannis Ohms wrote:
> > > Hi
> > >
> > >
> > > I used the following command to create 4 queues
> > >
> > > ovs-vsctl -- set port s7-eth2 qos=@newqos -- --id=@newqos create qos
> > > type=linux-htb other-config:max-rate=1000 queues:1=@newQ
> > queues:2=@newQ2
> > > queues:3=@newQ3 -- --id=@newQ create queue other-config:min-rate=200
> > > other-config:max-rate=200,2=@newQ2 -- --id=@newQ2 create queue
> > > other-config:min-rate=200 other-config:max-rate=500,3=@newQ3 --
> > > --id=@newQ3 create queue other-config:min-rate=200
> > > other-config:max-rate=600
> > >
> > > Now I wanted to know which queues precede each other i.e. if every queue
> > has
> > > a token and a packet to send who comes first. I requier this knowledge to
> > > address the latency aspect of my QoS.
> > >
> > > I looked into Linux tc-htb manpage (https://linux.die.net/man/8/tc-htb)
> > >
> > > They define a prio property which seems to define  the precedence between
> > > the queues.
> > >
> > > Can I pass this as an aditional parameter via ovs-vsctl
> >
> > OVS doesn't currently support the prio (priority) setting, and currently
> > sets all priorities to 0.  If you want to submit a patch to add support
> > for this feature, I think it would be a reasonable addition.
> > ___
> > discuss mailing list
> > disc...@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
> >
> 
> Hi Ben, Jannis,
> 
> I was about to implement prio (priority) setting for htb but I realized it
> is actually implemented.
> At least when I set other-config:priority for a given port then I can see
> it set correctly with tc class show.
> 
> Am I right or am I missing something? Maybe you meant something else?

Oh, that's funny.  You're right, and it's even documented.  I checked
the source before I replied, but I must have been looking at some other
QoS discipline.

Jannis, what's wrong with what's there?
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss


Re: [ovs-discuss] OVS queues and precedence

2017-11-13 Thread Łukasz Rząsik
2017-10-25 0:05 GMT+02:00 Ben Pfaff :

> On Wed, Oct 18, 2017 at 09:17:53AM +0200, Jannis Ohms wrote:
> > Hi
> >
> >
> > I used the following command to create 4 queues
> >
> > ovs-vsctl -- set port s7-eth2 qos=@newqos -- --id=@newqos create qos
> > type=linux-htb other-config:max-rate=1000 queues:1=@newQ
> queues:2=@newQ2
> > queues:3=@newQ3 -- --id=@newQ create queue other-config:min-rate=200
> > other-config:max-rate=200,2=@newQ2 -- --id=@newQ2 create queue
> > other-config:min-rate=200 other-config:max-rate=500,3=@newQ3 --
> > --id=@newQ3 create queue other-config:min-rate=200
> > other-config:max-rate=600
> >
> > Now I wanted to know which queues precede each other i.e. if every queue
> has
> > a token and a packet to send who comes first. I requier this knowledge to
> > address the latency aspect of my QoS.
> >
> > I looked into Linux tc-htb manpage (https://linux.die.net/man/8/tc-htb)
> >
> > They define a prio property which seems to define  the precedence between
> > the queues.
> >
> > Can I pass this as an aditional parameter via ovs-vsctl
>
> OVS doesn't currently support the prio (priority) setting, and currently
> sets all priorities to 0.  If you want to submit a patch to add support
> for this feature, I think it would be a reasonable addition.
> ___
> discuss mailing list
> disc...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
>

Hi Ben, Jannis,

I was about to implement prio (priority) setting for htb but I realized it
is actually implemented.
At least when I set other-config:priority for a given port then I can see
it set correctly with tc class show.

Am I right or am I missing something? Maybe you meant something else?
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss


Re: [ovs-discuss] OVS queues and precedence

2017-10-24 Thread Ben Pfaff
On Wed, Oct 18, 2017 at 09:17:53AM +0200, Jannis Ohms wrote:
> Hi
> 
> 
> I used the following command to create 4 queues
> 
> ovs-vsctl -- set port s7-eth2 qos=@newqos -- --id=@newqos create qos
> type=linux-htb other-config:max-rate=1000 queues:1=@newQ queues:2=@newQ2
> queues:3=@newQ3 -- --id=@newQ create queue other-config:min-rate=200
> other-config:max-rate=200,2=@newQ2 -- --id=@newQ2 create queue
> other-config:min-rate=200 other-config:max-rate=500,3=@newQ3 --
> --id=@newQ3 create queue other-config:min-rate=200
> other-config:max-rate=600
> 
> Now I wanted to know which queues precede each other i.e. if every queue has
> a token and a packet to send who comes first. I requier this knowledge to
> address the latency aspect of my QoS.
> 
> I looked into Linux tc-htb manpage (https://linux.die.net/man/8/tc-htb)
> 
> They define a prio property which seems to define  the precedence between
> the queues.
> 
> Can I pass this as an aditional parameter via ovs-vsctl

OVS doesn't currently support the prio (priority) setting, and currently
sets all priorities to 0.  If you want to submit a patch to add support
for this feature, I think it would be a reasonable addition.
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss