[GitHub] [hadoop-ozone] iamabug commented on a change in pull request #357: HDDS-2729. Enable multilingual Hugo features in ozone docs
iamabug commented on a change in pull request #357: HDDS-2729. Enable multilingual Hugo features in ozone docs URL: https://github.com/apache/hadoop-ozone/pull/357#discussion_r357867233 ## File path: hadoop-hdds/docs/content/concept/_index.zh.md ## @@ -0,0 +1,26 @@ +--- +title: Concepts Review comment: I have replaced the content with Chinese on my laptop and it seems to work out just fine. Except that the language switch button is not exactly on the top right, I am not sure if it's a problem. Screenshot: ![](https://tva1.sinaimg.cn/large/006tNbRwly1g9vvw3g5ttj31ip078q42.jpg) on the other hand, index page seems to be okay on this subject: ![](https://tva1.sinaimg.cn/large/006tNbRwly1g9vvxeceoej31hc05lt9j.jpg) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] iamabug commented on a change in pull request #357: HDDS-2729. Enable multilingual Hugo features in ozone docs
iamabug commented on a change in pull request #357: HDDS-2729. Enable multilingual Hugo features in ozone docs URL: https://github.com/apache/hadoop-ozone/pull/357#discussion_r357865447 ## File path: hadoop-hdds/docs/config.yaml ## @@ -16,11 +16,18 @@ languageCode: "en-us" DefaultContentLanguage: "en" +languages: + en: +languageName: English +weight: 1 + zh: +languageName: Mandarin Review comment: how about using a Chinese word for language name here so that Chinese users can recognize it easilier, i.e., Mandarin -> 中文 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org