sodonnel commented on pull request #1484: URL: https://github.com/apache/hadoop-ozone/pull/1484#issuecomment-706203898
Thanks for taking a look @elek > Can you please share more details. It would help me to understand the changes. I added some comments inline with each change that explains the reasoning behind them. There were two main problems: 1) The state reported by the DN was not reflected in DatanodeDetails seen in SCM. This was due to missing fields in the builder object and resulted in decommission not being able to survive a SCM restart. 2) After an SCM restart when a node reported as DECOMMISSIONING or ENTERING_MAINTENANCE, it failed to make any further progress and was stuck in that state. It needed to be put back into the DatanodeAdminMonitor to finish out the process. 3) There was a small race condition, which may not have caused any problems but was better to fix, in the node status getting set and then updated on registration. Each of the problems was discovered via one of the new tests and then corrected to get the test to pass. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
