[jira] [Commented] (HDDS-2657) Key get command creates the output file even in case of KEY_NOT_FOUND

2019-12-03 Thread Anu Engineer (Jira)


[ 
https://issues.apache.org/jira/browse/HDDS-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987091#comment-16987091
 ] 

Anu Engineer commented on HDDS-2657:


I have added Aysuh to the contributors group.

> Key get command creates the output file even in case of KEY_NOT_FOUND
> -
>
> Key: HDDS-2657
> URL: https://issues.apache.org/jira/browse/HDDS-2657
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>Reporter: Ayush Saxena
>Priority: Major
>  Labels: pull-request-available
> Attachments: HDDS-2657-01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If a key isn't found, the key get command still creates an output file of 0 
> size.
> {noformat}
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:41 ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39 ../
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35 ozone*
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ./ozone sh key get "hive/bucket/key 21" "file 21"
> KEY_NOT_FOUND Key not found
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:42  ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39  ../
> -rw-r--r--  1 ayush ayush 0 Dec  2 22:42 'file 21'
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35  ozone*
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-2657) Key get command creates the output file even in case of KEY_NOT_FOUND

2019-12-03 Thread Dinesh Chitlangia (Jira)


[ 
https://issues.apache.org/jira/browse/HDDS-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987018#comment-16987018
 ] 

Dinesh Chitlangia commented on HDDS-2657:
-

[~aengineer] / [~elek] - Could you please add [~ayushtkn] as contributor so we 
can assign this Jira to him? Thanks.

> Key get command creates the output file even in case of KEY_NOT_FOUND
> -
>
> Key: HDDS-2657
> URL: https://issues.apache.org/jira/browse/HDDS-2657
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>Reporter: Ayush Saxena
>Priority: Major
> Attachments: HDDS-2657-01.patch
>
>
> If a key isn't found, the key get command still creates an output file of 0 
> size.
> {noformat}
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:41 ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39 ../
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35 ozone*
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ./ozone sh key get "hive/bucket/key 21" "file 21"
> KEY_NOT_FOUND Key not found
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:42  ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39  ../
> -rw-r--r--  1 ayush ayush 0 Dec  2 22:42 'file 21'
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35  ozone*
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-2657) Key get command creates the output file even in case of KEY_NOT_FOUND

2019-12-03 Thread Dinesh Chitlangia (Jira)


[ 
https://issues.apache.org/jira/browse/HDDS-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987015#comment-16987015
 ] 

Dinesh Chitlangia commented on HDDS-2657:
-

[~ayushtkn] Thanks for reporting the issue and providing the patch.

Could you please submit a github PR so that all system checks can run?

> Key get command creates the output file even in case of KEY_NOT_FOUND
> -
>
> Key: HDDS-2657
> URL: https://issues.apache.org/jira/browse/HDDS-2657
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>Reporter: Ayush Saxena
>Priority: Major
> Attachments: HDDS-2657-01.patch
>
>
> If a key isn't found, the key get command still creates an output file of 0 
> size.
> {noformat}
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:41 ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39 ../
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35 ozone*
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ./ozone sh key get "hive/bucket/key 21" "file 21"
> KEY_NOT_FOUND Key not found
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:42  ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39  ../
> -rw-r--r--  1 ayush ayush 0 Dec  2 22:42 'file 21'
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35  ozone*
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-2657) Key get command creates the output file even in case of KEY_NOT_FOUND

2019-12-02 Thread Attila Doroszlai (Jira)


[ 
https://issues.apache.org/jira/browse/HDDS-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986274#comment-16986274
 ] 

Attila Doroszlai commented on HDDS-2657:


Thanks [~ayushtkn] for reporting this issue.  I have tested the fix, it works 
fine.

> Key get command creates the output file even in case of KEY_NOT_FOUND
> -
>
> Key: HDDS-2657
> URL: https://issues.apache.org/jira/browse/HDDS-2657
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>Reporter: Ayush Saxena
>Priority: Major
> Attachments: HDDS-2657-01.patch
>
>
> If a key isn't found, the key get command still creates an output file of 0 
> size.
> {noformat}
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:41 ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39 ../
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35 ozone*
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ./ozone sh key get "hive/bucket/key 21" "file 21"
> KEY_NOT_FOUND Key not found
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:42  ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39  ../
> -rw-r--r--  1 ayush ayush 0 Dec  2 22:42 'file 21'
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35  ozone*
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-2657) Key get command creates the output file even in case of KEY_NOT_FOUND

2019-12-02 Thread Ayush Saxena (Jira)


[ 
https://issues.apache.org/jira/browse/HDDS-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16986228#comment-16986228
 ] 

Ayush Saxena commented on HDDS-2657:


HDDS-2580, Could be a reason for this,
The output stream was created before the input stream, so if there is no key, 
still the output stream creates the empty file.
Uploaded fix.
Verified :

{noformat}
ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
 ./ozone sh key get "hive/bucket/key 21" "file 21"
KEY_NOT_FOUND Key not found
ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
 ll
total 24
drwxr-xr-x  2 ayush ayush  4096 Dec  2 22:55 ./
drwxr-xr-x 13 ayush ayush  4096 Dec  2 23:05 ../
-rwxr-xr-x  1 ayush ayush 12786 Dec  2 22:55 ozone*
{noformat}

Pls Review!!!

> Key get command creates the output file even in case of KEY_NOT_FOUND
> -
>
> Key: HDDS-2657
> URL: https://issues.apache.org/jira/browse/HDDS-2657
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>Reporter: Ayush Saxena
>Priority: Major
> Attachments: HDDS-2657-01.patch
>
>
> If a key isn't found, the key get command still creates an output file of 0 
> size.
> {noformat}
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:41 ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39 ../
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35 ozone*
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ./ozone sh key get "hive/bucket/key 21" "file 21"
> KEY_NOT_FOUND Key not found
> ayush@ayushpc:~/ozone/hadoop-ozone/hadoop-ozone/dist/target/ozone-0.5.0-SNAPSHOT/bin$
>  ll
> total 36
> drwxr-xr-x  3 ayush ayush  4096 Dec  2 22:42  ./
> drwxr-xr-x 13 ayush ayush  4096 Nov 30 19:39  ../
> -rw-r--r--  1 ayush ayush 0 Dec  2 22:42 'file 21'
> -rwxr-xr-x  1 ayush ayush 12786 Nov 30 19:35  ozone*
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org