[p2-dev] Bug 493193 - MirrorApplication should explicitly use MD5 artifact comparator
Hi there, When adding support for SHA256 checksums [1], I've found out that the only place that documents the usage of MD5 comparator in MirrorApplication is Equinox p2 Repository Mirroring wiki page [2]: Adding the argument -comparator specifies the mirroring application should use an Artifact Comparator with an ID of "comparator ID" to compare artifact descriptors. The mirroring application uses the "MD5 Comparator" to compare the MD5 hash property of the artifact descriptors if no comparator is defined. If no comparator is defined, ArtifactComparatorFactory's getArtifactComparator(String) will be finally called with null as a comparator ID. It's an ArtifactComparatorFactory's implementation detail that it will return the first configured one. MD5 comparator is the only one available now, but this may (and my I hope it will) change and break MirrorApplication's expectation. To avoid such breakage, MirrorApplication declares [3] an explicit dependency on MD5 comparator. So, when '-compare' CLI parameter is true but '-comparator' CLI parameter is missing, it will request MD5 artifact comparator to be used. Please provide your feedback or just merge [3]. [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=493193 [2] https://wiki.eclipse.org/Equinox_p2_Repository_Mirroring [3] https://git.eclipse.org/r/72234 -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
[p2-dev] Pending patches for handling exceptions while calculating checksum
Hi, could someone provide feedback on these patches? - https://git.eclipse.org/r/87352 - https://git.eclipse.org/r/87377 - https://git.eclipse.org/r/87726 Thanks in advance. -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
[p2-dev] Bug 509473: Version number of simpleconfigurator goes... down?
Hi there, I would expect simpleconfigurator's version to go up. Instead, it goes down, from 1.2.300.qualifier to 1.2.0.qualifier. Is it OK? git show 95a41dc3e -- bundles/org.eclipse.equinox.simpleconfigurator/ commit 95a41dc3e542929a2d03e0b9ab8bc1a476ba9101 Author: Markus Keller Date: Tue Jan 10 18:05:08 2017 +0100 Bug 509473: Update version number of simpleconfigurator and p2.engine diff --git a/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF index 7d6e84304..e0ef704c1 100644 --- a/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF +++ b/bundles/org.eclipse.equinox.simpleconfigurator/META-INF/MANIFEST.MF @@ -1,7 +1,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-SymbolicName: org.eclipse.equinox.simpleconfigurator;singleton:=true -Bundle-Version: 1.2.300.qualifier +Bundle-Version: 1.2.0.qualifier Bundle-Name: %bundleName Bundle-Vendor: %providerName Bundle-Localization: plugin diff --git a/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml b/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml index ba165af11..51f218ebc 100644 --- a/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml +++ b/bundles/org.eclipse.equinox.simpleconfigurator/pom.xml @@ -9,6 +9,6 @@ org.eclipse.equinox org.eclipse.equinox.simpleconfigurator - 1.2.300-SNAPSHOT + 1.2.0-SNAPSHOT eclipse-plugin -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
Re: [p2-dev] Pending patches for handling exceptions while calculating checksum
> could someone provide feedback on these patches? > > - https://git.eclipse.org/r/87352 > - https://git.eclipse.org/r/87377 > - https://git.eclipse.org/r/87726 And one more - https://git.eclipse.org/r/88262 > Thanks in advance. Anyone? -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
[p2-dev] Bug 423715 - Add SHA256 to p2 metadata publishing (and prefer for consumption if available)
Hi there, I have another set of changes related to multiple checksum support [0]. [0] https://bugs.eclipse.org/bugs/show_bug.cgi?id=423715 Please review and apply them one by one: [1] https://git.eclipse.org/r/116174 [2] https://git.eclipse.org/r/116197 [3] https://git.eclipse.org/r/116201 I've made them separate on purpose, to make it easier to reason about because the final change [4] is quite big (about 36 files changed, 928 insertions(+), 84 deletions(-)). [4] https://git.eclipse.org/r/69560 I'm still polishing [4] by removing any backward-incompatible changes. It seems will export one more internal package with x-friends, (for 2 bundles and test bundle), not sure if I can avoid that. Hope to submit this final change in couple days. -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
Re: [p2-dev] Bug 423715 - Add SHA256 to p2 metadata publishing (and prefer for consumption if available)
> Please review and apply them one by one: > > [1] https://git.eclipse.org/r/116174 > [2] https://git.eclipse.org/r/116197 > [3] https://git.eclipse.org/r/116201 Thanks to Alexander Kurtakov for taking care of these, we're almost done here. [...] > Hope to submit this final change in couple days. Attending FOSDEM and working on this didn't work at all. The good news: I'll have time to finish it next week. -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
Re: [p2-dev] Bug 423715 - Add SHA256 to p2 metadata publishing (and prefer for consumption if available)
Mykola Nikishov writes: > I have another set of changes related to multiple checksum support [0]. > > [0] https://bugs.eclipse.org/bugs/show_bug.cgi?id=423715 > > Please review and apply them one by one: I have one more intermediate change set [1] for review [1] https://git.eclipse.org/r/117080 > [4] https://git.eclipse.org/r/69560 > > I'm still polishing [4] by removing any backward-incompatible > changes. It seems will export one more internal package with x-friends, > (for 2 bundles and test bundle), not sure if I can avoid that. Still working on [4], I reworked it a bit and took a more conservative approach by only adding support for multiple checksums without touching existing infrastructure that handles MD5. In other words, it a) should not regress MD5 handling, b) adds new features = hope it will qualify for Photon release. -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
[p2-dev] Ready for review, Re: Bug 423715 - Add SHA256 to p2 metadata publishing (and prefer for consumption if available)
Mykola Nikishov writes: >> [4] https://git.eclipse.org/r/69560 >> >> I'm still polishing [4] by removing any backward-incompatible >> changes. It seems will export one more internal package with x-friends, >> (for 2 bundles and test bundle), not sure if I can avoid that. > > Still working on [4], I reworked it a bit and took a more conservative > approach by only adding support for multiple checksums without touching > existing infrastructure that handles MD5. All intermediate changes had been merged by Alex Kurtakov and [4] is ready for review now. There are still some TODOs, so I expect at least one more version to be uploaded. Most important undocumented part yet is how to use new artifact checksum comparator with mirror (and other) standalone applications. Couple days ago I was unable to check this feature with latest Tycho [1] as it failed to build locally against latest Equinox p2. I have no build log now, but it was something about a missing method related to requirement capabilities. Not sure if its an actual issue though, will investigate later. [1] https://git.eclipse.org/r/68960 -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
Re: [p2-dev] RCP update failing
Ed Merks writes: > Based on past experience, this problem will likely go away if you > update your version of Java which will update Java the root > certificates. Pretty sure it wouldn't: #1: Requesting http:// resource and failing with TLS/SSL-related exception?! Looks suspicious, at least, and raises #2: #2: it becomes popular to terminate TLS traffic at the border and re-encrypt it with self-issued and self-signed certificate. Such certificate MUST be provided to the client, otherwise client will get sun.security.validator.ValidatorException: PKIX path building failed. #3: Open p2 repo in Web browser and check what certificate is provided to the browser. Check https://duckduckgo.com/?q=java+key+tool+import+certificate for how to import certificate into a keystore. > On 05.11.2017 05:40, Timothy Vogel wrote: >> >> An update site that has been working is now failing with the >> exception below. It is trying to read p2.index. This file does not >> exist in the composite repo nor the product repo. I created one >> with minimal contents and receive the same error. >> >> Any suggestions on how to debug? >> >> Thanks >> >> Timothy >> >> 20171105 00:15:08.536 11548 ERROR >> com.easa.acmotor.base.BusinessStatusHandler - uncaught exception: >> org.eclipse.equinox.p2.transport.ecf : Connection to >> http://www.xxx.com/sites/motordb_update/repository/p2.index failed >> on sun.security.validator.ValidatorException: PKIX path building >> failed: sun.security.provider.certpath.SunCertPathBuilderException: >> unable to find valid certification path to requested target. Retry >> attempt 0 started >> >> javax.net.ssl.SSLHandshakeException: >> sun.security.validator.ValidatorException: PKIX path building >> failed: sun.security.provider.certpath.SunCertPathBuilderException: >> unable to find valid certification path to requested target [...] -- Mykola https://manandbytes.github.io/ ___ p2-dev mailing list p2-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/p2-dev
