[Bug 805416] Review Request: google-croscore-fonts - The width-compatible fonts for improved on-screen readability

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805416

--- Comment #5 from Akira TAGOH ta...@redhat.com 2012-03-27 02:11:26 EDT ---
You can check /etc/fonts/conf.d/30-metric-aliases.conf for the references.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798738] Review request: mysqlenum - is an automatic blind SQL injection tool.

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798738

--- Comment #16 from pjp pj.pan...@yahoo.co.in 2012-03-27 02:26:09 EDT ---
Hi, I've made the changes, please see:

SPEC: http://pjp.dgplug.org/tools/mysqlenum.spec
SRPM: http://pjp.dgplug.org/tools/mysqlenum-0.3-6.fc16.x86_64.rpm


$ rpmlint SPECS/mysqlenum.spec 
SPECS/mysqlenum.spec: W: invalid-url Source0: mysqlenum-0.3.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint SRPMS/mysqlenum-0.3-6.fc16.src.rpm 
mysqlenum.src: W: invalid-url Source0: mysqlenum-0.3.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint RPMS/x86_64/mysqlenum-0.3-6.fc16.x86_64.rpm 
mysqlenum.x86_64: W: no-manual-page-for-binary mysqlenum
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 798738] Review request: mysqlenum - is an automatic blind SQL injection tool.

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=798738

--- Comment #17 from pjp pj.pan...@yahoo.co.in 2012-03-27 02:28:00 EDT ---
(In reply to comment #16)
 SRPM: http://pjp.dgplug.org/tools/mysqlenum-0.3-6.fc16.x86_64.rpm

Please see: SRPM: http://pjp.dgplug.org/tools/mysqlenum-0.3-6.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805416] Review Request: google-croscore-fonts - The width-compatible fonts for improved on-screen readability

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805416

--- Comment #6 from Parag pnem...@redhat.com 2012-03-27 02:35:49 EDT ---
Updated to

Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/google-croscore-fonts.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/google-croscore-fonts-1.21.0-2.fc16.src.rpm

koji scratch build -
http://koji.fedoraproject.org/koji/taskinfo?taskID=3935561

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #3 from Matthias Runge mru...@matthias-runge.de 2012-03-27 
03:22:48 EDT ---
Ah, why do you think, ipython is required?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #2 from Matthias Runge mru...@matthias-runge.de 2012-03-27 
03:22:25 EDT ---
Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 Generic 
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
 Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm  4.4
 Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[!]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
 names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint python-restkit-4.1.2-1.fc18.src.rpm

python-restkit.src: W: spelling-error %description -l en_US httplib - HTTP
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint python-restkit-4.1.2-1.fc18.noarch.rpm

python-restkit.noarch: W: spelling-error %description -l en_US httplib - HTTP
python-restkit.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/restkit/contrib/webob_api.py 0644L
/usr/bin/env
python-restkit.noarch: W: no-manual-page-for-binary restcli
1 packages and 0 specfiles checked; 1 errors, 2 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
 provided in the spec URL.
/home/mrunge/review/806777/restkit-4.1.2.tar.gz :
  MD5SUM this package : 6a405efbf109d0fca13095237c8aae6e
  MD5SUM upstream package : 6a405efbf109d0fca13095237c8aae6e

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
 separate file from upstream, the packager SHOULD query upstream to
 include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
 /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
 --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
 upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
 Note: Source0:
 http://pypi.python.org/packages/source/r/restkit/restkit-4.1.2.tar.gz
 (restkit-4.1.2.tar.gz) Patch0: restkit-disable-tests-needing-internet-
 

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #4 from Matthias Runge mru...@matthias-runge.de 2012-03-27 
03:43:48 EDT ---
and another issue: Licensing seems to be a mixture of free licenses. 

[mrunge@mrungexp restkit-4.1.2]$ licensecheck -r . | grep -v UNKNOWN
./tests/_server_test.py: ISC 
./doc/sitemap_gen.py: BSD (3 clause)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #5 from Bohuslav Slavek Kabrda bkab...@redhat.com 2012-03-27 
03:55:57 EDT ---
Hi Matthias!

- I've been thinking a lot about IPython. It's an optional dependency needed
only by the command line tool (restcli) shipped with the library. On second
thought, I think it is not completely necessary, so I will remove it.
- The license is already included, just not listed explicitly, but with the
whole doc directory: /usr/share/doc/restkit/LICENSE
- As for the other licenses, I will probably go through all the files and add
everything in the next spec version.
- The shebang shall be stripped :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #6 from Matthias Runge mru...@matthias-runge.de 2012-03-27 
04:04:31 EDT ---
Hi Bohuslav,

You did not include the tests into RPM. Thus you have just two licenses: MIT
and BSD.
Imho it should be enough to mark bsd licensed file in files section.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #7 from Bohuslav Slavek Kabrda bkab...@redhat.com 2012-03-27 
04:10:53 EDT ---
Actually, the BDS licensed file doesn't get into the RPM either, so it's really
just MIT :)

So I removed IPython dependency and stripped the shebang, here is the result:
SPEC: http://bkabrda.fedorapeople.org/pkgs/restkit/python-restkit.spec
SRPM:
http://bkabrda.fedorapeople.org/pkgs/restkit/python-restkit-4.1.2-2.fc17.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3935693

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #8 from Matthias Runge mru...@matthias-runge.de 2012-03-27 
04:13:56 EDT ---
Ah yes, you're right.

Package APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #10 from Bohuslav Slavek Kabrda bkab...@redhat.com 2012-03-27 
04:18:27 EDT ---
(In reply to comment #8)
 Ah yes, you're right.
 
 Package APPROVED.

Sorry, I removed the review + by my mistake, could you please set it to +
again? Thanks :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review+  |fedora-review?, fedora-cvs?

--- Comment #9 from Bohuslav Slavek Kabrda bkab...@redhat.com 2012-03-27 
04:17:22 EDT ---
Thanks for your review! (could you please set fedora-review to +?)

New Package SCM Request
===
Package Name: python-restkit
Short Description: Restkit is an HTTP resource kit for Python
Owners: bkabrda
Branches: f17
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806677] Review Request: jboss-web - JBoss Web Server

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806677

--- Comment #5 from Juan Hernández juan.hernan...@redhat.com 2012-03-27 
04:37:48 EDT ---
Thanks Tony!

In order to use the method I suggested to build the javadoc you need to use the
original build.xml *and* the new build-javadoc.xml. It wasn't very well
explained in my previous comment, sorry. In the %build section you will need to
invoke ant twice:

# Once for the binaries:
ant

# And another time for the javadoc:
ant -f build-javadoc.xml

Patching the original build.xml is also ok, but it will require more work when
you update to a new upstream version. I let it up to you to decide which is
better. Right now it is not working because of the slash in front of the
directory, it should be a relative path:

- cp -rp /apidocs/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}
+ cp -rp apidocs/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 619380] Review Request: giis - Solution to undelete files gET iT i sAY

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619380

--- Comment #10 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2012-03-27 04:46:29 EDT ---
http://hubbitus.info/rpm/Fedora16/giis/giis.spec
http://hubbitus.info/rpm/Fedora16/giis/giis-4.6.1-1.fc16.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 791247] Review Request: jboss-remote-naming - JBoss Remote Naming

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=791247

Marek Goldmann mgold...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Marek Goldmann mgold...@redhat.com 2012-03-27 04:42:28 
EDT ---
Thanks for review!

New Package SCM Request
===
Package Name:  jboss-remote-naming
Short Description: JBoss Remote Naming
Owners:goldmann
Branches:  f17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 790893] Review Request: ibus-hunspell-table - Predictive text using hunspell dictionaries

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790893

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 04:48:24 EDT ---
ibus-hunspell-table-0.0.4-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/ibus-hunspell-table-0.0.4-1.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 790893] Review Request: ibus-hunspell-table - Predictive text using hunspell dictionaries

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790893

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 04:47:52 EDT ---
ibus-hunspell-table-0.0.4-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/ibus-hunspell-table-0.0.4-1.fc15

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 790893] Review Request: ibus-hunspell-table - Predictive text using hunspell dictionaries

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=790893

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 04:47:41 EDT ---
ibus-hunspell-table-0.0.4-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/ibus-hunspell-table-0.0.4-1.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 799284] Review Request: perl-Pod-Plainer - Perl extension for converting Pod to old-style Pod

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799284

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #5 from Petr Šabata psab...@redhat.com 2012-03-27 05:19:49 EDT ---
 FIX: The package doesn't build due to missing build dependencies; add 
 perl(Test::More) and, optionally, perl(Test::Pod::Coverage) = 1.00 to your
 BRs.

OK.

 FIX: The URL is wrong; correct it to http://search.cpan.org/dist/Pod-Plainer

OK.

 FIX: Also the SPEC filename is just lowercase.  This needs to be fixed too.

perl-pod-plainer.spec again?  Not OK. 

 FIX: Remove useless Provides; this is created automatically by rpmbuild.

OK.

 TODO: Also, you don't have to explicitly require perl(Pod::Parser),
 rpmbuild gets this.

OK.

 TODO: Use %{version} in Source tag.

OK.

 FIX: Your package doesn't require Perl MODULE_COMPAT.  Add 
 perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo $version)) to
 your Requires.

OK.

 TODO: Don't package META* in %doc.  There's nothing of interest for the 
 end-user.

OK.

 TIP: Don't rely on gzip manpage compression.  Replace '.gz' with '*'.

OK.

 TIP: You don't have to use OPTIMIZE since this is a noarch package, as you 
 also state on line 28. 

OK.

 FIX: Don't define PREFIX, and especially -- don't use hardcoded paths like
 '/usr'.

You don't have to define PREFIX at all.

--
I'm approving this package.  Just please use the correct letter case in your
SPEC file name before you import it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805416] Review Request: google-croscore-fonts - The width-compatible fonts for improved on-screen readability

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805416

--- Comment #7 from Akira TAGOH ta...@redhat.com 2012-03-27 05:43:10 EDT ---
As the description for SymbolNeu says it's compatible font to Symbol. I guess
you better have the substitution for that? and you shouldn't have any
relationship to sans-serif for that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806011] Review Request: jboss-jstl-1.2-api - JSP Standard Template Library 1.2 API

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806011

Marek Goldmann mgold...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com
   Flag||fedora-review?

--- Comment #2 from Marek Goldmann mgold...@redhat.com 2012-03-27 05:51:15 
EDT ---
Taking this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 755054] Review Request: gnome-font-viewer - Utility for previewing fonts for GNOME

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=755054

Rui Matos tiagoma...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-review?

--- Comment #11 from Rui Matos tiagoma...@gmail.com 2012-03-27 05:51:30 EDT 
---
Updated to 3.4.0

spec: http://glua.ua.pt/~rmatos/gnome-font-viewer.spec
srpm: http://glua.ua.pt/~rmatos/gnome-font-viewer-3.4.0-1.fc17.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=3935917

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805416] Review Request: google-croscore-fonts - The width-compatible fonts for improved on-screen readability

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805416

--- Comment #8 from Parag pnem...@redhat.com 2012-03-27 06:09:46 EDT ---
Thanks for the comment. Updated at the same location as given in comment#6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 569582] Review Request: udev-browse - Udev browser tool

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569582

--- Comment #7 from Lennart Poettering lpoet...@redhat.com 2012-03-27 
06:11:39 EDT ---
Thanks for the review!

OK, added the necessary dep for libgee06-devel and dropped the defattr.

New .spec and srpm are now available here:

Spec URL: http://0pointer.de/public/udev-browse.spec
SRPM URL: http://0pointer.de/public/udev-browse-0.2-2.fc17.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806011] Review Request: jboss-jstl-1.2-api - JSP Standard Template Library 1.2 API

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806011

Marek Goldmann mgold...@redhat.com changed:

   What|Removed |Added

 Blocks|652183(FE-JAVASIG)  |
   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Marek Goldmann mgold...@redhat.com 2012-03-27 06:24:54 
EDT ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output:

$ rpmlint SPECS/jboss-jstl-1.2-api.spec 
SPECS/jboss-jstl-1.2-api.spec: W: invalid-url Source0:
jboss-jstl-1.2-api-1.0.3.Final.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
$ rpmlint SRPMS/jboss-jstl-1.2-api-1.0.3-2.fc17.src.rpm 
jboss-jstl-1.2-api.src: I: enchant-dictionary-not-found en_US
jboss-jstl-1.2-api.src: W: invalid-url URL: http://www.jboss.org HTTP Error
403: Forbidden
jboss-jstl-1.2-api.src: W: invalid-url Source0:
jboss-jstl-1.2-api-1.0.3.Final.tar.xz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint RPMS/noarch/jboss-jstl-1.2-api-1.0.3-2.fc17.noarch.rpm 
jboss-jstl-1.2-api.noarch: I: enchant-dictionary-not-found en_US
jboss-jstl-1.2-api.noarch: W: invalid-url URL: http://www.jboss.org HTTP Error
403: Forbidden
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: CDDL or GPLv2 with exceptions
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package: 4398339465ea305c78d8f6e40478f89d
MD5SUM upstream package: 4398339465ea305c78d8f6e40478f89d
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other
packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with
good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT
mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when
building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[-]  If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[-]  If package uses custom depmap -Dmaven.local.depmap.file=* explain why
it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[X]  Package has BuildArch: noarch (if 

[Bug 806011] Review Request: jboss-jstl-1.2-api - JSP Standard Template Library 1.2 API

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806011

Juan Hernández juan.hernan...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Juan Hernández juan.hernan...@redhat.com 2012-03-27 
06:29:34 EDT ---
New Package SCM Request
===
Package Name: jboss-jstl-1.2-api
Short Description: JSP Standard Template Library 1.2 API
Owners: jhernand
Branches: f17
InitialCC: goldmann

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807240] New: Review Request: microemulator - Java 2 Micro Edition (J2ME) CLDC/MIDP Emulator

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: microemulator - Java 2 Micro Edition (J2ME) CLDC/MIDP 
Emulator

https://bugzilla.redhat.com/show_bug.cgi?id=807240

   Summary: Review Request: microemulator - Java 2 Micro Edition
(J2ME) CLDC/MIDP Emulator
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: punto...@libero.it
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://gil.fedorapeople.org/microemulator.spec
SRPM URL: http://gil.fedorapeople.org/microemulator-2.0.4-1.fc16.src.rpm
Description: This is Java 2 Micro Edition (J2ME) CLDC/MIDP Emulator. Allows
demonstration MIDlet (MIDP/CLDC) based applications in web
browser applet, also can be run as standalone java application.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 803376] Review Request: weld-parent - Parent POM for Weld

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=803376

Marek Goldmann mgold...@redhat.com changed:

   What|Removed |Added

 Blocks||805468
 Depends on|805468  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 803381] Review Request: weld-api - Weld API

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=803381

Marek Goldmann mgold...@redhat.com changed:

   What|Removed |Added

 Blocks||805468
 Depends on|805468  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 804824] Review Request: jboss-jsp-2.2-api - JavaServer(TM) Pages 2.2 API

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=804824

Marek Goldmann mgold...@redhat.com changed:

   What|Removed |Added

 Blocks||805468
 Depends on|805468  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805468] Review Request: weld-core - Reference Implementation for JSR-299: Contexts and Dependency Injection (CDI)

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805468

Marek Goldmann mgold...@redhat.com changed:

   What|Removed |Added

 Blocks|803376, 803381, 804824  |
 Depends on||803376, 803381, 804824

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806117] Review Request: Oplop - Generate account passwords based on account nicknames

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806117

--- Comment #2 from Abdel Gadiel Martínez Lassonde 
abdel.g.martine...@gmail.com 2012-03-27 06:55:52 EDT ---
Thank you. I'm on it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807242] New: Review Request: microemulator - Java 2 Micro Edition (J2ME) CLDC/MIDP Emulator

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: microemulator - Java 2 Micro Edition (J2ME) CLDC/MIDP 
Emulator

https://bugzilla.redhat.com/show_bug.cgi?id=807242

   Summary: Review Request: microemulator - Java 2 Micro Edition
(J2ME) CLDC/MIDP Emulator
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: punto...@libero.it
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://gil.fedorapeople.org/microemulator.spec
SRPM URL: http://gil.fedorapeople.org/microemulator-2.0.4-1.fc16.src.rpm
Description: This is Java 2 Micro Edition (J2ME) CLDC/MIDP Emulator. Allows
demonstration MIDlet (MIDP/CLDC) based applications in web
browser applet, also can be run as standalone java application.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805416] Review Request: google-croscore-fonts - The width-compatible fonts for improved on-screen readability

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805416

Akira TAGOH ta...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #9 from Akira TAGOH ta...@redhat.com 2012-03-27 07:11:21 EDT ---
Here we go:

* rpmlint result:
  google-croscore-fonts.src: W: no-url-tag
  google-croscore-fonts.src: W: invalid-url Source0: 
http://gsdview.appspot.com/chromeos-localmirror/distfiles/croscorefonts-1.21.0.tar.gz
HTTP Error 405: Method Not Allowed
  1 packages and 0 specfiles checked; 0 errors, 2 warnings.

  google-croscore-arimo-fonts.noarch: W: no-url-tag
  google-croscore-arimo-fonts.noarch: W: no-documentation
  google-croscore-cousine-fonts.noarch: W: no-url-tag
  google-croscore-cousine-fonts.noarch: W: no-documentation
  google-croscore-fonts-common.noarch: W: no-url-tag
  google-croscore-symbolneu-fonts.noarch: W: no-url-tag
  google-croscore-symbolneu-fonts.noarch: W: no-documentation
  google-croscore-tinos-fonts.noarch: W: no-url-tag
  google-croscore-tinos-fonts.noarch: W: no-documentation
  5 packages and 0 specfiles checked; 0 errors, 9 warnings.

+ package name meets the naming guidelines
+ the spec file name matches %{name}.spec
+ package meets the packaging guidelines
+ package meets the licensing guidelines
+ License field has the actual license
+ License file is available in the package
+ the spec file is written in American English
+ the spec file is legible
+ the sources matches the upstream source
+ the package can be built into binary rpms
* no locale files available
* no shared libraries available
+ package owns directories it creates
+ package consistently uses macros
* no large documentation files available
* no devel files available
* no desktop files available

Is it maybe a good idea to move the source URL to the comment and have the name
of tarball in the Source field perhaps? otherwise it looks good to me.
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591388] Review Request: pbuilder - Personal package builder for Debian packages

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591388

Bug 591388 depends on bug 591192, which changed state.

Bug 591192 Summary: Review Request: dh-make - Tool that converts source 
archives into Debian package source
https://bugzilla.redhat.com/show_bug.cgi?id=591192

   What|Old Value   |New Value

 Resolution||WORKSFORME
 Status|ASSIGNED|CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591192] Review Request: dh-make - Tool that converts source archives into Debian package source

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591192

Jeroen van Meeuwen kana...@kanarip.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||WORKSFORME
   Flag|needinfo?(kanarip@kanarip.c |
   |om) |
Last Closed||2012-03-27 07:16:03

--- Comment #17 from Jeroen van Meeuwen kana...@kanarip.com 2012-03-27 
07:16:03 EDT ---
dh-make is already in Fedora, Oron has been made a co-maintainer

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #10 from Miroslav Suchý msu...@redhat.com 2012-03-27 07:23:09 EDT 
---
Changelog entries fixed.
Man pages added.

Updated:
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin-1.8.3-1.fc16.src.rpm
http://miroslav.suchy.cz/fedora/spacewalk-admin/spacewalk-admin.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807256] Review Request: python-django-mptt - Utilities for implementing Modified Preorder Tree Traversal

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807256

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Blocks||736776

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807256] New: Review Request: python-django-mptt - Utilities for implementing Modified Preorder Tree Traversal

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-django-mptt - Utilities for implementing 
Modified Preorder Tree Traversal

https://bugzilla.redhat.com/show_bug.cgi?id=807256

   Summary: Review Request: python-django-mptt - Utilities for
implementing Modified Preorder Tree Traversal
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mru...@matthias-runge.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://www.matthias-runge.de/fedora/python-django-mptt.spec
SRPM URL:
http://www.matthias-runge.de/fedora/python-django-mptt-0.5.2-1.fc16.src.rpm
Description: Utilities for implementing Modified Preorder Tree Traversal (MPTT)
with your Django Model classes and working with trees of Model instances.


please note: this is a review request required for renaming. 

There seems to exist a problem with django-1.4 from rawhide, so tests don't
succeed in this combination. They run e.g. on f16. 
(simplejson can not be imported)

[mrunge@mrungexp SPECS]$ rpmlint ./python-django-mptt.spec
../SRPMS/python-django-mptt-0.5.2-1.fc16.src.rpm
../RPMS/noarch/python-django-mptt-0.5.2-1.fc16.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

koji-scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=3936102

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 799284] Review Request: perl-Pod-Plainer - Perl extension for converting Pod to old-style Pod

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799284

--- Comment #6 from xn...@redhat.com 2012-03-27 07:41:11 EDT ---
(In reply to comment #5)
  FIX: The package doesn't build due to missing build dependencies; add 
  perl(Test::More) and, optionally, perl(Test::Pod::Coverage) = 1.00 to your
  BRs.
 
 OK.
 
  FIX: The URL is wrong; correct it to http://search.cpan.org/dist/Pod-Plainer
 
 OK.
 
  FIX: Also the SPEC filename is just lowercase.  This needs to be fixed too.
 
 perl-pod-plainer.spec again?  Not OK. 
Fixed
 
  FIX: Remove useless Provides; this is created automatically by rpmbuild.
 
 OK.
 
  TODO: Also, you don't have to explicitly require perl(Pod::Parser),
  rpmbuild gets this.
 
 OK.
 
  TODO: Use %{version} in Source tag.
 
 OK.
 
  FIX: Your package doesn't require Perl MODULE_COMPAT.  Add 
  perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo $version)) to
  your Requires.
 
 OK.
 
  TODO: Don't package META* in %doc.  There's nothing of interest for the 
  end-user.
 
 OK.
 
  TIP: Don't rely on gzip manpage compression.  Replace '.gz' with '*'.
 
 OK.
 
  TIP: You don't have to use OPTIMIZE since this is a noarch package, as you 
  also state on line 28. 
 
 OK.
 
  FIX: Don't define PREFIX, and especially -- don't use hardcoded paths like
  '/usr'.
 
 You don't have to define PREFIX at all.
 
Fixed
 --
 I'm approving this package.  Just please use the correct letter case in your
 SPEC file name before you import it.

The fixed package and spec file are here:
Spec URL: https://dl.dropbox.com/u/64704553/perl-pod-plainer.spec
SRPM URL:
https://dl.dropbox.com/u/64704553/perl-Pod-Plainer-1.03-1.fc16.src.rpm

Thanks very much, Petr.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806678] Review Request: logback - A Java logging library

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806678

Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

 CC||mefos...@gmail.com

--- Comment #2 from Mary Ellen Foster mefos...@gmail.com 2012-03-27 07:43:07 
EDT ---
*** Bug 805487 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805487] Review Request: logback - A Java logging library

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805487

Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE
Last Closed||2012-03-27 07:43:07

--- Comment #3 from Mary Ellen Foster mefos...@gmail.com 2012-03-27 07:43:07 
EDT ---


*** This bug has been marked as a duplicate of bug 806678 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 799284] Review Request: perl-Pod-Plainer - Perl extension for converting Pod to old-style Pod

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799284

--- Comment #7 from xn...@redhat.com 2012-03-27 07:42:43 EDT ---
(In reply to comment #5)
  FIX: The package doesn't build due to missing build dependencies; add 
  perl(Test::More) and, optionally, perl(Test::Pod::Coverage) = 1.00 to your
  BRs.
 
 OK.
 
  FIX: The URL is wrong; correct it to http://search.cpan.org/dist/Pod-Plainer
 
 OK.
 
  FIX: Also the SPEC filename is just lowercase.  This needs to be fixed too.
 
 perl-pod-plainer.spec again?  Not OK. 
Fixed
 
  FIX: Remove useless Provides; this is created automatically by rpmbuild.
 
 OK.
 
  TODO: Also, you don't have to explicitly require perl(Pod::Parser),
  rpmbuild gets this.
 
 OK.
 
  TODO: Use %{version} in Source tag.
 
 OK.
 
  FIX: Your package doesn't require Perl MODULE_COMPAT.  Add 
  perl(:MODULE_COMPAT_%(eval `%{__perl} -V:version`; echo $version)) to
  your Requires.
 
 OK.
 
  TODO: Don't package META* in %doc.  There's nothing of interest for the 
  end-user.
 
 OK.
 
  TIP: Don't rely on gzip manpage compression.  Replace '.gz' with '*'.
 
 OK.
 
  TIP: You don't have to use OPTIMIZE since this is a noarch package, as you 
  also state on line 28. 
 
 OK.
 
  FIX: Don't define PREFIX, and especially -- don't use hardcoded paths like
  '/usr'.
 
 You don't have to define PREFIX at all.
 
Fixed
 --
 I'm approving this package.  Just please use the correct letter case in your
 SPEC file name before you import it.

The fixed package and spec file are here:
Spec URL: https://dl.dropbox.com/u/64704553/perl-Pod-Plainer.spec
SRPM URL:
https://dl.dropbox.com/u/64704553/perl-Pod-Plainer-1.03-1.fc16.src.rpm

Thanks very much, Petr.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806594] Review Request: python-django-notification - User notification management for the Django web framework

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806594

--- Comment #7 from Matthias Runge mru...@matthias-runge.de 2012-03-27 
07:57:41 EDT ---
imported, built, django-notification retired, request for blocking
https://fedorahosted.org/rel-eng/ticket/5147

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806562] Review Request: python-django-pagination - Django pagination tools

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806562

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2012-03-27 07:57:09

--- Comment #10 from Matthias Runge mru...@matthias-runge.de 2012-03-27 
07:57:09 EDT ---
imported, built, django-pagination deprecated, request for blocking
https://fedorahosted.org/rel-eng/ticket/5147

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806594] Review Request: python-django-notification - User notification management for the Django web framework

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806594

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2012-03-27 07:57:56

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805035] Review Request: janino-parent - Parent POM for Janino

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805035

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805035] Review Request: janino-parent - Parent POM for Janino

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805035

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
08:10:41 EDT ---
janino-parent-2.6.1-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/janino-parent-2.6.1-2.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 800526] Review Request: seahorse-sharing - Sharing of PGP public keys via DNS-SD and HKP

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=800526

--- Comment #5 from Rui Matos tiagoma...@gmail.com 2012-03-27 08:13:58 EDT ---
Ok, here it is, updated to the latest upstream as well:

Spec URL: http://glua.ua.pt/~rmatos/seahorse-sharing.spec
SRPM URL: http://glua.ua.pt/~rmatos/seahorse-sharing-3.4.0-1.fc17.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=3936205

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 713313] Review Request: msktutil - Program for interoperability with Active Directory

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713313

--- Comment #41 from Jon Ciesla limburg...@gmail.com 2012-03-27 08:19:50 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806011] Review Request: jboss-jstl-1.2-api - JSP Standard Template Library 1.2 API

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806011

--- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-03-27 08:22:53 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 791247] Review Request: jboss-remote-naming - JBoss Remote Naming

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=791247

--- Comment #5 from Jon Ciesla limburg...@gmail.com 2012-03-27 08:22:24 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #11 from Jon Ciesla limburg...@gmail.com 2012-03-27 08:23:25 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802182] Review Request: ironjacamar - Java Connector Architecture 1.6 implementation

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802182

--- Comment #6 from Juan Hernández juan.hernan...@redhat.com 2012-03-27 
08:42:31 EDT ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!]  Rpmlint output:

Output of rpmlint of the source package:

$ rpmlint ironjacamar-1.0.9-2.fc17.src.rpm 
ironjacamar.src: W: invalid-url URL: http://www.jboss.org/ironjacamar HTTP
Error 403: Forbidden
ironjacamar.src: W: invalid-url Source13:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-spec-api-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source12:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-common-api-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source11:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-validator-ant-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source10:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-core-api-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source9:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-validator-maven-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source8:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-common-spi-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source7:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-jdbc-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source6:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-core-impl-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source5:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-validator-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source4:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-common-impl-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source3:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-validator-cli-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source2:
https://repository.jboss.org/nexus/service/local/repositories/releases/content/org/jboss/ironjacamar/ironjacamar-deployers-common/1.0.9.Final/ironjacamar-common-impl-papaki-1.0.9.Final.pom
HTTP Error 404: The server has not found anything matching the request URI
ironjacamar.src: W: invalid-url Source0: ironjacamar-1.0.9.Final-CLEAN.tar.xz
1 packages and 0 specfiles checked; 0 errors, 14 warnings.

The URLs that fail can all be retrieved using the shell script snippet provided
in the spec file.

Output of rpmlint of the binary packages:

$ rpmlint ironjacamar-1.0.9-2.fc18.noarch.rpm
ironjacamar-javadoc-1.0.9-2.fc18.noarch.rpm
ironjacamar.noarch: W: invalid-url URL: http://www.jboss.org/ironjacamar HTTP
Error 403: Forbidden
ironjacamar.noarch: W: class-path-in-manifest
/usr/share/java/ironjacamar/ironjacamar-validator.jar
ironjacamar-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java
docs, Java-docs, Avocados
ironjacamar-javadoc.noarch: W: invalid-url URL:
http://www.jboss.org/ironjacamar HTTP Error 403: Forbidden
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

The 

[Bug 806669] Review Request: janino - An embedded Java compiler

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806669

--- Comment #1 from gil cattaneo punto...@libero.it 2012-03-27 08:53:13 EDT 
---
Spec URL: http://gil.fedorapeople.org/janino.spec
SRPM URL: http://gil.fedorapeople.org/janino-2.6.1-2.fc16.src.rpm
merged with mefoster's janino spec files
provides janino, parent, commons-compiler and commons-compiler-jdk

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760154] Review Request: xcb-util-keysyms - Standard X key constants and keycodes conversion on top of libxcb

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760154

--- Comment #7 from Jon Ciesla limburg...@gmail.com 2012-03-27 09:01:09 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 760154] Review Request: xcb-util-keysyms - Standard X key constants and keycodes conversion on top of libxcb

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=760154

Thomas Moschny thomas.mosc...@gmx.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #6 from Thomas Moschny thomas.mosc...@gmx.de 2012-03-27 08:58:59 
EDT ---
Thanks for the review! (And sorry for the wrong link.)

New Package SCM Request
===
Package Name: xcb-util-keysyms
Short Description: Standard X key constants and keycodes conversion on top of
libxcb
Owners: thm
Branches: f17
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802758] Review Request: drupal6-drush - cli for drupal management

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802758

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802758] Review Request: drupal6-drush - cli for drupal management

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802758

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
09:00:19 EDT ---
drupal6-drush-4.1-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal6-drush-4.1-3.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802761] Review Request: drupal6-geshifilter - geshifilter module for drupal6

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802761

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802761] Review Request: drupal6-geshifilter - geshifilter module for drupal6

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802761

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
09:02:19 EDT ---
drupal6-geshifilter-1.4-5.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/drupal6-geshifilter-1.4-5.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802761] Review Request: drupal6-geshifilter - geshifilter module for drupal6

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802761

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
09:09:15 EDT ---
drupal6-geshifilter-1.4-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/drupal6-geshifilter-1.4-5.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802758] Review Request: drupal6-drush - cli for drupal management

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802758

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
09:07:08 EDT ---
drupal6-geshifilter-1.4-5.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/drupal6-geshifilter-1.4-5.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802761] Review Request: drupal6-geshifilter - geshifilter module for drupal6

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802761

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
09:08:45 EDT ---
drupal6-geshifilter-1.4-5.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/drupal6-geshifilter-1.4-5.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802758] Review Request: drupal6-drush - cli for drupal management

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802758

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
09:11:57 EDT ---
drupal6-drush-4.1-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/drupal6-drush-4.1-3.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 802758] Review Request: drupal6-drush - cli for drupal management

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=802758

--- Comment #10 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 09:13:40 EDT ---
drupal6-drush-4.1-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/drupal6-drush-4.1-3.fc16

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 799284] Review Request: perl-Pod-Plainer - Perl extension for converting Pod to old-style Pod

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799284

--- Comment #8 from Petr Šabata psab...@redhat.com 2012-03-27 09:15:17 EDT ---
Ok, fine.
I've approved this review already. You should submit an SCM request now.
http://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-review?  |fedora-review+

--- Comment #11 from Michael Scherer m...@zarb.org 2012-03-27 09:15:05 EDT ---
[x]: MUST Changelog in prescribed format.

So the package is good to go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806678] Review Request: logback - A Java logging library

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806678

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG
Last Closed||2012-03-27 09:29:40

--- Comment #3 from gil cattaneo punto...@libero.it 2012-03-27 09:29:40 EDT 
---
package merged in Mary Ellen Foster spec file she soon will reopen the bug

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 611372] Review Request: perl-Net-Twitter - Perl interface to Twitter

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611372

--- Comment #16 from Petr Šabata psab...@redhat.com 2012-03-27 09:30:46 EDT 
---
Looking at the changes...

You've added the required build time dependencies, including the optional ones.
OK.

You've removed %defattr, the BuildRoot tag, buildroot removal in %install but
you've kept the %clean section. You could just drop it entirely.
Sort of OK.

About the runtime dependencies -- sadly, rpmbuild doesn't detect everything. It
usually fails with 'use's and 'require's in indented blocks, for example.
I see you've just removed them all. I think you're missing some deps now but
I'll have to check that again...

I usually respect the versions in Makefile/META since those are the versions
the original author developed and tested the module with.  However, as I said
before, it's up to you :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tinycdb - Utility and library for manipulating constant databases

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
09:35:28 EDT ---
tinycdb-0.77-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/tinycdb-0.77-4.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806926] Review Request: tinycdb - Utility and library for manipulating constant databases

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806926

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591190] Review Request: debhelper - Helper programs for debian/rules

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591190

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

 CC||msu...@redhat.com

--- Comment #17 from Miroslav Suchý msu...@redhat.com 2012-03-27 09:33:24 EDT 
---
debhelper.noarch: W: incoherent-version-in-changelog 9.20120322
['9.20120322-1.fc18', '9.20120322-1']
You are missing that release number -1 in changelog entry.

debhelper.noarch: W: doc-file-dependency
/usr/share/doc/debhelper-9.20120322/examples/rules.tiny /usr/bin/make
There is make, which is automatically added to requires. As it is not used
anywhere else in real code, you should filter this dependency out:
http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#.25_docdir_filtering

What happened with %check section?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

--- Comment #13 from Jon Ciesla limburg...@gmail.com 2012-03-27 09:40:01 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 737972] Review Request: spacewalk-admin - Various utility scripts and data files for RHN Satellite installations

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737972

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #12 from Miroslav Suchý msu...@redhat.com 2012-03-27 09:36:57 EDT 
---
New Package SCM Request
===
Package Name: spacewalk-admin
Short Description: Various utility scripts and data files for RHN Satellite
installations
Owners: msuchy
Branches: F-17, F-16, EL-5, EL-6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 799284] Review Request: perl-Pod-Plainer - Perl extension for converting Pod to old-style Pod

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799284

xn...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #9 from xn...@redhat.com 2012-03-27 09:42:55 EDT ---
New Package SCM Request
===
Package Name: perl-Pod-Plainer
Short Description: Perl extension for converting Pod to old-style Pod
Owners: xning
Branches: f16 f17 el5 el6
InitialCC: psabata perl-sig pnemade

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 799284] Review Request: perl-Pod-Plainer - Perl extension for converting Pod to old-style Pod

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799284

--- Comment #10 from Jon Ciesla limburg...@gmail.com 2012-03-27 09:45:17 EDT 
---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805487] Review Request: logback - A Java logging library

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805487

Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|DUPLICATE   |
   Keywords||Reopened

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806678] Review Request: logback - A Java logging library

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806678

Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

 Resolution|NOTABUG |DUPLICATE

--- Comment #4 from Mary Ellen Foster mefos...@gmail.com 2012-03-27 09:48:45 
EDT ---


*** This bug has been marked as a duplicate of bug 805487 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805487] Review Request: logback - A Java logging library

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805487

Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 805487] Review Request: logback - A Java logging library

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805487

Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

 CC||punto...@libero.it

--- Comment #4 from Mary Ellen Foster mefos...@gmail.com 2012-03-27 09:48:45 
EDT ---
*** Bug 806678 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806665] Review Request: mosh - Mobile shell that supports roaming and intelligent local echo

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806665

Alex Chernyakhovsky acher...@mit.edu changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 806777] Review Request: python-restkit - Restkit is an HTTP resource kit for Python

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=806777

--- Comment #12 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 10:00:23 EDT ---
python-restkit-4.1.2-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-restkit-4.1.2-2.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 794941] Review Request: neethi - Web Services Policy framework

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=794941

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2012-03-27 
10:10:43 EDT ---
neethi-3.0.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/neethi-3.0.1-1.fc17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 794941] Review Request: neethi - Web Services Policy framework

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=794941

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807328] New: Review Request: drupal6-og - Organic Group Module for Drupal6

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: drupal6-og - Organic Group Module for Drupal6

https://bugzilla.redhat.com/show_bug.cgi?id=807328

   Summary: Review Request: drupal6-og - Organic Group Module for
Drupal6
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ansi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://people.redhat.com/~ansilva/drupal6-og.spec
SRPM URL: http://people.redhat.com/~ansilva/drupal6-og-2.2-3.fc16.src.rpm
Description: Enable users to create and manage their own 'groups'.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807331] New: Review Request: drupal6-addthis - AddThis module for Drupal6.

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: drupal6-addthis - AddThis module for Drupal6.

https://bugzilla.redhat.com/show_bug.cgi?id=807331

   Summary: Review Request: drupal6-addthis - AddThis module for
Drupal6.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ansi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://people.redhat.com/~ansilva/drupal6-addthis.spec
SRPM URL:
http://people.redhat.com/~ansilva/drupal6-addthis-3.0-3.beta2.fc16.src.rpm
Description: AddThis module for Drupal6.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807350] Review Request: seahorse-nautilus - PGP encryption and signing for nautilus

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807350

Rui Matos tiagoma...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807350] New: Review Request: seahorse-nautilus - PGP encryption and signing for nautilus

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: seahorse-nautilus - PGP encryption and signing for 
nautilus

https://bugzilla.redhat.com/show_bug.cgi?id=807350

   Summary: Review Request: seahorse-nautilus - PGP encryption and
signing for nautilus
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: unspecified
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: tiagoma...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://glua.ua.pt/~rmatos/seahorse-nautilus.spec
SRPM URL: http://glua.ua.pt/~rmatos/seahorse-nautilus-3.4.0-1.fc17.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=3936783

This was split from seahorse-plugins upstream. Please review, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 611372] Review Request: perl-Net-Twitter - Perl interface to Twitter

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611372

--- Comment #18 from Julian C. Dunn jd...@aquezada.com 2012-03-27 11:19:09 
EDT ---
(In reply to comment #17)
 So, after going through the deps again, I see only perl(Net::Netrc) doesn't 
 get
 autodetected and you should require it explicitly.

I left that out deliberately since the author says reading credentials from
.netrc is an optional feature; the require is wrapped in an if statement in
the code. Do you think it should be included as a dep unconditionally? I'm
happy to include it as an extra Requires if you think it makes sense.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 724936] Review Request: python-mock - A Python Mocking and Patching Library for Testing

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=724936

--- Comment #25 from Fedora Update System upda...@fedoraproject.org 
2012-03-27 11:31:02 EDT ---
python-mock-0.8.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-mock-0.8.0-1.el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 611372] Review Request: perl-Net-Twitter - Perl interface to Twitter

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611372

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #19 from Petr Šabata psab...@redhat.com 2012-03-27 11:33:16 EDT 
---
(In reply to comment #18)
 (In reply to comment #17)
  So, after going through the deps again, I see only perl(Net::Netrc) doesn't 
  get
  autodetected and you should require it explicitly.
 
 I left that out deliberately since the author says reading credentials from
 .netrc is an optional feature;

Fair enough.

 the require is wrapped in an if statement in
 the code. Do you think it should be included as a dep unconditionally? I'm
 happy to include it as an extra Requires if you think it makes sense.

It's up to you.  If you think most users would benefit from it, it might be a
good idea.

Approving.
(You should now submit an SCM request.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807017] Review Request: ovirt-engine - Management server for Open Virtualization

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807017

Ofer Schreiber oschr...@redhat.com changed:

   What|Removed |Added

 CC||oschr...@redhat.com

--- Comment #2 from Ofer Schreiber oschr...@redhat.com 2012-03-27 11:47:44 
EDT ---
I'm trying to do a review, but the mock build fails due to:
Error: No Package found for spring-ldap

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807375] New: Review Request: kwooty - A friendly nzb usenet binary download application

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: kwooty - A friendly nzb usenet binary download 
application

https://bugzilla.redhat.com/show_bug.cgi?id=807375

   Summary: Review Request: kwooty - A friendly nzb usenet binary
download application
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: gre...@freenet.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://brummbq.fedorapeople.org/kwooty.spec
SRPM URL: http://brummbq.fedorapeople.org/kwooty-0.8.3-1.fc16.src.rpm
Description:
Kwooty is a NZB usenet binary downloader for KDE 4. Features : automatic file
verification - repairing with par2 files, automatic archive extraction (Rar,
Zip and 7z archive formats supported), built-in YEnc and UUEncode file
decoders, ...

atm I'm using version 0.8.3 - a non released version (contains various fixes)
upstream send directly to me. I will upgrade as soon as possible.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 611372] Review Request: perl-Net-Twitter - Perl interface to Twitter

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611372

--- Comment #17 from Petr Šabata psab...@redhat.com 2012-03-27 11:06:54 EDT 
---
So, after going through the deps again, I see only perl(Net::Netrc) doesn't get
autodetected and you should require it explicitly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807017] Review Request: ovirt-engine - Management server for Open Virtualization

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=807017

--- Comment #3 from Juan Hernández juan.hernan...@redhat.com 2012-03-27 
11:55:00 EDT ---
The spring-ldap was added just yesterday, so it is available currently only in
rawhide and won't probably yet reached all mirrors. You can get it here:

http://koji.fedoraproject.org/koji/buildinfo?buildID=309704

Thanks for testing!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807383] New: Review Request: PythonMagick - Interface to ImageMagick for Python written in C++

2012-03-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: PythonMagick - Interface to ImageMagick for Python 
written in C++

https://bugzilla.redhat.com/show_bug.cgi?id=807383

   Summary: Review Request: PythonMagick - Interface to
ImageMagick for Python written in C++
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: unspecified
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: philip.worr...@googlemail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org
Classification: Fedora
  Story Points: ---
  Type: ---
Regression: ---
Mount Type: ---
 Documentation: ---


Spec URL: http://www.freefilehosting.net/pythonmagick 
SRPM URL: http://www.freefilehosting.net/pythonmagick-097-1fc15src_1 
Description: PythonMagick is an object-oriented Python interface to ImageMagick

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >