[Bug 919442] Review Request: R-Rsamtools - R interface to samtools
https://bugzilla.redhat.com/show_bug.cgi?id=919442 --- Comment #13 from Pierre-YvesChibon pin...@pingoured.fr --- ping ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mh3FJnvxULa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 919442] Review Request: R-Rsamtools - R interface to samtools
https://bugzilla.redhat.com/show_bug.cgi?id=919442 Pierre-YvesChibon pin...@pingoured.fr changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-09-05 02:16:07 --- Comment #14 from Pierre-YvesChibon pin...@pingoured.fr --- apparently it's in and build and all, thus closing here. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RTT4miAWRla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912960] Review Request: rubygem-gdk3 - Ruby binding of GDK-3.x
https://bugzilla.redhat.com/show_bug.cgi?id=912960 --- Comment #29 from Miroslav Suchý msu...@redhat.com --- I will bring this to packagers list. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=B36WhoJcZaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839056] Review Request: python-flake8 - code checking using pep8 and pyflakes
https://bugzilla.redhat.com/show_bug.cgi?id=839056 --- Comment #16 from Pierre-YvesChibon pin...@pingoured.fr --- Fails to build on a F19 mock due to missing python3-pyflakes -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4tymJLemlZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839056] Review Request: python-flake8 - code checking using pep8 and pyflakes
https://bugzilla.redhat.com/show_bug.cgi?id=839056 --- Comment #17 from Pierre-YvesChibon pin...@pingoured.fr --- Corresponding logs in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5898306 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=08bSaSX22za=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 678809] Review Request: seeks - A web-search proxy that provides a meta-search engine
https://bugzilla.redhat.com/show_bug.cgi?id=678809 --- Comment #30 from Pierre-YvesChibon pin...@pingoured.fr --- I was (re)starting the review of this package but: + seems to fail building (both locally and on koji): http://koji.fedoraproject.org/koji/taskinfo?taskID=5898333 + I have the impression it's bundling protobuf (see src/proxy/protobuf_export_format) Other than this, the sources look good and the spec is clean. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0CheS0YsB3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004209] Review Request: nlopt - Open-source library for nonlinear optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1004209 Matthias Runge mru...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mru...@redhat.com Assignee|nob...@fedoraproject.org|mru...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=A7npCBMxNDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839056] Review Request: python-flake8 - code checking using pep8 and pyflakes
https://bugzilla.redhat.com/show_bug.cgi?id=839056 Matthias Runge mru...@redhat.com changed: What|Removed |Added Depends On||1004668 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rWwNQiHf8Ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004678] New: Review Request: python-cov-core - Plugin core for use by pytest-cov, nose-cov and nose2-cov
https://bugzilla.redhat.com/show_bug.cgi?id=1004678 Bug ID: 1004678 Summary: Review Request: python-cov-core - Plugin core for use by pytest-cov, nose-cov and nose2-cov Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: bkab...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://bkabrda.fedorapeople.org/pkgs/cov-core/python-cov-core.spec SRPM URL: http://bkabrda.fedorapeople.org/pkgs/cov-core/python-cov-core-1.7-1.fc19.src.rpm Description: This is a lib package for use by pytest-cov, nose-cov and nose2-cov. If you're developing a coverage plugin for a test framework then you probably want one of those. Fedora Account System Username: bkabrda -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ce5QJSQq9la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004209] Review Request: nlopt - Open-source library for nonlinear optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1004209 Matthias Runge mru...@redhat.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|mru...@redhat.com |nob...@fedoraproject.org Flags|fedora-review? | --- Comment #1 from Matthias Runge mru...@redhat.com --- Since this is a collection of libraries with different licenses/copyrights, we'd at least need a license breakdown here. In my opinion, using macros that much makes the spec slightly unreadable. But that's personal preference. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MPakKQ5eKJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004257] Review Request: pudb - console-based Python debugger
https://bugzilla.redhat.com/show_bug.cgi?id=1004257
Parag AN(पराग) panem...@gmail.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #6 from Parag AN(पराग) panem...@gmail.com ---
Review:-
+ package builds fine in mock (f21)
- rpmlint output on rpms gave
python3-pudb.noarch: E: non-executable-script
/usr/lib/python3.3/site-packages/pudb/debugger.py 0644L /usr/bin/env
python3-pudb.noarch: W: no-manual-page-for-binary pudb3
python-pudb.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/pudb/debugger.py 0644L /usr/bin/env
python-pudb.noarch: W: no-manual-page-for-binary pudb
3 packages and 0 specfiles checked; 2 errors, 2 warnings.
+ Source verified with upstream as (sha256sum)
tarball in srpm :
3f99f6f1d85808f6f17ee86a2bb28845e86c9bb3e72868d6bfe10ef7e22bcfff
tarball from upstream :
3f99f6f1d85808f6f17ee86a2bb28845e86c9bb3e72868d6bfe10ef7e22bcfff
+ License is MIT and there is license text in any source file or own license
text file.
Suggestions:
1) I assume you are not building this package on el5 and el6, so remove invalid
buildroot. See http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
2) I assume you are not building this package on el5 and el6, so remove
following from spec as its not needed anymore in Fedora
%if ! (0%{?rhel} 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
%endif
If you want to build for EPEL then keep above.
3) BuildRequires: python-devel should be changed to python2-devel
See https://fedoraproject.org/wiki/:Python#BuildRequires
4) rpmlint output is showing non-executable-script error. To fix this add
following line in %prep but before copying to py3dir
sed -i '1{\@^#! /usr/bin/env python@d}' pudb/debugger.py
5) I don't think you will need to write explicitly attr(0755, root, root) for
/usr/bin/pudb. Remove attr().
6) source package does not include license text as a separate file from
upstream, the packager SHOULD query upstream to include it.
Please bump the release tag when you will fix above issues and submit a new
srpm.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=PgbqdTX9Zta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004678] Review Request: python-cov-core - Plugin core for use by pytest-cov, nose-cov and nose2-cov
https://bugzilla.redhat.com/show_bug.cgi?id=1004678 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7F6nhNrdJDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004565] Review Request: eureka - A cross-platform map editor for the classic DOOM games
https://bugzilla.redhat.com/show_bug.cgi?id=1004565 Jay Greguske jgreg...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #2 from Jay Greguske jgreg...@redhat.com --- Here are some direct links: http://jgreguske.fedorapeople.org/eureka/eureka-1.00-1.fc19.src.rpm http://jgreguske.fedorapeople.org/eureka/eureka.spec No plans for EPEL. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PIuX5vJ6KKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004760] New: Review Request: ColPack - Algorithms for the specialized vertex coloring problems
https://bugzilla.redhat.com/show_bug.cgi?id=1004760 Bug ID: 1004760 Summary: Review Request: ColPack - Algorithms for the specialized vertex coloring problems Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: bjoern.es...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Description: ColPack is a package comprising of implementation of algorithms for specialized vertex coloring problems that arise in sparse derivative computation. It is written in an object-oriented fashion heavily using the Standard Template Library (STL). It is designed to be simple, modular, extendable and efficient. Koji Builds: el5: https://koji.fedoraproject.org/koji/taskinfo?taskID=5898942 el6: https://koji.fedoraproject.org/koji/taskinfo?taskID=5898946 F18: https://koji.fedoraproject.org/koji/taskinfo?taskID=5898950 F19: https://koji.fedoraproject.org/koji/taskinfo?taskID=5898953 F20: https://koji.fedoraproject.org/koji/taskinfo?taskID=5898956 Frh: https://koji.fedoraproject.org/koji/taskinfo?taskID=5898960 Issues: fedora-review shows no issues, rpmlint reports some false positives. Fedora Account System Username: besser82 Urls: Spec URL: http://besser82.fedorapeople.org/review/ColPack.spec SRPM URL: http://besser82.fedorapeople.org/review/ColPack-1.0.9-1.fc19.src.rpm # Thanks for review in advance! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Tf675IHVMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004760] Review Request: ColPack - Algorithms for the specialized vertex coloring problems
https://bugzilla.redhat.com/show_bug.cgi?id=1004760 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Alias||ColPack -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=k9HsG20zYSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004544] Package Review: grub2-icons
https://bugzilla.redhat.com/show_bug.cgi?id=1004544
Susi Lehtola susi.leht...@iki.fi changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
CC||susi.leht...@iki.fi
--- Comment #3 from Susi Lehtola susi.leht...@iki.fi ---
URL: http://sea.fedorapeople.org/Review/%{name}
Source0:
http://sea.fedorapeople.org/Review/%{name}/%{name}-%{version}.tar.gz
This looks like pure nonsense. Where are the icons from? Upstream URL?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=EDZ2PFmwtaa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #6 from Christopher Meng cicku...@gmail.com --- I think you should request an additional +1. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=awPXQrUKPxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882704] Review Request: otopi - oVirt Task Oriented Pluggable Installer/Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=882704 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com Flags||needinfo?(dougsland@redhat. ||com) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3adgZhewH2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969718] Review Request: pbuilder - Personal package builder for Debian packages
https://bugzilla.redhat.com/show_bug.cgi?id=969718 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com Flags||needinfo? --- Comment #11 from Christopher Meng cicku...@gmail.com --- Status? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M1WAUjC8x8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884759] Review Request: toilet - colorful ASCII art generator
https://bugzilla.redhat.com/show_bug.cgi?id=884759 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com Flags||needinfo?(pknirsch@redhat.c ||om) --- Comment #11 from Christopher Meng cicku...@gmail.com --- Status? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UlKAoZMu25a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 865699] Review Request: ladish - LADI Audio session handler
https://bugzilla.redhat.com/show_bug.cgi?id=865699 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com Flags||needinfo?(echevemaster@gmai ||l.com) --- Comment #18 from Christopher Meng cicku...@gmail.com --- Do you have time now? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y7rAvHZezQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 884759] Review Request: toilet - colorful ASCII art generator
https://bugzilla.redhat.com/show_bug.cgi?id=884759 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||zidkova.zuz...@seznam.cz Flags||needinfo?(zidkova.zuzana@se ||znam.cz) --- Comment #12 from Christopher Meng cicku...@gmail.com --- What's up? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wXz8gbDIx4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969718] Review Request: pbuilder - Personal package builder for Debian packages
https://bugzilla.redhat.com/show_bug.cgi?id=969718 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||needinfo?(ser...@serjux.com ||) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VQTtffhjbya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com Flags||needinfo?(mizdebsk@redhat.c ||om) --- Comment #22 from Christopher Meng cicku...@gmail.com --- Ping? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U0qHIQbQAza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949895] Review Request: python3-bsddb3 - Python3 bindings for BerkleyDB
https://bugzilla.redhat.com/show_bug.cgi?id=949895 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com, ||jsta...@redhat.com Flags||needinfo?(jsta...@redhat.co ||m) --- Comment #2 from Christopher Meng cicku...@gmail.com --- Status? perl-XML-Tiny -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EA6IZsKx6Qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967337] Review Request: rubygem-faraday - HTTP/REST API client library
https://bugzilla.redhat.com/show_bug.cgi?id=967337 Axilleas Pipinellis axill...@archlinux.gr changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #11 from Axilleas Pipinellis axill...@archlinux.gr --- (In reply to Vít Ondruch from comment #9) (In reply to Axilleas Pipinellis from comment #6) - multibyte.txt is included in test/ so it is not needed to download it in %prep. Just remark: It is forbidden to download anything during build. Moreover, it is even not possible, since there is no network available in Koji build. So this definitely have to be fixed. Thanks, will keep that in mind. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u61bMXgcvBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1000583] Review Request: fcitx-anthy - Anthy Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=1000583
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #2 from Christopher Meng cicku...@gmail.com ---
Directories without known owners:
%{_datadir}/fcitx/anthy/*.sty
---
%{_datadir}/fcitx/anthy
===
Suggestion:
Name:fcitx-anthy
Version:0.2.0
Release:1%{?dist}
Summary:Anthy Engine for Fcitx
Group:System Environment/Libraries
License:GPLv2+
URL:https://fcitx-im.org/wiki/Anthy
Source0:
http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz
BuildRequires:cmake
BuildRequires:fcitx-devel
BuildRequires:gettext
BuildRequires:intltool
BuildRequires:anthy-devel
Requires:fcitx
Auh, a bit ugly...
Name:fcitx-anthy
Version:0.2.0
Release:1%{?dist}
Summary:Anthy Engine for Fcitx
Group:System Environment/Libraries
License:GPLv2+
URL:https://fcitx-im.org/wiki/Anthy
Source0:http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz
BuildRequires:anthy-devel
BuildRequires:cmake
BuildRequires:fcitx-devel
BuildRequires:gettext
BuildRequires:intltool
Requires:fcitx
Also, %description is too short.
Orig:
Fcitx-anthy is an Anthy engine wrapper for Fcitx. It
provides a Japanese input method.
Mine:
Fcitx-anthy is an Anthy engine wrapper for Fcitx based on scim-anthy. It
provides a Japanese input method. Users can input Japanese hiragana and
katakana by inputting romaji via fcitx-anthy. Fcitx-anthy can also convert
hiragana or katakana to Japanese kanji after inputting hiragana or katakana.
*
Please FIX the issue before SCM.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=4GLI2s0zsCa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004209] Review Request: nlopt - Open-source library for nonlinear optimization
https://bugzilla.redhat.com/show_bug.cgi?id=1004209 Will Benton wi...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|NEW |ASSIGNED CC||wi...@redhat.com Assignee|nob...@fedoraproject.org|wi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tXGtZgGeUIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004760] Review Request: ColPack - Algorithms for the specialized vertex coloring problems
https://bugzilla.redhat.com/show_bug.cgi?id=1004760 Will Benton wi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||wi...@redhat.com Assignee|nob...@fedoraproject.org|wi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IfY0tjiSoAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952347] Review Request: ovirt-image-uploader - Image Uploader tool for oVirt Engine
https://bugzilla.redhat.com/show_bug.cgi?id=952347 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #6 from Christopher Meng cicku...@gmail.com --- Why WONTFIX? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ezrwqcm4EBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952354] Review Request: ovirt-log-collector - Log Collector tool for oVirt Engine
https://bugzilla.redhat.com/show_bug.cgi?id=952354 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #6 from Christopher Meng cicku...@gmail.com --- Why WONTFIX? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zPRUejkflTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952351] Review Request: ovirt-iso-uploader - ISO Uploader tool for oVirt Engine
https://bugzilla.redhat.com/show_bug.cgi?id=952351 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #9 from Christopher Meng cicku...@gmail.com --- Why WONTFIX? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UigDAT0iELa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969718] Review Request: pbuilder - Personal package builder for Debian packages
https://bugzilla.redhat.com/show_bug.cgi?id=969718 Sergio Monteiro Basto ser...@serjux.com changed: What|Removed |Added Flags|needinfo? | |needinfo?(ser...@serjux.com | |) | --- Comment #12 from Sergio Monteiro Basto ser...@serjux.com --- Lets build devscripts -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=h6n9vfVj42a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004678] Review Request: python-cov-core - Plugin core for use by pytest-cov, nose-cov and nose2-cov
https://bugzilla.redhat.com/show_bug.cgi?id=1004678 --- Comment #2 from Christopher Meng cicku...@gmail.com --- Ah... bugzilla just caught errors. Please note that python-devel should be python2-devel. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bt33v30wwBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] New: Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 Bug ID: 1004845 Summary: Review Request: python-libarchive - Fully functional Python wrapper for libarchive. Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dkho...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-libarchive/python-libarchive.spec SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-libarchive/python-libarchive-3.1.2.1-1.fc19.src.rpm Description: Fully functional Python wrapper for libarchive. Created using SWIG. The low-level API provides access to all of the functionality of libarchive. The package also includes a high level python library which mimics the zipfile and tarfile modules. For more details, see http://code.google.com/p/python-libarchive/ Fedora Account System Username: halfie I use this package almost every day. So, it would be great to have it in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Bb31XkVXTOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 Dhiru Kholia dkho...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SkQ54Pg9aha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 Paul Wouters pwout...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||pwout...@redhat.com Assignee|nob...@fedoraproject.org|pwout...@redhat.com Flags||fedora-review? --- Comment #1 from Paul Wouters pwout...@redhat.com --- I'll take it, as I'm already going to sponsor Dhiru -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gJwcji15Tsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004678] Review Request: python-cov-core - Plugin core for use by pytest-cov, nose-cov and nose2-cov
https://bugzilla.redhat.com/show_bug.cgi?id=1004678 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Christopher Meng cicku...@gmail.com --- Package looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wU4jgNzRPKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004030] Review Request: ovirt-scheduler-proxy - Scheduling Proxy for Open Virtualization
https://bugzilla.redhat.com/show_bug.cgi?id=1004030 Martin Sivák msi...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #1 from Martin Sivák msi...@redhat.com --- Please use the new version as Juan had comments about the licensing. Spec URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy.spec SRPM URL: http://msivak.fedorapeople.org/newpkg/ovirt-scheduler-proxy-0.1.1-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=61bRec3Rvla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 --- Comment #23 from gil cattaneo punto...@libero.it --- pong? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=H8SeFA1guUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 994152] Review Request: libprocess - Library that provides an actor style message-passing
https://bugzilla.redhat.com/show_bug.cgi?id=994152 --- Comment #8 from Timothy St. Clair tstcl...@redhat.com --- Updated: spec: http://tstclair.fedorapeople.org/mesos/libprocess/libprocess.spec srpm: http://tstclair.fedorapeople.org/mesos/libprocess/libprocess-0.0.1-7.c2373fa.fc21.src.rpm re comment #5 - it's in the proper location(s) re comment #6 - There are 2 standard locations, I have no real preference, if it's a blocker I'll change re comment #7 - fixed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G00JWYGp6Fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 --- Comment #2 from Paul Wouters pwout...@redhat.com --- build fails for me on f18... paul@bofh:/vol/home/paul/1004257-python-pudb/1004845-python-libarchive$ rpmbuild -ba ./srpm/python-libarchive.spec Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.rpePkY + umask 022 + cd /home/paul/BUILD + cd /home/paul/BUILD + rm -rf python-libarchive-3.1.2-1 + /usr/bin/gzip -dc /home/paul/SOURCES/python-libarchive-3.1.2-1.tar.gz + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd python-libarchive-3.1.2-1 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + rm -rf libarchive.egg-info + exit 0 Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.E6oOMA + umask 022 + cd /home/paul/BUILD + cd python-libarchive-3.1.2-1 + /usr/bin/python setup.py build running build running build_py creating build creating build/lib.linux-x86_64-2.7 creating build/lib.linux-x86_64-2.7/libarchive copying libarchive/zip.py - build/lib.linux-x86_64-2.7/libarchive copying libarchive/__init__.py - build/lib.linux-x86_64-2.7/libarchive copying libarchive/_libarchive.py - build/lib.linux-x86_64-2.7/libarchive copying libarchive/tar.py - build/lib.linux-x86_64-2.7/libarchive running build_ext building 'libarchive.__libarchive' extension creating build/temp.linux-x86_64-2.7 creating build/temp.linux-x86_64-2.7/libarchive gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC -Ilibarchive -I/usr/include/python2.7 -c libarchive/_libarchive_wrap.c -o build/temp.linux-x86_64-2.7/libarchive/_libarchive_wrap.o libarchive/_libarchive_wrap.c: In function 'init__libarchive': libarchive/_libarchive_wrap.c:6245:21: warning: variable 'md' set but not used [-Wunused-but-set-variable] gcc -pthread -shared -Wl,-z,relro build/temp.linux-x86_64-2.7/libarchive/_libarchive_wrap.o -L/usr/lib64 -larchive -lpython2.7 -o build/lib.linux-x86_64-2.7/libarchive/__libarchive.so -l:libarchive.so.13.1.2 /usr/bin/ld: cannot find libarchive.so.13.1.2 collect2: error: ld returned 1 exit status error: command 'gcc' failed with exit status 1 error: Bad exit status from /var/tmp/rpm-tmp.E6oOMA (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.E6oOMA (%build) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VaZDhgen2na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 --- Comment #5 from Paul Wouters pwout...@redhat.com --- I does not specify a minimum version of libarchive. Often people grab srpms from one branch and use it on another. So if this python package only works with some minimal version, it should be added as minimum version to the Requires: (even if f20 does not ship versions old enough to not work) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lxf9UKR03ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 --- Comment #7 from Paul Wouters pwout...@redhat.com --- this was build on a fresh f19 VM. installed libarchive/libarchive-devel, build python-libarchive, then ran the test that segfaults -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=utzrI8MIdia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845
--- Comment #8 from Björn besser82 Esser bjoern.es...@gmail.com ---
Some general comments on the spec-file:
* Use of %define:
%define upstream_version 3.1.2
%define upstream_release 1
Use %global instead of %define.
See:
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define
* no %check, though there's a testsuite in sources:
BuildRequires: swig
%check
%{__python} tests.py
http://code.google.com/p/python-libarchive/wiki/Building
* What are these used for?
%global upstream_name python-libarchive
%global module_name libarchive
* Use the macro you define more common:
Version: %{upstream_version}.%{upstream_release}
* no proper export of compiler-flags before build:
Add %configure ||: on top inside %build
There might be more issues, this just came from quick glance over the spec.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=UjX8LkYrESa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1001351] Review Request: glite-lbjp-common-db - Database engine abstraction wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=1001351 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- glite-lbjp-common-db-3.2.8-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oNrvmHLIw1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] New: Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 Bug ID: 1004913 Summary: Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: thomas.mosc...@gmx.de QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://thm.fedorapeople.org/perl-Gtk2-SourceView2/perl-Gtk2-SourceView2.spec SRPM URL: http://thm.fedorapeople.org/perl-Gtk2-SourceView2/perl-Gtk2-SourceView2-0.10-1.fc21.src.rpm Description: Perl bindings for the C library libgtksourceview2 that extends the standard GTK+ framework for multiline text editing with support for configurable syntax highlighting, unlimited undo/redo, UTF-8 compliant caseless searching, printing and other features typical of a source code editor. Fedora Account System Username: thm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tvycNsEXaNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC||bjoern.es...@gmail.com --- Comment #3 from Björn besser82 Esser bjoern.es...@gmail.com --- (In reply to Paul Wouters from comment #2) build fails for me on f18... build/lib.linux-x86_64-2.7/libarchive/__libarchive.so -l:libarchive.so.13.1.2 /usr/bin/ld: cannot find libarchive.so.13.1.2 collect2: error: ld returned 1 exit status error: command 'gcc' failed with exit status 1 error: Bad exit status from /var/tmp/rpm-tmp.E6oOMA (%build) Paul, this is closely tied to the version of libarchive: [[ Version(python-libarchive) == Version(libarchive) ]] build_succedes ;) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x1mtNOPtRRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845
--- Comment #6 from Björn besser82 Esser bjoern.es...@gmail.com ---
(In reply to Paul Wouters from comment #5)
I does not specify a minimum version of libarchive. Often people grab srpms
from one branch and use it on another. So if this python package only works
with some minimal version, it should be added as minimum version to the
Requires: (even if f20 does not ship versions old enough to not work)
python-libarchive will need _exactly the same_ version of libarchive. Like I
said before:
BuildRequires: libarchive-devel = %{version}
Requires: libarchive%{?_isa} = %{version}
So if libarchive is e.g. 12.3.4, then you need to use python-libarchive-12.3.4
and vice versa.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=x2pQkrTVvsa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845
--- Comment #4 from Björn besser82 Esser bjoern.es...@gmail.com ---
Or in other words:
BuildRequires: libarchive-devel = %{version}
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=xnWNkz7L9Ba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004951] Review Request: qtbrowserplugin - Qt Solutions Component: Browser Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004951 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Blocks||969212 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DDsjuPwnyma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004951] New: Review Request: qtbrowserplugin - Qt Solutions Component: Browser Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004951 Bug ID: 1004951 Summary: Review Request: qtbrowserplugin - Qt Solutions Component: Browser Plugin Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: or...@cora.nwra.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://www.cora.nwra.com/~orion/fedora/qtbrowserplugin.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/qtbrowserplugin-2.4-1.fc19.src.rpm Description: The QtBrowserPlugin solution is useful for implementing plugins for web browser. Fedora Account System Username: orion -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HBoLpdtnMBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004845] Review Request: python-libarchive - Fully functional Python wrapper for libarchive.
https://bugzilla.redhat.com/show_bug.cgi?id=1004845 --- Comment #9 from Dhiru Kholia dkho...@redhat.com --- Thanks guys! I think I have now addressed major problems. New links, Spec URL: https://bitbucket.org/dhiru/packages/raw/master/python-libarchive/python-libarchive.spec SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/python-libarchive/python-libarchive-3.1.2.1-2.fc19.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=5901971 http://koji.fedoraproject.org/koji/taskinfo?taskID=5901976 libarchive version on f18 is too old which results in build failures. Special thanks goes to besser82 for mentoring me in #fedora-mentors :-) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6VFBTEH21ea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004913] Review Request: perl-Gtk2-SourceView2 - Perl bindings for the GtkSourceView 2.x widget
https://bugzilla.redhat.com/show_bug.cgi?id=1004913 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||bjoern.es...@gmail.com Assignee|nob...@fedoraproject.org|bjoern.es...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8eOBcbj47Fa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004963] New: Review Request: openstack-heat-templates - Heat example templates and DIB elements
https://bugzilla.redhat.com/show_bug.cgi?id=1004963 Bug ID: 1004963 Summary: Review Request: openstack-heat-templates - Heat example templates and DIB elements Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sd...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://raw.github.com/sdake/fedora-reviews/master/openstack-heat-templates/openstack-heat-templates.spec SRPM URL: https://github.com/sdake/fedora-reviews/blob/master/openstack-heat-templates/openstack-heat-templates-0.0.1-1.fc19.src.rpm?raw=true Description: Heat example templates and DIB elements Fedora Account System Username: sdake -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qrCBGmSPIwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 917149] Review Request: openshift-origin-node-proxy - Routing proxy for OpenShift Origin Node
https://bugzilla.redhat.com/show_bug.cgi?id=917149 --- Comment #6 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-proxy.spec SRPM URL: http://tdawson.fedorapeople.org/openshift-origin/openshift-origin-node-proxy-1.11.1.1-3.fc20.src.rpm - Fixed LICENSE file inconsistency -- The wrong file had been copied in and nobody checked until this review. -- Has been fixed upstream but hasn't been released yet. - added -p option to installing files -- Has been fixed upstream but hasn't been released yet. - added comments about patch and LICENSE source -- logrotate has also been fixed upstream, but hasn't been released yet. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VgGqkaCHY4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004951] Review Request: qtbrowserplugin - Qt Solutions Component: Browser Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004951
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1.BuildRequires: qt4-devel.
2.Is there any reason of %{_libdir}/*.a ?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=bnNHbUGac4a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004306] Review Request: opvdm - A tool for simulating organic solar cells
https://bugzilla.redhat.com/show_bug.cgi?id=1004306 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #4 from Christopher Meng cicku...@gmail.com --- You should also add link to your spec file as we need to first make your spec readable. Besides please find a sponsor, I can't sponsor you, sorry. See: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=R3PPt4f02ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 891282] Review Request: elementary - Basic widget set that is easy to use based on EFL
https://bugzilla.redhat.com/show_bug.cgi?id=891282 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-review? | --- Comment #2 from Dan Mashal dan.mas...@gmail.com --- Waiting on Wolfgang to return from holiday. In the process of updating the spec and SRPM for his review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9xkgbShSc2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 994152] Review Request: libprocess - Library that provides an actor style message-passing
https://bugzilla.redhat.com/show_bug.cgi?id=994152 --- Comment #9 from Christopher Meng cicku...@gmail.com --- pkgconfig has two locations because this is related to BuildArch. If you mark this package as noarch, put it under datadir. *** And what I told you in comment #5 is that: *.so.* is used for runtime and *.so is used for development. You used glob to include all libs. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZFit0E2ZRBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004951] Review Request: qtbrowserplugin - Qt Solutions Component: Browser Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1004951
--- Comment #2 from Orion Poplawski or...@cora.nwra.com ---
(In reply to Christopher Meng from comment #1)
1.BuildRequires: qt4-devel.
No, it's qt-devel. Although I suppose I'm tied to version 4 via qmake-qt4. I'd
prefer to keep it as is though.
2.Is there any reason of %{_libdir}/*.a ?
Lazy. Changed.
* Thu Sep 5 2013 Orion Poplawski or...@cora.nwra.com - 2.4-2
- Use explicit name for library file
http://www.cora.nwra.com/~orion/fedora/qtbrowserplugin.spec
http://www.cora.nwra.com/~orion/fedora/qtbrowserplugin-2.4-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=hnGWJdhGzPa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004997] New: Review Request: swizzle - Stream-based parsing code
https://bugzilla.redhat.com/show_bug.cgi?id=1004997 Bug ID: 1004997 Summary: Review Request: swizzle - Stream-based parsing code Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/swizzle.spec SRPM URL: http://gil.fedorapeople.org/swizzle-1.6.2-1.fc19.src.rpm Description: Swizzle started out as some stream-based parsing code. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=5903776 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6ShPYqA8nha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987881] Review Request: sisu-xmlrpc - A Java implementation of XML-RPC with Async Http Client support
https://bugzilla.redhat.com/show_bug.cgi?id=987881 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1004997 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m4xPc2irMXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004997] Review Request: swizzle - Stream-based parsing code
https://bugzilla.redhat.com/show_bug.cgi?id=1004997 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||987881 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g9CdiR7skia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC||package-review@lists.fedora ||project.org --- Comment #3 from Jens Petersen peter...@redhat.com --- Right good point which I forgot to mention indeed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Jj4S7hTPBga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 974725] Review Request: ghc-pretty-show - Tools for working with derived Show instances and generic inspection of values
https://bugzilla.redhat.com/show_bug.cgi?id=974725 --- Comment #4 from Jens Petersen peter...@redhat.com --- But jquery is not packaged yet it seems: bug 857992. So perhaps it could be waived for now. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0bZKdp6bkoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1001728] Review Request: rubygem-rkerberos - A Ruby interface for the the Kerberos library
https://bugzilla.redhat.com/show_bug.cgi?id=1001728
Simon A. Erat erat.si...@gmail.com changed:
What|Removed |Added
CC||erat.si...@gmail.com
--- Comment #1 from Simon A. Erat erat.si...@gmail.com ---
Hello Miroslav
This is only a 'pre-review' and needs to be approved.
--
Informal Review
* Valid License named in specfile:
Artistic 2.0
* Missing License:
Either as file or link in readme/manual of the package
* Package fails to buld as noarch
Is an 'interface' really required to be the same arch as the host-application
- ruby?
* ruby is named in specfile as requirement
##!!
Processing files: rubygem-rkerberos-0.1.2-3.fc19.noarch
+ popd
+ exit 0
Provides: rkerberos.so rubygem(rkerberos) = 0.1.2 rubygem-rkerberos =
0.1.2-3.fc19
Requires(rpmlib): rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(FileDigests) =
4.6.0-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.4) libcom_err.so.2 libcrypt.so.1 libdl.so.2
libkadm5clnt_mit.so.8 libkadm5clnt_mit.so.8(kadm5clnt_mit_8_MIT) libkrb5.so.3
libkrb5.so.3(krb5_3_MIT) libm.so.6 libpthread.so.0 librt.so.1 libruby.so.2.0
rtld(GNU_HASH)
error: Arch dependent binaries in noarch package
RPM build errors:
Arch dependent binaries in noarch package
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/rubygem-rkerberos.spec']
Traceback (most recent call last):
File /usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py, line
70, in trace
result = func(*args, **kw)
File /usr/lib/python2.7/site-packages/mockbuild/util.py, line 361, in do
raise mockbuild.exception.Error, (Command failed. See logs for output.\n #
%s % (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/rubygem-rkerberos.spec']
LEAVE do -- EXCEPTION RAISED
##!!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- gems should require rubygems package
Note: Requires: rubygems missing in rubygem-rkerberos-doc
See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems
- Pure Ruby package must be built as noarch
- Package contains Requires: ruby(release).
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
---Its in: /usr/lib64/gems/ruby/rkerberos-0.1.2/lib
What does that mean?
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 20 files have unknown license. Detailed output of
licensecheck in /home/simon/1001728-rubygem-rkerberos/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gems/gems/rkerberos-0.1.2
[x]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/gems/gems/rkerberos-0.1.2, /usr/share/gems,
/usr/share/gems/doc, /usr/share/gems/gems
[x]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
--they are in a -debug package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and
[Bug 993582] Review Request: inxi - A full featured system information script
https://bugzilla.redhat.com/show_bug.cgi?id=993582 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-09-05 23:08:24 --- Comment #10 from Christopher Meng cicku...@gmail.com --- I hope russian can remove packages approved in Fedora and focus on Fedora. Like this bug, you forgot to close it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZjqK19Ftkka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996792] Review Request: python-fedmsg-meta-debian - Metadata providers for Debian's fedmsg deployment
https://bugzilla.redhat.com/show_bug.cgi?id=996792 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-09-05 23:10:14 --- Comment #6 from Christopher Meng cicku...@gmail.com --- Please remember to close it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NzFBy1TjIna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1000731] Review Request: waffle - Platform independent GL API layer
https://bugzilla.redhat.com/show_bug.cgi?id=1000731 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | CC||mc...@redhat.com Flags||needinfo?(mc...@redhat.com) --- Comment #4 from Christopher Meng cicku...@gmail.com --- ping after 10 days. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4OUJX2Gfqfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
