[Bug 1114749] Review Request: eclipse-webtools - Eclipse Webtools Projects

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114749

Gerard Ryan ger...@ryan.lt changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG),
   ||814, 1108657, 1108656,
   ||1096104, 1106205, 1106203,
   ||1106202




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1096104
[Bug 1096104] eclipse-wtp-jeetools: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1106202
[Bug 1106202] eclipse-wtp-servertools: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1106203
[Bug 1106203] eclipse-wtp-sourceediting: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1106205
[Bug 1106205] eclipse-wtp-webservices: FTBFS in rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1108656
[Bug 1108656] eclipse-wtp-jeetools-3_6_0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1108657
[Bug 1108657] eclipse-wtp-jsf-3_6_0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=814
[Bug 814] eclipse-wtp-webservices-3_6_0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083701] Review Request: rubygem-docile - Docile keeps your Ruby DSLs tame and well-behaved

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1083701

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
rubygem-docile-1.1.4-1.fc20 has been pushed to the Fedora 20 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112864] Review Request: elpa - High-performance library for parallel solution of eigenvalue problems

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112864

Sandro Mani manisan...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #16 from Sandro Mani manisan...@gmail.com ---
The reason for
# %{?_smp_mflags}
should be documented with a comment. But this is not a blocker.

Rest is fine, package approved!


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/gfortran, /usr/lib64/gfortran/modules,
 /usr/lib64/openmpi/lib/pkgconfig, /usr/lib64/gfortran/modules/mpich,
 /usr/lib64/mpich/lib/pkgconfig, /usr/lib64/gfortran/modules/openmpi
 = These directories should be owned by gcc-gfortran resp openmpi/mpich,
which are listed as Requires
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/gfortran,
 /usr/lib64/openmpi/lib, /usr/lib64/gfortran/modules, /usr/lib64/mpich,
 /usr/lib64/mpich/lib, /usr/lib64/openmpi/lib/pkgconfig,
 /usr/lib64/gfortran/modules/mpich, /usr/lib64/mpich/lib/pkgconfig,
 /usr/lib64/openmpi, /usr/lib64/gfortran/modules/openmpi
 = These directories should be owned by gcc-gfortran resp openmpi/mpich,
which are listed as Requires
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include 

[Bug 1111948] Review Request: kf5-kio - KDE Frameworks 5 Tier 3 solution for filesystem abstraction

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=948

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Jan Grulich jgrul...@redhat.com ---
It's not necessary to have Requires: kf5-kwallet-libs, just remove it during
import. The rest looks good, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113915] Review Request: micropython - Implementation of Python 3 with very low memory footprint

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1113915



--- Comment #2 from Matej Stuchlik mstuc...@redhat.com ---
(In reply to Christopher Meng from comment #1)
 1. Release:1
 
 https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Using_the_.25.7B.
 3Fdist.7D_Tag

Fixed
8
 2. BuildRequires:  python-devel
 BuildRequires:  python3-devel
 
 Why python2 still being used?

Required during the build process:
python ../py/makeqstrdata.py build/genhdr/qstrdefs.preprocessed.h
qstrdefsport.h  build/genhdr/qstrdefs.generated.h

 3. LDFLAGS need to set as well: %?__global_ldflags

Fixed, but I'm now the build fails during linking.
http://koji.fedoraproject.org/koji/taskinfo?taskID=7095407
I'll look into it, but does it seem familiar to you?

 4. Try make -C for subdir building

Fixed

New SRPM URL: http://mstuchli.fedorapeople.org/micropython-1.1.1-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015263] Review request: lz4 Extremely fast compression algorithm

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015263



--- Comment #30 from pjp pj.pan...@yahoo.co.in ---
(In reply to Jon Ciesla from comment #29)
 kumarpraveen.nitdgp is not in the packager group.

  Ah sorry, his FAS id is kumarpraveen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015263] Review request: lz4 Extremely fast compression algorithm

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015263

pjp pj.pan...@yahoo.co.in changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #31 from pjp pj.pan...@yahoo.co.in ---
Package Change Request
==
Package Name: lz4
New Branches: el5 el6 epel7
Owners: pjp kumarpraveen

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823352] Review Request: rubygem-chef - a client for the Chef config management system

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=823352
Bug 823352 depends on bug 902240, which changed state.

Bug 902240 Summary: rubygem-diff-lcs-1.2.5 is available
https://bugzilla.redhat.com/show_bug.cgi?id=902240

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111955] Review Request: kf5-kdewebkit - KDE Frameworks 5 Tier 3 integration module for QtWebKit

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=955

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jan Grulich jgrul...@redhat.com ---
Now it looks good, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112864] Review Request: elpa - High-performance library for parallel solution of eigenvalue problems

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112864

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #17 from Dominik 'Rathann' Mierzejewski domi...@greysector.net ---
New Package SCM Request
===
Package Name: elpa
Short Description: High-performance library for parallel solution of eigenvalue
problems
Upstream URL: http://elpa.rzg.mpg.de/
Owners: rathann
Branches: f19 f20 epel7 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111294] Review Request: engrid - Mesh generation tool

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=294

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|domi...@greysector.net
  Flags||fedora-review?



--- Comment #3 from Dominik 'Rathann' Mierzejewski domi...@greysector.net ---
Taking review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111957] Review Request: kf5-kinit - KDE Frameworks 5 tier 3 solution for process launching

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=957

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jan Grulich jgrul...@redhat.com ---
Ok, looks good now, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111954] Review Request: kf5-ktexteditor - KDE Frameworks 5 Tier 3 with advanced embeddable text editor

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=954



--- Comment #3 from Jan Grulich jgrul...@redhat.com ---
1) Missing call of update-desktop-database
2) Missing %config before %{_sysconfdir}/xdg/kate*
3) E: incorrect-fsf-address /usr/share/katepart5/script/indentation/lilypond.js
- this is not a blocking issue, but upstream should be informed about this

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114702] Review Request: python3-pycairo - Python 3 bindings for the cairo library

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114702



--- Comment #2 from Miro Hrončok mhron...@redhat.com ---
Oh, never though of searching it by that name :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=505154

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Depends On||294




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=294
[Bug 294] Review Request: engrid - Mesh generation tool
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111294] Review Request: engrid - Mesh generation tool

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=294

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Blocks||505154 (FE-SCITECH)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113915] Review Request: micropython - Implementation of Python 3 with very low memory footprint

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1113915



--- Comment #3 from Christopher Meng i...@cicku.me ---
(In reply to Matej Stuchlik from comment #2)
 Fixed, but I'm now the build fails during linking.
 http://koji.fedoraproject.org/koji/taskinfo?taskID=7095407
 I'll look into it, but does it seem familiar to you?

Yes, because you are overriding the ldflags.

Also no hidden build:

mkdir -p build/genhdr
CPP ../py/qstrdefs.h
makeqstrdata ../py/qstrdefs.h qstrdefsport.h
../py/py-version.sh: line 4: git: command not found
Generating build/genhdr/py-version.h
mkdir -p build/py/
CC ../py/nlrx86.S
CC ../py/nlrx64.S
CC ../py/nlrthumb.S
CC ../py/nlrsetjmp.c
CC ../py/malloc.c
CC ../py/gc.c
CC ../py/qstr.c
CC ../py/vstr.c
CC ../py/unicode.c
CC ../py/mpz.c
CC ../py/lexer.c
CC ../py/lexerstr.c
CC ../py/lexerunix.c
CC ../py/parse.c
CC ../py/parsehelper.c
CC ../py/scope.c
CC ../py/compile.c
CC ../py/emitcommon.c
CC ../py/emitpass1.c
CC ../py/emitcpy.c
CC ../py/emitbc.c
CC ../py/asmx64.c
CC ../py/emitnative.c
CC ../py/asmthumb.c
CC ../py/emitnative.c
CC ../py/emitinlinethumb.c
CC ../py/formatfloat.c
CC ../py/parsenumbase.c
CC ../py/parsenum.c
CC ../py/emitglue.c
CC ../py/runtime.c
CC ../py/argcheck.c
CC ../py/map.c
CC ../py/obj.c
CC ../py/objarray.c
CC ../py/objbool.c
CC ../py/objboundmeth.c
CC ../py/objcell.c
CC ../py/objclosure.c
CC ../py/objcomplex.c
CC ../py/objdict.c
CC ../py/objenumerate.c
CC ../py/objexcept.c
CC ../py/objfilter.c
CC ../py/objfloat.c
CC ../py/objfun.c
CC ../py/objgenerator.c
CC ../py/objgetitemiter.c
CC ../py/objint.c
CC ../py/objint_longlong.c
CC ../py/objint_mpz.c
CC ../py/objlist.c
CC ../py/objmap.c
CC ../py/objmodule.c
CC ../py/objobject.c
CC ../py/objproperty.c
CC ../py/objnone.c
CC ../py/objnamedtuple.c
CC ../py/objrange.c
CC ../py/objset.c
CC ../py/objslice.c
CC ../py/objstr.c
CC ../py/objstringio.c
CC ../py/objtuple.c
CC ../py/objtype.c
CC ../py/objzip.c
CC ../py/opmethods.c
CC ../py/sequence.c
CC ../py/stream.c
CC ../py/binary.c
CC ../py/builtin.c
CC ../py/builtinimport.c
CC ../py/builtinevex.c
CC ../py/builtintables.c
CC ../py/modarray.c
CC ../py/modcollections.c
CC ../py/modgc.c
CC ../py/modio.c
CC ../py/modmath.c
CC ../py/modcmath.c
CC ../py/modmicropython.c
CC ../py/modstruct.c
CC ../py/modsys.c
CC ../py/vm.c
CC ../py/showbc.c
CC ../py/repl.c
CC ../py/smallint.c
CC ../py/pfenv.c
CC main.c
CC gccollect.c
CC input.c
CC file.c
CC modsocket.c
CC modos.c
CC modtime.c
CC modffi.c
LINK micropython
build/modffi.o: In function `ffifunc_call':
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:331: undefined reference
to `ffi_call'
build/modffi.o: In function `ffimod_close':
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:163: undefined reference
to `dlclose'
build/modffi.o: In function `ffimod_var':
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:247: undefined reference
to `dlsym'
build/modffi.o: In function `ffimod_make_new':
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:262: undefined reference
to `dlopen'
build/modffi.o: In function `mod_ffi_callback':
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:217: undefined reference
to `ffi_closure_alloc'
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:228: undefined reference
to `ffi_prep_cif'
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:233: undefined reference
to `ffi_prep_closure_loc'
build/modffi.o: In function `ffimod_func':
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:173: undefined reference
to `dlsym'
/builddir/build/BUILD/micropython-1.1.1/unix/modffi.c:191: undefined reference
to `ffi_prep_cif'
build/modffi.o:(.rodata+0x0): undefined reference to `ffi_type_uint8'
build/modffi.o:(.rodata+0x1c): undefined reference to `ffi_type_uint32'
build/modffi.o:(.rodata+0x28): undefined reference to `ffi_type_uint32'
build/modffi.o:(.rodata+0x38): undefined reference to `ffi_type_pointer'
build/modffi.o:(.rodata+0x80): undefined reference to `ffi_type_sint8'
build/modffi.o:(.rodata+0x88): undefined reference to `ffi_type_double'
build/modffi.o:(.rodata+0x90): undefined reference to `ffi_type_float'
build/modffi.o:(.rodata+0x9c): undefined reference to `ffi_type_sint32'
build/modffi.o:(.rodata+0xa8): undefined reference to `ffi_type_sint32'
build/modffi.o:(.rodata+0xb8): undefined reference to `ffi_type_pointer'
build/modffi.o:(.rodata+0xc4): undefined reference to `ffi_type_pointer'
build/modffi.o:(.rodata+0xd0): undefined reference to `ffi_type_void'
collect2: error: ld returned 1 exit status
../py/mkrules.mk:75: recipe for target 'micropython' failed
make: Leaving directory '/builddir/build/BUILD/micropython-1.1.1/unix'
RPM build errors:
make: *** [micropython] Error 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=505154

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Depends On|1105730 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1105730
[Bug 1105730] Review Request: seqan - Open source C++ library of efficient
algorithms and data structures
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1105730] Review Request: seqan - Open source C++ library of efficient algorithms and data structures

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1105730

Dominik 'Rathann' Mierzejewski domi...@greysector.net changed:

   What|Removed |Added

 Blocks|505154 (FE-SCITECH) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094415] Review Request: jai-imageio-core-standalone - Java Advanced Imaging Image I/O Tools API core (standalone)

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094415



--- Comment #5 from gil cattaneo punto...@libero.it ---
Spec URL: http://gil.fedorapeople.org/jai-imageio-core-standalone.spec
SRPM URL:
http://gil.fedorapeople.org/jai-imageio-core-standalone-1.2-0.1.pre.dr.b04.2013.04.23.fc19.src.rpm

- remove JJ2000
- use git commit hash

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7095639

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|nathan...@natemccallum.com  |nob...@fedoraproject.org
  Flags|needinfo?(nathaniel@natemcc |
   |allum.com)  |
   |needinfo?(nathaniel@natemcc |
   |allum.com)  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114702] Review Request: python3-pycairo - Python 3 bindings for the cairo library

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114702



--- Comment #3 from Miro Hrončok mhron...@redhat.com ---
(In reply to Christopher Meng from comment #1)
 I've asked many times on -devel trying to persuade someone to update the
 package in Fedora, and I only get responses but no actions.

What you mean by that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114702] Review Request: python3-pycairo - Python 3 bindings for the cairo library

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114702



--- Comment #4 from Christopher Meng i...@cicku.me ---
(In reply to Miro Hrončok from comment #3)
 (In reply to Christopher Meng from comment #1)
  I've asked many times on -devel trying to persuade someone to update the
  package in Fedora, and I only get responses but no actions.
 
 What you mean by that?

https://lists.fedoraproject.org/pipermail/devel/2013-November/191248.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 634700] Review Request: python3-cairo - cairo python bindings for Python 3

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=634700

Miro Hrončok mhron...@redhat.com changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #33 from Miro Hrončok mhron...@redhat.com ---
*** Bug 1114702 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114702] Review Request: python3-pycairo - Python 3 bindings for the cairo library

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114702

Miro Hrončok mhron...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2014-07-01 06:26:06



--- Comment #5 from Miro Hrončok mhron...@redhat.com ---
Cant see how this is relevant to this Review Request. Probably a question for
upstream, isn't it?

Anyway, closing this.

*** This bug has been marked as a duplicate of bug 634700 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111948] Review Request: kf5-kio - KDE Frameworks 5 Tier 3 solution for filesystem abstraction

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=948

Dan Vrátil dvra...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #7 from Dan Vrátil dvra...@redhat.com ---
New Package SCM Request
===
Package Name: kf5-kio
Short Description: KDE Frameworks 5 Tier 3 solution for filesystem abstraction
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl kkofler rdieter than
Branches: 
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111955] Review Request: kf5-kdewebkit - KDE Frameworks 5 Tier 3 integration module for QtWebKit

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=955

Dan Vrátil dvra...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Dan Vrátil dvra...@redhat.com ---
New Package SCM Request
===
Package Name: kf5-kdewebkit
Short Description: KDE Frameworks 5 Tier 3 integration module for QtWebKit
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl rdieter kkofler than
Branches: 
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113915] Review Request: micropython - Implementation of Python 3 with very low memory footprint

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1113915



--- Comment #4 from Matej Stuchlik mstuc...@redhat.com ---
(In reply to Christopher Meng from comment #3)
 (In reply to Matej Stuchlik from comment #2)
  Fixed, but I'm now the build fails during linking.
  http://koji.fedoraproject.org/koji/taskinfo?taskID=7095407
  I'll look into it, but does it seem familiar to you?
 
 Yes, because you are overriding the ldflags.

I don't think I follow, looking at the build log, LDFLAGS seem to be
-Wl,-z,relro  -lm -Wl,-Map=micropython.map,--cref, i.e. %?__global_ldflags
followed by whatever is added in the Makefile, which seem alright to me. Maybe
you missed that I'm using LDFLAGS_MOD=%?__global_ldflags?
  ^^^

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111957] Review Request: kf5-kinit - KDE Frameworks 5 tier 3 solution for process launching

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=957

Dan Vrátil dvra...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Dan Vrátil dvra...@redhat.com ---
New Package SCM Request
===
Package Name: kf5-kinit
Short Description: KDE Frameworks 5 tier 3 solution for process launching
Upstream URL: http://www.kde.org
Owners: dvratil jgrulich ltinkl rdieter kkofler than
Branches: 
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689

Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sanjay.an...@gmail.com
   Assignee|nob...@fedoraproject.org|sanjay.an...@gmail.com
  Flags||fedora-review?



--- Comment #6 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com ---
I'll take this one. Review coming in a few hours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114749] Review Request: eclipse-webtools - Eclipse Webtools Projects

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114749

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111954] Review Request: kf5-ktexteditor - KDE Frameworks 5 Tier 3 with advanced embeddable text editor

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=954



--- Comment #4 from Dan Vrátil dvra...@redhat.com ---
Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor.spec
SRPM URL:
http://dvratil.fedorapeople.org/kf5/review/kf5-ktexteditor-4.100.0-3.src.rpm

Added %config and call to update-desktop-database

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112072] Review Request: vit - A minimalist Taskwarrior full-screen terminal interface with Vim key bindings

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112072

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||i...@cicku.me
   Assignee|nob...@fedoraproject.org|i...@cicku.me
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113915] Review Request: micropython - Implementation of Python 3 with very low memory footprint

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1113915



--- Comment #5 from Christopher Meng i...@cicku.me ---
(In reply to Matej Stuchlik from comment #4)
 (In reply to Christopher Meng from comment #3)
  (In reply to Matej Stuchlik from comment #2)
   Fixed, but I'm now the build fails during linking.
   http://koji.fedoraproject.org/koji/taskinfo?taskID=7095407
   I'll look into it, but does it seem familiar to you?
  
  Yes, because you are overriding the ldflags.
 
 I don't think I follow, looking at the build log, LDFLAGS seem to be
 -Wl,-z,relro  -lm -Wl,-Map=micropython.map,--cref, i.e. %?__global_ldflags
 followed by whatever is added in the Makefile, which seem alright to me.
 Maybe you missed that I'm using LDFLAGS_MOD=%?__global_ldflags?
   ^^^

I don't know.

If revision 1 was built successfully, then rev 2 failed, it should be caused by
ldflags.

But now you provide the rev 2 RPM with no %release tag bumped, I can't tell.

Anyway, fix it and then I will go ahead.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114702] Review Request: python3-pycairo - Python 3 bindings for the cairo library

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114702



--- Comment #6 from Christopher Meng i...@cicku.me ---
(In reply to Miro Hrončok from comment #5)
 Cant see how this is relevant to this Review Request. Probably a question
 for upstream, isn't it?

Not upstream, but the relevant nonresponsive package maintainer in Fedora. I
have no idea.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113951] Review Request: perl-App-GitHooks - Extensible plugins system for git hooks

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1113951



--- Comment #4 from David Dick dd...@cpan.org ---
(In reply to Petr Šabata from comment #3)
 The License tag is incorrect.  All the files require at least GPLv3.

fixed

 `Devel::Cover' and `lib' are only used in App::GitHooks::Test DATA section
 which I don't see used anywhere.  Perhaps it's a dead code?

agreed.  builds fine without these BRs at
http://koji.fedoraproject.org/koji/taskinfo?taskID=7095757

fixed and uploaded.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689

Ankur Sinha (FranciscoD) sanjay.an...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com ---
[+] OK
[-] NA
[?] Issue

** Mandatory review guidelines: **
 [+] rpmlint output:
[asinha@ankur-laptop  SRPMS]$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/*.rpm ../SPECS/python3-dugong.spec
./python3-dugong-3.0-1.fc21.src.rpm
python3-dugong.noarch: W: spelling-error %description -l en_US http - HTTP
python3-dugong.noarch: W: spelling-error %description -l en_US httplib - HTTP
python3-dugong.noarch: W: spelling-error %description -l en_US BadStatusLine -
Stateliness
python3-dugong.noarch: W: spelling-error %description -l en_US IncompleteRead
- Incomplete Read, Incomplete-read, Incomplete
python3-dugong.noarch: W: spelling-error %description -l en_US asyncio -
Asuncion
python3-dugong.noarch: W: spelling-error %description -l en_US str - st, tr,
stir
python3-dugong.noarch: W: spelling-error %description -l en_US encodable -
expendable
python3-dugong.src: W: spelling-error %description -l en_US http - HTTP
python3-dugong.src: W: spelling-error %description -l en_US httplib - HTTP
python3-dugong.src: W: spelling-error %description -l en_US BadStatusLine -
Stateliness
python3-dugong.src: W: spelling-error %description -l en_US IncompleteRead -
Incomplete Read, Incomplete-read, Incomplete
python3-dugong.src: W: spelling-error %description -l en_US asyncio - Asuncion
python3-dugong.src: W: spelling-error %description -l en_US str - st, tr, stir
python3-dugong.src: W: spelling-error %description -l en_US encodable -
expendable
python3-dugong.src: W: spelling-error %description -l en_US http - HTTP
python3-dugong.src: W: spelling-error %description -l en_US httplib - HTTP
python3-dugong.src: W: spelling-error %description -l en_US BadStatusLine -
Stateliness
python3-dugong.src: W: spelling-error %description -l en_US IncompleteRead -
Incomplete Read, Incomplete-read, Incomplete
python3-dugong.src: W: spelling-error %description -l en_US asyncio - Asuncion
python3-dugong.src: W: spelling-error %description -l en_US str - st, tr, stir
python3-dugong.src: W: spelling-error %description -l en_US encodable -
expendable
3 packages and 1 specfiles checked; 0 errors, 21 warnings.
[asinha@ankur-laptop  SRPMS]$

^^
Only spelling warnings. Please look at them. For example, http - HTTP seems
liek a change you can make. 

 [+] License is acceptable (...)
 [?] License field in spec is correct
^^ It may make sense to also include Apache since the CaseInsensitiveDict
implementation is licensed such. The LICENSE file mentions it too.

 [+] License files included in package %docs if included in source package
 [+] License files installed when any subpackage combination is installed
 [+] Spec written in American English
 [+] Spec is legible
 [+] Sources match upstream unless altered to fix permissibility issues
Getting https://pypi.python.org/packages/source/d/dugong/dugong-3.0.tar.bz2 to
/tmp/review/dugong-3.0.tar.bz2
  % Total% Received % Xferd  Average Speed   TimeTime Time  Current
 Dload  Upload   Total   SpentLeft  Speed
100  176k  100  176k0 0   108k  0  0:00:01  0:00:01 --:--:--  108k
f81bc01e7656ced466e1eb059952c21f  /tmp/review/dugong-3.0.tar.bz2
f81bc01e7656ced466e1eb059952c21f 
/home/asinha/rpmbuild/SOURCES/dugong-3.0.tar.bz2
removed ‘/tmp/review/dugong-3.0.tar.bz2’
removed directory: ‘/tmp/review’

 [+] Build succeeds on at least one primary arch
 [+] Build succeeds on all primary arches or has ExcludeArch + bugs filed
 [+] BuildRequires correct, justified where necessary
 [-] Locales handled with %find_lang, not %_datadir/locale/*
 [-] %post, %postun call ldconfig if package contains shared .so files
 [+] No bundled libs
 [-] Relocatability is justified
 [+] Package owns all directories it creates
 [+] Package requires others for directories it uses but does not own
 [+] No duplication in %files unless necessary for license files
 [+] File permissions are sane
 [+] Package contains permissible code or content
 [-] Large docs go in -doc subpackage
 [+] %doc files not required at runtime
 [-] Static libs go in -static package/virtual Provides
 [-] Development files go in -devel package
 [-] -devel packages Require base with fully-versioned dependency, %_isa
 [+] No .la files
 [-] GUI app uses .desktop file, installs it with desktop-file-install
 [-] File list does not conflict with other packages' without justification
 [+] File names are valid UTF-8

** Optional review guidelines: **
 [-] Query upstream about including license files
 [-] Translations of description, summary
 [+] Builds in mock
 [+] Builds on all arches
 [?] Functions as described (e.g. no crashes)
^^
Not tested

 

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #8 from Christopher Meng i...@cicku.me ---
Thanks!

I will review your soon, as I'm outside now.

New Package SCM Request
===
Package Name: python3-dugong
Short Description: Python 3.x HTTP 1.1 client module
Upstream URL: https://bitbucket.org/nikratio/python-dugong
Owners: cicku
Branches: f20 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112434] Review Request: brd - Scans directories and files for damage due to decay of storage medium

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112434



--- Comment #12 from Jeff Backus jeff.bac...@gmail.com ---
(In reply to Denis Fateyev from comment #11)
 Thanks for the link, Rich. The wording used in this part of guidelines is a
 bit unclear indeed. We keep the spec in its current state; package is
 approved.

Hi Denis,

Agreed - it got me turned around a couple of times. :) Thanks for the review!

Regards,
Jeff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111954] Review Request: kf5-ktexteditor - KDE Frameworks 5 Tier 3 with advanced embeddable text editor

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=954

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jan Grulich jgrul...@redhat.com ---
I also forgot to mention that the patch doesn't apply, but I fixed it locally
and you can find the fixed patch here [1]. It looks good now, approved.

[1]
http://jgrulich.fedorapeople.org/ktexteditor-move-katepart-into-kf5-parts-sudir-of-plugin-dir.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112434] Review Request: brd - Scans directories and files for damage due to decay of storage medium

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112434

Jeff Backus jeff.bac...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #13 from Jeff Backus jeff.bac...@gmail.com ---
New Package SCM Request
===
Package Name: brd
Short Description: Scans directories and files for damage due to decay of
storage medium
Upstream URL: https://github.com/jsbackus/brd
Owners: jsbackus
Branches: f19 f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111961] Review Request: kf5-kdesignerplugin - KDE Frameworks 5 Tier 3 integration module for Qt Designer

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=961

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111959] Review Request: kf5-kjsembed - KDE Frameworks 5 Tier 3 addon for binding JS objects to QObjects

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=959

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111958] Review Request: kf5-kded - KDE Frameworks 5 Tier 3 addon with extensible daemon for system-level services

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=958

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Jan Grulich jgrul...@redhat.com ---
Looks good, except too long description line, but this could be fixed during
import. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015263] Review request: lz4 Extremely fast compression algorithm

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015263



--- Comment #32 from Jon Ciesla limburg...@gmail.com ---
Already done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015263] Review request: lz4 Extremely fast compression algorithm

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015263

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021719] Review Request: opensmtpd - Minimalistic but powerful smtp server

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021719

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021719] Review Request: opensmtpd - Minimalistic but powerful smtp server

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021719



--- Comment #34 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055126] Review Request: nfdump - NetFlow collecting and processing tools

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1055126

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055126] Review Request: nfdump - NetFlow collecting and processing tools

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1055126



--- Comment #17 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1078327] Review Request: github2fedmsg - Pubsubhubbub app that rebroadcasts GH events over fedmsg

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1078327

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1078327] Review Request: github2fedmsg - Pubsubhubbub app that rebroadcasts GH events over fedmsg

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1078327



--- Comment #19 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689



--- Comment #9 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111948] Review Request: kf5-kio - KDE Frameworks 5 Tier 3 solution for filesystem abstraction

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=948



--- Comment #8 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111948] Review Request: kf5-kio - KDE Frameworks 5 Tier 3 solution for filesystem abstraction

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=948

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111955] Review Request: kf5-kdewebkit - KDE Frameworks 5 Tier 3 integration module for QtWebKit

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=955

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111955] Review Request: kf5-kdewebkit - KDE Frameworks 5 Tier 3 integration module for QtWebKit

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=955



--- Comment #5 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111957] Review Request: kf5-kinit - KDE Frameworks 5 tier 3 solution for process launching

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=957



--- Comment #5 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1097426] Review Request: dpdk - dataplane development toolkit for optimized network appliances

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1097426

Ville Skyttä ville.sky...@iki.fi changed:

   What|Removed |Added

 Blocks||496968 (DebugInfo)



--- Comment #29 from Ville Skyttä ville.sky...@iki.fi ---
(In reply to Neil Horman from comment #27)
 I won't be using RPM_OPT_FLAGS, because they override options that the dpdk
 has to set which will otherwise cause build failures/run time failures.

The proper way to do it is to use RPM_OPT_FLAGS (or more generally user set
CFLAGS) as the basis, and append/override parts in them that need to be
appended/overridden.

http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

(In reply to Neil Horman from comment #28)
 also note, dpdk doesn't build for i386 platforms.  i686 and x86_64 are the
 only arches it builds on currently.

Nevertheless I suggest doing ExclusiveArch: %{ix86} x86_64 which in practice
in Fedora is the same as ExclusiveArch: i686 x86_64 nowadays.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=496968
[Bug 496968] Tracking bug for packages with debuginfo problems
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111957] Review Request: kf5-kinit - KDE Frameworks 5 tier 3 solution for process launching

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=957

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112434] Review Request: brd - Scans directories and files for damage due to decay of storage medium

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112434

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111959] Review Request: kf5-kjsembed - KDE Frameworks 5 Tier 3 addon for binding JS objects to QObjects

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=959

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jan Grulich jgrul...@redhat.com ---
Looks good, no issue spotted even with fedora-review or rpmlint, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112434] Review Request: brd - Scans directories and files for damage due to decay of storage medium

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112434



--- Comment #14 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112864] Review Request: elpa - High-performance library for parallel solution of eigenvalue problems

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112864



--- Comment #18 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112864] Review Request: elpa - High-performance library for parallel solution of eigenvalue problems

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112864

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111961] Review Request: kf5-kdesignerplugin - KDE Frameworks 5 Tier 3 integration module for Qt Designer

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=961

Jan Grulich jgrul...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jan Grulich jgrul...@redhat.com ---
Looks good, no issue spotted even with fedora-review or rpmlint, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1078327] Review Request: github2fedmsg - Pubsubhubbub app that rebroadcasts GH events over fedmsg

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1078327

Ralph Bean rb...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-07-01 08:48:46



--- Comment #20 from Ralph Bean rb...@redhat.com ---
Thanks all!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
python3-dugong-3.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python3-dugong-3.1-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1111689] Review Request: python3-dugong - Python 3.x HTTP 1.1 client module

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1078327] Review Request: github2fedmsg - Pubsubhubbub app that rebroadcasts GH events over fedmsg

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1078327



--- Comment #21 from Fedora Update System upda...@fedoraproject.org ---
github2fedmsg-0.3.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/github2fedmsg-0.3.1-2.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1067003] Review Request: perl-Time-ParseDate - Date parsing both relative and absolute

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1067003



--- Comment #9 from Petr Pisar ppi...@redhat.com ---
The standalone spec file and file from source RPM differ. I will use the
standalone one for this review.

The URL and Source0 are usable. Ok.
The source archive is original (SHA-256:
14a761a45885cbff907531a0b293a7553100260ec0aa6cb51f4deef75616cdfe). Ok.
Summary is Ok.
Description is Ok.

TODO: Wrap the description paragraph to 80 columns.

License verified from lib/Time/ParseDate.pm, lib/Time/CTime.pm,
lib/Time/DaysInMonth.pm, lib/Time/JulianDay.pm, lib/Time/Timezone.pm.

FIX: The lib/Time/Timezone.pm is not TPDL-licensed. It is Public Domain:

=head1 LICENSE

David Muir Sharnoff disclaims any copyright and puts his contribution
to this module in the public domain.

Change the license tag from (TPDL) to (TPDL and Public Domain).

No XS code presents, noarch BuildArch is Ok.
Build-time dependencies are Ok.
All tests pass. Ok.

$ rpmlint perl-Time-ParseDate.spec
../SRPMS/perl-Time-ParseDate-2013.1113-2.fc21.src.rpm
../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm 
perl-Time-ParseDate.src: W: spelling-error %description -l en_US CTime - C
Time, Crime, Clime
perl-Time-ParseDate.src: W: spelling-error %description -l en_US DaysInMonth -
Semimonthly
perl-Time-ParseDate.src: W: spelling-error %description -l en_US JulianDay -
Julian Day, Julian-Day, Julian-day
perl-Time-ParseDate.src: E: description-line-too-long C There can be numerous
options for controlling what is recognized and what is not.
perl-Time-ParseDate.noarch: W: spelling-error %description -l en_US CTime - C
Time, Crime, Clime
perl-Time-ParseDate.noarch: W: spelling-error %description -l en_US DaysInMonth
- Semimonthly
perl-Time-ParseDate.noarch: W: spelling-error %description -l en_US JulianDay
- Julian Day, Julian-Day, Julian-day
perl-Time-ParseDate.noarch: E: description-line-too-long C There can be
numerous options for controlling what is recognized and what is not.
2 packages and 1 specfiles checked; 2 errors, 6 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm 
drwxr-xr-x2 rootroot0 Jul  1 15:02
/usr/share/doc/perl-Time-ParseDate
-rw-r--r--1 rootroot 7275 Nov 14  2013
/usr/share/doc/perl-Time-ParseDate/Changes
-rw-r--r--1 rootroot  604 Nov 28  1998
/usr/share/doc/perl-Time-ParseDate/README
-rw-r--r--1 rootroot 2805 Jul  1 15:02
/usr/share/man/man3/Time::CTime.3pm.gz
-rw-r--r--1 rootroot 2181 Jul  1 15:02
/usr/share/man/man3/Time::DaysInMonth.3pm.gz
-rw-r--r--1 rootroot 2901 Jul  1 15:02
/usr/share/man/man3/Time::JulianDay.3pm.gz
-rw-r--r--1 rootroot 3674 Jul  1 15:02
/usr/share/man/man3/Time::ParseDate.3pm.gz
-rw-r--r--1 rootroot 2321 Jul  1 15:02
/usr/share/man/man3/Time::Timezone.3pm.gz
drwxr-xr-x2 rootroot0 Jul  1 15:02
/usr/share/perl5/vendor_perl/Time
-rw-r--r--1 rootroot 5780 Sep 20  2013
/usr/share/perl5/vendor_perl/Time/CTime.pm
-rw-r--r--1 rootroot 1330 Apr  1  2008
/usr/share/perl5/vendor_perl/Time/DaysInMonth.pm
-rw-r--r--1 rootroot 5940 May  6  2011
/usr/share/perl5/vendor_perl/Time/JulianDay.pm
-rw-r--r--1 rootroot29907 Nov 14  2013
/usr/share/perl5/vendor_perl/Time/ParseDate.pm
-rw-r--r--1 rootroot 9604 Sep 20  2013
/usr/share/perl5/vendor_perl/Time/Timezone.pm
File permissions and layout is Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm | sort -f | uniq
-c
  1 perl = 0:5.000
  1 perl = 0:5.002
  1 perl(:MODULE_COMPAT_5.18.2)
  1 perl(Carp)
  1 perl(Exporter)
  1 perl(integer)
  1 perl(strict)
  1 perl(Time::CTime)
  1 perl(Time::JulianDay)
  1 perl(Time::Timezone)
  1 perl(vars)
  1 rpmlib(CompressedFileNames) = 3.0.4-1
  1 rpmlib(FileDigests) = 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) = 4.0-1
  1 rpmlib(PayloadIsXz) = 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Time-ParseDate-2013.1113-2.fc21.noarch.rpm | sort -f | uniq
-c
  1 perl(Time::CTime) = 2011.0505
  1 perl(Time::DaysInMonth) = 99.1117
  1 perl(Time::JulianDay) = 2011.0505
  1 perl(Time::ParseDate) = 2013.1113
  1 perl(Time::Timezone) = 2006.0814
  1 perl-Time-modules = 2013.1113-2.fc21
  1 perl-Time-ParseDate = 2013.1113-2.fc21
Binary provides are Ok.

This package replaces perl-Time-modules correctly. Ok.

Package builds in F21
(http://koji.fedoraproject.org/koji/taskinfo?taskID=7096282). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' issues, consider fixing `TODO' items, and 

[Bug 1115049] New: Review Request: freight - A modern take on the Debian archive

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1115049

Bug ID: 1115049
   Summary: Review Request: freight - A modern take on the Debian
archive
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: dcl...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://domcleal.fedorapeople.org/reviews/freight/freight.spec
SRPM URL:
http://domcleal.fedorapeople.org/reviews/freight/freight-0.3.5-1.fc20.src.rpm

Description:
freight programs create the files needed to serve a Debian archive. The actual
serving is done via your favorite HTTP server.

Fedora Account System Username: domcleal

One rpmlint warning exists on the RPM regarding a missing freight-clear-cache
man page, which I've submitted upstream for a future release:
https://github.com/rcrowley/freight/pull/55

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 689870] Review Request: tabix - Generic indexer for TAB-delimited genome position files

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=689870

Adam Huffman bl...@verdurin.com changed:

   What|Removed |Added

  Flags|needinfo?(bl...@verdurin.co |
   |m)  |



--- Comment #12 from Adam Huffman bl...@verdurin.com ---
I haven't been working in this field for over two years now, so it would be
better for someone else to adopt this package.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 716400] Review Request: MACS - Model-based Analysis for ChIP-Seq

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=716400

Adam Huffman bl...@verdurin.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(bl...@verdurin.co |
   |m)  |
Last Closed||2014-07-01 10:02:20



--- Comment #6 from Adam Huffman bl...@verdurin.com ---
I haven't been working in this field for over two years now, so it would be
better for someone else to maintain this package, if there is interest.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100870] Review Request: perl-Parse-EDID - Extended display identification data parser

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100870



--- Comment #3 from maria...@tuxette.fr maria...@tuxette.fr ---
updated spec according to review : 
SPECS : http://giverny.tuxette.fr/copr/perl-Parse-EDID/perl-Parse-EDID.spec
SRPMS :
http://giverny.tuxette.fr/copr/perl-Parse-EDID/perl-Parse-EDID-1.0.6-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1062757] Review Request: glite-lb-logger-msg - Plugin for sending LB notifications to messaging infrastructure

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1062757



--- Comment #2 from František Dvořák val...@civ.zcu.cz ---
Spec URL:
http://scientific.zcu.cz/fedora/glite-lb-logger-msg-1.2.13-1/glite-lb-logger-msg.spec
SRPM URL:
http://scientific.zcu.cz/fedora/glite-lb-logger-msg-1.2.13-1/glite-lb-logger-msg-1.2.13-1.fc21.src.rpm

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7096471

Changelog:
* New release 1.2.13 (LB 4.1.2)
* Added man pages
* Consistent style with buildroot macro

rpmlint:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1104746] Review Request: soscleaner - sosreport data obfuscation

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1104746

Jamie Duncan jdun...@redhat.com changed:

   What|Removed |Added

  Flags|needinfo?   |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1113951] Review Request: perl-App-GitHooks - Extensible plugins system for git hooks

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1113951

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Petr Šabata psab...@redhat.com ---
Check.  Approving.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114682] Review Request: python-OWSLib - Work with OGC map, feature, and coverage services

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114682



--- Comment #2 from Volker Fröhlich volke...@gmx.at ---
Spec URL: http://www.geofrogger.net/review/python-OWSLib.spec
SRPM URL: http://www.geofrogger.net/review/python-OWSLib-0.8.7-2.fc19.src.rpm

Corrected BR

The test suite is not included in the tarball, thus can't be executed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1115121] New: Review Request: osh - V6 Thompson Shell Port

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1115121

Bug ID: 1115121
   Summary: Review Request: osh - V6 Thompson Shell Port
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: i...@cicku.me
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://us-la.cicku.me/osh.spec
SRPM URL: http://us-la.cicku.me/osh-20140410-1.fc21.src.rpm
Description: Osh is an enhanced, backward-compatible port of the Sixth Edition
Thompson shell. Sh6 is an unenhanced port of the shell, and glob6 is a port of 
its global command. Together, sh6 and glob6 provide a user interface which is 
backward compatible with that provided by the Sixth Edition Thompson shell and
global command, but without the obvious enhancements found in osh.
Fedora Account System Username: cicku

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1115122] New: Review Request: zsh-lovers - A collection of tips, tricks and examples for the Z shell

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1115122

Bug ID: 1115122
   Summary: Review Request: zsh-lovers - A collection of tips,
tricks and examples for the Z shell
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: i...@cicku.me
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://us-la.cicku.me/zsh-lovers.spec
SRPM URL: http://us-la.cicku.me/zsh-lovers-0.9.0-1.fc21.src.rpm
Description: zsh-lovers is a small project which tries to collect tips, tricks
and examples for the Z shell.

This package only ships a manpage of the collection.
Fedora Account System Username: cicku

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1058623

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-07-01 11:36:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1058628] Review Request: linode-cli - Official command-line interface to the Linode platform

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1058628
Bug 1058628 depends on bug 1058623, which changed state.

Bug 1058623 Summary: Review Request: perl-WebService-Linode - Perl Interface to 
the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087017] Review Request: screen-message - Displays a short text fullscreen

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087017

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com



--- Comment #5 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Leon Weber from comment #4)
 Now referring to the renamed binary name in the man page:
 
 Spec URL: https://feynman.q-ix.net/rpm/screen-message.spec
 SRPM URL: https://feynman.q-ix.net/rpm/screen-message-0.20-3.fc20.src.rpm

Have you talked with upstream before rename everything?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 979166] Review Request: tora - Toolkit for Oracle, MySQL and PostreSQL

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=979166
Bug 979166 depends on bug 1026440, which changed state.

Bug 1026440 Summary: Please update antlr3 to version 3.5.1 and include C++ 
runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1026440

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 977646] Review Request: mylvmbackup - Utility for creating MySQL backups via LVM snapshots

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=977646

Christopher Meng i...@cicku.me changed:

   What|Removed |Added

  Flags|fedora-review?  |
   |needinfo?(l...@grimmer.com) |



--- Comment #8 from Christopher Meng i...@cicku.me ---
NEW SPEC URL: http://us-la.cicku.me/mylvmbackup.spec
NEW SRPM URL: http://us-la.cicku.me/mylvmbackup-0.15-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1112864] Review Request: elpa - High-performance library for parallel solution of eigenvalue problems

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1112864



--- Comment #19 from Dave Love d.l...@liverpool.ac.uk ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #15)

 It is build against atlas now. openblas doesn't support ARM yet. Do you
 think it's worth it to build against openblas on x86/x86_64 and atlas on ARM?

I don't know what difference it makes in this case, but I'd expect openblas to
be maybe twice as fast on sandybridge for DGEMM-based things, at least with the
packaged versions.  However, when I tried to compare atlas recently, I got
strange, non-reproducible results that I haven't tried to understand.

If the tests in the ELPA source make a reasonable benchmark, I could maybe
try, but I think they didn't run for long.

cp2k built with openblas, fftw, and openmpi actually seemed to out-perform a
version
built with all-intel on a similar cluster on the one case I had a report for,
but
I haven't tried very serious comparisons, and I've just discovered that the
Fedora
fftw isn't avx enabled.  I'd forgotten to file an issue suggesting it should
use
openblas.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087812

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||gpaw-0.10.0.11364-5.el6
 Resolution|--- |ERRATA
Last Closed|2014-04-22 05:30:07 |2014-07-01 13:05:08



--- Comment #32 from Fedora Update System upda...@fedoraproject.org ---
gpaw-0.10.0.11364-5.el6 has been pushed to the Fedora EPEL 6 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1105531] Review Request: gen-oath-safe - Script for generating HOTP/TOTP keys (and QR code)

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1105531

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|gen-oath-safe-0.9.0-1.fc20  |gen-oath-safe-0.9.0-1.el6



--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
gen-oath-safe-0.9.0-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1077795] Review Request: copr-selinux - SELinux module for COPR

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1077795

Antonio Trande anto.tra...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



--- Comment #5 from Antonio Trande anto.tra...@gmail.com ---
%{POLICYCOREUTILSVER} is not expanded and not exist.
Avoid to use macro in the comments (you can even redouble % to disable them).
%{sbinpath} or %{_sbindir} ? :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1108914] Review Request: python-simplejson3 - Simple, fast, extensible JSON encoder/decoder for Python

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1108914



--- Comment #2 from Mathieu Bridon boche...@fedoraproject.org ---
We'll only need this if we deploy on EL6, but it looks like we might deploy on
EL7 only.

To anyone who was thinking about reviewing this: don't waste your time for now,
I'll add a comment later on if we decide EL6 is needed. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1115185] New: Review Request: python-sphinx-rtd-theme - Sphinx theme for readthedocs.org

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1115185

Bug ID: 1115185
   Summary: Review Request: python-sphinx-rtd-theme - Sphinx theme
for readthedocs.org
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://jjames.fedorapeople.org/python-sphinx-rtd-theme/python-sphinx-rtd-theme.spec
SRPM URL:
http://jjames.fedorapeople.org/python-sphinx-rtd-theme/python-sphinx-rtd-theme-0.2013-1.20140611gitb83f5ad.fc21.src.rpm
Fedora Account System Username: jjames
Description: This is a prototype mobile-friendly sphinx theme for
readthedocs.org.  It's currently in development and includes some rtd variable
checks that can be ignored if you're just trying to use it on your project
outside of that site.

This package is a new build-time dependency for python-networkx.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114267] Review Request: python-cryptography - PyCA's cryptography library

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114267

Jamie Duncan jdun...@redhat.com changed:

   What|Removed |Added

 CC||jdun...@redhat.com



--- Comment #4 from Jamie Duncan jdun...@redhat.com ---
your spec file referenced in C #3 is breaking fedora-review:


No handlers could be found for logger trace.__main__
INFO: Downloading .spec and .srpm files
error: line 1: Unknown tag: !DOCTYPE html PUBLIC -//W3C//DTD XHTML 1.0
Transitional//EN
ERROR: Can't parse specfile: can't parse specfile\n (logs in
/home/jduncan/.cache/fedora-review.log)


attempting to reset it:

Spec Url: http://ayrx.fedorapeople.org/python-cryptography.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114749] Review Request: eclipse-webtools - Eclipse Webtools Projects

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114749



--- Comment #3 from Gerard Ryan ger...@ryan.lt ---
Spec URL: http://ryan.lt/eclipse-webtools/3.6.0-2/eclipse-webtools.spec
SRPM URL:
http://ryan.lt/eclipse-webtools/3.6.0-2/eclipse-webtools-3.6.0-2.fc21.src.rpm

Hi Gil,

Thanks for the review!

(In reply to gil cattaneo from comment #2)
 
 Issues:
 ===
 - If (and only if) the source package includes the text of the license(s) in
   its own file, then that file, containing the text of the license(s) for the
   package is included in %doc.
   Note: Cannot find license.html in rpm(s)
   See:
   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
   seem you use a eclipselink license file. please, report a bug for upstream
 for include it

I've changed this now to
webtools.common/features/org.eclipse.jst.common_core.feature.patch/epl-v10.html
which is included in the source package. Is this acceptable?

 - Bundled jar/class files should be removed before build
   Note: Jar files in source (see attachment)
   See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
   built_JAR_files_.2F_Other_bundled_software'

I missed the class files, thanks for pointing it out. They're removed now.
There's a false positive for the jar file that's reported, since it's a
directory whose name ends with .jar:

 ./webtools.releng.aggregator/webtools.javaee.tests/tests/org.eclipse.jst.j2ee.core.tests/commonArchiveResources/loose_module_workspace/boo.jar

Thanks,
Gerard.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1099499] Review Request: python-oslo-vmware - Oslo VMware library for OpenStack projects

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1099499

Jon Bernard jober...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #10 from Jon Bernard jober...@redhat.com ---
New Package SCM Request
===
Package Name: python-oslo-vmware
Short Description: Oslo VMware library for OpenStack projects
Upstream URL: http://launchpad.net/oslo
Owners: jbernard flaper87
Branches: f20 el6 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114749] Review Request: eclipse-webtools - Eclipse Webtools Projects

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114749

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #4 from gil cattaneo punto...@libero.it ---
(In reply to Gerard Ryan from comment #3)


 I've changed this now to
 webtools.common/features/org.eclipse.jst.common_core.feature.patch/epl-v10.
 html which is included in the source package. Is this acceptable?
for me yes
  - Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
built_JAR_files_.2F_Other_bundled_software'
 
 I missed the class files, thanks for pointing it out. They're removed now.
 There's a false positive for the jar file that's reported, since it's a
 directory whose name ends with .jar:
 
  ./webtools.releng.aggregator/webtools.javaee.tests/tests/org.eclipse.jst.j2ee.core.tests/commonArchiveResources/loose_module_workspace/boo.jar

there is this file with different license, maybe, before import, please fix
license field

Apache (v2.0)
-
webtools.releng.aggregator/webtools.releng/releng.wtptools/api/org.eclipse.wtp.releng.wtpbuilder/src/org/eclipse/wtp/releng/wtpbuilder/Main.java

org.eclipse.persistence.jpa.jpql is available in eclipselink package (JSR 317)
if you dont need a newer release (JSR 338), please remove.

thanks to you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1067003] Review Request: perl-Time-ParseDate - Date parsing both relative and absolute

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1067003



--- Comment #10 from Denis Fateyev de...@fateyev.com ---
Fixed the long description and adjusted license tag.
Updated version:
http://www.fateyev.com/RPMS/Fedora20/testing/perl-Time-ParseDate.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1105015] Review Request: lua-ldap - LDAP client library for Lua

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1105015



--- Comment #3 from Jeff Backus jeff.bac...@gmail.com ---
(In reply to Dan Callaghan from comment #2)
 
 The license is in the tarball as doc/us/license.html (easily missed since
 it's not included as plain text in the root, like most packages).
 
 It's in the corresponding place under /usr/share/doc for the lua-ldap and
 lua-ldap-compat packages as well.
 

Found it. Thanks!

  [-]: %check is present and all tests pass.
   Source tarball contains what looks like some sort of test. Maybe add as
  %check?
 
 I wrote a little script to allow running the tests against a dummy slapd in
 %check.
 
 https://github.com/luaforge/lualdap/pull/2

Looks good. Thanks!

 
  [!]: Packages should try to preserve timestamps of original installed files.
   Please work with upstream (or create a patch) to change the following
  line in the Makefile:
  cp src/$(LIBNAME) $(LUA_LIBDIR)
   to:
  cp -p src/$(LIBNAME) $(LUA_LIBDIR)
 
 Preserving timestamps in this case doesn't serve much purpose, since the
 file is built right before that and is not included in multiple subpackages
 or anything like that. However I can easily add it.
 

Good point. Also, unfortunately, I seem to have given you erroneous advice. cp
-p copies all permissions, so now I'm getting a rpmlint error. The correct
method is to use install -p. I verified that this is correct. Please change
destdir.patch to either use install -p or to not use cp -p on line 12. Sorry
about that!

 http://fedorapeople.org/~dcallagh/lua-ldap/lua-ldap.spec
 http://fedorapeople.org/~dcallagh/lua-ldap/lua-ldap-1.1.0-2.fc21.src.rpm

Since this package hasn't been built by the system, increasing the version
number is optional. Please see the section on multiple Changelog Entries per
Release in the guidelines for more information. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Multiple_Changelog_Entries_per_Release

So, in summary, please fix the previous fix I requested ('cp -p' - 'install
-p' or just 'cp'). Otherwise, the package looks good!

Regards,
Jeff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1033796] Review Request: golang-launchpad-gocheck - Rich testing framework for the Go language

2014-07-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1033796

John Skeoch jske...@redhat.com changed:

   What|Removed |Added

   Assignee|l...@redhat.com |jk...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >