[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal
https://bugzilla.redhat.com/show_bug.cgi?id=1122577
--- Comment #2 from Lukas Zapletal l...@redhat.com ---
Hey,
thanks for the flag and initial review.
Github tarballs used to be problematic due to githashes in the tarballs but it
looks like they changed it:
git-xcleaner-git-xcleaner-1.1-1/.gitignore
git-xcleaner-git-xcleaner-1.1-1/LICENSE
git-xcleaner-git-xcleaner-1.1-1/README.md
git-xcleaner-git-xcleaner-1.1-1/git-xcleaner
git-xcleaner-git-xcleaner-1.1-1/git-xcleaner.spec
git-xcleaner-git-xcleaner-1.1-1/man/
git-xcleaner-git-xcleaner-1.1-1/man/git-xcleaner.md
git-xcleaner-git-xcleaner-1.1-1/man/git-xcleaner.txt
git-xcleaner-git-xcleaner-1.1-1/rel-eng/
git-xcleaner-git-xcleaner-1.1-1/rel-eng/packages/
git-xcleaner-git-xcleaner-1.1-1/rel-eng/packages/.readme
git-xcleaner-git-xcleaner-1.1-1/rel-eng/packages/git-xcleaner
git-xcleaner-git-xcleaner-1.1-1/rel-eng/tito.props
git-xcleaner-git-xcleaner-1.1-1/screenshots/
git-xcleaner-git-xcleaner-1.1-1/screenshots/01_main_menu.png
git-xcleaner-git-xcleaner-1.1-1/screenshots/02_select.png
So I assume I can use %{name}-%{name} here which is - weird - but it will work.
Please go ahead with the review and I will change this in the next release.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121988] Review Request: zanata-python-client - Python Client for Zanata Server
https://bugzilla.redhat.com/show_bug.cgi?id=1121988
--- Comment #1 from Parag AN(पराग) panem...@gmail.com ---
Review:
+ mock build is successful for f22.
+ rpmlint output on rpms gave
zanata-python-client.noarch: E: explicit-lib-dependency python-hashlib
zanata-python-client.noarch: E: incorrect-fsf-address /usr/bin/flies
zanata-python-client.noarch: W: no-manual-page-for-binary flies
zanata-python-client.noarch: W: no-manual-page-for-binary zanata
zanata-python-client.src:179: W: macro-in-%changelog %doc
2 packages and 0 specfiles checked; 2 errors, 3 warnings.
+ Source verified with upstream as (sha256sum)
srpm tarball
:9cbc8cacc3f86327e2a2aa902cd8215df3964dc23b395043338d75460aebd77b
upstream tarball
:9cbc8cacc3f86327e2a2aa902cd8215df3964dc23b395043338d75460aebd77b
+ License MIT is valid and is included in its own file as %doc
+ rest looks following packaging guidelines.
Suggestions:
1) Ask upstream to fix the fsf address in /usr/bin/flies
2) every '%' character in changelog should be written as '%%'
3) you don't need sitelib macro for current Fedora releases
%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print get_python_lib())}
drop above.
4) Drop Group tag
5) Instead of following
%if 0%{?fedora} 13
BuildRequires: python-devel
%endif
just add
BuildRequires: python2-devel
we want this BR: for python packages
6) Change %{__python} to %{__python2}
7) drop %clean
8) change %{python_sitelib} to %{python2_sitelib}
9) drop defattr line
Check more on http://fedoraproject.org/wiki/Packaging:Python
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 Peng Wu p...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-07-24 02:34:46 --- Comment #8 from Peng Wu p...@redhat.com --- Built for rawhide and F21, close bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115049] Review Request: freight - A modern take on the Debian archive
https://bugzilla.redhat.com/show_bug.cgi?id=1115049 Dominic Cleal dcl...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2014-07-24 02:50:06 --- Comment #14 from Dominic Cleal dcl...@redhat.com --- Released to stable for F20, F21, EL6 and EL7. Thanks for the reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #9 from Christopher Meng i...@cicku.me --- Can you build and push update to f20? I can't understand why f20 users can't use it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium
https://bugzilla.redhat.com/show_bug.cgi?id=1113310 --- Comment #7 from Christopher Meng i...@cicku.me --- I just wonder wht it has libnacl instead of libsodium in its name? ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal
https://bugzilla.redhat.com/show_bug.cgi?id=1122577
Christopher Meng i...@cicku.me changed:
What|Removed |Added
CC||i...@cicku.me
--- Comment #3 from Christopher Meng i...@cicku.me ---
(In reply to Lukas Zapletal from comment #2)
So I assume I can use %{name}-%{name} here which is - weird - but it will
work.
The way you tag your project is weird, actually it's confusing.
You should tag it directly in github with something like 1.1 or v1.1.
Then download the source and use this link in your SPEC:
https://github.com/lzap/git-xcleaner/archive/1.1.tar.gz#/%{name}-%{version}.tar.gz
Now your tag is git-xcleaner-1.1-1. I'm sorry but I think it's a crap. First I
don't think your project worth some alpha/beta in the tags, second what does -1
means? Why not 1.1.1?
Take a look at the packages using source from github, I think you will
understand:
http://pkgs.fedoraproject.org/cgit/git-cola.git/tree/git-cola.spec#n7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium
https://bugzilla.redhat.com/show_bug.cgi?id=1113310 --- Comment #8 from Erik Johnson e...@saltstack.com --- Not sure, I didn't write it :) I think it was named libnacl partly because it was written as an alternative to PyNaCl. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113392] Review Request: xorg-x11-drv-libinput - Xorg X11 libinput input driver
https://bugzilla.redhat.com/show_bug.cgi?id=1113392 Peter Hutterer peter.hutte...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Peter Hutterer peter.hutte...@redhat.com --- Thanks Parag. All fixed locally and upstream as requested. New Package SCM Request === Package Name: xorg-x11-drv-libinput Short Description: Xorg X11 libinput input driver Upstream URL: https://github.com/whot/xf86-input-libinput Owners: whot jwrdegoede Branches: F21 InitialCC: xgl-maint -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #10 from Peng Wu p...@redhat.com --- I will use/test for a few days, before push it for f20. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121968] Review Request: adobe-source-han-sans-twhk-fonts - Adobe OpenType Pan-CJK font family for Traditional Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121968 Peng Wu p...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-07-24 03:23:05 --- Comment #6 from Peng Wu p...@redhat.com --- Built for rawhide and F21, close bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #11 from Christopher Meng i...@cicku.me --- It would still be better to push it to testing, as many Chinese are requesting it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #12 from Christopher Meng i...@cicku.me --- Thanks for packaging it! I just thought if Fedora has plan to move to this one as default. WenQuanYi is nearly stalled now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122735] Review Request: perl-IO-Pty-Easy - Easy interface to IO::Pty
https://bugzilla.redhat.com/show_bug.cgi?id=1122735 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #13 from Peng Wu p...@redhat.com --- I will push it soon. Currently WenQuanYi has more glyph coverage. If you want to use it as default, just need to install the new fonts, then remove wqy-*-fonts and cjkuni-*-fonts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122735] Review Request: perl-IO-Pty-Easy - Easy interface to IO::Pty
https://bugzilla.redhat.com/show_bug.cgi?id=1122735
Christopher Meng i...@cicku.me changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Christopher Meng i...@cicku.me ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 1 files have unknown license. Detailed output of
licensecheck:
Unknown or generated
IO-Pty-Easy-0.09/lib/IO/Pty/Easy.pm
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/IO
(perl-IO-String, perl-IO-SessionData, perl-IO-Socket-SSL, perl-IO-Socket-
IP, perl-IO-Socket-INET6, perl-IO-Multiplex, perl-IO-HTML, perl-IO-
stringy)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources
[Bug 1122731] Review Request: perl-File-Spec-Native - Use native OS implementation of File::Spec from a subclass
https://bugzilla.redhat.com/show_bug.cgi?id=1122731 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 445977] Review Request: ikiwiki - A wiki compiler
https://bugzilla.redhat.com/show_bug.cgi?id=445977 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC||thomas.mosc...@gmx.de Flags||needinfo?(thomas.moschny@gm ||x.de) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal
https://bugzilla.redhat.com/show_bug.cgi?id=1122577 --- Comment #4 from Fabio Alessandro Locati fabioloc...@gmail.com --- I've to agree with Christopher that the way you tagged is weird, even because if the upstream version is 1.1-1, would be wrong to tag the Fedora Package as 1.1-1, since it should be tagged as 1.1-1-1 (I'm not suggesting to do it, I'm only saying that the coherence is needed). Since we are talking about the versioning of the project... where did the 1.0 is/was/have been? I think the wikipedia page http://en.wikipedia.org/wiki/Software_versioning has a lot of great ideas and suggestions on how to tag a software. Every method is acceptable (some software are not tagged at all), but some methods are easier to be managed by the packagers and by the users. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109751] Review Request: python-emcee - The Python ensemble sampling toolkit for affine-invariant MCMC
https://bugzilla.redhat.com/show_bug.cgi?id=1109751 --- Comment #2 from Sergio Pascual sergio.pa...@gmail.com --- Thanks for the review!! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1116028] Review Request: rubygem-elasticsearch-transport - Elasticsearch transport
https://bugzilla.redhat.com/show_bug.cgi?id=1116028 --- Comment #4 from Steve Traylen steve.tray...@cern.ch --- Spec URL: http://cern.ch/straylen/rpms/rubygem-elasticsearch-transport/rubygem-elasticsearch-transport.spec SRPM URL: http://cern.ch/straylen/rpms/rubygem-elasticsearch-transport/rubygem-elasticsearch-transport-1.0.4-2.fc20.src.rpm all comments addressed, I also moved the tests to the doc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121485] Review Request: adobe-source-han-sans-cn-fonts - Adobe OpenType Pan-CJK font family for Simplified Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121485 --- Comment #14 from Peng Wu p...@redhat.com --- built for f20 and submitted in bodhi. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121968] Review Request: adobe-source-han-sans-twhk-fonts - Adobe OpenType Pan-CJK font family for Traditional Chinese
https://bugzilla.redhat.com/show_bug.cgi?id=1121968 --- Comment #7 from Peng Wu p...@redhat.com --- built for f20 and submitted in bodhi. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium
https://bugzilla.redhat.com/show_bug.cgi?id=1113310 Sergio Pascual sergio.pa...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||sergio.pa...@gmail.com Assignee|nob...@fedoraproject.org|sergio.pa...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113328] Review Request: python-ioflo - Flow Based Programming Automated Reasoning Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1113328 Sergio Pascual sergio.pa...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||sergio.pa...@gmail.com Docs Contact||sergio.pa...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791
--- Comment #6 from Christopher Meng i...@cicku.me ---
1. Drop this line as well: mkdir -p %{buildroot}%{_datadir}/applications
2. Final question here, main pkg has %doc LICENSE.txt README.txt CHANGELOG.txt.
And somehow I think it's better to put README and CHANGELOG to the -devel.
3. Does it support python3?
Nonetheless, PACKAGE APPROVED.
Once above are checked, I will set + here.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122735] Review Request: perl-IO-Pty-Easy - Easy interface to IO::Pty
https://bugzilla.redhat.com/show_bug.cgi?id=1122735 David Dick dd...@cpan.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from David Dick dd...@cpan.org --- Thanks Christopher! This is awesome. New Package SCM Request === Package Name: perl-IO-Pty-Easy Short Description: Easy interface to IO::Pty Upstream URL: http://search.cpan.org/dist/IO-Pty-Easy/ Owners: ddick Branches: f20, f21, el6, epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 244262] Review Request: perl-CGI-FormBuilder - Easily generate and process stateful forms
https://bugzilla.redhat.com/show_bug.cgi?id=244262 Thomas Moschny thomas.mosc...@gmx.de changed: What|Removed |Added CC||thomas.mosc...@gmx.de Flags||needinfo?(ktdreyer@ktdreyer ||.com) --- Comment #15 from Thomas Moschny thomas.mosc...@gmx.de --- Ken, would you mind also maintaining an EPEL7 branch? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 243716] Review Request: perl-Text-Markdown - A text-to-HTML filter
https://bugzilla.redhat.com/show_bug.cgi?id=243716 Thomas Moschny thomas.mosc...@gmx.de changed: What|Removed |Added CC||thomas.mosc...@gmx.de Flags||needinfo?(lkund...@v3.sk) --- Comment #19 from Thomas Moschny thomas.mosc...@gmx.de --- Lubomir, would you mind also maintaining this package in EPEL7? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 445977] Review Request: ikiwiki - A wiki compiler
https://bugzilla.redhat.com/show_bug.cgi?id=445977 Thomas Moschny thomas.mosc...@gmx.de changed: What|Removed |Added Flags|needinfo?(thomas.moschny@gm |fedora-cvs? |x.de) fedora-cvs+ | --- Comment #20 from Thomas Moschny thomas.mosc...@gmx.de --- perl-Text-Markdown and perl-CGI-FormBuilder are still not in EPEL7. Ok, so let's go for EPEL6 at least now. Package Change Request == Package Name: ikiwiki New Branches: el6 Owners: thm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal
https://bugzilla.redhat.com/show_bug.cgi?id=1122577 --- Comment #5 from Lukas Zapletal l...@redhat.com --- Chris, my tag is fine, I use tito tool (https://github.com/dgoodwin/tito) which is configured by default to store RELEASE in tags and I want to do that, because it is _very_ helpful to track whole nvre as tags. Tito has mechanisms to check for pushed tags when submitting builds into Koji (or making release tarballs), because the SPEC file is part of the upstream project in this case. This is how it works and there are many other projects with the similar approach (e.g. Spacewalk - https://git.fedorahosted.org/cgit/spacewalk.git/refs/tags). It is not confusing if you realize that the SPEC file is part of the upstream project, I will be the Fedora maintainer. Other distribution maintainers can safely ignore the release, it is only used to fix bugs in the Fedora packaging. The tito tool is capable of making _correct_ tarballs (/tmp/tito/git-xcleaner-1.1.tar.gz in my case). I have never intended to use github.com tarball feature for the reason I've described above. Therefore I will add this as Source URL: http://lzap.fedorapeople.org/projects/git-xcleaner/git-xcleaner-1.1.tar.gz My versioning convention will be 1.1234, because this tiny tool is not worth three levels in versioning scheme. To be honeste, I like simple number versioning scheme (e.g. Google Chrome or systemd), but I am fine with the standard two levels. Since I had one upstream change (changed welcome text), I released new version 1.2 which contains this change plus the new URL upstream tarball site: http://lzap.fedorapeople.org/fedora-packaging/git-xcleaner/1.2-1/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal
https://bugzilla.redhat.com/show_bug.cgi?id=1122577 --- Comment #6 from Christopher Meng i...@cicku.me --- (In reply to Lukas Zapletal from comment #5) Chris, my tag is fine, I use tito tool (https://github.com/dgoodwin/tito) which is configured by default to store RELEASE in tags and I want to do that, because it is _very_ helpful to track whole nvre as tags. Tito has mechanisms to check for pushed tags when submitting builds into Koji (or making release tarballs), because the SPEC file is part of the upstream project in this case. This is how it works and there are many other projects with the similar approach (e.g. Spacewalk - https://git.fedorahosted.org/cgit/spacewalk.git/refs/tags). Yes, and I often see this kind of fine tags in projects relating to RH. It is not confusing if you realize that the SPEC file is part of the upstream project, I will be the Fedora maintainer. Other distribution maintainers can safely ignore the release, it is only used to fix bugs in the Fedora packaging. The tito tool is capable of making _correct_ tarballs (/tmp/tito/git-xcleaner-1.1.tar.gz in my case). Yes, and then the Source tag comes without fill link. https://fedoraproject.org/wiki/Packaging:SourceURL My versioning convention will be 1.1234, because this tiny tool is not worth three levels in versioning scheme. To be honeste, I like simple number versioning scheme (e.g. Google Chrome or systemd), but I am fine with the standard two levels. Up to you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1001818] Review Request: rubygem-table_print - shows objects in nicely formatted columns for easy reading
https://bugzilla.redhat.com/show_bug.cgi?id=1001818 Achilleas Pipinellis axill...@axilleas.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||axill...@axilleas.me -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958865] Review Request: edk2 - EFI Development Kit II
https://bugzilla.redhat.com/show_bug.cgi?id=958865 --- Comment #15 from Paolo Bonzini pbonz...@redhat.com --- Package Change Request == Package Name: edk2 New Branches: el6 epel7 Owners: bonzini crobinso InitialCC: virtmaint -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958865] Review Request: edk2 - EFI Development Kit II
https://bugzilla.redhat.com/show_bug.cgi?id=958865 Paolo Bonzini pbonz...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121988] Review Request: zanata-python-client - Python Client for Zanata Server
https://bugzilla.redhat.com/show_bug.cgi?id=1121988 --- Comment #2 from Parag AN(पराग) panem...@gmail.com --- ugh! pasting mistake. I see license for this package is LGPLv2+ Drop COPYING file in %doc as it contains GPLv3+ text which is not related to this package. Good to drop it from upstream also. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121988] Review Request: zanata-python-client - Python Client for Zanata Server
https://bugzilla.redhat.com/show_bug.cgi?id=1121988 --- Comment #3 from anish apa...@redhat.com --- Hi Parag Thank you for your review comments, I have opened a bug for correct fsf file on upstream Please find new SRPM and Spec file on Spec URL: http://anishpatil.fedorapeople.org/zanata-python-client.spec SRPM URL: http://anishpatil.fedorapeople.org/zanata-python-client-1.3.14-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal
https://bugzilla.redhat.com/show_bug.cgi?id=1122577 --- Comment #7 from Lukas Zapletal l...@redhat.com --- Yes, and I often see this kind of fine tags in projects relating to RH. Indeed, tito was created by ex-Spacewalk guy and many other folks around this project got used to it. I am open for other releasing tool recommendations but this one has really many features tight to Fedora, RPMs and the workflow. The key concept here is when the upstream author is also the package maintaner. All is done by tito, then imported as SRPM into distgit. Yes, and then the Source tag comes without fill link. https://fedoraproject.org/wiki/Packaging:SourceURL Sorry, what you mean? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #5 from anish apa...@redhat.com --- Thanks Parag for review New Package SCM Request === Package Name: nodejs-sprintf Short Description: JavaScript sprintf implementation Upstream URL: https://github.com/maritz/node-sprintf Owners: anishoatik Branches: f20 f21 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 anish apa...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096184] Review Request: nodejs-i18n-transform - i18n transforms to a json object
https://bugzilla.redhat.com/show_bug.cgi?id=1096184 --- Comment #4 from anish apa...@redhat.com --- Thanks Parag for review New Package SCM Request === Package Name: nodejs-i18n-transform Short Description: i18n transforms to a json objec Upstream URL: https://github.com/andyroyle/i18n-transform Owners: anishpatil Branches: f20 f21 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096184] Review Request: nodejs-i18n-transform - i18n transforms to a json object
https://bugzilla.redhat.com/show_bug.cgi?id=1096184 anish apa...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #6 from anish apa...@redhat.com --- Correct owners name in earlier comment New Package SCM Request === Package Name: nodejs-sprintf Short Description: JavaScript sprintf implementation Upstream URL: https://github.com/maritz/node-sprintf Owners: anishpatil Branches: f20 f21 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800265] Review Request: perl-Net-Google-Spreadsheets - Perl module for using Google Spreadsheets API
https://bugzilla.redhat.com/show_bug.cgi?id=800265 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 800265] Review Request: perl-Net-Google-Spreadsheets - Perl module for using Google Spreadsheets API
https://bugzilla.redhat.com/show_bug.cgi?id=800265 --- Comment #1 from Petr Pisar ppi...@redhat.com --- URL is usable. Ok. Source0 does not exist anymore. FIX: The 0.14 version is not distributed by CPAN anymore. Upstream released a new version 0.1501. Please upgrade the package and provide new spec and SRPM files. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121934] Review Request: perl-Term-EditorEdit - Edit a document via $EDITOR
https://bugzilla.redhat.com/show_bug.cgi?id=1121934 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121934] Review Request: perl-Term-EditorEdit - Edit a document via $EDITOR
https://bugzilla.redhat.com/show_bug.cgi?id=1121934 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar ppi...@redhat.com --- Inner and standalone spec files differ. I will use the standalone one for this review. URL and Source0 are usable. Ok. Source archive is original (SHA-256: 1af6774e7c686dea23eb89948469b1525ec097486b4ed1d7e8764026ae10fceb). Ok. Summary verified from README. Ok. Description verified from REAEDM. TODO: Append full-stop marker at the and of the description text. License verified from lib/Term/EditorEdit.pm, README. Ok. No XS code. noarch BuildArch is Ok. TODO: Constrain `perl(ExtUtils::MakeMaker)' build-time dependency with `= 6.30' (Makefile.PL:7). TODO: You can replace PERL_INSTALL_ROOT= with DESTDIR= in the %install section. All build-requires are declared. Ok. The useless editor-edit script is removed from PATH. Ok. All tests pass. Ok. $ rpmlint perl-Term-EditorEdit.spec ../SRPMS/perl-Term-EditorEdit-0.0016-1.fc22.src.rpm ../RPMS/noarch/perl-Term-EditorEdit-0.0016-1.fc22.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Term-EditorEdit-0.0016-1.fc22.noarch.rpm drwxr-xr-x2 rootroot0 Jul 24 14:10 /usr/share/doc/perl-Term-EditorEdit -rw-r--r--1 rootroot 619 Jul 5 2011 /usr/share/doc/perl-Term-EditorEdit/Changes -rw-r--r--1 rootroot 2714 Jul 5 2011 /usr/share/doc/perl-Term-EditorEdit/README -rwxr-xr-x1 rootroot 129 Jul 5 2011 /usr/share/doc/perl-Term-EditorEdit/editor-edit -rw-r--r--1 rootroot 2916 Jul 24 14:10 /usr/share/man/man3/Term::EditorEdit.3pm.gz drwxr-xr-x2 rootroot0 Jul 24 14:10 /usr/share/perl5/vendor_perl/Term drwxr-xr-x2 rootroot0 Jul 24 14:10 /usr/share/perl5/vendor_perl/Term/EditorEdit -rw-r--r--1 rootroot 4040 Jul 5 2011 /usr/share/perl5/vendor_perl/Term/EditorEdit.pm -rw-r--r--1 rootroot 6020 Jul 5 2011 /usr/share/perl5/vendor_perl/Term/EditorEdit/Edit.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Term-EditorEdit-0.0016-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(Any::Moose) 1 perl(Carp) 1 perl(File::Temp) 1 perl(IO::File) 1 perl(strict) 1 perl(Term::EditorEdit::Edit) 1 perl(Text::Clip) 1 perl(Try::Tiny) 1 perl(warnings) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Term-EditorEdit-0.0016-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Term::EditorEdit) = 0.0016 1 perl(Term::EditorEdit::Edit) 1 perl-Term-EditorEdit = 0.0016-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Term-EditorEdit-0.0016-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7190404). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 445977] Review Request: ikiwiki - A wiki compiler
https://bugzilla.redhat.com/show_bug.cgi?id=445977 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 445977] Review Request: ikiwiki - A wiki compiler
https://bugzilla.redhat.com/show_bug.cgi?id=445977 --- Comment #21 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958865] Review Request: edk2 - EFI Development Kit II
https://bugzilla.redhat.com/show_bug.cgi?id=958865 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958865] Review Request: edk2 - EFI Development Kit II
https://bugzilla.redhat.com/show_bug.cgi?id=958865 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096072] Review Request: nodejs-sprintf - JavaScript sprintf implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1096072 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096184] Review Request: nodejs-i18n-transform - i18n transforms to a json object
https://bugzilla.redhat.com/show_bug.cgi?id=1096184 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096184] Review Request: nodejs-i18n-transform - i18n transforms to a json object
https://bugzilla.redhat.com/show_bug.cgi?id=1096184 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113392] Review Request: xorg-x11-drv-libinput - Xorg X11 libinput input driver
https://bugzilla.redhat.com/show_bug.cgi?id=1113392 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113392] Review Request: xorg-x11-drv-libinput - Xorg X11 libinput input driver
https://bugzilla.redhat.com/show_bug.cgi?id=1113392 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119986] EPEL7 branch couchdb
https://bugzilla.redhat.com/show_bug.cgi?id=1119986 --- Comment #1 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119986] EPEL7 branch couchdb
https://bugzilla.redhat.com/show_bug.cgi?id=1119986 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122484] Review Request: perl-Date-Handler - Easy but complete date object
https://bugzilla.redhat.com/show_bug.cgi?id=1122484 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122484] Review Request: perl-Date-Handler - Easy but complete date object
https://bugzilla.redhat.com/show_bug.cgi?id=1122484 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122735] Review Request: perl-IO-Pty-Easy - Easy interface to IO::Pty
https://bugzilla.redhat.com/show_bug.cgi?id=1122735 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122735] Review Request: perl-IO-Pty-Easy - Easy interface to IO::Pty
https://bugzilla.redhat.com/show_bug.cgi?id=1122735 --- Comment #4 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122749] EPEL7 branch erlang-oauth erlang-mochiweb erlang-snappy
https://bugzilla.redhat.com/show_bug.cgi?id=1122749 --- Comment #1 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122749] EPEL7 branch erlang-oauth erlang-mochiweb erlang-snappy
https://bugzilla.redhat.com/show_bug.cgi?id=1122749 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122747] EPEL7 branch autoconf-archive
https://bugzilla.redhat.com/show_bug.cgi?id=1122747 --- Comment #1 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122747] EPEL7 branch autoconf-archive
https://bugzilla.redhat.com/show_bug.cgi?id=1122747 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122941] New: Review Request: rubygem-font-awesome-rails - An asset gemification of the font-awesome icon font library
https://bugzilla.redhat.com/show_bug.cgi?id=1122941 Bug ID: 1122941 Summary: Review Request: rubygem-font-awesome-rails - An asset gemification of the font-awesome icon font library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jstri...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-font-awesome-rails-4.1.0.0-1.fc22.src.rpm Description: A font-awesome icon font library for the Rails asset pipeline. Fedora Account System Username: jstribny -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122939] New: Review Request: rubygem-jquery-ui-rails - jQuery UI packaged for the Rails asset pipeline
https://bugzilla.redhat.com/show_bug.cgi?id=1122939 Bug ID: 1122939 Summary: Review Request: rubygem-jquery-ui-rails - jQuery UI packaged for the Rails asset pipeline Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jstri...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-ui-rails.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-ui-rails-5.0.0-1.fc22.src.rpm Description: jQuery UI's JavaScript, CSS, and image files packaged for the Rails 3.1+ asset pipeline. Fedora Account System Username: jstribny -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122940] New: Review Request: rubygem-capybara_minitest_spec - Capybara + MiniTest::Spec
https://bugzilla.redhat.com/show_bug.cgi?id=1122940
Bug ID: 1122940
Summary: Review Request: rubygem-capybara_minitest_spec -
Capybara + MiniTest::Spec
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: jstri...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Spec URL:
http://data-strzibny.rhcloud.com/obs/rubygem-capybara_minitest_spec.spec
SRPM URL:
http://data-strzibny.rhcloud.com/obs/rubygem-capybara_minitest_spec-1.0.2-1.fc22.src.rpm
Description: Use Capybara matchers with MiniTest. Specifically, it defines
MiniTest::Spec expectations like page.must_have_content('content').
Fedora Account System Username: jstribny
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122944] New: Review Request: rubygem-jquery-datatables-rails - jQuery datatables for rails
https://bugzilla.redhat.com/show_bug.cgi?id=1122944 Bug ID: 1122944 Summary: Review Request: rubygem-jquery-datatables-rails - jQuery datatables for rails Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jstri...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-datatables-rails.spec SRPM URL: http://data-strzibny.rhcloud.com/obs/rubygem-jquery-datatables-rails-2.1.10.0.3-1.fc22.src.rpm Description: This gem packages the jQuery DataTables plugin for the Rails 3.1+ asset pipeline. It provides all the basic DataTables files, and a few of the extras. Fedora Account System Username: jstribny -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089493] Review Request: bashmount - A menu-driven bash script for mounting removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1089493 --- Comment #5 from jiri vanek jva...@redhat.com --- If this will go to f21 then suggest will not be here. But I guess this depends on maintainer. Thank you for watching (not just this ) review -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122954] New: EPEL-7 branch: perl-Unix-Syslog
https://bugzilla.redhat.com/show_bug.cgi?id=1122954 Bug ID: 1122954 Summary: EPEL-7 branch: perl-Unix-Syslog Product: Fedora EPEL Version: epel7 Component: Package Review Assignee: nob...@fedoraproject.org Reporter: mstev...@imt-systems.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Package Change Request == Package Name: perl-Unix-Syslog New Branches: epel7 Owners: steve mstevens This is needed to fix #1121606 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122955] New: EPEL-7 branch: perl-Convert-TNEF
https://bugzilla.redhat.com/show_bug.cgi?id=1122955 Bug ID: 1122955 Summary: EPEL-7 branch: perl-Convert-TNEF Product: Fedora EPEL Version: epel7 Component: Package Review Assignee: nob...@fedoraproject.org Reporter: mstev...@imt-systems.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Package Change Request == Package Name: perl-Convert-TNEF New Branches: epel7 Owners: steve mstevens This is needed to fix #1121606 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1121988] Review Request: zanata-python-client - Python Client for Zanata Server
https://bugzilla.redhat.com/show_bug.cgi?id=1121988
--- Comment #4 from Parag AN(पराग) panem...@gmail.com ---
Few more fixes needed
1) In above link spec I can still see COPYING packaged, remove it
2) change
%{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT
to
%{__python2} setup.py install --skip-build --root $RPM_BUILD_ROOT
3)change
python2 setup.py build
to
%{__python2} setup.py build
All this is given on
http://fedoraproject.org/wiki/Packaging:Python#Example_spec_file
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117906] Review Request: python-scikit-image - Image processing in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1117906
--- Comment #2 from Erik Johnson e...@saltstack.com ---
On which branches do you intend this to be built?
The with_python3 at the top will keep this from building for EPEL 7. Also,
if you want to build on EPEL 6 and earlier, then you'd need to define some
additional python macros
(https://fedoraproject.org/wiki/Packaging:Python#Macros). For instance, I use
following to allow the package to build properly on all current Fedora and EPEL
branches:
%if 0%{?fedora} 12 || 0%{?rhel} 6
%global with_python3 1
%else
%if 0%{?rhel} == 5
%global with_python26 1
%global pybasever 2.6
%endif
%{!?__python2: %global __python2 /usr/bin/python%{?pybasever}}
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c from
distutils.sysconfig import get_python_lib; print get_python_lib(1))}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
%endif
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113541] Rename Request: x11trace - Utility for tracing X11 protocol for debugging
https://bugzilla.redhat.com/show_bug.cgi?id=1113541 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-07-24 10:16:30 --- Comment #12 from Parag AN(पराग) panem...@gmail.com --- Thanks. We can close this review then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745510] Review Request: vdsm - Virtual Desktop Server Manager
https://bugzilla.redhat.com/show_bug.cgi?id=745510 Douglas Schilling Landgraf dougsl...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #26 from Douglas Schilling Landgraf dougsl...@redhat.com --- Package Change Request == Package Name: vdsm New Branches: el6 epel7 Owners: fsimonce danken smizrahi bronhaim dougsland -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122996] New: Review Request: openstack-tempest - set of integration tests to be run against a live OpenStack cluster
https://bugzilla.redhat.com/show_bug.cgi?id=1122996 Bug ID: 1122996 Summary: Review Request: openstack-tempest - set of integration tests to be run against a live OpenStack cluster Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: slina...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://slinabery.fedorapeople.org/openstack-tempest/openstack-tempest.spec SRPM URL: http://slinabery.fedorapeople.org/openstack-tempest/openstack-tempest-20140703-2.fc20.src.rpm Description: This is a set of integration tests to be run against a live OpenStack cluster, icehouse release. Tempest has batteries of tests for OpenStack API validation, Scenarios, and other specific tests useful in validating an OpenStack deployment. Fedora Account System Username: slinabery -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1116238] Review Request: openstack-tempest-icehouse - set of integration tests to be run against a live OpenStack cluster
https://bugzilla.redhat.com/show_bug.cgi?id=1116238 Steve Linabery slina...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Flags|needinfo?(p...@draigbrady.com) | Last Closed||2014-07-24 10:42:52 --- Comment #13 from Steve Linabery slina...@redhat.com --- New review request for openstack-tempest package using subpackage approach: https://bugzilla.redhat.com/show_bug.cgi?id=1122996 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123010] New: Review Request: python-texttable - Python module to generate a formatted text table, using ASCII characters.
https://bugzilla.redhat.com/show_bug.cgi?id=1123010 Bug ID: 1123010 Summary: Review Request: python-texttable - Python module to generate a formatted text table, using ASCII characters. Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: admil...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://maxamillion.fedorapeople.org/python-texttable.spec SRPM URL: http://maxamillion.fedorapeople.org/python-texttable-0.8.1-1.fc20.src.rpm Description: Python module to generate a formatted text table, using ASCII characters. Fedora Account System Username: maxamillion -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123011] New: Review Request: python-dockerpty - Python library to use the pseudo-tty of a docker container
https://bugzilla.redhat.com/show_bug.cgi?id=1123011 Bug ID: 1123011 Summary: Review Request: python-dockerpty - Python library to use the pseudo-tty of a docker container Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: admil...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://maxamillion.fedorapeople.org/python-dockerpty.spec SRPM URL: http://maxamillion.fedorapeople.org/python-dockerpty-0.2.1-1.fc20.src.rpm Description: Provides the functionality needed to operate the pseudo-tty (PTY) allocated to a docker container, using the Python client. Fedora Account System Username: maxamillion -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122209] Review Request: nodejs-alter - Alters a string
https://bugzilla.redhat.com/show_bug.cgi?id=1122209 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: nodejs-alter Short Description: Alters a string Upstream URL: https://npmjs.org/package/alter Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122241] Review Request: nodejs-stream-to-array - Concatenate a readable stream's data into a single array
https://bugzilla.redhat.com/show_bug.cgi?id=1122241 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: nodejs-stream-to-array Short Description: Concatenate a readable stream's data into a single array Upstream URL: https://npmjs.org/package/stream-to-array Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122223] Review Request: nodejs-ftp - An FTP client module for node.js
https://bugzilla.redhat.com/show_bug.cgi?id=113 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: nodejs-ftp Short Description: An FTP client module for node.js Upstream URL: https://npmjs.org/package/ftp Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122234] Review Request: nodejs-recast - JavaScript syntax tree transformer
https://bugzilla.redhat.com/show_bug.cgi?id=1122234 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: nodejs-recast Short Description: JavaScript syntax tree transformer Upstream URL: https://npmjs.org/package/recast Owners: ralph Branches: f21,f20,f19,epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #7 from Antonio Trande anto.tra...@gmail.com --- (In reply to Christopher Meng from comment #6) 2. Final question here, main pkg has %doc LICENSE.txt README.txt CHANGELOG.txt. And somehow I think it's better to put README and CHANGELOG to the -devel. Why? -devel requires main package... 3. Does it support python3? No, I think. Spec URL: http://sagitter.fedorapeople.org/freesteam/freesteam.spec SRPM URL: http://sagitter.fedorapeople.org/freesteam/freesteam-2.1-3.20140724svn753.fc20.src.rpm - New svn release - Fixed unused-direct-shlib-dependency warnings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117906] Review Request: python-scikit-image - Image processing in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1117906
--- Comment #4 from Eduardo Mayorga e...@mayorgalinux.com ---
Some comments:
- It won't build in EPEL7 either as it doesn't ship Python 3, so you must
conditionalize for that branch too.
- The python3- subpackage's summary and description should explicitly state
it's a Python 3 module. For example:
%package -n python3-%{upname}
Summary: Image processing in Python
should be:
Summary: Image processing in Python 3
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1116028] Review Request: rubygem-elasticsearch-transport - Elasticsearch transport
https://bugzilla.redhat.com/show_bug.cgi?id=1116028 Eduardo Mayorga e...@mayorgalinux.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|e...@mayorgalinux.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113301] Review Request: nova-image-builder - Utility for building OpenStack Glance images inside OpenStack Nova instances
https://bugzilla.redhat.com/show_bug.cgi?id=1113301 --- Comment #1 from Dennis Kliban dkli...@redhat.com --- The spec file has been updated. Here are the new URLs: Spec URL: http://imcleod.fedorapeople.org/src/nova-image-builder/nova-image-builder.spec SRPM URL: http://imcleod.fedorapeople.org/src/nova-image-builder/nova-image-builder-0.0.1-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113301] Review Request: nova-image-builder - Utility for building OpenStack Glance images inside OpenStack Nova instances
https://bugzilla.redhat.com/show_bug.cgi?id=1113301
Ian McLeod imcl...@redhat.com changed:
What|Removed |Added
CC||imcl...@redhat.com
--- Comment #2 from Ian McLeod imcl...@redhat.com ---
This is my review based on the package guidelines and Dennis' SPEC file update:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
[imcleod@localhost SPECS]$ rpmlint nova-image-builder.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[imcleod@localhost SPECS]$
MUST: The package must be named according to the Package Naming Guidelines .
CONFIRMED
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] . CONFIRMED
MUST: The package must meet the Packaging Guidelines . CONFIRMED
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines . CONFIRMED - ASL 2.0
MUST: The License field in the package spec file must match the actual license.
[3] - CONFIRMED - ASL 2.0
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4] - CONFIRMED
MUST: The spec file must be written in American English. [5] CONFIRMED
MUST: The spec file for the package MUST be legible. [6] CONFIRMED
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use sha256sum for this task as it is
used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this. - CONFIRMED
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7] CONFIRMED
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8] N/A - noarch package with all noarch dep
chain
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense. CONFIRMED
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9] N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10] N/A
MUST: Packages must NOT bundle copies of system libraries.[11] CONFIRMED
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. [12] N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. [13] CONFIRMED
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. (Notable exception: license texts in specific situations)[14]
CONFIRMED
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. [15] CONFIRMED
MUST: Each package must consistently use macros. [16] CONFIRMED
MUST: The package must contain code, or permissable content. [17] CONFIRMED
MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). [18] N/A - no significant
doc content
MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. [18] CONFIRMED
MUST: Static libraries must be in a -static package. [19] N/A
MUST: Development files must be in a -devel package. [20] N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21] N/A
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.[19] N/A
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be
[Bug 1117562] Review Request: golang-github-tchap-go-patricia - A generic patricia trie implemented in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1117562 --- Comment #3 from Lokesh Mandvekar l...@fedoraproject.org --- disabling debuginfo... Spec URL: http://lsm5.fedorapeople.org/golang-github-tchap-go-patricia/golang-github-tchap-go-patricia.spec SRPM URL: http://lsm5.fedorapeople.org/golang-github-tchap-go-patricia/SRPMS/golang-github-tchap-go-patricia-1.0.1-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123044] New: Review Request: pyrax - A Rackspace/Openstack client library
https://bugzilla.redhat.com/show_bug.cgi?id=1123044 Bug ID: 1123044 Summary: Review Request: pyrax - A Rackspace/Openstack client library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: imcl...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://imcleod.fedorapeople.org/src/pyrax/pyrax.spec SRPM URL: http://imcleod.fedorapeople.org/src/pyrax/pyrax-1.9.0-1.fc20.src.rpm Description: pyrax is a client library for interacting with Rackspace and other OpenStack based clouds. It includes Rackspace-specific features not found in the generic Openstack clients Fedora Account System Username: imcleod -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal
https://bugzilla.redhat.com/show_bug.cgi?id=1122577
--- Comment #8 from Fabio Alessandro Locati fabioloc...@gmail.com ---
- rpmlint returns:
rpmlint git-xcleaner-1.2-1.fc20.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2 ) OK, text in %doc, matches source
- spec file legible, in American English
- mantainer is upstream developer
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use almost consistent (1)
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
(1):
http://lzap.fedorapeople.org/projects/git-xcleaner/%{name}-%{version}.tar.gz
one time is used git-xcleaner and the other one %{name}. I think it should be
http://lzap.fedorapeople.org/projects/%{name}/%{name}-%{version}.tar.gz
Out of the macro consistency pointed here, I think is all clean :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060906] Review Request: nss_wrapper - A wrapper for the user, group and hosts NSS API
https://bugzilla.redhat.com/show_bug.cgi?id=1060906 Andreas Schneider a...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2014-07-24 13:59:36 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745510] Review Request: vdsm - Virtual Desktop Server Manager
https://bugzilla.redhat.com/show_bug.cgi?id=745510 --- Comment #27 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122209] Review Request: nodejs-alter - Alters a string
https://bugzilla.redhat.com/show_bug.cgi?id=1122209 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122223] Review Request: nodejs-ftp - An FTP client module for node.js
https://bugzilla.redhat.com/show_bug.cgi?id=113 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122223] Review Request: nodejs-ftp - An FTP client module for node.js
https://bugzilla.redhat.com/show_bug.cgi?id=113 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 745510] Review Request: vdsm - Virtual Desktop Server Manager
https://bugzilla.redhat.com/show_bug.cgi?id=745510 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
