[Bug 1238222] Review Request: perl-MIME-Base64 - Encoding and decoding of Base64 and quoted-printable strings

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238222

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Petr Pisar ppi...@redhat.com ---
New Package SCM Request
===
Package Name: perl-MIME-Base64
Short Description: Encoding and decoding of Base64 and quoted-printable strings
Upstream URL: http://search.cpan.org/dist/MIME-Base64/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238237] Review Request: perl-Pod-Escapes - Resolve POD escape sequences

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238237

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Petr Pisar ppi...@redhat.com ---
New Package SCM Request
===
Package Name: perl-Pod-Escapes
Short Description: Resolve POD escape sequences
Upstream URL: http://search.cpan.org/dist/Pod-Escapes/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230867] Review Request: felix-scr - Apache Felix Declarative Services Runtime

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230867



--- Comment #14 from Severin Gehwolf sgehw...@redhat.com ---
(In reply to Mikolaj Izdebski from comment #13)
 Issues:
 1) spec file must be named %{name}.spec, where %{name} is component name,
 in this case felix-scr

I don't understand this one. Isn't this the case? From comment 9 I see this
URL: https://jkang.fedorapeople.org/felix-scr.spec So it's felix-scr.spec.
Then Name:  felix-scr is in that spec. I'm confused...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 909887] Review Request: gnome-connection-manager - A tabbed ssh connection manager for gtk+ environments (Python Application)

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=909887

Mat Booth mat.bo...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2015-07-02 07:06:15



--- Comment #7 from Mat Booth mat.bo...@redhat.com ---
Closing, I am no longer interested in maintaining this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231981] Review Request: python-toml - Python Library for Tom's Obvious, Minimal Language

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1231981



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
python-toml-0.9.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-toml-0.9.0-2.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683790] Review Request: rubygem-hoe-yard - A Hoe plug-in for generating YARD documentation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=683790

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2015-07-02 05:46:43



--- Comment #11 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
Since there seems to be no progress here, I'm closing this bug. Feel free to
reopen if you wish to restart the review.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1165895] Review Request: gosnake - The Console Snake Game

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1165895

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 847777] Review Request: strata-sdk - Python library for Red Hat customer portal's RESTful service interface

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=84

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2015-07-02 05:48:14



--- Comment #8 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
Since there seems to be no progress here, I'm closing this bug. Feel free to
reopen if you wish to restart the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230867] Review Request: felix-scr - Apache Felix Declarative Services Runtime

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230867



--- Comment #16 from Severin Gehwolf sgehw...@redhat.com ---
OK, that makes sense now. Thanks for clarifying. I missed this in the earlier
review. Nice catch!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1234605] Review Request: statscache - A daemon to build and keep fedmsg statistics

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1234605

Ratnadeep Debnath rtn...@gmail.com changed:

   What|Removed |Added

  Flags|needinfo?(rtn...@gmail.com) |needinfo?(rb...@redhat.com)



--- Comment #3 from Ratnadeep Debnath rtn...@gmail.com ---
Hey Ralph,

[!]: Three files/dirs problems I noticed:
 - statscache-common should probably own the directory
   %{python_sitelib}/%{modname}/
 - statscache-web should probably own the directory
   %{_datadir}/%{modname}/
 - Lastly, I don't think %{_sysconfdir}/fedmsg.d/ should be declared in the
   '%files common' section.  The core fedmsg package already owns that
   directory.

Do you think it's a good idea to change the owner for
%{python_sitelib}/%{modname} and for %{_datadir}/%{modname}. rpmlint on the
RPMs throws warnings like:
- non-standard uid
- non-standard gid

for both the lib and data dirs.

What I see here: http://pkgs.fedoraproject.org/cgit/fedmsg.git/tree/fedmsg.spec
is that you have changed owners for log/ and run/ dirs only.
%attr(755, %{modname}, %{modname}) %dir %{_var}/log/%{modname}
%attr(775, %{modname}, %{modname}) %dir %{_var}/run/%{modname}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230867] Review Request: felix-scr - Apache Felix Declarative Services Runtime

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230867



--- Comment #15 from Mikolaj Izdebski mizde...@redhat.com ---
The spec URL is meaningless. What matters is the name of spec file inside srpm,
it is felix-scr-1.6.2.spec, but it should be felix-scr.spec

Reproducer:
curl -s https://jkang.fedorapeople.org/felix-scr-1.6.2-2.fc21.src.rpm |
rpm2cpio | cpio -it | grep spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 782560] Review Request: rubygem-ruby-shadow - *nix Shadow Password Module

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=782560

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2015-07-02 05:47:19



--- Comment #40 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
Since there seems to be no progress here, I'm closing this bug. Feel free to
reopen if you wish to restart the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 787350] Review Request: rubygem-rspec-puppet - RSpec tests for your Puppet manifests

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=787350

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2015-07-02 05:47:34



--- Comment #14 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
Since there seems to be no progress here, I'm closing this bug. Feel free to
reopen if you wish to restart the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 683789] Review Request: rubygem-rubytree - RubyTree is a Ruby implementation of the generic tree data structure

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=683789
Bug 683789 depends on bug 683790, which changed state.

Bug 683790 Summary: Review Request: rubygem-hoe-yard - A Hoe plug-in for 
generating YARD documentation
https://bugzilla.redhat.com/show_bug.cgi?id=683790

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 745993] Review Request: rubygem-useragent - HTTP User Agent parser

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=745993

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX
Last Closed||2015-07-02 05:46:54



--- Comment #4 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
Since there seems to be no progress here, I'm closing this bug. Feel free to
reopen if you wish to restart the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1165895] Review Request: gosnake - The Console Snake Game

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1165895



--- Comment #6 from Fedora Update System upda...@fedoraproject.org ---
gosnake-1.1-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/gosnake-1.1-1.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1186557] Review Request: libticalcs2 - Texas Instruments calculator communication library

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1186557



--- Comment #4 from Antonio Trande anto.tra...@gmail.com ---
- To me, 'make -C docs install DESTDIR=%{buildroot}'
  is redundant; you could manage all documentation by using %doc macro.

- Also, 'make install DESTDIR=%{buildroot}' already installs fr.po  

make[1]: Entering directory '/builddir/build/BUILD/libticalcs2-1.1.8/po'
/usr/bin/mkdir -p
/builddir/build/BUILDROOT/libticalcs2-1.1.8-2.fc23.i386/usr/share
installing fr.gmo as
/builddir/build/BUILDROOT/libticalcs2-1.1.8-2.fc23.i386/usr/share/locale/fr/LC_MESSAGES/libticalcs2.mo

You could patch 'make' and permit that %find_lang script works; you won't
obliged to list explicitely

%lang(fr) %{_datadir}/locale/fr/LC_MESSAGES/libticalcs2.mo

- Why do you use %define instead of %global ?

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/locale/fr/LC_MESSAGES/libticalcs2.mo
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: GPL, LGPL (v2 or later), GPL (v2 or later), Unknown or
 generated. 14 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/1186557-libticalcs2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/libticalcs2
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in 

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #9 from Piotr Popieluch piotr1...@gmail.com ---
Spec URL: https://piotrp.fedorapeople.org/graphite-api.spec
SRPM URL: https://piotrp.fedorapeople.org/graphite-api-1.0.1-3.fc22.src.rpm

notes:
- will need some work to get it working on Python 3
- no el6 support
- this is the last available release + a patch. There are many new commits
since the last release, maybe we should package the git head instead of the
release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231981] Review Request: python-toml - Python Library for Tom's Obvious, Minimal Language

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1231981

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231981] Review Request: python-toml - Python Library for Tom's Obvious, Minimal Language

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1231981



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
python-toml-0.9.0-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-toml-0.9.0-2.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1165895] Review Request: gosnake - The Console Snake Game

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1165895



--- Comment #5 from Fedora Update System upda...@fedoraproject.org ---
gosnake-1.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/gosnake-1.1-1.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236151] Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236151

Pavol Babinčák pbabi...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236151] Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236151



--- Comment #6 from Pavol Babinčák pbabi...@redhat.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236151] Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236151

Jiri Popelka jpope...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238689] New: Review Request: perl-libnet - Perl clients for various network protocols

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238689

Bug ID: 1238689
   Summary: Review Request: perl-libnet - Perl clients for various
network protocols
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ppisar.fedorapeople.org/perl-libnet/perl-libnet.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-libnet/perl-libnet-3.06-1.fc23.src.rpm
Description:
Fedora Account System Username: ppisar
This is a collection of Perl modules which provides a simple and
consistent programming interface (API) to the client side of various
protocols used in the internet community.

This package will dual-live with perl.spec after sub-packaging it there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236151] Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236151



--- Comment #7 from Fedora Update System upda...@fedoraproject.org ---
python-dockerfile-parse-0.0.3-2.fc22 has been submitted as an update for Fedora
22.
https://admin.fedoraproject.org/updates/python-dockerfile-parse-0.0.3-2.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238703] New: Review Request: perl-perlfaq - Frequently asked questions about Perl

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238703

Bug ID: 1238703
   Summary: Review Request: perl-perlfaq - Frequently asked
questions about Perl
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ppisar.fedorapeople.org/perl-perlfaq/perl-perlfaq.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-perlfaq/perl-perlfaq-5.021009-1.fc23.src.rpm
Description:
The perlfaq comprises several documents that answer the most commonly asked
questions about Perl and Perl programming.

Fedora Account System Username: ppisar

This package will dual-live with perl.spec after sub-packaging it there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1218410] Review Request: python-APSscheduler - In-process task scheduler with Cron-like capabilities

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1218410



--- Comment #5 from Tristan Cacqueray tdeca...@redhat.com ---
Oups, only the swift object was miss-named, here are the correct link then:

Spec URL:
https://ca.enocloud.com:8080/v1/AUTH_09317026f6ce4da881c5e0b69bdcff93/fedora-pkg/python-APScheduler.spec
SRPM URL:
https://ca.enocloud.com:8080/v1/AUTH_09317026f6ce4da881c5e0b69bdcff93/fedora-pkg/python-APScheduler-2.1.2-1.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236151] Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236151



--- Comment #8 from Fedora Update System upda...@fedoraproject.org ---
python-dockerfile-parse-0.0.3-2.el6 has been submitted as an update for Fedora
EPEL 6.
https://admin.fedoraproject.org/updates/python-dockerfile-parse-0.0.3-2.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236151] Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236151



--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
python-dockerfile-parse-0.0.3-2.el7 has been submitted as an update for Fedora
EPEL 7.
https://admin.fedoraproject.org/updates/python-dockerfile-parse-0.0.3-2.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236319] Review Request: python-lz4 - LZ4 Bindings for Python

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236319



--- Comment #20 from Fedora Update System upda...@fedoraproject.org ---
python-lz4-0.7.0-3.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-lz4-0.7.0-3.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236319] Review Request: python-lz4 - LZ4 Bindings for Python

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236319



--- Comment #21 from Fedora Update System upda...@fedoraproject.org ---
python-lz4-0.7.0-3.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-lz4-0.7.0-3.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238730] New: Review Request: perl-Unicode-Normalize - Unicode Normalization Forms

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238730

Bug ID: 1238730
   Summary: Review Request: perl-Unicode-Normalize - Unicode
Normalization Forms
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Unicode-Normalize/perl-Unicode-Normalize.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Unicode-Normalize/perl-Unicode-Normalize-1.18-1.fc23.src.rpm
Description:
This package provides Perl functions that can convert strings into various
Unicode normalization forms as defined in Unicode Standard Annex #15.

Fedora Account System Username: ppisar

This package will dual-live with perl.spec after sub-packaging it there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236319] Review Request: python-lz4 - LZ4 Bindings for Python

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236319

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236151] Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236151



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
python-dockerfile-parse-0.0.3-2.fc21 has been submitted as an update for Fedora
21.
https://admin.fedoraproject.org/updates/python-dockerfile-parse-0.0.3-2.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238755] Review Request: gstreamer1-rtsp-server - A GStreamer 1.x based RTSP server

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238755

Wim Taymans wtaym...@redhat.com changed:

   What|Removed |Added

 Blocks||1129638
 CC||m...@stefanringel.de



--- Comment #1 from Wim Taymans wtaym...@redhat.com ---
*** Bug 1129677 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1129638
[Bug 1129638] Update to gnome-dvb-daemon 0.2.90
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219540] Review Request: ahc-tools - Tools for RDO-manager automatic health checks

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1219540

Haïkel Guémar karlthe...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Haïkel Guémar karlthe...@gmail.com ---
The Group is not required, I advise you to drop it when you'll import the
package

I hereby approve it into Fedora Packages Collection, please submit a SCM
request.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: Apache (v2.0), Unknown or generated, *No copyright* Apache
 (v2.0). 1 files have unknown license. Detailed output of licensecheck
 in /home/haikel/1219540-ahc-tools/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all 

[Bug 1238755] New: Review Request: gstreamer1-rtsp-server - A GStreamer 1.x based RTSP server

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238755

Bug ID: 1238755
   Summary: Review Request: gstreamer1-rtsp-server - A GStreamer
1.x based RTSP server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: wtaym...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://people.freedesktop.org/~wtay/SPECS/gstreamer1-rtsp-server.spec
SRPM URL:
http://people.freedesktop.org/~wtay/SRPMS/gstreamer1-rtsp-server-1.4.0-3.fc23.src.rpm
Description: gstreamer rtsp server version 1.x 
Fedora Account System Username: wtaymans

It is needed for gnome-dvb-daemon update to version 0.2.90
There is currently gstreamer-rtsp which is based on the 0.10 GStreamer version.
For the 1.x based version we suggest this new name for consistency with the
other GStreamer packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238755] Review Request: gstreamer1-rtsp-server - A GStreamer 1.x based RTSP server

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238755

Kalev Lember kalevlem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||kalevlem...@gmail.com
   Assignee|nob...@fedoraproject.org|kalevlem...@gmail.com



--- Comment #2 from Kalev Lember kalevlem...@gmail.com ---
Taking for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230874] Review Request: felix-scr-maven-plugin - Maven plugin for generating OSGi Declarative Services annotations

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230874



--- Comment #21 from Jie Kang jk...@redhat.com ---
(In reply to Mikolaj Izdebski from comment #20)
 I agree with either package name - it is up to maintainer to choose.

Okay. I think I will go with felix-scr-maven-plugin.

 Everything looks good, except for one problem - release field does not match
 changelog (release is 1%{?dist}, while changelog says 1.21.0-2)

I have updated the spec file with Release as 2%{?dist}. The spec [1] and srpm
[2] on my fedorapeople space should have the corrections now.

Are there any other concerns to address?


Thanks!

[1] https://jkang.fedorapeople.org/felix-scr-maven-plugin.spec
[2] https://jkang.fedorapeople.org/felix-scr-maven-plugin-1.21.0-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208844] Review Request: inkscape-psd - Inkscape PSD Importer

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208844

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
[x] OK
[-] not applicable

Issues:
===
- Package contains BR: python2-devel or python3-devel

I *think* this not necessary here. Only a file is copied, and not to any python
specific directory.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: BSD (2 clause). Detailed output of licensecheck in /var/tmp
 /review-inkscape-psd/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[-]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep

Rpmlint
---
Checking: inkscape-psd-0.1.1-2.fc23.noarch.rpm
  inkscape-psd-0.1.1-2.fc23.src.rpm
inkscape-psd.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.


Rpmlint (installed packages)

inkscape-psd.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Requires

inkscape-psd (rpmlib, GLIBC filtered):
inkscape
python

Provides

inkscape-psd:
inkscape-psd

Looks good. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129677] Review Request: gstreamer1-rtsp-server - gstreamer rtsp server version 1.x

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1129677

Wim Taymans wtaym...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2015-07-02 10:27:34



--- Comment #21 from Wim Taymans wtaym...@redhat.com ---
Marking as duplicate because of updated spec file.

*** This bug has been marked as a duplicate of bug 1238755 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238760] New: Review Request: perl-Unicode-Collate - Unicode Collation Algorithm

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238760

Bug ID: 1238760
   Summary: Review Request: perl-Unicode-Collate - Unicode
Collation Algorithm
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Unicode-Collate/perl-Unicode-Collate.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Unicode-Collate/perl-Unicode-Collate-1.12-1.fc23.src.rpm
Description:
This package is Perl implementation of Unicode Technical Standard #10 (Unicode
Collation Algorithm).

Fedora Account System Username: ppisar

This package will dual-live with perl.spec after sub-packaging it there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230445] Review Request: officeparser - Parse the format of OLE compound documents used by MS Office applications

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230445



--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Please, rebuild the package after making changes ;)

officeparser.noarch: W: tag-in-description C BuildRequires:
officeparser.noarch: E: wrong-script-interpreter /usr/bin/officeparser.py
%{__python2}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1232580] Review Request: purple-line - libpurple (Pidgin, Finch) protocol plugin for LINE

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1232580

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Parag AN(पराग) panem...@gmail.com ---
Issues:
1) rpmlint on all generated rpms gave output as
purple-line.src: W: spelling-error Summary(en_US) libpurple - lib purple,
lib-purple, purple
purple-line.src: W: summary-not-capitalized C libpurple (Pidgin, Finch)
protocol plugin for LINE
purple-line.src: W: invalid-url Source0: purple-line-20150426git9b7b019.tar.gz
purple-line.x86_64: W: spelling-error Summary(en_US) libpurple - lib purple,
lib-purple, purple
purple-line.x86_64: W: summary-not-capitalized C libpurple (Pidgin, Finch)
protocol plugin for LINE
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

== Fix summary capitalization

2) Group tag is not mandatory now so can be removed

3) License is MIT and not BSD as per LICENSE text

4) CFLAGS are not honored when compilation happens. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

5) Maybe you want to use %license macro as
%license LICENSE
%doc README.md

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1119118] Review Request: perl-App-Netdisco - Web-based network management tool

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1119118
Bug 1119118 depends on bug 1119158, which changed state.

Bug 1119158 Summary: Review Request: perl-URL-Encode - Encoding and decoding of 
application/x-www-form-urlencoded encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1119158

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1119158] Review Request: perl-URL-Encode - Encoding and decoding of application/x-www-form-urlencoded encoding

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1119158

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2015-07-02 11:40:36



--- Comment #6 from Petr Šabata psab...@redhat.com ---
Dead review.  Closing.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238755] Review Request: gstreamer1-rtsp-server - A GStreamer 1.x based RTSP server

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238755



--- Comment #3 from Kalev Lember kalevlem...@gmail.com ---
Here's rpmlint output:

$ rpmlint gstreamer1-rtsp-server-1.4.0-3.fc23.src.rpm \
  gstreamer1-rtsp-server \
  gstreamer1-rtsp-server-devel \
  gstreamer1-rtsp-server-devel-docs \
  gstreamer1-rtsp-server-debuginfo

gstreamer1-rtsp-server.src: W: spelling-error Summary(en_US) GStreamer - G
Streamer, Streamer, Steamer
gstreamer1-rtsp-server.src:98: W: macro-in-%changelog %make_install
gstreamer1-rtsp-server.x86_64: W: spelling-error Summary(en_US) GStreamer - G
Streamer, Streamer, Steamer
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstbase-1.0.so.0
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libgstrtp-1.0.so.0
gstreamer1-rtsp-server.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgstrtspserver-1.0.so.0.400.0 /lib64/libpthread.so.0
gstreamer1-rtsp-server-devel.x86_64: W: only-non-binary-in-usr-lib
gstreamer1-rtsp-server-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 8 warnings.

Most of it is noise, but the W: macro-in-%changelog %make_install issue would
be important to fix. rpm expands macros anywhere, even in the %changelog
section and that means it also expands the %make_install macro, messing up the
changelog section.

Easiest would be to either escape the macro with %% or just remove the % macro
symbol in front of it.


Some other things I noticed while going through the spec file; none of those
are review blockers but might be nice to fix:

 %build
 # Until https://bugzilla.gnome.org/show_bug.cgi?id=634376 is fixed, disable 
 introspection
 %configure  --enable-gtk-doc

I think this comment can go? Introspection seems to be enabled in the build
now.


 find %{buildroot} -name '*.a' -exec rm -f {} ';'

passing --disable-static to %configure would probably be slightly nicer than
building the static library and then deleting it afterwards


 %doc COPYING.LIB README TODO NEWS

COPYING.LIB should be marked %license as per latest guideline updates. Not sure
TODO is useful to package at all?


 %dir %{_libdir}/girepository-%{majorminor}/
 %{_libdir}/girepository-%{majorminor}/GstRtspServer-%{majorminor}.typelib

and

%files devel
%dir %{_datadir}/gir-%{majorminor}/
%{_datadir}/gir-%{majorminor}/GstRtspServer-%{majorminor}.gir

The girepository-1.0 and gir-1.0 directory versions are the gobject
introspection version and using the rtsp-server's majorminor here is probably
wrong. I'd just write 1.0 instead of using the macro.


 %files devel-docs
 %doc %{_datadir}/gtk-doc/html/gst-rtsp-server-%{majorminor}

Should include the %{_datadir}/gtk-doc/ and %{_datadir}/gtk-doc/html/
directories in the package as well to avoid leaving unowned directories behind
on uninstall.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #10 from James Turnbull ja...@lovedthanlost.net ---
Agreed on HEAD. I've been discussing upstream doing a new release soon
hopefully. It's unclear to me what's needed for Python 3 support.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1235364] Review Request: python-mysql - Python interface to MySQL

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1235364

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 CC||nob...@fedoraproject.org



--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
*** Bug 226179 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1235364] Review Request: python-mysql - Python interface to MySQL

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1235364

Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Since this is a rename review request, I'm mostly looking at the relevant
parts:
+ obsoletes/provides look correct
+ new names is OK according to python guidelines
+ license matches
- license is not installed: please use %license for the license file
[https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text]

Questions:
Can the text about compatibility with older interface written by J. Skinner
be removed? It was probably useful in 2001, but maybe nobody remembers the
older interface now.

Since the same documentation files are installed for both subpackages, I'd
suggest adding %global _docdir_fmt %{name} to avoid duplication.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208844] Review Request: inkscape-psd - Inkscape PSD Importer

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208844

Mosaab Alzoubi moc...@hotmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Mosaab Alzoubi moc...@hotmail.com ---
Thank you ..

New Package SCM Request
===
Package Name: inkscape-psd
Short Description: Inkscape PSD Importer
Owners: moceap
Branches: f21 f22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233985] Review Request: gap-pkg-nq - Nilpotent Quotients of finitely presented groups

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233985



--- Comment #5 from Fedora Update System upda...@fedoraproject.org ---
gap-pkg-nq-2.5.1-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/gap-pkg-nq-2.5.1-1.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233985] Review Request: gap-pkg-nq - Nilpotent Quotients of finitely presented groups

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233985

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 478722] Review Request: ossim - Open Source Software Image Map

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=478722

Rashad M rashad.kanav...@c-s.fr changed:

   What|Removed |Added

 CC||rashad.kanav...@c-s.fr



--- Comment #6 from Rashad M rashad.kanav...@c-s.fr ---
Is it possible to resubmit a new spec for OSSIM? or shall I open a new request?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #11 from Piotr Popieluch piotr1...@gmail.com ---
HEAD appears to depend on Flask-Cache which is not in Fedora yet, tests fail
now. Will try to package Flask-Cache tomorrow. 

I haven't looked into Python 3 yet, I expect some issues with dependencies
which are still missing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1237281] Review Request: bashithacomplex-fonts - Sinhala fonts

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1237281



--- Comment #1 from Parag AN(पराग) panem...@gmail.com ---
Review:
+ Package built fine for F23 x86_64

+ rpmlint on all generated rpms gave output
bashithacomplex-fonts.noarch: W: spelling-error Summary(en_US) Bashitha -
Bashing
bashithacomplex-fonts.noarch: W: no-documentation
bashithacomplex-fonts.src: W: spelling-error Summary(en_US) Bashitha - Bashing
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
Source in srpm:8460b239ee8fd0d92fcb2762b411d2560ba91b45958d49a24b1ee5a052d47008
Upstream
source:8460b239ee8fd0d92fcb2762b411d2560ba91b45958d49a24b1ee5a052d47008

+ follows fonts packaging guidelines

Suggestions:
1) Correct the release tag as
Release:0.1.%{checkout}%{?dist}

2) You should also add metainfo file, see sample at
http://pkgs.fedoraproject.org/cgit/lklug-fonts.git/tree/

and also do changes in spec file to install this bashithacomplex.metainfo.xml
file

3) Note following lines are optional now in Fedora packages
rm -fr %{buildroot}
and
%clean
rm -fr %{buildroot}

4) Ask upstream to provide license somewhere on their website which we can
download and add to this package. License is not clear just by downloading ttf
file. Also, on upstream website they used word BhashitaScreen and it is not
related to the font file we are packaging so not sure what license is for this
BhashitaComplex font.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023690] Review Request: rspamd - Fast, free and open-source spam filtering system

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023690



--- Comment #2 from Christopher Meng i...@cicku.me ---
I will update all my reviews in the next week and continue the packaging work.

My site isn't down, I will fix them soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233986] Review Request: gap-pkg-carat - GAP interface to CARAT

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233986



--- Comment #2 from Jerry James loganje...@gmail.com ---
(In reply to Gerald Cox from comment #1)
 I noticed the use of the Suggests Tag, which from what I gather has been
 available for some time now but as far as I can tell isn't widely discussed.
 I did find this:
 
 http://www.rpm.org/wiki/PackagerDocs/Dependencies#Weakdependencies
 
 I didn't find it discussed anywhere in the Fedora documentation.  Did I miss
 something?
 
 If not, I'll consider taking it up with the FPC just for the reason that I
 think at times some reviewers become a bit pedantic and flip out when they
 encounter something which isn't specifically mentioned.

There has been some discussion, for example:

https://lists.fedoraproject.org/pipermail/devel/2014-October/203208.html
https://lists.fedoraproject.org/pipermail/devel/2014-November/204113.html
https://lists.fedoraproject.org/pipermail/packaging/2015-January/010417.html

And a packaging draft (not final and not approved):

https://fedoraproject.org/wiki/PackagingDrafts/WeakDependencies

Nothing about weak dependencies has been finalized for Fedora, as far as I
know.  If it makes you uncomfortable, I can take that out of the package until
something gets finalized.  But I think that having some examples of weak
dependencies in Fedora is valuable for gaining experience with them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233986] Review Request: gap-pkg-carat - GAP interface to CARAT

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233986

Jerry James loganje...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #3 from Jerry James loganje...@gmail.com ---
New Package SCM Request
===
Package Name: gap-pkg-carat
Short Description: GAP interface to CARAT
Upstream URL: https://www.math.uni-bielefeld.de/~gaehler/gap45/packages.php
Owners: jjames
Branches: f22
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1237281] Review Request: bashithacomplex-fonts - Sinhala fonts

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1237281

Danishka Navin danis...@gmail.com changed:

   What|Removed |Added

 CC||harsh...@redhat.com



--- Comment #2 from Danishka Navin danis...@gmail.com ---
Spec URL:
https://snavin.fedorapeople.org/packages/bashithacomplex-fonts/bashithacomplex-fonts.spec

SRPM URL:
https://snavin.fedorapeople.org/packages/bashithacomplex-fonts/bashithacomplex-fonts-1.000-0.2.20150628.fc21.src.rpm

Fixed succession 1 and 2.


I already contacted upstream to provide license file, before start packaging. I
hope they will provide it soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #12 from James Turnbull ja...@lovedthanlost.net ---
Quickly testing on CentOS Linux release 7.1.1503 (Core) I had to pip upgrade
urllib3, six, pyparsing, and websocket to get it to work. Not being overly
Python savvy or how Python libraries are packaged on RH/Fedora/CentOS - I am
not sure how helpful that is.

$ pip list
backports.ssl-match-hostname (3.4.0.2)
boto (2.38.0)
cairocffi (0.7.1)
carbon (0.9.12)
cffi (1.1.2)
chardet (2.0.1)
Cheetah (2.4.4)
cloud-init (0.7.5)
configobj (4.7.2)
decorator (3.4.0)
Django (1.6.11)
django-tagging (0.3.1)
Flask (0.10.1)
gevent (1.0.2)
graphite-api (1.0.1)
graphite-web (0.9.12)
greenlet (0.4.7)
gunicorn (19.3.0)
iniparse (0.4)
IPy (0.75)
itsdangerous (0.24)
Jinja2 (2.7.3)
jsonpatch (1.2)
jsonpointer (1.0)
Markdown (2.4.1)
MarkupSafe (0.23)
Pillow (2.0.0)
pip (1.5.6)
policycoreutils-default-encoding (0.1)
prettytable (0.7.2)
psycopg2 (2.5.1)
pycparser (2.14)
pycurl (7.19.0)
Pygments (1.4)
pygobject (3.8.2)
pygpgme (0.3)
pyliblzma (0.5.3)
pyOpenSSL (0.13.1)
pyparsing (2.0.3)
pyserial (2.6)
pytz (2012d)
pyudev (0.15)
pyxattr (0.5.1)
PyYAML (3.10)
requests (1.1.0)
rsa (3.1.1)
seobject (0.1)
sepolicy (1.1)
setuptools (0.9.8)
simplejson (3.3.3)
six (1.9.0)
slip (0.4.0)
slip.dbus (0.4.0)
structlog (15.2.0)
Twisted-Core (12.2.0)
urlgrabber (3.10)
urllib3 (1.10.4)
websocket (0.2.1)
Werkzeug (0.10.4)
whisper (0.9.12)
wsgiref (0.1.2)
yum-metadata-parser (1.1.4)
zope.interface (4.0.5)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233986] Review Request: gap-pkg-carat - GAP interface to CARAT

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233986



--- Comment #4 from Gerald Cox gb...@bzb.us ---
(In reply to Jerry James from comment #2)
 
 Nothing about weak dependencies has been finalized for Fedora, as far as I
 know.  If it makes you uncomfortable, I can take that out of the package
 until something gets finalized.  But I think that having some examples of
 weak dependencies in Fedora is valuable for gaining experience with them.

No, it doesn't make me uncomfortable at all; and I agree the information would
be valuable.  Regardless uncomfortable isn't a justification to block.  I was
just curious.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208844] Review Request: inkscape-psd - Inkscape PSD Importer

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208844



--- Comment #7 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208844] Review Request: inkscape-psd - Inkscape PSD Importer

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208844

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1220491] Review Request: elastic-curator - Tools for managing Elasticsearch indices

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1220491

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1232580] Review Request: purple-line - libpurple (Pidgin, Finch) protocol plugin for LINE

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1232580



--- Comment #2 from fujiwara tfuji...@redhat.com ---
Updated the spec file:
Spec URL: https://fujiwara.fedorapeople.org/purple-line/purple-line.spec
SRPM URL:
https://fujiwara.fedorapeople.org/purple-line/purple-line-20150426git9b7b019-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233986] Review Request: gap-pkg-carat - GAP interface to CARAT

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233986

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1220491] Review Request: elastic-curator - Tools for managing Elasticsearch indices

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1220491



--- Comment #6 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233986] Review Request: gap-pkg-carat - GAP interface to CARAT

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233986



--- Comment #5 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1220491] Review Request: elastic-curator - Tools for managing Elasticsearch indices

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1220491



--- Comment #3 from Piotr Popieluch piotr1...@gmail.com ---
- Update to 3.2.0
- Rewrite description
- Remove mkdir in %%install
- Add missing BuildRequires


Spec URL: https://piotrp.fedorapeople.org/elastic-curator.spec
SRPM URL: https://fedorapeople.org/~piotrp/elastic-curator-3.2.0-1.fc22.src.rpm

python3-nose-xcover is needed for running the tests while building for Python
3. I've requested python3 module/commit acl in bug 1238822

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1225231] Review Request: light-locker-settings - Just a simple settings dialog for light-locker

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1225231

Yajo yajo@gmail.com changed:

   What|Removed |Added

 CC||yajo@gmail.com



--- Comment #3 from Yajo yajo@gmail.com ---
This is an unofficial review.

At a first glance, I see the following errors:

 License:GPLv3+
Reading the source and the project URL, it's only GPLv3.

 %setup -q
You might prefer %autosetup unless you target EPEL7. See
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#.25autosetup

 BuildRequires: python3

Should be python3-devel. See
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires

 # configure macro does not work

IMHO A little explanation would prevent future developers to lose time
wondering why.

 * Tue May 26 2015 Raphael Groner projects...@smart.ms
 -

Please fill this, also with the version stuff.

You might want to see the rpmlint errors too:

Checking: light-locker-settings-1.5.0-1.fc21.x86_64.rpm
  light-locker-settings-1.5.0-1.fc21.src.rpm
light-locker-settings.x86_64: W: spelling-error %description -l en_US
screensaver - screen saver, screen-saver, screens aver
light-locker-settings.x86_64: W: no-version-in-last-changelog
light-locker-settings.x86_64: E: no-binary
light-locker-settings.x86_64: E: script-without-shebang
/usr/share/light-locker-settings/light-locker-settings/light-locker-settings.glade
light-locker-settings.x86_64: W: dangling-symlink
/usr/share/light-locker-settings/locale /usr/share/locale
light-locker-settings.x86_64: W: spurious-executable-perm
/usr/share/doc/light-locker-settings/COPYING
light-locker-settings.x86_64: W: spurious-executable-perm
/usr/share/doc/light-locker-settings/INSTALL
light-locker-settings.x86_64: W: no-manual-page-for-binary
light-locker-settings
light-locker-settings.x86_64: W: install-file-in-docs
/usr/share/doc/light-locker-settings/INSTALL
light-locker-settings.src: W: spelling-error %description -l en_US screensaver
- screen saver, screen-saver, screens aver
light-locker-settings.src: W: no-version-in-last-changelog
light-locker-settings.src:36: W: configure-without-libdir-spec
2 packages and 0 specfiles checked; 2 errors, 10 warnings.

Also, you might want to create appdata files, or at least notify upstream a bug
about it. See
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#AppData_files

That's it for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015868] Review Request: python-qutepart - Source code text editor component based on Qt

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015868



--- Comment #27 from Yajo yajo@gmail.com ---
Informal review here: https://bugzilla.redhat.com/show_bug.cgi?id=1225231#c3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1237281] Review Request: bashithacomplex-fonts - Sinhala fonts

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1237281

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219540] Review Request: ahc-tools - Tools for RDO-manager automatic health checks

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1219540

John Trowbridge jtrow...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #7 from John Trowbridge jtrow...@redhat.com ---
New Package SCM Request
===
Package Name: ahc-tools
Short Description:  Reporting and matching tools for RDO-manager automatic
health checks
Upstream URL: https://github.com/rdo-management/ahc-tools
Owners: trown divius
Branches: f21 f22 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238229] Review Request: perl-PerlIO-via-QuotedPrint - PerlIO layer for quoted-printable strings

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238229



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238229] Review Request: perl-PerlIO-via-QuotedPrint - PerlIO layer for quoted-printable strings

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238229

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219540] Review Request: ahc-tools - Tools for RDO-manager automatic health checks

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1219540

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 496166] Review Request: sakura - Terminal emulator based on GTK and VTE

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=496166



--- Comment #16 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 496166] Review Request: sakura - Terminal emulator based on GTK and VTE

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=496166

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219540] Review Request: ahc-tools - Tools for RDO-manager automatic health checks

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1219540



--- Comment #8 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219540] Review Request: ahc-tools - Tools for RDO-manager automatic health checks

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1219540

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221540] Review Request: nodejs-write-file-atomic - Write files in an atomic fashion w/configurable ownership

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221540



--- Comment #11 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221540] Review Request: nodejs-write-file-atomic - Write files in an atomic fashion w/configurable ownership

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221540

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230149] Review Request: zathura-pdf-mupdf - PDF support for zathura via mupdf

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230149

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230149] Review Request: zathura-pdf-mupdf - PDF support for zathura via mupdf

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230149



--- Comment #9 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1237071] Review Request: perl-Archive-Any-Create - Abstract API to create archives (tar.gz and zip)

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1237071

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231943] Review Request: python-proliantutils - Client Library for interfacing with various devices in HP Proliant Servers

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1231943



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1236225] Review Request: jenkins-openid-plugin - Jenkins OpenID Plugin

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1236225



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1237019] Review Request: perl-Proc-Terminator - Conveniently terminate processes

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1237019



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1237071] Review Request: perl-Archive-Any-Create - Abstract API to create archives (tar.gz and zip)

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1237071



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1237019] Review Request: perl-Proc-Terminator - Conveniently terminate processes

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1237019

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238237] Review Request: perl-Pod-Escapes - Resolve POD escape sequences

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238237

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1238237] Review Request: perl-Pod-Escapes - Resolve POD escape sequences

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1238237



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1077030] Review Request: python-semantic-version - library implementing SemVer

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1077030



--- Comment #11 from Michael Hrivnak mhriv...@redhat.com ---
Success! In addition to the below, it builds successfully on el7 and el6.

spec: https://mhrivnak.fedorapeople.org/python-semantic-version.spec
SRPM:
https://mhrivnak.fedorapeople.org/python-semantic-version-2.4.2-1.fc22.src.rpm

Scratch builds:
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10272528
f22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10272548
f21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10272737

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233985] Review Request: gap-pkg-nq - Nilpotent Quotients of finitely presented groups

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233985

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230274] Review Request: mpssh - Parallel ssh tool

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230274



--- Comment #8 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230274] Review Request: mpssh - Parallel ssh tool

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1230274

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231943] Review Request: python-proliantutils - Client Library for interfacing with various devices in HP Proliant Servers

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1231943

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233985] Review Request: gap-pkg-nq - Nilpotent Quotients of finitely presented groups

2015-07-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233985



--- Comment #4 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >