[Bug 1189385] Review Request: nodejs-line-reader - Asynchronous line-by-line file reader
https://bugzilla.redhat.com/show_bug.cgi?id=1189385 --- Comment #6 from Piotr Popieluch piotr1...@gmail.com --- I need this package as dependency for another pacakge. No response was given from the submitter for more than a month. This review seems stalled. If no response is given within one week I will close this bug and submit a review-request in my name (for which you can co-maintain if you like). https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews PS. tests should be run with mocha, you should change the test section from: node test/line_reader.js to: moch test/line_reader.js add: BR npm(mocha) and enable tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241423] Review Request: nodejs-esprima-fb - Facebook-specific fork of the esprima project
https://bugzilla.redhat.com/show_bug.cgi?id=1241423
Piotr Popieluch piotr1...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flags|fedora-review- |fedora-review+
--- Comment #7 from Piotr Popieluch piotr1...@gmail.com ---
Ok, looks good, APPROVED.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: BSD (2 clause), Unknown or generated. 1 files have unknown
license. Detailed output of licensecheck in
/home/piotr/rpmbuild/1241423-nodejs-esprima-fb/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all
[Bug 1243782] Review Request: nodejs-process-nextick-args - The process.nextTick() but always with args
https://bugzilla.redhat.com/show_bug.cgi?id=1243782 Parag pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Parag pnem...@redhat.com --- Thank you Zuzana for this package review. New Package SCM Request === Package Name: nodejs-process-nextick-args Short Description: The process.nextTick() but always with args Upstream URL: https://github.com/calvinmetcalf/process-nextick-args Owners: pnemade Branches: f21 f22 f23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241423] Review Request: nodejs-esprima-fb - Facebook-specific fork of the esprima project
https://bugzilla.redhat.com/show_bug.cgi?id=1241423 Parag pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Parag pnem...@redhat.com --- Thank you for this package review. New Package SCM Request === Package Name: nodejs-esprima-fb Short Description: Facebook-specific fork of the esprima project Upstream URL: https://github.com/facebook/esprima Owners: pnemade Branches: f21 f22 f23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244655] New: Review Request: async - StumbleUpon's Async Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244655 Bug ID: 1244655 Summary: Review Request: async - StumbleUpon's Async Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://gil.fedorapeople.org/async.spec SRPM URL: https://gil.fedorapeople.org/async-1.4.1-1.fc22.src.rpm Description: This Java library provides some useful building blocks to build high-performance multi-threaded asynchronous applications in Java. Its implementation was inspired by Twisted's asynchronous library (twisted.internet.defer). Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10408076 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244655] Review Request: async - StumbleUpon's Async Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244655 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244657] New: Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 Bug ID: 1244657 Summary: Review Request: asynchbase - An alternative HBase client library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://gil.fedorapeople.org/asynchbase.spec SRPM URL: https://gil.fedorapeople.org/asynchbase-1.6.0-1.fc22.src.rpm Description: An alternative HBase client library for applications requiring fully asynchronous, non-blocking and thread-safe HBase connectivity. Fedora Account System Username: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244678] New: Review Request: duperemove - Tools for deduping file systems
https://bugzilla.redhat.com/show_bug.cgi?id=1244678 Bug ID: 1244678 Summary: Review Request: duperemove - Tools for deduping file systems Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: frap...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://about.frafra.eu/duperemove.spec SRPM URL: https://about.frafra.eu/duperemove-0.09.5-1.fc22.src.rpm Description: Duperemove is a simple tool for finding duplicated extents and submitting them for deduplication Fedora Account System Username: frafra -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244509] Review Request: perl-DBIx-Class-Schema-Diff - Identify differences between two DBIx::Class schemas
https://bugzilla.redhat.com/show_bug.cgi?id=1244509 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244102] Review Request: php-composer-spdx-licenses - SPDX licenses list and validation library
https://bugzilla.redhat.com/show_bug.cgi?id=1244102
--- Comment #5 from Marcin Haba marcin.h...@bacula.pl ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file CHANGELOG.md is marked as %doc instead of %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: Unknown or generated. 4 files have unknown license. Detailed
output of licensecheck in /home/gani/1244102-php-composer-spdx-
licenses/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/php/Composer(composer)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[ ]: Each %files section contains %defattr if rpm 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: Buildroot is not present
Note: Buildroot: present but not needed
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright
[Bug 1244658] New: Review Request: dgit - Integration between git and Debian-style archives
https://bugzilla.redhat.com/show_bug.cgi?id=1244658 Bug ID: 1244658 Summary: Review Request: dgit - Integration between git and Debian-style archives Product: Fedora Version: 22 Component: Package Review Assignee: nob...@fedoraproject.org Reporter: lkund...@v3.sk QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org SPEC: http://v3.sk/~lkundrak/SPECS/dgit.spec SRPM: http://v3.sk/~lkundrak/SRPMS/dgit-1.0-1.fc22.src.rpm Description: dgit (with the associated infrastructure) makes it possible to treat the Debian archive as a git repository: dgit push constructs uploads from git commits dgit clone and dgit fetch construct git commits from uploads. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244353] Review Request: ossim - Open Source Software Image Map
https://bugzilla.redhat.com/show_bug.cgi?id=1244353 --- Comment #2 from Rashad M rashad.kanav...@c-s.fr --- Thanks for your review. Here is the spec file hosted on our git https://git.orfeo-toolbox.org/otb-devutils.git/blob/HEAD:/Packaging/fedora/SPECS/ossim.spec I had updated spec as per your suggestions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244102] Review Request: php-composer-spdx-licenses - SPDX licenses list and validation library
https://bugzilla.redhat.com/show_bug.cgi?id=1244102 --- Comment #7 from Marcin Haba marcin.h...@bacula.pl --- Thanks for this notice. It is comment generated automatically by fedora-review tool. I have no idea about it either why this comment occured. I pasted it as part of entire generated form. I will try to look on this issue deeper. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157298] Review Request: 'javax.resource' package
https://bugzilla.redhat.com/show_bug.cgi?id=1157298
gil cattaneo punto...@libero.it changed:
What|Removed |Added
CC||punto...@libero.it
--- Comment #1 from gil cattaneo punto...@libero.it ---
hi
this package already exist in fedora:
http://pkgs.fedoraproject.org/cgit/jboss-transaction-1.1-api.git/
http://pkgs.fedoraproject.org/cgit/jboss-transaction-1.2-api.git/
then should be explained how produce the source archive (as comment in the spec
file)
after you must remove rm -rf %{buildroot} install section
the jar file must be unversioning
you must remove %clean section and %defattr(-,root,root)
in %files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244655] Review Request: async - StumbleUpon's Async Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244655 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1244657 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1244657 [Bug 1244657] Review Request: asynchbase - An alternative HBase client library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244657] Review Request: asynchbase - An alternative HBase client library
https://bugzilla.redhat.com/show_bug.cgi?id=1244657 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||1244655 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1244655 [Bug 1244655] Review Request: async - StumbleUpon's Async Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244102] Review Request: php-composer-spdx-licenses - SPDX licenses list and validation library
https://bugzilla.redhat.com/show_bug.cgi?id=1244102 --- Comment #6 from Remi Collet fed...@famillecollet.com --- (In reply to Marcin Haba from comment #5) Issues: === - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file CHANGELOG.md is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text I don't understand this comment. %license LICENSE %doc *.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095404] Review Request: opendial - Toolkit for building dialog systems
https://bugzilla.redhat.com/show_bug.cgi?id=1095404 gil cattaneo punto...@libero.it changed: What|Removed |Added CC||punto...@libero.it --- Comment #6 from gil cattaneo punto...@libero.it --- hi URL and Source0 field should be changed in: URL:http://www.opendial-toolkit.net/ Source0:https://github.com/plison/opendial/archive/version-0.95.tar.gz available newer release: 1.4 (consider upgrading) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244509] Review Request: perl-DBIx-Class-Schema-Diff - Identify differences between two DBIx::Class schemas
https://bugzilla.redhat.com/show_bug.cgi?id=1244509 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova jples...@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-DBIx-Class-Schema-Diff-1.03-1.fc24.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Array::Diff) 1 perl(DBIx::Class::Schema::Diff::Filter) 1 perl(DBIx::Class::Schema::Diff::InfoPacket) 1 perl(DBIx::Class::Schema::Diff::Schema) 1 perl(DBIx::Class::Schema::Diff::SchemaData) 1 perl(DBIx::Class::Schema::Diff::Source) 1 perl(Data::Dumper::Concise) 1 perl(Hash::Layout) 1 perl(JSON) 1 perl(List::MoreUtils) 1 perl(List::Util) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Moo::Role) 1 perl(Path::Class) 1 perl(Scalar::Util) 1 perl(Try::Tiny) 1 perl(Types::Standard) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-DBIx-Class-Schema-Diff-1.03-1.fc24.noarch.rpm | sort | uniq -c 1 perl(DBIx::Class::Schema::Diff) = 1.03 1 perl(DBIx::Class::Schema::Diff::Filter) 1 perl(DBIx::Class::Schema::Diff::InfoPacket) 1 perl(DBIx::Class::Schema::Diff::Role::Common) 1 perl(DBIx::Class::Schema::Diff::Schema) 1 perl(DBIx::Class::Schema::Diff::SchemaData) 1 perl(DBIx::Class::Schema::Diff::Source) 1 perl-DBIx-Class-Schema-Diff = 1.03-1.fc24 Binary provides are Ok. $ rpmlint ./perl-DBIx-Class-Schema-Diff* perl-DBIx-Class-Schema-Diff.src: W: spelling-error Summary(en_US) schemas - schema, sachems, schemes perl-DBIx-Class-Schema-Diff.noarch: W: spelling-error Summary(en_US) schemas - schema, sachems, schemes 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Rpmlint is ok TODO: Please add build-require 'make' Otherwise package is good. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244658] Review Request: dgit - Integration between git and Debian-style archives
https://bugzilla.redhat.com/show_bug.cgi?id=1244658 Christopher Meng i...@cicku.me changed: What|Removed |Added CC||i...@cicku.me --- Comment #1 from Christopher Meng i...@cicku.me --- Just a side note, I tried to package dput and then found it's no longer developed anymore. See Bug 987738. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031466] Review Request: jamm - Java Agent for Memory Measurements
https://bugzilla.redhat.com/show_bug.cgi?id=1031466 --- Comment #1 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/jamm.spec SRPM URL: http://gil.fedorapeople.org/jamm-0.2.5-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205479] Review Request: python-morris - An announcement (signal/event) system for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1205479 Zygmunt Krynicki m...@zygoon.pl changed: What|Removed |Added Flags|needinfo?(m...@zygoon.pl) | --- Comment #3 from Zygmunt Krynicki m...@zygoon.pl --- Ah, I'm sorry, the host was down. I've restarted it. Please try again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205872] Review Request: python-padme - Mostly transparent proxy class for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1205872 Zygmunt Krynicki m...@zygoon.pl changed: What|Removed |Added Flags|needinfo?(m...@zygoon.pl) | --- Comment #3 from Zygmunt Krynicki m...@zygoon.pl --- Ah, I'm sorry, the host was down. I've restarted it. Please try again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244102] Review Request: php-composer-spdx-licenses - SPDX licenses list and validation library
https://bugzilla.redhat.com/show_bug.cgi?id=1244102 --- Comment #8 from Marcin Haba marcin.h...@bacula.pl --- Hello, It looks that the source of this issue is here: /usr/lib/python2.7/site-packages/FedoraReview/plugins/generic.py Here is grabbing all potential licenses files: for potentialfile in ['COPYING', 'LICEN', 'copying', 'licen']: pattern = '*' + potentialfile + '*' [if 'COPYING', 'LICEN', 'copying' or 'licen' found in paths from rpm content then add the file to licenses list (licenses variable) and next the license files are checked if exists in docs files list: for _license in licenses: if _license in docs: [test fail due to found license file is in docs The problem here is in line 791 generic.py: pattern = '*' + potentialfile + '*' and in consequence in 793 generic.py: licenses = filter(lambda l: not self.rpms.find(l + '/*'), licenses)file because pattern here is find(l + '/*') Your package name contains in name keyword licenses - php-composer-spdx-licenses and from this reason it finish with test fail. I will propose to fedora-review author change the patterm from: pattern = '*' + potentialfile + '*' to: pattern = '*/' + potentialfile + '*' Then this test case be search on files only, not paths. I checked this change with your package and fedora-review. It works for me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234664] Review Request: jchart2d - Real-time charting library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1234664 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||1244709 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1244709 [Bug 1244709] Add maven pom -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128339] Review Request: nsgenbind - Generate javascript to dom bindings from w3c webidl files
https://bugzilla.redhat.com/show_bug.cgi?id=1128339 gil cattaneo punto...@libero.it changed: What|Removed |Added CC||punto...@libero.it --- Comment #1 from gil cattaneo punto...@libero.it --- Spec and source rpm are no more available to the specified URLs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 571816] Review Request: clamav-unofficial-sigs - Scripts to download unoffical clamav signatures
https://bugzilla.redhat.com/show_bug.cgi?id=571816 Andrew Colin Kissa and...@topdog.za.net changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #23 from Andrew Colin Kissa and...@topdog.za.net --- Package Change Request == Package Name: clamav-unofficial-sigs New Branches: epel7 Owners: topdog ondrejj -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.
https://bugzilla.redhat.com/show_bug.cgi?id=1241919 --- Comment #20 from Jackson Isaac jacksonisaac2...@gmail.com --- Added Fixes as mentioned by Michael in Comment #19. Updated to release v3. Spec URL: https://jacksonisaac.fedorapeople.org/packaging/python-line_profiler/release-v3/python-line_profiler.spec SRPM URL: https://jacksonisaac.fedorapeople.org/packaging/python-line_profiler/release-v3/python-line_profiler-1.0-3.fc22.src.rpm Used http://pkgs.fedoraproject.org/cgit/python-fastcache.git/plain/python-fastcache.spec as reference. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] New: Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Bug ID: 1244760 Summary: Review Request: rubygem-six - Very simple authorization gem Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: ilya.grad...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://repo.clanwars.org/gitlab/rubygem-six.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-six-0.2.0-1.fc24.src.rpm Description: Very simple authorization gem. Fedora Account System Username:ilgrad, ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244764] Review Request: rubygem-diffy - Convenient diffing in ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1244764 Ilya Gradina ilya.grad...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244764] New: Review Request: rubygem-diffy - Convenient diffing in ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1244764 Bug ID: 1244764 Summary: Review Request: rubygem-diffy - Convenient diffing in ruby Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: ilya.grad...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://repo.clanwars.org/gitlab/rubygem-diffy.spec SRPM URL: http://repo.clanwars.org/gitlab/rubygem-diffy-3.0.7-1.fc24.src.rpm Description: Convenient diffing in ruby Fedora Account System Username: ilgrad, ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205872] Review Request: python-padme - Mostly transparent proxy class for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1205872 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205479] Review Request: python-morris - An announcement (signal/event) system for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1205479 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #4 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl --- Fedora Account System (FAS) tells you're not in the packager group yet. You need to go through the sponsor process, see https://fedoraproject.org/wiki/Package_Review_Process#Contributor . Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1182358] New package request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1182358 errata-xmlrpc errata-xml...@redhat.com changed: What|Removed |Added Status|VERIFIED|RELEASE_PENDING -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234210] Review Request: pdf-stapler - tool for manipulating PDF documents from the command line
https://bugzilla.redhat.com/show_bug.cgi?id=1234210 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|zbys...@in.waw.pl |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Ilya Gradina ilya.grad...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244797] Review Request: libASL - Advanced Simulation Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244797 --- Comment #2 from Christian Dersch lupi...@mailbox.org --- Spec URL: https://lupinix.fedorapeople.org/review/libASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/libASL-0.1.4-0.1.fc22.src.rpm Package will be named libASL to be conform with Naming Guidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244817] New: Review Request: python-xvfbwrapper - run headless display inside X virtual framebuffer (Xvfb)
https://bugzilla.redhat.com/show_bug.cgi?id=1244817 Bug ID: 1244817 Summary: Review Request: python-xvfbwrapper - run headless display inside X virtual framebuffer (Xvfb) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mru...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://www.matthias-runge.de/fedora/python-xvfbwrapper.spec SRPM URL: http://www.matthias-runge.de/fedora/python-xvfbwrapper-0.2.4-1.fc22.src.rpm Description: Python wrapper for running a display inside X virtual framebuffer (Xvfb) Fedora Account System Username: mrunge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244797] New: Review Request: ASL - Advanced Simulation Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244797 Bug ID: 1244797 Summary: Review Request: ASL - Advanced Simulation Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: lupi...@mailbox.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://lupinix.fedorapeople.org/review/ASL.spec SRPM URL: https://lupinix.fedorapeople.org/review/ASL-0.1.4-0.1.fc22.src.rpm Description: Advanced Simulation Library is a free and open source multiphysics simulation software package and a tool for solving Partial Differential Equations. It has significant user base across many areas of engineering and science, from both industrial and academic organizations. ASL utilizes only the methods that allow efficient parallelization: Lattice Boltzmann Methods, Explicit Finite Difference, Matrix Free Finite Elements, etc. and exploits all available hardware resources, such as SIMD, local cache, etc.. Once written, an ASL-based application can be deployed on a variety of architectures, such as CPU, GPU, FPGA, DSP, clusters and supercomputers, sometimes even without recompilation. ASL has an extensive range of features to solve anything from complex fluid flows involving chemical reactions, turbulence and heat transfer, to solid mechanics and elasticity. Fedora Account System Username: lupinix Koji builds: Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411683 F23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411726 F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411778 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10411803 Thanks for review in advance! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244797] Review Request: ASL - Advanced Simulation Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244797 --- Comment #1 from Christian Dersch lupi...@mailbox.org --- Please wait, after running fedora-review, I recognized that a package ASL doesn't exist right now, but a package called asl = have to check -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244797] Review Request: libASL - Advanced Simulation Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244797 Christian Dersch lupi...@mailbox.org changed: What|Removed |Added Summary|Review Request: ASL - |Review Request: libASL - |Advanced Simulation Library |Advanced Simulation Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244797] Review Request: libASL - Advanced Simulation Library
https://bugzilla.redhat.com/show_bug.cgi?id=1244797 --- Comment #3 from Christian Dersch lupi...@mailbox.org --- OK, there are more conflicts to be resolved... I have to contact upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.
https://bugzilla.redhat.com/show_bug.cgi?id=1241919 --- Comment #21 from Michel Alexandre Salim mic...@michel-slm.name --- Heh, that reference to fastcache's spec threw fedora-review into a loop, it assumed the last spec mentioned is the one to use. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244102] Review Request: php-composer-spdx-licenses - SPDX licenses list and validation library
https://bugzilla.redhat.com/show_bug.cgi?id=1244102 --- Comment #9 from Marcin Haba marcin.h...@bacula.pl --- Hello, Just I notified fedora-review authors about issue from this feature request. https://fedorahosted.org/FedoraReview/ticket/264 I also prepared a bit better patch that this above and I attached patch to ticket. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.
https://bugzilla.redhat.com/show_bug.cgi?id=1241919 --- Comment #22 from Jackson Isaac jacksonisaac2...@gmail.com --- Updated to release v3. Spec URL: https://jacksonisaac.fedorapeople.org/packaging/python-line_profiler/release-v3/python-line_profiler.spec SRPM URL: https://jacksonisaac.fedorapeople.org/packaging/python-line_profiler/release-v3/python-line_profiler-1.0-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244899] New: Review Request: monodevelop-database - Database Add-in for MonoDevelop
https://bugzilla.redhat.com/show_bug.cgi?id=1244899 Bug ID: 1244899 Summary: Review Request: monodevelop-database - Database Add-in for MonoDevelop Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: claudiorodr...@pereyradiaz.com.ar QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/elsupergomez/lbs-mono-fedora/master/monodevelop-database/monodevelop-database.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/monodevelop-database-5.7-5.fc22.src.rpm Description: Database Add-in for MonoDevelop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244899] Review Request: monodevelop-database - Database Add-in for MonoDevelop
https://bugzilla.redhat.com/show_bug.cgi?id=1244899 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Blocks||1221559 Depends On||1223455, 1223442 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1221559 [Bug 1221559] Mono 4 https://bugzilla.redhat.com/show_bug.cgi?id=1223442 [Bug 1223442] Review Request: npgsql - A .Net Data Provider for PostgreSQL https://bugzilla.redhat.com/show_bug.cgi?id=1223455 [Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223442] Review Request: npgsql - A .Net Data Provider for PostgreSQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223442 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Blocks||1244899 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1244899 [Bug 1244899] Review Request: monodevelop-database - Database Add-in for MonoDevelop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223455] Review Request: mysql-connector-net - Mono ADO.NET driver for MySQL
https://bugzilla.redhat.com/show_bug.cgi?id=1223455 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Blocks||1244899 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1244899 [Bug 1244899] Review Request: monodevelop-database - Database Add-in for MonoDevelop -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244817] Review Request: python-xvfbwrapper - run headless display inside X virtual framebuffer (Xvfb)
https://bugzilla.redhat.com/show_bug.cgi?id=1244817 Julien Enselme juj...@jujens.eu changed: What|Removed |Added CC||juj...@jujens.eu Assignee|nob...@fedoraproject.org|juj...@jujens.eu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1233989] Review Request: gap-pkg-aclib - Almost Crystallographic groups library for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1233989 --- Comment #1 from Gerald Cox gb...@bzb.us --- Jerry, A few errors on rpmlint... looks like a typo for libraray, the others I believe are false positives. You also threw a few errors: gap-pkg-aclib.noarch: E: version-control-internal-file /usr/lib/gap/pkg/aclib/gap/CVS/Entries see: https://fedoraproject.org/wiki/Common_Rpmlint_issues#version-control-internal-file and: gap-pkg-aclib.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/aclib/doc/algos.tex see: https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line-encoding This doesn't appear too serious... you should let upstream know, and fix for the interim if you are so inclined, but I don't view it as a blocker. Checking: gap-pkg-aclib-1.2-1.fc23.noarch.rpm gap-pkg-aclib-1.2-1.fc23.src.rpm gap-pkg-aclib.noarch: W: spelling-error %description -l en_US nilpotent - nil potent, nil-potent, Omnipotent gap-pkg-aclib.noarch: W: spelling-error %description -l en_US cyrstallographic - crystallographic, crystallography, photographically gap-pkg-aclib.noarch: W: spelling-error %description -l en_US libraray - library, Libra gap-pkg-aclib.noarch: W: spelling-error %description -l en_US polycyclic - poly cyclic, poly-cyclic, polyclinic gap-pkg-aclib.noarch: W: only-non-binary-in-usr-lib gap-pkg-aclib.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/aclib/doc/algos.tex gap-pkg-aclib.noarch: E: version-control-internal-file /usr/lib/gap/pkg/aclib/gap/CVS/Entries gap-pkg-aclib.noarch: E: version-control-internal-file /usr/lib/gap/pkg/aclib/gap/CVS/Root gap-pkg-aclib.noarch: E: version-control-internal-file /usr/lib/gap/pkg/aclib/gap/CVS/Repository gap-pkg-aclib.src: W: spelling-error %description -l en_US nilpotent - nil potent, nil-potent, Omnipotent gap-pkg-aclib.src: W: spelling-error %description -l en_US cyrstallographic - crystallographic, crystallography, photographically gap-pkg-aclib.src: W: spelling-error %description -l en_US libraray - library, Libra gap-pkg-aclib.src: W: spelling-error %description -l en_US polycyclic - poly cyclic, poly-cyclic, polyclinic 2 packages and 0 specfiles checked; 3 errors, 10 warnings. sh: /usr/bin/python: No such file or directory gap-pkg-aclib.noarch: W: spelling-error %description -l en_US nilpotent - nil potent, nil-potent, Omnipotent gap-pkg-aclib.noarch: W: spelling-error %description -l en_US cyrstallographic - crystallographic, crystallography, photographically gap-pkg-aclib.noarch: W: spelling-error %description -l en_US libraray - library, Libra gap-pkg-aclib.noarch: W: spelling-error %description -l en_US polycyclic - poly cyclic, poly-cyclic, polyclinic gap-pkg-aclib.noarch: W: only-non-binary-in-usr-lib gap-pkg-aclib.noarch: E: version-control-internal-file /usr/lib/gap/pkg/aclib/gap/CVS/Repository gap-pkg-aclib.noarch: E: version-control-internal-file /usr/lib/gap/pkg/aclib/gap/CVS/Entries gap-pkg-aclib.noarch: E: version-control-internal-file /usr/lib/gap/pkg/aclib/gap/CVS/Root gap-pkg-aclib.noarch: W: wrong-file-end-of-line-encoding /usr/lib/gap/pkg/aclib/doc/algos.tex 1 packages and 0 specfiles checked; 3 errors, 6 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226719] Review Request: menulibre - FreeDesktop.org compliant menu editor
https://bugzilla.redhat.com/show_bug.cgi?id=1226719
--- Comment #2 from Marcus Karlsson m...@acc.umu.se ---
Thank you for doing the review. I have updated the spec file and I believe that
the issues should be resolved now.
Updated spec URL:
http://www.acc.umu.se/~mk/fedora/menulibre/20150720T1815/menulibre.spec
Updated SRPM URL:
http://www.acc.umu.se/~mk/fedora/menulibre/20150720T1815/menulibre-2.0.6-1.fc22.src.rpm
Changes:
- License file COPYING has been marked as %license and removed from %doc.
- Package now owns the %{datadir}/menulibre directory.
- BR python3 has been removed.
- The %clean section has been removed.
- Hashbang lines are removed from files in %{python3_sitelib}/menulibre{,_lib},
resolving the rpmlint issues. These files are not supposed to be invoked
directly, so opting to remove the hashbang instead of marking the files as
executable.
rpmlint:
rpmlint menulibre.spec menulibre-2.0.6-1.fc22.noarch.rpm
menulibre-2.0.6-1.fc22.src.rpm menulibre
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
diff -u 20150531T2115/menulibre.spec 20150720T1815/menulibre.spec
--- 20150531T2115/menulibre.spec2015-05-31 23:17:15.983984688 +0200
+++ 20150720T1815/menulibre.spec2015-07-20 20:17:41.864882650 +0200
@@ -12,7 +12,6 @@
BuildRequires: desktop-file-utils
BuildRequires: gettext
BuildRequires: intltool
-BuildRequires: python3
BuildRequires: python3-devel
BuildRequires: python3-distutils-extra
Requires: gnome-menus
@@ -35,6 +34,14 @@
%install
%{__python3} setup.py install --root=%{buildroot}
+
+# Remove hashbang line from non-executable library files
+for lib in %{buildroot}%{python3_sitelib}/menulibre{,_lib}/*.py; do
+sed '1{\@^#!/usr/bin/python3@d}' $lib $lib.new
+touch -r $lib $lib.new
+mv $lib.new $lib
+done
+
desktop-file-validate %{buildroot}/%{_datadir}/applications/menulibre.desktop
%find_lang %{name}
@@ -50,11 +57,9 @@
%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || :
-%clean
-rm -rf %{buildroot}
-
%files -f %{name}.lang
-%doc AUTHORS COPYING NEWS PKG-INFO README
+%doc AUTHORS NEWS PKG-INFO README
+%license COPYING
%{_bindir}/%{name}
%{_datadir}/applications/menulibre.desktop
%{_datadir}/icons/hicolor/16x16/apps/menulibre.svg
@@ -63,7 +68,7 @@
%{_datadir}/icons/hicolor/48x48/apps/menulibre.svg
%{_datadir}/icons/hicolor/64x64/apps/menulibre.svg
%{_datadir}/icons/hicolor/scalable/apps/menulibre.svg
-%{_datadir}/menulibre/ui/MenulibreWindow.ui
+%{_datadir}/menulibre/
%{_datadir}/pixmaps/menulibre.png
%{_mandir}/man1/menulibre.1.gz
%{python3_sitelib}/menulibre
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244764] Review Request: rubygem-diffy - Convenient diffing in ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1244764
Vít Ondruch vondr...@redhat.com changed:
What|Removed |Added
CC||vondr...@redhat.com
--- Comment #1 from Vít Ondruch vondr...@redhat.com ---
Hi Ilya,
Looking on the .spec file, I see a few small issues:
* Test suite is not executed.
- It is good habit to execute the test suite, since it is the only way how to
be sure that the code actually works. There is no compiler or anything else
which would watch your back. You can refer to Ruby packaging guidelines [1]
how to do this.
* You should not ship hidden files in you package.
- There are excluded several dot files, but you missed the
%{gem_instdir}/.rspec
- In my packages, I usually remove all of them by simple:
%{gem_instdir}/.*
- This issue is reported by rpmlint, so I guess you did not run it. This is
suggested by packaging guidelines [2] as well as review guidelines [3].
I can sponsor you, but I would appreciate, if you can take a look on some other
packages and submit informal reviews to take more familiar with Fedora
packaging process and guidelines. I am pretty sure you can find some other
GitLab related packages already submitted for a review in Bugzilla.
BTW you lists two FAS nicks and the changelog states that the .spec file was
prepared by Igor Gnatenko, so could you please clarify who is actually author
and submitter etc. Just to be clear. Thank you.
[1] https://fedoraproject.org/wiki/Packaging:Ruby#Testing_frameworks_usage
[2] https://fedoraproject.org/wiki/Packaging:Guidelines#Use_rpmlint
[3] https://fedoraproject.org/wiki/Packaging:ReviewGuidelines
[4]
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Get_Sponsored
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244353] Review Request: ossim - Open Source Software Image Map
https://bugzilla.redhat.com/show_bug.cgi?id=1244353 --- Comment #3 from Marcin Haba marcin.h...@bacula.pl --- Hello, Thanks for your changes in Spec. Could I ask you about provide spec file in plan text form togeter with source rpm in lines like below: Spec URL: url-to-spec-in-text-format.spec SRPM URL: url-to-srpm-available-to-download.src.rpm I am asking about it because fedora-review tool is able to work with specs in text format, not with HTML git pages. This tool downloads files directly from links pasted here in bugzilla.redhat.com and then performs tests and prepares review check list form. Thanks in advance. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208616] Review Request: consul - Tool for service discovery, monitoring and configuration http://www.consul.io
https://bugzilla.redhat.com/show_bug.cgi?id=1208616 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1231459] Review Request: libosimum - Fast and flexible C++ library for working with OpenStreetMap data
https://bugzilla.redhat.com/show_bug.cgi?id=1231459 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235305] Review Request: hitch - Network proxy that terminates TLS/SSL connections
https://bugzilla.redhat.com/show_bug.cgi?id=1235305 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1231459] Review Request: libosmium - Fast and flexible C++ library for working with OpenStreetMap data
https://bugzilla.redhat.com/show_bug.cgi?id=1231459 Tom Hughes t...@compton.nu changed: What|Removed |Added Summary|Review Request: libosimum - |Review Request: libosmium - |Fast and flexible C++ |Fast and flexible C++ |library for working with|library for working with |OpenStreetMap data |OpenStreetMap data Flags||fedora-cvs? --- Comment #14 from Tom Hughes t...@compton.nu --- New Package SCM Request === Package Name: libosmium Short Description: Fast and flexible C++ library for working with OpenStreetMap data Upstream URL: http://osmcode.org/libosmium/ Owners: tomh Branches: f21 f22 f23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219288] Review Request: python-marshmallow - Python library for converting complex datatypes to and from primitive types
https://bugzilla.redhat.com/show_bug.cgi?id=1219288 --- Comment #2 from Julien Enselme juj...@jujens.eu --- Any progress on addressing the problems I pointed out? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1233963] Review Request: python-cachetools - Extensible memoizing collections and decorators
https://bugzilla.redhat.com/show_bug.cgi?id=1233963 --- Comment #2 from Julien Enselme juj...@jujens.eu --- Any progress on addressing the problems I pointed out? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1163559] Review Request: python-flask-uwsgi-websocket - High-performance WebSockets for your Flask apps powered by uWSGI
https://bugzilla.redhat.com/show_bug.cgi?id=1163559 --- Comment #4 from Julien Enselme juj...@jujens.eu --- Any progress? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1233963] Review Request: python-cachetools - Extensible memoizing collections and decorators
https://bugzilla.redhat.com/show_bug.cgi?id=1233963 --- Comment #3 from John Eckersberg jecke...@redhat.com --- (In reply to Julien Enselme from comment #2) Any progress on addressing the problems I pointed out? Sorry, I lost track of this in my backlog. I'll get an updated package posted later today. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Bill Pemberton wf...@worldbroken.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Bill Pemberton wf...@worldbroken.com --- New Package SCM Request === Package Name: perl-Algorithm-LUHN Short Description: Calculate the Modulus 10 Double Add Double checksum Upstream URL: http://search.cpan.org/dist/Algorithm-LUHN/ Owners: wfp Branches: f22 f23 el6 epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244899] Review Request: monodevelop-database - Database Add-in for MonoDevelop
https://bugzilla.redhat.com/show_bug.cgi?id=1244899 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added CC||p...@all-the-johnsons.co.uk --- Comment #1 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- *** Bug 551914 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551914] Review Request: monodevelop-database - A database plugin for monodevelop
https://bugzilla.redhat.com/show_bug.cgi?id=551914 Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Last Closed||2015-07-20 13:57:09 --- Comment #17 from Claudio Rodrigo Pereyra DIaz claudiorodr...@pereyradiaz.com.ar --- *** This bug has been marked as a duplicate of bug 1244899 *** -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244817] Review Request: python-xvfbwrapper - run headless display inside X virtual framebuffer (Xvfb)
https://bugzilla.redhat.com/show_bug.cgi?id=1244817
Julien Enselme juj...@jujens.eu changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Julien Enselme juj...@jujens.eu ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[-]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: Unknown or generated. 3 files have unknown license. Detailed
output of licensecheck in /tmp/1244817-python-
xvfbwrapper/licensecheck.txt
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package
[Bug 1244014] Review Request: python-ddt - Data-Driven/Decorated Tests
https://bugzilla.redhat.com/show_bug.cgi?id=1244014
--- Comment #4 from Carl George carl.geo...@rackspace.com ---
Have you tried running %build and %install without creating a separate py3k
directory? This package doesn't use 2to3 so this should work juts as well.
I have not tried it that way. I just did it the same way I saw several other
module packages do it (pip, setuptools, six, click). The only documentation I
could find about this says the macro should be used when the same source is
used for both python2 and python3 [1], which is the case here.
You can use %global _docdir_fmt %{name} to use a common license and
documentation directories.
I'm not following what the point of this would be. I thought the current
project goal was to separate license files from documentation [2]?
Summary or %description should say what this package is in more basic term
(e.g. a library which provides a testing framework).
I thought that was clear in the summary, but I am not a wordsmith, so I'm open
to more detailed suggestions here. I just copied the current summary and
description from the setup.py and README.md files. Maybe the long_description
in the setup.py would be more appropriate for the RPM description?
long_description='A library to multiply test cases',
[1]: https://fedoraproject.org/wiki/Python3.4GuidlinesDraft#Macros
[2]:
https://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image#Summary
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242896] Review Request: python-ironic-inspector-client - Python client and CLI tool for Ironic Inspector
https://bugzilla.redhat.com/show_bug.cgi?id=1242896 Julien Enselme juj...@jujens.eu changed: What|Removed |Added Status|NEW |ASSIGNED CC||juj...@jujens.eu Assignee|nob...@fedoraproject.org|juj...@jujens.eu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #1 from Vít Ondruch vondr...@redhat.com --- Lets do bug 1244764 first ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228869] Review Request: gdouros-asea-fonts - an étude on the dominant typeface of Greek typography
https://bugzilla.redhat.com/show_bug.cgi?id=1228869 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added CC||ke...@scrye.com Flags|fedora-cvs? | --- Comment #7 from Kevin Fenzi ke...@scrye.com --- Our git processing script is erroring on this package. (Likely due to the é in the description) I'm not sure this is allowed by the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description says: Please put personal preferences aside and use American English spelling in the summary and description. I'm clearing the flag here so I can process the rest of the queue... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243499] Review Request: python-configparser - Backport of python 3 configparser module to python 2.7 (and 2.6)
https://bugzilla.redhat.com/show_bug.cgi?id=1243499 --- Comment #7 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243782] Review Request: nodejs-process-nextick-args - The process.nextTick() but always with args
https://bugzilla.redhat.com/show_bug.cgi?id=1243782 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243499] Review Request: python-configparser - Backport of python 3 configparser module to python 2.7 (and 2.6)
https://bugzilla.redhat.com/show_bug.cgi?id=1243499 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242709] Review Request: python-jupyter_core - Core Jupyter functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1242709 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243249] Review Request: python-nbformat - The Jupyter Notebook format
https://bugzilla.redhat.com/show_bug.cgi?id=1243249 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474984] Review Request: bandwidthd - Tracks network usage and builds html and graphs
https://bugzilla.redhat.com/show_bug.cgi?id=474984 --- Comment #23 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 474984] Review Request: bandwidthd - Tracks network usage and builds html and graphs
https://bugzilla.redhat.com/show_bug.cgi?id=474984 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193878] Review Request: qmasterpassword - Stateless Master Password Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1193878 --- Comment #16 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193878] Review Request: qmasterpassword - Stateless Master Password Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1193878 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241922] Review Request: perl-Test-LWP-UserAgent - LWP::UserAgent suitable for simulating and testing network calls
https://bugzilla.redhat.com/show_bug.cgi?id=1241922 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208616] Review Request: consul - Tool for service discovery, monitoring and configuration http://www.consul.io
https://bugzilla.redhat.com/show_bug.cgi?id=1208616 Jiri Popelka jpope...@redhat.com changed: What|Removed |Added Assignee|bra...@redhat.com |jpope...@redhat.com Flags||fedora-review+ --- Comment #18 from Jiri Popelka jpope...@redhat.com --- Re-setting fedora-review flag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241922] Review Request: perl-Test-LWP-UserAgent - LWP::UserAgent suitable for simulating and testing network calls
https://bugzilla.redhat.com/show_bug.cgi?id=1241922 --- Comment #8 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243782] Review Request: nodejs-process-nextick-args - The process.nextTick() but always with args
https://bugzilla.redhat.com/show_bug.cgi?id=1243782 --- Comment #6 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243783] Review Request: nodejs-util-deprecate - The Node.js `util.deprecate()` function with browser support
https://bugzilla.redhat.com/show_bug.cgi?id=1243783 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244509] Review Request: perl-DBIx-Class-Schema-Diff - Identify differences between two DBIx::Class schemas
https://bugzilla.redhat.com/show_bug.cgi?id=1244509 --- Comment #3 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243783] Review Request: nodejs-util-deprecate - The Node.js `util.deprecate()` function with browser support
https://bugzilla.redhat.com/show_bug.cgi?id=1243783 --- Comment #4 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208616] Review Request: consul - Tool for service discovery, monitoring and configuration http://www.consul.io
https://bugzilla.redhat.com/show_bug.cgi?id=1208616 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223887] Review Request: atomicapp - Reference implementation of the Nulecule container application Specification
https://bugzilla.redhat.com/show_bug.cgi?id=1223887 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- atomicapp-0.1.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/atomicapp-0.1.1-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243506] Review Request: perl-Net-HL7 - Simple perl API for HL7 messages
https://bugzilla.redhat.com/show_bug.cgi?id=1243506 --- Comment #3 from Petr Šabata psab...@redhat.com --- (In reply to Bill Pemberton from comment #2) I was a afraid of that. I thought ANY of the Beerware weren't allowed, but then I saw the above link and (falsely) thought Beerware was Beerware You can also ask on the legal@ list. I'm not sure whether simply blocking FE-Legal is enough to get any legal attention. You could also contact upstream, explain the situation and ask them change the license to be a little bit more permissive. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223887] Review Request: atomicapp - Reference implementation of the Nulecule container application Specification
https://bugzilla.redhat.com/show_bug.cgi?id=1223887 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #11 from Jan Chaloupka jchal...@redhat.com --- epel7 branch not created http://pkgs.fedoraproject.org/cgit/atomicapp.git/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228868] Review Request: gdouros-aroania-fonts - A font based on Victor Julius Scholderer's New Hellenic
https://bugzilla.redhat.com/show_bug.cgi?id=1228868 --- Comment #6 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223887] Review Request: atomicapp - Reference implementation of the Nulecule container application Specification
https://bugzilla.redhat.com/show_bug.cgi?id=1223887 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ --- Comment #12 from Jan Chaloupka jchal...@redhat.com --- Created now. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228868] Review Request: gdouros-aroania-fonts - A font based on Victor Julius Scholderer's New Hellenic
https://bugzilla.redhat.com/show_bug.cgi?id=1228868 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235305] Review Request: hitch - Network proxy that terminates TLS/SSL connections
https://bugzilla.redhat.com/show_bug.cgi?id=1235305 --- Comment #16 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241423] Review Request: nodejs-esprima-fb - Facebook-specific fork of the esprima project
https://bugzilla.redhat.com/show_bug.cgi?id=1241423 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241423] Review Request: nodejs-esprima-fb - Facebook-specific fork of the esprima project
https://bugzilla.redhat.com/show_bug.cgi?id=1241423 --- Comment #9 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244509] Review Request: perl-DBIx-Class-Schema-Diff - Identify differences between two DBIx::Class schemas
https://bugzilla.redhat.com/show_bug.cgi?id=1244509 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Šabata psab...@redhat.com --- (In reply to Bill Pemberton from comment #4) I just realized that I removed perl from the BuildRequires instead of just removing the version requirement. Do I need to add that back or is it ok to assume the other perl BuildRequires will take care of it? Add it back. Although it's almost certain something will pull perl into the buildroot, you can never know. And since you're using it yourself, you need to buildrequire it. Anyhow, I trust you'll add it before pushing the package. I ack you've fixed everything I've pointed out so I'm going to approve this now :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223887] Review Request: atomicapp - Reference implementation of the Nulecule container application Specification
https://bugzilla.redhat.com/show_bug.cgi?id=1223887 --- Comment #10 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
