[Bug 1261166] Review Request: nodejs-commoner - Tool for translating any dialect of JavaScript to Node CommonJS modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261166



--- Comment #7 from Fedora Update System  ---
nodejs-commoner-0.10.3-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-16463

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265012] Review Request: python-pycosat - Python bindings to picosat (a SAT solver)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265012

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Antonio Trande  ---
Packaged approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1246903] Review Request: gnome-shell-extension-openweather - an extension to display weather information from many locations in the world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246903

Jens Lody  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #32 from Jens Lody  ---
New Package SCM Request
===
Package Name: gnome-shell-extension-openweather
Short Description: Display weather information for (almost) all locations in
the world
Upstream URL: https://github.com/jenslody/gnome-shell-extension-openweather
Owners: jenslody
Branches: f21 f22 f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265012] Review Request: python-pycosat - Python bindings to picosat (a SAT solver)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265012

Orion Poplawski  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Orion Poplawski  ---
New Package SCM Request
===
Package Name: python-pycosat
Short Description: Python bindings to picosat (a SAT solver)
Upstream URL: http://pypi.python.org/pypi/python-pycosat
Owners: orion group::python-sig
Branches: f23 f22 f21 epel7 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261166] Review Request: nodejs-commoner - Tool for translating any dialect of JavaScript to Node CommonJS modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261166



--- Comment #5 from Fedora Update System  ---
nodejs-commoner-0.10.3-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-16451

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1055378] Review Request: icinga - Open Source host, service and network monitoring program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1055378

Shawn Starr  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2015-09-22 14:47:39



--- Comment #49 from Shawn Starr  ---
Currently Icinga 2.x is being packaged a BZ will be forthcoming once I get the
SELinux discussion thats now ongoing sorted out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264561] Review Request: autocloud - A test framework to test Fedora cloud images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264561



--- Comment #7 from Jon Ciesla  ---
User "sayanchowdhury" is not in the packager group

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264561] Review Request: autocloud - A test framework to test Fedora cloud images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264561

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261166] Review Request: nodejs-commoner - Tool for translating any dialect of JavaScript to Node CommonJS modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261166



--- Comment #6 from Fedora Update System  ---
nodejs-commoner-0.10.3-1.fc21 has been submitted as an update to Fedora 21.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-16453

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265101] New: Review Request: postgresql-cstore_fdw - Columnar store for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265101

Bug ID: 1265101
   Summary: Review Request: postgresql-cstore_fdw - Columnar store
for PostgreSQL
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: holca...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/holcapek/postgresql-cstore_fdw/master/postgresql-cstore_fdw.spec
SRPM URL:
https://github.com/holcapek/postgresql-cstore_fdw/raw/master/postgresql-cstore_fdw-1.0-1.fc21.src.rpm
Description: This extension implements a columnar store for PostgreSQL.
Columnar stores provide notable benefits for analytic use-cases
where data is loaded in batches. This extension uses the Optimized
Row Columnar (ORC) format for its data layout.
Fedora Account System Username: holcapek

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264686] Review Request: itpp - C++ library for math, signal/speech processing, and communications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264686



--- Comment #6 from Antonio Trande  ---
>Do I have to change also all the directories names to libitpp? E.g. 
>>%{_includedir}/libitpp , %{_datadir}/libitpp ?

It's not necessary.

>2) use libitpp as the name of the package, but leaving the include dir named 
>as >%{_includedir}/itpp

Okay so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260575] Review Request: python-ordered-set - A Custom MutableSet that remembers its order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260575



--- Comment #16 from Fedora Update System  ---
python-ordered-set-1.3.1-4.el6 has been submitted as an update to Fedora EPEL
6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8187

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265101] Review Request: postgresql-cstore_fdw - Columnar store for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265101



--- Comment #1 from Jan Holcapek  ---
The package builds in mock, rpmlint has no complaints.

Note that I have packaged version 1.0 even there is version 1.3 already out. I
did that intentionally, since there are only 4 versions out (1.0 through 1.3
since August 2014), and for the sake of having "complete" history of versions
released in Fedora/EPEL, I've started with 1.0 and will release other versions
subsequently.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260575] Review Request: python-ordered-set - A Custom MutableSet that remembers its order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260575



--- Comment #17 from Fedora Update System  ---
python-ordered-set-1.3.1-4.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8188

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265327] Review Request: nodejs-os-tmpdir - Node.js os.tmpdir() ponyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265327



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=11181174

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265329] Review Request: nodejs-parse-json - Parse JSON with more helpful errors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265329



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=11181180

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265012] Review Request: python-pycosat - Python bindings to picosat (a SAT solver)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265012



--- Comment #4 from Orion Poplawski  ---
The permission issue is an artifact of mock's ccache being enabled.  It doesn't
occur with koji or fedpkg mockbuild.


* Tue Sep 22 2015 Orion Poplawski  - 0.6.1-2
- Quiet setup

Spec URL: http://www.cora.nwra.com/~orion/fedora/python-pycosat.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python-pycosat-0.6.1-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265326] New: Review Request: nodejs-node-error-ex - Easy error subclassing and stack customization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265326

Bug ID: 1265326
   Summary: Review Request: nodejs-node-error-ex - Easy error
subclassing and stack customization
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-node-error-ex.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-node-error-ex-1.2.0-1.fc23.src.rpm

Description:
Easy error subclassing and stack customization.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129505



--- Comment #12 from Adam Miller  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 5 files have unknown license. Detailed
 output of licensecheck in /home/admiller/reviews/1129505-bash-
 completion-extras/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/bash-
 completion/completions(tig, cmake, bzr, rpmdevtools, mercurial,
 createrepo, vagrant, python-django-bash-completion, bash-completion,
 firewalld, subversion, rolekit, rpmlint, yum, libappstream-glib,
 source-highlight, git, gvfs, glib2)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 112640 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[!]: Spec use %global instead of %define unless justified.
 Note: %define requiring justification: %define rhelname bash-
 completion
[x]: Packager, 

[Bug 1212835] Review Request: castxml - C-family abstract syntax tree XML output tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1212835



--- Comment #10 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1212835] Review Request: castxml - C-family abstract syntax tree XML output tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1212835

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1252784] Review Request: python-wsgi_intercept - WSGI application tester

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252784



--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546



--- Comment #6 from Gustavo Lima Chaves  ---
> By the way:
> Gustavo please fix the url's for Source0 and Source1, they do not work.

Sorry, indeed the 0 one was wrong. What's the point of github having the
downloaded file != the URL file? :/

> What's the cause for keeping the "config"-file locally ?

What's the rationale for this? We distribute all deps on external servers? This
is only the configuration for Fedora systems, I thought I could skip having to
address this specifically in a URL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265321] Review Request: nodejs-gettext-parser - Parse and compile gettext po and mo files to/from json, nothing more, nothing less

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265321



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=11181089

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546



--- Comment #5 from Gustavo Lima Chaves  ---
> I can't sponsor you, but I can give some suggestions.

Thanks a lot for the suggestions, Christopher! I guess Fidencio and I
will continue fine with this (thank you too, Panda!).

>
> 1. Please include your email in changelog.

Done. I really wish I could have a single, initial changelog for an
initial packaging attempt. Is that possible?

>
> You can try rpmdev-bumpspec to see what exactly is changelog, obviously the
> current one is poor.
>
> 2. "%define soletta_major 0
> %define soletta_minor 0
> %define soletta_build 1
> %define soletta_release beta5"
>
> https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

Thanks a lot, I won't forget.

>
> 3. Drop Group tags in all packages.

Okay, better for me.

>
> 4. It's better to put %post(un/trans) after %install/%check but before %files.

Done.

>
> 5. "This package contains the sysctl linux-micro module for %{name}. The
> module sets kernel parameters from sysctl.conf files. This service
> will mimic systemd-sysctl.service and read the settings from
> '/etc/sysctl.conf' or '/run/sysctl.d', '/etc/sysctl.d',
> '/usr/local/lib/sysctl.d', '/usr/lib/sysctl.d', '/lib/sysctl.d'. Files
> are processed in alphabetical order. See
> http://www.freedesktop.org/software/systemd/man/systemd-sysctl.service.html.
> "
>
> Sorry, we don't use some of these paths. Please remove them.

All linux-micro modules were moved to the base lib package, so these
texts are no more. I did that because linux-micro would eventually
vanish in a f23 version of the spec.

>
> 6. The build log is silent, I could only see
>
> GEN *
> CC *
> LD *
> BIN *

Well, by default our build log IS indeed silent. You can see all
that's happening with V=1, if you wish.

>
> This makes it impossible to detect if it's been built correctly:
>
> https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
>
> You must compile packages with %optflags and %__global_ldflags for linking,
> note these need to be inserted, but not substituted of all flags since you
> might use some custom flags as well.

Nevertheless, I added those, thanks. The only "strange" output you'll
see there are cpio errors when trying to generate debug symbols for
the duktape (JavaScript) sub-module. There's an open ticket for the lib
authors to remove #line directives from their released code, that should
vanish soon (next release, maybe).

>
> 7. Drop %defattr(-, root, root, -)

Done.

>
> 8. %{_includedir}/soletta/*
>
> No, you forgot %{_includedir}/soletta/ itself, this will only include files
> underneath the dir without dir itself.

Ok, various %dir added.

>
> 9. Same as above, %{_datadir}/soletta and %{_libdir}/soletta weren't included,
> but since different subpackages put files inside, you need to decide on your
> own.

Ditto.

>
> 10. You use %license, but put it in lib%{name}-pin-mux-module-Edison only,
> that's wrong, you should put it into lib%{name}. (because every subpkg depends
> on it based on the spec from my view)

Now it happens just after the main lib's files.

>
> 11. I don't see any packages with name %{name}, so isn't it better to rename
> this spec to libsoletta?

I intend to package other things on the soletta project umbrella here.
Namely https://github.com/solettaproject/soletta-dev-app is the next
candidate, so...

>
> 12 Last question, do we really need such many subpackages?

11 of them were merged with the main lib now. The others I'd like to
keep -- they are optional for most use cases and may require different
deps.

Again, thanks a lot for the review. I'll have this new spec uploaded
soon for you to see.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 481527] Review Request: bucardo - asynchronous PostgreSQL replication system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=481527



--- Comment #31 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 481527] Review Request: bucardo - asynchronous PostgreSQL replication system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=481527

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1252784] Review Request: python-wsgi_intercept - WSGI application tester

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252784

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265326] Review Request: nodejs-node-error-ex - Easy error subclassing and stack customization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265326



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=11181150

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265327] New: Review Request: nodejs-os-tmpdir - Node.js os.tmpdir() ponyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265327

Bug ID: 1265327
   Summary: Review Request: nodejs-os-tmpdir - Node.js os.tmpdir()
ponyfill
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-os-tmpdir.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-os-tmpdir-1.0.1-1.fc23.src.rpm

Description:
Node.js os.tmpdir() ponyfill.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1246903] Review Request: gnome-shell-extension-openweather - an extension to display weather information from many locations in the world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246903

Richard Shaw  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #30 from Richard Shaw  ---
Ok, I think I've done what I'm supposed to do to sponsor you. I'm not sure if
there is any delay before you can be granted scm access so go ahead and try
your scm request.

Also, sponsoring is not a one time activity. If you run into any issues feel
free to contact me. If I don't know the answer I'll try to get it from someone
who does.

Use your powers for good!


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1259005] Review Request: docker-distribution - The Docker toolset to pack, ship, store, and deliver content

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1259005



--- Comment #13 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1259005] Review Request: docker-distribution - The Docker toolset to pack, ship, store, and deliver content

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1259005

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537



--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1116029] Review Request: rubygem-elasticsearch-api - Ruby elasticsearch api

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116029



--- Comment #6 from Troy Dawson  ---
If Haïkel Guémar doesn't respond I will take the review.  It's been over 3
months since you updated with his changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1116024] Review Request: rubygem-elasticsearch-extensions - Extensions for the Elasticsearch Rubygem.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116024

Troy Dawson  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tdaw...@redhat.com
   Assignee|nob...@fedoraproject.org|tdaw...@redhat.com



--- Comment #2 from Troy Dawson  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Not the latest version (0.0.18)

- License file LICENSE.txt is marked as %doc instead of %license
  See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- Package installs properly.
-- This is because this requires rubygem-ruby-prov (#1116021)
-- There isn't a rule that says you can't work on seveal packages at once. 
Let's see if we can get them both into fedora at the same time.
-- So, I would still pass this, as long at it looks like the dependency is
moving along.

- There is no %check section
-- This would require packages that are not yet in fedora
--- rubygem-turn (not really needed.  Dependency can be removed with 
 sed -i '/require.*turn/ s/^/#/' test/test_helper.rb
--- rubygem-elasticsearch-extentions (#1116030)
-- Since this is a *should* I would pass this without the %check section, but I
would highly encourage you to add the %check when the dependencies are in
fedora.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[-]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license 

[Bug 1129505] Review Request: bash-completion-extras - EPEL7 only supplemental bash-completion package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1129505



--- Comment #13 from Jim Perrin  ---
Updated and release bumped. I cleaned up a couple instances of trailing
whitespace as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546



--- Comment #7 from Gustavo Lima Chaves  ---
So, after this 1st round of reviews, here we are:

New spec URL:
https://raw.githubusercontent.com/solettaproject/soletta-packaging/v3/rpm/soletta.spec

New SRPM URL:
https://github.com/solettaproject/soletta-packaging/releases/download/v3/soletta-0.0.1-beta5.fc22.src.rpm

Successful koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=11182749

Successful copr build:
https://copr.fedoraproject.org/coprs/glchaves/soletta/build/117590/

Please let me know if I forgot anything from the reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1116029] Review Request: rubygem-elasticsearch-api - Ruby elasticsearch api

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1116029

Troy Dawson  changed:

   What|Removed |Added

 CC||tdaw...@redhat.com



--- Comment #5 from Troy Dawson  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Not the latest version (1.0.13)
- License file LICENSE.txt is marked as %doc instead of %license
  See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- There is no %check section
-- This would require packages that are not yet in fedora
--- rubygem-turn (not really needed.  Dependency can be removed with 
 sed -i '/require.*turn/ s/^/#/' test/test_helper.rb
test/integration/yaml_test_runner.rb
--- rubygem-elasticsearch-extentions (#1116024)
-- Since this is a *should* I would pass this without the %check section, but I
would highly encourage you to add the %check when the dependencies are in
fedora.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Ruby:
[-]: Platform dependent files must all go under %{gem_extdir_mri}, platform
 independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and 

[Bug 1246904] Review Request: gnome-shell-extension-panel-osd - An extension to configure the place where notifications are shown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246904

Michael Schwendt (Fedora Packager Sponsors Group)  
changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208695] Review Request: liberasurecode - Erasure Code API library written in C with pluggable backends

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208695



--- Comment #20 from Pete Zaitcev  ---
Final touches done:
 - fixed the spec file name inside SRPM (verified with rpm2cpio|cpio -it)
 - added TODO comment about "make test"

Spec URL: http://people.redhat.com/zaitcev/tmp/liberasurecode-1.0.9-3.spec
SRPM URL:
http://people.redhat.com/zaitcev/tmp/liberasurecode-1.0.9-3.fc22.src.rpm
Description:
An API library for Erasure Code, written in C. It provides a number
of pluggable backends, such as Intel ISA-L library.

Fedora Account System Username: zaitcev

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
php-udan11-sql-parser-0-0.3.20150820git1b2988f.fc23 has been pushed to the
Fedora 23 testing repository. If problems still persist, please make note of it
in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-udan11-sql-parser'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-16382

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265484] New: Review Request: google-roboto-slab-fonts - Google Roboto Slab fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265484

Bug ID: 1265484
   Summary: Review Request: google-roboto-slab-fonts - Google
Roboto Slab fonts
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL:
http://pnemade.fedorapeople.org/fedora-work/google-roboto-slab-fonts.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/google-roboto-slab-fonts-1.100263-0.1.20150923.fc23.src.rpm

Description:
Roboto has a dual nature. It has a mechanical skeleton and the forms are
largely geometric. At the same time, the font features friendly and open
curves. While some grotesks distort their letterforms to force a rigid
rhythm, Roboto doesn't compromise, allowing letters to be settled into
their natural width. This makes for a more natural reading rhythm more
commonly found in humanist and serif types.

This is the Roboto Slab family, which can be used alongside the normal
Roboto family and the Roboto Condensed family.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265484] Review Request: google-roboto-slab-fonts - Google Roboto Slab fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265484



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=11189745

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265327] Review Request: nodejs-os-tmpdir - Node.js os.tmpdir() ponyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265327

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1226557] Review Request: amsynth - A classic synthesizer with dual oscillators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1226557

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||1.5.1-6.fc23
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-23 00:11:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1226557] Review Request: amsynth - A classic synthesizer with dual oscillators

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1226557



--- Comment #21 from Fedora Update System  ---
amsynth-1.5.1-6.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265329] Review Request: nodejs-parse-json - Parse JSON with more helpful errors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265329

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265321] Review Request: nodejs-gettext-parser - Parse and compile gettext po and mo files to/from json, nothing more, nothing less

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265321

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265322] Review Request: nodejs-encoding - Convert encodings, uses iconv by default and fallbacks to iconv-lite if needed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265322

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265326] Review Request: nodejs-node-error-ex - Easy error subclassing and stack customization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265326

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262470] Review Request: python-PyPDF2 - A pure Python library built as a PDF toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262470



--- Comment #3 from Globe Trotter  ---
Pete,

Since Major did not respond yet, I was looking at this (I was the original
packager on BZ, see the duplicate, now closed, which preceded this one).


> - LICENSE file should go in every subpackage, not only -doc

How does one do this? 

Separately, I had some warnings on rpmlint using my spec file: see 1234208 but
, no erors.

$ rpmlint python-PyPDF2-1.24-1.1.fc22.src.rpm 
python-PyPDF2.src: W: spelling-error %description -l en_US decrypting ->
decryption, encrypting, decrying
python-PyPDF2.src: W: invalid-license BSD-3-Clause
python-PyPDF2.src: W: no-url-tag
python-PyPDF2.src:29: W: macro-in-comment %{modulename}
python-PyPDF2.src:29: W: macro-in-comment %{version}
python-PyPDF2.src: E: specfile-error warning: bogus date in %changelog: Thu Jul
11 2015 stat.mai...@inbox.com
1 packages and 0 specfiles checked; 1 errors, 5 warnings.
maitra@alakananda 21:59:54~$ rpmlint python-PyPDF2-1.24-1.1.fc22.src.rpm 
python-PyPDF2.src: W: spelling-error %description -l en_US decrypting ->
decryption, encrypting, decrying
python-PyPDF2.src: W: invalid-license BSD-3-Clause
python-PyPDF2.src: W: no-url-tag
python-PyPDF2.src:29: W: macro-in-comment %{modulename}
python-PyPDF2.src:29: W: macro-in-comment %{version}
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

Are these important?

Of course, perhaps Major will respond with the corrections you
requested/suggested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208695] Review Request: liberasurecode - Erasure Code API library written in C with pluggable backends

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208695

Pete Zaitcev  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #21 from Pete Zaitcev  ---
New Package SCM Request
===
Package Name: liberasurecode
Short Description: Erasure Code API library written in C with pluggable
backends
Upstream URL: https://bitbucket.org/tsg-/liberasurecode/
Owners: zaitcev
Branches: f24 f23 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262807] Review Request: php-udan11-sql-parser - A validating SQL lexer and parser with a focus on MySQL dialect

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262807



--- Comment #16 from Fedora Update System  ---
php-udan11-sql-parser-0-0.3.20150820git1b2988f.fc21 has been pushed to the
Fedora 21 testing repository. If problems still persist, please make note of it
in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update php-udan11-sql-parser'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-16383

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537



--- Comment #7 from Fedora Update System  ---
libs3-2.0-0.2.20150902git247ba1b.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16481

--- Comment #8 from Fedora Update System  ---
libs3-2.0-0.2.20150902git247ba1b.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8199

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537



--- Comment #9 from Fedora Update System  ---
libs3-2.0-0.2.20150902git247ba1b.el5 has been submitted as an update to Fedora
EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8200

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537



--- Comment #9 from Fedora Update System  ---
libs3-2.0-0.2.20150902git247ba1b.el5 has been submitted as an update to Fedora
EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8200

--- Comment #10 from Fedora Update System  ---
libs3-2.0-0.2.20150902git247ba1b.fc22 has been submitted as an update to Fedora
22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16482

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537



--- Comment #7 from Fedora Update System  ---
libs3-2.0-0.2.20150902git247ba1b.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16481

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265265] Review Request: mlt - A multimedia framework designed for television broadcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265265



--- Comment #6 from Sergio Monteiro Basto  ---
Hi, 
I don't know .
MLT BuildRequires ffmpeg-devel and libquicktime-devel from rpmfusion .
MLT have one /usr/lib64/mlt/libmltavformat.so .
I never done a freeworld package and IMO with RPMFusion idle is not a good idea
, but you may try , I do not object .
I'm packager maintainer because no one take care of it and IMO is a important
package but I don't know much about internals 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215807] Review Request: umockdev - Mock hardware devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215807

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||0.8.8-3.fc22
 Resolution|--- |NEXTRELEASE
Last Closed||2015-09-22 18:54:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215807] Review Request: umockdev - Mock hardware devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215807



--- Comment #12 from Fedora Update System  ---
umockdev-0.8.8-3.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=481528

Itamar Reis Peixoto  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #16 from Itamar Reis Peixoto  ---
Package Change Request
==
Package Name: perl-DBIx-Safe
New Branches: EL-7
Owners: itamarjp
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537



--- Comment #6 from Fedora Update System  ---
libs3-2.0-0.2.20150902git247ba1b.fc21 has been submitted as an update to Fedora
21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16480

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1261537] Review Request: libs3 - C Library and Tools for Amazon S3 Access

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1261537

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 481527] Review Request: bucardo - asynchronous PostgreSQL replication system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=481527

Itamar Reis Peixoto  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #30 from Itamar Reis Peixoto  ---
Package Change Request
==
Package Name: bucardo
New Branches: EL-7
Owners: itamarjp
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265321] New: Review Request: nodejs-gettext-parser - Parse and compile gettext po and mo files to/from json, nothing more, nothing less

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265321

Bug ID: 1265321
   Summary: Review Request: nodejs-gettext-parser - Parse and
compile gettext po and mo files to/from json, nothing
more, nothing less
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-gettext-parser.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-gettext-parser-1.1.1-1.fc23.src.rpm

Description:
Parse and compile gettext po and mo files with node.js.

This module is slightly based on module node-gettext. The plan is to move all
parsing and compiling logic from node-gettext to here and leave only
translation related functions (domains, plural handling, lookups etc.) there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265012] Review Request: python-pycosat - Python bindings to picosat (a SAT solver)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265012



--- Comment #1 from Antonio Trande  ---
Why are you building a python2-package?

>Wrote: /builddir/build/RPMS/python2-pycosat-0.6.1-1.fc24.i686.rpm

The name of package is python-pycosat.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264402] Review Request: python-automaton - Friendly state machines for python.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264402

Javier Peña  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2015-09-22 05:24:17



--- Comment #4 from Javier Peña  ---
Built in rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264561] Review Request: autocloud - A test framework to test Fedora cloud images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264561



--- Comment #4 from Ratnadeep Debnath  ---
Fixed all the issues listed above and updated the SPEC and SRPM file at:

Spec URL: https://rtnpro.fedorapeople.org/Packages/SPECS/autocloud.spec
SRPM URL:
https://rtnpro.fedorapeople.org/Packages/SRPMS/autocloud-0.1-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264686] Review Request: itpp - C++ library for math, signal/speech processing, and communications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264686



--- Comment #7 from Marco Driusso  ---
(In reply to Antonio Trande from comment #6)
> >Do I have to change also all the directories names to libitpp? E.g. 
> >>%{_includedir}/libitpp , %{_datadir}/libitpp ?
> It's not necessary.
> >2) use libitpp as the name of the package, but leaving the include dir named 
> >as >%{_includedir}/itpp
> Okay so.

OK, choice 2, now package name is libitpp.
Here new spec and SRPM:

Spec URL: https://mdriu.fedorapeople.org/libitpp.spec
SRPM URL: https://mdriu.fedorapeople.org/libitpp-4.3.1-1.fc22.src.rpm
Successful koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11175788

I hope you don't mind Antonio, I also sent a mail on the devel list for asking
other opinions about most appropriate package name (also for understanding
myself which are the naming criteria in cases like this).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264209] Review Request: php-wikimedia-ip-set - Library to match IP addresses against CIDR specifications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264209

Remi Collet  changed:

   What|Removed |Added

 CC||fed...@famillecollet.com



--- Comment #1 from Remi Collet  ---
According to packagist and github releases, version 1.0.1 = rev
3c2dd6706546fe616e6ceba02044e64dce4fc9be

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264419] Review Request: perl-Clownfish - Apache Clownfish symbiotic object system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264419

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Clownfish-0.4.2-1.fc24
 Resolution|--- |RAWHIDE
Last Closed||2015-09-22 03:20:23



--- Comment #4 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1252784] Review Request: python-wsgi_intercept - WSGI application tester

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252784

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Parag AN(पराग)  ---
Just looking into spec file above update looks good to me.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264561] Review Request: autocloud - A test framework to test Fedora cloud images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264561

Praveen Kumar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Praveen Kumar  ---
(In reply to Ratnadeep Debnath from comment #4)
> Fixed all the issues listed above and updated the SPEC and SRPM file at:
> 
> Spec URL: https://rtnpro.fedorapeople.org/Packages/SPECS/autocloud.spec
> SRPM URL:
> https://rtnpro.fedorapeople.org/Packages/SRPMS/autocloud-0.1-2.fc22.src.rpm

Check about scm: https://fedoraproject.org/wiki/Package_SCM_admin_requests

= Approved =

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265012] Review Request: python-pycosat - Python bindings to picosat (a SAT solver)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265012

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265265] New: Review Request: mlt - A multimedia framework designed for television broadcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265265

Bug ID: 1265265
   Summary: Review Request: mlt - A multimedia framework designed
for television broadcasting
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: limburg...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:
MLT is a LGPL multimedia framework designed for television broadcasting,
and melted is a GPL multi-unit video playout server with realtime
effects.

SPEC: https://fedorapeople.org/~limb/review/mlt/mlt.spec
SRPM: https://fedorapeople.org/~limb/review/mlt/mlt-0.9.8-1.fc22.src.rpm

Required for updated synfig and synfigstudio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265265] Review Request: mlt - A multimedia framework designed for television broadcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265265

Jon Ciesla  changed:

   What|Removed |Added

 Blocks||1265222




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1265222
[Bug 1265222] synfig-1.0.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1212835] Review Request: castxml - C-family abstract syntax tree XML output tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1212835

Mattias Ellert  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #9 from Mattias Ellert  ---
Many thanks for the review.

New Package SCM Request
===
Package Name: castxml
Short Description: C-family abstract syntax tree XML output tool
Owners: ellert
Branches: f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1212835] Review Request: castxml - C-family abstract syntax tree XML output tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1212835

Jon Kerr Nilsen  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #8 from Jon Kerr Nilsen  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Header files in -devel subpackage, if present.
Not a problem, the header files are needed for basic usage
- Large data in /usr/share should live in a noarch subpackage if package
  is arched.
Most of the data comes from the bundled clang header files. Since these
are in arched package for clang it should be fine to do the same here.

No failed items, package APPROVED.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary 

[Bug 1265265] Review Request: mlt - A multimedia framework designed for television broadcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265265



--- Comment #4 from Jon Ciesla  ---
Sergio, any comments on the above?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265265] Review Request: mlt - A multimedia framework designed for television broadcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265265

Jon Ciesla  changed:

   What|Removed |Added

 CC||ser...@serjux.com



--- Comment #3 from Jon Ciesla  ---
Agreed.  I'm not sure, and I can't update synfig without it.  I'd like to avoid
moving the whole stack to rpmfusion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260290] Review Request: python-XStatic-roboto-fontface - roboto-fontface 0.4.3 (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260290



--- Comment #18 from Fedora Update System  ---
python-XStatic-roboto-fontface-0.4.3.2-4.el7 has been submitted as an update to
Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8192

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1252784] Review Request: python-wsgi_intercept - WSGI application tester

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252784

Chandan Kumar  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Chandan Kumar  ---
New Package SCM Request
===
Package Name: python-wsgi_intercept
Short Description: wsgi_intercept installs a WSGI application in place of a
real URI for testing
Upstream URL: https://github.com/cdent/wsgi-intercept
Owners: chandankumar
Branches: f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265012] Review Request: python-pycosat - Python bindings to picosat (a SAT solver)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265012



--- Comment #2 from Orion Poplawski  ---
(In reply to Antonio Trande from comment #1)
> Why are you building a python2-package?

See http://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265265] Review Request: mlt - A multimedia framework designed for television broadcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265265

Mamoru TASAKA  changed:

   What|Removed |Added

 CC||mtas...@fedoraproject.org



--- Comment #1 from Mamoru TASAKA  ---
So as far as I read 
 * bug 459979
 * https://bugzilla.rpmfusion.org/show_bug.cgi?id=527 

the problem with this package is that the source contains avformat support and
at least this must be removed from the source tarball (not by "rm -rf" at
%prep). I don't know kdenlive and kino, however as far as I read the previous
review request these modules must be treated similarly. And the original bug
report doubts that this package is far from useful without avformat support.

Is this situation changed? (repeatedly, at least avformat suppport or so must
be removed from the tarball for Fedora inclusion)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264561] Review Request: autocloud - A test framework to test Fedora cloud images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264561

Ratnadeep Debnath  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Ratnadeep Debnath  ---
New Package SCM Request
===
Package Name: autocloud
Short Description: A test framework which automatically downloads and tests
Fedora cloud image builds from koji.
Owners: rtnpro kushal sayanchowdhury kumarpraveen
Branches: F-23
InitialCC: rtnpro kushal sayanchowdhury kumarpraveen

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1234210] Review Request: pdf-stapler - tool for manipulating PDF documents from the command line

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1234210



--- Comment #11 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Globe Trotter from comment #10)
> Response to Comment 3:
> 
> The author has finally added the License file to upstream.
> 
> However, now he has also explicitly required PyPDF2 instead of PyPdf which
> is also submitted to packaging:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1262470
OK. I'll try to review that.

> How does one proceed to submit a package for review which also depends on
> another that has also been submitted for review and no one has picked it
> yet? (The original PyPDF2 was submitted at the same time as this one:
> https://bugzilla.redhat.com/show_bug.cgi?id=1234208)
By adding the other bug to "Depends On". Both reviews can proceed in parallel,
the only caveat is that if this review is finished before the other one, you
will not be able to actually build the package officially in koji.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 750997] Review Request: scilab - Scientific software package for numerical computations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=750997

ycollet  changed:

   What|Removed |Added

 CC||ycollette.nos...@free.fr



--- Comment #18 from ycollet  ---
I still have the error message for fedora 22:

Attention : Impossible de trouver le package Java
'/usr/share/java/saxon/saxon.jar'.
Des problèmes sont survenus pendant le chargement des bibliothèques Java.
Pouvant induire des erreurs de Scilab.
Veuillez vérifier le fichier SCI/etc/classpath.xml.

I just installed scilab:
dnf install scilab

On a nearly fresh fedora install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1259005] Review Request: docker-distribution - The Docker toolset to pack, ship, store, and deliver content

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1259005

Jan Chaloupka  changed:

   What|Removed |Added

 Whiteboard|NotReady|
  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Jan Chaloupka  ---
Atm it can not be built from bundled deps due to dependency on docker. The
current effort is to perform daily scans of all golang packages and report API
backward compatibility issues. The effort is centralized at [1]. The server is
still under development with additional checks coming.

Besides deps, the spec file conforms to the current golang packaging draft.
Approving the review.

[1] http://209.132.179.123/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265265] Review Request: mlt - A multimedia framework designed for television broadcasting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265265



--- Comment #5 from Mamoru TASAKA  ---
If the files under src/modules creates really loadable (i.e. to be dlopen()ed)
modules, one way is to modify source on Fedora to build modules acceptable on
Fedora only, and on rpmfusion build full modules (if this approach is
possible), like gstreamer1 (gstreamer1-plugins-bad-freeworld is built on
rpmfusion side).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1259005] Review Request: docker-distribution - The Docker toolset to pack, ship, store, and deliver content

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1259005

Jan Chaloupka  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #12 from Jan Chaloupka  ---
New Package SCM Request
===
Package Name: docker-distribution
Short Description: The Docker toolset to pack, ship, store, and deliver content
Upstream URL: https://github.com/docker/distribution
Owners: jchaloup lsm5
Branches: f23 f22 f21 el6 epel7
InitialCC: golang-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1243550] Review Request: openstack-aodh - OpenStack Telemetry Alarming

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1243550



--- Comment #13 from Pradeep Kilambi  ---
Thanks! fixed the /etc/aodh own issue.

Spec URL: https://pkilambi.fedorapeople.org/openstack-aodh/openstack-aodh.spec
SRPM URL:
https://pkilambi.fedorapeople.org/openstack-aodh/openstack-aodh-1.0.0-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review