[Bug 1285518] Review Request: perl-File-Edit-Portable - Read and write files while keeping the original line-endings intact

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285518

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-File-Edit-Portable-1.10-1.fc24.noarch.rpm | sort |
uniq -c
  1 perl(:MODULE_COMPAT_5.22.0)
  1 perl(:VERSION) >= 5.8.0
  1 perl(Carp)
  1 perl(Exporter)
  1 perl(File::Find::Rule)
  1 perl(File::Temp)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-File-Edit-Portable-1.10-1.fc24.noarch.rpm | sort |
uniq -c
  1 perl(File::Edit::Portable) = 1.10
  1 perl-File-Edit-Portable = 1.10-1.fc24
Binary provides are Ok.

$ rpmlint ./perl-File-Edit-Portable*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

BuildRequires are ok
TODO: perl(strict) and perl(warnings) should be part of the first section
  BRs, because they are used in Makefile.PL

Please consider fixing 'TODO' items.

Package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285300] Review Request: eclipse-xtext - Xtext is a framework for development of programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285300



--- Comment #2 from Sopot Cela  ---
Thanks for the comments. Updated and uploaded: 

Spec URL: https://sopotc.fedorapeople.org/eclipse-xtext/eclipse-xtext.spec
SRPM URL:
https://sopotc.fedorapeople.org/eclipse-xtext/eclipse-xtext-2.9.0-0.1.rc1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285300] Review Request: eclipse-xtext - Xtext is a framework for development of programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285300

Mat Booth  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Mat Booth  ---
Thanks, I am happy to approve the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270513

Raphael Groner  changed:

   What|Removed |Added

   Priority|medium  |high



--- Comment #2 from Raphael Groner  ---
Raising priority to high cause newtonsoft-json is needed for several other
reviews and an update of MonoDevelop.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1223990] Review Request: openssl101e - A general purpose cryptography library with TLS implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1223990

Robert Scheck  changed:

   What|Removed |Added

  Flags||needinfo?(abeekhof@redhat.c
   ||om)



--- Comment #11 from Robert Scheck  ---
Andrew, sorry for pushing this a bit, but this package makes only sense while 
RHEL/CentOS 5 is still being actively used ;-) What is left to get this review
finished/approved?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285077] Review Request: nodejs-test - (Un)CommonJS test runner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285077

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Tom Hughes  ---
Great. Package approved then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281739] Review Request: python-libpagure - A Python library for Pagure APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281739



--- Comment #19 from Fedora Update System  ---
python-libpagure-0.5-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-78a26442ab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281739] Review Request: python-libpagure - A Python library for Pagure APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281739

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281739] Review Request: python-libpagure - A Python library for Pagure APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281739



--- Comment #20 from Fedora Update System  ---
python-libpagure-0.5-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-c386808c83

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285767] New: Review Request: golang-github-seccomp-libseccomp-golang - The libseccomp golang bindings repository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285767

Bug ID: 1285767
   Summary: Review Request:
golang-github-seccomp-libseccomp-golang - The
libseccomp golang bindings repository
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-seccomp-libseccomp-golang/golang-github-seccomp-libseccomp-golang.spec

SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-seccomp-libseccomp-golang/golang-github-seccomp-libseccomp-golang-0-0.1.git1b506fc.fc20.src.rpm

Description: The libseccomp golang bindings repository

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=11984989

$ rpmlint golang-github-seccomp-libseccomp-golang-0-0.1.git1b506fc.fc20.src.rpm
golang-github-seccomp-libseccomp-golang-devel-0-0.1.git1b506fc.fc20.noarch.rpm
golang-github-seccomp-libseccomp-golang-unit-test-devel-0-0.1.git1b506fc.fc20.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285767] Review Request: golang-github-seccomp-libseccomp-golang - The libseccomp golang bindings repository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285767

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|l...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270513

Claudio Rodrigo Pereyra DIaz  changed:

   What|Removed |Added

 CC||claudiorodrigo@pereyradiaz.
   ||com.ar
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1036130] Review request: plv8 - javascript language extension for postgresql

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1036130

Pavel Raiskup  changed:

   What|Removed |Added

 CC||mikko.tiiho...@iki.fi
  Flags||needinfo?(mikko.tiihonen@ik
   ||i.fi)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 494520] Review Request: cdf - The NASA Common Data Format implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=494520

Alexis Jeandet  changed:

   What|Removed |Added

 CC||alexis.jean...@member.fsf.o
   ||rg



--- Comment #6 from Alexis Jeandet  ---
Hi,

I contacted the cdf developers, they told me that they are really in favor of
an open source license but they have to deal with lawyer stuff... So we can
expect to get the lib cdf with a compatible license soon.

Best regards,
Alexis.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 915791] Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=915791



--- Comment #13 from Petr Šabata  ---
Just saying `fine' would be the easier way, however, it wouldn't feel right.

Please, rebase the package.  I'll re-review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269539

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269539



--- Comment #18 from Fedora Update System  ---
mozjs38-38.2.1-5.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c2272a08a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270513



--- Comment #3 from Claudio Rodrigo Pereyra DIaz 
 ---
Need split pc file into -devel package
Need add:
%dir %{_monodir}/%{name}

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD", "LGPL (v2.1 or later) (with
 incorrect FSF address)", "Unknown or generated". 317 files have
 unknown license. Detailed output of licensecheck in
 /media/galileo/fedora/1270513-newtonsoft-json/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/mono/newtonsoft-json
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/mono/newtonsoft-json
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[?]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[!]: The placement of pkgconfig(.pc) files are correct.
 Note: newtonsoft-json : /usr/lib64/pkgconfig/newtonsoft-json.pc
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.

[Bug 1285338] Review Request: openh264 - H.264 codec library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285338



--- Comment #6 from Kalev Lember  ---
Thanks Antonio!

* Thu Nov 26 2015 Kalev Lember  - 1.5.2-0.2.git21e44bd
- Pass Fedora LDFLAGS to the build to get full relro

Spec URL: https://kalev.fedorapeople.org/openh264.spec
SRPM URL:
https://kalev.fedorapeople.org/openh264-1.5.2-0.2.git21e44bd.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215478] Review Request: lets-encrypt - A free, automated certificate authority

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215478

Nikos Mavrogiannopoulos  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
  Flags|fedora-review?  |
   |needinfo?(tdfischer@hackerb |
   |ots.net)|



--- Comment #25 from Nikos Mavrogiannopoulos  ---
I'll get back to that once there is an active owner.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970393] Review Request: foo2zjs - Driver for printers of various wire protocols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970393



--- Comment #31 from Fedora Update System  ---
foo2zjs-0.2015-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-b6687a7b2d

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1189015] Review Request: python-MDAnalysis - Analyze and manipulate molecular dynamics trajectories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189015



--- Comment #5 from Antonio Trande  ---
Any news here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270513



--- Comment #4 from Upstream Release Monitoring 
 ---
raphgro's scratch build of newtonsoft-json-7.0.1-2.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11986801

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270513



--- Comment #5 from Raphael Groner  ---
Hi Claudio,
thanks for your review. May I assign this bug to you as you're doing the
official process?

Spec URL: https://raphgro.fedorapeople.org/review/openra/newtonsoft-json.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/openra/newtonsoft-json-7.0.1-2.fc23.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11986801

* Thu Nov 26 2015 Raphael Groner <> - 7.0.1-2
- fix folders ownership
- remove obsolete generation of pkgconfig file

About general discussion of devel subpackages for mono, see bug #477308.
 IMHO it's generally ridiculous to blow up spec files with generation of
.pc files that does not bring any real benefit over rpm's own features, but so
I tried in first step. Instead, mono is able to resolve its dependencies and
there's virtual Provides: mono(Newtonsoft.Json) 

> [?]: Patches link to upstream bugs/comments/lists or are otherwise
>  justified.

That's not needed, both patches are for Fedora only to ensure package builds
properly, see the comments.

> [?]: %check is present and all tests pass.

It's present and all enabled tests pass. We've to disable some tests due to in
Fedora currently unresolvable dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270513

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|claudiorodrigo@pereyradiaz.
   ||com.ar



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1197333] Review Request: polyglot-chess - Polyglot chess opening book program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197333

Raphael Groner  changed:

   What|Removed |Added

  Alias|polyglot|polyglot-chess



--- Comment #11 from Raphael Groner  ---
> polyglot-chess.src: W: spelling-error %description -l en_US xboard -> board, 
> aboard, x board
> polyglot-chess.src: W: spelling-error %description -l en_US leveldb -> level 
> db, level-db, level

Both are false positives.

> polyglot-chess.x86_64: E: incorrect-fsf-address 
> /usr/share/licenses/polyglot-chess/LICENSE
> polyglot-chess.x86_64: E: incorrect-fsf-address 
> /usr/share/doc/polyglot-chess/readme.txt

https://github.com/sshivaji/polyglot/issues/1

> [?] GUI app uses .desktop file, installs it with desktop-file-install
>Doesn't appear to be a GUI application

Yes, it's a CLI tool.

> [?] Functions as described (e.g. no crashes)
>Please check this ;)

Not sure if we should well package the branch named with leveldb, it has more
current commits with some bugfixes. Though, upstreams seems to be nearly dead,
no response to my reported issues till now.
https://github.com/sshivaji/polyglot/commits/leveldb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1197333] Review Request: polyglot-chess - Polyglot chess opening book program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197333



--- Comment #12 from Raphael Groner  ---
SPEC:
https://raphgro.fedorapeople.org/review/chess/polyglot/polyglot-chess.spec
SRPM:
https://raphgro.fedorapeople.org/review/chess/polyglot/polyglot-chess-1.4-5.20140902gitf46ee06.fc23.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11987209

* Thu Nov 26 2015 Raphael Groner <> - 1.4-5.20140902gitf46ee06
- fix rpmlint warnings

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1128395] Review Request: flatzebra - A generic game engine for 2D double-buffering animation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128395

Antonio Trande  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|anto.tra...@gmail.com   |nob...@fedoraproject.org
  Flags|fedora-review?  |



--- Comment #2 from Antonio Trande  ---
Review stalled or abandoned by contributor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1128395] Review Request: flatzebra - A generic game engine for 2D double-buffering animation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1128395

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||anto.tra...@gmail.com
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2015-11-26 14:02:07




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1150099] Review Request: python-neo - Represent electrophysiology data in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1150099

Antonio Trande  changed:

   What|Removed |Added

 CC|anto.tra...@gmail.com   |



--- Comment #2 from Antonio Trande  ---
Any news here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1197333] Review Request: polyglot-chess - Polyglot chess opening book program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197333



--- Comment #13 from Upstream Release Monitoring 
 ---
raphgro's scratch build of polyglot-chess-1.4-5.20140902gitf46ee06.fc23.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11987209

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1134840] Review Request: python3-script - Help for writing shell scripts in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1134840

Antonio Trande  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2015-11-26 14:06:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1192969] Review Request: python-hardware - Hardware detection and classification utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1192969

Antonio Trande  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2015-11-26 14:06:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270513] Review Request: newtonsoft-json - Popular high-performance JSON framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270513



--- Comment #6 from Claudio Rodrigo Pereyra DIaz 
 ---
(In reply to Raphael Groner from comment #5)
> Hi Claudio,
> thanks for your review. May I assign this bug to you as you're doing the
> official process?
> 
> Spec URL: https://raphgro.fedorapeople.org/review/openra/newtonsoft-json.spec
> SRPM URL:
> https://raphgro.fedorapeople.org/review/openra/newtonsoft-json-7.0.1-2.fc23.
> src.rpm
> 
> Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=11986801
> 
> * Thu Nov 26 2015 Raphael Groner <> - 7.0.1-2
> - fix folders ownership
> - remove obsolete generation of pkgconfig file
> 
> About general discussion of devel subpackages for mono, see bug #477308.
>  IMHO it's generally ridiculous to blow up spec files with generation
> of .pc files that does not bring any real benefit over rpm's own features,
> but so I tried in first step. Instead, mono is able to resolve its
> dependencies and there's virtual Provides: mono(Newtonsoft.Json) 

rpm resolver dependency yes, but without .pc file monodevelop could not
reference the assembly in to any project for development propose.

> > [?]: Patches link to upstream bugs/comments/lists or are otherwise
> >  justified.
> 
> That's not needed, both patches are for Fedora only to ensure package builds
> properly, see the comments.
> 
> > [?]: %check is present and all tests pass.
>
> It's present and all enabled tests pass. We've to disable some tests due to
> in Fedora currently unresolvable dependencies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285873] New: request to include redsocks in repo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285873

Bug ID: 1285873
   Summary: request to include redsocks in repo
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: akost...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



redsocks package - http://darkk.net.ru/redsocks/

A very useful tool to get traffic tunnelled through a http connect proxy or
socks4/5 server selectively.

Basically it runs as a local daemon. Administrator can DNAT particular TCP
(limited DNS and UDP support) traffic to the port daemon is listening to. Then
daemon does the magic to tunnel it through proxy or socks (depending on
config). Priceless when applications do not support socks/proxy or wanting to
redirect VM traffic through particular channel without prior knowledge what app
will be running inside, etc. many more usage scenarios.

Debian already has a package. I tried `alien` over the debian testing package +
`rpmrebuild -pe` to remove directory entries like `/`, `/lib/`, etc. After that
everything seems to be working as expected. Including `systemd` integration. So
I hope it wont be hard to include in fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285067] Review Request: python-pyxid - Python library for interfacing with Cedrus XID and StimTracker devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285067



--- Comment #2 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-pyxid

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276871] Review Request: python-nibabel - Python package to access a cacophony of neuro-imaging file formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276871



--- Comment #5 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-nibabel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276910] Review Request: python-transforms3d - 3 dimensional spatial transformations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276910



--- Comment #3 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-transforms3d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284779] Review Request: python-baker - Easy, powerful access to Python functions from the command line

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284779

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
- license is OK
- license file is not present, but upstream has been bugged
- new python packaging style is used
- requires/provides are correct
- check is present

Nice! Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1280482] Review Request: python-PyLink - Universal communication interface using File-Like API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280482

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
- license is OK
- license file is present, %license is used
- new python packaging style is used
- provides/requires are correct
- fedora-review has nothing to complain about
- latest version

Rpmlint
---
Checking: python2-PyLink-0.3.2-1.fc23.noarch.rpm
  python3-PyLink-0.3.2-1.fc23.noarch.rpm
  python-PyLink-0.3.2-1.fc23.src.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)

2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Everything looks good. Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284638] Review Request: bugyou - An Automatic Bug Reporting Tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284638



--- Comment #6 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/bugyou

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285428] Review Request: perl-Crypt-ScryptKDF - Scrypt password based key derivation function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285428



--- Comment #5 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/perl-Crypt-ScryptKDF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1280490] Review Request: python-pyriemann - Covariance matrices manipulation and Biosignal classification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280490

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1280490] Review Request: python-pyriemann - Covariance matrices manipulation and Biosignal classification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280490



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Build fails in tests:

==
ERROR: Test Fit of Kmeans
--
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
  File
"/builddir/build/BUILD/python-pyriemann-0.2.3/python2/tests/test_clustering.py",
line 20, in test_Kmeans_fit
km.fit(covset)
  File
"/builddir/build/BUILDROOT/python-pyriemann-0.2.3-2.fc24.x86_64/usr/lib/python2.7/site-packages/pyriemann/clustering.py",
line 155, in fit
tol=self.tol)
  File
"/builddir/build/BUILDROOT/python-pyriemann-0.2.3-2.fc24.x86_64/usr/lib/python2.7/site-packages/pyriemann/clustering.py",
line 20, in _fit_single
X, n_clusters, init, random_state=random_state)
  File "/usr/lib64/python2.7/site-packages/sklearn/cluster/k_means_.py", line
620, in _init_centroids
x_squared_norms = row_norms(X, squared=True)
  File "/usr/lib64/python2.7/site-packages/sklearn/utils/extmath.py", line 69,
in row_norms
norms = np.einsum('ij,ij->i', X, X)
ValueError: operand has more dimensions than subscripts given in einstein sum,
but no '...' ellipsis provided to broadcast the extra dimensions.
==
ERROR: Test Fit of Kmeans wit matric initialization
--
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
  File
"/builddir/build/BUILD/python-pyriemann-0.2.3/python2/tests/test_clustering.py",
line 26, in test_Kmeans_fit_with_init
km.fit(covset)
  File
"/builddir/build/BUILDROOT/python-pyriemann-0.2.3-2.fc24.x86_64/usr/lib/python2.7/site-packages/pyriemann/clustering.py",
line 141, in fit
tol=self.tol)
  File
"/builddir/build/BUILDROOT/python-pyriemann-0.2.3-2.fc24.x86_64/usr/lib/python2.7/site-packages/pyriemann/clustering.py",
line 20, in _fit_single
X, n_clusters, init, random_state=random_state)
  File "/usr/lib64/python2.7/site-packages/sklearn/cluster/k_means_.py", line
620, in _init_centroids
x_squared_norms = row_norms(X, squared=True)
  File "/usr/lib64/python2.7/site-packages/sklearn/utils/extmath.py", line 69,
in row_norms
norms = np.einsum('ij,ij->i', X, X)
ValueError: operand has more dimensions than subscripts given in einstein sum,
but no '...' ellipsis provided to broadcast the extra dimensions.
==
ERROR: Test Fit of Kmeans with a given y
--
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
  File
"/builddir/build/BUILD/python-pyriemann-0.2.3/python2/tests/test_clustering.py",
line 33, in test_Kmeans_fit_with_y
km.fit(covset,y=labels)
  File
"/builddir/build/BUILDROOT/python-pyriemann-0.2.3-2.fc24.x86_64/usr/lib/python2.7/site-packages/pyriemann/clustering.py",
line 155, in fit
tol=self.tol)
  File
"/builddir/build/BUILDROOT/python-pyriemann-0.2.3-2.fc24.x86_64/usr/lib/python2.7/site-packages/pyriemann/clustering.py",
line 20, in _fit_single
X, n_clusters, init, random_state=random_state)
  File "/usr/lib64/python2.7/site-packages/sklearn/cluster/k_means_.py", line
620, in _init_centroids
x_squared_norms = row_norms(X, squared=True)
  File "/usr/lib64/python2.7/site-packages/sklearn/utils/extmath.py", line 69,
in row_norms
norms = np.einsum('ij,ij->i', X, X)
ValueError: operand has more dimensions than subscripts given in einstein sum,
but no '...' ellipsis provided to broadcast the extra dimensions.
==
ERROR: Test Fit of Kmeans using paralell
--
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
  File
"/builddir/build/BUILD/python-pyriemann-0.2.3/python2/tests/test_clustering.py",
line 39, in test_Kmeans_fit_parallel
km.fit(covset)
  File
"/builddir/build/BUILDROOT/python-pyriemann-0.2.3-2.fc24.x86_64/usr/lib/python2.7/site-packages/pyriemann/clustering.py",
line 167, in fit
for seed in seeds)
  File "/usr/lib/python2.7/site-packages/joblib/parallel.py", line 812, in
__call__
self.retrieve()
  File "/usr/lib/python2.7/site-packages/joblib/parallel.py", line 762, in
retrieve
raise exception
JoblibValueError: JoblibValueError
___

This is with current rawhide:

DEBUG util.py:393:   python-pandas x86_64 0.17.0-3.fc24
   

[Bug 1277818] Review Request: vowpal-wabbit - Fast and efficient machine learning system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277818

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Please extend the %description to say what this package actually does. Who
sponsors the project is something that is not normally included in the
%description.

Since you install stuff in %{_libdir}, add scriptlets
[https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries].

Version 8.1.1 is out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277415] Review Request: php-nette-http - Nette HTTP Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277415
Bug 1277415 depends on bug 1277384, which changed state.

Bug 1277384 Summary: Review Request: php-nette-finder - Nette Finder: Files 
Searching
https://bugzilla.redhat.com/show_bug.cgi?id=1277384

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277384] Review Request: php-nette-finder - Nette Finder: Files Searching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277384



--- Comment #15 from Fedora Update System  ---
php-nette-finder-2.3.1-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284790] Review Request: python-tabulate - Pretty-print tabular data in Python, a library and a command-line utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284790



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Same as for other packages: I think that the tools are not python-version
specific, and there should be just one script in /usr/bin.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277384] Review Request: php-nette-finder - Nette Finder: Files Searching

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277384

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-26 15:59:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277484] Review Request: php-nette - Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277484
Bug 1277484 depends on bug 1277384, which changed state.

Bug 1277384 Summary: Review Request: php-nette-finder - Nette Finder: Files 
Searching
https://bugzilla.redhat.com/show_bug.cgi?id=1277384

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279211] Review Request: python-gradunwarp - Gradient Unwarping

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279211



--- Comment #7 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-gradunwarp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278685] Review Request: python-pywt - PyWavelets, wavelet transform module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278685

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=644899



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Original review is 644899.

Development has obviously been picked up again, so the reasons for retirement
are voided.

Why do you need separate documentation for python2 and python3? Even if there
are some small difference, I don't think they are important enough to pay for
the overhead of packagers and build time and disk usage and potential user
confusion.

Also, the docs are >1MB, so it might be nice to split them out into a separate
-doc package.

Tests in /usr/lib/python3.5/site-packages/pywt/tests/ have
#!/usr/bin/env python
Should be changed to #!/usr/bin/python3.5.

Looks good otherwise. Rpmlint complains about /usr/bin/env, but has only false
positives apart from that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 644899] Review Request: python-pywt - Python wavelet transforms module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=644899

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1278685



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222334] Review Request: bup - Efficient backup system based on git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222334



--- Comment #10 from William Moreno  ---
Test Build:

s390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1993939
ppc: http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2935262
arm: http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3297728

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1280490] Review Request: python-pyriemann - Covariance matrices manipulation and Biosignal classification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280490



--- Comment #3 from Upstream Release Monitoring 
 ---
zbyszek's scratch build of python-pyriemann-0.2.3-2.fc24.src.rpm for rawhide
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11987784

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284982] Review Request: nodejs-iconv - Text recoding in JavaScript for fun and profit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284982



--- Comment #6 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-iconv

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285074] Review Request: nodejs-ansi-font - ANSI font styling utils

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285074



--- Comment #4 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-ansi-font

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285049] Review Request: nodejs-jsonselect - CSS-like selectors for JSON

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285049



--- Comment #7 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-jsonselect

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277505] Review Request: jssc - Java Simple Serial Connector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277505



--- Comment #6 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/jssc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279176] Review Request: isis - Framework to access a large variety of image processing libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279176

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285338] Review Request: openh264 - H.264 codec library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285338



--- Comment #7 from Antonio Trande  ---
[x]: %build honors applicable compiler flags or justifies otherwise.

Just another thing:

%{_sysconfdir}/profile.d/gmpopenh264.sh shold be marked with %config, i think.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277504] Review Request: apigen - PHP source code API generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277504
Bug 1277504 depends on bug 1277499, which changed state.

Bug 1277499 Summary: Review Request: php-apigen-theme-default - Default Theme 
for Apigen
https://bugzilla.redhat.com/show_bug.cgi?id=1277499

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277497] Review Request: php-apigen-theme-bootstrap - Twitter Bootstrap Theme for Apigen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277497



--- Comment #15 from Fedora Update System  ---
php-apigen-theme-bootstrap-1.1.3-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281532] Review Request: Pagila - Example database for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281532



--- Comment #22 from Fedora Update System  ---
pagila-0.10.1-3.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277499] Review Request: php-apigen-theme-default - Default Theme for Apigen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277499

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-26 15:59:01



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277497] Review Request: php-apigen-theme-bootstrap - Twitter Bootstrap Theme for Apigen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277497

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-26 15:59:09



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277409] Review Request: php-nette-caching - Nette Caching Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277409
Bug 1277409 depends on bug 1277384, which changed state.

Bug 1277384 Summary: Review Request: php-nette-finder - Nette Finder: Files 
Searching
https://bugzilla.redhat.com/show_bug.cgi?id=1277384

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277437] Review Request: php-nette-robot-loader - Nette RobotLoader: comfortable autoloading

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277437
Bug 1277437 depends on bug 1277384, which changed state.

Bug 1277384 Summary: Review Request: php-nette-finder - Nette Finder: Files 
Searching
https://bugzilla.redhat.com/show_bug.cgi?id=1277384

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277504] Review Request: apigen - PHP source code API generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277504
Bug 1277504 depends on bug 1277497, which changed state.

Bug 1277497 Summary: Review Request: php-apigen-theme-bootstrap - Twitter 
Bootstrap Theme for Apigen
https://bugzilla.redhat.com/show_bug.cgi?id=1277497

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277465] Review Request: php-nette-forms - Nette Forms: greatly facilitates web forms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277465
Bug 1277465 depends on bug 1277395, which changed state.

Bug 1277395 Summary: Review Request: php-nette-component-model - Nette 
Component Model
https://bugzilla.redhat.com/show_bug.cgi?id=1277395

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277388] Review Request: php-nette-php-generator - Nette PHP Generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277388



--- Comment #16 from Fedora Update System  ---
php-nette-php-generator-2.3.4-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277395] Review Request: php-nette-component-model - Nette Component Model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277395



--- Comment #15 from Fedora Update System  ---
php-nette-component-model-2.2.4-2.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277395] Review Request: php-nette-component-model - Nette Component Model

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277395

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-11-26 15:58:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277484] Review Request: php-nette - Nette Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277484
Bug 1277484 depends on bug 1277395, which changed state.

Bug 1277395 Summary: Review Request: php-nette-component-model - Nette 
Component Model
https://bugzilla.redhat.com/show_bug.cgi?id=1277395

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277499] Review Request: php-apigen-theme-default - Default Theme for Apigen

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277499



--- Comment #14 from Fedora Update System  ---
php-apigen-theme-default-1.0.2-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277470] Review Request: php-nette-application - Nette Application MVC Component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277470
Bug 1277470 depends on bug 1277395, which changed state.

Bug 1277395 Summary: Review Request: php-nette-component-model - Nette 
Component Model
https://bugzilla.redhat.com/show_bug.cgi?id=1277395

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277388] Review Request: php-nette-php-generator - Nette PHP Generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277388

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1280482] Review Request: python-PyLink - Universal communication interface using File-Like API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280482

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276926] Review Request: nipy-data - Test data and brain templates for nipy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276926



--- Comment #5 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nipy-data

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 886320] Review Request: mingw-nspr - MinGW build of Netscape Portable Runtime

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=886320



--- Comment #7 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/mingw-nspr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285077] Review Request: nodejs-test - (Un)CommonJS test runner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285077



--- Comment #5 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-test

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1280464] Review Request: python-citeproc-py - Yet another Python CSL Processor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280464



--- Comment #4 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-citeproc-py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285300] Review Request: eclipse-xtext - Xtext is a framework for development of programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285300



--- Comment #4 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/eclipse-xtext

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278293] Review Request: python-moss - Assorted utilities for neuroimaging and cognitive science

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278293



--- Comment #6 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-moss

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208911] Review Request: doublecmd - Twin-panel (commander-style) file manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1208911

Raphael Groner  changed:

   What|Removed |Added

 Depends On||1247925



--- Comment #26 from Raphael Groner  ---
ARM support is not the best in fpc 2.x series, there's the new upstream version
3.0 of fpc that could make things better.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1247925
[Bug 1247925] add ppc64le and aarch64 support for fpc
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284790] Review Request: python-tabulate - Pretty-print tabular data in Python, a library and a command-line utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284790

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284779] Review Request: python-baker - Easy, powerful access to Python functions from the command line

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284779

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222334] Review Request: bup - Efficient backup system based on git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222334

William Moreno  changed:

   What|Removed |Added

 Blocks||485231
   ||(F-ExcludeArch-s390x)



--- Comment #11 from William Moreno  ---
s390 builds still fails, you MUST include a ExcludeArch: s390 tag in your spec.
Please wait I finish the review to update the spec.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=485231
[Bug 485231] ExcludeArch Tracker for s390x
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1222334] Review Request: bup - Efficient backup system based on git

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1222334



--- Comment #12 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of bup-0.27-0.3.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11988462

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279056] Review Request: libminc - Core library and API of the MINC toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279056



--- Comment #2 from Igor Gnatenko  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> %{_libdir}/cmake/LIBMINC/ → this looks suspicious. Cmake puts everything in
> /usr/share/cmake asaic, nothing provides /usr/lib/cmake in Fedora.
arch-dependent packages should go to libdir/cmake/*
> 
> I don't think libminc-devel should require cmake. It should be possible to
> link to the library using other build systems, and cmake is a fairly large
> dep.
will remore
> 
> Rpmlint
> ---
> Checking: libminc-2.3.00-1.fc24.i686.rpm
>   libminc-devel-2.3.00-1.fc24.i686.rpm
>   libminc-debuginfo-2.3.00-1.fc24.i686.rpm
>   libminc-2.3.00-1.fc24.src.rpm
> libminc.i686: W: shared-lib-calls-exit /usr/lib/libminc2.so.4.0.0
> exit@GLIBC_2.0
looks like you got it 2 times, probably bug in rpmlint? What does it mean?
> libminc-debuginfo.i686: W: spurious-executable-perm
> /usr/src/debug/libminc-libminc-2-3-00/volume_io/Geometry/tensors.c
will do chmod -x on that file.
> 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> - latest version is packaged
> - BSD license is OK
> - license file is present, %license is used
> - tests are present and pass
> - ldconfig is called
> - Provides/Requires look sane, apart from the cmake dep.
> 
> Looks fine apart from the minor issues listed above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279064] Review Request: minc-tools - Basic minc-tools from former minc repository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279064



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
mincview uses display from ImageMagick. Requires is missing.

minchistory and mincpik are PERL scripts. The header should be modified to
#!/usr/bin/perl. Then an automatic dependency on /usr/bin/perl will be
generated, it is currently missing.

rpmlint:
minc-tools.i686: W: name-repeated-in-summary C minc-tools
Yeah, Summary is currently pretty much useless. What do those tools do? Current
%description can be almost used as Summary, and %description should be extended
to give some information about the capabilities of those tools.

minc-tools.i686: W: no-manual-page-for-binary minchistory
minc-tools.i686: W: no-manual-page-for-binary mincmorph
minc-tools.i686: W: no-manual-page-for-binary worldtovoxel
minc-tools.i686: W: no-manual-page-for-binary mincpik
minc-tools.src: W: name-repeated-in-summary C minc-tools
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281739] Review Request: python-libpagure - A Python library for Pagure APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281739

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
python-libpagure-0.5-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update python-libpagure'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-c386808c83

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285067] Review Request: python-pyxid - Python library for interfacing with Cedrus XID and StimTracker devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285067

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 970393] Review Request: foo2zjs - Driver for printers of various wire protocols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970393

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #32 from Fedora Update System  ---
foo2zjs-0.2015-3.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update foo2zjs'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-b6687a7b2d

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269539] Review Request: mozjs38 - JavaScript interpreter and libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269539

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #19 from Fedora Update System  ---
mozjs38-38.2.1-5.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update mozjs38'
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-7c2272a08a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1240116] Review Request: python-music21 - A toolkit for computational musicology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1240116



--- Comment #17 from William Moreno  ---
s390: http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=1993942
ppc:  http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=2935801
arm:  http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=3298023
copr:
https://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/142816/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1277388] Review Request: php-nette-php-generator - Nette PHP Generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277388



--- Comment #17 from Fedora Update System  ---
php-nette-php-generator-2.3.4-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281532] Review Request: Pagila - Example database for PostgreSQL

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281532



--- Comment #23 from Fedora Update System  ---
pagila-0.10.1-3.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1279176] Review Request: isis - Framework to access a large variety of image processing libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279176



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in isis-adapter-qt4
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

- Why is -applications and -tools seperate?

Rpmlint
---
Checking: isis-0.7.9-1.fc24.i686.rpm
  isis-devel-0.7.9-1.fc24.i686.rpm
  isis-tools-0.7.9-1.fc24.i686.rpm
  isis-applications-0.7.9-1.fc24.i686.rpm
  isis-adapter-qt4-0.7.9-1.fc24.i686.rpm
  isis-adapter-qt4-devel-0.7.9-1.fc24.i686.rpm
  isis-adapter-itk-devel-0.7.9-1.fc24.i686.rpm
  isis-debuginfo-0.7.9-1.fc24.i686.rpm
  isis-0.7.9-1.fc24.src.rpm
isis.i686: W: shared-lib-calls-exit /usr/lib/libisis_core.so.3.0.0
exit@GLIBC_2.0
Hm, probably an upstream bug.

isis.i686: W: no-documentation
isis-devel.i686: W: no-documentation
isis-devel.i686: E: incorrect-fsf-address
/usr/include/isis/CoreUtils/application.hpp
isis-tools.i686: W: spelling-error %description -l en_US informations ->
information, information's, in formations
Wow, I haven't seen a non-false-positive rpmlint spelling error in a long
while. But this is one. Please fix!

isis-tools.i686: W: spelling-error %description -l en_US imageIO -> image
isis-tools.i686: W: spelling-error %description -l en_US voxel -> vowel
isis-tools.i686: W: no-documentation
isis-tools.i686: W: no-manual-page-for-binary isisdump
isis-tools.i686: W: no-manual-page-for-binary isisflip
isis-tools.i686: W: no-manual-page-for-binary isisconv
isis-tools.i686: W: no-manual-page-for-binary isisraw
isis-tools.i686: W: no-manual-page-for-binary isisdiff
isis-applications.i686: W: spelling-error %description -l en_US voxels ->
vowels
isis-applications.i686: W: no-documentation
isis-applications.i686: W: no-manual-page-for-binary isiscalc
isis-adapter-qt4.i686: W: no-documentation
isis-adapter-qt4.i686: E: library-without-ldconfig-postin
/usr/lib/libisisAdapter_qt4.so.0.0.0
isis-adapter-qt4.i686: E: library-without-ldconfig-postun
/usr/lib/libisisAdapter_qt4.so.0.0.0
Right, see above.

isis-adapter-qt4-devel.i686: W: no-dependency-on
isis-adapter-qt4/isis-adapter-qt4-libs/libisis-adapter-qt4
There's a requirement though the library name, but I think you should add a
versioned dependency:
Requires:   isis-adapter-qt4%{?_isa} = %{version}-%{release}

isis-adapter-qt4-devel.i686: W: no-documentation
isis-adapter-qt4-devel.i686: E: incorrect-fsf-address
/usr/include/isis/Adapter/qmatrixconversion.hpp
isis-adapter-itk-devel.i686: W: no-documentation
isis-adapter-itk-devel.i686: E: incorrect-fsf-address
/usr/include/isis/Adapter/itkAdapter_impl.hpp
isis-adapter-itk-devel.i686: E: incorrect-fsf-address
/usr/include/isis/Adapter/itkAdapter.hpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Core/CoreUtils/application.hpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Core/CoreUtils/application.cpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Adapter/qt4/qmatrixconversion.hpp
isis-debuginfo.i686: E: incorrect-fsf-address
/usr/src/debug/isis-c76e32f08eb1fbe44ec1ea5c306c1f7d2c2a2900/lib/Adapter/qt4/qmatrixconversion.cpp
9 packages and 0 specfiles checked; 10 errors, 19 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review