[Bug 1293425] Review Request: python-ImcSdk - python lib for CRUD operations on Cisco IMC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293425



--- Comment #3 from Brian Demers  ---

Based on review I have:
- Removed the egg-info from the tarball
- regenerated sphinx doc (https://github.com/CiscoUcs/ImcSdk/issues/4) and
included doc dir in the package
- added a TODO about the %check section (current source tarball does not
properly run tests), and the current tests do nothing.
- Created sub-package for python2, (to allow for python3 package) current
source is not supported on python3 yet

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293156] Review Request: lxqt-sudo - GUI frontend for sudo/su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293156



--- Comment #5 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of lxqt-sudo-0.10.0-2.fc23.src.rpm for epel7
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12504784

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201338] Review Request: python-uniseg - A pure Python module to determine Unicode text segmentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201338

Murilo Opsfelder Araújo  changed:

   What|Removed |Added

  Flags|needinfo?(muri...@br.ibm.co |
   |m)  |



--- Comment #8 from Murilo Opsfelder Araújo  ---
(In reply to Upstream Release Monitoring from comment #7)
> mopsfelder's scratch build of python-uniseg-0.7.1-0.el6.src.rpm for rawhide
> completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12503363

(This level of automation scares me.  Thanks, Fedora guys!)

William, comment 7 has the build I submitted with the latest 0.7.1 version of
python-uniseg.

I'd appreciate if you can review it.  Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295129] Review Request: python-boto3 - The AWS SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295129



--- Comment #5 from Fabio Alessandro Locati  ---
Thanks a lot :-). I'll follow your suggestions!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295129] Review Request: python-boto3 - The AWS SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295129



--- Comment #4 from William Moreno  ---
Package Aproved
===

I am fine with this package but upstream provides some test, open a issue
upstream asking for include it in the tarball and ru the test in the build.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. 
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.

[Bug 1293425] Review Request: python-ImcSdk - python lib for CRUD operations on Cisco IMC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293425



--- Comment #2 from Brian Demers  ---
Spec URL: https://bdemers.fedorapeople.org/python-ImcSdk/2/python-ImcSdk.spec
SRPM URL:
https://bdemers.fedorapeople.org/python-ImcSdk/2/python-ImcSdk-0.7.2-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293156] Review Request: lxqt-sudo - GUI frontend for sudo/su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293156



--- Comment #6 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of lxqt-sudo-0.10.0-2.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12504727

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295129] Review Request: python-boto3 - The AWS SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295129

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281876] Review Request: enki - Extensible text editor for programmers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281876

Raphael Groner  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed|2015-12-16 04:53:54 |2016-01-11 16:54:26



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1272332] Review Request: openstack-ec2-api - Support of EC2 API for OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272332

hgue...@redhat.com changed:

   What|Removed |Added

 CC||marcos.fermin.l...@cern.ch
  Flags|needinfo?(karlthered@gmail. |needinfo?(marcos.fermin.lob
   |com)|o...@cern.ch)



--- Comment #11 from hgue...@redhat.com ---
Could you submit a PR to add openstack-ec2-api in rdoinfo ?
https://github.com/redhat-openstack/rdoinfo/pull/134 (here's a sample, choose
the core config and add your mail).

Then, you can just close this ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293156] Review Request: lxqt-sudo - GUI frontend for sudo/su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293156

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from William Moreno  ---
Packaged Aproved.


The install fails in mock but I fin with this packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268372] Review Request: openstack-app-catalog-ui - openstack horizon plugin for the openstack app-catalog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268372

Matthias Runge  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-01-11 04:27:00



--- Comment #30 from Matthias Runge  ---
closing this, since it seems to be included now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297347] New: Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347

Bug ID: 1297347
   Summary: Review Request: java-comment-preprocessor
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pkaj...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://pkajaba.fedorapeople.org/java-comment-preprocessor.spec
SRPM URL:
https://pkajaba.fedorapeople.org/java-comment-preprocessor-6.0.1-1.fc23.src.rpm
Description: The Multi-Pass Java Preprocessor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293909] Review Request: python-simplepath - A python library for data-structure lookups.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293909



--- Comment #7 from Upstream Release Monitoring 
 ---
suanand's scratch build of python-simplepath-0.3.2-1.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12496777

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293075] Review Request: lximage-qt - The image viewer and screenshot tool for lxqt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293075

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Alias|lximage-qt  |



--- Comment #5 from Raphael Groner  ---
Removing alias to allow searching for bugs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292794] Review Request: openstack-magnum - Container Management project for OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292794



--- Comment #8 from Mathieu Velten  ---
Hi,

Ok so I replaced with %{upstream_version} and I checked the dependencies : they
should now be fully in line with Mitaka M1 (git tag 1.1.0) release. However
according to the test run
(https://kojipkgs.fedoraproject.org//work/tasks/6396/12496396/build.log) it
looks like I need to put all the Requires as BuildRequires so the tests can be
executed, is it the normal way to do ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265628] Review Request: dhcpcd - A minimalistic network configuration daemon with DHCP and rdisc support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265628

Pavel Šimerda (pavlix)  changed:

   What|Removed |Added

   Assignee|i...@cicku.me  |nob...@fedoraproject.org



--- Comment #26 from Pavel Šimerda (pavlix)  ---
We need to get this package to Fedora for IPv6 testing[1] and the reviewer is
not responding in bugzilla nor in e-mails. Resetting assignee.

[1] https://fedoraproject.org/wiki/QA/Networking

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293909] Review Request: python-simplepath - A python library for data-structure lookups.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293909



--- Comment #8 from Sundeep Anand  ---
SPEC file updated:

Spec URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-simplepath.spec

SRPM URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-simplepath-0.3.2-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1272332] Review Request: openstack-ec2-api - Support of EC2 API for OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272332

Marcos  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(marcos.fermin.lob |
   |o...@cern.ch)  |
Last Closed||2016-01-12 02:52:35



--- Comment #12 from Marcos  ---
Hi Haikel,

Thank you, here is my PR https://github.com/redhat-openstack/rdoinfo/pull/137

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1289979] Review Request: rbm - Reproducible Build Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289979

Petr Pisar  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||rbm-0.4-1.20151206gitd50b2a
   ||6.fc24
 Resolution|--- |RAWHIDE
Last Closed||2016-01-12 02:42:13



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

I corrected the typos.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288731] Review Request: os-autoinst - OS-level test automation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288731



--- Comment #11 from awill...@redhat.com  ---
"Suggestion: %autosetup would obviate the need for individual %patch lines."

Yeah, it would, I can switch over at some point.

"Normally perl requires are autogenerated, but in this case all dependencies
are also in BuildRequires, so it makes sense to use the same list for both. So
doing it manually is fine. At least that's my understanding, I'm not much of a
perl person."

More or less, yeah. I think we also get auto-generated requires, but it all
works fine (duplicated requires aren't really a big deal). Again this is
something that comes from the SUSE spec (and is especially nice to keep in line
with upstream as it lets me catch when they add/remove dependencies easily).

"/usr/libexec/os-autoinst → shouldn't this be in /usr/lib64/perl5/vendor_perl"

That would be an upstream decision really (upstream explicitly installs to
libexecdir), but I think for one thing os-autoinst is not intended to be used
as a vendor module. If you want to ask upstream I can hook you up with them...

"/var/lib/os-autoinst/audio/aplay-1.wav → shouldn't this be
/usr/share/os-autoinst?"

possibly? I don't actually know what it's for. Again, though, if that's going
to change it would make the most sense to patch upstream's install routine, I
much prefer that to relocating things in downstream packages.

"os-autoinst.x86_64: E: version-control-internal-file
/usr/libexec/os-autoinst/distri/.gitignore"

I suspect this isn't in fact an error (openQA's general design expects various
bits to be checked out of git, and thus including .gitignores isn't necessarily
a mistake), but I think it may be functionally obsolete at this point. I'll
check with upstream.

I'll update this probably tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297274] Review Request: pulp - An application for managing software repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297274

Randy Barlow  changed:

   What|Removed |Added

 Blocks||1297622




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1297622
[Bug 1297622] Review Request: pulp-docker - Support for Docker content in
the Pulp platform
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297622] New: Review Request: pulp-docker - Support for Docker content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297622

Bug ID: 1297622
   Summary: Review Request: pulp-docker - Support for Docker
content in the Pulp platform
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rbar...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://rbarlow.fedorapeople.org/pulp-docker.spec
SRPM URL:
https://rbarlow.fedorapeople.org/pulp-docker-2.0.0-0.1.beta.1.fc24.src.rpm
Description: Provides a collection of Pulp server plugins and admin client
extensions to support Docker content.

Fedora Account System Username: rbarlow

rpmlint has no warnings or errors:

$ rpmlint
/home/rbarlow/rpmbuild/SRPMS/pulp-docker-2.0.0-0.1.beta.1.fc24.src.rpm
/home/rbarlow/rpmbuild/RPMS/noarch/pulp-docker-admin-extensions-2.0.0-0.1.beta.1.fc24.noarch.rpm
/home/rbarlow/rpmbuild/RPMS/noarch/pulp-docker-doc-2.0.0-0.1.beta.1.fc24.noarch.rpm
/home/rbarlow/rpmbuild/RPMS/noarch/pulp-docker-plugins-2.0.0-0.1.beta.1.fc24.noarch.rpm
/home/rbarlow/rpmbuild/RPMS/noarch/python2-pulp-docker-common-2.0.0-0.1.beta.1.fc24.noarch.rpm
5 packages and 0 specfiles checked; 0 errors, 0 warnings.

This package depends on the Pulp platform package, which is still in review.
Until that is accepted into Fedora, I am unable to perform a Koji scratch build
or test this package with fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297646] New: Review Request: nodejs-duplexer3 - Like duplexer but using streams3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297646

Bug ID: 1297646
   Summary: Review Request: nodejs-duplexer3 - Like duplexer but
using streams3
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: pnem...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-duplexer3.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-duplexer3-0.1.4-1.fc23.src.rpm

Description:
This is a reimplementation of duplexer using the Streams3 API which is
standard in Node as of v4. Everything largely works the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297646] Review Request: nodejs-duplexer3 - Like duplexer but using streams3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297646

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274948] Review Request: pki-usgov-dod-cacerts - A collection of U.S. Government CA Certs that DOD uses

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274948



--- Comment #3 from Upstream Release Monitoring 
 ---
spollei's scratch build of pki-usgov-dod-cacerts-0.0.5-1.fc23.src.rpm for f23
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12508401

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297629] Review Request: python-crane - A WSGI app providing a docker-registry-like API with redirection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297629



--- Comment #1 from Upstream Release Monitoring 
 ---
rbarlow's scratch build of python-crane-2.0.0-0.1.beta.1.fc24.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12509008

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297622] Review Request: pulp-docker - Support for Docker content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297622

Randy Barlow  changed:

   What|Removed |Added

 Depends On||1297274
   Assignee|nob...@fedoraproject.org|admil...@redhat.com




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1297274
[Bug 1297274] Review Request: pulp - An application for managing software
repositories
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297274] Review Request: pulp - An application for managing software repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297274



--- Comment #6 from Upstream Release Monitoring 
 ---
rbarlow's scratch build of pulp-2.8.0-0.1.beta.1.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12508634

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297622] Review Request: pulp-docker - Support for Docker content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297622



--- Comment #1 from Upstream Release Monitoring 
 ---
rbarlow's scratch build of pulp-2.8.0-0.1.beta.1.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12508634

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297629] New: Review Request: python-crane - A WSGI app providing a docker-registry-like API with redirection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297629

Bug ID: 1297629
   Summary: Review Request: python-crane - A WSGI app providing a
docker-registry-like API with redirection
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rbar...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://rbarlow.fedorapeople.org/python-crane.spec
SRPM URL:
https://rbarlow.fedorapeople.org/python-crane-2.0.0-0.1.beta.1.fc24.src.rpm
Description: This wsgi application exposes a read-only API similar to
docker-registry, which docker can use for "docker pull" operations. Requests
for actual image files are responded to with 302 redirects to a URL formed with
per-repository settings.
Fedora Account System Username: rbarlow

There are some rpmlint errors due to the Python package including web content
within the Python package space. I've filed an upstream issue to track this
problem: https://pulp.plan.io/issues/1511

Here is the rpmlint output:

python-crane.src: W: spelling-error %description -l en_US wsgi -> swig, wigs,
newsgirl
python2-crane.noarch: W: spelling-error %description -l en_US wsgi -> swig,
wigs, newsgirl
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-ExtraBoldItalic-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-Regular-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-Semibold-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-Light-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-ExtraBold-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-Italic-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/PatternFlyIcons-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-SemiboldItalic-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-BoldItalic-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-Bold-webfont.svg
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/css/jquery.min.map
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/js/jquery.js
python2-crane.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/crane/static/fonts/OpenSans-LightItalic-webfont.svg
2 packages and 0 specfiles checked; 13 errors, 2 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297629] Review Request: python-crane - A WSGI app providing a docker-registry-like API with redirection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297629

Randy Barlow  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|admil...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 953514] Review Request: varnish-vmod-querystring - QueryString VMOD for Varnish

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=953514



--- Comment #16 from Ingvar Hagelund  ---
For what it's worth, I have started some general vmod packaging for fedora and
epel: https://copr.fedoraproject.org/coprs/ingvar/varnish41/packages/

vmod-querystring is not ported to varnish-4.1 yet, so this bug may sleep until
that is done.

I may start to submit my copr packages to fedora when the vmod maintainers have
standardized on version numbering. For now, many of the version numbers in my
copr packages are pure guesswork. Upstream is working on this.

Ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292416] Review Request: nodejs-es5-ext - ECMAScript 5 extensions and ES6 shims

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292416
Bug 1292416 depends on bug 1292412, which changed state.

Bug 1292412 Summary: Review Request: nodejs-es6-symbol - ECMAScript 6 Symbol 
polyfill
https://bugzilla.redhat.com/show_bug.cgi?id=1292412

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292412] Review Request: nodejs-es6-symbol - ECMAScript 6 Symbol polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292412



--- Comment #12 from Fedora Update System  ---
nodejs-es6-symbol-3.0.2-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292412] Review Request: nodejs-es6-symbol - ECMAScript 6 Symbol polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292412

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-12-20 13:15:47 |2016-01-12 02:26:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292400] Review Request: nodejs-next-tick - Environment agnostic nextTick polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292400



--- Comment #14 from Fedora Update System  ---
nodejs-next-tick-0.2.2-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292424] Review Request: nodejs-d - Property descriptor factory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292424

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-12-20 11:04:37 |2016-01-12 02:26:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292424] Review Request: nodejs-d - Property descriptor factory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292424
Bug 1292424 depends on bug 1292416, which changed state.

Bug 1292416 Summary: Review Request: nodejs-es5-ext - ECMAScript 5 extensions 
and ES6 shims
https://bugzilla.redhat.com/show_bug.cgi?id=1292416

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292428] Review Request: nodejs-lru-queue - LRU queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292428
Bug 1292428 depends on bug 1292416, which changed state.

Bug 1292416 Summary: Review Request: nodejs-es5-ext - ECMAScript 5 extensions 
and ES6 shims
https://bugzilla.redhat.com/show_bug.cgi?id=1292416

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292425] Review Request: nodejs-es6-weak-map - ECMAScript6 WeakMap polyfill

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292425
Bug 1292425 depends on bug 1292424, which changed state.

Bug 1292424 Summary: Review Request: nodejs-d - Property descriptor factory
https://bugzilla.redhat.com/show_bug.cgi?id=1292424

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292149] Review Request: nodejs-cli-color - Colors, formatting and other tools for the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292149
Bug 1292149 depends on bug 1292416, which changed state.

Bug 1292416 Summary: Review Request: nodejs-es5-ext - ECMAScript 5 extensions 
and ES6 shims
https://bugzilla.redhat.com/show_bug.cgi?id=1292416

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292416] Review Request: nodejs-es5-ext - ECMAScript 5 extensions and ES6 shims

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292416



--- Comment #11 from Fedora Update System  ---
nodejs-es5-ext-0.10.10-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297274] Review Request: pulp - An application for managing software repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297274



--- Comment #4 from Upstream Release Monitoring 
 ---
rbarlow's scratch build of pulp-2.8.0-0.1.beta.fc24.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12508358

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297274] Review Request: pulp - An application for managing software repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297274



--- Comment #5 from Randy Barlow  ---
I have made one more change - I added another .1 after the beta in the release,
so that I have a place to raise my spec file version when needed until we reach
a normal Pulp release.

Spec URL: https://rbarlow.fedorapeople.org/pulp.spec
SRPM URL: https://rbarlow.fedorapeople.org/pulp-2.8.0-0.1.beta.1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297281] Review Request: endless-sky - Space exploration, trading, and combat game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297281



--- Comment #3 from Link Dupont  ---
Updated SPEC file with an enhanced patch that fixes the game at runtime when
looking for data files.

Spec URL:
https://fedorapeople.org/cgit/linkdupont/public_git/packages.git/tree/SPECS/endless-sky.spec
SRPM URL:
https://linkdupont.fedorapeople.org/srpms/endless-sky-0.8.10-4.fc23.src.rpm

koji build for 0.8.10-4:
http://koji.fedoraproject.org/koji/taskinfo?taskID=12509931

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297274] Review Request: pulp - An application for managing software repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297274

Randy Barlow  changed:

   What|Removed |Added

 CC||admil...@redhat.com
  Flags||needinfo?(admiller@redhat.c
   ||om)



--- Comment #3 from Randy Barlow  ---
Adam,

I now have a beta of the package, and I believe I have worked out a number of
spec file issues that were present in the first link I provided. Here is an
updated package:

Spec URL: https://rbarlow.fedorapeople.org/pulp.spec
SRPM URL: https://rbarlow.fedorapeople.org/pulp-2.8.0-0.1.beta.fc24.src.rpm

There are still a number of rpmlint issues. Most I think we can ignore, but
perhaps you can provide some insight about a few of them. I'll comment inline
as I did before:

$ rpmlint ~/rpmbuild/RPMS/noarch/p*
~/rpmbuild/SRPMS/pulp-2.8.0-0.1.beta.fc24.src.rpm pulp-admin-client.noarch: W:
conffile-without-noreplace-flag /etc/bash_completion.d/pulp-admin
pulp-consumer-client.noarch: W: conffile-without-noreplace-flag
/etc/bash_completion.d/pulp-consumer

IMO, the bash_completion isn't really a config file so it doesn't need
noreplace. Do you agree?

pulp-agent.noarch: E: zero-length /etc/pulp/agent/agent.conf

I filed this upstream: https://pulp.plan.io/issues/1497

pulp-consumer-client.noarch: E: non-readable /etc/pki/pulp/consumer/rsa.key 640
pulp-nodes-child.noarch: E: non-readable
/etc/pulp/server/plugins.conf.d/nodes/importer/http.conf 640
pulp-nodes-common.noarch: E: non-readable /etc/pulp/nodes.conf 640
pulp-server.noarch: E: non-readable /etc/pki/pulp/ca.key 640
pulp-server.noarch: E: non-readable /etc/pki/pulp/rsa.key 640
pulp-server.noarch: E: non-readable /etc/pulp/server.conf 640

These files all contain secrets (cryptographic keys or passwords) and so I
think being unreadable by world is required.

pulp-nodes-common.noarch: W: no-manual-page-for-binary
pulp-gen-nodes-certificate
pulp-server.noarch: W: no-manual-page-for-binary pulp-gen-ca-certificate
pulp-server.noarch: W: no-manual-page-for-binary pulp-manage-db
pulp-server.noarch: W: no-manual-page-for-binary pulp-qpid-ssl-cfg

I filed an issue for these upstream: https://pulp.plan.io/issues/1499

pulp-nodes-parent.noarch: W: dangling-symlink /var/www/pulp/nodes/content
/var/lib/pulp/content
pulp-server.noarch: W: dangling-symlink /var/www/pulp/nodes/https
/var/lib/pulp/nodes/published/https
pulp-server.noarch: W: dangling-symlink /var/www/pulp/nodes/http
/var/lib/pulp/nodes/published/http

I am puzzled by these. AFAICT, these symlinks are from one subpackage's owned
directory to another subpackage's directories. Does rpmlint not allow symlinks
across subpackages? Do you have any advice about this?

pulp-server.noarch: E: explicit-lib-dependency python-httplib2

I think this might just be a linter mistake due to this package having "lib" in
its name.

pulp-server.noarch: E: non-standard-dir-perm /var/log/pulp 750

We have had a number of bugs where secret information has gotten logged. We
decided that it was safest to make the logs as non-world readable. Is that
acceptable?

pulp-server.noarch: W: log-files-without-logrotate ['/var/log/pulp']

I've filed this issue upstream: https://pulp.plan.io/issues/1498

python2-pulp-streamer.noarch: W: empty-%postun

We used the %systemd_postun macro here, which seems to be empty. I didn't write
that part of our original spec, so I'm not 100% sure what it is there for. Do
you think I should just drop the %postun section since it's empty anyway?

20 packages and 0 specfiles checked; 9 errors, 11 warnings.

Thanks for your review, and sorry it was a little later than expected!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1251689] Review Request: java-scrypt - Java implementation of scrypt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1251689



--- Comment #8 from Jonny Heggheim  ---
Thanks for the review and the pointer. I have a question, since upstream have
tagged the release, should I use the tag name or the commit hash?

The Fedora wiki sugest this in the Git Tags section:
> Source0:  
> https://github.com/OWNER/%{name}/archive/GIT-TAG.tar.gz#/%{name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297552] New: Review Request: atomic-devmode - Try out Atomic Host without cloud-init

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297552

Bug ID: 1297552
   Summary: Review Request: atomic-devmode - Try out Atomic Host
without cloud-init
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jle...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Homepage: https://github.com/jlebon/atomic-devmode
Spec URL: https://jlebon.fedorapeople.org/atomic-devmode.spec
SRPM URL: https://jlebon.fedorapeople.org/atomic-devmode-0.1-1.fc23.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12502182

Fedora Account System Username: jlebon

Description (from specfile):

---
This package installs a Developer Mode boot option useful
for trying out an Atomic Host without having to set up a 
cloud-init source. When booted, the system automatically 
logs in and starts the Cockpit container.
---

More information on the motivation for this package can be found on the
atomic-devel mailing list:

https://lists.projectatomic.io/projectatomic-archives/atomic-devel/2015-December/msg00034.html

This is my first package and thus, I need a sponsor. I am also the upstream
maintainer for the project. Please let me know if I misfiled this, or if
there's something else I should do to get the review process going.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1285412] Review Request: nodejs-ebnf-parser - A parser for BNF and EBNF grammars used by jison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1285412

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-01-11 15:21:20



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1296302] Review Request: nodejs-jison - A parser generator with Bison's API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1296302
Bug 1296302 depends on bug 1285412, which changed state.

Bug 1285412 Summary: Review Request: nodejs-ebnf-parser - A parser for BNF and 
EBNF grammars used by jison
https://bugzilla.redhat.com/show_bug.cgi?id=1285412

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294275] Review Request: python-ivi - Python Interchangeable Virtual Instrument Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294275



--- Comment #10 from Fedora Update System  ---
python-ivi-0.14.9-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1f2bdb73c8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1286699] Review Request: python-django-multiselectfield - A multi-select form field and model for Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286699

William Moreno  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-01-11 16:11:15



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297552] Review Request: atomic-devmode - Try out Atomic Host without cloud-init

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297552



--- Comment #1 from Jonathan Lebon  ---
To clarify some more: this package is mainly meant for integration with Atomic
Hosts. Getting the package in the repo is the first step. Then the kickstart
files will have to be modified so that the boot menu item is added in the
default image.

If it will help, it should also be possible to make it compatible with the
Cloud images, so that users would be able to do, e.g.:

$ sudo dnf install atomic-devmode
$ sudo /usr/libexec/atomic-devmode/atomic-devmode-install
$ sudo reboot

and then select "Developer Mode" in the GRUB 2 menu.

However, being able to do the above means that you were able to get into the
system in the first place, which means that you already have cloud-init set up.
:)

A more realistic alternate use case for supporting regular Cloud images would
be e.g. someone who wants to build their own Cloud image which auto-logs in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293045] Review Request: fontopia - the console font editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293045



--- Comment #8 from Fedora Update System  ---
fontopia-1.1-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ca75e185d5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293045] Review Request: fontopia - the console font editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293045

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293045] Review Request: fontopia - the console font editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293045



--- Comment #9 from Fedora Update System  ---
fontopia-1.1-2.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1742894a43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169966] Review Request: rkt - CLI for running app containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1169966



--- Comment #40 from Lokesh Mandvekar  ---
$ gofed check-deps -v
import path github.com/appc/cni/pkg/invoke not found
import path github.com/appc/cni/pkg/ip not found
import path github.com/appc/cni/pkg/ipam not found
import path github.com/appc/cni/pkg/ns not found
import path github.com/appc/cni/pkg/skel not found
import path github.com/appc/cni/pkg/types not found
import path github.com/appc/cni/plugins/ipam/dhcp not found
import path github.com/appc/cni/plugins/ipam/host-local not found
import path github.com/appc/cni/plugins/main/bridge not found
import path github.com/appc/cni/plugins/main/ipvlan not found
import path github.com/appc/cni/plugins/main/macvlan not found
import path github.com/appc/cni/plugins/main/ptp not found
import path github.com/appc/cni/plugins/meta/flannel not found
import path github.com/appc/docker2aci/lib not found
import path github.com/appc/docker2aci/tarball not found
import path github.com/appc/goaci/proj2aci not found
package golang-github-appc-spec not found in golang.repos
package golang-github-appc-spec not found in golang.repos
package golang-github-appc-spec not found in golang.repos
package golang-github-appc-spec not found in golang.repos
import path github.com/appc/spec/pkg/acirenderer not found
import path github.com/appc/spec/pkg/device not found
package golang-github-appc-spec not found in golang.repos
package golang-github-appc-spec not found in golang.repos
import path github.com/bradfitz/http2 not found
import path github.com/camlistore/camlistore/pkg/errorutil not found
import path github.com/camlistore/lock not found
import path github.com/coreos/gexpect not found
import path github.com/coreos/go-iptables/iptables not found
Traceback (most recent call last):
  File "/usr/share/gofed/checkDeps.py", line 94, in 
ups_commits = modules.Repos.getRepoCommits(path, upstream,
pull=options.pull)
  File "/usr/share/gofed/modules/Repos.py", line 173, in getRepoCommits
os.chdir('/'.join(path.split('/')[:-1]))
OSError: [Errno 2] No such file or directory:
'/var/lib/gofed/packages/golang-github-coreos-go-semver/upstream/'


the traceback aside, i'm not sure why it says golang-github-appc-spec not
found, or does it mean something else? that package does exist on fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297550] New: Review Request: golang-github-jmespath-go-jmespath - Golang implementation of JMESPath

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297550

Bug ID: 1297550
   Summary: Review Request: golang-github-jmespath-go-jmespath -
Golang implementation of JMESPath
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: e...@logic.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/~logic/vault/golang-github-jmespath-go-jmespath/golang-github-jmespath-go-jmespath.spec
SRPM URL:
https://fedorapeople.org/~logic/vault/golang-github-jmespath-go-jmespath/golang-github-jmespath-go-jmespath-0.2.2-1.fc24.src.rpm
Description: Golang implementation of JMESPath
Fedora Account System Username: logic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295129] Review Request: python-boto3 - The AWS SDK for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295129



--- Comment #3 from William Moreno  ---
epel7: http://koji.fedoraproject.org/koji/taskinfo?taskID=12502598
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12502608

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 988648] Review Request: libunity - Unity instrumenting and integration library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988648

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||rdie...@math.unl.edu
 Resolution|--- |NOTABUG
Last Closed||2016-01-11 15:24:32



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297514] Review Request: python3-numpy - A fast multidimensional array facility for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297514



--- Comment #1 from Orion Poplawski  ---
https://copr.fedoraproject.org/coprs/g/python/python3_epel7/build/152862/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294275] Review Request: python-ivi - Python Interchangeable Virtual Instrument Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294275



--- Comment #9 from Fedora Update System  ---
python-ivi-0.14.9-3.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-745088385f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294275] Review Request: python-ivi - Python Interchangeable Virtual Instrument Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294275

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #9 from Fedora Update System  ---
python-ivi-0.14.9-3.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-745088385f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201338] Review Request: python-uniseg - A pure Python module to determine Unicode text segmentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201338



--- Comment #7 from Upstream Release Monitoring 
 ---
mopsfelder's scratch build of python-uniseg-0.7.1-0.el6.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12503363

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234



--- Comment #3 from Christian Dersch  ---
Added tests, replaced spec and src.rpm in place.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234



--- Comment #6 from Yanis Guenane  ---
I do see it now. Sorry for the noise.

Looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293909] Review Request: python-simplepath - A python library for data-structure lookups.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293909



--- Comment #9 from Upstream Release Monitoring 
 ---
suanand's scratch build of python-simplepath-0.3.2-1.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12498106

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297413] Review Request: python-importanize - Utility for organizing Python imports using PEP8 or custom rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297413

Sundeep Anand  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297413] New: Review Request: python-importanize - Utility for organizing Python imports using PEP8 or custom rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297413

Bug ID: 1297413
   Summary: Review Request: python-importanize - Utility for
organizing Python imports using PEP8 or custom rules
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: suan...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-importanize.spec
SRPM URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-importanize-0.4.1-1.fc23.src.rpm
Description: importanize allows to organize Python imports using PEP8 or
configuration file.
Fedora Account System Username: suanand

Upstream co-maintainer: zanata-python-client

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282903] Review Request: golang-github-sallyom-Register - Golang binary for registering OCI containers with systemd-machined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282903



--- Comment #10 from Jan Chaloupka  ---
Looks ok to me. It conforms to the current golang packaging draft.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234



--- Comment #4 from Yanis Guenane  ---
You're right it was the main astropy git repo. My bad.

Thanks for adding the %doc stanza.
Also you said you added tests but I still don't see any %check on the .spec,
anything I am missing ? Else LGTM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276960] Review Request: gimp-bimp-plugin - Batch Image Manipulation Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276960



--- Comment #2 from Maxim Orlov  ---
>Why do you create an empty configure script and then call it?

for Use configure:
%prep
...
echo '#!/bin/bash' > configure
chmod +x configure

%build
%configure
...

[maxim@localhost ~]$ rpm --eval %configure

  CFLAGS="${CFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic}" ; export
CFLAGS ; 
  CXXFLAGS="${CXXFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic}" ; export
CXXFLAGS ; 
  FFLAGS="${FFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-I/usr/lib64/gfortran/modules}" ; export FFLAGS ; 
  FCFLAGS="${FCFLAGS:--O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-I/usr/lib64/gfortran/modules}" ; export FCFLAGS ; 
  LDFLAGS="${LDFLAGS:--Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld}"; export LDFLAGS; 
  [ "1" = 1 ] && for i in $(find $(dirname ./configure) -name config.guess -o
-name config.sub) ; do 
  [ -f /usr/lib/rpm/redhat/$(basename $i) ] && /usr/bin/rm -f $i &&
/usr/bin/cp -fv /usr/lib/rpm/redhat/$(basename $i) $i ; 
  done ; 
  [ "1" = 1 ] && [ x != "x-specs=/usr/lib/rpm/redhat/redhat-hardened-ld" ] && 
  for i in $(find . -name ltmain.sh) ; do 
/usr/bin/sed -i.backup -e
's~compiler_flags=$~compiler_flags="-specs=/usr/lib/rpm/redhat/redhat-hardened-ld"~'
$i 
  done ; 
  ./configure --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu \
--program-prefix= \
--disable-dependency-tracking \
--prefix=/usr \
--exec-prefix=/usr \
--bindir=/usr/bin \
--sbindir=/usr/sbin \
--sysconfdir=/etc \
--datadir=/usr/share \
--includedir=/usr/include \
--libdir=/usr/lib64 \
--libexecdir=/usr/libexec \
--localstatedir=/var \
--sharedstatedir=/var/lib \
--mandir=/usr/share/man \
--infodir=/usr/share/info

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297411] Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Stanislav Ochotnicky  changed:

   What|Removed |Added

 Depends On||1296974



--- Comment #1 from Stanislav Ochotnicky  ---
I'll note this is not final version and will likely need tweaks as upstream
fixes up their pypi releases. But should be close enough for initial review. 

I have included py3 parts even if they are not used right now.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1296974
[Bug 1296974] Review Request: python-beanbag - A helper module for
accessing REST APIs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1296974] Review Request: python-beanbag - A helper module for accessing REST APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1296974

Stanislav Ochotnicky  changed:

   What|Removed |Added

 Blocks||1297411




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1297411
[Bug 1297411] Review Request: pdc-client - Client library and console
client for Product Definition Center
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297413] Review Request: python-importanize - Utility for organizing Python imports using PEP8 or custom rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297413



--- Comment #1 from Upstream Release Monitoring 
 ---
suanand's scratch build of python-importanize-0.4.1-1.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12497775

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276960] Review Request: gimp-bimp-plugin - Batch Image Manipulation Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276960



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Maxim Orlov from comment #2)
> >Why do you create an empty configure script and then call it?
> 
> for Use configure:

I'm aware what %configure expands too. But creating ./configure during build
is unusual, so I'm asking what is reason for doing that (why do you need
to do it).

(In reply to Maxim Orlov from comment #3)
> >find %{buildroot}%{_datadir}/locale/ -name "*.po" -delete
> 
> Using -delete instead of -exec rm -rf {} \; no change functional nor speed.
> I see no reason to change this.

It's shorter and doesn't call an external program.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297425] Review Request: python-contexttimer - A timer context manager measuring time of the code block it contains

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297425

Sundeep Anand  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297425] New: Review Request: python-contexttimer - A timer context manager measuring time of the code block it contains

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297425

Bug ID: 1297425
   Summary: Review Request: python-contexttimer - A timer context
manager measuring time of the code block it contains
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: suan...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-contexttimer.spec
SRPM URL:
https://bitbucket.org/sundeep_co_in/python-pkgs/downloads/python-contexttimer-0.3.1-1.fc23.src.rpm
Description: Utilities to quickly measure the execution time of a code block or
a function.
Fedora Account System Username: suanand

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297425] Review Request: python-contexttimer - A timer context manager measuring time of the code block it contains

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297425

Sundeep Anand  changed:

   What|Removed |Added

 Blocks||1297413




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1297413
[Bug 1297413] Review Request: python-importanize - Utility for organizing
Python imports using PEP8 or custom rules
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297413] Review Request: python-importanize - Utility for organizing Python imports using PEP8 or custom rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297413

Sundeep Anand  changed:

   What|Removed |Added

 Depends On||1297425




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1297425
[Bug 1297425] Review Request: python-contexttimer - A timer context manager
measuring time of the code block it contains
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234



--- Comment #5 from Christian Dersch  ---
Maybe browser cache? I get it with tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234



--- Comment #2 from Christian Dersch  ---
Thank you for commenting this. The upstream git you mentioned is astropy itself
(which we already have in Fedora). So: No docs (because there are no docs in
upstream tarball). Same for the doc files README, CHANGES and CONTRIBUTING.
They are not part of the tar of astropy-helpers.

I'll have a look at the tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276960] Review Request: gimp-bimp-plugin - Batch Image Manipulation Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276960



--- Comment #3 from Maxim Orlov  ---
>find %{buildroot}%{_datadir}/locale/ -name "*.po" -delete

Using -delete instead of -exec rm -rf {} \; no change functional nor speed. I
see no reason to change this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297425] Review Request: python-contexttimer - A timer context manager measuring time of the code block it contains

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297425



--- Comment #1 from Upstream Release Monitoring 
 ---
suanand's scratch build of python-contexttimer-0.3.1-1.fc23.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12498000

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293909] Review Request: python-simplepath - A python library for data-structure lookups.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293909

Sundeep Anand  changed:

   What|Removed |Added

 Depends On||1297413




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1297413
[Bug 1297413] Review Request: python-importanize - Utility for organizing
Python imports using PEP8 or custom rules
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297413] Review Request: python-importanize - Utility for organizing Python imports using PEP8 or custom rules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297413

Sundeep Anand  changed:

   What|Removed |Added

 Blocks||1293909




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1293909
[Bug 1293909] Review Request: python-simplepath - A python library for
data-structure lookups.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297234] Review Request: python-astropy-helpers - Utilities for building and installing Astropy and Astropy affiliated packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297234

Yanis Guenane  changed:

   What|Removed |Added

 CC||yguen...@redhat.com



--- Comment #1 from Yanis Guenane  ---
My review is yet unofficial as I am not part of the packager group.

Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= Issues =

> [ ]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.

Maybe the docs/ folder at https://github.com/astropy/astropy/tree/master/docs
could have its own subpackage -doc

> [ ]: %check is present and all tests pas

The upstream project provide tests. Anything that prevent running them here ?


Also, upstream provides README, CHANGES and CONTRIBUTING files that would fit
in a %doc.

= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 73 files have unknown
 license. Detailed output of licensecheck in /home/packager/review-
 python-astropy-helpers/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build
 process.
[ ]: A package which is used by another package via an egg interface should
 provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned 

[Bug 1297411] New: Review Request: pdc-client - Client library and console client for Product Definition Center

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297411

Bug ID: 1297411
   Summary: Review Request: pdc-client - Client library and
console client for Product Definition Center
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: socho...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://sochotni.fedorapeople.org//pdc-client.spec
SRPM URL: http://sochotni.fedorapeople.org//pdc-client-0.1.9-1.fc22.src.rpm

Description:
This client package contains two separate Product Definition Center clients and
API module. Both clients contain extensive built-in help. Just run the
executable with -h or --help argument.

1. pdc_client

This is a very simple client. Essentially this is just a little more convenient
than using curl manually. Each invocation of this client obtains a token and
then performs a single request.

This client is not meant for direct usage, but just as a helper for integrating
with PDC from languages where it might be easier than performing the network
requests manually.

2. pdc

This is much more user friendly user interface. A single invocation can perform
multiple requests depending on what subcommand you used.

The pdc client supports Bash completion if argcomplete Python package is
installed.

3. Python API (pdc_client)

When writing a client code interfacing with PDC server, you might find
pdc_client module handy. It provides access to the configuration defined above
and automates obtaining authorization token.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347

Pavel Raiskup  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||prais...@redhat.com
   Assignee|nob...@fedoraproject.org|prais...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1207938] Review Request: virglrenderer - 3D backend rendering library for qemu virtio GPU

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1207938

Marc-Andre Lureau  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-01-11 08:30:38



--- Comment #6 from Marc-Andre Lureau  ---
upstream for a while, closing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169966] Review Request: rkt - CLI for running app containers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1169966



--- Comment #35 from Tom "spot" Callaway  ---
Okay. I've looked through that, and outside of a lot of bundled go code, there
are no OS images that I could see. Thanks for following through on this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297491] New: Review Request: python2-multilib - A module for determining if a package is multilib or not

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297491

Bug ID: 1297491
   Summary: Review Request: python2-multilib - A module for
determining if a package is multilib or not
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jgreg...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://people.redhat.com/jgregusk/not-piracy/srpms/python2-multilib.spec
SRPM URL:
https://people.redhat.com/jgregusk/not-piracy/srpms/python2-multilib-1.1-1.fc23.src.rpm
Description: A Python module that supports several multilib "methods" useful
for determining if a 32-bit package should be included with its 64-bit analogue
in a compose.
Fedora Account System Username: jgreguske

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292794] Review Request: openstack-magnum - Container Management project for OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292794

Javier Peña  changed:

   What|Removed |Added

  Flags|needinfo?(jp...@redhat.com) |



--- Comment #9 from Javier Peña  ---
Hi Mathieu,

It is common that you need to put all Requires as BuildRequires to run tests,
that shows tests are comprehensive enough :).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1296974] Review Request: python-beanbag - A helper module for accessing REST APIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1296974

Ralph Bean  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #6 from Ralph Bean  ---
Looks good to me now.  Package Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292794] Review Request: openstack-magnum - Container Management project for OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292794

Stephen Gordon  changed:

   What|Removed |Added

 CC||sgor...@redhat.com
  Flags||needinfo?(jp...@redhat.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347



--- Comment #1 from Pavel Raiskup  ---
My major concern to ask for edit is to fix the packaging of license file which
is available in tarball.  See also the one trailing whitespace and
mixed-use-of-space-and-tabs catched by rpmlint.

Shortened fedora-review output:

= MUST items =

Generic:
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[!]: License file installed when any subpackage combination is installed.
[!]: Package complies to the Packaging Guidelines

= SHOULD items =

Generic:
[?]: Package functions as described.

praiskup: I'll test with 'postgresql-jdbc' build once Pavel gives me a patch.

[!]: %check is present and all tests pass.

praiskup: there seem to be testsuite within the pom.xml, if that is truth -
could we nable it?

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


attachments:
java-comment-preprocessor.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line
13, tab: line 1)
3 packages and 0 specfiles checked; 0 errors, 7 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297528] New: Review Request: golang-github-duosecurity-duo_api_golang - Duo Security API for strong two-factor authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297528

Bug ID: 1297528
   Summary: Review Request:
golang-github-duosecurity-duo_api_golang - Duo
Security API for strong two-factor authentication
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: e...@logic.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/~logic/vault/golang-github-duosecurity-duo_api_golang/golang-github-duosecurity-duo_api_golang.spec
SRPM URL:
https://fedorapeople.org/~logic/vault/golang-github-duosecurity-duo_api_golang/golang-github-duosecurity-duo_api_golang-0-0.1.git16da9e7.fc24.src.rpm
Description: The Duo Auth API provides a low-level API for adding strong
two-factor authentication to applications that cannot directly display rich web
content.
Fedora Account System Username: logic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297527] New: Review Request: perl-WWW-Twilio-API - Accessing Twilio's REST API with Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297527

Bug ID: 1297527
   Summary: Review Request: perl-WWW-Twilio-API - Accessing
Twilio's REST API with Perl
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: de...@fateyev.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-WWW-Twilio-API.spec
SRPM URL:
http://www.fateyev.com/RPMS/Fedora22/perl-WWW-Twilio-API-0.18-1.fc24.src.rpm
Description: WWW::Twilio::API aims to make connecting to and making REST calls
on the Twilio API easy, reliable, and enjoyable.
Fedora Account System Username: dfateyev

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=12499224 (Rawhide)
https://koji.fedoraproject.org/koji/taskinfo?taskID=12498753 (Fedora 23)
https://koji.fedoraproject.org/koji/taskinfo?taskID=12499086 (EPEL 7)
https://koji.fedoraproject.org/koji/taskinfo?taskID=12499075 (EPEL 6)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297529] New: Review Request: golang-github-fatih-structs - Utilities for Go structs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297529

Bug ID: 1297529
   Summary: Review Request: golang-github-fatih-structs -
Utilities for Go structs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: e...@logic.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/~logic/vault/golang-github-fatih-structs/golang-github-fatih-structs.spec
SRPM URL:
https://fedorapeople.org/~logic/vault/golang-github-fatih-structs/golang-github-fatih-structs-0-0.1.git9a77333.fc24.src.rpm
Description: Structs contains various utilities to work with Go (Golang)
structs.
Fedora Account System Username: logic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review