[Bug 1264654] Review Request: php-aws-sdk3 - Amazon Web Services framework for PHP (3.x)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264654



--- Comment #6 from Remi Collet  ---
Hmm... scratch build ok
http://koji.fedoraproject.org/koji/taskinfo?taskID=13679876

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1264654] Review Request: php-aws-sdk3 - Amazon Web Services framework for PHP (3.x)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264654

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #5 from Remi Collet  ---
you may want to switch autoloader without @include_once.

I have build failure during fedora-review.

It seems "phpunit -d memory_limit=1G ..." works, can you please check ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309782] Review Request: bugyou_plugins - Plugins and Services for Bugyou

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309782



--- Comment #43 from Fedora Update System  ---
bugyou_plugins-0.1.4-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a4cda29200

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309782] Review Request: bugyou_plugins - Plugins and Services for Bugyou

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309782

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 744416] Review Request: libisofs1 - Library to create ISO 9660 disk images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=744416

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|herr...@owlriver.com|nonamed...@gmail.com
  Flags|needinfo?(herrold@owlriver. |
   |com)|



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 744416] Review Request: libisofs1 - Library to create ISO 9660 disk images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=744416

Mukundan Ragavan  changed:

   What|Removed |Added

 CC||nonamed...@gmail.com



--- Comment #6 from Mukundan Ragavan  ---

Invoking "Policy for stalled package reviews" [1] here and taking up the
package for review.

[1] https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

William Moreno  changed:

   What|Removed |Added

  Flags|needinfo?(williamjmorenor@g |
   |mail.com)   |



--- Comment #16 from William Moreno  ---
Package Review
==

Issues:
===

1. Fedora review found:
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in knode, knode-libs, ktimetracker
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: sed
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1474560 bytes in 48 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
- update-desktop-database is invoked in %post and %postun if package
  contains desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in knode, ktimetracker
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database



2. Directory ownerhip issues:
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/lib64/kde4/plugins/accessible, /usr/share/dbus-1,
 /usr/share/dbus-1/interfaces

[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/kde4/apps/knode/pics(kdepim-common, knode),
 /usr/share/kde4/apps/libmessageviewer(kmail),
 /usr/lib64/kde4/plugins/grantlee/0.5(kmail, grantlee),
 /usr/share/kde4/apps/kdepimwidgets(kdepim-common),
 /usr/share/kde4/apps/messageviewer/themes/example(kmail),
 /usr/lib64/kde4/plugins/grantlee(kmail),
 /usr/share/kde4/apps/messageviewer(kmail),
 /usr/share/kde4/apps/kdepimwidgets/pics(kdepim-common),
 /usr/share/kde4/apps/messageviewer/themes/example_fancy(kmail),
 /usr/share/kde4/apps/knode(kdepim-common, knode),
 /usr/share/kde4/apps/libkleopatra/pics(kleopatra-libs),
 /usr/share/kde4/apps/messageviewer/about(kmail),
 /usr/share/kde4/apps/messageviewer/themes(kmail),
 /usr/share/kde4/apps/libmessageviewer/pics(kmail),
 /usr/share/kde4/apps/libkleopatra(kleopatra-libs)



3. Should be better to exclude this file:
knode.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/knode.svgz



4. This package ships many subpackages and I am currios about than there is not
any devel subpackage.

[!]: Development (unversioned) .so files in -devel subpackage, if present.
[!]: Development files must be in a -devel package

Unversioned so-files

knode: /usr/lib64/kde4/kcm_knode.so
knode: /usr/lib64/kde4/knodepart.so
knode-libs:
/usr/lib64/kde4/plugins/accessible/messagevieweraccessiblewidgetfactory.so
knode-libs: /usr/lib64/kde4/plugins/designer/kdepimwidgets.so
knode-libs: /usr/lib64/kde4/plugins/designer/mailcommonwidgets.so
knode-libs: /usr/lib64/kde4/plugins/designer/pimcommonwidgets.so
knode-libs:
/usr/lib64/kde4/plugins/grantlee/0.5/grantlee_messageheaderfilters.so
ktimetracker: /usr/lib64/kde4/kcm_ktimetracker.so
ktimetracker: /usr/lib64/kde4/ktimetrackerpart.so


5. Subpackages do not have a license text in the rpm.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[!]: License file installed when any subpackage combination is installed.


6- Some of this files can be moved to a common subpackage?
[!]: Large data in /usr/share should live in a noarch subpackage if package
 is arched.
 Note: Arch-ed rpms have a total of 2181120 bytes in /usr/share


7. Upstream link to sources is not working:
[!]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source0:

http://download.kde.org/stable/applications/4.14.10/src/kdepim-4.14.10.tar.xz
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags


8. There are a lot of these warnings:
unused-direct-shlib-dependency

= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 

[Bug 1277504] Review Request: apigen - PHP source code API generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277504

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
apigen-4.1.2-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe09dec891

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321825] Review Request: python-units - Python support for quantities with units

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321825

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
python-units-0.06-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f0c42bf1c8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323832] Review Request: kf5-kactivities-stats - A KDE Frameworks 5 Tier 3 library for accessing the usage data collected by the activities system.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323832

William Moreno  changed:

   What|Removed |Added

  Flags|needinfo?(williamjmorenor@g |
   |mail.com)   |



--- Comment #3 from William Moreno  ---
Package Review
==


1. kf5-kactivities-stats.x86_64: W: no-documentation
You can include MAINTAINER README.developers and TODO with %%docs

2. [!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/qt5,
 /usr/include/KF5, /usr/lib64/qt5/mkspecs, /usr/lib64/cmake,
 /usr/lib64/qt5/mkspecs/modules

Also rpmlint shows:
kf5-kactivities-stats-devel.x86_64: W: only-non-binary-in-usr-lib
kf5-kactivities-stats.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKF5ActivitiesStats.so.5.21.0 /lib64/libm.so.6
kf5-kactivities-stats.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libKF5ActivitiesStats.so.5.21.0 /lib64/libgcc_s.so.1

3. [!]: %check is present and all tests pass.
Source tarball hace a test directory than should be run in %check

4. Some rpmlint issues:
kf5-kactivities-stats.x86_64: W: summary-ended-with-dot C A KDE Frameworks 5
Tier 3 library for accessing the usage data collected by the activities system.
kf5-kactivities-stats.x86_64: E: summary-too-long C A KDE Frameworks 5 Tier 3
library for accessing the usage data collected by the activities system.
kf5-kactivities-stats.x86_64: E: description-line-too-long C A KDE Frameworks 5
Tier 3 library for accessing the usage data collected by the activities
system..

= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the 

[Bug 1326169] Review Request: php-league-climate - Allows you to easily output colored text, special formats, and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326169

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
php-league-climate-3.2.1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c47ed33fdf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1272527] Review Request: python-muranoclient - is a client library for Murano

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272527

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #17 from Fedora Update System  ---
python-muranoclient-0.8.4-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-99777522b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324367] Review Request: libkml - Reference implementation of OGC KML 2.2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324367

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
libkml-1.3.0-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-769b3cc6ff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326521] Review Request: php-akamai-open-edgegrid-client - Implements the Akamai {OPEN} EdgeGrid Authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326521

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
php-akamai-open-edgegrid-client-0.4.4-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-556664b74f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301063] Review Request: python-congressclient - OpenStack Congress client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301063

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
python-congressclient-1.2.1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6abd5312a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327784] New: Review Request: nauty - Graph canonical labeling and automorphism group computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327784

Bug ID: 1327784
   Summary: Review Request: nauty - Graph canonical labeling and
automorphism group computation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jjames.fedorapeople.org/nauty/nauty.spec
SRPM URL: https://jjames.fedorapeople.org/nauty/nauty-2.6.4-1.fc25.src.rpm
Fedora Account System Username: jjames
Description: Nauty and Traces are programs for computing automorphism groups of
graphs and digraphs. (At present, Traces does not accept digraphs.) They can
also produce a canonical label. They are written in a portable subset of C, and
run on a considerable number of different systems.

There is a small suite of programs called gtools included in the package. For
example, geng can generate non-isomorphic graphs very quickly. There are also
generators for bipartite graphs, digraphs, and multigraphs, and programs for
manipulating files of graphs in a compact format.

The Fedora package was modeled on the Debian package in hopes that cross-distro
compatibility might help consumers of this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347



--- Comment #9 from gil cattaneo  ---
Both, because using as BRs maven-local(*) is already available
as Rs (are automatically generated by JP-Ts)
Requires:  jpackage-utils
Requires:  java-headless >= 1:1.8
and BRs
BuildRequires: java-devel >= 1:1.8
BuildRequires: jpackage-utils (*)

(*)  sub package of javapackages-tools
(**) alias of javapackages-tools
Sorry for the noise

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326170] Review Request: php-aws-php-sns-message-validator - Amazon SNS message validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326170



--- Comment #10 from Fedora Update System  ---
php-aws-php-sns-message-validator-1.1.0-1.fc24 has been submitted as an update
to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-25a5f3c38d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327781] Review Request: golang-github-olivere-elastic - Elasticsearch client for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327781

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1256978




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1256978
[Bug 1256978] cadvisor-v0.22.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326170] Review Request: php-aws-php-sns-message-validator - Amazon SNS message validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326170

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326170] Review Request: php-aws-php-sns-message-validator - Amazon SNS message validation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326170



--- Comment #9 from Fedora Update System  ---
php-aws-php-sns-message-validator-1.1.0-1.fc23 has been submitted as an update
to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-922e255b00

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327781] New: Review Request: golang-github-olivere-elastic - Elasticsearch client for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327781

Bug ID: 1327781
   Summary: Review Request: golang-github-olivere-elastic -
Elasticsearch client for Go
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-olivere-elastic/golang-github-olivere-elastic.spec

SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-olivere-elastic/golang-github-olivere-elastic-2.0.12-0.1.git3cfe882.fc20.src.rpm

Description: Elasticsearch client for Go

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13675451

$ rpmlint golang-github-olivere-elastic-2.0.12-0.1.git3cfe882.fc20.src.rpm
golang-github-olivere-elastic-devel-2.0.12-0.1.git3cfe882.fc20.noarch.rpm
golang-github-olivere-elastic-unit-test-devel-2.0.12-0.1.git3cfe882.fc20.x86_64.rpm
golang-github-olivere-elastic.src: W: spelling-error Summary(en_US)
Elasticsearch -> Elastic search, Elastic-search, Elastically
golang-github-olivere-elastic.src: W: spelling-error %description -l en_US
Elasticsearch -> Elastic search, Elastic-search, Elastically
golang-github-olivere-elastic-devel.noarch: W: spelling-error Summary(en_US)
Elasticsearch -> Elastic search, Elastic-search, Elastically
golang-github-olivere-elastic-devel.noarch: W: spelling-error %description -l
en_US Elasticsearch -> Elastic search, Elastic-search, Elastically
golang-github-olivere-elastic-devel.noarch: W: spelling-error %description -l
en_US gopkg -> go pkg, go-pkg, GOP
golang-github-olivere-elastic-unit-test-devel.x86_64: W: spelling-error
%description -l en_US gopkg -> go pkg, go-pkg, GOP
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1300981] Review Request: python-django-rest-framework-braces - Utilities for working with Django-Rest-Framework.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1300981

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-15 17:36:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1318358] Review Request: copr-dist-git - Copr services for Dist Git server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318358



--- Comment #12 from Fedora Update System  ---
copr-dist-git-0.15-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1318358] Review Request: copr-dist-git - Copr services for Dist Git server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318358

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-15 17:36:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1300981] Review Request: python-django-rest-framework-braces - Utilities for working with Django-Rest-Framework.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1300981



--- Comment #13 from Fedora Update System  ---
python-django-rest-framework-braces-0.1.6-2.fc24 has been pushed to the Fedora
24 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327753] Review Request: golang-github-Shopify-toxiproxy - A proxy to simulate network and system conditions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327753

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1256978




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1256978
[Bug 1256978] cadvisor-v0.22.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go library for Apache Kafka 0.8 and 0.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327762



--- Comment #2 from Jan Chaloupka  ---
Tests depends on bz#1327753 which is on review as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go library for Apache Kafka 0.8 and 0.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327762

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1256978




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1256978
[Bug 1256978] cadvisor-v0.22.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324988] Review Request: python-lasagne - Lightweight library to build and train neural networks in Theano

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324988



--- Comment #13 from Fedora Update System  ---
python-lasagne-0.1-3.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270405] Review Request: native_client - Google Native Client Toolchain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270405
Bug 1270405 depends on bug 1270357, which changed state.

Bug 1270357 Summary: Review Request: nacl-gcc - Various compilers (C, C++) for 
nacl
https://bugzilla.redhat.com/show_bug.cgi?id=1270357

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270322] Review Request: chromium - A WebKit (Blink) powered web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270322
Bug 1270322 depends on bug 1270357, which changed state.

Bug 1270357 Summary: Review Request: nacl-gcc - Various compilers (C, C++) for 
nacl
https://bugzilla.redhat.com/show_bug.cgi?id=1270357

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324988] Review Request: python-lasagne - Lightweight library to build and train neural networks in Theano

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324988

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-15 17:34:04



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321438] Review Request: python-breathe - Doxygen xml output to reStructuredText

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321438



--- Comment #25 from Fedora Update System  ---
python-breathe-4.2.0-2.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270357] Review Request: nacl-gcc - Various compilers (C, C++) for nacl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270357

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-15 17:33:38



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270322] Review Request: chromium - A WebKit (Blink) powered web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270322
Bug 1270322 depends on bug 1270358, which changed state.

Bug 1270358 Summary: Review Request: nacl-newlib - C library intended for use 
on embedded systems
https://bugzilla.redhat.com/show_bug.cgi?id=1270358

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270358] Review Request: nacl-newlib - C library intended for use on embedded systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270358
Bug 1270358 depends on bug 1270357, which changed state.

Bug 1270357 Summary: Review Request: nacl-gcc - Various compilers (C, C++) for 
nacl
https://bugzilla.redhat.com/show_bug.cgi?id=1270357

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321438] Review Request: python-breathe - Doxygen xml output to reStructuredText

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321438

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-15 17:34:09



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270405] Review Request: native_client - Google Native Client Toolchain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270405
Bug 1270405 depends on bug 1270358, which changed state.

Bug 1270358 Summary: Review Request: nacl-newlib - C library intended for use 
on embedded systems
https://bugzilla.redhat.com/show_bug.cgi?id=1270358

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327526] Review Request: golang-github-klauspost-crc32 - CRC32 hash with x64 optimizations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327526

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1327762




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327762
[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go
library for Apache Kafka 0.8 and 0.9
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270358] Review Request: nacl-newlib - C library intended for use on embedded systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270358

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-15 17:33:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327307] Review Request: golang-github-eapache-go-resiliency - Resiliency patterns for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327307

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1327762




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327762
[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go
library for Apache Kafka 0.8 and 0.9
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270357] Review Request: nacl-gcc - Various compilers (C, C++) for nacl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270357



--- Comment #15 from Fedora Update System  ---
nacl-gcc-4.4.3-18.20150504gitf80d6b9.fc24,
nacl-newlib-2.1.0-9.20150528git8c4da47.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270358] Review Request: nacl-newlib - C library intended for use on embedded systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270358



--- Comment #12 from Fedora Update System  ---
nacl-gcc-4.4.3-18.20150504gitf80d6b9.fc24,
nacl-newlib-2.1.0-9.20150528git8c4da47.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221781

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-10-08 04:33:31 |2016-04-15 17:33:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1221781] Review Request: zipios - C++ library for reading and writing Zip files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1221781



--- Comment #54 from Fedora Update System  ---
zipios-2.1.1-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327254] Review Request: golang-github-eapache-queue - Fast golang queue using ring-buffer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327254

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1327762




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327762
[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go
library for Apache Kafka 0.8 and 0.9
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go library for Apache Kafka 0.8 and 0.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327762

Jan Chaloupka  changed:

   What|Removed |Added

 Depends On||1327307, 1327254, 1327526



--- Comment #1 from Jan Chaloupka  ---
Info: no Koji build as the package depends on bz#1327307, bz#1327254 and
bz#1327526 which are currently on review. Locally, it builds fine.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1327254
[Bug 1327254] Review Request: golang-github-eapache-queue - Fast golang
queue using ring-buffer
https://bugzilla.redhat.com/show_bug.cgi?id=1327307
[Bug 1327307] Review Request: golang-github-eapache-go-resiliency -
Resiliency patterns for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1327526
[Bug 1327526] Review Request: golang-github-klauspost-crc32 - CRC32 hash
with x64 optimizations
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327762] New: Review Request: golang-github-Shopify-sarama - Sarama is a Go library for Apache Kafka 0.8 and 0.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327762

Bug ID: 1327762
   Summary: Review Request: golang-github-Shopify-sarama - Sarama
is a Go library for Apache Kafka 0.8 and 0.9
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-Shopify-sarama/golang-github-Shopify-sarama.spec

SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-Shopify-sarama/golang-github-Shopify-sarama-1.7.0-0.1.git87ec8d7.fc20.src.rpm

Description: Sarama is a Go library for Apache Kafka 0.8 and 0.9

Fedora Account System Username: jchaloup

$ rpmlint golang-github-Shopify-sarama-1.7.0-0.1.git87ec8d7.fc20.src.rpm
golang-github-Shopify-sarama-devel-1.7.0-0.1.git87ec8d7.fc20.noarch.rpm
golang-github-Shopify-sarama-unit-test-devel-1.7.0-0.1.git87ec8d7.fc20.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327534] Review Request: golang-github-jmespath-go-jmespath - Golang implementation of JMESPath

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327534

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1256978




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1256978
[Bug 1256978] cadvisor-v0.22.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347



--- Comment #8 from Pavel Kajaba  ---
https://fedorapeople.org/cgit/pkajaba/public_git/java-comment-preprocessor.git/tree/java-comment-preprocessor.spec

Here is the most current version.

Which ones are unneded now?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327526] Review Request: golang-github-klauspost-crc32 - CRC32 hash with x64 optimizations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327526

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1256978




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1256978
[Bug 1256978] cadvisor-v0.22.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327753] New: Review Request: golang-github-Shopify-toxiproxy - A proxy to simulate network and system conditions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327753

Bug ID: 1327753
   Summary: Review Request: golang-github-Shopify-toxiproxy - A
proxy to simulate network and system conditions
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-Shopify-toxiproxy/golang-github-Shopify-toxiproxy.spec

SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-Shopify-toxiproxy/golang-github-Shopify-toxiproxy-2.0.0-0.1.rc2.gitfc5a9c0.fc20.src.rpm

Description: A proxy to simulate network and system conditions

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13674605

$ rpmlint golang-github-Shopify-toxiproxy-2.0.0-0.1.rc2.gitfc5a9c0.fc20.src.rpm
golang-github-Shopify-toxiproxy-devel-2.0.0-0.1.rc2.gitfc5a9c0.fc20.noarch.rpm
golang-github-Shopify-toxiproxy-unit-test-devel-2.0.0-0.1.rc2.gitfc5a9c0.fc20.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #5 from Matthias Runge  ---
Aha, that explains it. Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974



--- Comment #15 from Rex Dieter  ---
and FYI, reference to Copr I made for initial testing:
https://copr.fedorainfracloud.org/coprs/rdieter/kdepim4/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1306353] Review Request: libunity - Library for integrating with Unity and Plasma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306353



--- Comment #8 from Rex Dieter  ---
Fyi, Copr for initial testing:
https://copr.fedorainfracloud.org/coprs/rdieter/libunity/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323832] Review Request: kf5-kactivities-stats - A KDE Frameworks 5 Tier 3 library for accessing the usage data collected by the activities system.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323832

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #2 from Rex Dieter  ---
reviewer ping. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314974] Review Request: kdepim4 - KDE4 PIM (Personal Information Manager) applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314974

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(williamjmorenor@g
   ||mail.com)



--- Comment #14 from Rex Dieter  ---
reviewer ping :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #19 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #12)
> 6) As this package is licensed by multiple licenses, so add comment in spec
> file as required.

Not sure what you mean here? The spec file has the GPL and BSD license text in
the comments at the beginning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347



--- Comment #7 from gil cattaneo  ---
... and also BuildRequires:jpackage-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347



--- Comment #6 from gil cattaneo  ---
(In reply to Pavel Kajaba from comment #5)
> Thanks for additional review! I have removed redundant dependencies,
> dangerous dependencies and also removed useless lines.
> 
> Spec URL: https://pkajaba.fedorapeople.org/java-comment-preprocessor.spec
> SRPM URL:
> https://pkajaba.fedorapeople.org/java-comment-preprocessor-6.0.1-2.fc23.src.
> rpm
> 
> There is diff of changes: 
> https://fedorapeople.org/cgit/pkajaba/public_git/java-comment-preprocessor.
> git/commit/?id=30394edc5fbcead1da4b79cd84ae74e50d0b1204
Thanks for your work
See
https://fedorapeople.org/cgit/pkajaba/public_git/java-comment-preprocessor.git/tree/java-comment-preprocessor.spec?id=30394edc5fbcead1da4b79cd84ae74e50d0b1204#n21
please remove unneeded Requires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(dennis.dalessandr
   ||o...@intel.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347



--- Comment #5 from Pavel Kajaba  ---
Thanks for additional review! I have removed redundant dependencies, dangerous
dependencies and also removed useless lines.

Spec URL: https://pkajaba.fedorapeople.org/java-comment-preprocessor.spec
SRPM URL:
https://pkajaba.fedorapeople.org/java-comment-preprocessor-6.0.1-2.fc23.src.rpm

There is diff of changes: 
https://fedorapeople.org/cgit/pkajaba/public_git/java-comment-preprocessor.git/commit/?id=30394edc5fbcead1da4b79cd84ae74e50d0b1204

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #18 from dennis.dalessan...@intel.com ---
So I'm asking is it a hard requirement to use the newer package? If so, why? is
there a specific problem with the older version (which would be good to know
for other reasons), or is a general policy that the latest/greatest is required
for Fedora packages?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870



--- Comment #17 from Neil Horman  ---
Its a BuildRequires.  If someone is building the rpm they can adhere to the
levels Fedora requires. If they aren't using fedora, then they can modify the
spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags|needinfo?(dennis.dalessandr |
   |o...@intel.com)|



--- Comment #16 from dennis.dalessan...@intel.com ---
(In reply to Honggang LI from comment #12)
> 3) BuildRequires:  libibverbs-devel >= 1.2.0
> We had update libibverbs to latest upstream v1.2.0 for Fedora.

Do we really need to update this? There still may be systems that want to build
this RPM but have not upgraded to 1.2.0, not sure how we would handle that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #4 from Jan Chaloupka  ---
Building locally? Install latest rpms for
golang-github-smartystreets-assertions [1] and
golang-github-smartystreets-goconvey [2]

[1] http://koji.fedoraproject.org/koji/buildinfo?buildID=754528
[2] http://koji.fedoraproject.org/koji/buildinfo?buildID=754610

They are currently override in buildroot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1272527] Review Request: python-muranoclient - is a client library for Murano

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272527



--- Comment #16 from Fedora Update System  ---
python-muranoclient-0.8.4-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-99777522b1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1272527] Review Request: python-muranoclient - is a client library for Murano

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272527

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301063] Review Request: python-congressclient - OpenStack Congress client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301063

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301063] Review Request: python-congressclient - OpenStack Congress client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301063



--- Comment #14 from Fedora Update System  ---
python-congressclient-1.2.1-1.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6abd5312a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #3 from Matthias Runge  ---
Tests seem to be a bit unstable:
+ go test -compiler gc -ldflags '' github.com/go-ini/ini
# github.com/go-ini/ini
../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:666:
undefined: ShouldHaveLength
../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:673:
undefined: ShouldHaveLength
../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:680:
undefined: ShouldHaveLength
../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:687:
undefined: ShouldHaveLength
../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:694:
undefined: ShouldHaveLength
../../BUILDROOT/golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc25.x86_64/usr/share/gocode/src/github.com/go-ini/ini/ini_test.go:701:
undefined: ShouldHaveLength

It failed for me in mock, and on copr, but succeeded on koji scratchbuilds :/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1272527] Review Request: python-muranoclient - is a client library for Murano

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272527

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #15 from Marcos  ---
Hi,

python-muranoclient was successfully pushed to master, f24 and epel7
http://pkgs.fedoraproject.org/cgit/rpms/python-muranoclient.git/

Koji builds for rawhide (master) and f24 worked fine. For epel7 it failed due
to:

"Error: No Package found for python-oslo-sphinx >= 2.3.0"

More info here http://koji.fedoraproject.org/koji/taskinfo?taskID=13671457

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321455] Review Request: knot-resolver - Caching full DNS Resolver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321455

Tomas Hozza  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(tho...@redhat.com |
   |)   |



--- Comment #3 from Tomas Hozza  ---
(In reply to Jan Včelák from comment #2)
> Thank you. Updated.
> 
> Spec URL:
> https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot-
> resolver.spec
> SRPM URL:
> https://jvcelak.fedorapeople.org/review/knot-resolver/1.0.0-0.2.79a8440/knot-
> resolver-1.0.0-0.2.79a8440.fc23.src.rpm
> 
> 
> (In reply to Tomas Hozza from comment #1)
> > - Package does not contain duplicates in %files.
> >   Note: warning: File listed twice: /var/lib/kresd/root.keys
> >   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
> 
> Fixed.
>  
> > - Packages should try to preserve timestamps of original installed
> >   files.
> 
> Fixed.
>
> > - Files outside of /usr SHOULD be owned by root:root
> >   (https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)
> 
> I've changed UID to root where possible. And kept GID to kresd where
> necessary. Files inside /var/lib are state information and have to be
> writable by the daemon.
> 
> > - Fully versioned dependency in subpackages if applicable.
> >   Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in knot-
> >   resolver-devel
> 
> Fixed.
> 
> > - Once you resolve issues with building the documentation, please package is
> >   as well, because currently there is no man page for the daemon.
> 
> The documentation building can't be fixed easily. The RTD theme cannot be
> loaded by Python 2 Sphinx on Fedora, and Breathe is incompatible with Python
> 3.
> 
> I've updated the package to current git master because some of the building
> issues were resolved. The manual page is now installed. And unit tests
> results are temporarily ignored (one failure is present and should be fixed
> in the gold release).

Thank you for resolving the issues.

The package is APPROVED for Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #16 from paul.j.re...@intel.com ---
(In reply to Michal Schmidt from comment #12)
> Sure, go ahead and post the spec here.

I have posted the template for the spec file to this problem report.

Note that this template for the spec file is in two active reviews.  One
review, is internal here at Intel.  The other is in this problem report.

I will try to propagate comments back and forth to keep all parties informed of
all comments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #15 from paul.j.re...@intel.com ---
Created attachment 1147688
  --> https://bugzilla.redhat.com/attachment.cgi?id=1147688=edit
Template for specfile

This is the template for the spec file that we use to generate the
hfi1-psm.spec file.  We use sed to set various entities in the template that
changes such as @VERSION@ and @RELEASE@.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #14 from paul.j.re...@intel.com ---
Another comment, on comment 2:

>> %if 0%{?rhel}%{?rhl}%{?fedora}
>> Requires: libuuid
>> %else
>> Requires: libuuid1
>> %endif
>
> The binary package will automatically get a dependency on
> "libuuid.so.1()(64bit)", so there is no need for an explicit Requires.
> http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

Do you know if SUSE will automatically get the dependency on libuuid?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #13 from paul.j.re...@intel.com ---
Regarding comment 2, I received some serious pushback from a member of my team
here at Intel regarding this comment:

> Source0: %{name}-%{version}-%{release}.tar.gz
>
> Could you please use a full URL in the Source tag?
> http://fedoraproject.org/wiki/Packaging:SourceURL

I need to know if this _needs_ to be changed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 988667] Review Request: valadoc - Documentation tool for the vala project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988667

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Whiteboard|NotReady|



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 988667] Review Request: valadoc - Documentation tool for the vala project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=988667



--- Comment #29 from Zbigniew Jędrzejewski-Szmek  ---
I added your account the right group, you should have access to
fedorapeople.org in case you need it in the future
[https://fedoraproject.org/wiki/Infrastructure/fedorapeople.org].

> so if a user has a (maybe manually) installed version of Vala-0.20, then a 
> new file will be created during the build, 
You could just remove those files at the end of %install:
find %{buildroot}/%{_libdir}/valadoc/drivers/ -type f \! -path *%{version}*
-delete

Some issues from before which still aren't fixed:
(In reply to Raphael Groner from comment #19)
> Again, some general advice:
> 
> . You must use '%license COPYING', remove '%doc COPYING' instead.
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

> . There's no license for the sub packages (devel & data), make them
> 'Require: %{name}%{?_isa} = %{version}-%{release}'.
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Subpackage_Licensing 

> . I guess you want also add 'Require: %{name}-data%{?_isa} =
> %{version}-%{release}' into main package, or data could be merged completely
> into main, why another sub package? At least, add 'BuildArch: noarch' into
> data subpackage.
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Noarch_with_unported_dependencies

> . Remove 'Group: Development/Tools', it's deprecated.
> https://fedoraproject.org/wiki/
> How_to_create_an_RPM_package#SPEC_file_overview

> . You must provide a proper %changelog with at least some intial entry.
> https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1272530] Review Request: python-mistralclient - python client for Mistral REST API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272530

Haïkel Guémar  changed:

   What|Removed |Added

  Flags|needinfo?(asteroid566@gmail |fedora-review+
   |.com)   |
   |needinfo?(karlthered@gmail. |
   |com)|



--- Comment #7 from Haïkel Guémar  ---
I hereby approve this package into Fedora Packages Collection, please submit
SCM requestx



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 16 files have unknown license. Detailed output of
 licensecheck in /home/haikel/1272530-python-
 mistralclient/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-mistralclient , python-mistralclient-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does 

[Bug 1327635] Review Request: openstack-congress - OpenStack Congress Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327635

Marcos  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #1 from Marcos  ---
There is not successful scratch because python-olso-config version. See here
http://koji.fedoraproject.org/koji/taskinfo?taskID=13670962

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327635] New: Review Request: openstack-congress - OpenStack Congress Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327635

Bug ID: 1327635
   Summary: Review Request: openstack-congress - OpenStack
Congress Service
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: marcos.fermin.l...@cern.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-congress/3.0.0/openstack-congress.spec
SRPM URL:
http://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-congress/3.0.0/openstack-congress-3.0.0-1.fc25.src.rpm
Description: OpenStack Congress Service is an open policy framework for
OpenStack
Fedora Account System Username:mflobo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327635] Review Request: openstack-congress - OpenStack Congress Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327635

Marcos  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|karlthe...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326521] Review Request: php-akamai-open-edgegrid-client - Implements the Akamai {OPEN} EdgeGrid Authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326521



--- Comment #6 from Fedora Update System  ---
php-akamai-open-edgegrid-client-0.4.4-1.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4c43492ba8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326521] Review Request: php-akamai-open-edgegrid-client - Implements the Akamai {OPEN} EdgeGrid Authentication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326521



--- Comment #7 from Fedora Update System  ---
php-akamai-open-edgegrid-client-0.4.4-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-556664b74f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326169] Review Request: php-league-climate - Allows you to easily output colored text, special formats, and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326169



--- Comment #9 from Fedora Update System  ---
php-league-climate-3.2.1-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-256d1faef2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326169] Review Request: php-league-climate - Allows you to easily output colored text, special formats, and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326169



--- Comment #8 from Fedora Update System  ---
php-league-climate-3.2.1-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d127f0584e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326169] Review Request: php-league-climate - Allows you to easily output colored text, special formats, and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326169

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326169] Review Request: php-league-climate - Allows you to easily output colored text, special formats, and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326169



--- Comment #7 from Fedora Update System  ---
php-league-climate-3.2.1-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c47ed33fdf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326169] Review Request: php-league-climate - Allows you to easily output colored text, special formats, and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326169



--- Comment #6 from Fedora Update System  ---
php-league-climate-3.2.1-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0887b8cdff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1302904] Review Request: cacti - re-review

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302904

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
OK, looks good. Package is RE-(APPROVED).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301063] Review Request: python-congressclient - OpenStack Congress client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301063

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(karlthered@gmail.
   ||com)



--- Comment #13 from Marcos  ---
Hi,

python-congressclient was successfully pushed to master, f24 and epel7
http://pkgs.fedoraproject.org/cgit/rpms/python-congressclient.git/

Koji builds for rawhide (master) and f24 worked fine. For epel7 it failed due
to:

"Error: No Package found for python-oslo-sphinx >= 2.3.0"

More info here http://koji.fedoraproject.org/koji/taskinfo?taskID=13670964

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1302904] Review Request: cacti - re-review

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302904



--- Comment #9 from Morten Stevens  ---
Okay, please check the latest changes:

Updated SRPM:
https://mstevens.fedorapeople.org/cacti/cacti-0.8.8g-1.el7.src.rpm
Updated SPEC: https://mstevens.fedorapeople.org/cacti/cacti.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1318988] Review Request: java-1.8.0-openjdk-aarch32 - OpenJDK AArch32 porting project preview release

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318988



--- Comment #25 from jiri vanek  ---
ok. Upstream provided another tag:

https://jvanek.fedorapeople.org/java-1.8.0-openjdk-aarch32-jit/6/java-1.8.0-openjdk-aarch32-1.8.0.76-1.160415.fc24.src.rpm
https://jvanek.fedorapeople.org/java-1.8.0-openjdk-aarch32-jit/6/java-1.8.0-openjdk-aarch32.spec

looks mutch better: http://koji.fedoraproject.org/koji/taskinfo?taskID=13670361

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1316676] Review Request: tlog - terminal I/O logger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316676



--- Comment #15 from Nikolai Kondrashov  ---
Thanks, Jakub and Soumya!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326274] Review Request: golang-github-opencontainers-runtime-spec - Open Container Specifications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326274



--- Comment #8 from Fedora Update System  ---
golang-github-opencontainers-runtime-spec-0.4.0-0.1.git93ca97e.el6 has been
pushed to the Fedora EPEL 6 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7df688c8f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1322846] Review Request: SuperLUMT - Single precision real SuperLU routines for shared memory parallel machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1322846



--- Comment #19 from Fedora Update System  ---
SuperLUMT-3.1.0-5.el6 has been pushed to the Fedora EPEL 6 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4a2210296a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326151] Review Request: xfce4-calculator-plugin - A calculator plugin for the Xfce4 panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326151



--- Comment #13 from Fedora Update System  ---
xfce4-calculator-plugin-0.5.1-2.el6 has been pushed to the Fedora EPEL 6
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ecfd6df5ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297347] Review Request: java-comment-preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297347

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #4 from gil cattaneo  ---
The spec file is full of useless and dangerous things:
- useless:

already added by maven-local. please remove
BuildRequires:java-devel >= 1:1.8
Requires:java-headless >= 1:1.8


NO more necessary. please remove
Group:Documentation

%check (is NOT necessary. please remove)

please, use
%files javadoc -f .mfiles-javadoc
%license texts/LICENSE-2.0.txt

instead of

%files javadoc
%license texts/LICENSE-2.0.txt
%doc %{_javadocdir}/%{name} (is NOT necessary. please remove)

This:
%setup -c -q
mv -f %{name}-%{version}/* .

for me does not make sense, at least I can not explain it

- dangerous:
BuildRequires:maven-shade-plugin
is not safe introduce copy of system libraries into this or other artifact
for example if one of these have a "security problems". the
maintainer work would be compromised and the problem remain if this package is
not rebuilt every time a dependency is updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org