[Bug 1334112] Review Request: pintail - build web sites from plain text markup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1334112



--- Comment #1 from Pete Travis  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/immanetize/pintail/pintail.git/plain/pintail.spec?id=ec3733276d954ed9bf62d270c6501c2813e14b8c
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/immanetize/pintail/fedora-rawhide-x86_64/00266844-pintail/pintail-0.2-1.fc25.src.rpm

Now shipping a newer upstream tag, with added requires.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1319839] Review Request: rocket-depot - GTK+ 3 rdesktop/ xfreerdp front-end

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1319839

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
rocket-depot-1.0.0-2.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9039104b1f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1333970] Review Request: plasma-applet-redshift-control - Plasma 5 applet for redshift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333970



--- Comment #10 from Fedora Update System  ---
plasma-applet-redshift-control-1.0.17-1.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-97b9e0ad10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1333970] Review Request: plasma-applet-redshift-control - Plasma 5 applet for redshift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333970



--- Comment #9 from Fedora Update System  ---
plasma-applet-redshift-control-1.0.17-1.fc22 has been pushed to the Fedora 22
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2e29dc70b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327781] Review Request: golang-github-olivere-elastic - Elasticsearch client for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327781



--- Comment #6 from Fedora Update System  ---
golang-github-olivere-elastic-2.0.12-0.1.git3cfe882.el7 has been pushed to the
Fedora EPEL 7 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-121040bfb7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327307] Review Request: golang-github-eapache-go-resiliency - Resiliency patterns for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327307



--- Comment #6 from Fedora Update System  ---
golang-github-eapache-go-resiliency-0-0.1.gitb86b1ec.el7 has been pushed to the
Fedora EPEL 7 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d143126c5d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291390] Review Request: nodejs-graceful-readlink - The graceful fs.readlink functionality

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291390



--- Comment #16 from Fedora Update System  ---
nodejs-graceful-readlink-1.0.1-1.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291364] Review Request: nodejs-escape-string-regexp - Escape RegExp special characters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291364



--- Comment #15 from Fedora Update System  ---
nodejs-escape-string-regexp-1.0.3-2.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1278960] Review Request: nodejs-heap - Binary heap (priority queue) algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278960



--- Comment #18 from Fedora Update System  ---
nodejs-heap-0.2.6-4.el6 has been pushed to the Fedora EPEL 6 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291392] Review Request: nodejs-is-builtin-module - Check if a string matches the name of a Node.js builtin module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291392



--- Comment #14 from Fedora Update System  ---
nodejs-is-builtin-module-1.0.0-1.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1274738] Review Request: nodejs-nth-check - A performant nth-check parser & compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274738



--- Comment #19 from Fedora Update System  ---
nodejs-nth-check-1.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1333970] Review Request: plasma-applet-redshift-control - Plasma 5 applet for redshift

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333970

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
plasma-applet-redshift-control-1.0.17-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8198362676

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1325023] edk2: distribute ovmf/aavmf roms (now that licensing issues are resolved)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1325023

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #32 from Fedora Update System  ---
edk2-20160418gita8c39ba-0.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f7573e344

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
erlang-exometer_core-1.4-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d1a18110db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327307] Review Request: golang-github-eapache-go-resiliency - Resiliency patterns for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327307

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
golang-github-eapache-go-resiliency-0-0.1.gitb86b1ec.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-323ac73e11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327781] Review Request: golang-github-olivere-elastic - Elasticsearch client for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327781

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
golang-github-olivere-elastic-2.0.12-0.1.git3cfe882.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe542e196a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291364] Review Request: nodejs-escape-string-regexp - Escape RegExp special characters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291364



--- Comment #14 from Fedora Update System  ---
nodejs-escape-string-regexp-1.0.3-2.fc23 has been pushed to the Fedora 23
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291391] Review Request: nodejs-has-ansi - Check if a string has ANSI escape codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291391



--- Comment #15 from Fedora Update System  ---
nodejs-has-ansi-2.0.0-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291390] Review Request: nodejs-graceful-readlink - The graceful fs.readlink functionality

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291390



--- Comment #15 from Fedora Update System  ---
nodejs-graceful-readlink-1.0.1-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1274738] Review Request: nodejs-nth-check - A performant nth-check parser & compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274738



--- Comment #18 from Fedora Update System  ---
nodejs-nth-check-1.0.1-3.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314865] Review Request: booth - Ticket Manager for Multi-site Clusters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314865



--- Comment #21 from Fedora Update System  ---
booth-1.0-2.eb4256a.git.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1244571] Review Request: drush - Command line shell and scripting interface for Drupal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244571



--- Comment #16 from Fedora Update System  ---
drush-6.7.0-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291391] Review Request: nodejs-has-ansi - Check if a string has ANSI escape codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291391



--- Comment #14 from Fedora Update System  ---
nodejs-has-ansi-2.0.0-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291390] Review Request: nodejs-graceful-readlink - The graceful fs.readlink functionality

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291390



--- Comment #14 from Fedora Update System  ---
nodejs-graceful-readlink-1.0.1-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291392] Review Request: nodejs-is-builtin-module - Check if a string matches the name of a Node.js builtin module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291392



--- Comment #13 from Fedora Update System  ---
nodejs-is-builtin-module-1.0.0-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291364] Review Request: nodejs-escape-string-regexp - Escape RegExp special characters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291364



--- Comment #13 from Fedora Update System  ---
nodejs-escape-string-regexp-1.0.3-2.fc22 has been pushed to the Fedora 22
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1332206] Review Request: python-pysocks - A Python SOCKS client module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332206



--- Comment #12 from Fedora Update System  ---
python-pysocks-1.5.6-2.fc22, python-requests-2.10.0-1.fc22,
python-urllib3-1.15.1-1.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1314865] Review Request: booth - Ticket Manager for Multi-site Clusters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314865



--- Comment #20 from Fedora Update System  ---
booth-1.0-2.eb4256a.git.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1244571] Review Request: drush - Command line shell and scripting interface for Drupal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1244571



--- Comment #15 from Fedora Update System  ---
drush-6.7.0-1.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909

Orion Poplawski  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1295484



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321416] Review Request: gnome-shell-extension-mailnag - A Gnome-Shell extension for mailnag

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321416

philip.worr...@googlemail.com changed:

   What|Removed |Added

  Flags||needinfo?(bugzilla@heiko-ad
   ||ams.de)



--- Comment #3 from philip.worr...@googlemail.com ---
Hello,

Thanks for posting the SRPM.

I am NOT a fedora packager but i'm happy to carry out an informal review whilst
you look for a sponsor. Hopefully it can give some help on how you can improve
your package. Please check the items below.

Comments
==
* There is a newer version of this package listed as 3.20
(https://github.com/pulb/mailnag-gnome-shell/archive/v3.20.0.tar.gz)
* In your spec file you have some code referring to the git scm for this
package but i noticed that upstream is providing packaged releases. You might
want to simplyfy your spec file by removing the git sections and using the
upstream release tarballs as sources. 
* Since fedora 18 the Group tag is ignored. In any case other gnome shell
extensions in the repo use Group: User Interface/Desktops
* The upstream source package includes a LICENCE file, you should use %licence 
 in the %files section to include it.
* Similarly you might want to package the README.md file as documentation using
%doc.
* On the project's website vala is listed as a build dependency, you should add
this to the buildrequires section.
* At runtime this package appears to require the mailnag (>= 1.2) daemon. You
should add a dependency for it in the spec file.
* You should probably add a runtime dependency to gnome-tweak-tool so that
users can enable this extension through the gui. i.e. Requires:
gnome-tweak-tool
* In the files section,
%{_datadir}/gnome-shell/extensions/mail...@pulb.github.com/*, I think that you
can remove the asterisk at the end so that this package owns this folder.
* If you add a patch you should add a comment to explain what it does and list
it in the changelog. When i look at your patch it appears to allow version 3.18
of this package to register in gnome 3.20 but upstream say that you need
version 3.20 for gnome 3.20 support. I think if you update your spec file for
version 3.20 you can probably drop this patch altogether.
* The %clean section is unnecessary
* Does this package fail to build on any architectures supported by fedora?, if
so you should add an ExcludeArch tag for any said architectures.
* The %build section is unnecessary in this case
* When upgrading to a new upstream release you should set the release number
back to 1. From your changelog it looks like you forgot to do this when you
introduced version 3.18 and its still at 2.
* Its hard to say from the %description whether i *need* to install this
package. Maybe you should revise the description section (e.g use the
description used by the FSF or the related Debian package)...

This package provides GNOME Shell integration for Mailnag. 
It includes the following features: notifies about new 
mails via the messaging tray (including a counter badge),
shows an indicator in the top panel (including counter 
badge and popup menu) and supports lock screen integration.

* Compared with the mailnag extension listed on gnome.org an important feature
of 
this package is that it ships with support for avatars. You might want to list
this fact in the description.  


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "GPL (v2 or later)", "Unknown or generated".
 3 files have unknown license. Detailed output of licensecheck in
 /home/worralph/fedora-review/gnome-shell-extension-
 mailnag/licensecheck.txt
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/gnome-
 shell/extensions/mail...@pulb.github.com
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gnome-
 shell/extensions/mail...@pulb.github.com
[-]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: 

[Bug 1336555] New: Review Request: python3-pytz - World Timezone Definitions for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336555

Bug ID: 1336555
   Summary: Review Request: python3-pytz - World Timezone
Definitions for Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: or...@cora.nwra.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-pytz.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-pytz-2016.4-1.el7.src.rpm
Description:
pytz brings the Olson tz database into Python. This library allows accurate
and cross platform timezone calculations using Python 2.3 or higher. It
also solves the issue of ambiguous times at the end of daylight savings,
which you can read more about in the Python Library Reference
(datetime.tzinfo).

Almost all (over 540) of the Olson timezones are supported.

Fedora Account System Username: orion

This is for EPEL7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552

Christoph Junghans  changed:

   What|Removed |Added

   See Also||https://github.com/losalamo
   ||s/flecsi/issues/74



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552

Christoph Junghans  changed:

   What|Removed |Added

URL||http://koji.fedoraproject.o
   ||rg/koji/taskinfo?taskID=141
   ||15052



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336552] New: Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552

Bug ID: 1336552
   Summary: Review Request: exodusii - Library to store and
retrieve transient finite element data
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jungh...@votca.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/junghans/fedora-review/master/exodusii/exodusii.spec
SRPM URL:
https://github.com/junghans/fedora-review/raw/master/exodusii/exodusii-6.02-0.src.rpm
Description: EXODUS II is a model developed to store and retrieve data for
finite element analyses. It is used for preprocessing (problem definition),
postprocessing
(results visualization), as well as code to code data transfer. An EXODUS II
data file is a random access, machine independent, binary file that is written
and read via C, C++, or Fortran library routines which comprise the
Application Programming Interface (API).

Fedora Account System Username: junghans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1203380] Review Request: gherkin2-java - A fast lexer and parser for the Gherkin language based on Ragel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1203380



--- Comment #9 from gil cattaneo  ---
(In reply to Raphael Groner from comment #8)
> Looks good. Thanks!
> 
> Issues:
> ===
> - Sources used to build the package match the upstream source, as provided
>   in the spec URL.
>   Note: Upstream MD5sum check error, diff is in /home/builder/fedora-
>   review/1203380-gherkin2-java/diff.txt
>   See: http://fedoraproject.org/wiki/Packaging/SourceURL
> => Please fix.
> 
> $ cat /home/builder/fedora-review/1203380-gherkin2-java/diff.txt
> Nur in
> /home/builder/fedora-review/1203380-gherkin2-java/srpm-unpacked/v2.12.2.tar.
> gz-extract: gherkin-2.12.2.
> Nur in
> /home/builder/fedora-review/1203380-gherkin2-java/upstream-unpacked/Source0:
> gherkin2-2.12.2.

Done

Spec URL: https://gil.fedorapeople.org/gherkin2-java.spec
SRPM URL: https://gil.fedorapeople.org/gherkin2-java-2.12.2-2.fc23.src.rpm

thanks for the review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291391] Review Request: nodejs-has-ansi - Check if a string has ANSI escape codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291391

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 15:07:02



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291390] Review Request: nodejs-graceful-readlink - The graceful fs.readlink functionality

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291390



--- Comment #13 from Fedora Update System  ---
nodejs-graceful-readlink-1.0.1-1.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1278960] Review Request: nodejs-heap - Binary heap (priority queue) algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278960

Fedora Update System  changed:

   What|Removed |Added

 Resolution|NOTABUG |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1274738] Review Request: nodejs-nth-check - A performant nth-check parser & compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274738

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 15:06:30



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291390] Review Request: nodejs-graceful-readlink - The graceful fs.readlink functionality

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291390

Fedora Update System  changed:

   What|Removed |Added

 Resolution|CURRENTRELEASE  |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291391] Review Request: nodejs-has-ansi - Check if a string has ANSI escape codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291391



--- Comment #13 from Fedora Update System  ---
nodejs-has-ansi-2.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291364] Review Request: nodejs-escape-string-regexp - Escape RegExp special characters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291364

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 15:06:51



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1278960] Review Request: nodejs-heap - Binary heap (priority queue) algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278960



--- Comment #17 from Fedora Update System  ---
nodejs-heap-0.2.6-4.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291392] Review Request: nodejs-is-builtin-module - Check if a string matches the name of a Node.js builtin module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291392

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 15:06:39



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1274738] Review Request: nodejs-nth-check - A performant nth-check parser & compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274738



--- Comment #17 from Fedora Update System  ---
nodejs-nth-check-1.0.1-3.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291364] Review Request: nodejs-escape-string-regexp - Escape RegExp special characters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291364



--- Comment #12 from Fedora Update System  ---
nodejs-escape-string-regexp-1.0.3-2.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291392] Review Request: nodejs-is-builtin-module - Check if a string matches the name of a Node.js builtin module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291392



--- Comment #12 from Fedora Update System  ---
nodejs-is-builtin-module-1.0.0-1.el7 has been pushed to the Fedora EPEL 7
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321416] Review Request: gnome-shell-extension-mailnag - A Gnome-Shell extension for mailnag

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321416

Heiko Adams  changed:

   What|Removed |Added

  Flags|needinfo?(bugzilla@heiko-ad |
   |ams.de) |



--- Comment #2 from Heiko Adams  ---
http://repo.heiko-adams.de/gnome-shell-extension-mailnag-3.18.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335654] Review Request: shim-aarch64 - UEFI shim for aarch64

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335654



--- Comment #5 from Peter Jones  ---
Sure, I'll go with shim-unsigned-aarch64.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630

philip.worr...@googlemail.com changed:

   What|Removed |Added

 CC||philip.worrall@googlemail.c
   ||om



--- Comment #2 from philip.worr...@googlemail.com ---
Hello Jakub,

I am NOT an official packager but i have tried to do an informal review.

The application installs but just running it for a few minutes I noticed a
couple of key bugs. For example the wallpaper of the day does not work because
some of the websites images are fetched from now use https. Furthermore, I
couldn't get wallpaper clocks to work either.

I think the upstream have stopped doing regular releases but you can find a
more recent (non-released) revision in launchpad where a couple of these issues
have been fixed. I started to modify the specfile (adding a generate-tarball
script to checkout the latest revision from launchpad) but it wont build until
your patches are rebased on the later revision i.e. the dependency on unity
needs removing. I started to have a look at this but its not trivial because a
lot of files have been moved around.

I have attached the script i wrote, id be happy to take another look if you
revised your patches against the newer revision of this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1293630] Review Request: wallch - A wallpaper changer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293630



--- Comment #1 from philip.worr...@googlemail.com ---
Created attachment 1158061
  --> https://bugzilla.redhat.com/attachment.cgi?id=1158061=edit
generate tarball from launchpad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335654] Review Request: shim-aarch64 - UEFI shim for aarch64

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335654

Peter Robinson  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #3 from Peter Robinson  ---

So mostly fine. Just a couple of queries around package naming, should probably
be called shim-unsigned-aarch64 with provides/obsoletes for shim-unsigned to
avoid conflicts and smooth upgrade, but other than that all OK.

shim-aarch64-0.9-1.fc25.src.rpm
shim-unsigned-0.9-1.fc25.aarch64.rpm



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "BSD (2 clause)", "*No copyright* BSD",
 "Unknown or generated". 396 files have unknown license. Detailed
 output of licensecheck in /home/pjones/shim-aarch64/1335654-shim-
 aarch64/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[ ]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = 

[Bug 1335654] Review Request: shim-aarch64 - UEFI shim for aarch64

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335654

Peter Robinson  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335654] Review Request: shim-aarch64 - UEFI shim for aarch64

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335654



--- Comment #4 from Peter Robinson  ---
Other than the naming query APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252812



--- Comment #20 from Fedora Update System  ---
python-gabbi-1.19.0-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329845] Review Request: erlang-eflame - Flame Graph profiler for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329845



--- Comment #5 from Fedora Update System  ---
erlang-eflame-0-0.1.gita085181.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329848] Review Request: erlang-parse_trans - Parse transform utilities for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329848

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:27:37



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846
Bug 1329846 depends on bug 1329848, which changed state.

Bug 1329848 Summary: Review Request: erlang-parse_trans - Parse transform 
utilities for Erlang
https://bugzilla.redhat.com/show_bug.cgi?id=1329848

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329848] Review Request: erlang-parse_trans - Parse transform utilities for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329848



--- Comment #6 from Fedora Update System  ---
erlang-parse_trans-2.9.2-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846
Bug 1329846 depends on bug 1329852, which changed state.

Bug 1329852 Summary: Review Request: erlang-setup - Generic setup utility for 
Erlang-based systems
https://bugzilla.redhat.com/show_bug.cgi?id=1329852

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329847] Review Request: erlang-kvc - Key Value Coding for Erlang data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329847

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:27:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329847] Review Request: erlang-kvc - Key Value Coding for Erlang data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329847



--- Comment #5 from Fedora Update System  ---
erlang-kvc-1.7.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329845] Review Request: erlang-eflame - Flame Graph profiler for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329845

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:27:31



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329852] Review Request: erlang-setup - Generic setup utility for Erlang-based systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329852



--- Comment #5 from Fedora Update System  ---
erlang-setup-1.7-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329852] Review Request: erlang-setup - Generic setup utility for Erlang-based systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329852

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:27:56



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1252812] Review Request: python-gabbi - Declarative HTTP testing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252812

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:25:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329849] Review Request: erlang-riak_dt - Convergent replicated data types in Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329849

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:22:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329849] Review Request: erlang-riak_dt - Convergent replicated data types in Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329849



--- Comment #5 from Fedora Update System  ---
erlang-riak_dt-2.1.2-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329850] Review Request: erlang-riak_ensemble - Multi-Paxos framework in Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329850

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:21:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329850] Review Request: erlang-riak_ensemble - Multi-Paxos framework in Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329850



--- Comment #7 from Fedora Update System  ---
erlang-riak_ensemble-2.1.2-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424



--- Comment #20 from Fedora Update System  ---
gimp-save-for-web-0.29.3-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-05-16 12:19:29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335654] Review Request: shim-aarch64 - UEFI shim for aarch64

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335654



--- Comment #2 from Peter Jones  ---
And the review.txt is here:
http://pjones.fedorapeople.org/shim-aarch64/review.txt

As always, it is filled with misleading results.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335654] Review Request: shim-aarch64 - UEFI shim for aarch64

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335654

Peter Robinson  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||pbrobin...@gmail.com
 QA Contact|extras...@fedoraproject.org |pbrobin...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1279091] Review Request: openra-eluant - Lua C# bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279091

Raphael Groner  changed:

   What|Removed |Added

Summary|Review Request: eluant - C# |Review Request:
   |bindings for Lua with a |openra-eluant - Lua C#
   |specific focus on building  |bindings
   |sandboxes   |
  Alias|eluant  |openra-eluant
 Whiteboard|NotReady|



--- Comment #2 from Raphael Groner  ---
Spec URL: https://raphgro.fedorapeople.org/review/openra/openra-eluant.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/openra/openra-eluant-20160124-1.src.rpm
Description: Lua C# bindings
Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14110187

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321416] Review Request: gnome-shell-extension-mailnag - A Gnome-Shell extension for mailnag

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321416

philip.worr...@googlemail.com changed:

   What|Removed |Added

 CC||bugzi...@heiko-adams.de,
   ||philip.worrall@googlemail.c
   ||om
  Flags||needinfo?(bugzilla@heiko-ad
   ||ams.de)



--- Comment #1 from philip.worr...@googlemail.com ---
Hi, the SRPM url is not valid. Please post a URL where we can find the SRPM
package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336458] Review Request: gplcver - interpreted Verilog simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336458

Mamoru TASAKA  changed:

   What|Removed |Added

 CC||chitl...@gmail.com,
   ||jaromir.ca...@email.cz,
   ||mtas...@fedoraproject.org
  Component|Package Review  |gplcver
   Assignee|nob...@fedoraproject.org|jaromir.ca...@email.cz



--- Comment #1 from Mamoru TASAKA  ---
Please describe in detail
- the detailed, exact step-by-step procedure to reproduce the issue you are
seeing
- The exact issue you are seeing (if it segfaults, adding backtrace or so is
also appreciated)
- The expected behavior
- How reproducible the issue is

so that the current maintainers (or potential sponsors) can examine the issue
or the patch you are trying to provide.

Once changing the component to gplcver. Adding myself as CC in case that
gplcver maintainers get nonresponsive.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336458] Review Request: gplcver - interpreted Verilog simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336458

Mamoru TASAKA  changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1315870

dennis.dalessan...@intel.com changed:

   What|Removed |Added

  Flags||needinfo?(nhor...@redhat.co
   ||m)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331175] Review Request: yadm - Yet Another Dotfiles Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331175

philip.worr...@googlemail.com changed:

   What|Removed |Added

 CC||philip.worrall@googlemail.c
   ||om
  Flags||needinfo?(sultan@locehilios
   ||.com)



--- Comment #2 from philip.worr...@googlemail.com ---

Hello,

This is an INFORMAL review as I am NOT an official fedora packager.

* The licence is included in the source tarball but not in the files section of
the spec file.
* It's not necessary to use %defattr in the files section anymore
* If the source code of the package provides a test suite, it should be
executed in the %check 
section, whenever it is practical to do so.

* Do you need to list bats as a build dependency for the testsuite?
* Do you need to list gnupg2 as a dependency?
* You should add the dist tag to your release version i.e. 1%{?dist}
* In the changelog you MAY want to indicate that this is the initial fedora
packaged version

* Is Yadm only for managing dot files or is it for any type of file? 

* In your man page the description is..

Yadm is a tool for managing a collection of files across multiple computers
using a shared Git repository. In addition, yadm provides a feature to select 
alternate versions of files based on the operation system or host name.
Lastly, yadm supplies the ability to manage a subset of secure files, 
which are encrypted before they are included in the repository.

I think this is better than the description listed in the spec file. Try to
make it clear 
to the user why they would *need* this package i.e. what problem can it solve.

* The Group tag is deprecated. RPM since Fedora 18 does not require the
presence 
of the Group tag in the spec file. If the tag is defined, it will be ignored.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Dist tag is present.


= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3)", "Unknown or generated". 6 files have unknown
 license. Detailed output of licensecheck in /home/worralph/fedora-
 review/yadm/licensecheck.txt
[-]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: 

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846



--- Comment #5 from Fedora Update System  ---
erlang-exometer_core-1.4-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d1a18110db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
> # LGPLv3+: src/Fl_GDI_Printer.cxx, src/Flv_List.cc, src/Flv_Table.cc
> # BSD: src/tinymt32*
> License:   GPLv3+ and LGPLv3+ and BSD

Are files under BSD and LGPLv3+ and GPLv3+ combined into a single compiled
binary? Then the license is just GPLv3+. The "License" tag is about the binary
rpm, not the sources.

s/french/French/

I'm afraid you'll have to repack the tarball to remove the non-free doc part,
because the SRPM must be distributable. Removing it during package build is too
late.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336458] Review Request: gplcver - interpreted Verilog simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336458

Dr Jonathan Kimmitt  changed:

   What|Removed |Added

 CC||jonat...@kimmitt.uk
Version|rawhide |23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336458] New: Review Request: gplcver - interpreted Verilog simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336458

Bug ID: 1336458
   Summary: Review Request: gplcver - interpreted Verilog
simulator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jonat...@kimmitt.uk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://technophobia.org/repo/SRPMS/gplcver.spec
SRPM URL: http://technophobia.org/repo/SRPMS/gplcver-2.12a-12.fc23.src.rpm
Description: Partial fix for existing broken package
Fedora Account System Username: jrrk2

For attention of jcapik or chitlesh

The existing gplcver package in FC23 is not 64-bit clean. This causes it to
fail immediately. This patched version provides a partial fix by making the
32-bit build avoid calling stat/fstat and encountering the problem. It does
nothing to address the problems of the 64-bit build. I appreciate the user base
for this package is limited which is probably why it has not been noticed
before.

copr info for future use is dnf copr enable jrrk2/gplcver 

Applying for sponsorship as co-maintainer and/or for the package maintainer to
adopt my changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1279090] Review Request: sdl2-cs - C# wrapper for SDL2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279090



--- Comment #3 from Matthias Mailänder  ---
We removed the need to contain MiniTK in
https://github.com/OpenRA/SDL2-CS/releases/tag/20151227 See
https://github.com/OpenRA/OpenRA/pull/10288 and
https://github.com/OpenRA/OpenRA/pull/10299 It got replaced by custom OpenGL
bindings. Note that OpenRA now also needs https://github.com/OpenRA/OpenAL-CS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326277] Review Request: ocitools - Collection of tools for working with the OCI runtime specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326277

Lokesh Mandvekar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Lokesh Mandvekar  ---
looks good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327307] Review Request: golang-github-eapache-go-resiliency - Resiliency patterns for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327307



--- Comment #4 from Fedora Update System  ---
golang-github-eapache-go-resiliency-0-0.1.gitb86b1ec.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-323ac73e11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327781] Review Request: golang-github-olivere-elastic - Elasticsearch client for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327781



--- Comment #4 from Fedora Update System  ---
golang-github-olivere-elastic-2.0.12-0.1.git3cfe882.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fe542e196a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327307] Review Request: golang-github-eapache-go-resiliency - Resiliency patterns for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327307

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327307] Review Request: golang-github-eapache-go-resiliency - Resiliency patterns for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327307



--- Comment #3 from Fedora Update System  ---
golang-github-eapache-go-resiliency-0-0.1.gitb86b1ec.el7 has been submitted as
an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d143126c5d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327781] Review Request: golang-github-olivere-elastic - Elasticsearch client for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327781

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327781] Review Request: golang-github-olivere-elastic - Elasticsearch client for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327781



--- Comment #3 from Fedora Update System  ---
golang-github-olivere-elastic-2.0.12-0.1.git3cfe882.el7 has been submitted as
an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-121040bfb7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327566] Review Request: php-nikic-php-parser - A PHP parser written in PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327566



--- Comment #10 from Remi Collet  ---
Thanks again for this one


New package request open on pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327566] Review Request: php-nikic-php-parser - A PHP parser written in PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327566

Johan Cwiklinski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Johan Cwiklinski  ---
Looks good to me; rpmlint output is just about spelling and can be ignored.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327566] Review Request: php-nikic-php-parser - A PHP parser written in PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327566

Johan Cwiklinski  changed:

   What|Removed |Added

 Attachment|0   |1
#1157912 is||
   obsolete||



--- Comment #8 from Johan Cwiklinski  ---
Created attachment 1157914
  --> https://bugzilla.redhat.com/attachment.cgi?id=1157914=edit
fedora-review output

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1279090] Review Request: sdl2-cs - C# wrapper for SDL2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279090



--- Comment #2 from Raphael Groner  ---
Needs unbundling of OpenTK. Luckily, OpenTK is already packaged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327566] Review Request: php-nikic-php-parser - A PHP parser written in PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327566



--- Comment #7 from Remi Collet  ---
Fix rpmlint
https://github.com/remicollet/remirepo/commit/42abb9f05cd542de7819486f6b5a5c9fdcc76c0e

Spec:
https://raw.githubusercontent.com/remicollet/remirepo/42abb9f05cd542de7819486f6b5a5c9fdcc76c0e/php/php-nikic-php-parser/php-nikic-php-parser.spec
Srpm: http://rpms.remirepo.net/SRPMS/php-nikic-php-parser-2.1.0-3.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327566] Review Request: php-nikic-php-parser - A PHP parser written in PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327566



--- Comment #6 from Johan Cwiklinski  ---
Created attachment 1157912
  --> https://bugzilla.redhat.com/attachment.cgi?id=1157912=edit
fedora-review output

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org