[Bug 1218758] Review Request: flmsg - Fast Light Message Amateur Radio Forms Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218758

Eric Christensen  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1218758] Review Request: flmsg - Fast Light Message Amateur Radio Forms Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218758

Eric Christensen  changed:

   What|Removed |Added

 CC||hobbes1...@gmail.com
  Flags||needinfo?(hobbes1069@gmail.
   ||com)



--- Comment #19 from Eric Christensen  ---
I'm a little concerned about the missing-call-to-setgroups-before-setuid error
that rpmlint is giving.  Also, the COPYING is GPLv2 and SPEC says GPLv3.  

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v2)", "GPL (v3 or later)", "Unknown
 or generated". 15 files have unknown license. Detailed output of
 licensecheck in /home/echristensen/1218758-flmsg/licensecheck.txt

This is odd.  SPEC says, and many of the files are, GPLv3 but COPYING says
GPLv2.

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a 

[Bug 1342770] Review Request: flmsg - Fast Light Message Amateur Radio Forms Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342770

Eric Christensen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-06-05 00:10:55



--- Comment #2 from Eric Christensen  ---
Opps, didn't mean to do this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342770] Review Request: flmsg - Fast Light Message Amateur Radio Forms Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342770



--- Comment #1 from Eric Christensen  ---
This package built on koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=14389001

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342770] New: Review Request: flmsg - Fast Light Message Amateur Radio Forms Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342770

Bug ID: 1342770
   Summary: Review Request: flmsg - Fast Light Message Amateur
Radio Forms Manager
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: spa...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://sparks.fedorapeople.org//flmsg.spec
SRPM URL: http://sparks.fedorapeople.org//flmsg-2.0.17-1.fc23.src.rpm

Description:
flmsg is a editor / file management tool for ics213 forms which form the
basis for emergency communications data transfers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1218758] Review Request: flmsg - Fast Light Message Amateur Radio Forms Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218758

Eric Christensen  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||spa...@redhat.com
   Assignee|nob...@fedoraproject.org|spa...@redhat.com



--- Comment #18 from Eric Christensen  ---
It's been a while since I reviewed anything but I'd really like to see this
package in the repos.  Let me see what I can do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1230213] Review Request: perl-Cookie-Baker - Cookie string generator / parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1230213



--- Comment #13 from Fedora Update System  ---
perl-Cookie-Baker-0.06-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0578df5386

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341283] Review Request: php-lukasreschke-id3parser - ID3 parser library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341283



--- Comment #9 from Fedora Update System  ---
php-lukasreschke-id3parser-0.0.1-1.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-90321c0ca4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1332344] Review Request: phototonic - Image viewer and organizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332344



--- Comment #23 from Fedora Update System  ---
phototonic-1.7.20-2.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1332344] Review Request: phototonic - Image viewer and organizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332344

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-06-04 22:51:09



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1332344] Review Request: phototonic - Image viewer and organizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332344



--- Comment #22 from Fedora Update System  ---
phototonic-1.7.20-2.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1202295] Review Request: xonsh - An exotic, usable shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202295

John Dulaney  changed:

   What|Removed |Added

 CC||jdula...@fedoraproject.org



--- Comment #6 from John Dulaney  ---
A few rpmlint issues:

xonsh.noarch: E: non-executable-script
/usr/lib/python3.4/site-packages/xonsh/xoreutils/_which.py 644 /usr/bin/env
xonsh.noarch: E: script-without-shebang
/usr/lib/python3.4/site-packages/xontrib/pyselect.xsh
xonsh.noarch: W: no-manual-page-for-binary xonsh


Also, the separate spec file is different from that in the srpm:

[jdulaney@bodrog review]$ diff -u xonsh.spec ../rpmbuild/SPECS/xonsh.spec 
--- xonsh.spec  2016-06-04 21:25:06.0 +
+++ ../rpmbuild/SPECS/xonsh.spec2016-06-04 21:08:36.0 +
@@ -9,6 +9,9 @@
 License:BSD
 URL:https://github.com/scopatz/xonsh
 Source0:   
https://pypi.python.org/packages/source/x/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
+# It may look nice but the logo is just redudant spam
+# in build process
+#Patch0: 001-remove-logo-from-setup.patch
 BuildArch:  noarch

 BuildRequires:  python3-devel

You may want to change the url to the new pypi.io.



Also, not sure if we should consider the old review abandoned or not; if so, I
think the procedure is to close this one and start a fresh review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1202295] Review Request: xonsh - An exotic, usable shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202295



--- Comment #5 from Luke Macken  ---
After watching the xonsh talk at PyCon this week, I'd be happy to take this
package over.

https://lmacken.fedorapeople.org/rpms/xonsh-0.3.2-1.fc23.src.rpm
https://lmacken.fedorapeople.org/rpms/xonsh.spec

* Fri Jun 03 2016 Luke Macken  - 0.3.2-1
- Latest upstream release   
- Update the Summary

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339760] Review Request: js-glmatrix - Javascript module designed to perform vector and matrix operations very fast

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339760



--- Comment #4 from John Dulaney  ---
Spec URL: https://jdulaney.fedorapeople.org/js-gl-matrix.spec
SRPM URL: https://jdulaney.fedorapeople.org/js-gl-matrix-2.3.2-3.fc24.src.rpm

The versioning is similar to how other js packages are done.  I figure it's a
good thing so it's easy to install multiple versions if desired.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342747] Review Request: Limnoria - A modified version of Supybot ( an IRC bot) with enhancements and bug fixes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342747



--- Comment #2 from Patrick Uiterwijk  ---
To fix:
- Licensing is both MIT/BSD and GPLv2 and GPLv2+, latter two are missing in
spec file and in %license.
- Missing Requires for all python libraries needed
- %install runs rm -rf $RPM_BUILD_ROOT



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 FAIL: Contains both BSD/MIT and GPLv2 and GPLv2+
[x]: Package does not own files or directories owned by other packages.
 Note: Owns a lot of directories supybot-gribble does, but it replaces
that.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[!]: Package is named according to the Package Naming Guidelines.
 Note: guidelines: "Package names should be in lower case ..."
 Is there a specific reason not to follow this?
[x]: Package does not generate any conflict.
 Conflicts with supybot-gribble, but it replaces that
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
 FAIL: Missing install-time dependencies on all python libraries needed.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
 FAIL: Missing GPLv2 and GPLv2+ licenses
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 FAIL: has rm -rf $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
 FAIL: Missing requires on all python libraries.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
 NOTE: %check is marked as TODO
[x]: Packages should try to preserve timestamps of 

[Bug 1342747] Review Request: Limnoria - A modified version of Supybot ( an IRC bot) with enhancements and bug fixes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342747

Patrick Uiterwijk  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||puiterw...@redhat.com
   Assignee|nob...@fedoraproject.org|puiterw...@redhat.com



--- Comment #1 from Patrick Uiterwijk  ---
I will do this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336005] Review Request: gap-pkg-resclasses - Set-theoretic computations with Residue Classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336005

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336005] Review Request: gap-pkg-resclasses - Set-theoretic computations with Residue Classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336005



--- Comment #7 from Fedora Update System  ---
gap-pkg-resclasses-4.5.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-179bd55d5d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342687] Review Request: python-backports-ssl-match-hostname - The ssl match_hostname() function from Python 3.5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342687

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jerry James  ---
I will take this review.  Immediate problem:

$ fedora-review -b 1342687 -m fedora-rawhide-x86_64
INFO: Processing bugzilla bug: 1342687

...

ERROR: No specfile found in srpm:
python-backports.ssl_match_hostname-3.5.0.1-0.fc25.src.rpm

There is a spec file in that SRPM, but its name does not end with ".spec".  Can
you fix that, please?  It should be named
python-backports-ssl-match-hostname.spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1338140] Review Request: guayadeque - Music player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1338140



--- Comment #15 from MartinKG  ---
(In reply to Raphael Groner from comment #12)

> > [?]: Package contains no bundled libraries without FPC exception.
> > => Source files without license header, see above.
> 
> Licensecheck script fails to detect the header, we overlooked that in first
> run. SHOULD ask upstream why wxCurl is bundled and try to unbundle.
> https://github.com/anonbeat/guayadeque/issues/8#issuecomment-222497195
> https://sourceforge.net/projects/wxcurl/

the packaging of wxcurl is currently discussed on the FedoraForum:
http://forums.fedoraforum.org/showthread.php?t=310141

need more assistance !


> Subpackages for locales look nearly good (ignore the rpmlint warnings),
> except:
> [!]: Package requires other packages for directories it uses.
>  Note: No known owner of /usr/share/guayadeque,
>  /usr/share/locale/sr_latin, /usr/share/locale/sr_latin/LC_MESSAGES
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners:
>  /usr/share/locale/sr_latin/LC_MESSAGES, /usr/share/locale/sr_latin,
>  /usr/share/guayadeque
> => Fix with:
> %files
> %dir %{_datadir}/%{name}
> 
done

> guayadeque-langpack-sr_latin.noarch: E: incorrect-locale-subdir
> /usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
> guayadeque-langpack-sr_latin.noarch: E: invalid-lc-messages-dir
> /usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
> => sr_latin is not a valid locale identifier, change to sr@latin.
> https://github.com/anonbeat/guayadeque/issues/6
>
done

new rpm package:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/guayadeque.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/guayadeque-0.4.1-0.6.beta1git79b6383.fc24.src.rpm

%changelog
* Sat Jun 04 2016 Martin Gansser  -
0.4.1-0.6.beta1git79b6383
- Update to 0.4.1-0.6.beta1git79b6383
- Added wxWidgets to License tag
- Added %%dir %%{_datadir}/%%{name} because it's owned by the package
- modified macro for l10n subpackage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340061] systemd presets request - lircd.socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340061

Alec Leamas  changed:

   What|Removed |Added

Summary|systemd presets request -   |systemd presets request -
   |lircd.service, lircd.socket |lircd.socket



--- Comment #3 from Alec Leamas  ---
Fixing heading. And changing my statement that this about all branches - it
isn't. It's just for f24 and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160672] Review Request: seafile-client - Seafile cloud storage desktop client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160672

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
seafile-5.1.2-3.fc24, seafile-client-5.1.1-3.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6aa664154f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160671] Review Request: seafile - Cloud storage system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160671

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #23 from Fedora Update System  ---
seafile-5.1.2-3.fc24, seafile-client-5.1.1-3.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6aa664154f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340551] Review Request: gap-pkg-irredsol - Irreducible soluble linear groups over finite fields

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340551

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
gap-pkg-irredsol-1.3.1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5caf05f266

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341283] Review Request: php-lukasreschke-id3parser - ID3 parser library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341283

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
php-lukasreschke-id3parser-0.0.1-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b467a790cf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1230213] Review Request: perl-Cookie-Baker - Cookie string generator / parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1230213

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
perl-Cookie-Baker-0.06-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6c34a4ccaa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342749] Review Request: wildfly-core - The core runtime of WildFly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342749

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342749] Review Request: wildfly-core - The core runtime of WildFly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342749

gil cattaneo  changed:

   What|Removed |Added

   Keywords||Tracking



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342749] Review Request: wildfly-core - The core runtime of WildFly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342749

gil cattaneo  changed:

   What|Removed |Added

 Depends On||1342100




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1342100
[Bug 1342100] Update picketbox to 4.9.5.Final
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342749] New: Review Request: wildfly-core - The core runtime of WildFly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342749

Bug ID: 1342749
   Summary: Review Request: wildfly-core - The core runtime of
WildFly
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: punto...@libero.it
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://gil.fedorapeople.org/wildfly-core.spec
SRPM URL: https://gil.fedorapeople.org/wildfly-core-2.1.0-1.fc23.src.rpm
Description:
This project provides the core runtime that is used by the
Wildfly application server. This includes:

* Modular class loading
* Unified management, including domain mode
* Basic deployment architecture
* CLI for management

Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14383573

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342747] New: Review Request: Limnoria - A modified version of Supybot (an IRC bot) with enhancements and bug fixes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342747

Bug ID: 1342747
   Summary: Review Request: Limnoria - A modified version of
Supybot (an IRC bot) with enhancements and bug fixes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ke...@scrye.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://www.scrye.com/~kevin/fedora/review/Limnoria/Limnoria.spec
SRPM URL:
http://www.scrye.com/~kevin/fedora/review/Limnoria/Limnoria-20160506-1.fc25.src.rpm
Description:
Supybot is a robust (it doesn't crash), user friendly
(it's easy to configure) and programmer friendly
(plugins are extremely easy to write) Python IRC bot.
It aims to be an adequate replacement for most existing IRC bots.
It includes a very flexible and powerful ACL system for controlling
access to commands, as well as more than 50 builtin plugins
providing around 400 actual commands.

Limnoria is a project which continues development of Supybot
(you can call it a fork) by fixing bugs and adding features
(see the list of added features for more details).

Fedora Account System Username: kevin

rpmlint says:

Limnoria.noarch: W: spelling-error %description -l en_US Supybot -> Subplot
Limnoria.src: W: spelling-error %description -l en_US Supybot -> Subplot
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

scratch build: 

https://koji.fedoraproject.org/koji/taskinfo?taskID=14383371

Note that this package is python3 ready itself, but many of the plugins we have
in Fedora currently are not. As we get them ported over we can change this
package to build against python3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1334888] Review Request: python-seesaw - ArchiveTeam seesaw kit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1334888



--- Comment #4 from Ben Rosser  ---
I've unbundled six and added a dependency on python{2,3}-six. I also fixed the
python-Tornado dependency and changed python-sockjs-tornado to be
python2-sockjs-tornado.

For the moment, I've added bundled provides on the JS and CSS:

Provides:   bundled(js-jquery) = 1.7.2
Provides:   bundled(js-smoothie) = 1.9
Provides:   bundled(js-sockjs) = 0.3
Provides:   bundled(reset-css) = 2.0

I may attempt to unbundle some of them later though. js-jquery is packaged in
Fedora, but the version is much newer than what's used in seesaw (2.x vs 1.7),
and research suggested there might be some issues upgrading. The other three
are not even in Fedora, although there is an open review ticket from 2014 for
reset-css  (https://bugzilla.redhat.com/show_bug.cgi?id=1094034).

The license field has been set to "WTFPL and MIT and Public Domain" as a
consequence of this.

I fleshed out the summary and description on the -doc subpackage.

I tried enabling the unit tests. However, test_proc_utf8 fails when invoked as
part of %check, but works just fine when I run "nosetests -v" in the package's
build directory myself. This happens when I'm invoking rpmbuild manually, so I
don't understand what could be different about the RPM environment and my
system's...

The relevant test is here:
https://github.com/ArchiveTeam/seesaw-kit/blob/master/seesaw/externalprocess_test.py#L107
and the specific error was https://paste.fedoraproject.org/374430/50597051/.
The code is just trying to print out a Unicode string.

Spec URL: https://tc01.fedorapeople.org/seesaw/python-seesaw.spec
SRPM URL:
https://tc01.fedorapeople.org/seesaw/python-seesaw-0.9.2-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1338140] Review Request: guayadeque - Music player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1338140



--- Comment #14 from Raphael Groner  ---
Maybe modify the lang_subpkg macro definition a little bit to include all
variants into one subpackage for the same language code, mind the additional
star character (*) in the last line.

%define lang_subpkg() \
%packagelangpack-%{1}\
Summary:%{2} language data for %{name}\
BuildArch:  noarch \
Requires:   %{name} = %{version}-%{release}\
Supplements:(%{name} = %{version}-%{release} and langpacks-%{1})\
\
%descriptionlangpack-%{1}\
%{2} language data for %{name}.\
\
%files  langpack-%{1}\
%{_datadir}/locale/%{1}*/LC_MESSAGES/%{name}.mo

...
%lang_subpkg sr "Serbian (Cyrillic and Latin)"
%lang_subpkg sv Swedish
%lang_subpkg th Thai

https://www.gnu.org/software/gettext/manual/html_node/Locale-Names.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340061] systemd presets request - lircd.service, lircd.socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340061

Kevin Fenzi  changed:

   What|Removed |Added

 CC||den...@ausil.us,
   ||jdisn...@gmail.com,
   ||ke...@scrye.com,
   ||pbrobin...@gmail.com,
   ||sgall...@redhat.com,
   ||zbys...@in.waw.pl
  Component|Package Review  |fedora-release
   Assignee|nob...@fedoraproject.org|den...@ausil.us



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1260208] Review Request: jandex-maven-plugin - Jandex wrapper for Maven

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260208

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1260208] Review Request: jandex-maven-plugin - Jandex wrapper for Maven

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260208



--- Comment #1 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/jandex-maven-plugin.spec
SRPM URL: https://gil.fedorapeople.org/jandex-maven-plugin-1.0.4-1.fc22.src.rpm

- update to 1.0.4

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14382109

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342743] New: Review Request: crawl - Roguelike dungeon exploration game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342743

Bug ID: 1342743
   Summary: Review Request: crawl - Roguelike dungeon exploration
game
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: anto.tra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/crawl/crawl.git/plain/crawl.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sagitter/crawl/fedora-rawhide-x86_64/00323471-crawl/crawl-0.18.1-2.fc25.src.rpm

Description:
Dungeon Crawl Stone Soup is a free roguelike game of exploration
and treasure-hunting in dungeons filled with dangerous and unfriendly
monsters in a quest for the mystifyingly fabulous Orb of Zot.

Dungeon Crawl Stone Soup has diverse species and many different character
backgrounds to choose from, deep tactical game-play, sophisticated magic,
religion and skill systems, and a grand variety of monsters to fight and
run from, making each game unique and challenging.

Fedora Account System Username: sagitter

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340513] Review Request: gap-pkg-gbnp - Computing Gröbner bases of noncommutative polynomials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340513

Till Hofmann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Till Hofmann  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size in /usr/share is 20480 bytes in 4 files, but there
is
  documentation in /usr/lib/gap/pkg/gbnp/doc with 137 files and size 3.4MB.
  I know from the last review that gap handles documentation differently, but
is
  it still possible to move those files to a doc package?
  You could also put all doc files in /usr/share and then symlink
/usr/lib/gap/pkg/gbnp/doc.
- There are a lot of files in /usr/lib/gap/pkg/gbnp/doc that look like they
  shouldn't be packaged. Some of them are removed in %install, but all files
  in subfolders are still there. I suggest you replace rm -f in %install with
  some suitable find ... -delete
- [!]: Uses parallel make %{?_smp_mflags} macro.
  If for some reason you can't use %{?_smp_mflags}, please specify the reason
in
  the Spec file.
- There are 81 test files packaged. Do they need to be in the package? If so,
  please specify the reason.
- Not sure if the TODO file should be packaged.
- Please convert the following files to utf8:
  gap-pkg-gbnp.noarch: W: file-not-utf8 /usr/share/doc/gap-pkg-gbnp/TODO
  gap-pkg-gbnp.noarch: W: file-not-utf8 /usr/lib/gap/pkg/gbnp/doc/gbnp_doc.tex
- spelling:
  gap-pkg-gbnp.noarch: W: spelling-error Summary(en_US) noncommutative -> non
  commutative, non-commutative, noncom mutative
  This should probably be non-commutative. All other spelling errors are okay.

not necessarily an issue:
- [?]: Development files must be in a -devel package
  I don't know enough about gap to be able to say which files are development
  files. Please move all development files to a -devel package if there are
any.

not an issue:

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file copyrightcomment is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
  --> that file is not actually a license file


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[?]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist 

[Bug 1340513] Review Request: gap-pkg-gbnp - Computing Gröbner bases of noncommutative polynomials

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340513

Till Hofmann  changed:

   What|Removed |Added

 CC||hofm...@kbsg.rwth-aachen.de
   Assignee|nob...@fedoraproject.org|hofm...@kbsg.rwth-aachen.de
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342737] New: Review Request: btrfs-sxbackup - Incremental btrfs snapshot backups with push/ pull support via SSH

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342737

Bug ID: 1342737
   Summary: Review Request: btrfs-sxbackup - Incremental btrfs
snapshot backups with push/pull support via SSH
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: hofm...@kbsg.rwth-aachen.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://thofmann.fedorapeople.org/btrfs-sxbackup.spec
SRPM URL: https://thofmann.fedorapeople.org/btrfs-sxbackup-0.6.6-1.fc23.src.rpm
Description:
Btrfs snapshot backup utility with push/pull support via SSH, retention, Email
notifications, compression of transferred data, and syslog logging.

Fedora Account System Username: thofmann

koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14379518

rpmlint:
There is one warning:
btrfs-sxbackup.noarch: W: spelling-error %description -l en_US syslog -> slog
Clearly, this is not a spelling error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321687] Review Request: qpid-java - Apache Qpid Java Components

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321687



--- Comment #3 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/qpid-java.spec
SRPM URL: https://gil.fedorapeople.org/qpid-java-6.0.3-1.fc23.src.rpm

- update to 6.0.3

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14379340

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1338140] Review Request: guayadeque - Music player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1338140



--- Comment #13 from MartinKG  ---
(In reply to Raphael Groner from comment #12)
> 
> guayadeque-langpack-sr_latin.noarch: E: incorrect-locale-subdir
> /usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
> guayadeque-langpack-sr_latin.noarch: E: invalid-lc-messages-dir
> /usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
> => sr_latin is not a valid locale identifier, change to sr@latin.
> https://github.com/anonbeat/guayadeque/issues/6
> 

changed sr_latin to sr@latin in the spec file
...
%lang_subpkg sr@latin "Serbian (Latin)"
%lang_subpkg sv Swedish
%lang_subpkg th Thai
%lang_subpkg tr Turkish
%lang_subpkg uk Ukrainian

%prep
%setup -qn %{name}-%{commit0}
%patch0 -p0

#rm -rf src/curl src/wx/curl
mv po/sr-latin po/sr@latin
sed -i -e 's|ADD_SUBDIRECTORY( sr-latin )|ADD_SUBDIRECTORY( sr@latin )|'
po/CMakeLists.txt
sed -i -e 's|sr_latin|sr@latin|' po/sr@latin/CMakeLists.txt
...

but @ was detected as Illegal character:

[martin@fc24 SPECS]$ rpmbuild -ba guayadeque.spec 
error: line 71: Illegal char '@' (0x40) in: %packagelangpack-sr@latin

need more assistance !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336005] Review Request: gap-pkg-resclasses - Set-theoretic computations with Residue Classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336005



--- Comment #6 from Till Maas  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-resclasses

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340061] systemd presets request - lircd.service, lircd.socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340061



--- Comment #2 from Alec Leamas  ---
As of now, lirc-0.9.4 is in updates-testing (bundled with libirman) for f24,
pushed to rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 450054] Review Request: liblinebreak - A Unicode line-breaking library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=450054

Michel Alexandre Salim  changed:

   What|Removed |Added

 Blocks||1342724




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1342724
[Bug 1342724] Review Request: libunibreak - A Unicode line-breaking library
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342724] Review Request: libunibreak - A Unicode line-breaking library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342724

Michel Alexandre Salim  changed:

   What|Removed |Added

 Blocks||991284
 Depends On||450054




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=450054
[Bug 450054] Review Request: liblinebreak - A Unicode line-breaking library
https://bugzilla.redhat.com/show_bug.cgi?id=991284
[Bug 991284] libunibreak should obsolete this package
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342724] New: Review Request: libunibreak - A Unicode line-breaking library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342724

Bug ID: 1342724
   Summary: Review Request: libunibreak - A Unicode line-breaking
library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mic...@michel-slm.name
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://salimma.fedorapeople.org/specs/libdevel/libunibreak.spec
SRPM URL:
https://salimma.fedorapeople.org/specs/libdevel/libunibreak-3.0-1.fc24.src.rpm

NOTE: this is a re-review for a renamed package, it was previously called
liblinebreak. Please check the additional guidelines here:

  https://fedoraproject.org/wiki/Package_Renaming_Process

Description:
Libunibreak is an implementation of the line breaking and word
breaking algorithms as described in Unicode Standard Annex 14 and
Unicode Standard Annex 29. It is designed to be used in a generic text
renderer.

Fedora Account System Username: salimma

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339760] Review Request: js-glmatrix - Javascript module designed to perform vector and matrix operations very fast

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339760



--- Comment #3 from Igor Gnatenko  ---
> Requires:  web-assets-filesystem
add this req.

> %{installdir}/%{version}
not sure if it should be versioned. What do you think?

Also according to guidelines name should be the same as in upstream
(gl-matrix). I think you should rename stuff into js-gl-matrix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org