[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367598



--- Comment #2 from Jerry James  ---
Thanks for the review, Paulo.

(In reply to Paulo Andrade from comment #1)
>   It is not required to have:
> BuildRequires: gcc

Actually, it is now.  See:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/XGXCCAJNEOIEN3KK6TN2657LSIGZGB3N/

>   This looks suspecting, as it means it will loop only once:
> ./src/randschr.c:238:10: warning: this 'if' clause does not guard...
> [-Wmisleading-indentation]

Good catch!  I will add braces to the warning patch to fix that.

>   || and && have different precedence, so this code is also suspecting:
> ./src/randschr.c:391:43: warning: suggest parentheses around '&&' within
> '||' [-Wparentheses]
>lowestOrder == curOrder && levelLowestOrder > finalLevel)
> ) {
>^~~~

That one I think is okay.  It appears to me that the && really should be within
||, so it is parsed in the correct order.  But ... it's easy to patch, so I
will add parentheses there.

>   Another case of suspicious code:
> ./src/ccent.c: In function 'nextBasePointEltCent':
> ./src/ccent.c:90:24: warning: suggest parentheses around '+' inside '<<'
> [-Wparentheses]
>  priority = 20ul - (unsigned long)
> MIN(cycleLen[pt],1000) << 20
> 
> ~~
> + cSize;
> ^~~

This one worries me.  I'm not sure if the + is supposed to be inside or outside
of the <<, so I am reluctant to touch it.  I think I'd better check with
upstream before I do anything here, unless you think you can see where the
parentheses should go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367526] Review Request: brial - BRiAl is the successor to PolyBoRi

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367526



--- Comment #3 from Paulo Andrade  ---
(In reply to Jerry James from comment #2)
> Issues
> ==
> 1. This is causing some problems:
> 
> checking size of void *... 0
> checking size of int... 0
> checking size of long... 0
> 
>If you look through the build log, you'll see warnings about casting
> between
>pointers and integers of a different size.  This is due to the configure
>failure above.  The problem seems to be that the configure checks are
> linked
>with $RPM_LD_FLAGS, but compiled without %{optflags}, so the link step
> fails
>due to bad relocations.  The problem is this line in the spec file:
> 
> export CXXFLAGS="$CXXFLAGS -std=c++98"
> 
>At that point, CXXFLAGS has not been set, so the $CXXFLAGS inside quotes
> is
>the empty string, resulting in CXXFLAGS set to " -std=c++98".  Do this
>instead:
> 
> export CXXFLAGS="%{optflags} -std=c++98"

  Fixed, thanks!

> 2. The license field reflects the final binary contents.  Since the GPL, both
>versions 2 and 3, subsumes BSD, it is permissible make the license field
>read simply "GPLv2+" if you wish.  Otherwise, you need to document the
>multiple license scenario in the spec file.  See
>   
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Multiple_Licensing_Scenarios

  I added a comment about what code is under a BSD like license (Cudd)

> 3. In the review below, I presume that polybori will be retired.  For
> example,
>I don't mark that this package causes conflicts.  It does, but that will
> be
>handled by removing polybori.  However, that means that the "Conflicts"
> tag
>in the -devel package should be removed.  Instead, add "Obsoletes" and
>"Provides" tags to each package as described here:
>   
> https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.
> 2FReplacing_Existing_Packages

  Ok. Added the proper Obsoletes/Provides. Only sagemath uses it, so,
once a sagemath 7.3 package is available, polybori can be retired.

> 4. The rpmlint output shows some unused direct library dependencies.  I like
> to
>do this after the %configure step to remove both rpaths and such unused
>dependencies:
> 
> # Get rid of undesirable hardcoded rpaths, and workaround libtool reordering
> # -Wl,--as-needed after all the libraries.
> sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' \
> -e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \
> -e 's|CC="\(g..\)"|CC="\1 -Wl,--as-needed"|' \
> -i libtool
>
>It is not enough to add -Wl,--as-needed to LDFLAGS, unfortunately, since
>libtool has a long-standing bug where it reorders -Wl,--as-needed AFTER
> all
>of the libraries, where it does no good at all.

  Thanks. Changed to use the suggested pattern, that indeed corrects the
problem. On not yet released versions it should actually make use of gd
and png.

> 5. The changelog remarks that the python sources have been prepared for
> python
>3.  Is it possible to make both python 2 and python 3 subpackages?  Also,
>see https://fedoraproject.org/wiki/Packaging:Python for information on the
>%python_provide macro.

  I believe this is more of something to ask upstream, it explicitly requires
python 2.7:
AM_PATH_PYTHON([2.7])
so, I believe this is a work in progress by upstream.

> 6. Note the rpmlint complaint about mixed use of space and tabs.  Choose one.

  Corrected. Was a bad cut

> 7. I don't like the summary line.  Yes, this is a replacement for polybori,
>but what does it DO?  Maybe reuse the polybori summary line: "Framework
> for
>Boolean Rings".  Along those lines, I think the description is confusing,
>since it mentions polybori, but not brial.

  I used the sagemath SPKG.txt text, but indeed it was not looking right.
Now it was changed the Summary to the same as polybori, and description
basically s/PolyBori/BRiAl/.

> 8. What version of cudd is bundled?  The Provides line should indicate that;
>e.g., "Provides: bundled(cudd) = 2.5.1".

  The code is significantly changed, but appears to be based/forked from
2.5.0, I changed to:
# brial-0.8.5/Cudd/cudd/cudd.h:#define CUDD_VERSION "2.5.0"
Provides:bundled(cudd) = 2.5.0

> [!]: If the package is under multiple licenses, the licensing breakdown
>  must be documented in the spec.
should be fixed.

> [!]: %build honors applicable compiler flags or justifies otherwise.
should be fixed.

> [!]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.
should be fixed.

> [!]: Useful -debuginfo package or justification otherwise.
>  This is due to the CXXFLAGS snafu described above.
should be fixed.

Spec URL: https://pcpa.fedorapeople.org/brial.spec
SRPM URL: https://pcpa.fedorapeople.org/brial-0.8.5-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You 

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367598



--- Comment #1 from Paulo Andrade  ---
  It is not required to have:
BuildRequires: gcc

---
  This looks suspecting, as it means it will loop only once:
./src/randschr.c:238:10: warning: this 'if' clause does not guard...
[-Wmisleading-indentation]
  if ( hOrder % primeList[i] == 0 )
  ^~
./src/randschr.c:240:13: note: ...this statement, but the latter is
misleadingly indented as if it is guarded by the 'if'
 break;
 ^
code is:
  for ( i = 0 ; primeList[i] != 0 ; ++i ) {
 if ( hOrder % primeList[i] == 0 )
raisePermToPower( h, hOrder / primeList[i]);
break;
  }
and the data is:
guava-3.13.1/src/leon/src/primes.c:Unsigned primeList[] =
{2,3,5,7,9,11,13,17,19,23,29,31,37,41,43,47,53,59, ... 0};

---
  || and && have different precedence, so this code is also suspecting:
./src/randschr.c:391:43: warning: suggest parentheses around '&&' within '||'
[-Wparentheses]
   lowestOrder == curOrder && levelLowestOrder > finalLevel) )
{
   ^~~~
code is:
if ( nonInvolRejectCount > 0 &&
(...||   (lowestOrder < (curOrder = permOrder(h)) ||
 ...&&...)   lowestOrder == curOrder && levelLowestOrder > finalLevel) ) {

---
  Another case of suspicious code:
./src/ccent.c: In function 'nextBasePointEltCent':
./src/ccent.c:90:24: warning: suggest parentheses around '+' inside '<<'
[-Wparentheses]
 priority = 20ul - (unsigned long) MIN(cycleLen[pt],1000)
<< 20
   
 ~~
+ cSize;
^~~

---
  The package appears in good shape, but while I checked all other
compiler warnings, and they appear to just warn about improper
indentation or somewhat uncommon coding practive, the above warnings
may be valid, so, I would like some comment about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361320] Review Request: cAudio - 3D Audio Engine Based on Openal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361320



--- Comment #6 from Ben Rosser  ---
Whoops, fixed.

- Fix bad macro (_isa should be ?_isa).
- Add license.txt to doc subpackage, since it doesn't require the main package.

Spec URL: https://tc01.fedorapeople.org/cAudio/cAudio.spec
SRPM URL: https://tc01.fedorapeople.org/cAudio/cAudio-2.3.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367598

Paulo Andrade  changed:

   What|Removed |Added

 CC||paulo.cesar.pereira.de.andr
   ||a...@gmail.com
   Assignee|nob...@fedoraproject.org|paulo.cesar.pereira.de.andr
   ||a...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363921] Review Request: protobuf-java-format - Serialization and de-serialization of different formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363921

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363921] Review Request: protobuf-java-format - Serialization and de-serialization of different formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363921



--- Comment #4 from gil cattaneo  ---
Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7287
https://admin.fedoraproject.org/pkgdb/package/requests/7288
https://admin.fedoraproject.org/pkgdb/package/requests/7289

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #11 from Mosaab Alzoubi  ---
First look :

1- For updated SPEC SRPM you must use new URLs in last comment , not in
attachment part.
2- Spec URL must be in plain mode (in your case
https://raw.githubusercontent.com/muayyad-alsadi/dumb-init/add-rpm-spec/dumb-init.spec)
3- Upstream has make , you may use it .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1303569] Review Request: uflash - An utility to flash Python onto the BBC micro:bit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303569

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
uflash-1.0.3-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-389585fba2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348778



--- Comment #14 from Fedora Update System  ---
ansible-review-0.9.0-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-68c52c3f1c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #10 from Mosaab Alzoubi  ---
Welcome back Alsadi , Happy to continue with your first review .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033

Mosaab Alzoubi  changed:

   What|Removed |Added

 CC||moc...@hotmail.com
   Assignee|nob...@fedoraproject.org|moc...@hotmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363921] Review Request: protobuf-java-format - Serialization and de-serialization of different formats

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363921

Nils Philippsen  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Nils Philippsen  ---
Thanks for fixing this, the package is ACCEPTED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364542] Review Request: ardour5 - Digital Audio Workstation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364542



--- Comment #21 from Nils Philippsen  ---
ardour5-5.0.0-0.8 is building in COPR, with the changes mentioned above:

https://copr.fedorainfracloud.org/coprs/nphilipp/ardour5/build/442012/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364605] Review Request: gap-pkg-hap - Homological Algebra Programming for GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364605



--- Comment #8 from Fedora Update System  ---
gap-pkg-hap-1.11-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e369cda956

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364605] Review Request: gap-pkg-hap - Homological Algebra Programming for GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364605

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364605] Review Request: gap-pkg-hap - Homological Algebra Programming for GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364605



--- Comment #7 from Fedora Update System  ---
gap-pkg-hap-1.11-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7c5ea14c03

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1205248] Review Request: jaxws-undertow-httpspi - Undertow to JAXWS 2.2 HTTP SPI bridge

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1205248



--- Comment #9 from Fedora Update System  ---
jaxws-undertow-httpspi-1.0.1-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3600adc9aa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348778



--- Comment #13 from Fedora Update System  ---
ansible-review-0.9.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a6c98e4bcb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #9 from gil cattaneo  ---
install -pm 755 %{name}.1.gz "${RPM_BUILD_ROOT}/%{_mandir}/man1/"
why must be executable? when normally should have read permissions ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #19 from l...@us.ibm.com ---
(In reply to Igor Gnatenko from comment #2)

> > BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> not needed
> 
> > rm -fr %{buildroot}
> not needed
> 
> > %clean
> > [ "%{buildroot}" != "/" ] && rm -rf %{buildroot}
> don't do that
> 
> > %defattr(-,root,root)
> not needed
> 

I did these cleanings. The 'rpmlint' tool wasn't too happy with all these
changes I made.  But, I assume that the tool doesn't apply to or hasn't caught
up with the EPEL packaging.

Thanks,
Vicky

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #19 from l...@us.ibm.com ---
(In reply to Igor Gnatenko from comment #2)

> > BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> not needed
> 
> > rm -fr %{buildroot}
> not needed
> 
> > %clean
> > [ "%{buildroot}" != "/" ] && rm -rf %{buildroot}
> don't do that
> 
> > %defattr(-,root,root)
> not needed
> 

I did these cleanings. The 'rpmlint' tool wasn't too happy with all these
changes I made.  But, I assume that the tool doesn't apply to or hasn't caught
up with the EPEL packaging.

Thanks,
Vicky

--- Comment #20 from l...@us.ibm.com ---
(In reply to Igor Gnatenko from comment #2)

> > BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> not needed
> 
> > rm -fr %{buildroot}
> not needed
> 
> > %clean
> > [ "%{buildroot}" != "/" ] && rm -rf %{buildroot}
> don't do that
> 
> > %defattr(-,root,root)
> not needed
> 

I did these cleanings. The 'rpmlint' tool wasn't too happy with all these
changes I made.  But, I assume that the tool doesn't apply to or hasn't caught
up with the EPEL packaging.

Thanks,
Vicky

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #18 from l...@us.ibm.com ---
Rpmlint output:

rpmlint tss2.spec  ../SRPMS/tss2* ../RPMS/*/tss2*
tss2.spec:73: E: files-attr-not-set
tss2.spec:74: E: files-attr-not-set
tss2.spec:75: E: files-attr-not-set
tss2.spec:76: E: files-attr-not-set
tss2.spec: W: no-cleaning-of-buildroot %install
tss2.spec: W: no-cleaning-of-buildroot %clean
tss2.spec: W: no-buildroot-tag
tss2.spec: W: no-%clean-section
tss2.src:73: E: files-attr-not-set
tss2.src:74: E: files-attr-not-set
tss2.src:75: E: files-attr-not-set
tss2.src:76: E: files-attr-not-set
tss2.src: W: no-cleaning-of-buildroot %install
tss2.src: W: no-cleaning-of-buildroot %clean
tss2.src: W: no-buildroot-tag
tss2.src: W: no-%clean-section
tss2-debuginfo.x86_64: W: spelling-error Summary(en_US) tss -> ts, toss, ass
tss2-debuginfo.x86_64: W: spelling-error %description -l en_US tss -> ts, toss,
ass
4 packages and 1 specfiles checked; 8 errors, 10 warnings.
[lo1@vtpm2014 SPECS]$

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #17 from l...@us.ibm.com ---
Spec URL: https://fedorapeople.org/~honclo/tss2.spec
SRPM URL: https://fedorapeople.org/~honclo/tss2-713-2.el6.src.rpm

Description: 
TSS2 is a user space Trusted Computing Group's Software Stack (TSS) for
TPM 2.0.  It implements the functionality equivalent to the TCG TSS
working group's ESAPI, SAPI, and TCTI layers (and perhaps more) but with
a hopefully far simpler interface.

It comes with about 80 "TPM tools" that can be used for rapid prototyping,
education and debugging. 

Fedora Account System Username: l...@us.ibm.com

Koji Build:  http://koji.fedoraproject.org/koji/taskinfo?taskID=15250859

This is my first package and I need a sponsor.  I appreciate all the
comments!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #8 from Muayyad Alsadi  ---
my tickets can be found by als...@ojuba.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #7 from Muayyad Alsadi  ---
> I apologize for the question. but it is your first package for Fedora?

I'm an old fedora contributor, but never maintained a package before.
I have submitted patches (to packagekit, yumex, and many other) that got
accepted.
I took part in packaging some packages like luajit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #6 from Muayyad Alsadi  ---
Created attachment 1191404
  --> https://bugzilla.redhat.com/attachment.cgi?id=1191404=edit
updated src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #5 from Muayyad Alsadi  ---
Created attachment 1191403
  --> https://bugzilla.redhat.com/attachment.cgi?id=1191403=edit
updated spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359804] Review Request: golang-github-mvo5-goconfigparser - Golang implementation of Python ConfigParser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359804



--- Comment #9 from Fedora Update System  ---
golang-github-mvo5-goconfigparser-0-0.1.gitefba970.fc23 has been pushed to the
Fedora 23 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361212] Review Request: perl-Ref-Util - Utility functions for checking references

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361212



--- Comment #12 from Fedora Update System  ---
perl-Ref-Util-0.020-2.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #16 from l...@us.ibm.com ---
(In reply to Jason Tibbitts from comment #15)
> I'll do it; I should be done in a few minutes, but it might take another
> half an hour before you're able to access the servers.

Yay got it. Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033



--- Comment #4 from gil cattaneo  ---
I apologize for the question. but it is your first package for Fedora?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367598] New: Review Request: gap-pkg-guava - Computing with error-correcting codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367598

Bug ID: 1367598
   Summary: Review Request: gap-pkg-guava - Computing with
error-correcting codes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jjames.fedorapeople.org/gap-pkg-guava/gap-pkg-guava.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-guava/gap-pkg-guava-3.13.1-1.fc26.src.rpm
Fedora Account System Username: jjames
Description: GUAVA is a package that implements coding theory algorithms in
GAP.
Codes can be created and manipulated and information about codes can be
calculated.

GUAVA consists of various files written in the GAP language, and an
external program from J. S. Leon for dealing with automorphism groups of
codes and isomorphism testing functions.  Several algorithms that need
the speed are integrated in the GAP kernel.

The functions within GUAVA can be divided into four categories:
- Construction of codes.  GUAVA can construct non-linear, linear and
  cyclic codes over an arbitrary finite field.  Examples are
  HadamardCode, ReedMullerCode, BestKnownLinearCode, QRCode and
  GoppaCode.
- Manipulation of codes.  These functions allow the user to transform
  one code into another or to construct a new code from two codes.
  Examples are PuncturedCode, DualCode, DirectProductCode and UUVCode.
- Computation of information about codes.  This information is stored in
  the code record.  Examples are MinimumDistance, OuterDistribution,
  IsSelfDualCode and AutomorphismGroup.
- Generation of bounds on linear codes.  The table by Brouwer and
  Verhoeff (as it existed in the mid-1990s) is incorporated into GUAVA.
  For example, BoundsMinimumDistance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367033] Review Request: dumb-init - entrypoint wrapper for docker that pass signal and handle zombies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367033

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #3 from gil cattaneo  ---

%install
rm -rf $RPM_BUILD_ROOT Please, remove

mkdir -p "${RPM_BUILD_ROOT}/%{_bindir}" "${RPM_BUILD_ROOT}/%{_mandir}/man1/"
Pòease, use cp -p or install -pm 755 for the binary and install -pm 644 for the
man1
cp %{name} "${RPM_BUILD_ROOT}/%{_bindir}/"
cp %{name}.1.gz "${RPM_BUILD_ROOT}/%{_mandir}/man1/"

%files
%{_bindir}/%{name}
%license LICENSE
%doc README.md
%doc %{_mandir}/man1/%{name}.1.gz Please, remove the %doc macro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #15 from Jason Tibbitts  ---
I'll do it; I should be done in a few minutes, but it might take another half
an hour before you're able to access the servers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #14 from l...@us.ibm.com ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #12)
> Can you post the updated spec file and srpm?
> 
> (See https://bugzilla.redhat.com/show_bug.cgi?id=1353000#c8 for an example
> that is in the most commonly used format which makes it easy for reviews to
> understand what has changed.)
Hi Zbigniew,

Will you be able to add me to a non CLA group?  I haven't got responses from
the groups  that I wanted to join and seems like it's going to take a while..


Vicky

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267340] Review Request: rubygem-minitest-around - Around block for minitest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267340



--- Comment #1 from Ilya Gradina  ---
New Spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-minitest-around-0.3.2-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267342] Review Request: rubygem-default_value_for - Provides a way to specify default values for ActiveRecord models

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267342

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1267340




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1267340
[Bug 1267340] Review Request: rubygem-minitest-around - Around block for
minitest
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1267340] Review Request: rubygem-minitest-around - Around block for minitest

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267340

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1267342




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1267342
[Bug 1267342] Review Request: rubygem-default_value_for - Provides a way to
specify default values for ActiveRecord models
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1358956] Review Request: sstp-client - Secure Socket Tunneling Protocol(SSTP) Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358956



--- Comment #5 from Fedora Update System  ---
sstp-client-1.0.10-5.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e73d66fc7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1358956] Review Request: sstp-client - Secure Socket Tunneling Protocol(SSTP) Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358956

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1264656] Review Request: rubygem-ace-rails-ap - The Ajax.org Cloud9 Editor.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264656



--- Comment #7 from Ilya Gradina  ---
Hi Vit,

New SPEC:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-ace-rails-ap.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-ace-rails-ap-4.1.0-1.fc24.src.rpm

the question is set: https://github.com/codykrieger/ace-rails-ap/issues/22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367569] Review Request, first package: PFT - Hacker friendly static blog generator - core library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367569

Giovanni  changed:

   What|Removed |Added

Summary|Review Request: PFT -   |Review Request, first
   |Hacker friendly static blog |package: PFT - Hacker
   |generator - core library|friendly static blog
   ||generator - core library



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1356595] Review Request: php-simplesamlphp-saml2_1 - SAML2 PHP library from SimpleSAMLphp ( version 1)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356595



--- Comment #19 from Fedora Update System  ---
php-simplesamlphp-saml2_1-1.9-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1356587] Review Request: php-simplesamlphp-saml2 - SAML2 PHP library from SimpleSAMLphp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356587



--- Comment #19 from Fedora Update System  ---
php-simplesamlphp-saml2-2.2-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367569] New: Review Request: PFT - Hacker friendly static blog generator - core library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367569

Bug ID: 1367569
   Summary: Review Request: PFT - Hacker friendly static blog
generator - core library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: da...@openmailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/dacav/pft/perl-PFT.git/plain/perl-PFT.spec


SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/dacav/pft/fedora-rawhide-x86_64/00441360-perl-PFT/perl-PFT-1.0.3-2.fc26.src.rpm


Description:
PFT stands for *Plain F. Text*, where the meaning of *F.* is up to
personal interpretation. Like *Fancy* or *Fantastic*.

It is yet another static website generator. This means your content is
compiled once and the result can be served by a simple HTTP server,
without need of server-side dynamic content generation.

This package provides the core library which abstracts away the file-system
access.


Fedora Account System Username: da...@openmailbox.org


I'm the upstream maintainer of this software, and this is the first package
software I submit, so I would need a sponsor.

The package builds fine on Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15277986

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1356587] Review Request: php-simplesamlphp-saml2 - SAML2 PHP library from SimpleSAMLphp

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356587



--- Comment #18 from Fedora Update System  ---
php-simplesamlphp-saml2-2.2-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1356595] Review Request: php-simplesamlphp-saml2_1 - SAML2 PHP library from SimpleSAMLphp ( version 1)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1356595



--- Comment #18 from Fedora Update System  ---
php-simplesamlphp-saml2_1-1.9-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #7 from Ilya Gradina  ---
Hi Vit,
Sorry for the long wait.
New SPEC:
https://raw.githubusercontent.com/ilgrad/fedora-packages/master/rubygems/rubygem-simple_oauth.spec
New SRPM:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-simple_oauth-0.3.1-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359804] Review Request: golang-github-mvo5-goconfigparser - Golang implementation of Python ConfigParser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359804



--- Comment #8 from Fedora Update System  ---
golang-github-mvo5-goconfigparser-0-0.1.gitefba970.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359804] Review Request: golang-github-mvo5-goconfigparser - Golang implementation of Python ConfigParser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359804

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-08-16 15:22:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361212] Review Request: perl-Ref-Util - Utility functions for checking references

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361212



--- Comment #11 from Fedora Update System  ---
perl-Ref-Util-0.020-2.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1361212] Review Request: perl-Ref-Util - Utility functions for checking references

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361212

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-08-16 15:22:27



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283296] Review Request: pam-u2f - PAM authentication over U2F

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283296



--- Comment #21 from James  ---
Any advance on the selinux issue?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367526] Review Request: brial - BRiAl is the successor to PolyBoRi

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367526



--- Comment #2 from Jerry James  ---
Issues
==
1. This is causing some problems:

checking size of void *... 0
checking size of int... 0
checking size of long... 0

   If you look through the build log, you'll see warnings about casting between
   pointers and integers of a different size.  This is due to the configure
   failure above.  The problem seems to be that the configure checks are linked
   with $RPM_LD_FLAGS, but compiled without %{optflags}, so the link step fails
   due to bad relocations.  The problem is this line in the spec file:

export CXXFLAGS="$CXXFLAGS -std=c++98"

   At that point, CXXFLAGS has not been set, so the $CXXFLAGS inside quotes is
   the empty string, resulting in CXXFLAGS set to " -std=c++98".  Do this
   instead:

export CXXFLAGS="%{optflags} -std=c++98"

2. The license field reflects the final binary contents.  Since the GPL, both
   versions 2 and 3, subsumes BSD, it is permissible make the license field
   read simply "GPLv2+" if you wish.  Otherwise, you need to document the
   multiple license scenario in the spec file.  See
  
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

3. In the review below, I presume that polybori will be retired.  For example,
   I don't mark that this package causes conflicts.  It does, but that will be
   handled by removing polybori.  However, that means that the "Conflicts" tag
   in the -devel package should be removed.  Instead, add "Obsoletes" and
   "Provides" tags to each package as described here:
  
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

4. The rpmlint output shows some unused direct library dependencies.  I like to
   do this after the %configure step to remove both rpaths and such unused
   dependencies:

# Get rid of undesirable hardcoded rpaths, and workaround libtool reordering
# -Wl,--as-needed after all the libraries.
sed -e 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' \
-e 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' \
-e 's|CC="\(g..\)"|CC="\1 -Wl,--as-needed"|' \
-i libtool

   It is not enough to add -Wl,--as-needed to LDFLAGS, unfortunately, since
   libtool has a long-standing bug where it reorders -Wl,--as-needed AFTER all
   of the libraries, where it does no good at all.

5. The changelog remarks that the python sources have been prepared for python
   3.  Is it possible to make both python 2 and python 3 subpackages?  Also,
   see https://fedoraproject.org/wiki/Packaging:Python for information on the
   %python_provide macro.

6. Note the rpmlint complaint about mixed use of space and tabs.  Choose one.

7. I don't like the summary line.  Yes, this is a replacement for polybori,
   but what does it DO?  Maybe reuse the polybori summary line: "Framework for
   Boolean Rings".  Along those lines, I think the description is confusing,
   since it mentions polybori, but not brial.

8. What version of cudd is bundled?  The Provides line should indicate that;
   e.g., "Provides: bundled(cudd) = 2.5.1".

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/include/polybori/ring
 (polybori-devel), /usr/include/polybori/iterators(polybori-devel),
 /usr/include/polybori/diagram(polybori-devel),
 /usr/include/polybori/orderings(polybori-devel),
 /usr/include/polybori/factories(polybori-devel),
 /usr/include/polybori/cudd(polybori-devel),
 /usr/include/polybori/common(polybori-devel), /usr/include/polybori
 (polybori-devel), /usr/include/polybori/literals(polybori-devel),
 /usr/include/polybori/cache(polybori-devel),
 /usr/include/polybori/except(polybori-devel),
 /usr/include/polybori/groebner(polybori-devel),
 /usr/include/polybori/routines(polybori-devel)
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled 

[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/ mono

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366713



--- Comment #3 from gil cattaneo  ---
(In reply to Timotheus Pokorra from comment #2)
> Thanks Gil for those suggestions!
> I have adjusted the spec file and the src.rpm accordingly:
> 
> Spec URL: https://tpokorra.fedorapeople.org/nunit2/nunit2.spec
> SRPM URL:
> https://tpokorra.fedorapeople.org/nunit2/nunit2-2.6.4-13.fc26.src.rpm

have missing:
find %{_builddir}/%{?buildsubdir}/bin -name \*.dll -exec install -p \-m0755
"{}" "%{buildroot}%{_monodir}/nunit2/" \;
find %{_builddir}/%{?buildsubdir}/bin -name \*.exe -exec install -p \-m0755
"{}" "%{buildroot}%{_monodir}/nunit2/" \;
for i in nunit-console-runner.dll nunit.core.dll nunit.core.interfaces.dll
nunit.framework.dll nunit.mocks.dll nunit.util.dll ; do
gacutil -i %{buildroot}%{_monodir}/nunit2/$i -package nunit2 -root
%{buildroot}%{_monodir}/../
done
desktop-file-install --dir=%{buildroot}/%{_datadir}/applications %{SOURCE4}
cp -p src/GuiRunner/nunit-gui-exe/App.ico
%{buildroot}/%{_datadir}/icons/NUnit2/nunit.ico

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291008] Review Request: tipl - Template image processing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291008



--- Comment #9 from Fedora Update System  ---
tipl-0-0.2.git6a59380.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-af97a2d9b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291008] Review Request: tipl - Template image processing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291008

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1291008] Review Request: tipl - Template image processing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291008



--- Comment #8 from Fedora Update System  ---
tipl-0-0.2.git6a59380.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8a9d641c47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1349604] Review Request: python-tqdm - A Fast, Extensible Progress Meter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349604



--- Comment #9 from Fedora Update System  ---
python-tqdm-4.8.3-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-58d5b9b42a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1349604] Review Request: python-tqdm - A Fast, Extensible Progress Meter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349604

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1349604] Review Request: python-tqdm - A Fast, Extensible Progress Meter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1349604



--- Comment #8 from Fedora Update System  ---
python-tqdm-4.8.3-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f7a52b0e9e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #9 from Fedora Update System  ---
libtermkey-0.18-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-da3f432a8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198



--- Comment #8 from Fedora Update System  ---
libtermkey-0.18-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0cd6b1c21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327198] Review Request: libtermkey - Library for easy processing of keyboard entry from terminal-based programs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327198

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1288882] Review Request: python-prov - W3C Provenance Data Model supporting PROV-JSON and PROV-XML import /export

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=122

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1288882] Review Request: python-prov - W3C Provenance Data Model supporting PROV-JSON and PROV-XML import /export

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=122



--- Comment #5 from Fedora Update System  ---
python-prov-1.4.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f0f53ae51

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1288882] Review Request: python-prov - W3C Provenance Data Model supporting PROV-JSON and PROV-XML import /export

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=122



--- Comment #4 from Fedora Update System  ---
python-prov-1.4.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ff5b4b7979

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327218] Review Request: libvterm - An abstract library implementation of a VT220/xterm/ ECMA-48 terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327218

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327218] Review Request: libvterm - An abstract library implementation of a VT220/xterm/ ECMA-48 terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327218



--- Comment #6 from Fedora Update System  ---
libvterm-0-0.1.bzr681.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-df8e01600e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327218] Review Request: libvterm - An abstract library implementation of a VT220/xterm/ ECMA-48 terminal emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327218



--- Comment #7 from Fedora Update System  ---
libvterm-0-0.1.bzr681.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1dbe8784a8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367536] New: Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367536

Bug ID: 1367536
   Summary: Rebase clufter component
   Product: Red Hat Enterprise Linux 6
   Version: 6.5
 Component: clufter
  Keywords: Rebase
  Severity: medium
  Priority: high
  Assignee: jpoko...@redhat.com
  Reporter: jpoko...@redhat.com
QA Contact: cluster...@redhat.com
CC: bor...@redhat.com, cfe...@redhat.com,
cluster...@redhat.com, extras...@fedoraproject.org,
jpoko...@redhat.com, lkoc...@redhat.com,
lkupr...@redhat.com, mli...@redhat.com,
nob...@fedoraproject.org,
package-review@lists.fedoraproject.org,
phag...@redhat.com, royo...@redhat.com,
rstei...@redhat.com, rwill...@redhat.com,
sa...@redhat.com, slev...@redhat.com,
tlavi...@redhat.com, vpav...@redhat.com
Depends On: 1343661
Blocks: 1328078



+++ This bug was initially created as a clone of Bug #1343661 +++

+++ This bug was initially created as a clone of Bug #1269964 +++

Upstream development of clufter has progressed (since 6.8 package
till 6.9 package + something more likely to come) so this asks for
a rebase.

More specifically, clufter received plentiful bug fixes and enhancements
compared to previous RHEL minor release (6.8/clufter-0.56.2),
notably commits in 0.56.3:

filters/coro2pcscmd[cluster,corosync]: make pcs --wait check silent
filters/configuration[cib2pcscmd]: avoid "pcs cluster cib  --config"

both of which are relevant to [bug 1328078].

... plus ...

v0.57.0
- bug fixes:
  . with *2pcscmd* commands, clufter would previously emit doubled
"pcs" at the beginning for the command defining simple order
constraint
  . with *2pcscmd* commands, clufter would previously omit and/or
logic operators between each pair of atomic expressions
forming a rule for location constraint
  . with  *2pcscmd* commands, clufter would previously disregard
master/slave roles correctly encoded with a capitalized first
letter in CIB for colocation and location constraints
- feature extensions:
  . with *2pcscmd* commands, clufter now supports resource sets
for colocation and order constraints
  . with *2pcscmd* commands, clufter now supports ticket contraints
(incl. resource sets)

v0.58.0
- bug fixes:
  . the upstream-suggested (meta) specfile and its form of advising
how to run Python intepreter (added with previous release)
turned to cause issues if setuptools are not recent enough,
so double-check that no extra double-quoting is injected
in any case
[https://github.com/pypa/setuptools/issues/188]
  . some internal-only negligence was fixed to match the design
intentions (may affect too relaxed 3rd party plugins)
- feature extensions:
  . pcs2pcscmd* commands are now aware of quorum device configured
in corosync.conf and are able to emit respective configuration
commands using pcs tool

v0.59.0
- bug fixes:
  . previously, pcs2pcscmd* commands would attempt to have quorum
device configured using "pcs quorum add" whereas the correct syntax
is "pcs quorum device add"
  . with {cib,pcs}2pcscmd* commands, clufter no longer chokes on
validation failures (unless --nocheck provided) due to source CIB
file using newer "validate-with" validation version specification
than supported so far, such as with pacemaker-2.5 introducing the
alert handlers stanza in CIB, because the support has been extended
up that very version (only affects deployments that do not borrow
the schemas from the installed pacemaker on-the-fly during a build
stage, which is not the case when building RPMs using the upstream
specfile)
- feature extensions:
  . {cib,pcs}2pcscmd* commands are now aware of configured alert
handlers in CIB and able to emit respective configuration
commands using pcs tool
- functional changes:
  . due to too many moving targets (corosync, pacemaker, pcs) with
features being gradually added, clufter as of this release
relies on the specified distribution target (which basically boils
down to snapshot of the supported features, as opposed to passing
zillion extra parameters expressing the same) stronger than ever;
this has several implications: do not expect that one sequence
of pcs commands at the clufter's output is portable to completely
different environment, and your distribution/setup may not be
supported (I try to cover Fedora, RHEL+derivates, Debian and Ubuntu
directly) in which case facts.py (where everything is tracked)

[Bug 1343661] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343661

Jan Pokorný  changed:

   What|Removed |Added

 Blocks||1367536




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1367536
[Bug 1367536] Rebase clufter component
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367526] Review Request: brial - BRiAl is the successor to PolyBoRi

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367526

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Jerry James  ---
I will take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1276624] Review Request: swagger-core - Java implementation of Swagger

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276624



--- Comment #21 from Fedora Update System  ---
swagger-core-1.5.7-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2ad426c4c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1365144] Review Request: aries-blueprint-core - Apache Aries Blueprint Core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365144

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
aries-blueprint-core-1.6.2-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5e771fa7c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366568] Review Request: perl-Test-MockRandom - Replaces random number generation with non-random number generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366568

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
perl-Test-MockRandom-1.01-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ec8f5c44b8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366017] Review Request: aries-blueprint-cm - Apache Aries Blueprint CM

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366017

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
aries-blueprint-cm-1.0.8-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0d2ae5e36

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1348778] Review Request: ansible-review - Reviews Ansible playbooks, roles and inventory and suggests improvements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348778

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
ansible-review-0.9.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-24798fcf0b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1205248] Review Request: jaxws-undertow-httpspi - Undertow to JAXWS 2.2 HTTP SPI bridge

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1205248

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
jaxws-undertow-httpspi-1.0.1-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3762203847

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367526] New: Review Request: brial - BRiAl is the successor to PolyBoRi

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367526

Bug ID: 1367526
   Summary: Review Request: brial - BRiAl is the successor to
PolyBoRi
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: paulo.cesar.pereira.de.andr...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://pcpa.fedorapeople.org/brial.spec
SRPM URL: https://pcpa.fedorapeople.org/brial-0.8.5-1.fc26.src.rpm
Description: The core of PolyBoRi is a C++ library, which provides high-level
data
types for Boolean polynomials and monomials, exponent vectors, as well
as for the underlying polynomial rings and subsets of the powerset of
the Boolean variables. As a unique approach, binary decision diagrams
are used as internal storage type for polynomial structures. On top of
this C++-library we provide a Python interface. This allows parsing of
complex polynomial systems, as well as sophisticated and extendable
strategies for Gröbner base computation. PolyBoRi features a powerful
reference implementation for Gröbner basis computation.
Fedora Account System Username: pcpa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 968136] Review Request: camel - Apache Camel integration framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=968136

gil cattaneo  changed:

   What|Removed |Added

 Depends On||1367518




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1367518
[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client
for Java
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518

gil cattaneo  changed:

   What|Removed |Added

 Blocks||968136




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=968136
[Bug 968136] Review Request: camel - Apache Camel integration framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] New: Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518

Bug ID: 1367518
   Summary: Review Request: async-http-client1 - Asynchronous Http
Client for Java
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: punto...@libero.it
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://gil.fedorapeople.org/async-http-client1.spec
SRPM URL: https://gil.fedorapeople.org/async-http-client1-1.9.39-1.fc24.src.rpm
Description:
Async Http Client library purpose is to allow Java applications to
easily execute HTTP requests and asynchronously process the HTTP
responses. The Async HTTP Client library is simple to use.
Fedora Account System Username: gil


Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15276444

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1303569] Review Request: uflash - An utility to flash Python onto the BBC micro:bit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303569

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1303569] Review Request: uflash - An utility to flash Python onto the BBC micro:bit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303569



--- Comment #7 from Fedora Update System  ---
uflash-1.0.3-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-389585fba2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 913605] Review Request: NFStest - NFS Testing Tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=913605

Lorenzo Dalrio  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-08-16 10:55:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360277] Review Request: qt-installer-framework - The Qt Installer Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360277

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu
  Alias||qt-installer-framework



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360277] Review Request: qt-installer-framework - The Qt Installer Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360277

Helio Chissini de Castro  changed:

   What|Removed |Added

 Blocks||928937 (qt-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360255] Review Request: qt5-qtcharts - Qt Charts module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360255

Rex Dieter  changed:

   What|Removed |Added

  Alias||qt5-qtcharts



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360258] Review Request: qt5-qtserialbus - The Qt Serial Bus API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360258

Rex Dieter  changed:

   What|Removed |Added

  Alias||qt5-qtserialbus



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360284] Review Request: qt5-qtdeclarative-render2d - Render 2D QtDeclarative component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360284

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu
 Blocks||928937 (qt-reviews)
  Alias||qt5-qtdeclarative-render2d




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360255] Review Request: qt5-qtcharts - Qt Charts module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360255

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu
 Blocks||928937 (qt-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360258] Review Request: qt5-qtserialbus - The Qt Serial Bus API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360258

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rdie...@math.unl.edu
 Blocks||928937 (qt-reviews)
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1358918] Review Request: qtwebbrowser - QtWebEngine based browser for embedded touch devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358918

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Flags||fedora-review?



--- Comment #5 from Rex Dieter  ---
I can help review this today...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1360199] Review Request: snap-confine - Confinement system for snap applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360199



--- Comment #17 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/snap-confine

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367407] Review Request: golang-gopkg-go-macaroon-macaroon - A native Go implementation of macaroons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367407



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-gopkg-go-macaroon-macaroon

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1363825] Review Request: perl-LWP-UserAgent-DNS-Hosts - Override LWP HTTP/HTTPS request' s host like /etc/hosts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363825

Carl George  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-08-16 09:19:57



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1342839

Miro Hrončok  changed:

   What|Removed |Added

  Flags||needinfo?(lmac...@redhat.co
   ||m)



--- Comment #16 from Miro Hrončok  ---
I have an update ready of one package, that needs this. Can I proceed with
building the attached SRPM?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org