[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #10 from Igor Gnatenko  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #9)
> Thanks for the patches. I'm against using sed instead of patches, it won't
> fail when patch no longer applies.
In my patch I didn't remove any of your patches.

Can you update spec and srpm, so I will do final round of review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324784] Review Request: pseudo - Advanced tool for simulating superuser privileges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324784



--- Comment #9 from Dominik 'Rathann' Mierzejewski  ---
Thanks for the patches. I'm against using sed instead of patches, it won't fail
when patch no longer applies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374957] New: Review Request: python-colorspacious - Perform colorspace conversions accurately and easily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374957

Bug ID: 1374957
   Summary: Review Request: python-colorspacious - Perform
colorspace conversions accurately and easily
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: domi...@greysector.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspacious.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-colorspacious/python-colorspacious-1.0.0-2.fc26.src.rpm
Description:
Colorspacious is a powerful, accurate, and easy-to-use library for
performing colorspace conversions.

In addition to the most common standard colorspaces (sRGB, XYZ, xyY,
CIELab, CIELCh), we also include: color vision deficiency ("color
blindness") simulations using the approach of Machado et al (2009);
a complete implementation of CIECAM02; and the perceptually uniform
CAM02-UCS / CAM02-LCD / CAM02-SCD spaces proposed by Luo et al (2006).

Fedora Account System Username: rathann

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #11 from Germano Massullo  ---
(In reply to gil cattaneo from comment #9)
> Because of Comment#6

It is an application, not a library, so you are not forced to provide both
Python 2 & 3 versions at the same time

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #10 from Germano Massullo  ---
(In reply to gil cattaneo from comment #9)
> 
> (In reply to Germano Massullo from comment #8)
> > (In reply to gil cattaneo from comment #7)
> > > Please, remove "%if 0%{?with_python2}" and
> > > replace "%if 0%{?with_python3}" with "%if 0%{?el7}"
> > 
> > Why? The package either installs Python 2 version or Python3 version
> > depending on which Python interpreter version is shipped with the system
> 
> Because of Comment#6 and is not safe use your approch in the spec file
> i suggested of revrite your spec file using the template mentioned above.

Please define "not safe"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #9 from gil cattaneo  ---


(In reply to Germano Massullo from comment #8)
> (In reply to gil cattaneo from comment #7)
> > Please, remove "%if 0%{?with_python2}" and
> > replace "%if 0%{?with_python3}" with "%if 0%{?el7}"
> 
> Why? The package either installs Python 2 version or Python3 version
> depending on which Python interpreter version is shipped with the system

Because of Comment#6 and is not safe use your approch in the spec file
i suggested of revrite your spec file using the template mentioned above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #8 from Germano Massullo  ---
(In reply to gil cattaneo from comment #7)
> Please, remove "%if 0%{?with_python2}" and
> replace "%if 0%{?with_python3}" with "%if 0%{?el7}"

Why? The package either installs Python 2 version or Python3 version depending
on which Python interpreter version is shipped with the system

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Ben Rosser  changed:

   What|Removed |Added

Summary|Review Request: libquasselc |Review Request: quasselc -
   |- API to access a Quassel   |API to access a Quassel
   |Core in pure C  |Core in pure C



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374898] Review Request: libquasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898



--- Comment #2 from Ben Rosser  ---
Whoops. I'd apparently forgotten that github URLs worked like that, my bad!
Fixed, also added the hash to the release tag.

Renamed to "quasselc" (upstream's makefile installs files into
/usr/include/quasselc so this name is acceptable). I wasn't entirely sure which
name would be better. 

Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/quasselc.spec
SRPM URL:
https://tc01.fedorapeople.org/quassel/quassel-irssi/quasselc-0-0.1.20160909gitfcd9669.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366878] Review Request: python-attrs - Python attributes without boilerplate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366878



--- Comment #17 from Fedora Update System  ---
python-attrs-16.0.0-5.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370913] Review Request: artemis-wildfly-integration - ActiveMQ Artemis WildFly Integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370913

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-10 17:00:19



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373244] Review Request: perl-Path-Iterator-Rule - Iterative, recursive file finder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373244
Bug 1373244 depends on bug 1373243, which changed state.

Bug 1373243 Summary: Review Request: perl-Test-Filename - Portable filename 
comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1373243

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370913] Review Request: artemis-wildfly-integration - ActiveMQ Artemis WildFly Integration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370913



--- Comment #6 from Fedora Update System  ---
artemis-wildfly-integration-1.0.2-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243



--- Comment #8 from Fedora Update System  ---
perl-Test-Filename-0.03-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373243

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-10 17:00:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366878] Review Request: python-attrs - Python attributes without boilerplate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366878

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-09-10 16:55:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366878] Review Request: python-attrs - Python attributes without boilerplate

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366878



--- Comment #16 from Fedora Update System  ---
python-attrs-16.0.0-5.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1371635] Review Request: adobe-source-serif-pro-fonts - A set of OpenType fonts designed to complement Source Sans Pro

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1371635



--- Comment #9 from Fedora Update System  ---
adobe-source-serif-pro-fonts-1.017-2.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1370874] Review Request: gap-pkg-automata - Finite automata algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370874



--- Comment #15 from Fedora Update System  ---
gap-pkg-automata-1.13-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1079064] Review Request: btbuilder - Role-playing game construction set in the style of the Bard' s Tale Construction Set

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079064



--- Comment #46 from Fedora Update System  ---
btbuilder-0.5.11-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1079064] Review Request: btbuilder - Role-playing game construction set in the style of the Bard' s Tale Construction Set

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079064

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-09-09 17:47:23 |2016-09-10 16:54:25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374948] Review Request: dynamips - Cisco router emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374948



--- Comment #1 from Athmane Madjoudj  ---
We had before some attempt to package this, I'm giving it a try since the
policy regarding emulator has been relaxed.

Below Copr build [1], please note that there's a binary blob (mips microcode),
I've asked upstream to provide more details (license and step to build from
source) [2]

[1] https://copr.fedorainfracloud.org/coprs/athmane/gns3-extra/build/451517/

[2] https://github.com/GNS3/dynamips/issues/75

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374948] New: Review Request: dynamips - Cisco router emulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374948

Bug ID: 1374948
   Summary: Review Request: dynamips - Cisco router emulator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: athma...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/dynamips.spec
SRPM URL:
https://athmane.fedorapeople.org/pkgs/gns3/dynamips-0.2.16-1.fc24.src.rpm
Description:
Dynamips emulates Cisco 7200/3600/3725/3745/2691 routers on a traditional PC.

Fedora Account System Username: athmane

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374947] Review Request: vpcs - Virtual PC Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374947



--- Comment #1 from Athmane Madjoudj  ---
Copr build: 
https://copr.fedorainfracloud.org/coprs/athmane/gns3-extra/build/451518/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374947] New: Review Request: vpcs - Virtual PC Simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374947

Bug ID: 1374947
   Summary: Review Request: vpcs - Virtual PC Simulator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: athma...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://athmane.fedorapeople.org/pkgs/gns3/vpcs.spec
SRPM URL:
https://athmane.fedorapeople.org/pkgs/gns3/vpcs-0.8.0svn126-1.fc24.src.rpm
Description: 
The VPCS can simulate up to 9 PCs. You can ping/traceroute them, or 
ping/traceroute the other hosts/routers from the VPCS


Fedora Account System Username: athmane

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359110] Review Request: xreader - Simple document viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359110

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-09-10 14:43:55



--- Comment #5 from Mario Blättermann  ---
Sorry, I don't have the time to continue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #7 from gil cattaneo  ---
Please, remove "%if 0%{?with_python2}" and
replace "%if 0%{?with_python3}" with "%if 0%{?el7}"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359392] Review Request: xviewer-plugins - A collection of plugins for xviewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359392

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-09-10 14:42:37



--- Comment #1 from Mario Blättermann  ---
Sorry, I don't have the time to continue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1358699] Review Request: xed - A small and lightweight text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1358699

Mario Blättermann  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-09-10 14:41:27



--- Comment #4 from Mario Blättermann  ---
Sorry, I don't have the time to continue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1359392] Review Request: xviewer-plugins - A collection of plugins for xviewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359392
Bug 1359392 depends on bug 1354210, which changed state.

Bug 1354210 Summary: Review Request: xviewer - Fast and functional graphics 
viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354210

Mario Blättermann  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(mario.blaetterman |
   |n...@gmail.com)|
Last Closed||2016-09-10 14:39:56



--- Comment #15 from Mario Blättermann  ---
(In reply to Raphael Groner from comment #12)
> Friendly reminder. Are you still interested in this package?

Sorry, I'm pretty busy with other things, especially translations. Those have
priority for me, and actually I feel unable to maintain more packages than my
current ones... Well, submitting Cinnamon's X-apps for review was a result of
the first euphoria after noticing their releases. But I really don't have the
time to continue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1344294] Review Request: warsow-data - Game data for Warsow

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344294

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Raphael Groner  ---
APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357064

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #26 from Raphael Groner  ---
Thanks for the review!

I'll look into the open points while importing the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #6 from Igor Gnatenko  ---
Package should contain both py2 and py3 subpackages and make use of
%python_provide macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #5 from gil cattaneo  ---
Issues:
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt
All source files are without license headers. Please, ask to upstream to
confirm the
licensing of code and/or content/s, and ask to add license headers
   
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

python-django-netjsongraph.noarch: E: description-line-too-long C Requires:
  python3-django-rest-framework >= 3.3, python3-django-rest-framework < 3.4
python-django-netjsongraph.noarch: W: tag-in-description C Requires:
python-django-netjsongraph.noarch: W: tag-in-description C Requires:
python-django-netjsongraph.noarch: W: tag-in-description C Requires:
python-django-netjsongraph.noarch: E: no-changelogname-tag
python-django-netjsongraph.noarch: E: wrong-script-interpreter
/usr/lib/python3.5/site-packages/tests/manage.py /usr/bin/env python
python-django-netjsongraph.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/tests/manage.py 644 /usr/bin/env python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #4 from gil cattaneo  ---
(In reply to Germano Massullo from comment #2)
> (In reply to gil cattaneo from comment #1)
> > i dont uderstand this part of your spec file:
> >...
> > 
> > the python2 package is available only in EL7?
> > otherwise you should use this template
> > https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
> 
> Python 3 is available only on Fedora

Yes but in fedora is available Python2 also ...
and my hint can solve this problem:
python-django-netjsongraph.noarch: E: description-line-too-long C Requires:
  python3-django-rest-framework >= 3.3, python3-django-rest-framework < 3.4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #3 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have
 unknown license. Detailed output of licensecheck in /home/gil/1369213
 -python-django-netjsongraph/licensecheck.txt
All source files are without license headers. Please, ask to upstream to
confirm the
licensing of code and/or content/s, and ask to add license headers
   
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python3.5/site-
 packages/tests(python3-repoze-who-plugins-sa, python3-custodia,
 python3-journal-brief, python3-django-federated-login,
 python3-oauth2), /usr/lib/python3.5/site-
 packages/tests/__pycache__(python3-repoze-who-plugins-sa,
 python3-custodia, python3-oauth2, python3-django-federated-login)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[?]: A package which is used by another package via an egg interface should
 provide egg info.
[?]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec 

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #2 from Germano Massullo  ---
(In reply to gil cattaneo from comment #1)
> i dont uderstand this part of your spec file:
>...
> 
> the python2 package is available only in EL7?
> otherwise you should use this template
> https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

Python 3 is available only on Fedora

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213



--- Comment #1 from gil cattaneo  ---
i dont uderstand this part of your spec file:

%description -n python-%{pypi_name}
django-netjsongraph is a network topology collector and
network topology visualizer.
It supports collecting network topology from OLSR,
BATMAN-advanced, BMX and NetJSON NetworkGraph.
%{?python_provide:%python_provide python-%{pypi_name}}
%if 0%{?with_python2}
Requires:   python2-django >= 1.9, python2-django < 1.10
Requires:   python2-django-model-utils
Requires:   python2-django-rest-framework >= 3.3,
python2-django-rest-framework < 3.4
Requires:   python2-netdiff >= 0.4.7, python2-netdiff <= 5.0
Requires:   python2-six
%endif

%if 0%{?with_python3}
Requires:   python3-django >= 1.9, python3-django < 1.10
Requires:   python3-django-model-utils
Requires:   python3-django-rest-framework >= 3.3,
python3-django-rest-framework < 3.4
Requires:   python3-netdiff >= 0.4.7, python3-netdiff <= 5.0
Requires:   python3-six
%endif

the python2 package is available only in EL7?
otherwise you should use this template
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for ALSA

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457



--- Comment #9 from Christos Triantafyllidis 
 ---
Hello Raphael,

While I'll be reviewing the rest can you please have a look at the only issue
flagged by fedora-reviewer:
[!]: Package should not use obsolete m4 macros
 Note: Some obsoleted macros found, see the attachment.
 See: https://fedorahosted.org/FedoraReview/wiki/AutoTools

AutoTools: Obsoleted m4s found
--
  AM_PROG_LIBTOOL found in: cava-
  0360e8872e405ca1bbd09d290e9e1b87b4be60e4/configure.ac:9


Expect an update with the full review results later today or tomorrow (no need
to upload a new SPEC/SRPM before my full review).

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1369213] python-django-netjsongraph - Reusable django app for collecting and visualizing network topology

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369213

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Germano Massullo  changed:

   What|Removed |Added

   Priority|medium  |high
 CC||germano.massu...@gmail.com
   Assignee|nob...@fedoraproject.org|germano.massu...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for ALSA

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457

Raphael Groner  changed:

   What|Removed |Added

Summary|Review Request: cava -  |Review Request: cava -
   |Console-based Audio |Console-based Audio
   |Visualizer for Alsa |Visualizer for ALSA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for Alsa

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard|NotReady|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Christos Triantafyllidis  changed:

   What|Removed |Added

  Flags||needinfo?(steve.traylen@cer
   ||n.ch)



--- Comment #16 from Christos Triantafyllidis 
 ---
Hey Steve,

Are you still available to review that?

I'll update the request later today to current upstream version (0.8.1).

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for Alsa

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457



--- Comment #8 from Raphael Groner  ---
In latest snapshot upstream supports now to unbundle iniparser, also version 3.
Please be aware that we build against iniparser 4.0 in Rawhide but still 3.1 in
other Fedoras.

Spec URL: https://raphgro.fedorapeople.org/review/util/cava.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/util/cava-0.4.1-2.20160909git0360e88.fc24.src.rpm
Description: Console-based Audio Visualizer for ALSA

Test builds:
https://copr.fedorainfracloud.org/coprs/raphgro/review/package/cava/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1123579] Review Request: rubygem-colorize - Add color methods to String class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123579

Germano Massullo  changed:

   What|Removed |Added

   Priority|medium  |urgent



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372999] Review Request: rubygem-http_parser.rb - Simple callback-based HTTP request/ response parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372999



--- Comment #7 from Matthias Runge  ---
(In reply to Vít Ondruch from comment #5)
> Just FYI, this [1] is one of the first documents one interested in Fedora
> packaging should read. Let me quote from it:
> 
> ```
> Before submitting your request, be sure there’s not a previous request for
> the same package. There is a convenient search box on the package review
> status page. 
> ```
> 
> It would be nice if you can follow this advice, thx.

I'm sorry, this slipped through here. The package has been reviewed and
imported. Maybe the current maintainer and the submitter of the other review
can collaborate on maintenance?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518



--- Comment #4 from Fedora Update System  ---
async-http-client1-1.9.39-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-032228faa1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for Alsa

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457

Raphael Groner  changed:

   What|Removed |Added

 Depends On|1346451 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1346451
[Bug 1346451] iniparser-4.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367518] Review Request: async-http-client1 - Asynchronous Http Client for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367518

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270622] Review Request: sdb - The string database from radare reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270622

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1368855 (radare2)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368855
[Bug 1368855] Review Request: radare2 - The reverse engineering framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368855] Review Request: radare2 - The reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368855

Igor Gnatenko  changed:

   What|Removed |Added

 Depends On||1270622 (sdb)



--- Comment #1 from Igor Gnatenko  ---
Please unbundle sdb as you packaged it.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1270622
[Bug 1270622] Review Request: sdb - The string database from radare reverse
engineering framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270622] Review Request: sdb - The string database from radare reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270622

Igor Gnatenko  changed:

   What|Removed |Added

  Alias||sdb



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270622] Review Request: sdb - The string database from radare reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270622



--- Comment #4 from Igor Gnatenko  ---
Few notes here:
* LDFLAGS are ignored
* Missing BuildRequires: gcc
* Redundant BuildRequires: vala-devel (should be just vala)
* %make_build and %make_install are preferred way
* Group tag is redundant
* vapi files should go under devel subpackage
* Tests are not ran
* BR: nodejs-devel is not needed as you don't package nodejs lib from tree
* BR: leveldb-devel is not needed unless you run tests
* Timestamps are not preserved

Probably there are more issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368855] Review Request: radare2 - The reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368855

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373821] Review Request: python-pulp - LP modeler written in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373821

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #6 from Marcos  ---
Hi Igor,

Thanks for review and sorry because I didn't update the files at github.
Please, check again and write your comments.

Spec URL:
https://github.com/marcosflobo/package_review/blob/master/pulp/1.6.1/python-pulp.spec
SRPM URL:
https://github.com/marcosflobo/package_review/raw/master/pulp/1.6.1/python-PuLP-1.6.1-1.fc24.src.rpm


Successful scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=15559934

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1372999] Review Request: rubygem-http_parser.rb - Simple callback-based HTTP request/ response parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372999



--- Comment #6 from Igor Gnatenko  ---
(In reply to Vít Ondruch from comment #5)
> It would be nice if you can follow this advice, thx.
It actually seems like mafia. Someone needs package, so he packages it and
sends for review and asks for friend to review it - done.

I would also prefer to see Fedora rule followed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367976] Review Request: rubygem-contracts - Contracts for Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367976

Mamoru TASAKA  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-09-10 05:19:11



--- Comment #7 from Mamoru TASAKA  ---
Imported into rawhide. thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373155] Review Request: perl-Test-Toolbox - Tools for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373155

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
perl-String-Util-1.26-1.fc25, perl-Test-Toolbox-0.4-1.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-86f77ef0ed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546



--- Comment #72 from Fedora Update System  ---
soletta-1-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a45444cb7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374642] Review Request: perl-Number-Range - Extension to work with ranges of numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374642

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
perl-Number-Range-0.12-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d294d28454

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1373244] Review Request: perl-Path-Iterator-Rule - Iterative, recursive file finder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373244

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
perl-Path-Iterator-Rule-1.012-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fdec559075

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374898] Review Request: libquasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #1 from Igor Gnatenko  ---
> Name: libquasselc
I think we should take original name - quasselc or QuasselC (depending how
upstream feel)

> Release:0.1.20160909git%{?dist}
This is allowed, but I would prefer to have in format
%{gitdate}git%{shortcommit}

> License:GPLv3
GPLv3+

> Source0:libquassel-20160909git.tar.gz
https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374898] Review Request: libquasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1079064] Review Request: btbuilder - Role-playing game construction set in the style of the Bard' s Tale Construction Set

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079064

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||panem...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #45 from Parag AN(पराग)  ---
As this package is built in Fedora, I don't think this should block for
FE-NEEDSPONSOR.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899



--- Comment #1 from Ben Rosser  ---
Also should be noted that the patch here
https://patch-diff.githubusercontent.com/raw/phhusson/quassel-irssi/pull/19.patch
is a pull request I opened against quassel-irssi; see
https://github.com/phhusson/quassel-irssi/pull/19.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374898] Review Request: libquasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1374899




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1374899
[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to
quassel core
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374899] Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899

Ben Rosser  changed:

   What|Removed |Added

 Depends On||1374898




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1374898
[Bug 1374898] Review Request: libquasselc - API to access a Quassel Core in
pure C
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374899] New: Review Request: quassel-irssi - An irssi plugin to connect to quassel core

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374899

Bug ID: 1374899
   Summary: Review Request: quassel-irssi - An irssi plugin to
connect to quassel core
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rosser@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi.spec
SRPM URL:
https://tc01.fedorapeople.org/quassel/quassel-irssi/quassel-irssi-0-0.1.20160909git.fc24.src.rpm
Description: An irssi plugin that supports connecting to a quassel core.
Fedora Account System Username: tc01

rpmlint complains that libquassel-core.so is not stripped, which presumably is
why no debuginfo package is generated. I'm not sure why the stripping doesn't
happen automatically though.

Requires libquasselc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1374898] New: Review Request: libquasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Bug ID: 1374898
   Summary: Review Request: libquasselc - API to access a Quassel
Core in pure C
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rosser@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://tc01.fedorapeople.org/quassel/quassel-irssi/libquasselc.spec
SRPM URL:
https://tc01.fedorapeople.org/quassel/quassel-irssi/libquasselc-0-0.1.20160909git.fc24.src.rpm
Description: An implementation of the Quassel protocol in pure C.
Fedora Account System Username: tc01

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #71 from Fedora Update System  ---
soletta-1-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f80075e7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1079064] Review Request: btbuilder - Role-playing game construction set in the style of the Bard' s Tale Construction Set

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079064

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #44 from Fedora Update System  ---
btbuilder-0.5.11-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9f6d40c04f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org