[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369708



--- Comment #34 from yunying@intel.com ---
(In reply to lo1 from comment #32)
> (In reply to yunying.sun from comment #31)
> > (In reply to lo1 from comment #30)
> By the way, the format of the changelog,
> in particular the version-release at the end is not the expected.   You can
> search for "%changelog:" in the link:
> https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Introduction
> 
Thanks for notice Vicky. I've updated SPEC to use V-R format in %changelog. 

Updated SPEC:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tss.spec
Updated SRPMS:
https://github.com/yunyings/share/raw/master/tpm2-tss-1.0-0.1.beta1.el7.src.rpm

Succeeded Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15854449
Succeeded COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tss/build/458998/

Any review comments are appreciated. Also could someone help to approve this
review request if no more issues? Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #12 from yunying@intel.com ---
SPEC updated to use version-release format in SPEC %changelog.

Updated SPEC:
https://raw.githubusercontent.com/yunyings/share/master/tpm2-tools.spec
Updated SRPMS:
https://github.com/yunyings/share/raw/master/tpm2-tools-1.1-0.1.beta1.el7.src.rpm
COPR build:
https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tools/build/459000/

Anyone could kindly help on the review and approve? Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377444



--- Comment #8 from Fedora Update System  ---
imapsync-1.727-1.fc24, perl-JSON-WebToken-0.10-1.fc24,
perl-Test-Mock-Guard-0.10-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4980b97ebd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #18 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-907c9f843e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378999



--- Comment #8 from Fedora Update System  ---
imapsync-1.727-1.fc24, perl-JSON-WebToken-0.10-1.fc24,
perl-Test-Mock-Guard-0.10-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4980b97ebd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379814] Review Request: vulkan - Vulkan loader and validation layers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379814



--- Comment #11 from Fedora Update System  ---
vulkan-1.0.26.0-3.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d52c05442d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379094] Review Request: python-flit - Simplified packaging of Python modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379094



--- Comment #6 from gil cattaneo  ---
(In reply to Mukundan Ragavan from comment #5)
> Could not get to these today ... sorry about the delay.
No problems, thanks for your work
> As far as bundled goes, flit is not really bundling the entire tornado
> library - is it still necessary to add provides for bundled? 

Unfortunately, that's the way it is ... that pain in ... Sorry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379091] Review Request: python-QtPy - Provides an abstraction layer on top of the various Qt bindings (PyQt5, PyQt4 and PySide) and additional custom QWidgets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379091



--- Comment #2 from Mukundan Ragavan  ---
hmm ... pypi tarball does not have the license. I will fix these and upload new
spec and srpm tomorrow.

sorry about the delay.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379094] Review Request: python-flit - Simplified packaging of Python modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379094



--- Comment #5 from Mukundan Ragavan  ---
Could not get to these today ... sorry about the delay.

As far as bundled goes, flit is not really bundling the entire tornado library
- is it still necessary to add provides for bundled? to me it seems unnecessary
.. thoughts?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377444



--- Comment #7 from Fedora Update System  ---
imapsync-1.727-1.fc23, perl-JSON-WebToken-0.10-1.fc23,
perl-Test-Mock-Guard-0.10-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d9ea875fa1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378999



--- Comment #7 from Fedora Update System  ---
imapsync-1.727-1.fc23, perl-JSON-WebToken-0.10-1.fc23,
perl-Test-Mock-Guard-0.10-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d9ea875fa1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379814] Review Request: vulkan - Vulkan loader and validation layers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379814



--- Comment #10 from Fedora Update System  ---
vulkan-1.0.26.0-3.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ea8dcc9d15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #17 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9542819fdd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377444



--- Comment #6 from Fedora Update System  ---
imapsync-1.727-1.el7, perl-JSON-WebToken-0.10-1.el7,
perl-Test-Mock-Guard-0.10-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3f52c73207

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378999



--- Comment #6 from Fedora Update System  ---
imapsync-1.727-1.el7, perl-JSON-WebToken-0.10-1.el7,
perl-Test-Mock-Guard-0.10-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-3f52c73207

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283



--- Comment #16 from Fedora Update System  ---
obconf-qt-0.11.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d3d78b1f9e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #7 from Michael Cullen  ---
Created attachment 1205720
  --> https://bugzilla.redhat.com/attachment.cgi?id=1205720=edit
licensecheck output

Attached licensecheck output - there's some BSD stuff, some MIT, some GPL and
some other.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218

Michael Cullen  changed:

   What|Removed |Added

 CC||mich...@cullen-online.com



--- Comment #6 from Michael Cullen  ---
In order to keep this moving, here are some comments:

Personally, I'd prefer to see a comment in the spec file so I don't have to
open the patch files to see what they do.

Secondly, there's a new release you should package (1.1.0) but it was only
released yesterday so I understand why it isn't here.

Here's a review from fedora-review. Mostly it looks alright, but I'm concerned
about the licenses around the examples. also, that static library really
shouldn't exist!

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: libzstd-devel. Does not provide -static:
  libzstd-devel.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- Newer version is now available
- LICENSE-examples not added as a license file, but examples are shipped
- According to LICENSE-examples, examples are "for non-commercial testing and
evaluation purposes only" which is not acceptable in Fedora packages
- example Makefile is GPLv2 which should be added to the license list in the
-devel package at least

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
 like)", "zlib/libpng", "BSD (3 clause)", "BSD (2 clause)". 110 files
 have unknown license. Detailed output of licensecheck in
 /home/rpmbuilder/1373218-zstd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 10 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is 

[Bug 1374957] Review Request: python-colorspacious - Perform colorspace conversions accurately and easily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374957



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-colorspacious

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/exodusii

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368845] Review Request: rubygem-forwardable-extended - Forwardable with hash, and instance variable extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368845



--- Comment #17 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el6, rubygem-forwardable-extended-2.6.0-1.el6,
rubygem-jekyll-sass-converter-1.4.0-1.el6, rubygem-jekyll-watch-1.5.0-1.el6,
rubygem-mercenary-0.3.6-1.el6, rubygem-pathutil-0.14.0-1.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368849] Review Request: rubygem-pathutil - Faster pure Ruby implementation of Pathname with extra bits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368849



--- Comment #17 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el6, rubygem-forwardable-extended-2.6.0-1.el6,
rubygem-jekyll-sass-converter-1.4.0-1.el6, rubygem-jekyll-watch-1.5.0-1.el6,
rubygem-mercenary-0.3.6-1.el6, rubygem-pathutil-0.14.0-1.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368847] Review Request: rubygem-jekyll-watch - Rebuild your Jekyll site when a file changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368847



--- Comment #17 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el6, rubygem-forwardable-extended-2.6.0-1.el6,
rubygem-jekyll-sass-converter-1.4.0-1.el6, rubygem-jekyll-watch-1.5.0-1.el6,
rubygem-mercenary-0.3.6-1.el6, rubygem-pathutil-0.14.0-1.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368846] Review Request: rubygem-jekyll-sass-converter - Basic Sass converter for Jekyll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368846



--- Comment #17 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el6, rubygem-forwardable-extended-2.6.0-1.el6,
rubygem-jekyll-sass-converter-1.4.0-1.el6, rubygem-jekyll-watch-1.5.0-1.el6,
rubygem-mercenary-0.3.6-1.el6, rubygem-pathutil-0.14.0-1.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368848] Review Request: rubygem-mercenary - An easier way to build your command-line scripts in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368848



--- Comment #17 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el6, rubygem-forwardable-extended-2.6.0-1.el6,
rubygem-jekyll-sass-converter-1.4.0-1.el6, rubygem-jekyll-watch-1.5.0-1.el6,
rubygem-mercenary-0.3.6-1.el6, rubygem-pathutil-0.14.0-1.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368844] Review Request: rubygem-colorator - Colorize your text in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368844



--- Comment #18 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el6, rubygem-forwardable-extended-2.6.0-1.el6,
rubygem-jekyll-sass-converter-1.4.0-1.el6, rubygem-jekyll-watch-1.5.0-1.el6,
rubygem-mercenary-0.3.6-1.el6, rubygem-pathutil-0.14.0-1.el6 has been pushed to
the Fedora EPEL 6 stable repository. If problems still persist, please make
note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369708



--- Comment #33 from l...@us.ibm.com ---
> No, I dont think the Fedora 24 local build is mandatory.  Sorry, I totally
> ignored the koji and copr for some reasons.  To clarify, Koji and Copr build
> would be more appropriate and "clean" as my local one.
Typo corrected:
To clarify, Koji and Copr build would be more appropriate and "clean" than my
local one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369708



--- Comment #32 from l...@us.ibm.com ---
(In reply to yunying.sun from comment #31)
> (In reply to lo1 from comment #30)
> > Changelog needs to be updated every time you make changes:
> > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> > Guidelines#Changelogs
> > 
> Thanks for the review Vicky. About change logs, on wiki it says "Every time
> you make changes, that is, whenever you increment the E-V-R of a package,
> add a changelog entry. ". My understanding is only when version and/or
> release is updated, changelog needed. 
> 
> In my case, the target version/release is the package's first release,
> 1.0-beta1, not changed. So I suppose it's better not to log every detailed
> changes which I made to fix issues found during review, otherwise the
> changelog would be long and full of minor details. Is it acceptable?
> 

You're right.  You can do this any number of times, until you actually build
1.0-0.1.beta1 in the buildsystem. By the way, the format of the changelog, in
particular the version-release at the end is not the expected.   You can search
for "%changelog:" in the link:
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Introduction

> > 
> > 
> > The package failed to build on Fedora 24 (x86_64) as below:
> > 
> Your build failed due to not finding g++. But on koji build server and COPR,
> this package does compile successfully. I did local rpmbuild on my desktop
> with RHEL 7.3 Alpha(No Fedora 24 environment so far). Does Fedora 24 local
> build is mandatory for new package?

No, I dont think the Fedora 24 local build is mandatory.  Sorry, I totally
ignored the koji and copr for some reasons.  To clarify, Koji and Copr build
would be more appropriate and "clean" as my local one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354018



--- Comment #3 from Jared Smith  ---
Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-utfx/nodejs-utfx-1.0.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379460

Jan Chaloupka  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Jan Chaloupka  ---
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290576] Review Request: nodejs-json-schema - JSON Schema specifications, reference schemas, and a CommonJS implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290576



--- Comment #6 from Piotr Popieluch  ---
Tom,

I don't expect I will be able to work on this module soon. Not sure if I should
close this request or keep it open. 

This is needed for update of http-signature bug: #1179226

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374957] Review Request: python-colorspacious - Perform colorspace conversions accurately and easily

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374957

Tim Flink  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Tim Flink  ---
Looks good to me. Apologies on the delayed review.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 19 files have
 unknown license. Detailed output of licensecheck in
 /home/tflink/code/packages/reviews/1374957-python-
 colorspacious/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.5/site-packages,
 /usr/lib/python3.5
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.5/site-
 packages, /usr/lib/python3.5
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python-
 colorspacious-doc , python2-colorspacious , 

[Bug 1232816] Review Request: nodejs-spdx - SPDX License Expression Syntax parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232816

Piotr Popieluch  changed:

   What|Removed |Added

 CC||zsvet...@redhat.com
  Flags||needinfo?(zsvetlik@redhat.c
   ||om)



--- Comment #9 from Piotr Popieluch  ---
Are you still interested in packaging this module?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1194923] Review Request: nodejs-ava - Simple test runner

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1194923

Piotr Popieluch  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |WONTFIX
Last Closed||2016-09-28 17:17:12



--- Comment #9 from Piotr Popieluch  ---
I'm not interested in packaging this anymore, closing


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1354018] Review Request: nodejs-utfx - A compact library to encode, decode and convert UTF8 / UTF16

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1354018

Piotr Popieluch  changed:

   What|Removed |Added

 CC||piotr1...@gmail.com



--- Comment #2 from Piotr Popieluch  ---
BR: npm(testjs) is missing.


 /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ /usr/bin/node tests/suite.js
module.js:457
throw err;
^
Error: Cannot find module 'testjs'
at Function.Module._resolveFilename (module.js:455:15)
at Function.Module._load (module.js:403:25)
at Module.require (module.js:483:17)
at require (internal/module.js:20:19)
at Object. (/builddir/build/BUILD/package/tests/suite.js:2:12)
at Module._compile (module.js:556:32)
at Object.Module._extensions..js (module.js:565:10)
at Module.load (module.js:473:32)
at tryModuleLoad (module.js:432:12)
at Function.Module._load (module.js:424:3)
error: Bad exit status from /var/tmp/rpm-tmp.ZMSh4u (%check)
Bad exit status from /var/tmp/rpm-tmp.ZMSh4u (%check)
RPM build errors:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378971] Review Request: f25-backgrounds - Fedora 25 default desktop background

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378971

Luya Tshimbalanga  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-09-28 17:10:48



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379814] Review Request: vulkan - Vulkan loader and validation layers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379814

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #9 from Fedora Update System  ---
vulkan-1.0.26.0-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-89bbc07132

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380179] Review Request: webvirtmgr - panel for manage virtual machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380179



--- Comment #1 from Raphael Groner  ---
Notes:
- There's an issue with current django to make webvirtmgr not work.
https://github.com/retspen/webvirtmgr/issues/624
https://github.com/retspen/webvirtmgr/issues/592
- The package should be ported to Python3. i assume upstream did not port so
far.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377444

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #5 from Fedora Update System  ---
imapsync-1.727-1.fc25, perl-JSON-WebToken-0.10-2.fc25,
perl-Test-Mock-Guard-0.10-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-17a038f8c3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357283] Review Request: obconf-qt - A configuration editor for the OpenBox window manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357283

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #15 from Fedora Update System  ---
obconf-qt-0.11.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-327af04953

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379421] Review Request: python-psycogreen - Psycopg2 integration with co-routine libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379421

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #6 from Fedora Update System  ---
python-psycogreen-1.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6f3b609541

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380179] New: Review Request: webvirtmgr - panel for manage virtual machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380179

Bug ID: 1380179
   Summary: Review Request: webvirtmgr - panel for manage virtual
machine
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://raphgro.fedorapeople.org/review/py/webvirtmgr/webvirtmgr.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/py/webvirtmgr/webvirtmgr-4.8.9-2.20160508git.fc24.src.rpm
Description: webvirtmgr panel for manage virtual machine
Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15849466

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380178] Review Request: zsh-grml - Configuration files for zsh from the Grml project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380178

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard||Trivial



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380178] Review Request: zsh-grml - Configuration files for zsh from the Grml project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380178



--- Comment #1 from Raphael Groner  ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15849684

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380178] New: Review Request: zsh-grml - Configuration files for zsh from the Grml project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380178

Bug ID: 1380178
   Summary: Review Request: zsh-grml - Configuration files for zsh
from the Grml project
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://raphgro.fedorapeople.org/review/util/zsh-grml.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/util/zsh-grml-0.12.6-1.fc24.src.rpm
Description: Configuration files for zsh from the Grml project
Fedora Account System Username: raphgro

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15849466

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378999

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #5 from Fedora Update System  ---
imapsync-1.727-1.fc25, perl-JSON-WebToken-0.10-2.fc25,
perl-Test-Mock-Guard-0.10-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-17a038f8c3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379460

Dusty Mabe  changed:

   What|Removed |Added

  Flags|needinfo?(dustymabe@redhat. |
   |com)|



--- Comment #7 from Dusty Mabe  ---
(In reply to Jan Chaloupka from comment #5)
> > $ rpmlint kompose-0.1.0-0.1.git8227684.fc24.src.rpm 
> > kompose-0.1.0-0.1.git8227684.fc24.x86_64.rpm 
> > kompose-debuginfo-0.1.0-0.1.git8227684.fc24.x86_64.rpm
> > kompose.src:596: W: macro-in-comment %{buildroot}
> > kompose.x86_64: W: spurious-executable-perm 
> > /usr/share/doc/kompose/CONTRIBUTING.md
> > kompose.x86_64: E: script-without-shebang 
> > /usr/share/licenses/kompose/LICENSE
> > kompose.x86_64: W: spurious-executable-perm 
> > /usr/share/doc/kompose/RELEASE.md
> > kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/README.md
> > kompose.x86_64: W: spurious-executable-perm 
> > /usr/share/doc/kompose/code-of-conduct.md
> > kompose.x86_64: W: no-manual-page-for-binary kompose
> > 3 packages and 0 specfiles checked; 1 errors, 6 warnings.
> 
> Permissions of the affected files need to be altered.

I sent a patch upstream for the executable files yesterday, but I can't change
what was released in 0.1.0. I guess I'll add code to the rpm to make them not
executable as well. 

> Man page is optional.

no work to be done here :) 

> The macro should be removed are changed to %%{buildroot}

I changed to comment to not have '%{buildroot}'



latest versions at:
Spec URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose.spec
SRPM URL:
https://dustymabe.fedorapeople.org/kompose-rpm/kompose-0.1.0-0.1.git8227684.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380156

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1380106
 Depends On||1380155
   ||(php-webmozart-assert)
  Alias||php-webmozart-path-util




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1380106
[Bug 1380106] drush-8.1.5 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1380155
[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate
method input/output with nice error messages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1380156
   ||(php-webmozart-path-util)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1380156
[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform
utilities for file paths
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155

Shawn Iwinski  changed:

   What|Removed |Added

  Alias||php-webmozart-assert



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380156] New: Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380156

Bug ID: 1380156
   Summary: Review Request: php-webmozart-path-util -
Cross-platform utilities for file paths
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/e5ca5d6ff110ba3eb6c152e99b47ec0dfef3aecc/php-webmozart-path-util/php-webmozart-path-util.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-webmozart-path-util-2.3.0-1.fc24.src.rpm

Description:
This package provides robust, cross-platform utility functions for normalizing,
comparing and modifying file paths and URLs.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] New: Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155

Bug ID: 1380155
   Summary: Review Request: php-webmozart-assert - Assertions to
validate method input/output with nice error messages
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/c350f7d905a72757f702b5b0d69bc2c67cf52468/php-webmozart-assert/php-webmozart-assert.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-webmozart-assert-1.1.0-1.fc24.src.rpm

Description:
This library contains efficient assertions to test the input and output of your
methods. With these assertions, you can greatly reduce the amount of coding
needed to write a safe implementation.

All assertions in the Assert class throw an \InvalidArgumentException if they
fail.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368850] Review Request: rubygem-rouge - Simple, easy-to-extend drop-in replacement for pygments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368850



--- Comment #14 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el7, rubygem-forwardable-extended-2.6.0-1.el7,
rubygem-jekyll-sass-converter-1.4.0-1.el7, rubygem-jekyll-watch-1.5.0-1.el7,
rubygem-mercenary-0.3.6-1.el7, rubygem-pathutil-0.14.0-1.el7,
rubygem-rouge-1.11.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368849] Review Request: rubygem-pathutil - Faster pure Ruby implementation of Pathname with extra bits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368849



--- Comment #16 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el7, rubygem-forwardable-extended-2.6.0-1.el7,
rubygem-jekyll-sass-converter-1.4.0-1.el7, rubygem-jekyll-watch-1.5.0-1.el7,
rubygem-mercenary-0.3.6-1.el7, rubygem-pathutil-0.14.0-1.el7,
rubygem-rouge-1.11.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368846] Review Request: rubygem-jekyll-sass-converter - Basic Sass converter for Jekyll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368846



--- Comment #16 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el7, rubygem-forwardable-extended-2.6.0-1.el7,
rubygem-jekyll-sass-converter-1.4.0-1.el7, rubygem-jekyll-watch-1.5.0-1.el7,
rubygem-mercenary-0.3.6-1.el7, rubygem-pathutil-0.14.0-1.el7,
rubygem-rouge-1.11.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368845] Review Request: rubygem-forwardable-extended - Forwardable with hash, and instance variable extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368845



--- Comment #16 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el7, rubygem-forwardable-extended-2.6.0-1.el7,
rubygem-jekyll-sass-converter-1.4.0-1.el7, rubygem-jekyll-watch-1.5.0-1.el7,
rubygem-mercenary-0.3.6-1.el7, rubygem-pathutil-0.14.0-1.el7,
rubygem-rouge-1.11.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368847] Review Request: rubygem-jekyll-watch - Rebuild your Jekyll site when a file changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368847



--- Comment #16 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el7, rubygem-forwardable-extended-2.6.0-1.el7,
rubygem-jekyll-sass-converter-1.4.0-1.el7, rubygem-jekyll-watch-1.5.0-1.el7,
rubygem-mercenary-0.3.6-1.el7, rubygem-pathutil-0.14.0-1.el7,
rubygem-rouge-1.11.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368844] Review Request: rubygem-colorator - Colorize your text in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368844



--- Comment #17 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el7, rubygem-forwardable-extended-2.6.0-1.el7,
rubygem-jekyll-sass-converter-1.4.0-1.el7, rubygem-jekyll-watch-1.5.0-1.el7,
rubygem-mercenary-0.3.6-1.el7, rubygem-pathutil-0.14.0-1.el7,
rubygem-rouge-1.11.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368848] Review Request: rubygem-mercenary - An easier way to build your command-line scripts in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368848



--- Comment #16 from Fedora Update System  ---
rubygem-colorator-1.1.0-1.el7, rubygem-forwardable-extended-2.6.0-1.el7,
rubygem-jekyll-sass-converter-1.4.0-1.el7, rubygem-jekyll-watch-1.5.0-1.el7,
rubygem-mercenary-0.3.6-1.el7, rubygem-pathutil-0.14.0-1.el7,
rubygem-rouge-1.11.1-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Dominik 'Rathann' Mierzejewski  ---
One more small issue:
The devel package should depend on the main package with %{_isa}, since it's
archful. Only noarch packages can skip %{_isa}.
Requires:   %{name}%{_isa} = %{version}-%{release}
You can fix this upon import.

Other than that, it looks like all issues are fixed. Good work! Package
approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380140] Review Request: language-detector - Language Detection Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380140

gil cattaneo  changed:

   What|Removed |Added

 Blocks||1340387




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1340387
[Bug 1340387] CVE-2016-4434 tika: XML External Entity vulnerability
[fedora-all]
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380140] Review Request: language-detector - Language Detection Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380140

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380140] New: Review Request: language-detector - Language Detection Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380140

Bug ID: 1380140
   Summary: Review Request: language-detector - Language Detection
Library for Java
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: punto...@libero.it
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://gil.fedorapeople.org/language-detector.spec
SRPM URL: https://gil.fedorapeople.org/language-detector-0.5-1.fc24.src.rpm
Description: A language detector / language guesser library in Java.
Fedora Account System Username: gil

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380105] Review Request: mingw-libdb - MinGW build of The Berkeley DB database library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380105



--- Comment #1 from Neal Gompa  ---
Spec URL:
http://kinginuyasha.enanocms.org/downloads/mingw-libdb-5.3.28-2.fc24.src.rpm
SRPM URL: http://kinginuyasha.enanocms.org/downloads/mingw-libdb.spec

Updated SRPM and Spec to use %license for storing license files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380105] New: Review Request: mingw-libdb - MinGW build of The Berkeley DB database library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380105

Bug ID: 1380105
   Summary: Review Request: mingw-libdb - MinGW build of The
Berkeley DB database library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ngomp...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/ngompa/mingw-libdb/mingw-libdb.git/plain/mingw-libdb.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/mingw-libdb/fedora-rawhide-x86_64/00446598-mingw-libdb/mingw-libdb-5.3.28-1.fc26.src.rpm

Description:

The Berkeley DB Database is a programmatic toolkit that provides
database support for applications.


Fedora Account System Username: ngompa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104

Jon Ciesla  changed:

   What|Removed |Added

 Blocks||1361684




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1361684
[Bug 1361684] 1.6.4 is out
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] New: Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104

Bug ID: 1380104
   Summary: Review Request: python-backports-functools_lru_cache -
A backport of functools.lru_cache from Python 3.3 as
published at ActiveState
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: limburg...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description: A backport of functools.lru_cache from Python 3.3 as published at
ActiveState

SPEC:
https://fedorapeople.org/~limb/review/python-backports-functools_lru_cache/python-backports-functools_lru_cache.spec
SRPM:
https://fedorapeople.org/~limb/review/python-backports-functools_lru_cache/python-backports-functools_lru_cache-1.2.1-1.fc24.src.rpm

Needed for pylint 1.6.x.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052



--- Comment #9 from Fedora Update System  ---
python-filelock-2.0.6-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d99061b906

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376450] Review Request: libdvbpsi - Library for MPEG TS and DVB PSI tables decoding and generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376450



--- Comment #14 from Fedora Update System  ---
libdvbpsi-1.3.0-3.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8e6fb2c213

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #14 from Fedora Update System  ---
kf5-kirigami-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-eaa3b46f02

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379814] Review Request: vulkan - Vulkan loader and validation layers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379814



--- Comment #8 from leigh scott  ---
(In reply to Michael Cronenworth from comment #6)
> In regards to vkjson: I actually meant you should include the utility as it
> was requested in the previous review. I'm not sure how important it is
> though. I'll leave that up to you. The changes look good.
> 
> APPROVED

Thank you for the review, package imported and built for all branches.

As for vkjson, I will include it when someone can prove it's actually used.
It seems to provide similar info to vulkaninfo but different values (I doubt
the vkjson info is correct as most values are 0).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376450] Review Request: libdvbpsi - Library for MPEG TS and DVB PSI tables decoding and generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376450



--- Comment #13 from Fedora Update System  ---
libdvbpsi-1.2.0-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b28902f027

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379814] Review Request: vulkan - Vulkan loader and validation layers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379814



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/vulkan

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1348298] Review Request: libXfont2 - X11 font support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1348298

Hans de Goede  changed:

   What|Removed |Added

 CC||hdego...@redhat.com



--- Comment #5 from Hans de Goede  ---
*** Bug 1379968 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379968] Review Request: libXfont2 - X.Org X11 Xfont2 runtime library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379968

Hans de Goede  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-09-28 07:43:19



--- Comment #1 from Hans de Goede  ---
Oops it turns out this is already packaged, closing.

*** This bug has been marked as a duplicate of bug 1348298 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377733] Review Request: systemd-bootchart - Boot performance graphing tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377733



--- Comment #11 from Fabio Alessandro Locati  ---
Sorry,
I lost your comment :/. Nice, thanks :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379968] New: Review Request: libXfont2 - X.Org X11 Xfont2 runtime library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379968

Bug ID: 1379968
   Summary: Review Request: libXfont2 - X.Org X11 Xfont2 runtime
library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: hdego...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~jwrdegoede/libXfont2.spec
SRPM URL: https://fedorapeople.org/~jwrdegoede/libXfont2-2.0.1-1.fc26.src.rpm
Description: X.Org X11 libXfont2 runtime library.
Fedora Account System Username: jwrdegoede

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782

Jakub Hrozek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from Jakub Hrozek  ---
I have some questions and comments:
1) we released cmocka 1.1 last week. I think this version should be packaged.
2) could you report the issue with LargestIntegralType upstream?
3) The same for the pkg-config file, it would be nicer to have no workarounds
in Fedora (although I wouldn't block the review over this)
4) maybe this is me not understanding the mingw packaging well (this is the
first mingw package I am reviewing..) but is it expected there is no -devel
package? I haven't found any notice about that in
https://fedoraproject.org/wiki/Packaging:MinGW?rd=Packaging/MinGW
5) A similar question about a -static package which we have in the native
packaging scheme
6) The fedora-review tool suggests there are some unowned reviews:
Note: Directories without known owners: /usr/x86_64-w64-mingw32/sys-
 root/mingw/include/cmockery, /usr/x86_64-w64-mingw32/sys-
 root/mingw/lib/cmake/cmocka, /usr/i686-w64-mingw32/sys-
 root/mingw/include/cmockery, /usr/i686-w64-mingw32/sys-
 root/mingw/lib/cmake/cmocka

The rest looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379709] Review Request: python-epi - Tool for looking at the entry point plugins on a system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379709



--- Comment #3 from Chandan Kumar  ---
Fixed Source macro under prep section:
Here is the updated
SPEC: https://chandankumar.fedorapeople.org/python-epi.spec
SRPM: https://chandankumar.fedorapeople.org/python-epi-0.1-3.fc24.src.rpm

Successful Koji Build :
http://koji.fedoraproject.org/koji/taskinfo?taskID=15843226

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782

Jakub Hrozek  changed:

   What|Removed |Added

 CC||jhro...@redhat.com
   Assignee|nob...@fedoraproject.org|jhro...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379709] Review Request: python-epi - Tool for looking at the entry point plugins on a system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379709



--- Comment #2 from Chandan Kumar  ---
Thanks for the review Parag.
Added LICENSE and README file to Sources and included %check to run tests.

Here is the updated
SPEC : https://chandankumar.fedorapeople.org/python-epi.spec
SRPM : https://chandankumar.fedorapeople.org/python-epi-0.1-2.fc24.src.rpm
and successful Koji Build :
http://koji.fedoraproject.org/koji/taskinfo?taskID=15842964

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379460

Jan Chaloupka  changed:

   What|Removed |Added

 CC||dustym...@redhat.com
  Flags||needinfo?(dustymabe@redhat.
   ||com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379460



--- Comment #6 from Jan Chaloupka  ---
Up to the file permissions and the macro the spec file complies to packaging
guidelines. Once updated the spec file can be approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379460

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379460



--- Comment #5 from Jan Chaloupka  ---

> $ rpmlint kompose-0.1.0-0.1.git8227684.fc24.src.rpm 
> kompose-0.1.0-0.1.git8227684.fc24.x86_64.rpm 
> kompose-debuginfo-0.1.0-0.1.git8227684.fc24.x86_64.rpm
> kompose.src:596: W: macro-in-comment %{buildroot}
> kompose.x86_64: W: spurious-executable-perm 
> /usr/share/doc/kompose/CONTRIBUTING.md
> kompose.x86_64: E: script-without-shebang /usr/share/licenses/kompose/LICENSE
> kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/RELEASE.md
> kompose.x86_64: W: spurious-executable-perm /usr/share/doc/kompose/README.md
> kompose.x86_64: W: spurious-executable-perm 
> /usr/share/doc/kompose/code-of-conduct.md
> kompose.x86_64: W: no-manual-page-for-binary kompose
> 3 packages and 0 specfiles checked; 1 errors, 6 warnings.

Permissions of the affected files need to be altered.
Man page is optional.
The macro should be removed are changed to %%{buildroot}

> = MUST items =
>
> C/C++:
> [ ]: Package does not contain kernel modules.

True

> [ ]: Package contains no static executables.

Go binary is static binary, known fact

> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.

ASL 2.0

> [ ]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses
> found: "Apache (v2.0)", "Unknown or generated", "MIT/X11 (BSD like)",
> "*No copyright* MPL (v2.0)", "ISC", "BSD (3 clause)", "BSD (2
> clause)", "BSD (3 clause) MIT/X11 (BSD like)". 1590 files have unknown
> license. Detailed output of licensecheck in /tmp/tmpOV_NQ5/review-
> kompose/licensecheck.txt

non ASL 2.0 licenses are licences of dependencies in the vendor directory, not
the project itself

> [ ]: License file installed when any subpackage combination is installed.

True

> [ ]: %build honors applicable compiler flags or justifies otherwise.

True, Go specific

> [ ]: Package contains no bundled libraries without FPC exception.

It contains bundled libraries, all of them are listed as "Provides:
bundles(library) = %{version}-COMMIT"

> [ ]: Changelog in prescribed format.

True

> [ ]: Sources contain only permissible code or content.

True

> [ ]: Package contains desktop file if it is a GUI application.

No GUI application

> [ ]: Development files must be in a -devel package

No devel subpackage, only sources

> [ ]: Package uses nothing in %doc for runtime.

True

> [ ]: Package consistently uses macros (instead of hard-coded directory
>  names).

That is true

> [ ]: Package is named according to the Package Naming Guidelines.

It is

> [ ]: Package does not generate any conflict.

It does not

> [ ]: Package obeys FHS, except libexecdir and /usr/target.

It does

> [ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.

No applicable

> [ ]: Requires correct, justified where necessary.

True

> [ ]: Spec file is legible and written in American English.

The spec file is readable

> [ ]: Package contains systemd file(s) if in need.

No systemd

> [ ]: Useful -debuginfo package or justification otherwise.

Present

> [ ]: Package is not known to require an ExcludeArch tag.

Not applicable

> [ ]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 30720 bytes in 5 files.

Not applicable

> [ ]: Package complies to the Packaging Guidelines

It does

> = SHOULD items =
>
> Generic:
> [ ]: If the source package does not include license text(s) as a separate
>  file from upstream, the packager SHOULD query upstream to include it.

Not applicable

> [ ]: Final provides and requires are sane (see attachments).

True

> [ ]: Fully versioned dependency in subpackages if applicable.
> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kompose-
> debuginfo

True, debuginfo is generated automatically by rpmbuild

> [ ]: Package functions as described.

Not applicable

> [ ]: Latest version is packaged.

True

> [ ]: Package does not include license text files separate from upstream.

True

> [ ]: Description and summary sections in the package spec file contains
> translations for supported Non-English languages, if available.

Not applicable

> [ ]: %check is present and all tests pass.

True

> [ ]: Packages should try to preserve timestamps of original installed
> files.

Not applicable, devel is not generated

> [ ]: Spec use %global instead of %define unless justified.
> Note: %define requiring justification: %define gobuild(o:) go build
> -ldflags "${LDFLAGS:-} -B 0x$(head -c20 /dev/urandom|od -An -tx1|tr -d
> ' \\n')" -a -v -x %{?**};

I prefer using %define for functions and %global for constants (constant

[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369720



--- Comment #11 from yunying@intel.com ---
Ping. Could someone help to do further review? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats ( required for `samtools`)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326504



--- Comment #11 from Adam Huffman  ---
Hi Sam,

Any news on this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1326504] Review Request: htslib - C library for high-throughput sequencing data formats ( required for `samtools`)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326504

Adam Huffman  changed:

   What|Removed |Added

 CC||samstud...@gmail.com
  Flags||needinfo?(samstudio8@gmail.
   ||com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373487] Review Request: python33 - Version 3.3 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373487



--- Comment #5 from Fedora Update System  ---
python33-3.3.6-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-0aa94b66eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378445



--- Comment #13 from Fedora Update System  ---
kf5-kirigami-1.1.0-1.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9960e5ece0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376450] Review Request: libdvbpsi - Library for MPEG TS and DVB PSI tables decoding and generation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376450



--- Comment #12 from Fedora Update System  ---
libdvbpsi-1.3.0-3.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b6da558152

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346243] Review Request: execdb - Execution status database for Taskotron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346243



--- Comment #12 from Fedora Update System  ---
execdb-0.0.7-4.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c5a81466d7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346245] Review Request: resultsdb_frontend - Frontend for the ResultsDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346245



--- Comment #7 from Fedora Update System  ---
resultsdb_frontend-1.1.9-4.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-10ce986b13

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #4 from Parag AN(पराग)  ---
Hi Tomas,
   1) Can you use the current recommended way of writing python specs? See we
are now using %py2_build, %py2_install macros. See
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

  2) Source0: can be used as
Source0:   
https://files.pythonhosted.org/packages/source/d/%{pypi_name}/%{pypi_name}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org