[Bug 1381430] Review Request: python3-prctl - Python(ic) interface to the linux prctl syscall

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381430

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381430] Review Request: python3-prctl - Python(ic) interface to the linux prctl syscall

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381430

kushal...@gmail.com  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|panem...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381430] New: Review Request: python3-prctl - Python(ic) interface to the linux prctl syscall

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381430

Bug ID: 1381430
   Summary: Review Request: python3-prctl - Python(ic) interface
to the linux prctl syscall
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@kushaldas.in
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://kushal.fedorapeople.org/packages/python3-prctl.spec
SRPM URL:
https://kushal.fedorapeople.org/packages/python3-prctl-1.6.1-1.fc24.src.rpm
Description: Python(ic) interface to the linux prctl syscall
Fedora Account System Username: kushal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379174

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Mukundan Ragavan  ---
Thanks for the fixes.

These changes look fine. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

  Flags||needinfo?(ttomecek@redhat.c
   ||om)



--- Comment #6 from Michael Hampton  ---
All right, thank you to Parag An who drew my attention to the need to pay
attention to the Python-specific guidelines more closely. I think this package
is almost ready. I was only able to find one issue, but it's a pretty serious
one.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= Issues ===

- This program requires the python six module, but neither subpackage
  Requires: it.
  %package -n python2-%{pypi_name}
  Does not contain Requires: python-six
  %package -n python3-%{pypi_name}
  Does not contain Requires: python3-six



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable. 
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
   

[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379096
Bug 1379096 depends on bug 1379095, which changed state.

Bug 1379095 Summary: Review Request: python-entrypoints - Discover and load 
entry points from installed packages
https://bugzilla.redhat.com/show_bug.cgi?id=1379095

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379095] Review Request: python-entrypoints - Discover and load entry points from installed packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379095

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-03 20:14:52



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979
Bug 1327979 depends on bug 1379096, which changed state.

Bug 1379096 Summary: Review Request: python-nbconvert - Converting Jupyter 
Notebooks
https://bugzilla.redhat.com/show_bug.cgi?id=1379096

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379096

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-03 20:12:46



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782



--- Comment #10 from Fedora Update System  ---
mingw-cmocka-1.1.0-2.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e9785a9311

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540



--- Comment #4 from Christoph Junghans  ---
I forgot:
Spec URL: http://junghans.github.io/fedora-review/votca-xtp/votca-xtp.spec
SRPM URL:
http://junghans.github.io/fedora-review/votca-xtp/votca-xtp-1.4-0.2rc1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942



--- Comment #5 from Raphael Groner  ---
Spec URL: https://raphgro.fedorapeople.org/review/java/testing/jwebunit.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/java/testing/jwebunit-3.3-2.fc25.src.rpm

- Added upstream patch for htmlunit 2.23
- Koji still fails the htmlunit tests, should I disable those?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540



--- Comment #3 from Christoph Junghans  ---
(In reply to Dridi Boukelmoune from comment #2)
> [?]: License file installed when any subpackage combination is installed.
>  Review note, it is not present in the devel subpackage.
Devel pulls in the main package, which has the license file.

> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/votca
>  Review note: it is provided by votca-csg-common which isn't a dependency
>  of the votca-xtp-common subpackage. Consider adding a dependency or
>  owning /usr/share/votca too.
> [?]: Package does not generate any conflict.
> [!]: Package requires other packages for directories it uses.
>  Review note: see above, it's not the case for the common subpackage.
Add requirement on votca-csg-common, that should fix these issues.

> [?]: Package functions as described.
>  Review note: too big for me to test, relying on the github account and
>  web site looking serious.
> [?]: Package should compile and build into binary rpms on all supported
>  architectures.
I did another Koji build and it passed on all 4 archs, see
http://koji.fedoraproject.org/koji/taskinfo?taskID=15927493

> [?]: %check is present and all tests pass.
>  Review note: I failed to find a test suite with a quick glance.
Yes, there is no test suite.

> Rpmlint (debuginfo)
> ---
> Checking: votca-xtp-debuginfo-1.4-0.1rc1.fc26.x86_64.rpm
> votca-xtp-debuginfo.x86_64: E: script-without-shebang
> /usr/src/debug/xtp-1.4_rc1/src/tools/xtp_kmc_run.cc
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
> 
> Review note: it looks like a broken permission in the debuginfo
> subpackage.
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #30 from Fedora Update System  ---
vim-syntastic-3.7.0-6.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373487] Review Request: python33 - Version 3.3 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373487

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-03 16:19:29



--- Comment #6 from Fedora Update System  ---
python33-3.3.6-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372881] Review Request: nodejs-stream-shift - Returns the next buffer/object in a stream' s readable queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372881

Piotr Popieluch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||piotr1...@gmail.com
   Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Piotr Popieluch  ---
test.js does not have to be included in the package. Otherwise fine, approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 3 files have
 unknown license. Detailed output of licensecheck in /home/piotr
 /fedora-scm/1372881-nodejs-stream-shift/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/licenses/nodejs-
 stream-shift(this, [y/N]:, Is, ok), /usr/lib/node_modules/stream-
 shift(this, [y/N]:, Is, ok), /usr/share/doc/nodejs-stream-shift(this,
 [y/N]:, Is, ok), /usr/lib/node_modules/stream-shift/node_modules(this,
 [y/N]:, Is, ok)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to 

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #23 from gil cattaneo  ---
(In reply to Tomas Repik from comment #22)

> 
> (In reply to gil cattaneo from comment #21)
> > i know caffeine is "not friendly" (read crap) with packager. but this will
> > not be the possibility of keeping the package, at length, in Fedora
> So you think it's ineviteble to package caffeine? What if we removed
> caffeine 
> from cassandra so it's not dependent? Is that not possible? I can help with
> doing either.

caffeine replace
com.googlecode.concurrentlinkedhashmap:concurrentlinkedhashmap-lru 
(see https://github.com/ben-manes/concurrentlinkedhashmap/issues/48),
you could try to remove it but could produce other issues.

> > Default Python interpreter for Fedora (in rawhide) should be python3
> > For me should better split clientutil package in:
> > - clientutil only the binaries/scripts files
> > - python2-cqlshlib and/or python3-cqlshlib
> DONE (only python2 because of usage in SCLs)
I do not understand ...

> > [!]: Packages are noarch unless they use JNI
> > %package parent
> DONE
> 
> Tests still don't work...
All test suite? or few tests?

Please, cleanup spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #8 from Christoph Junghans  ---
(In reply to Christoph Junghans from comment #7)
> fedora-review throughs an error when installing:
> 
> it seems something went wrong with the auto-provide for the shared lib.
Try
%make_build ... LDFLAGS='%__global_ldflags'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381303] Review Request: perl-LaTeX-ToUnicode - Convert LaTeX commands to Unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381303

Tom "spot" Callaway  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tcall...@redhat.com
   Assignee|nob...@fedoraproject.org|tcall...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Tom "spot" Callaway  ---
= Review = 

Good:

- rpmlint checks return:
perl-LaTeX-ToUnicode.noarch: E: incorrect-fsf-address
/usr/share/licenses/perl-LaTeX-ToUnicode/LICENSE

(safe to ignore, may want to ask upstream to update their LICENSE text)

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL+ or Artistic) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(b9023af14629a53bcf4e6e7379b3712b84fabc48c4ea5221670f681473ca11b0)
- package compiles on f24 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381307] Review Request: perl-BibTeX-Parser - Pure Perl BibTeX parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381307

Tom "spot" Callaway  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tcall...@redhat.com
   Assignee|nob...@fedoraproject.org|tcall...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Tom "spot" Callaway  ---
= Review = 

Good:

- rpmlint checks return: nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPL+ or Artistic) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(989d341b6c625d240c54457e40a76d646d7243e2a5c0d0d19fe3ccb3a18742bf)
- package compiles on f24 (noarch)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888
Bug 1372888 depends on bug 1372886, which changed state.

Bug 1372886 Summary: Rudimentary ceritifi requires in requires.txt
https://bugzilla.redhat.com/show_bug.cgi?id=1372886

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372888] Review Request: python-toro - Synchronization primitives for Tornado coroutines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372888
Bug 1372888 depends on bug 1372887, which changed state.

Bug 1372887 Summary: Missing Requires: python-backports-ssl_match_hostname
https://bugzilla.redhat.com/show_bug.cgi?id=1372887

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374138] Review Request: vim-syntastic - A vim plugins to check syntax for programming languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #29 from Fedora Update System  ---
vim-syntastic-3.7.0-6.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361659

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 CC||ybron...@redhat.com
  Flags||needinfo?(ybronhei@redhat.c
   ||om)



--- Comment #29 from Dominik 'Rathann' Mierzejewski  ---
Ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196039] Review Request: google-oauth-java-client - Google OAuth Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196039



--- Comment #4 from gil cattaneo  ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15926261

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218

Pádraig Brady  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-10-03 12:46:14



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165

Christoph Junghans  changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org



--- Comment #7 from Christoph Junghans  ---
> %global _hardened_build 1
Can be dropped this is the default now, see
https://fedoraproject.org/wiki/Changes/Harden_All_Packages

> Source:   libslz-1.1.0.tar.gz
Follow
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags
and
use
URL:
http://git.1wt.eu/web?p=%{name}.git;a=snapshot;h=v%{version};sf=tgz#/%{name}-%{version}.tar.gz
and
%setup -q -n %{name}
You can always change it once their website is up.

fedora-review throughs an error when installing:

it seems something went wrong with the auto-provide for the shared lib.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381303] Review Request: perl-LaTeX-ToUnicode - Convert LaTeX commands to Unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381303

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1381307




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1381307
[Bug 1381307] Review Request: perl-BibTeX-Parser - Pure Perl BibTeX parser
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381307] Review Request: perl-BibTeX-Parser - Pure Perl BibTeX parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381307

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1381262
 Depends On||1381303




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1381262
[Bug 1381262] texlive-bibtexperllibs-svn40139-3.fc26.noarch: nothing
provides perl(BibTeX::Parser)
https://bugzilla.redhat.com/show_bug.cgi?id=1381303
[Bug 1381303] Review Request: perl-LaTeX-ToUnicode - Convert LaTeX commands
to Unicode
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381307] New: Review Request: perl-BibTeX-Parser - Pure Perl BibTeX parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381307

Bug ID: 1381307
   Summary: Review Request: perl-BibTeX-Parser - Pure Perl BibTeX
parser
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-BibTeX-Parser/perl-BibTeX-Parser.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-BibTeX-Parser/perl-BibTeX-Parser-0.69-1.fc26.src.rpm
Description:
This is a BibTeX parser written in Perl.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196037] Review Request: google-http-java-client - Google HTTP Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196037

gil cattaneo  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||google-http-java-client-1.2
   ||2.0-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2016-10-03 12:00:38



--- Comment #13 from gil cattaneo  ---
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15925834

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196039] Review Request: google-oauth-java-client - Google OAuth Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196039
Bug 1196039 depends on bug 1196037, which changed state.

Bug 1196037 Summary: Review Request: google-http-java-client - Google HTTP 
Client Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1196037

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381303] New: Review Request: perl-LaTeX-ToUnicode - Convert LaTeX commands to Unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381303

Bug ID: 1381303
   Summary: Review Request: perl-LaTeX-ToUnicode - Convert LaTeX
commands to Unicode
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-LaTeX-ToUnicode/perl-LaTeX-ToUnicode.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-LaTeX-ToUnicode/perl-LaTeX-ToUnicode-0.04-1.fc26.src.rpm
Description:
This Perl module provides a method to convert LaTeX-style markups for accents
etc. into their Unicode equivalents. It translates commands for special
characters or accents into their Unicode equivalents and removes
formatting commands.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540

Dridi Boukelmoune  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from Dridi Boukelmoune  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 136 files have unknown
 license. Detailed output of licensecheck in
 1380540-votca-xtp/licensecheck.txt


[?]: License file installed when any subpackage combination is installed.
 Review note, it is not present in the devel subpackage.


[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/votca
 Review note: it is provided by votca-csg-common which isn't a dependency
 of the votca-xtp-common subpackage. Consider adding a dependency or
 owning /usr/share/votca too.

 --- votca-xtp.spec2016-10-01 01:26:15.0 +0200
 +++ votca-xtp.spec2016-10-03 16:46:43.898844031 +0200
 @@ -102,7 +102,7 @@

  %files common
  %license LICENSE.md
 -%{_datadir}/votca/xtp
 +%{_datadir}/votca

  %files libs
  %license LICENSE.md


[x]: %build honors applicable compiler flags or justifies otherwise.
 Review note: even with a non-parallel build I found my laptop hovering.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
 Review note: I didn't look at the whole source base, because it's too
 large but overall I haven't seen anything striking me as odd or out of
 place.

[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.


[!]: Package requires other packages for directories it uses.
 Review note: see above, it's not the case for the common subpackage.

[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, 

[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380420



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gomtree

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380156



--- Comment #2 from Remi Collet  ---
Created attachment 1206923
  --> https://bugzilla.redhat.com/attachment.cgi?id=1206923=edit
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1380156 -L /dev/shm/extras/RPMS/noarch/
Buildroot used: fedora-rawhide-x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380420

Lokesh Mandvekar  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jchal...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380156

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #3 from Remi Collet  ---
No blocker

=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380156

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fed...@famillecollet.com
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com



--- Comment #1 from Remi Collet  ---
Created attachment 1206922
  --> https://bugzilla.redhat.com/attachment.cgi?id=1206922=edit
phpci.log

phpCompatInfo version 5.0.1 DB version 1.12.0 built Sep 27 2016 07:32:45 CEST
static analyze results

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380420

Jan Chaloupka  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jan Chaloupka  ---
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155

Remi Collet  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #3 from Remi Collet  ---
Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=15925487

No blocker

=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155



--- Comment #2 from Remi Collet  ---
Created attachment 1206919
  --> https://bugzilla.redhat.com/attachment.cgi?id=1206919=edit
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1380155
Buildroot used: fedora-rawhide-x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380420



--- Comment #4 from Lokesh Mandvekar  ---
yup I'm seeing this too, weird. Anyway, changed build step like you mentioned. 

Spec URL: https://lsm5.fedorapeople.org/gomtree/gomtree.spec
SRPM URL:
https://lsm5.fedorapeople.org/gomtree/SRPMS/gomtree-0-0.2.git8c6b32c.fc26.src.rpm

PTAL

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155

Remi Collet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||fed...@famillecollet.com
   Assignee|nob...@fedoraproject.org|fed...@famillecollet.com



--- Comment #1 from Remi Collet  ---
Created attachment 1206918
  --> https://bugzilla.redhat.com/attachment.cgi?id=1206918=edit
phpci.log

phpCompatInfo version 5.0.1 DB version 1.12.0 built Sep 27 2016 07:32:45 CEST
static analyze results

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378028] Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting threads and processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378028

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Petr Pisar  ---
URL and Source addresses are usable. Ok.
Source archive is original (SHA-256:
fecc71952ab13b88f65e6e3bb8815dae915c78455a098cc31af9842253c4dc81). Ok.
Summary is Ok.
Description verified from README.md. Ok.
License verified from lib/MCE/Shared.pm, README.md, Copying, LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

TODO: The dependency on `perl >= 4:5.10.1' is better written as `perl(:VERSION)
>= 5.10.1'. You don't have to deal with the epoch number. (Although it's
probably unavailable on EPEL.)

All tests pass. Ok.

$ rpmlint perl-MCE-Shared.spec ../SRPMS/perl-MCE-Shared-1.805-1.fc26.src.rpm
../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm 
perl-MCE-Shared.src: W: spelling-error %description -l en_US parallelization ->
palatalization, rationalization, pluralization
perl-MCE-Shared.noarch: W: spelling-error %description -l en_US parallelization
-> palatalization, rationalization, pluralization
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-MCE-Shared-1.805-1.fc26.noarch.rpm
drwxr-xr-x2 rootroot0 Oct  3 16:55
/usr/share/doc/perl-MCE-Shared
-rw-r--r--1 rootroot 4350 Sep 23 08:04
/usr/share/doc/perl-MCE-Shared/Changes
-rw-r--r--1 rootroot 3900 Sep 23 07:58
/usr/share/doc/perl-MCE-Shared/README.md
drwxr-xr-x2 rootroot0 Oct  3 16:55
/usr/share/licenses/perl-MCE-Shared
-rw-r--r--1 rootroot12633 Aug 22  2015
/usr/share/licenses/perl-MCE-Shared/Copying
-rw-r--r--1 rootroot 6319 Aug 22  2015
/usr/share/licenses/perl-MCE-Shared/LICENSE
-rw-r--r--1 rootroot 5657 Oct  3 16:54
/usr/share/man/man3/MCE::Hobo.3pm.gz
-rw-r--r--1 rootroot 8016 Oct  3 16:54
/usr/share/man/man3/MCE::Shared.3pm.gz
-rw-r--r--1 rootroot 5554 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Array.3pm.gz
-rw-r--r--1 rootroot 1255 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Base.3pm.gz
-rw-r--r--1 rootroot 3607 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Condvar.3pm.gz
-rw-r--r--1 rootroot 3634 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Handle.3pm.gz
-rw-r--r--1 rootroot 4574 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Hash.3pm.gz
-rw-r--r--1 rootroot 7275 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Minidb.3pm.gz
-rw-r--r--1 rootroot 7037 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Ordhash.3pm.gz
-rw-r--r--1 rootroot 4372 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Queue.3pm.gz
-rw-r--r--1 rootroot 2329 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Scalar.3pm.gz
-rw-r--r--1 rootroot 2506 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Sequence.3pm.gz
-rw-r--r--1 rootroot 1240 Oct  3 16:54
/usr/share/man/man3/MCE::Shared::Server.3pm.gz
drwxr-xr-x2 rootroot0 Oct  3 16:54
/usr/share/perl5/vendor_perl/MCE
-rw-r--r--1 rootroot26123 Sep 23 08:00
/usr/share/perl5/vendor_perl/MCE/Hobo.pm
drwxr-xr-x2 rootroot0 Oct  3 16:54
/usr/share/perl5/vendor_perl/MCE/Shared
-rw-r--r--1 rootroot32395 Sep 23 08:00
/usr/share/perl5/vendor_perl/MCE/Shared.pm
-rw-r--r--1 rootroot24185 Sep 23 08:00
/usr/share/perl5/vendor_perl/MCE/Shared/Array.pm
-rw-r--r--1 rootroot 8547 Sep 23 08:00
/usr/share/perl5/vendor_perl/MCE/Shared/Base.pm
-rw-r--r--1 rootroot 9928 Sep 23 08:01
/usr/share/perl5/vendor_perl/MCE/Shared/Condvar.pm
-rw-r--r--1 rootroot12273 Sep 23 08:01
/usr/share/perl5/vendor_perl/MCE/Shared/Handle.pm
-rw-r--r--1 rootroot19410 Sep 23 08:01
/usr/share/perl5/vendor_perl/MCE/Shared/Hash.pm
-rw-r--r--1 rootroot56625 Sep 23 08:01
/usr/share/perl5/vendor_perl/MCE/Shared/Minidb.pm
-rw-r--r--1 rootroot39521 Sep 23 08:01
/usr/share/perl5/vendor_perl/MCE/Shared/Ordhash.pm
-rw-r--r--1 rootroot25479 Sep 23 08:01
/usr/share/perl5/vendor_perl/MCE/Shared/Queue.pm
-rw-r--r--1 rootroot 5580 Sep 23 08:01
/usr/share/perl5/vendor_perl/MCE/Shared/Scalar.pm
-rw-r--r--1 root 

[Bug 1378028] Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting threads and processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378028

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #9 from Fedora Update System  ---
mingw-cmocka-1.1.0-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-571867e1b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378807] Review Request: mingw-podofo - MinGW Windows podofo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378807

Sandro Mani  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-03 10:08:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-backports-functools_lru_cache

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361632] Review Request: python-blowfish - Fast, efficient Blowfish cipher implementation in pure Python (3.4+)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361632



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-blowfish

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/zstd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #9 from Jon Ciesla  ---
Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361632] Review Request: python-blowfish - Fast, efficient Blowfish cipher implementation in pure Python (3.4+)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361632



--- Comment #10 from Jon Ciesla  ---
Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379096] Review Request: python-nbconvert - Converting Jupyter Notebooks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379096



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-nbconvert

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379095] Review Request: python-entrypoints - Discover and load entry points from installed packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379095



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-entrypoints

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020



--- Comment #22 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/cassandra/v4/cassandra.spec
SRPM URL:
https://trepik.fedorapeople.org/cassandra/v4/cassandra-3.5-1.fc23.src.rpm

(In reply to gil cattaneo from comment #21)
> i know caffeine is "not friendly" (read crap) with packager. but this will
> not be the possibility of keeping the package, at length, in Fedora
So you think it's ineviteble to package caffeine? What if we removed caffeine 
from cassandra so it's not dependent? Is that not possible? I can help with
doing either.

> Default Python interpreter for Fedora (in rawhide) should be python3
> For me should better split clientutil package in:
> - clientutil only the binaries/scripts files
> - python2-cqlshlib and/or python3-cqlshlib
DONE (only python2 because of usage in SCLs)

> [!]: Packages are noarch unless they use JNI
> %package parent
DONE

Tests still don't work...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380140] Review Request: language-detector - Language Detection Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380140



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/language-detector

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378807] Review Request: mingw-podofo - MinGW Windows podofo library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378807



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mingw-podofo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-jcconv

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196037] Review Request: google-http-java-client - Google HTTP Client Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196037



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/google-http-java-client

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942

Mikolaj Izdebski  changed:

   What|Removed |Added

 CC||mizde...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 831883] Review Request: ovirt-image-uploader - Tool for uploading OVF images into oVirt Export domain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=831883

Sandro Bonazzola  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2016-10-03 07:53:44



--- Comment #5 from Sandro Bonazzola  ---
Closing wontfix, being upstream ovirt-image-uploader deprecated in oVirt 4.0
(current release) and will be dropped in 4.1 (next release) and 4.1 is expected
to run on Fedora 24.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357064

Raphael Groner  changed:

   What|Removed |Added

 Depends On||1381197




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1381197
[Bug 1381197] Please build a package for EPEL7
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1196920] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1196920

Raphael Groner  changed:

   What|Removed |Added

 CC||guido.grazi...@gmail.com,
   ||projects...@smart.ms
  Flags||needinfo?(guido.grazioli@gm
   ||ail.com)



--- Comment #4 from Raphael Groner  ---
Friendly reminder. Are you still interested in this package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540

Dridi Boukelmoune  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|dridi.boukelmo...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376438] Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438



--- Comment #1 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues

- dvblast, dvblastctl exe files are "Partial Relro" "No PIE".
  http://fedoraproject.org/wiki/Packaging:Guidelines#PIE
  Probably ld flags are not properly set.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "WTFPL WTFPL (v2)", "GPL (v2 or later)",
 "Unknown or generated". 9 files have unknown license. Detailed output
 of licensecheck in /home/sagitter/1376438-dvblast/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in dvblast-
 debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present 

[Bug 1380420] Review Request: gomtree - Go CLI tool for mtree support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380420



--- Comment #3 from Jan Chaloupka  ---
$ rpmlint gomtree-0-0.1.git8c6b32c.fc20.x86_64.rpm
gomtree.x86_64: W: spelling-error Summary(en_US) mtree -> tree, m tree
gomtree.x86_64: W: spelling-error %description -l en_US mtree -> tree, m tree
gomtree.x86_64: W: binaryinfo-readelf-failed /usr/bin/gomtree 
gomtree.x86_64: E: script-without-shebang /usr/bin/gomtree
gomtree.x86_64: W: no-manual-page-for-binary gomtree
1 packages and 0 specfiles checked; 1 errors, 4 warnings.

No sure if %gobuild -o bin/%{name} %{import_path} does anything good. I have
always assumed you need to specify entire path to the main package file, i.e.
%{import_path}/cmd/gomtree.

Checking the compiled binary:

$ ./usr/bin/gomtree
./usr/bin/gomtree: line 1: syntax error near unexpected token `newline'
./usr/bin/gomtree: line 1: `!'

$ file ./usr/bin/gomtree
./usr/bin/gomtree: current ar archive

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379174] Review Request: vmod-querystring - QueryString module for Varnish Cache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379174



--- Comment #3 from Dridi Boukelmoune  ---
Spec URL: https://dridi.fedorapeople.org/review/vmod-querystring.spec
SRPM URL:
https://dridi.fedorapeople.org/review/vmod-querystring-1.0.1-1.fc24.src.rpm

I added the %license and also added the %optflags since varnish modules are
supposed to be loaded by a long-running daemon.

Thanks for reviewing!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #6 from Dridi Boukelmoune  ---
Spec URL: https://dridi.fedorapeople.org/review/libslz.spec
SRPM URL: https://dridi.fedorapeople.org/review/libslz-1.1.0-1.fc24.src.rpm

I went ahead and fixed or commented everything you mentioned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376438] Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #3 from Antonio Trande  ---
Hi Tim.
First of all:

- Leave a comment about what patches do.

- python(2)-sitelib macro is already defined

- Use python2-devel as BR package

- Use macros instead of hardlinks:
  /usr --> %{_prefix}
  /usr/include/ssm --> %{_includedir}/ssm

- 'rm -rf %{buildroot}' and '%defattr(-,root,root,-)' lines are used on epel5
only.

- doc sub-package isn't noarch

- COPYING is not tagged with %license

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202231] Review Request: jbehave - Behavior-Driven Development framework for Java and Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202231

Raphael Groner  changed:

   What|Removed |Added

 Whiteboard||NotReady



--- Comment #11 from Raphael Groner  ---
ok

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364805

Daniel Maixner  changed:

   What|Removed |Added

   Assignee|xsk...@gmail.com|nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1270525] Review Request: maxmind-db - Reader for the MaxMind DB Database Format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270525

Raphael Groner  changed:

   What|Removed |Added

 Depends On||1366713




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1366713
[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/mono
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/ mono

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366713

Raphael Groner  changed:

   What|Removed |Added

 Status|CLOSED  |MODIFIED
 Blocks||1270525 (maxmind-db)
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #20 from Raphael Groner  ---
(In reply to Timotheus Pokorra from comment #18)
> I think there is not much benefit of upgrading the nunit package in Fedora
> 25 to NUnit3. There is no nunit gui stable yet, and no package requires
> nunit3 in Fedora 25.
> Therefore there is no need for nunit2 for compatibility reasons.
> I will drop the F25 branch for nunit2.

No. https://bugzilla.redhat.com/show_bug.cgi?id=1270525#c10


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1270525
[Bug 1270525] Review Request: maxmind-db - Reader for the MaxMind DB
Database Format
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1270525] Review Request: maxmind-db - Reader for the MaxMind DB Database Format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270525
Bug 1270525 depends on bug 1366713, which changed state.

Bug 1366713 Summary: Review Request: nunit2 - unit-testing framework for 
.Net/mono
https://bugzilla.redhat.com/show_bug.cgi?id=1366713

   What|Removed |Added

 Status|CLOSED  |MODIFIED
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376940] Review Request: python3-urllib3 - Python 3 HTTP library with thread-safe connection pooling and file post

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376940
Bug 1376940 depends on bug 1376938, which changed state.

Bug 1376938 Summary: Ship python34-pysocks
https://bugzilla.redhat.com/show_bug.cgi?id=1376938

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364805

Daniel Maixner  changed:

   What|Removed |Added

  Flags|needinfo?(xsk...@gmail.com) |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379432] Review Request: odoo - Suite of web based open source business apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379432



--- Comment #2 from Björn "besser82" Esser <fed...@besser82.io> ---
Updated package:

Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/odoo.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/odoo-9.0c.20161003-0.1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359914] Review Request: lollypop - Music player for GNOME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359914

MartinKG  changed:

   What|Removed |Added

 Depends On||1381132




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1381132
[Bug 1381132] Review Request: python-wikipedia - Wikipedia API for Python
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381132] Review Request: python-wikipedia - Wikipedia API for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381132

MartinKG  changed:

   What|Removed |Added

 Blocks||1359914




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1359914
[Bug 1359914] Review Request: lollypop - Music player for GNOME
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381132] Review Request: python-wikipedia - Wikipedia API for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381132

MartinKG  changed:

   What|Removed |Added

URL||https://github.com/barrust/
   ||Wikipedia



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381132] New: Review Request: python-wikipedia - Wikipedia API for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381132

Bug ID: 1381132
   Summary: Review Request: python-wikipedia - Wikipedia API for
Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mgans...@alice.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/python-wikipedia.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/python-wikipedia-1.4.4-1.gitb329024.fc24.src.rpm

Description: Search Wikipedia, get article summaries, get data like links and
images from a page, and more.

Fedora Account System Username: martinkg

rpmlint -i python-wikipedia.spec
/home/martin/rpmbuild/SRPMS/python-wikipedia-1.4.4-1.gitb329024.fc24.src.rpm
/home/martin/rpmbuild/RPMS/noarch/python2-wikipedia-1.4.4-1.gitb329024.fc24.noarch.rpm
/home/martin/rpmbuild/RPMS/noarch/python3-wikipedia-1.4.4-1.gitb329024.fc24.noarch.rpm
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

%changelog
* Sun Oct 02 2016 Martin Gansser  -
1.4.4-1.gitb329024
- Initial package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

  Flags|needinfo?(ttomecek@redhat.c |
   |om) |



--- Comment #5 from Tomas Tomecek  ---
(I'm back from vacation)

I used pyp2rpm to generate the spec and expected it would conform to the
guidelines. I rewrote it then.

Spec:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec
Srpm:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375670] Review Request: python26 - Version 2.6 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375670



--- Comment #9 from Fedora Update System  ---
python26-2.6.9-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-af076fa537

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 426387] Merge reviews to be completed for F9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=426387
Bug 426387 depends on bug 226377, which changed state.

Bug 226377 Summary: Merge Review: rpm
https://bugzilla.redhat.com/show_bug.cgi?id=226377

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |WONTFIX



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/ mono

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366713



--- Comment #19 from Timotheus Pokorra  ---
hmm, dropping the Fedora 25 branch would mean orphaning and retiring? I will
just keep it for the moment. Perhaps after the release of Fedora 25 we decide
to upgrade MonoDevelop for some reason, and then it will be good to have that
branch already available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/ mono

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366713

Timotheus Pokorra  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-03 02:56:41



--- Comment #18 from Timotheus Pokorra  ---
I think there is not much benefit of upgrading the nunit package in Fedora 25
to NUnit3. There is no nunit gui stable yet, and no package requires nunit3 in
Fedora 25.
Therefore there is no need for nunit2 for compatibility reasons.
I will drop the F25 branch for nunit2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302053] Review Request: pgcenter - Top-like PostgreSQL statistics viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302053



--- Comment #17 from Fedora Update System  ---
pgcenter-0.3.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-bf2cfd3c17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #13 from Fedora Update System  ---
python-filelock-2.0.6-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0fdf697d47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378014



--- Comment #12 from Fedora Update System  ---
perl-IO-FDPass-1.1-3.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332052] Review Request: python-filelock - A platform independent file lock

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332052



--- Comment #12 from Fedora Update System  ---
python-filelock-2.0.6-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org