[Bug 1378860] Review Request: jetty-setuid - SetUID support for jetty

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378860



--- Comment #5 from gil cattaneo  ---
If there aren't any objections i can take this review ... ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1290342] Review Request: ecc-25519-java - Java library to use Ed25519 and Curve25518

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290342



--- Comment #6 from gil cattaneo  ---
Any new news?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376783] Review Request: python-can: The can package provides controller area network support for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376783

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
The packaging tempalte from
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file should
be used. It's much better to use %pyX_build, etc.

The description should be wrapped to <= 80 columns, this is even visible in the
way that bugzilla formats the description above.

Is python fully supported? Than the executables should use python3 not python2.


You can replace the second and subsequent Summary texts with %{summary}, no
need to repeat.


Also, don't repeat the %description, it makes the spec file much harder to read
than necessary:

%global _description \
XXX \
YYY

%description -n package-name %{_description}

etc.

In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly.
Something like
%{python2_sitelib}/libname
%{python2_sitelib}/libname-%{version}.egg-info

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375735] Review Request: python-asciitree - Draws ASCII trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375735

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
python2-asciitree.noarch: W: spelling-error %description -l en_US ascii ->
ASCII

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ python packaging templates is python
+ %python_provide is present
- %check is missing, but an upstream bug has been files
+ provides/requires look sane
+ no scriptlets present or necessary

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375735] Review Request: python-asciitree - Draws ASCII trees

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375735

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375962] Review Request: python-sphinx-intl - Sphinx utility that make it easy to translate and to apply translation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375962



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
IIRC, it might be enough to set the locale: LC_ALL=en_US.utf8 py.test...
See python-libarchive-c for an example.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375962] Review Request: python-sphinx-intl - Sphinx utility that make it easy to translate and to apply translation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375962



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Add -v to py.test invocation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375962] Review Request: python-sphinx-intl - Sphinx utility that make it easy to translate and to apply translation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375962

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Hm, fails to build in rawhide for me:
+ py.test-3.5 .
= test session starts
==
platform linux -- Python 3.5.2, pytest-3.0.3, py-1.4.31, pluggy-0.4.0
rootdir:
/builddir/build/BUILD/sphinx-intl-bf6edc2e505567768eb230099c9960ccdedd12b5,
inifile: 
collected 15 items
tests/test_basic.py ..
tests/test_catalog.py ..
tests/test_cmd_pot.py FFF
=== FAILURES
===
___ test_update_pot_notfound
___
temp = path('/tmp/pytest-of-mockbuild/pytest-1/test_update_pot_notfound0/root')
def test_update_pot_notfound(temp):
r1 = runner.invoke(commands.update, ['-d', 'locale'])
assert r1.exit_code != 0
>   assert 'Please specify pot directory with -p option,' in r1.output
E   assert 'Please specify pot directory with -p option,' in ''
E+  where '' = .output
/builddir/build/BUILD/sphinx-intl-bf6edc2e505567768eb230099c9960ccdedd12b5/tests/test_cmd_pot.py:23:
AssertionError
...

Full log at
http://in.waw.pl/~zbyszek/fedora/1375962-python-sphinx-intl-build.log 

Also, PYTHONPATH=$(pwd) can be just PYTHONPATH=., the result is the same.

Looks nice, but please make the tests pass ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375993] Review Request: python-flufl.i18n - A high level API for Python internationalization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375993

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Same comments as in
https://bugzilla.redhat.com/show_bug.cgi?id=1376001#c1 and
https://bugzilla.redhat.com/show_bug.cgi?id=1375999#c1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375999] Review Request: python-flufl.bounce - Email bounce detectors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375999

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Same comments as for the other review, see
https://bugzilla.redhat.com/show_bug.cgi?id=1376001#c1.

Also, don't repeat the %description, it makes the spec file much harder to read
than necessary:

%global _description \
The flufl.bounce library provides a set of heuristics and an API for   \
detecting the original bouncing email addresses from a bounce message. Many\
formats found in the wild are supported, as are VERP and RFC 3464 (DSN).

%description -n %{py2_namespace}-%{srcname} %{_description}

etc.

In %files, please enumerate the items under %{pythonX_sitelib}/ explicitly.
Something like
%{python2_sitelib}/libname
%{python2_sitelib}/libname-%{version}.egg-info

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375999] Review Request: python-flufl.bounce - Email bounce detectors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375999

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376001] Review Request: python-flufl.lock - NFS-safe file locking with timeouts for POSIX systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376001

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
"." should be replaced with "-" in the package name
[https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Separators].

You can replace the second and subsequent Summary texts with %{summary}, no
need to repeat.

Looks good otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381029] Review Request: more-itertools - Python library for efficient use of itertools utility in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381029

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Please have a look at the python packaging guidelines. Try the template from
https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file.

The most obvious issues:
- this is a python library, the package should be called python-more-itertools
- python3 must be supported
- description should be wrapped to 72-80 columns
- please start from the template linked above, that will make many things
simpler and more correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361632] Review Request: python-blowfish - Fast, efficient Blowfish cipher implementation in pure Python (3.4+)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361632



--- Comment #13 from Fedora Update System  ---
python-blowfish-0.6.1-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9b278118dc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #14 from Fedora Update System  ---
gasnet-1.26.4-5.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c3ddd3e289

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104



--- Comment #12 from Fedora Update System  ---
python-backports-functools_lru_cache-1.2.1-1.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1065ca8dcb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #16 from Fedora Update System  ---
exodusii-6.02-5.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ef86cfeae3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #16 from Fedora Update System  ---
zstd-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3355e1dae4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375744



--- Comment #13 from Fedora Update System  ---
gasnet-1.26.4-5.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2927fa727d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1361632] Review Request: python-blowfish - Fast, efficient Blowfish cipher implementation in pure Python (3.4+)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1361632

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #12 from Fedora Update System  ---
python-blowfish-0.6.1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-857cd7babf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #15 from Fedora Update System  ---
exodusii-6.02-5.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3ec60759ec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372938] Review Request: xorg-x11-drv-amdgpu - X.Org X11 amdgpu video driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372938



--- Comment #28 from Fedora Update System  ---
libXfont2-2.0.1-2.fc25, tigervnc-1.7.0-2.fc25, xorg-x11-drivers-7.7-18.fc25,
xorg-x11-drv-amdgpu-1.1.2-3.20160929git97d7386c.fc25,
xorg-x11-drv-armsoc-1.4.0-3.20160929.fc25,
xorg-x11-drv-ati-7.7.1-1.20160928git3fc839ff.fc25,
xorg-x11-drv-dummy-0.3.6-26.fc25, xorg-x11-drv-evdev-2.10.4-1.fc25,
xorg-x11-drv-fbdev-0.4.3-25.fc25, xorg-x11-drv-fbturbo-0.5.1-0.8.20150221.fc25,
xorg-x11-drv-freedreno-1.4.0-3.20160929.fc25,
xorg-x11-drv-geode-2.11.18-2.fc25,
xorg-x11-drv-intel-2.99.917-26.20160929.fc25,
xorg-x11-drv-ivtv-1.2.0-0.22.fc25,
xorg-x11-drv-libinput-0.19.1-2.20160929.fc25,
xorg-x11-drv-nouveau-1.0.13-1.fc25, xorg-x11-drv-omap-0.4.4-3.fc25,
xorg-x11-drv-openchrome-0.5.0-2.fc25, xorg-x11-drv-opentegra-0.7.0-8.fc25,
xorg-x11-drv-qxl-0.1.4-9.20160929gite13d28ee.fc25,
xorg-x11-drv-sisusb-0.9.6-24.fc25,
xorg-x11-drv-synaptics-1.8.99.1-2.20160929git48632211.fc25,
xorg-x11-drv-v4l-0.2.0-47.fc25, xorg-x11-drv-vesa-2.3.2-25.fc25,
xorg-x11-drv-vmware-13.0.2-12.20150211git8f0cf7c.fc25,
xorg-x11-drv-voodoo-1.2.5-25.fc25,
xorg-x11-drv-wacom-0.33.0-2.20160929gitb61d1711.fc25,
xorg-x11-font-utils-7.5-32.fc25, xorg-x11-proto-devel-7.7-20.fc25,
xorg-x11-server-1.19.0-0.1.20160929.fc25 has been pushed to the Fedora 25
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a5c3ebe67a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380104] Review Request: python-backports-functools_lru_cache - A backport of functools.lru_cache from Python 3.3 as published at ActiveState

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380104

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #11 from Fedora Update System  ---
python-backports-functools_lru_cache-1.2.1-1.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0d465fefd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671



--- Comment #8 from Fedora Update System  ---
python-jcconv-0.2.4-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba72dcc8eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380140] Review Request: language-detector - Language Detection Library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380140

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA



--- Comment #7 from Fedora Update System  ---
language-detector-0.5-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6cd0442d1d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #15 from Fedora Update System  ---
zstd-1.1.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c258c9e3b5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327981] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327981



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
rpmlint:
python2-ipykernel.noarch: W: spelling-error Summary(en_US) IPython -> I Python,
Python, Diphthong
python3-ipykernel.noarch: W: spelling-error Summary(en_US) IPython -> I Python,
Python, Diphthong
python-ipykernel.src: W: spelling-error Summary(en_US) IPython -> I Python,
Python, Diphthong
python-ipykernel-doc.noarch: W: spelling-error Summary(en_US) IPython -> I
Python, Python, Diphthong
Yeah, way to go rpmlint!

python-ipykernel-doc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/python-ipykernel-doc/html/objects.inv
python-ipykernel-doc.noarch: W: file-not-utf8
/usr/share/doc/python-ipykernel-doc/html/objects.inv
Those are not text files, so OK.

4 packages and 0 specfiles checked; 0 errors, 6 warnings.

Hm, this requires python-ipython 4, while we have 3.2.1 in rawhide... Do we
have some tracking bug for the update of python-ipython?

I think you need R:python[23]-zmq.

Where does ipython_genutils module come from?

import gi
gi.require_version ('Gdk', '3.0')
gi.require_version ('Gtk', '3.0')
from gi.repository import GObject, Gtk
→ don't you need dependencies on python[23]-gobject-base, gtk3,
gobject-introspection for those?

import matplotlib
from matplotlib.backends.backend_agg import new_figure_manager, FigureCanvasAgg
# analysis: ignore
from matplotlib._pylab_helpers import Gcf
→ more requires?

Also python[23]-pillow?

I think you can drop README.md from the doc directory, it's only about building
the package and running tests from the source tree. Not useful for the binary
package.

For the %description:
This package provide the IPython kernel for the Jupyter notebook. The notebook
provides a front-end to enter and edit commands, and display results, while
this package wraps the backend, i.e. the actual IPython instance that will
execute Python commands supplied by the frontend.

+ provides look OK
+ %python_provide is used
+ all modern python macros are used
+ doc subpackage is present
+ builds OK
- a few Requires seem to be missing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366047



--- Comment #36 from l...@us.ibm.com ---
Hi Tomas,

If there is anything else that I can do in order for the package to get
approved, please feel free to let me know.


Thanks,
Vicky

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #14 from Fedora Update System  ---
zstd-1.1.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ebb17c7dc5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381741] Review Request: ginga - Image Viewer and Toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381741

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381741] New: Review Request: ginga - Image Viewer and Toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381741

Bug ID: 1381741
   Summary: Review Request: ginga - Image Viewer and Toolkit
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lupi...@mailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lupinix.fedorapeople.org/review/ginga.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/ginga-2.5.20160926130800-1.fc25.src.rpm

Description: Astronomical Image Viewer and Toolkit
Fedora Account System Username: lupinix

Koji scratch build (rawhide):
http://koji.fedoraproject.org/koji/taskinfo?taskID=15941757

Thank you very much for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #10 from Dridi Boukelmoune  ---
One more thing in the patch set I'll send upstream, good catch. The problem
actually lies in the Makefile where chmod explicitly sets 644.

I'll submit an updated spec tomorrow, it may look a lot like yours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381735] New: Review Request: python-astroscrappy - Cosmic Ray Annihilation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381735

Bug ID: 1381735
   Summary: Review Request: python-astroscrappy - Cosmic Ray
Annihilation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lupi...@mailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lupinix.fedorapeople.org/review/python-astroscrappy.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/python-astroscrappy-1.0.5-1.fc25.src.rpm

Description: Astro-SCRAPPY is designed to detect cosmic rays in images (numpy
arrays).
Fedora Account System Username: lupinix

Koji scratch build (rawhide):
http://koji.fedoraproject.org/koji/taskinfo?taskID=15941674

Thank you very much for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376438] Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-10-04 15:27:02



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379165] Review Request: libslz - StateLess Zip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379165



--- Comment #9 from Christoph Junghans  ---
Thanks to Tom Spura, he pointed out to me that lib*.so.* misses an executable
bit, which fixes the above issue, have look here:

Spec URL: http://junghans.github.io/fedora-review/libslz/libslz.spec
SRPM URL:
http://junghans.github.io/fedora-review/libslz/libslz-1.1.0-1.fc26.src.rpm
Review.txt: http://junghans.github.io/fedora-review/libslz/review.txt
Build log: https://travis-ci.org/junghans/fedora-review/builds/165023015
Raw Build log:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/165023016/log.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373486

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-10-04 14:50:00



--- Comment #14 from Fedora Update System  ---
python34-3.4.5-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376438] Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/dvblast

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380156



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-webmozart-path-util

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-webmozart-assert

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369535] Review Request: sassc - Wrapper around libsass to compile CSS stylesheet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369535

Jeff Sheltren  changed:

   What|Removed |Added

 CC||aurel...@bompard.org,
   ||shelt...@fedoraproject.org
  Flags||needinfo?(aurelien@bompard.
   ||org)



--- Comment #1 from Jeff Sheltren  ---
The spec looks good to me with a quick review, although I've hit an issue when
doing a test mock build on EL7:

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.MDOmNi
+ umask 022
+ cd /builddir/build/BUILD
+ cd sassc-3.3.6
+ ruby sass-spec/sass-spec.rb -c bin/sassc --ignore-todo sass-spec/spec
/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require': cannot
load such file -- minitest (LoadError)
from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in
`require'
from
/builddir/build/BUILD/sassc-3.3.6/sass-spec/lib/sass_spec/runner.rb:1:in `'
from /builddir/build/BUILD/sassc-3.3.6/sass-spec/lib/sass_spec.rb:4:in
`require_relative'
from /builddir/build/BUILD/sassc-3.3.6/sass-spec/lib/sass_spec.rb:4:in
`'
from sass-spec/sass-spec.rb:22:in `require_relative'
from sass-spec/sass-spec.rb:22:in `'

I confirmed that mock has installed rubygem-minitest during the chroot setup,
so I'm not sure why ruby isn't able to include it properly.  Any ideas?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380156] Review Request: php-webmozart-path-util - Cross-platform utilities for file paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380156



--- Comment #4 from Shawn Iwinski  ---
THANKS for the review Remi!

SCM request submitted via pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380155] Review Request: php-webmozart-assert - Assertions to validate method input/ output with nice error messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380155



--- Comment #4 from Shawn Iwinski  ---
THANKS for the review Remi!

SCM request submitted via pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366411] Review Request: fedora-rpm-macros - Miscellaneous Fedora RPM macros

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366411



--- Comment #10 from Pavel Raiskup  ---
(In reply to Jason Tibbitts from comment #9)
> I'm sorry, what's not transparent?  This is just a package.

That's "just" a package which is always installed in every buildroot.

> There's not currently anything actually in it.

If there is noting in it, yet - there is no know purpose of the package, and
I doubt it is useful to anything.  One could consider "empty package" to be
the simples "way" to get malicious code into Fedora.  WRT your contributions,
I know this is not truth - it is simply too early to have it in Fedora now.

> It's gone through the proper review procedure.

I know, I have no problem with that.  Even though I've seen how fast it has
been done.

> It's intended for future use, so we don't keep having to mess with
> redhat-rpm-config, which is rather more complicated than it needs to be for
> something that drops in some macro files.

Then please drop the requirement from 'redhat-rpm-config' package, so you
don't have to consult your changes with FPC.

> Plus it has a rather odd versioning mechanism.  This gives me one package I
> can untag if necessary, without worrying about conflicting with other macro
> maintenance done by the RPM maintainers.

I understand this argument.  But that doesn't mean you need to promote your
package that high, it all sounds like some work-around.

> And without using provenpackager privs to get FPC-approved macro work done.

This is pretty irrelevant.

> Having a package which can hold things like the GPG macros which the
> packaging committee has been discussing (and which will begin going in as
> soon as I can find the time) is beneficial.  That's the original reason this
> package was created.  I can see no downsides of that.

Why you feel it is needed to be in every buildroot, however?  If that is that
important, please put the gpg code into redhat-rpm-config.

> Also note that plenty of other macro packages are now required by
> redhat-rpm-config.  I don't see this trend going away.

Well, to some extent (if that is cleverly done enough), it makes sense to add
language-specific macro packages, but having 'fedora-rpm-macros' sounds simply
like something really replacing redhat-rpm-macros (which in fact provides
system-rpm-macros, sounds like way towards rename and something we should call
the package now).

Every new Requires in redhat-rpm-config should be properly raised on FPC.

> I also don't see what relevance RHEL/Centos has to this discussion.  If EPEL
> needs these macros for compatibility, they'll go into epel-rpm-macros.  If
> Red Hat wants to follow whatever obviously completely transparent process it
> has for doing whatever it wants to do internally, then it will and
> Fedora/EPEL will end up adapting as they always do.  That would be no
> different regardless of where the actual macros are stored.

In case the macros are going to be widely used, we would almost certainly go
and rename the package (because installing such package in RHEL chroot would
just lead to confusion on RHEL).  But in such case, you should do your changes
directly in redhat-rpm-config.

Pavel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381661] New: Review Request: obs-build - A generic package build script

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381661

Bug ID: 1381661
   Summary: Review Request: obs-build - A generic package build
script
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ngomp...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://kinginuyasha.enanocms.org/downloads/obs-build.spec
SRPM URL:
http://kinginuyasha.enanocms.org/downloads/obs-build-20160809-228.1.1.fc24.src.rpm

Description:
This package provides a script for building packages in a chroot environment.
It is commonly used with the Open Build Service as the engine for building
packages for a wide variety of distributions.


Fedora Account System Username: ngompa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366411] Review Request: fedora-rpm-macros - Miscellaneous Fedora RPM macros

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366411

Jason Tibbitts  changed:

   What|Removed |Added

  Flags|needinfo?(ti...@math.uh.edu |
   |)   |



--- Comment #9 from Jason Tibbitts  ---
I'm sorry, what's not transparent?  This is just a package.  There's not
currently anything actually in it.  It's gone through the proper review
procedure.  It's intended for future use, so we don't keep having to mess with
redhat-rpm-config, which is rather more complicated than it needs to be for
something that drops in some macro files.  Plus it has a rather odd versioning
mechanism.  This gives me one package I can untag if necessary, without
worrying about conflicting with other macro maintenance done by the RPM
maintainers.  And without using provenpackager privs to get FPC-approved macro
work done.

Having a package which can hold things like the GPG macros which the packaging
committee has been discussing (and which will begin going in as soon as I can
find the time) is beneficial.  That's the original reason this package was
created.  I can see no downsides of that.

Also note that plenty of other macro packages are now required by
redhat-rpm-config.  I don't see this trend going away.

I also don't see what relevance RHEL/Centos has to this discussion.  If EPEL
needs these macros for compatibility, they'll go into epel-rpm-macros.  If Red
Hat wants to follow whatever obviously completely transparent process it has
for doing whatever it wants to do internally, then it will and Fedora/EPEL will
end up adapting as they always do.  That would be no different regardless of
where the actual macros are stored.

Thanks for the tip about install.  It's always bugged me that it doesn't just
work like you'd expect by default.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376438] Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Antonio Trande  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376438] Review Request: dvblast - Simple and powerful streaming application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376438



--- Comment #2 from Nicolas Chauvet (kwizart)  ---
Thx for the review:


Spec URL: http://dl.kwizart.net/review/dvblast.spec
SRPM URL: http://dl.kwizart.net/review/dvblast-3.0-2.fc26.src.rpm
Description: Simple and powerful streaming application

Updated Changelog:
* Tue Oct 04 2016 Nicolas Chauvet  - 3.0-2
- Backport fix for LDFLAGS from upstream

Koji scratch build for f26:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15938373

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218



--- Comment #13 from Fedora Update System  ---
zstd-1.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-722779c63b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373782] Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373782



--- Comment #11 from Fedora Update System  ---
mingw-cmocka-1.1.0-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8e0d13ce58

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-docker-pycreds

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1357064



--- Comment #36 from Fedora Update System  ---
lumina-desktop-1.0.0-5.p2.Lbc08e90.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8ef6597c75

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373218] Review Request: zstd - Zstd compression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373218

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #12 from Fedora Update System  ---
zstd-1.1.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-df3c15fb8a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380671] Review Request: python-jcconv - JapaneseCharacterCONVerter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380671

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #7 from Fedora Update System  ---
python-jcconv-0.2.4-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5b597e47b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350257] Review Request: petsc - Portable Extensible Toolkit for Scientific Computation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350257



--- Comment #35 from Dave Love  ---
The fact that the check behaves differently in local mock, koji, and copr
suggests a real problem with undefined behaviour, which I think we should worry
about; I don't have time to debug it.  Maybe orion has an opinion, as he's
watching?

There's still this:
 Note: Directories without known owners: /usr/lib64/gfortran,
 /usr/lib64/gfortran/modules

Regarding the unused-direct-shlib-dependencys, I meant to find out why the
configured libraries aren't getting used, rather than just adding --as-needed. 
It seems to be a build bug, but again I don't have time to investigate.  It's
the sort of thing I might raise a bug report about as a user of the package,
and the packaging I did of older versions didn't have this issue, e.g. metis is
used.

I didn't notice before that fftw isn't configured because there's no bcond for
it.  It's an example of the conditionals being confusing when they don't have
an obvious purpose.  Is there any reason not to build against fftw?

Also, I still don't understand the module file.  The tests run (locally, for
me) 
without it, so why is it needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254



--- Comment #10 from Parag AN(पराग)  ---
I am happy to help here :)

BTW, you used bcond so I just thought lets check and python3 bcond need some
changes in spec.
e.g. rpmbuild -ba python-docker-pycreds.spec --without python
failing because conditional not used for py3_build and py3_install lines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381307] Review Request: perl-BibTeX-Parser - Pure Perl BibTeX parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381307

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-BibTeX-Parser-0.69-1.f
   ||c26
   ||perl-BibTeX-Parser-0.69-1.f
   ||c25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373487] Review Request: python33 - Version 3.3 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373487



--- Comment #8 from Miro Hrončok  ---
SSL related failures are expected. The others, not sure. Feel free to dig into
it, but I don't think that's a stopper.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381548] Review Request: mariadb-connector-odbc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381548

Tomas Hozza  changed:

   What|Removed |Added

 CC||tho...@redhat.com
   Assignee|hho...@redhat.com   |pemen...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381303] Review Request: perl-LaTeX-ToUnicode - Convert LaTeX commands to Unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381303

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-LaTeX-ToUnicode-0.04-1
   ||.fc26
   ||perl-LaTeX-ToUnicode-0.04-1
   ||.fc25



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #9 from Tomas Tomecek  ---
Thanks a lot Michael! SCM request initiated:
https://admin.fedoraproject.org/pkgdb/package/requests/8140

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381548] Review Request: mariadb-connector-odbc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381548

Honza Horak  changed:

   What|Removed |Added

 CC||hho...@redhat.com
   Assignee|nob...@fedoraproject.org|hho...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/votca-xtp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378028] Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting threads and processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378028



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MCE-Shared

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540



--- Comment #6 from Christoph Junghans  ---
(In reply to Dridi Boukelmoune from comment #5)
> It now looks good to me, package approved!
> 
> Please open a pull request upstream to fix the permissions of
> src/tools/xtp_kmc_run.cc
Done! Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378341] Review Request: fedpkg-copr - copr dist-git client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378341



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/fedpkg-copr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381307] Review Request: perl-BibTeX-Parser - Pure Perl BibTeX parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381307



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-BibTeX-Parser

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381303] Review Request: perl-LaTeX-ToUnicode - Convert LaTeX commands to Unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381303



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-LaTeX-ToUnicode

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372881] Review Request: nodejs-stream-shift - Returns the next buffer/object in a stream' s readable queue

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372881



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-stream-shift

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381548] New: Review Request: mariadb-connector-odbc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381548

Bug ID: 1381548
   Summary: Review Request: mariadb-connector-odbc
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: msch...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Sources:
Spec URL:
https://raw.githubusercontent.com/FaramosCZ/Fedora-maintain/master/mariadb/mariadb-connector-odbc/SPECS/mariadb-connector-odbc.spec
SRPM URL:
https://raw.githubusercontent.com/FaramosCZ/Fedora-maintain/master/mariadb/mariadb-connector-odbc/SRPMS/mariadb-connector-odbc-2.0.12-1.fc24.src.rpm

GitHub:
https://github.com/FaramosCZ/Fedora-maintain/tree/master/mariadb/mariadb-connector-odbc

COPR:
https://copr.fedorainfracloud.org/coprs/mschorm/mariadb-connector-odbc/

Description: 
MariaDB Connector/ODBC is a standardized, LGPL licensed database driver using
the industry standard Open Database Connectivity (ODBC) API. It supports ODBC
Standard 3.5, can be used as a drop-in replacement for MySQL Connector/ODBC,
and it supports both Unicode and ANSI modes

Aditional info:
In this SRPM a patch is included, which creates possibility to build package
with dynamic library (instead of the static one).
Link to patch suggestion sent to upstream:
https://jira.mariadb.org/browse/ODBC-55

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366411] Review Request: fedora-rpm-macros - Miscellaneous Fedora RPM macros

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366411



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
Thanks, this has been an annoying wart.

install -Dt /path/to/somewhere/ FILE1 FILE2

should DTRT according to the man page.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380540] Review Request: votca-xtp - VOTCA excitation and charge properties module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380540

Dridi Boukelmoune  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Dridi Boukelmoune  ---
It now looks good to me, package approved!

Please open a pull request upstream to fix the permissions of
src/tools/xtp_kmc_run.cc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #2 from Germano Massullo  ---
Downgrading to 2.0.5 due upstream request (Nikon support broken in 2.0.6)

https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/darktable2.spec
https://fedorapeople.org/~germano/package_reviews/darktable2_epel7/darktable2-2.0.5-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373487] Review Request: python33 - Version 3.3 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373487

Petr Viktorin  changed:

   What|Removed |Added

 CC||pvikt...@redhat.com



--- Comment #7 from Petr Viktorin  ---
I finally got around to testing this on f25. `python33 -m test` gives 3 errors:

- test_compileall (test_no_args_respects_force_flag: failure in subprocess)
- test_ftplib (test_auth_ssl: SSLV3_ALERT_HANDSHAKE_FAILURE)
- test_faulthandler (hangs)
- test_ssl (test_protocol_sslv3, test_options)

Are those expected?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378740] Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378740

Lumír Balhar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Lumír Balhar  ---
The package looks good to me. Just pay attention that you have a different
version of specfile in SRPM.

Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 3 files have
 unknown license. Detailed output of licensecheck in
 /home/lbalhar/Review/1378740-python-pytest-
 faulthandler/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -pytest-faulthandler , python3-pytest-faulthandler
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
   

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507



--- Comment #1 from Germano Massullo  ---
There should not be problems in the spec file since it has already been
reviewed when darktable 2 landed into Fedora repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1281478

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381516] New: Review Request: python-reproject - Reproject astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381516

Bug ID: 1381516
   Summary: Review Request: python-reproject - Reproject
astronomical images
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lupi...@mailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lupinix.fedorapeople.org/review/python-reproject.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/python-reproject-0.3.1-1.fc25.src.rpm
Description: Reproject astronomical images
Fedora Account System Username: lupinix

Koji build for rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15935442

Thank you very much for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507

Germano Massullo  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507

Oliver Haessler  changed:

   What|Removed |Added

 CC||oli...@redhat.com
   Assignee|nob...@fedoraproject.org|oli...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381507] New: Review Request: darktable2 - Utility to organize and develop raw images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381507

Bug ID: 1381507
   Summary: Review Request: darktable2 - Utility to organize and
develop raw images
   Product: Fedora EPEL
   Version: epel7
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: germano.massu...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description of problem:
darktable2 is a replacement for darktable EPEL7 package that ships 1.x
darktable releases.
darktable upstream developers develop only 2.x releases.
To be compliant to EPEL packaging guidelines, I am making a new package for 2.x
releases.
Since darktable 2 once it reads darktable 1.x XML files will make them
uncompatible with older 1.x releases, I inserted a 
Obsoletes: darktable
flag.

If you see build errors concerning pugixml version, don't worry about it
because there is a new version that is going to be released
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-dce60c46e0


spec file:
https://germano.fedorapeople.org/package_reviews/darktable2_epel7/darktable2.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/darktable2_epel7/darktable2-2.0.6-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Michael Hampton  changed:

   What|Removed |Added

   Assignee|er...@ioerror.us|ttome...@redhat.com
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Michael Hampton  ---
All right, the Requires look right and everything else does as well. That
covers everything I could find. If something else comes up later, it should be
easy enough to update it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366411] Review Request: fedora-rpm-macros - Miscellaneous Fedora RPM macros

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366411



--- Comment #7 from Pavel Raiskup  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> Yeah, install is stupid like that. I don't think the repetition can be
> avoided.

There is '--target-directory' option, which should help IMO.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379254

Tomas Tomecek  changed:

   What|Removed |Added

  Flags|needinfo?(ttomecek@redhat.c |
   |om) |



--- Comment #7 from Tomas Tomecek  ---
Oh my, I feel really bad now. The new spec format is pretty confusing. I really
hope I got it right this time, thank you so much Michael and Parag.

(on top of the missing requirement, there was also a typo in provides macro)

Spec:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds.spec
Srpm:
https://ttomecek.fedorapeople.org/python-docker-pycreds/python-docker-pycreds-0.2.1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366411] Review Request: fedora-rpm-macros - Miscellaneous Fedora RPM macros

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366411

Pavel Raiskup  changed:

   What|Removed |Added

 CC||prais...@redhat.com,
   ||ti...@math.uh.edu
  Flags||needinfo?(ti...@math.uh.edu
   ||)



--- Comment #6 from Pavel Raiskup  ---
(In reply to Jason Tibbitts from comment #0)
> This is a super simple package which currently doesn't actually contain any
> macros.  It will be used as a repository for packaging-committee approved
> macros so that redhat-rpm-config doesn't have to be modified directly.

Jason, this is very not transparent.  Please always post links for FPC
decisions about such things!  Not everybody (me personally) looks at FPC
tickets.

My point is that neither from redhat-rpm-config nor from fedora-rpm-config
git-log I see where you've been discussing this across fedora board and thus I
don't really see _what are the real benefits_ of such package (even though
this is probably perfectly valid).

Also, what scared me, you've made 'redhat-rpm-config' "Requires:
fedora-rpm-macros", so this is basically in every fedora build root.
And I see little benefit of having those macros separated, because there
is the same "possibility" to break something.  It just looks like we are
going to have a troubles to get this into CentOS/RHEL/EPEL.

What I always disliked about 'redhat-rpm-config' is it's name.  That
should be named like 'os-rpm-config' --- but that would be about package
rename process, not about yet another macro package ...

Please make this movement clear, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378028] Review Request: perl-MCE-Shared - MCE extension for sharing data, supporting threads and processes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378028



--- Comment #3 from Paul Howarth  ---
(In reply to Petr Pisar from comment #2)
> TODO: The dependency on `perl >= 4:5.10.1' is better written as
> `perl(:VERSION) >= 5.10.1'. You don't have to deal with the epoch number.
> (Although it's probably unavailable on EPEL.)

Indeed, this does not work on EL-7, which upstream is particularly keen to see
MCE::Shared available on.

> FIX: Run-require `perl(overloading)' (lib/MCE/Shared/Server.pm:28).
> FIX: Run-require `perl(Storable) >= 2.04' (lib/MCE/Shared/Minidb.pm:417).
> FIX: Run-require `perl(Symbol)' (lib/MCE/Shared/Server.pm:306).

Fixed in perl-MCE-Shared-1.805-3

> Resolution: Package APPROVED.

Thanks for the review Petr.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378740] Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378740



--- Comment #4 from Dominika Krejčí  ---
Fix of tests, added BuildRequires: pythonXpytest-mock

Spec URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler-1.3.0-1.fc24.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15933423

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381430] Review Request: python3-prctl - Python(ic) interface to the linux prctl syscall

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381430



--- Comment #1 from Parag AN(पराग)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Suggestions:
1) Good to add BuildRequires: gcc as we want to specify more BR's in spec

2) For correct directory ownership, add expanded form of %files section

3) you can add if you want 
%check
%{__python3} -m unittest test_prctl.py

but this is failing currently.

4) you can also add docs files using sphinx-build-3

Please submit the updated package that fixed above issues.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 10 files have
 unknown license. Detailed output of licensecheck in
 /home/parag/1381430-python3-prctl/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/python3.5/site-
 packages/__pycache__(system-python-libs, python3-regex, audit-libs-
 python3)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs 

[Bug 1378740] Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378740



--- Comment #3 from Dominika Krejčí  ---
Fix of the Source format and added Requires.

Spec URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler.spec
SRPM URL:
https://dkrejci.fedorapeople.org/python-pytest-faulthandler/python-pytest-faulthandler-1.3.0-1.fc24.src.rpm

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15933038

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378740] Review Request: python-pytest-faulthandler - py.test plugin that activates the fault handler module for tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378740

Lumír Balhar  changed:

   What|Removed |Added

 CC||lbal...@redhat.com
   Assignee|nob...@fedoraproject.org|lbal...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org