[Bug 1387447] Review Request: php-sentry - PHP client for Sentry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387447

Remi Collet  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Remi Collet  ---

[x]: License field in the package spec file matches the actual license.

[x]: Requires correct, justified where necessary.


=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447



--- Comment #12 from Fedora Update System  ---
python-winrm-0.2.1-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387447] Review Request: php-sentry - PHP client for Sentry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387447



--- Comment #7 from Shawn Iwinski  ---
Downgraded to 0.2.0 (latest 0.x release) for php-Monolog (verified
compatibility) and made fixes per comment 4.



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/47e74254d7e035220abc71352f9b59f9c05c1e73/php-sentry/php-sentry.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-sentry-0.22.0-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1302909] Review Request: drupal8 - An open source content management platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302909

Shawn Iwinski  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-11-03 21:41:02



--- Comment #18 from Shawn Iwinski  ---
Updated to 8.2.2, added RPM README, and submitted deploy via bodhi -- see bug
1383483

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388344] Review Request: javapoet - API for generating .java sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388344



--- Comment #8 from Fedora Update System  ---
javapoet-1.7.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381741] Review Request: ginga - Image Viewer and Toolkit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381741



--- Comment #11 from Fedora Update System  ---
ginga-2.5.20161005204600-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1355592] Review Request: libvmi - A library for performing virtual-machine introspection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1355592



--- Comment #14 from Fedora Update System  ---
libvmi-0.11.0-1.20161003git5ad492c.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447



--- Comment #11 from Fedora Update System  ---
python-winrm-0.2.1-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387876] Review Request: python-fitsio - Python FITS library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387876



--- Comment #8 from Fedora Update System  ---
python-fitsio-0.9.10-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942



--- Comment #11 from gil cattaneo  ---
(In reply to gil cattaneo from comment #10)
> Must be removed all "Requires: ..." are useless.
> Because all Requires are handled by our Java Tools.
> 
> Suggestion, instead of:
> 
> ...
> %mvn_package :%{name}-code-generator code-generator
> %mvn_package :%{name}-core core
> %mvn_package :%{name}-htmlunit-plugin htmlunit-plugin
> 
> 
> %build
> %mvn_build
> 
> ...
> 
> %files -f .mfiles
> %license COPYING COPYING.LESSER LICENSE.txt
> %doc README.md
> 
> %files code-generator -f .mfiles-code-generator
> %license COPYING COPYING.LESSER LICENSE.txt
> 
> %files core -f .mfiles-core
> %license COPYING COPYING.LESSER LICENSE.txt
> 
> %files htmlunit-plugin -f .mfiles-htmlunit-plugin
> 
> You could use:
> 
> ...
> 
> 
> %build
> %mvn_build -s
> 
> ...
> 
> %files -f .mfiles-jwebunit
> %license COPYING COPYING.LESSER LICENSE.txt
> 
> %files code-generator -f .mfiles-jwebunit-code-generator
> %license COPYING COPYING.LESSER LICENSE.txt
> 
> %files core -f .mfiles-jwebunit-core
> %license COPYING COPYING.LESSER LICENSE.txt
> %doc README.md

Ops forgotten
> %files htmlunit-plugin -f .mfiles-htmlunit-plugin
become %files htmlunit-plugin -f .mfiles-jwebunit-htmlunit-plugin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942



--- Comment #10 from gil cattaneo  ---
Must be removed all "Requires: ..." are useless.
Because all Requires are handled by our Java Tools.

Suggestion, instead of:

...
%mvn_package :%{name}-code-generator code-generator
%mvn_package :%{name}-core core
%mvn_package :%{name}-htmlunit-plugin htmlunit-plugin


%build
%mvn_build

...

%files -f .mfiles
%license COPYING COPYING.LESSER LICENSE.txt
%doc README.md

%files code-generator -f .mfiles-code-generator
%license COPYING COPYING.LESSER LICENSE.txt

%files core -f .mfiles-core
%license COPYING COPYING.LESSER LICENSE.txt

%files htmlunit-plugin -f .mfiles-htmlunit-plugin

You could use:

...


%build
%mvn_build -s

...

%files -f .mfiles-jwebunit
%license COPYING COPYING.LESSER LICENSE.txt

%files code-generator -f .mfiles-jwebunit-code-generator
%license COPYING COPYING.LESSER LICENSE.txt

%files core -f .mfiles-jwebunit-core
%license COPYING COPYING.LESSER LICENSE.txt
%doc README.md

%files htmlunit-plugin -f .mfiles-htmlunit-plugin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373019] Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373019



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-fuse

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349



--- Comment #12 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/flyingsaucersattack

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391598] Review Request: mkosi - Create legacy-free OS images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391598



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391598] Review Request: mkosi - Create legacy-free OS images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391598

Juan Orti  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Juan Orti  ---
Package is APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 5 files have unknown license. Detailed
 output of licensecheck in /home/juan/1391598-mkosi/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items 

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942



--- Comment #9 from Raphael Groner  ---
> # FIXME unavailable dependency for tests: tempus-fugit

Done, see bug #1009654.

I'll provide an update later, incl. fixes for the issues below.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391598] Review Request: mkosi - Create legacy-free OS images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391598

Juan Orti  changed:

   What|Removed |Added

 CC||j.orti.alca...@gmail.com
   Assignee|nob...@fedoraproject.org|j.orti.alca...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1324636] Review Request: python3-dbus - D-Bus Python 3 Bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324636

Tim Orling  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|williamjmore...@gmail.com   |ticot...@gmail.com
  Flags|needinfo?(williamjmorenor@g |
   |mail.com)   |



--- Comment #2 from Tim Orling  ---
I will take over the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373019] Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373019



--- Comment #5 from Juan Orti  ---
Thank you. Just tell me if you want me to review one of yours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373019] Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373019

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
+ latest version
+ package name is OK
+ license is acceptable (ISC)
+ license is specified correctly
+ standard python packaging template is used
+ %python_provide is present
+ provides/requires look OK
+ no scriptlets present or required

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349



--- Comment #11 from Hans de Goede  ---
(In reply to Link Dupont from comment #10)
> I like Zbigniew's suggestions.

Agreed I was planning on posting a new version, but you responded before I got
a chance too. Thanks for the review, I'll address Zbigniew's suggestions after
importing the pkg as reviewed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389927] Review Request: qtl866 - GUI driver for the TL866 (MiniPRO) chip programmer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389927

Lubomir Rintel  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||lrin...@redhat.com
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-11-03 14:43:04



--- Comment #3 from Lubomir Rintel  ---
Imported and built.
Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372836] Review Request: python-hug - A Python framework that makes developing APIs simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372836



--- Comment #5 from Haïkel Guémar  ---
0. spec URL is 2.2.0, maybe a cache issue
1. yes but not mandatory
2. I'll shorten it.
3. fixed.
4. ack
5. nope, tests are broken, it's confusing internal module with stdlib one
6. it is required for installation, and it's tied to a specific version of
Falcon much like urllib3/requests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928
Bug 1382928 depends on bug 1382926, which changed state.

Bug 1382926 Summary: Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart 
Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1382926

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382926] Review Request: perl-HTTP-MultiPartParser - HTTP MultiPart Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382926

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-03 14:22:24



--- Comment #8 from Fedora Update System  ---
perl-HTTP-MultiPartParser-0.01-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1381661] Review Request: obs-build - A generic package build script

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1381661

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-03 14:21:44



--- Comment #12 from Fedora Update System  ---
obs-build-20161025-231.1.1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388344] Review Request: javapoet - API for generating .java sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388344

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-03 14:21:37



--- Comment #7 from Fedora Update System  ---
javapoet-1.7.0-1.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382875] Review Request: psad - Port Scan Attack Detector (psad) watches for suspect traffic

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382875

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-03 14:21:10



--- Comment #16 from Fedora Update System  ---
psad-2.4.3-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383447] Review Request: python-winrm - Python library for Windows Remote Management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383447



--- Comment #10 from Fedora Update System  ---
python-winrm-0.2.1-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #9 from Germano Massullo  ---
I have forgotten to write that the spec is made for EPEL7 & Fedora >= 24

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #8 from Germano Massullo  ---
I removed all BuildRequires required for tests, because:
- python-coveralls has no builds for EPEL7;
- since tests are disabled, we no longer need those BuildRequires

spec file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/new/python-netjsonconfig.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/new/python-netjsonconfig-0.5.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382755] Review Request: legion - A data-centric parallel programming system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382755



--- Comment #12 from Christoph Junghans  ---
@besser82: I think this is ready for review now!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372836] Review Request: python-hug - A Python framework that makes developing APIs simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372836



--- Comment #4 from Iryna Shcherbina  ---
Hello Haïkel,

thank you for the response and updates.
However, the SpecURL link you've provided still holds the spec file for 2.1.2
hug version.

The spec file provided in the srpm looks good, but I still have a couple of
suggestions:

1) Please use macro instead of a hardcoded name in the %files section:
> %{_bindir}/hug

change to

`%{_bindir}/%{pypi_name}`

2) Please consider using %{summary} macro for the summary in your python3-
subpackage:

> Summary:A Python framework that makes developing APIs as simple as 
> possible, but no simpler

change to

`Summary:%{summary}`

This will fix the following rpmlint error:
`python3-hug.noarch: E: summary-too-long C A Python framework that makes
developing APIs as simple as possible, but no simpler`

3) Please fix another rpmlint error in the python3- subpackage %description
section. You might just copy the main description.
`python3-hug.noarch: E: description-line-too-long C A Python framework that
makes developing APIs as simple as possible, but no simpler`

4) Please include the `%doc README.md` in the %files section. It is now also
available, after your PR was merged, and it will fix the ugly
`python3-hug.noarch: W: no-documentation` warning.

5) Can I ask you, what was the problem with tests and if it was fixed?

6) Also, I do not see the purpose of `BuildRequires:  python3-falcon = 1.0.0`.
Is it required to build the RPM?

Apart from the above, everything looks good to me.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel 

[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389016



--- Comment #22 from Dave Love  ---
(In reply to Antonio Trande from comment #19)
> (In reply to Dave Love from comment #16)
> > (In reply to Antonio Trande from comment #14)
> > 
> > > - Some minor warnings from rpmlint.
> > 
> > Which ones do you want removed?  I wasn't convinced they were worth
> > bothering with.
> 
> 'spurious-executable-perm', 'zero-length'.

I'm not convinced the permission is spurious, since they are scripts.
The .make files are cleaned up now

> doc sub-package contains source files to compile samples. Is it the right
> place for them?

I don't know.  I thought that's OK, but I can't find any relevant policy.
I'll do something else reasonable with them if you say what.

I'll update to 1.5.2 when I get a chance (thanks).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #7 from Charalampos Stratakis  ---
And my previous comment also applies for the runtime requirements, python-six,
python-jinja2 (but not for python-jsonschema as that package doesn't use the
python provide macro or an explicit provides tag)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #6 from Charalampos Stratakis  ---
python-setuptools BuildRequires should be replaced with python2-setuptools as
the package provides that name from f24+ (unless you plan on building it for
F23 as well, where the python2 subpackage doesn't not provide the python2
namespace).

Same for python-nose where from F23+ the SPEC virtually provides the python2
name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #5 from Germano Massullo  ---
spec file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig-0.5.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942
Bug 1380942 depends on bug 1009654, which changed state.

Bug 1009654 Summary: Review Request: tempus-fugit - Java classes for temporal 
testing and concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=1009654

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391598] New: Review Request: mkosi - Create legacy-free OS images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391598

Bug ID: 1391598
   Summary: Review Request: mkosi - Create legacy-free OS images
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zbys...@in.waw.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://in.waw.pl/~zbyszek/fedora/mkosi.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/mkosi-1-1.fc26.src.rpm
Fedora Account System Username: zbyszek
Description:

A fancy wrapper around "dnf --installroot", "debootstrap" and
"pacstrap", that may generate disk images with a number of bells and
whistles.

Generated images are "legacy-free". This means only GPT disk labels
(and no MBR disk labels) are supported, and only systemd based images
may be generated. Moreover, for bootable images only EFI systems are
supported (not plain MBR/BIOS).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654

gil cattaneo  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||1.2-0.1.SNAPSHOT.fc26
 Resolution|--- |RAWHIDE
Last Closed||2016-11-03 11:11:15



--- Comment #11 from gil cattaneo  ---
Thanks to all!
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16283310

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373019] Review Request: python-fuse - Python module that provides a simple interface to FUSE and MacFUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373019



--- Comment #3 from Juan Orti  ---
This is the request to upstream to include the license text as a saparate file:
https://github.com/terencehonles/fusepy/issues/59

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/tempus-fugit

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #4 from Charalampos Stratakis  ---
Please remove the comment from the python2 subpackage, since it is explicitly
stated in the guidelines about the binary situation, you don't have to mention
it in the SPEC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #9 from gil cattaneo  ---
Thanks for the review!

create new SCM request:
https://admin.fedoraproject.org/pkgdb/package/requests/8553

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202470] Review Request: validator-htmlparser - An implementation of the HTML5 parsing algorithm in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202470

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202470] Review Request: validator-htmlparser - An implementation of the HTML5 parsing algorithm in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202470



--- Comment #17 from Fedora Update System  ---
validator-htmlparser-1.4-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-52797ac124

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1202504] Review Request: jsontools - Java Tools for the JSON Format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1202504

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063

Pavel Raiskup  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|prais...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390063] Package Review: classloader-leak-test-framework - Detection and verification of Java ClassLoader leaks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390063

Pavel Raiskup  changed:

   What|Removed |Added

 CC||package-review@lists.fedora
   ||project.org
  Component|postgresql-jdbc |Package Review
   Assignee|tre...@redhat.com   |nob...@fedoraproject.org
Summary|package |Package Review:
   |classloader-leak-test-frame |classloader-leak-test-frame
   |work so we are able to  |work - Detection and
   |build postgresql-jdbc   |verification of Java
   ||ClassLoader leaks



--- Comment #3 from Pavel Raiskup  ---
Stand-alone test framework for detecting and/or verifying the existence or
non-existence of Java ClassLoader leaks. It is also possible to test leak
prevention mechanisms to confirm that the leak really is avoided. The framework
is an built upon JUnit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391487] Review Request: nextcloud-client - The Nextcloud Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391487



--- Comment #2 from Germano Massullo  ---
(In reply to Nick Bebout from comment #1)
> Fails to build on epel7.  Are you intending to package it for epel?
> 
> https://kojipkgs.fedoraproject.org//work/tasks/2789/16282789/build.log

Not at the moment. There are problems in disabling dolphin integration (EPEL7)
on both owncloud-client nextcloud-client.
I will fix them later once I figure out what is better to do

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391487] Review Request: nextcloud-client - The Nextcloud Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391487



--- Comment #1 from Nick Bebout  ---
Fails to build on epel7.  Are you intending to package it for epel?

https://kojipkgs.fedoraproject.org//work/tasks/2789/16282789/build.log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #3 from Germano Massullo  ---
I edited the spec file to enable the binary for Python 3 only

spec file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig-0.5.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1360482



--- Comment #18 from Nick Bebout  ---
jhogarth - I'd recommend s/NextCloud/Nextcloud since Nextcloud is how upstream
writes it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457



--- Comment #2 from Charalampos Stratakis  ---
If the binary has the same functionality (usually it does) under python2 and
python3 it should only be packaged for the python3 subpackage.

As it is currently the binary is pointing to usr/bin/python3, and by including
it at both subpackages %files sections, as a result the python2 subpackage has
a dependency on python3.

If however you would like to package the binary for both python2 and python3
you can find guidance at the rpm porting guide [0]

[0] http://python-rpm-porting.readthedocs.io/en/latest/tools.html#install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391487] Review Request: nextcloud-client - The Nextcloud Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391487

Nick Bebout  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||n...@fedoraproject.org
   Assignee|nob...@fedoraproject.org|n...@fedoraproject.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457

Charalampos Stratakis  changed:

   What|Removed |Added

 CC||cstra...@redhat.com
   Assignee|nob...@fedoraproject.org|cstra...@redhat.com
  Flags||fedora-review?



--- Comment #1 from Charalampos Stratakis  ---
Taking this review as I provided also so initial feedback regarding the tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457

Charalampos Stratakis  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-HTTP-Entity-Parser

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389927] Review Request: qtl866 - GUI driver for the TL866 (MiniPRO) chip programmer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389927



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/qtl866

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389016



--- Comment #21 from Hans Pabst  ---
Version 1.5.2 addresses the soname issue, avoids building code as part of the
"install" target, and also resolves other (minor) issues or glitches. More
details can be found at https://github.com/hfp/libxsmm/releases/tag/1.5.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391487] New: Review Request: nextcloud-client - The Nextcloud Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391487

Bug ID: 1391487
   Summary: Review Request: nextcloud-client - The Nextcloud
Client
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: germano.massu...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description
Nextcloud-client enables you to connect to your private Nextcloud Server.
With it you can create folders in your home directory, and keep the contents
of those folders synced with your Nextcloud server. Simply copy a file into
the directory and the Nextcloud Client does the rest.

spec file:
https://germano.fedorapeople.org/package_reviews/nextcloud-client/nextcloud-client.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/nextcloud-client/nextcloud-client-2.2.4-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387291] Review Request: python-lazr-delegates - Easily write objects that delegate behavior

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387291



--- Comment #5 from Fedora Update System  ---
python-lazr-delegates-2.0.3-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7afbe2ffc9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387291] Review Request: python-lazr-delegates - Easily write objects that delegate behavior

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387291

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jitka Plesnikova  ---
> BuildRequires
> TODO: Remove perl(Module::Build) from build-require, it is not used
-BuildRequires:  perl(Module::Build)
Ok.

> FIX: Please add following build-requires:
>- perl(base) - t/Util.pm:5
>- perl(Carp) - lib/HTTP/Entity/Parser/MultiPart.pm:7
>- perl(Exporter) - t/Util.pm:5
>- perl(Fcntl) - lib/HTTP/Entity/Parser/MultiPart.pm:8
>- perl(File::Basename) - t/01_content_type/multipart.t:8
>- perl(HTTP::Headers) - t/01_content_type/multipart.t:6
>- perl(IO::File) - t/Util.pm:6
>- perl(strict) - lib/HTTP/Entity/Parser.pm:4
>- perl(utf8) - t/01_content_type/json.t:6
>- perl(warnings) - lib/HTTP/Entity/Parser.pm:5
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(Exporter)
+BuildRequires:  perl(Fcntl)
+BuildRequires:  perl(File::Basename)
+BuildRequires:  perl(HTTP::Headers)
+BuildRequires:  perl(IO::File)
+BuildRequires:  perl(base)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(utf8)
+BuildRequires:  perl(warnings)
Ok.

The package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391291] Review Request: perl-DBICx-AutoDoc - Generate automatic documentation of DBIx::Class:: Schema objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391291



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add following build-requires:
 make - spec file lines: 41, 44, 48
 perl(base) - lib/DBICx/AutoDoc.pm:5
 perl(DBIx::Class::Relationship::Helpers) - lib/DBICx/AutoDoc/Magic.pm:5
 perl(File::Spec) - lib/DBICx/AutoDoc.pm:13
 perl(FindBin) - lib/DBICx/AutoDoc.pm:8
 perl(strict) - lib/DBICx/AutoDoc.pm:2
 perl(warnings) - lib/DBICx/AutoDoc.pm:3

FIX: Either unbundle the ./inc files and build-require the Module::Install*
 modules whose functions are called from Makefile.PL or build-require
 dependencies of the bundled code (`perl(File::Find)' in
 inc/Module/Install.pm:23, `perl(File::Path)' in inc/Module/Install.pm:24
etc.).

$ rpm -qp --requires perl-DBICx-AutoDoc-0.08-2.fc26.noarch.rpm | sort | uniq -c
  1 /usr/bin/perl
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(Carp)
  1 perl(Class::Accessor::Grouped)
  1 perl(DBICx::AutoDoc)
  1 perl(DBICx::AutoDoc::Magic)
  1 perl(DBIx::Class)
  1 perl(DBIx::Class::Relationship::Helpers)
  1 perl(Data::Dump)
  1 perl(File::ShareDir)
  1 perl(File::Spec)
  1 perl(File::Temp)
  1 perl(FindBin)
  1 perl(Getopt::Long)
  1 perl(Pod::Usage)
  1 perl(Template)
  1 perl(Tie::IxHash)
  1 perl(base)
  1 perl(lib)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-DBICx-AutoDoc-0.08-2.fc26.noarch.rpm | sort | uniq -c
  1 perl(DBICx::AutoDoc) = 0.08
  1 perl(DBICx::AutoDoc::Magic) = 0.08
  1 perl-DBICx-AutoDoc = 0.08-2.fc26
Binary provides are Ok.

$ rpmlint ./perl-DBICx-AutoDoc*
perl-DBICx-AutoDoc.noarch: W: spelling-error %description -l en_US schemas ->
schema, sachems, schemes
perl-DBICx-AutoDoc.noarch: E: wrong-script-interpreter
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.png
[% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.png
644 [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: wrong-script-interpreter
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.png [%
ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.png
644 [% ENV.SHELL %]
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-inheritance.html
644 /usr/bin/perl
perl-DBICx-AutoDoc.noarch: E: non-executable-script
/usr/share/perl5/vendor_perl/auto/share/dist/DBICx-AutoDoc/AUTODOC-graph.html
644 /usr/bin/perl
perl-DBICx-AutoDoc.src: W: spelling-error %description -l en_US schemas ->
schema, sachems, schemes
2 packages and 1 specfiles checked; 6 errors, 2 warnings.

*.html and *.png are not scripts. The errors are not valid.
Rpmlint is ok.

Please correct all 'FIX' issues and provide new spec file.

The package is not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] New: Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457

Bug ID: 1391457
   Summary: Review Request: python-netjsonconfig - PaNetwork
configuration management library based on NetJSON
DeviceConfiguration
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: germano.massu...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description
netjsonconfig is a python library that converts NetJSON DeviceConfiguration
objects into real router configurations that can be installed on systems like
OpenWRT, LEDE or OpenWisp Firmware.

Could you please check if
%{_bindir}/netjsonconfig
on both python 2 and 3 sections, can cause any conflicts? Mock build works
good, but I want to ask to be 100% sure.

spec file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig-0.5.1-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391444] Review Request: boost159 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391444



--- Comment #1 from Haïkel Guémar  ---
Co-installability with EL7 boost is important, please test it!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391444] Review Request: boost159 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391444

Haïkel Guémar  changed:

   What|Removed |Added

  Component|Package Review  |Package Review
Version|rawhide |trunk
Product|Fedora  |RDO



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391444] New: Review Request: boost159 - The free peer-reviewed portable C++ source libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391444

Bug ID: 1391444
   Summary: Review Request: boost159 - The free peer-reviewed
portable C++ source libraries
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: karlthe...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://hguemar.fedorapeople.org/reviews/boost159.spec
SRPM URL:
https://hguemar.fedorapeople.org/reviews/boost159-1.59.0-1.el7.src.rpm
Description: The free peer-reviewed portable C++ source libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382928] Review Request: perl-HTTP-Entity-Parser - PSGI compliant HTTP Entity Parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382928



--- Comment #2 from Ralf Corsepius  ---
Updated version:
Spec URL:
https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser.spec
SRPM URL:
https://corsepiu.fedorapeople.org/packages/perl-HTTP-Entity-Parser-0.18-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372836] Review Request: python-hug - A Python framework that makes developing APIs simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372836



--- Comment #3 from Haïkel Guémar  ---
Spec URL: https://hguemar.fedorapeople.org/reviews/python-hug.spec
SRPM URL:
https://hguemar.fedorapeople.org/reviews/python-hug-2.2.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781



--- Comment #13 from gil cattaneo  ---
Build fails: [ERROR] Plugin org.apache.maven.plugins:maven-source-plugin:3.0.1
or one of its dependencies could not be resolved: Cannot access central
(https://repo.maven.apache.org/maven2) in offline mode and the artifact
org.apache.maven.plugins:maven-source-plugin:jar:3.0.1 has not been downloaded
from it before. -> [Help 1]
Please, remove this useless plugin/task with: 
%pom_remove_plugin :maven-source-plugin

RPMS spec file differ with the given spec file

--- /srpm-unpacked/sunflow.spec2016-10-17 13:24:18.0 +0200
+++ /srpm/sunflow.spec2016-11-03 10:05:04.418398346 +0100
@@ -11,10 +11,8 @@
 Source2: sunflow.desktop
 License: MIT
 BuildArch: noarch
-BuildRequires: jpackage-utils
 BuildRequires: desktop-file-utils
 BuildRequires: dos2unix
-BuildRequires: javapackages-tools
 BuildRequires: maven-local
 BuildRequires: janino

@@ -29,8 +27,6 @@
 %description javadoc
 API documentation for sunflow.

-# TODO: blender export plugin
-
 %prep
 %setup -q
 dos2unix -k CHANGELOG LICENSE README
@@ -40,7 +36,6 @@

 %install
 %mvn_install
-install -D -m 0644 target/%{name}-%{version}-javadoc.jar
$RPM_BUILD_ROOT%{_javadir}/%{name}/%{name}-javadoc.jar

 %jpackage_script org.sunflow.SunflowGUI "" "" "janino:sunflow" sunflow true

@@ -77,7 +72,6 @@

 %files javadoc -f .mfiles-javadoc
 %license LICENSE
-%{_datadir}/java/%{name}/%{name}-javadoc.jar

 %changelog
 * Mon Oct 17 2016 Michal Vala 
0.07.3-0.1.20140412git4f5017f
 - switch to new upstream https://github.com/skrat/sunflow

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1383781] Review Request: sunflow - A rendering system for photo-realistic image synthesis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383781

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #12 from gil cattaneo  ---
have time for review this https://bugzilla.redhat.com/show_bug.cgi?id=1390156 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372836] Review Request: python-hug - A Python framework that makes developing APIs simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372836

hgue...@redhat.com changed:

   What|Removed |Added

 CC||hgue...@redhat.com



--- Comment #2 from hgue...@redhat.com ---
1. it was latest when review was opened, I have now other people interested in,
so I'll update it.
2. pypi.io is also an accepted Source URL.
3. Yeah
3. running tests but that needed some fixing, I need to recheck now that 2.2.0
is out.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343208] Review Request: xfce4-hotcorner-plugin - XFCE4 HotCorner Panel Plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343208

davideol...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-11-03 04:21:13



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391291] Review Request: perl-DBICx-AutoDoc - Generate automatic documentation of DBIx::Class:: Schema objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391291

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Link Dupont  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] New: Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Bug ID: 1391334
   Summary: Review Request: freeorion - Turn-based space empire
and galactic conquest (4X) computer game
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: l...@sub-pop.net
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://fedorapeople.org/cgit/linkdupont/public_git/freeorion.git/plain/freeorion.spec
SRPM URL:
https://fedorapeople.org/~linkdupont/srpms/freeorion-0.4.6-1.fc26.src.rpm
Description:
FreeOrion, an open-source game inspired by Master of Orion, is a turn-based
game
of epic space strategy that builds on the classic '4X' model by incorporating
the nation-building elements of games such as Europa Universalis 2 and a
versatile tactical combat engine. While its modular, open-source design allows
for a significant degree of customization of the game engine and the story
elements by the community, the FreeOrion team is dedicated to the construction
of a living, breathing universe in a 'grand campaign' model.
Fedora Account System Username: linkdupont

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org