[Bug 846561] Review Request: groovy-gram - A metadata processing engine for Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=846561

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382995] Review Request: unit-api - JSR 363 - Units of Measurement API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382995



--- Comment #6 from gil cattaneo  ---
Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/8661

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382995] Review Request: unit-api - JSR 363 - Units of Measurement API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382995

gil cattaneo  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jonnyheggh...@sigaint.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382995] Review Request: unit-api - JSR 363 - Units of Measurement API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382995



--- Comment #5 from gil cattaneo  ---
(In reply to Jonny Heggheim from comment #3)
> Can you review bug 1187082?

it is already assigned some other review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382995] Review Request: unit-api - JSR 363 - Units of Measurement API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382995



--- Comment #4 from gil cattaneo  ---
(In reply to Jonny Heggheim from comment #3)
> Can you review bug 1187082?
Sure! Can you fill the "Assigned To" field?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152



--- Comment #10 from Jared Wallace  ---
Second unofficial review:
https://bugzilla.redhat.com/show_bug.cgi?id=1376511#c6

This is far from done though, several issues that need to be tackled before
review continues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376511] Review Request: nexus - NeXus scientific data file format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376511

Jared Wallace  changed:

   What|Removed |Added

 CC||jared-wall...@us.ibm.com



--- Comment #6 from Jared Wallace  ---
(This is an unofficial review)

I'll throw some notes out first, but do also review the automated tool output
below, as it identified a large quantity of issues as well.

1) You can remove the line "rm -rf $RPM_BUILD_ROOT" from %install

2) You've got a small ton of rpmlint errors that will either need fixing or
explaining (ignore spelling issues unless it really is mispelled)

3) If you have questions about any of the issues listed below, let me know and
I'll try to help you solve them.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/doc/NeXus/README.doc
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: nexus. Illegal package name: nexus. Does not
  provide -static: nexus.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
- ldconfig called in %post and %postun if required.
  Note: /sbin/ldconfig not called in nexus
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2) (with incorrect FSF address)", "*No copyright* GPL
 (v2)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL (v2 or
 later) (with incorrect FSF address)", "GPL (v2 or later) (with
 incorrect FSF address)", "*No copyright* LGPL (v2 or later) (with
 incorrect FSF address)", "GPL (v2)". 185 files have unknown license.
 Detailed output of licensecheck in /tmp/pkg-
 review/nexus/nexus/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/lib64/pkgconfig(pkgconfig), /usr/share/man/man1(filesystem)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 81920 bytes in 13 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other 

[Bug 1382995] Review Request: unit-api - JSR 363 - Units of Measurement API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382995



--- Comment #3 from Jonny Heggheim  ---
Can you review bug 1187082?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382995] Review Request: unit-api - JSR 363 - Units of Measurement API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382995

Jonny Heggheim  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Jonny Heggheim  ---
Review approved!


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382995] Review Request: unit-api - JSR 363 - Units of Measurement API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382995



--- Comment #1 from Jonny Heggheim  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- This seems like a Java package, please install fedora-review-plugin-java
  to get additional checks


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 26 files have unknown
 license. Only none code lacks the license header.
[x]: License file installed when any subpackage combination is installed.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = 

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152



--- Comment #9 from Jared Wallace  ---
*doh*

fixed spec is here:

https://bitbucket.org/jared-wallace/orpie/raw/e9223f4935c3716f46c577f389382ef4ccbe07a9/SPECS/orpie.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152

Jared Wallace  changed:

   What|Removed |Added

  Flags|needinfo?(jared-wallace@us. |
   |ibm.com)|



--- Comment #8 from Jared Wallace  ---
First unofficial review here:
https://bugzilla.redhat.com/show_bug.cgi?id=1392599#c2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082

Piotr Popieluch  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||piotr1...@gmail.com
   Docs Contact||piotr1...@gmail.com
  Flags||fedora-review+



--- Comment #18 from Piotr Popieluch  ---
Looks good, approved.

Thing to keep in mind is the non-numeric version number. This is only allowed
when they increment properly otherwise it can cause update issues. I couldn't
find upstreams versioning policy so not sure if it is.

I personally would include the license as a SOURCE, not patch it and I would
use sed to remove the shebang. But this is ok.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 3 files have unknown
 license. Detailed output of licensecheck in
 /home/piotr/rpmbuild/1187082-python-slowaes/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not 

[Bug 1392599] Review Request: mcrcon - Console based rcon client for minecraft servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392599

Jared Wallace  changed:

   What|Removed |Added

 CC||jared-wall...@us.ibm.com



--- Comment #2 from Jared Wallace  ---
**This is an unofficial review**

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues
==

1) *MUST* The description has lines exceeding 79 characters. Please split them
across multiple lines to avoid this.

2) *MUST* The README.txt has incorrect end-of-line encoding. You can fix this
with the following command:

sed -i 's/\r$//' README.txt

3) *SHOULD* Consider writing a manpage for this so people understand how to use
it. Here's a guide:
http://www.schweikhardt.net/man_page_howto.html

4) *SHOULD* The link you have to the spec file is not linked to the "raw" spec
file, but rather the Git page - it's better to link to the raw version. That
way when people click to save the link, they get the spec file and not HTML.

5) *SHOULD* You do not need the line "rm -rf %{buildroot}"

6) *OPTIONAL* Consider using copr to build this as outlined here:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Make_a_Package

7) *MUST* The source file mcrcon.c in your src rpm and the upstream source are
different. I suspect because the source url you have is for SourceForge, and
not the upstream github repo, which is here:
https://github.com/Tiiffi/mcrcon

Everything else seems to be alright. Good luck :)


(rest of the review below can be ignored, all issues are enumerated above)

= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "zlib/libpng". Detailed output of licensecheck in /tmp/pkg-
 review/mcrcon/mcrcon/licensecheck.txt
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII 

[Bug 1393996] Review Request: python-novajoin - Nova integration to enroll IPA clients

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393996



--- Comment #2 from Alan Pevec  ---
Please rename SRPM:
Name:   novajoin
should be
Name:   python-novajoin

empty top-level package packages makes no sense,
unless you wanted to put systemd services there?
In that case use Name: openstack-novajoin and check example spec for services
https://github.com/openstack-packages/openstack-example-spec/blob/master/openstack-example.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(jared-wallace@us.
   ||ibm.com)



--- Comment #7 from Randy Barlow  ---
Hey Jared! The changes look nice! Two things I noticed in your changelog:

* There's a line that says you added the multi-core, but as you noted it
doesn't build that way so it's not actually added. I think it's OK to not build
multi-core since that doesn't work, so let's just drop that changelog entry.
* Typically people add a space between changelog entries for readability, so
adding one more newline before the Wed Oct 05 line would improve readability.
This is just a suggestion of mine, not a formal requirement, so it's up to you.

Let's fix at least that first one, and then I think this'll be ready to pass
review. Then we can look at some package reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #17 from Raphael Groner  ---
Okay, let's skip EPEL for now. Related tests of jwebunit plugin generally don't
work in koji anyways.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385331] Review Request: hot-tux - Graphical CPU utilization monitoring utility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385331

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #13 from Raphael Groner  ---
APPROVED.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: coreutils gcc sed
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
=> Ignore.

[?]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
=> Please add a short comment why to use makefile.patch. 


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
=> Artistic clarified.

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 18 files have unknown license. Detailed
 output of licensecheck in /home/builder/fedora-review/1385331-hot-
 tux/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hot-tux-
 debuginfo
=> Ignore.

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #16 from Raphael Groner  ---
Okay, let's skip EPEL for now. Related ests of jwebunit plugin generally don't
work in koji anyways.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1369708

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #45 from Raphael Groner  ---
Please follow the official process to get sponsored as a packager:
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380179] Review Request: webvirtmgr - panel for manage virtual machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380179



--- Comment #5 from Raphael Groner  ---
I can try to work with upstream on a patch to update webvirtmgr to work with a
newer Django.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344261] Review Request: warsow - Fast paced 3D first person shooter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344261



--- Comment #8 from Raphael Groner  ---
FTBFS

You may need 'BuildRequires: pkgconfig(gl)' that installs mesa-libGL-devel
including the missing %{_includedir}/GL/gl.h file.

[  8%] Building C object ref_gl/CMakeFiles/ref_gl.dir/r_alias.c.o
cd /builddir/build/BUILD/warsow_21_sdk/source/source/cmake_build/ref_gl &&
/usr/bin/cc  -DAPPLICATION_VERSION_HEADER=\"version.warsow.h\"
-DFREETYPELIB_RUNTIME -DLIBCURL_RUNTIME -DLIBJPEG_RUNTIME -DLIBPNG_RUNTIME
-DOGGLIB_RUNTIME -DTHEORALIB_RUNTIME -DUSE_SDL2 -DVORBISLIB_RUNTIME
-DZLIB_RUNTIME -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -Dref_gl_EXPORTS
-I/usr/include/SDL2  -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -pipe -Wall
-Wno-unused-function -fvisibility=hidden -Winvalid-pch -std=gnu99
-D_POSIX_C_SOURCE=200112L -D_XOPEN_SOURCE=500 -DNDEBUG -fno-strict-aliasing
-ffast-math -funroll-loops -fPIC   -o CMakeFiles/ref_gl.dir/r_alias.c.o   -c
/builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_alias.c
In file included from
/builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_glimp.h:70:0,
 from
/builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_local.h:72,
 from
/builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/r_alias.c:23:
/builddir/build/BUILD/warsow_21_sdk/source/source/ref_gl/qgl.h:69:19: fatal
error: GL/gl.h: No such file or directory
 #include 
   ^
compilation terminated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942

Raphael Groner  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1009654
 Depends On|1009654 |



--- Comment #14 from Raphael Groner  ---
SPEC: https://raphgro.fedorapeople.org/review/java/testing/jwebunit.spec
SRPM:
https://raphgro.fedorapeople.org/review/java/testing/jwebunit-3.3-4.fc25.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16407426

%changelog
* Fri Nov 11 2016 Raphael Groner <> - 3.3-4
- drop unneeded explicit Requires
- add weak dependency to plugin
- simplify build of subpackages
- use available tempus-fugit
- disable plugin tests


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1009654
[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal
testing and concurrency
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654

Raphael Groner  changed:

   What|Removed |Added

 Blocks|1380942 |
   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1380942




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1380942
[Bug 1380942] Review Request: jwebunit - Java framework for testing web
applications
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148

Yaakov Selkowitz  changed:

   What|Removed |Added

 CC||yselk...@redhat.com



--- Comment #8 from Yaakov Selkowitz  ---
Are there any other parts of gst-plugins-ugly which we can include as a
(slightly) more complete gstreamer1-plugins-ugly-free?

There are five plugins under gst/ with actual code:

* asfdemux: demuxer for Microsoft's Advanced Streaming Format
* dvdlpcmdec: Decode DVD LPCM frames into standard PCM
* dvdsub: DVD subtitle parser and decoder
* realmedia: RealMedia support
* xingmux: add Xing tags to MP3 files

And the following plugins under ext/ which just wrap other libraries which are,
or could be, in Fedora:

* cdio: read CD audio with libcdio (which is free but GPL)
* dvdread: access DVDs with libdvdread (which is free but GPL; note that there
is another plugin already in gstreamer1-plugins-bad-free which uses
libdvd{nav,read})
* mad: MP3 decoding with libmad (not yet in Fedora, but should be acceptable as
a MP3 decoder; license is GPL)

There are others, but their dependent libraries are not in Fedora for legal
reasons, or just obsolete (namely, libsidplay).  Precedence is that ext/
plugins need not be removed from the tarballs even if they wrap unacceptable
libraries, since they are just wrappers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152



--- Comment #6 from Jared Wallace  ---
New spec:
https://bitbucket.org/jared-wallace/orpie/raw/f4be32478c1f3fcbc215e090e08064beb7290c19/SPECS/orpie.spec

New
SRPM:https://bitbucket.org/jared-wallace/orpie/raw/f4be32478c1f3fcbc215e090e08064beb7290c19/SRPMS/orpie-1.5.2-2.fc24.src.rpm

The parallel compiler flag actually breaks the build :/

I opened an issue upstream here:
https://github.com/pelzlpj/orpie/issues/9

Copr has new builds as well

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382152] Review Request: orpie - scientific calculator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382152

Jared Wallace  changed:

   What|Removed |Added

  Flags|needinfo?(jared-wallace@us. |
   |ibm.com)|



--- Comment #5 from Jared Wallace  ---
Thanks :)

I'll get to work on these items and the reviews immediately.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942
Bug 1380942 depends on bug 1009654, which changed state.

Bug 1009654 Summary: Review Request: tempus-fugit - Java classes for temporal 
testing and concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=1009654

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654

gil cattaneo  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed|2016-11-03 11:11:15 |2016-11-11 13:42:30



--- Comment #15 from gil cattaneo  ---
(In reply to Raphael Groner from comment #14)
> Could you build jmock for EPEL7?
No. I do not maintain packages for EPEL
> Otherwise, tempus-fugit is not possible for EPEL7.
If you want, i can leave the property of these packages, for these branches

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #13 from Fedora Update System  ---
tempus-fugit-1.2-0.1.SNAPSHOT.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-93ec0bcedb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654



--- Comment #12 from Fedora Update System  ---
tempus-fugit-1.2-0.1.SNAPSHOT.fc24 has been submitted as an update to Fedora
24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-aff6d6dc37

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1009654] Review Request: tempus-fugit - Java classes for temporal testing and concurrency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1009654

Raphael Groner  changed:

   What|Removed |Added

 Status|CLOSED  |MODIFIED
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #14 from Raphael Groner  ---
Could you build jmock for EPEL7?
Otherwise, tempus-fugit is not possible for EPEL7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380942] Review Request: jwebunit - Java framework for testing web applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380942
Bug 1380942 depends on bug 1009654, which changed state.

Bug 1009654 Summary: Review Request: tempus-fugit - Java classes for temporal 
testing and concurrency
https://bugzilla.redhat.com/show_bug.cgi?id=1009654

   What|Removed |Added

 Status|CLOSED  |MODIFIED
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #15 from Fedora Update System  ---
mpg123-1.23.8-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dec08a99bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #6 from Jakub Jelen  ---
The testsuite requires python

  [librdkafka-0.9.2]$ grep -r "python"
  tests/LibrdkafkaTestApp.py:#!/usr/bin/env python
  [...]

so I guess we need BuildRequires python for the tests.



Rpmlint (installed packages)

sh: /usr/bin/python: No such file or directory

> probably bug in fedora-review in rawhide

librdkafka-devel.x86_64: W: only-non-binary-in-usr-lib

> The *.so files in the non-devel should have reasonable permissions (but it 
> does not look like helping the message above). A bug in rpmlint (bug 
> #1251505)?:

> %attr(0644,root,root) %{_libdir}/librdkafka.so.*
> %attr(0644,root,root) %{_libdir}/librdkafka++.so.*

librdkafka-devel.x86_64: W: no-documentation

> We should have some manual page. Though it is not crucial

librdkafka.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/librdkafka++.so.1 /lib64/libz.so.1
librdkafka.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/librdkafka++.so.1 /lib64/librt.so.1

> Make sure the libraries (libz, librt) are used in the code or the proper 
> configure flags are used to build the package with these dependencies.

3 packages and 0 specfiles checked; 0 errors, 4 warnings.

===
Otherwise it looks good

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #15 from Antonio Trande  ---
coot does not compile on rawhide:

libtool: compile:  g++ -DPACKAGE_NAME=\"coot\" -DPACKAGE_TARNAME=\"coot\"
-DPACKAGE_VERSION=\"0.8.7\" "-DPACKAGE_STRING=\"coot 0.8.7\""
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"coot\"
-DVERSION=\"0.8.7\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1
-DLT_OBJDIR=\".libs/\" -DHAVE_OPENMP=1 -DFFTW2_PREFIX_S=1 "-DHAVE_BOOST=/**/"
-DHAVE_PYTHON=\"2.7\" "-DHAVE_BOOST_PYTHON=/**/" -I. -I.. -I/usr/include
-DHAVE_GOOCANVAS -I/usr/include/goocanvas-1.0 -pthread -I/usr/include/gtk-2.0
-I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/atk-1.0
-I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libdrm
-I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/pango-1.0
-I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/glib-2.0
-I/usr/lib64/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16
-I/usr/include/freetype2 -I/usr/include/libpng16 -DMAKE_ENHANCED_LIGAND_TOOLS
-I/usr/include/rdkit -DRDKIT_HAS_CAIRO_SUPPORT -DUSE_PYTHON
-I/usr/include/python2.7 -I/usr/include/python2.7 -DUSE_PYGTK
-DPKGDATADIR=\"/usr/share/coot\" -O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic
-fno-strict-aliasing -Wall -Wno-unused -c lbg-search.cc  -fPIC -DPIC -o
.libs/lbg-search.o
lbg-search.cc:37:47: fatal error: GraphMol/MolDraw2D/MolDraw2DCairo.h: No such
file or directory
 #include 
   ^

Wrong path of header file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392606] Review Request: perl-Encode-IMAPUTF7 - Process the special UTF-7 variant required by IMAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392606



--- Comment #11 from Jason Tibbitts  ---
Hmm, I didn't see any open reviews for any of the deps and the IMAPTalk one was
just submitted so I don't think any work has been duplicated besides the
IMAPTalk package which I was about to submit but now don't have to.

Still need to package Mail::JMAPTalk, Net::DAVTalk, Net::CalDAVTalk,
Net::CardDAVTalk (which aren't on CPAN and haven't yet had tagged releases)and
double check the rest of the dependencies listed at
https://github.com/cyrusimap/cassandane/blob/master/doc/README.deps

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gstreamer1-plugin-mpg123

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #5 from Radovan Sroka  ---
Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/raw/master/f/librdkafka-0.9.2-4.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #4 from Jakub Jelen  ---
Few more notes from fedora-review:

Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
  Note: Unversioned so-files directly in %_libdir.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #14 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mpg123

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Matthew Miller  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Matthew Miller  ---
Looks great to me. Review accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #12 from Wim Taymans  ---
Updated files with Obsoletes: -lib-devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #3 from Jakub Jelen  ---
Rpmlint
---
Checking: librdkafka-0.9.2-2.fc24.x86_64.rpm
  librdkafka-devel-0.9.2-2.fc24.x86_64.rpm
  librdkafka-debuginfo-0.9.2-2.fc24.x86_64.rpm
  librdkafka-0.9.2-2.fc24.src.rpm
librdkafka.x86_64: W: devel-file-in-non-devel-package /usr/lib64/librdkafka.so
librdkafka.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/librdkafka++.so

> Non-versioned *.so files should go to the *-devel package

librdkafka-devel.x86_64: W: only-non-binary-in-usr-lib
librdkafka-devel.x86_64: W: no-documentation
librdkafka-devel.x86_64: W: spurious-executable-perm
/usr/include/librdkafka/rdkafka.h
librdkafka-devel.x86_64: W: spurious-executable-perm
/usr/include/librdkafka/rdkafkacpp.h
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

in specfile:
> %defattr(444,root,root)

> The %defattr directive in the %files list SHOULD ONLY be used when setting a 
> non-default value, or to reset to the default value after having set a 
> non-default value. 

From https://fedoraproject.org/wiki/Packaging:Guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392457] Re-review Request for renaming python package to python2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392457



--- Comment #2 from Miro Hrončok  ---
You need to rename the specfile as well:

- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: python.spec should be python2.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375670] Review Request: python26 - Version 2.6 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375670

Miro Hrončok  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-11-11 10:38:59



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #11 from Wim Taymans  ---
Updated files:

https://people.freedesktop.org/~wtay/SPECS/mpg123.spec
https://people.freedesktop.org/~wtay/SRPMS/mpg123-1.23.8-3.fc24.src.rpm

Also:

https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-mpg123.spec
https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-mpg123-1.10.0-3.fc24.src.rpm

because -libs-devel -> -devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382859] Review Request: kelbt - Backtracking LR Parsing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382859

Igor Gnatenko  changed:

   What|Removed |Added

  Flags|needinfo?(ignatenko@redhat. |
   |com)|



--- Comment #2 from Igor Gnatenko  ---
(In reply to Randy Barlow from comment #1)
> There are two things we'll need to do:
> 
> 1) Drop the g++ BuildRequires, since it's not needed, and
it is needed for building.
> 2) Let's ask for an FPC exception for that bundled library.
according to latest guidelines, no need to ask for exception.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343977] Review Request: rubygem-asciidoctor-mallard - A Project Mallard converter for AsciiDoc

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343977

Tummala Dhanvi (c0mrad3)  changed:

   What|Removed |Added

  Flags||needinfo?(vondruch@redhat.c
   ||om)



--- Comment #10 from Tummala Dhanvi (c0mrad3)  ---
(In reply to Vít Ondruch from comment #9)
> * Source of the gem?
>   - Where did you get the source gem? It is not available on rubygems.org as
> far
> as I can tell, neither you documented anywhere how you obtained it.
The spec file contained the url of the github repo
https://github.com/asciidoctor/asciidoctor-mallard

I have built the gem my self using `gem build *.gemspec`
> 
> * Package naming
>   - Please rename the .spec file to rubygem-asciidoctor-mallar.spec to be in
> line with the guidelines [1].
Updated
> 
> * Package version
>   - Please use proper version scheme. The package version should be probably
> just "0.1.0" while the release should be "0.1.dev".
>   - The versioning is documented in detail here [2].
I upstream had it versioning like that
https://github.com/asciidoctor/asciidoctor-mallard/blob/master/lib/asciidoctor-mallard/version.rb

but I have updated it to 0.1.dev
> 
> * Duplicated license
>   - You should not include the "%license LICENSE.adoc". Please keep just
> "%doc
> %{gem_instdir}/LICENSE.adoc" in the main package (and change the %doc to
> %license of course).

Done

> * Unneeded requires
>   - You probably don't need to include "Requires: rubygem-thread_safe".
> Runtime
> requires should be autogenerated during build process.

Done

>   - Not sure what is the "pintail" good for. Some explaining hint above would
> come handy.
pintail is actually not required

Pintail is a tool to convert mallard to html
(https://github.com/projectmallard/pintail)

This package converts asciidoc to mallard  
> 
> * Doc subpackage
>   - It is good habit to keep the documentation in -doc subpackage.
Done
> 
> * Test suite
>   - Well, the line you used is just part of the story. You can see that there
> is nothing which would indicated, that the test suite was executed. You
> should use following line:
> 
> ```
> ruby -Ilib -e 'Dir.glob "./test/*_test.rb", (:require)'
> ```
> 
>   - Unfortunately, there seems to be dependency on asciidoctor-doctest, which
> is not in Fedora yet. Since it has quite lot of dependencies, it is
> probably not worth of packaging ATM, but all this should be documented.
>   - Instead of execution of test suite, you should consider to provide at
> least
> some sanity test, e.g. try to convert some document from AsciiDoc to
> Mallard using the %{gem_instdir}/bin/asciidoctor-mallard
> 
Can you please explain me a bit more about how to get it right ? 

URL: https://dhanvi.fedorapeople.org/packages/asciidoctor-mallard/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Jakub Jelen  changed:

   What|Removed |Added

 CC||jje...@redhat.com
   Assignee|nob...@fedoraproject.org|jje...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382859] Review Request: kelbt - Backtracking LR Parsing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382859

Randy Barlow  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #1 from Randy Barlow  ---
There are two things we'll need to do:

1) Drop the g++ BuildRequires, since it's not needed, and
2) Let's ask for an FPC exception for that bundled library.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2  
  randy: Sounds like you can just drop this one.


= MUST items =  

C/C++:  
[x]: Package does not contain kernel modules.   
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present. 
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.   

Generic:
[x]: Package is licensed with an open-source compatible license and meets   
 other legal requirements as defined in the legal section of Packaging  
 Guidelines.
[x]: License field in the package spec file matches the actual license. 
 Note: Checking patched sources after %prep for licenses. Licenses  
 found: "GPL (v2 or later) (with incorrect FSF address)", "MIT/X11 (BSD 
 like)", "LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown  
 or generated". 20 files have unknown license. Detailed output of   
 licensecheck in /home/rbarlow/reviews/1382859-kelbt/licensecheck.txt   
[x]: License file installed when any subpackage combination is installed.   
[x]: If the package is under multiple licenses, the licensing breakdown 
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
 randy: It sounds like we will need to get FPC approval for this aapl
package. I also attempted to find its upstream and was unable
to find it ☹
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description 

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #14 from Tim Fenn  ---
(In reply to Antonio Trande from comment #13)
> Package Review
> ==
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> ===
> - Package does not use a name that already exists.
>   Note: A package with this name already exists. Please check
>   https://admin.fedoraproject.org/pkgdb/package/coot
>   See:
>  
> https://fedoraproject.org/wiki/Packaging/
> NamingGuidelines#Conflicting_Package_Names
> 
> - Add 'Requires: lib%{name}%{?_isa} = %{version}-%{release}' to
> libcoot-devel.
> 

Done.

> - Add 'Requires: python2-lib%{name}%{?_isa} = %{version}-%{release}' to
> python2-libcoot-devel.
> 

Done.

> - 'coot-data' must be a noarch package.
>   Main package requires 'coot-data' as a noarch dependence.
> 
>   Requires: %{name}-data = %{version}-%{release}
> 


Done.

> - 'coot-doc' is a stand-alone package that must provide a license file.
> 

Done.

> - Following lines can be removed
> 
> %post -n python2-libcoot
> /sbin/ldconfig
> 
> %postun -n python2-libcoot
> /sbin/ldconfig
> 
> - ldconfig scriptlets can be written in this way
> 
> %post -n libcoot -p /sbin/ldconfig
> %postun -n libcoot -p /sbin/ldconfig
> 

Done.

> - Please, remove those macros in the comments or silence them with %%.
> 

Done.

> - Fix strange-permission warnings (set them with 644)
> 
> coot.src: W: strange-permission reference-structures.tar.gz 444

Fixed.

> coot.src: W: strange-permission coot.in 755
> 

This is set to 755 as its processed by autoconf to generate the coot script
that starts the main program.

I've also discussed the testing of the build with upstream, and there are
several files/custom scripts required to run the tests. I've asked upstream to
consider streamlining this in some way, but for now I've disabled the "make
check", since by itself it does nothing.

Also, the package was updated to version 0.8.7 (which fixes some of the smaller
issues, such as removing AM_PROG_CC_STDC).

https://timfenn.fedorapeople.org/coot.spec
https://timfenn.fedorapeople.org/coot-0.8.7-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148

Matthew Miller  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Matthew Miller  ---
Okay, builds fine in mock. Must be something weird in my local environment.

Everything else looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #2 from Radovan Sroka  ---
Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/raw/master/f/librdkafka-0.9.2-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #10 from Matthew Miller  ---
Neal, do you think the devel package name is a hard blocker? I agree it would e
more consistent. I guess we can do taht with another provides/obsoletes on the
existing (slightly odd) name as there is for libmpg123-devel.

Wim, can you fix the "Plulseaudio" typo while we're at it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #1 from Daniel Kopeček  ---
Found a small issue in the spec. Here's the pagure PR:

https://pagure.io/librdkafka/pull-request/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382859] Review Request: kelbt - Backtracking LR Parsing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382859

Randy Barlow  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ra...@electronsweatshop.com
   Assignee|nob...@fedoraproject.org|ra...@electronsweatshop.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #9 from Neal Gompa  ---
The Enhances is pointless, so remove them. You already have a hard Requires on
it anyway.

The Supplements look good to me.

Please don't name devel subpackages "libs-devel". That's just asking for
trouble because it's inconsistent with how we generally name development
subpackages. Please change it to "mpg123-devel".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393899] Review Request: libdirq - C implementation of the simple directory queue algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393899



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libdirq

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148



--- Comment #5 from Matthew Miller  ---
Still not working for me. I get 

+ ninja-build -v install
[0/1] '/usr/bin/python3' '/usr/bin/meson' '--internal' 'install'
'/home/mattdm/rpmbuild/BUILD/gst-plugin-mpg123-1.10.0/rpmbuilddir/meson-private/install.dat'
Installing ext/mpg123/libgstmpg123.so to
/home/mattdm/rpmbuild/BUILDROOT/gstreamer1-plugin-mpg123-1.10.0-2.fc25.mattdm.x86_64/usr/lib/x86_64-linux-gnu/gstreamer-1.0/libgstmpg123.so


I have 

  meson-0.35.1-1.fc25.noarch
  ninja-build-1.7.1-3.fc25.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148

Wim Taymans  changed:

   What|Removed |Added

 CC||wtaym...@redhat.com



--- Comment #4 from Wim Taymans  ---
Updated files:

https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-mpg123.spec
https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-mpg123-1.10.0-2.fc24.src.rpm

It installs in the right place for me. I have:

meson.noarch 0.35.0-3.fc24  @updates
ninja-build.x86_64   1.7.1-3.fc24   @updates

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] New: Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Bug ID: 1394275
   Summary: Review Request: librdkafka - C/C++ library
implementation of the Apache Kafka protocol
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rsr...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://pagure.io/librdkafka/raw/master/f/librdkafka.spec
SRPM URL:
https://pagure.io/librdkafka/blob/master/f/librdkafka-0.9.2-1.fc24.src.rpm
Description: 

Librdkafka is a C/C++ library implementation of the Apache Kafka protocol,
containing both Producer and Consumer support.
It was designed with message delivery reliability and high performance in mind,
current figures exceed 80 messages/second for the producer and 3 million 
messages/second for the consumer.

Fedora Account System Username: rsroka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147



--- Comment #8 from Matthew Miller  ---
Neal (or someone) can you comment on the Enhances/Supplements in the updated
package?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391457] Review Request: python-netjsonconfig - PaNetwork configuration management library based on NetJSON DeviceConfiguration

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391457

Charalampos Stratakis  changed:

   What|Removed |Added

 CC||germano.massu...@gmail.com
  Flags||needinfo?(germano.massullo@
   ||gmail.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392606] Review Request: perl-Encode-IMAPUTF7 - Process the special UTF-7 variant required by IMAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392606

Petr Pisar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=772620



--- Comment #10 from Petr Pisar  ---
I submitted all the dependencies for a review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 772620] Review Request: perl-Encode-IMAPUTF7 - Perl extension to deal with UTF-7 modification for IMAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=772620

Petr Pisar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1392606



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 772618] Review Request: perl-News-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=772618

Petr Pisar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1394267



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394267] Review Request: perl-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394267

Petr Pisar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=772618



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394267] New: Review Request: perl-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394267

Bug ID: 1394267
   Summary: Review Request: perl-NNTPClient - Perl 5 module to
talk to NNTP (RFC977) server
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ppisar.fedorapeople.org/perl-NNTPClient/perl-NNTPClient.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-NNTPClient/perl-NNTPClient-0.37-1.fc26.src.rpm
Description:
This module implements a client interface to NNTP, enabling a Perl 5
application to talk to NNTP servers. It uses the Object Oriented
Programming interface.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Wim Taymans  changed:

   What|Removed |Added

 CC||wtaym...@redhat.com



--- Comment #7 from Wim Taymans  ---
Updated files:

https://people.freedesktop.org/~wtay/SPECS/mpg123.spec
https://people.freedesktop.org/~wtay/SRPMS/mpg123-1.23.8-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393899] Review Request: libdirq - C implementation of the simple directory queue algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393899

Alejandro Alvarez  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Alejandro Alvarez  ---
Accepted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394262




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394262
[Bug 1394262] Review Request: perl-Net-CardDAVTalk - CardDAV client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394262




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394262
[Bug 1394262] Review Request: perl-Net-CardDAVTalk - CardDAV client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394262




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394262
[Bug 1394262] Review Request: perl-Net-CardDAVTalk - CardDAV client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394262] Review Request: perl-Net-CardDAVTalk - CardDAV client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394262

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1394242, 1394183, 1394174




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394174
[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way
https://bugzilla.redhat.com/show_bug.cgi?id=1394183
[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very
fast parsing of VCards
https://bugzilla.redhat.com/show_bug.cgi?id=1394242
[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394262] New: Review Request: perl-Net-CardDAVTalk - CardDAV client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394262

Bug ID: 1394262
   Summary: Review Request: perl-Net-CardDAVTalk - CardDAV client
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Net-CardDAVTalk/perl-Net-CardDAVTalk.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Net-CardDAVTalk/perl-Net-CardDAVTalk-0.03-1.fc26.src.rpm
Description:
This is an CardDAV client with FastMail Perl API.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393899] Review Request: libdirq - C implementation of the simple directory queue algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393899



--- Comment #6 from lionel.c...@cern.ch ---
Indeed, now added...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393021] Review Request: pulledpork - Pulled Pork for Snort and Suricata rule management

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393021



--- Comment #12 from Fedora Update System  ---
pulledpork-0.7.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-6e20685523

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394252




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250

Athmane Madjoudj  changed:

   What|Removed |Added

 Blocks||1381750




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1381750
[Bug 1381750] python3-aiohttp has dependency on multidict>=2 which is not
available in F24 and F25
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to hash conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394240

Petr Pisar  changed:

   What|Removed |Added

 Blocks|1394252 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394252




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON data interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394252

Petr Pisar  changed:

   What|Removed |Added

 Depends On|1394215, 1394240|1394167, 1394242, 1394183




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394167
[Bug 1394167] Review Request: perl-Data-ICal-TimeZone - Time zones for
Data::ICal
https://bugzilla.redhat.com/show_bug.cgi?id=1394183
[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very
fast parsing of VCards
https://bugzilla.redhat.com/show_bug.cgi?id=1394215
[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to
Data::UUID
https://bugzilla.redhat.com/show_bug.cgi?id=1394240
[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to
hash conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1394242
[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to Data:: UUID

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394215

Petr Pisar  changed:

   What|Removed |Added

 Blocks|1394252 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394167] Review Request: perl-Data-ICal-TimeZone - Time zones for Data::ICal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394167

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394252




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250

Athmane Madjoudj  changed:

   What|Removed |Added

 Blocks||1391287




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1391287
[Bug 1391287] python3-aiohttp requires async_timeout
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394252




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to Data:: UUID

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394215

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394252




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to hash conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394240

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394252




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394252
[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON
data interface
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON data interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394252

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1394215, 1394240, 1394174




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394174
[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way
https://bugzilla.redhat.com/show_bug.cgi?id=1394215
[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to
Data::UUID
https://bugzilla.redhat.com/show_bug.cgi?id=1394240
[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to
hash conversion
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394252] New: Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON data interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394252

Bug ID: 1394252
   Summary: Review Request: perl-Net-CalDAVTalk - CalDAV client
with JSON data interface
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-Net-CalDAVTalk/perl-Net-CalDAVTalk.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-Net-CalDAVTalk/perl-Net-CalDAVTalk-0.09-1.fc26.src.rpm
Description:
This a Perl library for accessing CalDAV servers providing JSON interface to
the data.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250



--- Comment #2 from Athmane Madjoudj  ---
Sorry, copy-paste typo:

Spec URL: https://athmane.fedorapeople.org/pkgs/python-async_timeout.spec
SRPM URL:
https://athmane.fedorapeople.org/pkgs/python-async_timeout-1.1.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250



--- Comment #1 from Athmane Madjoudj  ---
rpmlint:

$ rpmlint SPECS/python-async_timeout.spec 
SRPMS/python-async_timeout-1.1.0-1.fc25.src.rpm
RPMS/noarch/python3-async_timeout-1.1.0-1.fc25.noarch.rpm 
python-async_timeout.src: W: spelling-error Summary(en_US) asyncio -> Asuncion
python-async_timeout.src: W: summary-not-capitalized C asyncio-compatible
timeout context manager
python-async_timeout.src: W: spelling-error %description -l en_US asyncio ->
Asuncion
python3-async_timeout.noarch: W: spelling-error Summary(en_US) asyncio ->
Asuncion
python3-async_timeout.noarch: W: summary-not-capitalized C asyncio-compatible
timeout context manager
python3-async_timeout.noarch: W: spelling-error %description -l en_US asyncio
-> Asuncion
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] New: Review Request: python-async_timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250

Bug ID: 1394250
   Summary: Review Request: python-async_timeout -
asyncio-compatible timeout context manager
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: athma...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://athmane.fedorapeople.org/pkgs/python-async_timeout.spec
SRPM URL:
https://athmane.fedorapeople.org/pkgs/python-fluidity-sm-0.2.0-1.fc20.src.rpm
Description:
asyncio-compatible timeout context manager

Fedora Account System Username: athmane

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394242

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1394215, 1394240, 1394174




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394174
[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way
https://bugzilla.redhat.com/show_bug.cgi?id=1394215
[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to
Data::UUID
https://bugzilla.redhat.com/show_bug.cgi?id=1394240
[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to
hash conversion
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393899] Review Request: libdirq - C implementation of the simple directory queue algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393899



--- Comment #5 from Alejandro Alvarez  ---
Looks good. Last missing thing: %defattr(-,root,root,-) for %files static

rpmlint:
libdirq.src: W: spelling-error %description -l en_US filesystem -> file system,
file-system, systematic
libdirq.src: W: spelling-error %description -l en_US scalability ->
availability, sociability, inviolability
libdirq.src:77: E: files-attr-not-set
libdirq.src: W: no-cleaning-of-buildroot %install
1 packages and 0 specfiles checked; 1 errors, 3 warnings.

Cheers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to Data:: UUID

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394215

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394242




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394242
[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to hash conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394240

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394242




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394242
[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394174] Review Request: perl-XML-Spice - Generating XML in Perl way

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394174

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1394242




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394242
[Bug 1394242] Review Request: perl-Net-DAVTalk - Client for DAV servers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org