[Bug 1403724] Review Request: php-justinrainbow-json-schema4 - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403724



--- Comment #13 from Fedora Update System  ---
php-justinrainbow-json-schema4-4.1.0-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8c84d412a2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403724] Review Request: php-justinrainbow-json-schema4 - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403724

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403724] Review Request: php-justinrainbow-json-schema4 - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403724



--- Comment #14 from Fedora Update System  ---
php-justinrainbow-json-schema4-4.1.0-1.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4bb2e63763

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403724] Review Request: php-justinrainbow-json-schema4 - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403724



--- Comment #15 from Fedora Update System  ---
php-justinrainbow-json-schema4-4.1.0-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-908654fb39

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276



--- Comment #17 from Sachidananda Urs  ---
(In reply to tserlin from comment #14)
> This is un-official review of/comment on the package...
> 
> 
> Just to be clear, is this intended to be version 2.1 or 2.0.1? Just a quick
> glance, but I don't see any mention of 2.1 or a 2.1 branch on the upstream
> github.
> 
> The updated spec file is obviously for 2.0.1.
> 
> 
> I get:
> 
> ERROR: 'No srpm found for gdeploy' (logs in
> /home/thomas/.cache/fedora-review.log)
> 
> when I run `fedora-review  -m fedora-rawhide-x86_64 -n gdeploy` on the
> downloaded spec file and source RPM.

It is 2.0.1 and I will make the changes suggested by Ken and update the bug
with the details.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276



--- Comment #16 from Sachidananda Urs  ---
(In reply to Ken Dreyer from comment #15)
> Sac, would you please post raw direct links to the latest .spec and .src.rpm
> so that the fedora-review tool can process them? The previous link for the
> .spec was to GitHub's web UI, and fedora-review needs the raw file.

Ken, sure will do that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1176273



--- Comment #24 from Jeremy Newton  ---
Just from a quick glance. Source1 shouldn't be necessary, please remove it.

I have some additional comments, but I need to look into it further to give you
better feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398949] Review Request: bear - Game engine and editors dedicated to creating great 2D games

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398949

Jeremy Newton  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #29 from Jeremy Newton  ---
Looks good, but the one issue remains. You need to set DCMAKE_SKIP_RPATH to ON.
You need this ON to skip the build step that adds rpath to the binaries. The
use of chrpath can be avoided by turning this on.

Please fix this prior to importing the package.

Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1379798] Review Request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1379798

Jeremy Newton  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-11-28 11:53:20 |2016-12-22 23:37:08



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276



--- Comment #15 from Ken Dreyer  ---
Sac, would you please post raw direct links to the latest .spec and .src.rpm so
that the fedora-review tool can process them? The previous link for the .spec
was to GitHub's web UI, and fedora-review needs the raw file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258542



--- Comment #22 from Adam Williamson  ---
Debian is not inevitably 'freer' than Fedora. Our requirements are more strict
in some ways. Just because Debian doesn't (and, AFAICT, never has) required
fonts to be compiled from source doesn't mean we're wrong in requiring this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #26 from Fedora Update System  ---
libprelude-3.1.0-26.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ccc77adf2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398433] Review Request: granite - elementary GTK+ Development Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398433

Neal Gompa  changed:

   What|Removed |Added

 CC||domi...@greysector.net,
   ||ngomp...@gmail.com
  Flags||needinfo?(dominik@greysecto
   ||r.net)



--- Comment #9 from Neal Gompa  ---
@Rathann:

Are you still working on this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1344276] Review Request: gdeploy - Tool to deploy GlusterFS clusters and other utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1344276

tser...@redhat.com changed:

   What|Removed |Added

 CC||tser...@redhat.com



--- Comment #14 from tser...@redhat.com ---
This is un-official review of/comment on the package...


Just to be clear, is this intended to be version 2.1 or 2.0.1? Just a quick
glance, but I don't see any mention of 2.1 or a 2.1 branch on the upstream
github.

The updated spec file is obviously for 2.0.1.


I get:

ERROR: 'No srpm found for gdeploy' (logs in
/home/thomas/.cache/fedora-review.log)

when I run `fedora-review  -m fedora-rawhide-x86_64 -n gdeploy` on the
downloaded spec file and source RPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #15 from Jarod Wilson  ---
SRPM and spec updated, based on proposed patch and upstream review discussion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962



--- Comment #8 from Fedora Update System  ---
python-pathlib2-2.1.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a461353f4a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401961] Review Request: madplay - MPEG audio decoder and player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401961



--- Comment #13 from Fedora Update System  ---
madplay-0.15.2b-11.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pathlib2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404217] Review Request: php-pecl-dio - Direct I/O functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404217



--- Comment #15 from Fedora Update System  ---
php-pecl-dio-0.0.9-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962



--- Comment #6 from Paulo Andrade  ---
Many thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962



--- Comment #5 from Paulo Andrade  ---
  Submitted request about license issues at
https://github.com/mcmtroffaes/pathlib2/issues/14

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401582] Review Request: python-flufl-testing - Small collection of test tool plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401582

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-22 11:49:13



--- Comment #9 from Fedora Update System  ---
python-flufl-testing-0.4-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387518] Review Request: python-lazr-config - Create configuration schemas, and process and validate configurations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387518

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-22 11:49:15



--- Comment #10 from Fedora Update System  ---
python-lazr-config-2.1-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404217] Review Request: php-pecl-dio - Direct I/O functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404217

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-22 11:49:10



--- Comment #14 from Fedora Update System  ---
php-pecl-dio-0.0.9-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-12-22 11:49:04



--- Comment #18 from Fedora Update System  ---
flyingsaucersattack-1.20h-3.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] ansible-pacemaker - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728



--- Comment #5 from Javier Peña  ---
Initial licensecheck output:

$ licensecheck -r .
./setup.py: Apache (v2.0)
./modules/pacemaker_resource.py: Apache (v2.0)
./modules/pacemaker_cluster.py: Apache (v2.0)
./README.md: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache (v2.0) GENERATED FILE

The module is licensed using the Apache 2.0 license, and I see no apparent
issues in the git repo history.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774

Rex Dieter  changed:

   What|Removed |Added

  Flags|needinfo?(rdie...@math.unl. |
   |edu)|



--- Comment #7 from Rex Dieter  ---
Why?  -devel requires the main pkg already.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386774] Review Request: kf5-libktorrent - Library providing torrent downloading code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386774

Randy Barlow  changed:

   What|Removed |Added

  Flags|needinfo?(randy@electronswe |needinfo?(rdie...@math.unl.
   |atshop.com) |edu)



--- Comment #6 from Randy Barlow  ---
Hello Rex! I apologize for the delay. One more change - can you also add the
%license macro to the devel subpackage?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958



--- Comment #2 from Paulo Andrade  ---
Thanks for the initial review.

  Updated to 4.5.2.

  Corrected removal of not necessary files.

  As a note, %check will not work currently. This is a minimal
update, that would really also require updating ipython, but
is enough to have a functional sagemath 7.4 package, that will
at first be the unique package using it. I requested ipython
update at https://bugzilla.redhat.com/show_bug.cgi?id=1408250
  The package will work with sagemath 7.4 because sagemath
7.4, in my still WIP package, will bundle ipython 5.

Spec URL: https://pcpa.fedorapeople.org/python-ipykernel.spec
SRPM URL: https://pcpa.fedorapeople.org/python-ipykernel-4.5.2-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406946] Review Request: python-httpbin - HTTP Request & Response Service, written in Python + Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406946

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Neal Gompa  ---
Everything looks good to me now.

PACKAGE APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962



--- Comment #4 from gil cattaneo  ---
(In reply to Paulo Andrade from comment #3)
>   Many thanks for reviewing it!

Thanks for your work!

>   About the license, there is only one python source file, and 2
> test files. This a common practice of having a single LICENSE
> file (kind like having a single COPYING file), and there is a
> single author.

So upstream may easily fix the header License where are missing

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406831] Review Request: perl-Module-Install-DOAPChangeSets - Write your distribution change log in RDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406831

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Summary is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Module-Install-DOAPChangeSets-0.206-1.fc26.noarch.rpm
| sort | uniq -c
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(:VERSION) >= 5.8.0
  1 perl(File::Slurp)
  1 perl(LWP::Simple)
  1 perl(List::MoreUtils)
  1 perl(Module::Install::Base)
  1 perl(Perl::Version)
  1 perl(RDF::DOAP::ChangeSets)
  1 perl(RDF::Query) >= 2.906
  1 perl(RDF::Trine) >= 0.112
  1 perl(Text::Wrap)
  1 perl(URI::file) >= 4.0
  1 perl(parent)
  1 perl(strict)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Module-Install-DOAPChangeSets-0.206-1.fc26.noarch.rpm
| sort | uniq -c
  1 perl(Module::Install::Admin::DOAPChangeSets) = 0.206
  1 perl(Module::Install::DOAPChangeSets) = 0.206
  1 perl(RDF::DOAP::ChangeSets) = 0.206
  1 perl-Module-Install-DOAPChangeSets = 0.206-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Module-Install-DOAPChangeSets*
perl-Module-Install-DOAPChangeSets.noarch: W: spelling-error %description -l
en_US autogenerate -> auto generate, auto-generate, unregenerate
perl-Module-Install-DOAPChangeSets.src: W: spelling-error %description -l en_US
autogenerate -> auto generate, auto-generate, unregenerate
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

License
FIX: Please add license Public Domain (COPYRIGHT)

BuildRequires are almost ok
FIX: Please add 'coreutils' (spec file L54:rm -rf ./inc)

Please correct all 'FIX' issues.

Otherwise package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962



--- Comment #3 from Paulo Andrade  ---
  Many thanks for reviewing it!

  Added %check, and extra build requires to run %check.

  About the license, there is only one python source file, and 2
test files. This a common practice of having a single LICENSE
file (kind like having a single COPYING file), and there is a
single author.

  Also changed the URL field, as it was somewhat confusing; it
was pathlib page, not pathlib2.

Spec URL: https://pcpa.fedorapeople.org/python-pathlib2.spec
SRPM URL: https://pcpa.fedorapeople.org/python-pathlib2-2.1.0-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #14 from Honggang LI  ---
Created attachment 1234802
  --> https://bugzilla.redhat.com/attachment.cgi?id=1234802=edit
proposed patch against the SPEC file linked in comment #6.

proposed patch against the SPEC file linked in comment #6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1404043



--- Comment #13 from Honggang LI  ---
(In reply to Jarod Wilson from comment #6)
> http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core.spec
> http://people.redhat.com/~jwilson/pkgreview/rdma-core/rdma-core-12-1.fc26.
> src.rpm

Please consider attached patch "spec.patch". And please append valid changelog
to the spec file. Then please DO build the srpm in koji system and feedback the
task link. I had run fedora-review tool against local copy of updated spec and
srpm. The test result seems acceptable now.

SIMPLE functional test had been run mlx5 HCA.No plan to run the entire RDMA
regression test suite over all RDMA hardware.
1 libibverbs-utils PASSED
2 librdmacm-utils  PASSED
3 ibacmPASSED
4 SRP  PASSED
5 rempbuild (libfabric/fabtests/openmpi) PASSED
6 iwpmdNOT-TEST

thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401967] Review Request: qcad - Powerful 2D CAD system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401967



--- Comment #16 from Fedora Update System  ---
qcad-3.16.2.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-74b582dd78

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401967] Review Request: qcad - Powerful 2D CAD system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401967

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353224] Review Request: python-tackerclient - Client for OpenStack tacker project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353224

Dan Radez  changed:

   What|Removed |Added

 CC||dra...@redhat.com



--- Comment #9 from Dan Radez  ---
*** Bug 1406848 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401967] Review Request: qcad - Powerful 2D CAD system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401967



--- Comment #17 from Fedora Update System  ---
qcad-3.16.2.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4700215a37

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406807] Review Request: perl-RDF-Query - SPARQL 1.1 Query and Update implementation for RDF:: Trine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406807

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-RDF-Query-2.917-1.fc26
 Resolution|--- |RAWHIDE
Last Closed||2016-12-22 08:28:59



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406831] Review Request: perl-Module-Install-DOAPChangeSets - Write your distribution change log in RDF

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406831
Bug 1406831 depends on bug 1406807, which changed state.

Bug 1406807 Summary: Review Request: perl-RDF-Query - SPARQL 1.1 Query and 
Update implementation for RDF::Trine
https://bugzilla.redhat.com/show_bug.cgi?id=1406807

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406807] Review Request: perl-RDF-Query - SPARQL 1.1 Query and Update implementation for RDF:: Trine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406807



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-RDF-Query

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406807] Review Request: perl-RDF-Query - SPARQL 1.1 Query and Update implementation for RDF:: Trine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406807

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok (RDF-Query-2.917/lib/RDF/Query.pm)
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok

There are lots of requires and provides for the package. 
I don't list them here.

Binary requires are Ok.
Binary provides are Ok.
Permissions of files are ok.

$ rpmlint ./perl-RDF-Query*
perl-RDF-Query.noarch: W: spelling-error Summary(en_US) Trine -> Trina, Taine,
Urine
perl-RDF-Query.src: W: spelling-error Summary(en_US) Trine -> Trina, Taine,
Urine
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #3 from TR Bentley  ---
Looking at the packaging again I can see errors.
The inital question is the upstream package is called pysword and that is how
it is built.  Should I package it as pysword or python3-pysword.

To move to python3-pysword I would need to rebuild a copy of the upstream
packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] ansible-pacemaker - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728

Javier Peña  changed:

   What|Removed |Added

 CC||jp...@redhat.com
  Component|Package Review  |Package Review
Version|rawhide |trunk
Product|Fedora  |RDO



--- Comment #4 from Javier Peña  ---
This should be an RDO review rather than a Fedora one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406728] ansible-pacemaker - Ansible library for tripleo composable upgrade

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406728

Javier Peña  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|hgue...@redhat.com
 QA Contact|extras...@fedoraproject.org |hgue...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403554] Review Request: eigen2 - Obsolete version of the eigen vector and matrix math C++ template library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403554

Sandro Mani  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-12-22 05:58:06



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962



--- Comment #2 from gil cattaneo  ---
Issues:

[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 7 files have unknown license. Detailed
 output of licensecheck in /home/gil/1406962-python-
 pathlib2/licensecheck.txt

All source files are without license headers. Please, ask to upstream to
confirm the licensing of code and/or content/s, and add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[!]: %check is present and all tests pass.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 7 files have unknown license. Detailed
 output of licensecheck in /home/gil/1406962-python-
 pathlib2/licensecheck.txt

All source files are without license headers. Please, ask to upstream to
confirm the licensing of code and/or content/s, and add license headers
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification

[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[?]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-pathlib2 , python3-pathlib2
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: 

[Bug 1406958] Review Request: python-ipykernel - IPython Kernel for Jupyter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406958

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #1 from gil cattaneo  ---
Is available a new release 4.5.2
https://github.com/ipython/ipykernel/tags
Please, consider upgrading

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1406962] Review Request: python-pathlib2 - Object-oriented filesystem paths

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1406962

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org