[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #5 from Per Bothner  ---
No, I don't have a sponsor.  Thanks,

I have a few additional changes I've been working on, some of relate to
packaging:

* It would be helpful to update the libwebsockets package (to version 2.2),
though some more testing (relating to domterm) is desirable.  Once that is
done, I can remove a bunch of crud from the source code.

* I want domterm to install a 'dt-util' script, which does useful things when
running under DomTerm.  The script is written, so it mainly a matter of
updating the documentation, plus a binary spec file change (to install the
script itself and perhaps a stub man page),

* I'm thinking of including some documentation (in html form) that can be
loaded by a hotkey.  BUt that can wait.

* I'm working on an integrated pager (a la less).  It's promising, but not
quite there yet.  A lot of it is working out the UI.

On the other hand, I can always release a package, and update it as I improve
it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397692] Review Request: gnome-shell-extension-activities-configurator - Configure the top bar and Activities button in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397692

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
(Note: the spec file is now inaccessible, it says "deploy in progress".
Fortunately I had it open is a tab.)

Without further ado,
+ package name is OK
+ license is acceptable (GPLv2)
+ license is specified correctly
+ builds and installs OK
+ latest version
+ Provides/Requires/BuildRequires look correct
+ scriptlets are OK

rpmlint:
gnome-shell-extension-activities-configurator.src:67: W:
mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 67)

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1252130] Review Request: gnome-shell-extension-drop-down-terminal - Drop Down Terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1252130



--- Comment #9 from Andrew Toskin  ---
...Looks up stream is on version 23. So if you want to resume working on this
package, we'll need an updated spec and SRPM before we get started with a
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #4 from Andrew Toskin  ---
@bothner
Do you have a sponsor yet? I can't sponsor you, but DomTerm seems interesting,
so I could certainly help with the basic review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Ah, I set the fedora-review+ flag, but forgot to update other metadata. The
review stands, please builds the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1343710] Review Request: chrome-gnome-shell - Support for managing GNOME Shell Extensions through web browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1343710



--- Comment #39 from Jeremy Newton  ---
(In reply to Yuri Konotopov from comment #38)
> Pete,
> 
> Native host manifest location is well documented by Mozilla [1] and "lib" is
> arch-independent. It should be properly placed to /usr/share (and this
> location was documented early), but this is not work now - there is a bug in
> Mozilla's bugtracker [2].
> 
> > Right now upstream install scripts put the mozilla files in /usr/lib64
> 
> Those files are placed to platform provide libdir because of Mozilla's bug
> 1318461. I will change location to /usr/share as soon as this bug will be
> resolved.
> If distro rules allow to use "lib" as platform independent directory - I
> recommend to use it.
> 
> [1]
> https://developer.mozilla.org/en-US/Add-ons/WebExtensions/
> Native_messaging#Linux
> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1318461

In my honest opinion, lib should be fine as an interim solution until this is
resolved.

(In reply to Pete Walter from comment #37)
> Are there any blockers left I need to address?
> 
> I'm happy to change it to noarch if that's the upstream guidance, but at the
> same time I don't think there's anything wrong if it's archful either. Right
> now upstream install scripts put the mozilla files in /usr/lib64 and I would
> like to avoid adding downstream hacks to move this to a different location.

I would think a noarch would be the "more correct" solution, as it's just for
the interim, and isn't "%{_lib}" always /usr/lib for noarch builds? I maybe
wrong, but both upstream should resolve it themselves and I would think this
would be the lowest maintenance solution for you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
ampy-1.0.1-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3171bdb23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
onboard-1.4.1-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a8ac7ff05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4f8c3ca6b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
go-i18n-1.7.0-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ec7e584128

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Bug 1431763 depends on bug 1431759, which changed state.

Bug 1431759 Summary: Review Request: golang-github-oschwald-maxminddb-golang - 
MaxMind DB Reader for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431759

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431759] Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431759

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #8 from Fedora Update System  ---
golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc26 has been pushed
to the Fedora 26 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1aa2aac9ed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429232] Review Request: systemd-coredump-python - systemd-coredump helper to log Python exceptions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429232

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
systemd-coredump-python-2-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b2050abe09

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432104] Review Request: rsync-bpc - A customized version of rsync that is used as part of BackupPC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432104



--- Comment #9 from Richard Shaw  ---
Already got a response, currently no plans to adapt the tests to work...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394923] Review Request: golang-github-fortytw2-leaktest - Goroutine Leak Detector

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394923



--- Comment #1 from Athos Ribeiro  ---
New sources with some improvements

Spec
URL:https://athoscr.fedorapeople.org/packaging/golang-github-fortytw2-leaktest.spec
SRPM
URLhttps://athoscr.fedorapeople.org/packaging/golang-github-fortytw2-leaktest-0-0.2.git0db74e8.fc25.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18404984

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432104] Review Request: rsync-bpc - A customized version of rsync that is used as part of BackupPC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432104



--- Comment #8 from Richard Shaw  ---
Ok, emailed backuppc-devel (more appropriate for that list) and I'll report any
response.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #44 from Mukundan Ragavan  ---
I have added you to packagers.

Please add me as a co-maintainer for this package so that I can help you with
anything that is necessary.

Welcome!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #43 from Mukundan Ragavan  ---
(In reply to Joël Krähemann from comment #41)
> Hi
> 
> I'm going to pick some packages and do the unofficial reviews.
> So far I did it for my own package as you see above.
> 
> Note there is a new upstream package available 0.7.122.7 fixing some serious
> memory problems. I have implement for many objects GObject::dispose() for
> more information see changelog.
> 
> Bests,
> Joël

Please do keep yourself updated with the packaging guidelines. I am going to
sponsor you even though you have not done package reviews. I am willing to
direct you to appropriate resources as you continue package this (and other)
packages.

Feel free to contact me with any questions you might have regarding Fedora
packaging, updates procedure, etc.


I will add you the packager group now. Please wait for about 1 hour before you
request your package on pkgdb.

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

Welcome to packagers!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #9 from Fedora Update System  ---
go-i18n-1.7.0-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ec7e584128

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/go-i18n

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #42 from Joël Krähemann  ---
Hi

here is the new SRPM some patches were removed. Further xvfb-run is a new build
dependency in order to run `make check`.

Spec URL: http://gsequencer.org/fedora/rpmbuild/SPECS/gsequencer.spec
SRPM URL:
http://gsequencer.org/fedora/rpmbuild/SRPMS/gsequencer-0.7.122.7-0.fc25.src.rpm

Bests,
Joël

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #13 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.el7 has been submitted as an
update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-626ff244d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #12 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d20426f634

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431587] Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go' s rand and math packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431587



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-cznic-mathutil

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #11 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7bfb5f6f7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #10 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.fc26 has been submitted as an
update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c4f8c3ca6b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Piotr Popieluch  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



--- Comment #7 from Piotr Popieluch  ---
looks good besides the two point mentioned before, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #6 from Piotr Popieluch  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 11 files have
 unknown license. Detailed output of licensecheck in /home/piotr
 /fedora-scm/1424860-nodejs-finalhandler/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[!]: Spec file according to URL is the same as in SRPM.
 Note: Spec file as given by url is not the same as in SRPM (see
 attached diff).
 See: (this test has no URL)
[x]: Rpmlint is 

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860

Piotr Popieluch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #5 from Piotr Popieluch  ---
[!]: Spec file according to URL is the same as in SRPM.
 Note: Spec file as given by url is not the same as in SRPM (see
 attached diff).
 See: (this test has no URL)


Github source URL does not match the guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Tags

Source0:https://github.com/pillarjs/finalhandler/archive/v%{version}.tar.gz

should be:

Source0: 
https://github.com/pillarjs/finalhandler/archive/v%{version}/%{npm_name}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #41 from Joël Krähemann  ---
Hi

I'm going to pick some packages and do the unofficial reviews.
So far I did it for my own package as you see above.

Note there is a new upstream package available 0.7.122.7 fixing some serious
memory problems. I have implement for many objects GObject::dispose() for more
information see changelog.

Bests,
Joël

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432104] Review Request: rsync-bpc - A customized version of rsync that is used as part of BackupPC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432104



--- Comment #7 from Benjamin Lefoul  ---
(In reply to Richard Shaw from comment #6)
> (In reply to Benjamin Lefoul from comment #5)
> > 
> > rsync-bpc.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/rsync_bpc
> > This is often a false positive, any comment?
> 
> I'm not really sure but I ran rpmlint on the rsync package and it gets the
> same error so I assume if it's actually a problem then once it's fixed in
> the rsync package it can be fixed here.

Fair enough.

> 
> 
> > [!]: %check is present and all tests pass.
> 
> I tried running "make check" but it fails, I don't think Craig updated the
> test to work with his fork.

OK. This is not not a MUST item, but it would be nice to know if the fork
breaks the tests.
If you want to ask him, can you CC the ML (I'm reading
backuppc-us...@lists.sourceforge.net)?

Apart from that this is good for approval.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230



--- Comment #5 from Fedora Update System  ---
ampy-1.0.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8cca426ffb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427341] Review Request: python-gamera - Gamera is a framework for building document analysis applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427341



--- Comment #17 from VincentS  ---
(In reply to Miro Hrončok from comment #16)
> First, /usr/lib64/python2.7/site-packages/gamera/gendoc.py:
> 
> This is a bit more complicated.
> 
> Based on the rpmlint output you can say that:
> 
>  * the file has a shebang that says "#!/usr/bin/env python" (note that using
> /usr/bin/env in shebangs is forbidden in Fedora packages)
>  * the file does not have executable permissions
> 
> So you have to ask yourself the question: "Shall this file be treated as
> executable or not?" The answer is usually "not" unless the file is in PATH
> (such as /usr/bin). So in this case instead of giving it permissions, remove
> the shebang. This is nice approach, as it checks if the shebang is there and
> if so, it removes it:
> 
> head -n 1 gamera/gendoc.py | grep '#!/usr/' && sed -i '1d'
> gamera/gendoc.py
> 
> If the file should have been an executable (not this case), you would need
> to change the shebang to "#!/usr/bin/python2" and add the executable
> permission.
> 
> Second: README:
> 
> I'd suggest running "chmod -x README" in %prep instead, as it explicitly
> says "remove the executable permission" rather than "set the permissions to
> exactly this and that".

Ok, all right.

Now I'll know for future through your really good explanations.

I fixed this according to your recommendations.

Here are new SPEC and SRPM:
Spec URL: https://dl.casperlefantom.net/pub/review/python-gamera.spec
SRPM URL:
https://dl.casperlefantom.net/pub/review/python-gamera-3.4.3-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230



--- Comment #4 from Fedora Update System  ---
ampy-1.0.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3171bdb23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #7 from Athos Ribeiro  ---
Thank you, Fabio. I will change the typo!

I requested the package repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426961] Review Request: nodejs-bufferutil - WebSocket buffer utils

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426961



--- Comment #9 from Fedora Update System  ---
nodejs-bufferutil-3.0.0-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-caef265c8c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1245958] Review Request: golang-github-coreos-pkg - A collection of go utility packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245958



--- Comment #55 from Fedora Update System  ---
golang-github-coreos-pkg-0-0.12.git3ac0863.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-80acf92bca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428565] Review Request: golang-github-sasha-s-go-deadlock - Online deadlock detection in go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428565

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
golang-github-sasha-s-go-deadlock-0.1.0-0.1.git3410008.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a0cc367bcc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431867] Review Request: golang-github-zillode-notify - File system event notification library on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431867



--- Comment #9 from Fedora Update System  ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-31df863b76

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411502] Review Request: flr - Fedora RelEng python libraries and command line tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411502

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
flr-0.0.3-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-af2cdfa185

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426961] Review Request: nodejs-bufferutil - WebSocket buffer utils

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426961



--- Comment #8 from Fedora Update System  ---
nodejs-bufferutil-3.0.0-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc1de66471

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431867] Review Request: golang-github-zillode-notify - File system event notification library on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431867

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #8 from Fedora Update System  ---
golang-github-zillode-notify-0-0.1.gitc2582a9.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e9dc5bf5ff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1245958] Review Request: golang-github-coreos-pkg - A collection of go utility packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245958



--- Comment #54 from Fedora Update System  ---
golang-github-coreos-pkg-0-0.12.git3ac0863.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b15b87e532

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431868
Bug 1431868 depends on bug 1431867, which changed state.

Bug 1431867 Summary: Review Request: golang-github-zillode-notify - File system 
event notification library on steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Fabio Valentini  ---
Looks very good now! Package approved.

PS: There's a typo in line 12 (s/loacles/locales) - just fix it before
committing the .spec in git.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1246524] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library for Go using FFT

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246524

Fabio Valentini  changed:

   What|Removed |Added

 Blocks||1431587




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1431587
[Bug 1431587] Review Request: golang-github-cznic-mathutil - Supplemental
utilities for Go's rand and math packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431587] Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go' s rand and math packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431587

Fabio Valentini  changed:

   What|Removed |Added

 Depends On||1246524



--- Comment #7 from Fabio Valentini  ---
Thanks for the review!

You submitted a review request for the "bigfft" package 2 years ago [1], are
you still interested in moving forward with it (I can do the review), or should
I submit a new one (with new sources and up-to-date spec), and mark yours as a
duplicate?

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1246524


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1246524
[Bug 1246524] Review Request: golang-github-remyoudompheng-bigfft - Big
integer multiplication library for Go using FFT
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422555] Review Request: arduino-ctags - A mix of ctags and anjuta-tags for the perfect C++ ctags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422555



--- Comment #13 from Randy Barlow  ---
Nevermind my comment about the .build-id folder. I learned on the php-devel
list that it's apparently being placed there by the rpm build system and not by
your spec file:

https://lists.fedoraproject.org/archives/list/php-de...@lists.fedoraproject.org/thread/JET6TZJOAP4XXIBGQ7ICLTKNRYLKGOY7/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #11 from Athos Ribeiro  ---
Hello Olivier,

The file

/usr/share/doc/golang-github-yosssi-ace-devel/examples/load_templates_from_binary_data/make_asset.sh

Is an executable file. It is pulling a /bin/sh dependency (Requires) to the
-devel package.

Removing the executable permissions from it will probably stop it from pulling
the dependency [1] (in case it does not, remove the shebang from the file as
well).

Other than that, the package looks good!

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1245958] Review Request: golang-github-coreos-pkg - A collection of go utility packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245958



--- Comment #53 from Fedora Update System  ---
golang-github-coreos-pkg-0-0.12.git3ac0863.el7 has been pushed to the Fedora
EPEL 7 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1510ffc19b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1245958] Review Request: golang-github-coreos-pkg - A collection of go utility packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245958



--- Comment #52 from Fedora Update System  ---
golang-github-coreos-pkg-0-0.12.git3ac0863.el6 has been pushed to the Fedora
EPEL 6 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-72814742dd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1262351] Review Request: golang-github-xiang90-probing - Golang project for probing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262351

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #16 from Fedora Update System  ---
golang-github-xiang90-probing-0-0.6.git07dd2e8.el6 has been pushed to the
Fedora EPEL 6 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f466ec7dd2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410594] Review Request: beaker - Full-stack software and hardware integration testing system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410594

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-15 14:22:19



--- Comment #19 from Fedora Update System  ---
beaker-24.1-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428287] Review Request: cldr-emoji-annotation - Emoji annotation files in CLDR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428287

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-15 14:22:38



--- Comment #9 from Fedora Update System  ---
cldr-emoji-annotation-30.0.3_2-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332306] Review Request: libcxxabi - Low level support for a standard C++ library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332306



--- Comment #29 from Fedora Update System  ---
libcxx-3.8.1-3.fc25, libcxxabi-3.8.1-2.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418804] Review Request: gcovr - A code coverage report generator using GNU gcov

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418804

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-15 14:21:33



--- Comment #9 from Fedora Update System  ---
gcovr-3.3-4.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Athos Ribeiro  changed:

   What|Removed |Added

Summary|Review Request: |Review Request: go-i18n -
   |golang-github-nicksnyder-go |Translate Go programs into
   |-i18n - Translate Go|multiple languages
   |programs into multiple  |
   |languages   |



--- Comment #5 from Athos Ribeiro  ---
Hello Fabio,

Thank you for the nice review!

1) Done.

2) Upstream names the project go-i18n, but names the main binary goi18n. I will
follow the guidelines, naming the package after upstream (go-i18n).

3) Done.

4) Done.

5) Done.

6) Done.

7) Done.

8) The codegen subpackage aims the generations of source code for new locales.
I do believe this should not be shipped, but sources are shipped within the
devel subpackage. I decided to keep the comments on the binary so if anyone
ever feels that The binary should be shipped, all we'd need to do is remove the
comments. I just added a new macro to build with codegen (deactivated) and some
comments on it.

Spec URL: https://athoscr.fedorapeople.org/packaging/go-i18n.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/go-i18n-1.7.0-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1418428] Review Request: python-retryz - Retry decorator python lib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1418428

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-15 14:21:38



--- Comment #6 from Fedora Update System  ---
python-retryz-0.1.8-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428535] Review Request: golang-github-petermattis-goid - Programmatic retrieval of goroutine IDs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428535



--- Comment #8 from Fedora Update System  ---
golang-github-petermattis-goid-0-0.1.gitcaab644.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428558] Review Request: golang-github-minio-sha256-simd - SHA256 implementation using SIMD instructions for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428558



--- Comment #8 from Fedora Update System  ---
golang-github-minio-sha256-simd-0-0.1.gite82e73b.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428539] Review Request: golang-github-jackpal-gateway - Discovering the address of a LAN gateway in go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428539



--- Comment #8 from Fedora Update System  ---
golang-github-jackpal-gateway-1.0.4-0.1.git5795ac8.fc24 has been pushed to the
Fedora 24 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428429] Review Request: golang-github-AudriusButkevicius-go-nat-pmp - Go language client for the NAT-PMP protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428429



--- Comment #8 from Fedora Update System  ---
golang-github-AudriusButkevicius-go-nat-pmp-0-0.1.git452c976.fc24 has been
pushed to the Fedora 24 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428562] Review Request: golang-github-d4l3k-messagediff - Generate diffs of arbitrary structs in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428562



--- Comment #9 from Fedora Update System  ---
golang-github-d4l3k-messagediff-1.1.0-0.1.git2fe2a1d.fc24 has been pushed to
the Fedora 24 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428528] Review Request: golang-github-gobwas-glob - Globbing library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428528



--- Comment #9 from Fedora Update System  ---
golang-github-gobwas-glob-0.2.2-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428526] Review Request: golang-github-chmduquesne-rollinghash - Some rolling checksum implementations in go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428526



--- Comment #9 from Fedora Update System  ---
golang-github-chmduquesne-rollinghash-2.0.2-0.1.git56b51d0.fc24 has been pushed
to the Fedora 24 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428517] Review Request: golang-github-calmh-luhn - Luhn-mod-N implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428517



--- Comment #9 from Fedora Update System  ---
golang-github-calmh-luhn-1.0.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428521] Review Request: golang-github-calmh-xdr - XDR enc/ decoder for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428521



--- Comment #10 from Fedora Update System  ---
golang-github-calmh-xdr-2.0.0-0.1.git08e072f.fc24 has been pushed to the Fedora
24 stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428513] Review Request: golang-github-calmh-du - Disk Usage Information library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428513



--- Comment #9 from Fedora Update System  ---
golang-github-calmh-du-1.0.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415389] Review Request: php-phpmyadmin-shapefile - ESRI ShapeFile library for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415389



--- Comment #15 from Fedora Update System  ---
php-phpmyadmin-shapefile-2.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1415390] Review Request: php-phpmyadmin-motranslator - Translation API for PHP using Gettext MO files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1415390



--- Comment #15 from Fedora Update System  ---
php-phpmyadmin-motranslator-3.0-1.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425934] Review Request: python-mtg - Console-based access to the Gatherer Magic Card Database

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425934

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-15 13:51:57



--- Comment #12 from Fedora Update System  ---
python-mtg-1.6.1-2.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1304467] Review Request: python-aodhclient - Python client for Aodh

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304467

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-15 13:51:52



--- Comment #16 from Fedora Update System  ---
python-aodhclient-0.5.0-2.fc24 has been pushed to the Fedora 24 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1332306] Review Request: libcxxabi - Low level support for a standard C++ library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332306

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-15 13:52:00



--- Comment #28 from Fedora Update System  ---
libcxx-3.8.0-6.fc24, libcxxabi-3.8.0-3.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322



--- Comment #11 from Fedora Update System  ---
onboard-1.4.1-4.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c5a8ddf300

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322



--- Comment #10 from Fedora Update System  ---
onboard-1.4.1-4.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e075b2a9c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322



--- Comment #9 from Fedora Update System  ---
onboard-1.4.1-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a8ac7ff05

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1245958] Review Request: golang-github-coreos-pkg - A collection of go utility packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1245958

Lokesh Mandvekar  changed:

   What|Removed |Added

 CC|l...@redhat.com |
   Assignee|l...@redhat.com |jchal...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1179350] Review Request: python-pytest-beakerlib - A pytest plugin that reports test results to the BeakerLib framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1179350



--- Comment #11 from Miro Hrončok  ---
> %if 0%{?with_python3}
> BuildRequires:  rpm-python3
> %endif

Does it not need rpm-python for Python 2?

You can define %license on platforms without it on the top instead of if/else
do %license/%doc.

%{!?_licensedir:%global license %%doc}


From my Fedora POV, I'd rather see the %py3_install macros etc., but I see why
that's not possible. Otherwise this looks good from the first glance, will do a
mock build on rawhide and epels and a formal review tmrw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322



--- Comment #8 from Nemanja Milosevic  ---
Hopefully everything is fixed now! :)

https://copr.fedorainfracloud.org/coprs/nmilosev/onboard/build/527299/

https://pagure.io/onboard-rpm/raw/master/f/onboard.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/ampy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1179350] Review Request: python-pytest-beakerlib - A pytest plugin that reports test results to the BeakerLib framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1179350



--- Comment #10 from Iryna Shcherbina  ---
I believe that Petr told me that it is supposed to be supported, but it was a
month ago, so I might be wrong. Petr?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432068] Review Request: perl-Proc-InvokeEditor - Perl extension for starting a text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432068



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Proc-InvokeEditor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431587] Review Request: golang-github-cznic-mathutil - Supplemental utilities for Go' s rand and math packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431587

Jan Chaloupka  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1179350] Review Request: python-pytest-beakerlib - A pytest plugin that reports test results to the BeakerLib framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1179350



--- Comment #9 from Miro Hrončok  ---
Is EPEL5 supposed to be supported?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431729] Review Request: perl-Class-Refresh - Refresh your classes during run time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431729

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Class-Refresh-0.07-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(B)
  1 perl(Carp)
  1 perl(Class::Load)
  1 perl(Class::Unload)
  1 perl(Devel::OverrideGlobalRequire)
  1 perl(Try::Tiny)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Class-Refresh-0.07-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(Class::Refresh) = 0.07
  1 perl-Class-Refresh = 0.07-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Class-Refresh*
perl-Class-Refresh.noarch: W: spelling-error %description -l en_US stateful ->
tasteful, wasteful, fateful
perl-Class-Refresh.src: W: spelling-error %description -l en_US stateful ->
tasteful, wasteful, fateful
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

BuildRequires are ok
TODO: To run all optional tests please add build-requires
  - perl(Test::Moose) - t/moose-metaclasses.t:5

Please consider fixing 'TODO' item.

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/php-paragonie-constant-time-encoding

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431867] Review Request: golang-github-zillode-notify - File system event notification library on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431867

Fabio Valentini  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-03-15 12:13:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1179350] Review Request: python-pytest-beakerlib - A pytest plugin that reports test results to the BeakerLib framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1179350

Miro Hrončok  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mhron...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230



--- Comment #2 from Miro Hrončok  ---
Thank you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431868] Review Request: syncthing-inotify - Syncthing File watcher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431868
Bug 1431868 depends on bug 1431867, which changed state.

Bug 1431867 Summary: Review Request: golang-github-zillode-notify - File system 
event notification library on steroids
https://bugzilla.redhat.com/show_bug.cgi?id=1431867

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763
Bug 1431763 depends on bug 1431759, which changed state.

Bug 1431759 Summary: Review Request: golang-github-oschwald-maxminddb-golang - 
MaxMind DB Reader for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1431759

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431759] Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431759

Fabio Valentini  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-03-15 12:13:06



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=505154

Orion Poplawski  changed:

   What|Removed |Added

 Depends On||1424482




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1424482
[Bug 1424482] Review Request: sge - Son of Grid Engine - Distributed
Computing Management software
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424482] Review Request: sge - Son of Grid Engine - Distributed Computing Management software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424482

Orion Poplawski  changed:

   What|Removed |Added

 Blocks||505154 (FE-SCITECH)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431729] Review Request: perl-Class-Refresh - Refresh your classes during run time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431729

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432068] Review Request: perl-Proc-InvokeEditor - Perl extension for starting a text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432068

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jitka Plesnikova  ---
> Couldn't find an editor: No such file or directory at
> /builddir/build/BUILD/Proc-InvokeEditor-1.07/blib/lib/Proc/InvokeEditor.pm
> line 178.
> # Looks like your test exited with 2 just after 6.
> t/02_editor.t 
> Dubious, test returned 2 (wstat 512, 0x200)
> Failed 2/8 subtests
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness"
"-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')"
t/*.t
t/01_require.t ... ok
t/02_editor.t  ok
t/03_pod.t ... ok
t/04_pod_coverage.t .. ok
All tests successful.
Ok.

> FIX: Add at least one of default editors (vi, ed) to build-requires and
>  also to run-requires.
 # Tests:
+# ed || vi must be installed to pass tests
+BuildRequires:  ed

BuildRequires are ok

$ rpm -qp --requires perl-Proc-InvokeEditor-1.07-1.fc27.noarch.rpm | sort |
uniq -c
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(Carp::Assert) >= 0.11
  1 perl(Exporter)
  1 perl(Fcntl)
  1 perl(File::Spec) >= 0.82
  1 perl(File::Temp) >= 0.12
  1 perl(IPC::Cmd)
  1 perl(strict)
  1 perl(vars)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Proc-InvokeEditor-1.07-1.fc27.noarch.rpm | sort |
uniq -c
  1 perl(Proc::InvokeEditor) = 1.07
  1 perl-Proc-InvokeEditor = 1.07-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Proc-InvokeEditor*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org