[Bug 1424890] Review Request: domterm - terminal emulator based on web technologies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #6 from Andrew Toskin  ---
(In reply to Per Bothner from comment #5)
> No, I don't have a sponsor.

Okay. If you haven't already, you'd probably want to post on the "devel"
mailing list asking for a sponsor.

 
https://lists.fedoraproject.org/archives/list/devel%40lists.fedoraproject.org/

If you *have* asked already and didn't get a response within a few days, you
can just bump the email thread. It's a busy mail list, so you have potentially
many readers, but also many other messages to compete against. So if no one
notices, just post again :)

Include a description of your package, DomTerm, and a link back to this
Bugzilla thread.


> * It would be helpful to update the libwebsockets package (to version 2.2),

Looks like updates are in the works. This thread is full of automated messages
about detecting and trying to build for 2.2, then falling back to 2.1.1.

  https://bugzilla.redhat.com/show_bug.cgi?id=1422477

If that thread closes with only a 2.1.1 build, you could manually open a ticket
about updating to 2.2.x.


> * I want domterm to install a 'dt-util' script, which does useful things
> when running under DomTerm.

Hmm, that may or may not be something you'd want or need to put in a
subpackage. I haven't needed to do anything like that yet, so I'm not sure. The
Fedora RPM Guide talks only a little about subpackages...

 
https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/RPM_Guide/ch10s04.html

And there's not much in the Wiki about when to use a subpackage or not, so this
might be something to ask your future sponsor.


> * I'm thinking of including some documentation (in html form) that can be
> loaded by a hotkey.  BUt that can wait.

You've been writing your docs in Troff format so far. Especially if you're
planning on also doing HTML or other formats, you might like the idea of
writing the documentation in Markdown, or another more readable markup
language, and then converting to whatever other formats with tools like pandoc
or cmark, or other document converters.

Just a thought. I personally would to maintain a nontrivial document in Troff.


> On the other hand, I can always release a package, and update it as I
> improve it.

True :) If DomTerm is usable now, then I don't think there's much point in
waiting to package it. I mean, the timing is up to you. But you'll surely get
more and better feedback when it's easier to install the application.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433121] Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433121



--- Comment #5 from Dusty Mabe  ---
(In reply to Athos Ribeiro from comment #4)
>
> Take the ticket before you perform the review :(
> Else, it's one review down to the project

Yep, that was my fault. I was shocked someone took it that quick. You are fast
:)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433121] Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433121



--- Comment #4 from Athos Ribeiro  ---
(In reply to Dusty Mabe from comment #3)
> jchaloup - :) i ran through and did the whole review before I realized
> someone else had done it :(. Sometimes you just have one of those days.

Take the ticket before you perform the review :(
Else, it's one review down to the project

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390477



--- Comment #9 from Andrew Toskin  ---
At some point I think I missed one of the notifications for this thread, so I
was a little confused about being added to the packagers group before all my
package reviews were done. But I think I'm all caught up now. Thanks, Zbigniew.
I'll find another reviewer for my other pending packages.

Am I missing anything else I need to do for this package, or is the rest of the
process automated from here? I've been checking PkgDB and Koji:

*
https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-do-not-disturb-button/
* https://koji.fedoraproject.org/koji/packageinfo?packageID=23928

Seems to me like everything should be done, but there haven't been the usual
automated messages about adding the package to Fedora 24 - 27, and the package
doesn't show up in a `dnf search`.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #29 from Fedora Update System  ---
ipython-5.3.0-3.fc26, python-ipykernel-4.5.2-6.fc26,
python-notebook-4.4.1-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
python-leather-0.3.3-2.gite85dd30.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ceb5bfa9b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
go-i18n-1.7.0-5.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8dc79a021

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887



--- Comment #8 from Fedora Update System  ---
golang-github-remyoudompheng-bigfft-0-0.1.gita8e77dd.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e104a2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433121] Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433121

Dusty Mabe  changed:

   What|Removed |Added

 CC||dustym...@redhat.com



--- Comment #3 from Dusty Mabe  ---
jchaloup - :) i ran through and did the whole review before I realized someone
else had done it :(. Sometimes you just have one of those days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1272174] Review Request: golang-github-pmezard-go-difflib - Partial port of Python difflib package to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272174

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
golang-github-pmezard-go-difflib-0-0.6.gitd8ed262.el6 has been pushed to the
Fedora EPEL 6 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1ecdc2a1bc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417



--- Comment #46 from Mukundan Ragavan  ---
(In reply to Joël Krähemann from comment #45)
> I have just requested the package. I have found some useful documentation in
> the fedora wiki. And for sure you are added as a co-maintainer.

I see that the package is approved. Go ahead and build it for rawhide. Test and
make sure everything works.

You can also do a scratch build for other fedora releases using koji.

For example, to test fedora 25,

koji build f25 --scratch 

You can then use this package to test everything works as expected and submit
an update.

Please let me know (you can email me if not in this bug report) if there are
questions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1322662] Review Request: cvs2svn - CVS to SVN/GIT/ BZR repository converter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1322662



--- Comment #5 from Stuart D Gathman  ---
Thanks.  Looks like it might be simple to fix the two nits.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1410953] Review Request: python3-cffi - Foreign Function Interface for Python to call C code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1410953



--- Comment #18 from Fedora Update System  ---
python3-cffi-1.9.1-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391216] Review Request: python3-pygments - Syntax highlighting engine written in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391216

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-16 20:18:52



--- Comment #12 from Fedora Update System  ---
python3-pygments-2.2.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1219662] Review Request: python-terminado - Terminals served to term.js using Tornado websockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1219662



--- Comment #28 from Fedora Update System  ---
python-terminado-0.6-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391254] Review Request: python3-docutils - System for processing plaintext documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391254

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-16 20:18:47



--- Comment #13 from Fedora Update System  ---
python3-docutils-0.12-0.8.20140510svn7747.el7 has been pushed to the Fedora
EPEL 7 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427017] Review Request: php-psr-container - Common Container Interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427017



--- Comment #15 from Fedora Update System  ---
php-psr-container-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391254] Review Request: python3-docutils - System for processing plaintext documentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391254



--- Comment #14 from Fedora Update System  ---
python3-docutils-0.12-0.8.20140510svn7747.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979



--- Comment #28 from Fedora Update System  ---
python-notebook-4.4.1-2.fc26 ipython-5.3.0-2.fc26 python-ipykernel-4.5.2-6.fc26
has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0e5cf9525f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327979] Review Request: python-notebook - A web-based notebook environment for interactive computing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327979

Miro Hrončok  changed:

   What|Removed |Added

   Fixed In Version||python-notebook-4.4.1-2.fc2
   ||7



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433121] Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433121



--- Comment #2 from Jan Chaloupka  ---
> Is there any special reason for not running the tests?

They were failing for me due to a broken dependency. It needs to be fixed by
either fixing the dependency or updating this package to a newer one. This
package will get eventually updated and the test gets fixed.

> The content of the examples is only used by the test cases. It is not a test
case itself, but shouldn't it be moved to the unit-test subpackage AND to %doc
on the -devel package?

I will move the code there once the tests are running properly.

> Upstream provides versions (v1.1 tag is available on the same commit 
> packaged).
You should update the Version and Release tags accordingly [1]. Refer to [2] 
if you need to package post 1.1 commits.

Good point. The current spec generator does not care about the version as it is
hard to retrieve it from the github. I will update the spec file.

Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432230] Review Request: ampy - Command line tool to interact with a MicroPython board over a serial connection

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432230



--- Comment #7 from Fedora Update System  ---
ampy-1.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8cca426ffb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
golang-github-remyoudompheng-bigfft-0-0.1.gita8e77dd.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-218bd43c5f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322



--- Comment #13 from Fedora Update System  ---
onboard-1.4.1-4.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c5a8ddf300

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887



--- Comment #7 from Fedora Update System  ---
golang-github-remyoudompheng-bigfft-0-0.1.gita8e77dd.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cef856b9f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #16 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d20426f634

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431322] Review Request: Onboard - On screen keyboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431322



--- Comment #14 from Fedora Update System  ---
onboard-1.4.1-4.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9e075b2a9c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #17 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7bfb5f6f7f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422714] Review Request: yank - tool for yanking (copying) stdin to clipboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422714

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #16 from Fedora Update System  ---
yank-0.8.2-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9679fa4df4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392090] Review Request: pychromecast - Python library to communicate with the Google Chromecast

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392090
Bug 1392090 depends on bug 1401337, which changed state.

Bug 1401337 Summary: Review Request: python-zeroconf - Pure Python Multicast 
DNS Service Discovery Library
https://bugzilla.redhat.com/show_bug.cgi?id=1401337

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431759] Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431759



--- Comment #10 from Fedora Update System  ---
golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc25 has been pushed
to the Fedora 25 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5f9006e5bc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401337] Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401337

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---



--- Comment #12 from Fedora Update System  ---
python-zeroconf-0.18.0-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7ea7818e6e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431759] Review Request: golang-github-oschwald-maxminddb-golang - MaxMind DB Reader for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431759



--- Comment #9 from Fedora Update System  ---
golang-github-oschwald-maxminddb-golang-1.1.0-1.git697da80.fc24 has been pushed
to the Fedora 24 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6529cf5bae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431766] Review Request: php-paragonie-constant-time-encoding - Constant-Time Character Encoding in PHP Projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431766



--- Comment #15 from Fedora Update System  ---
php-paragonie-constant-time-encoding-1.0.1-4.el7 has been pushed to the Fedora
EPEL 7 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-626ff244d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1429001] Review Request: pyosmium - Python bindings for libosmium

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1429001

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-16 18:21:09



--- Comment #9 from Fedora Update System  ---
libosmium-2.11.1-1.fc25, osmium-tool-1.5.1-2.fc25, protozero-1.5.1-3.fc25,
pyosmium-2.11.0-2.fc25, rapidjson-1.1.0-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428437] Review Request: golang-github-bkaradzic-go-lz4 - Port of LZ4 lossless compression algorithm to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428437



--- Comment #15 from Fedora Update System  ---
golang-github-bkaradzic-go-lz4-1.0.0-1.fc25 has been pushed to the Fedora 25
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433121] Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433121

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Athos Ribeiro  ---
Is there any special reason for not running the tests?

The content of the examples is only used by the test cases. It is not a test
case itself, but shouldn't it be moved to the unit-test subpackage AND to %doc
on the -devel package?

Upstream provides versions (v1.1 tag is available on the same commit packaged).
You should update the Version and Release tags accordingly [1]. Refer to [2] 
if you need to package post 1.1 commits.

Package looks good overall, I will trust you will handle the Version tags
before uploading. Approved

[1] https://fedoraproject.org/wiki/Packaging:Versioning
[2]
https://fedoraproject.org/wiki/Package_Versioning_Examples#Complex_versioning_examples

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
 Note that golang packages share namespace!
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: 

[Bug 1432901] Review Request: restic - restic backup program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432901

Till Maas  changed:

   What|Removed |Added

 CC||opensou...@till.name
 Whiteboard||NotReady



--- Comment #1 from Till Maas  ---
The package needs to be built from source. Copying just the upstream binary is
not enough:

https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1345887] Review Request: golang-github-yosssi-ace - HTML template engine for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1345887



--- Comment #12 from Olivier Lemasle  ---
Hello Athos,

Thanks, I wasn't aware it was the cause of this unnecessary dependency. I've
fixed the issue; please find the new spec:

Spec URL: https://olem.fedorapeople.org/reviews/golang-github-yosssi-ace.spec
SRPM URL:
https://olem.fedorapeople.org/reviews/golang-github-yosssi-ace-0.0.5-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427634] Review Request: syncthing - Continuous File Synchronization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427634
Bug 1427634 depends on bug 1428437, which changed state.

Bug 1428437 Summary: Review Request: golang-github-bkaradzic-go-lz4 - Port of 
LZ4 lossless compression algorithm to Go
https://bugzilla.redhat.com/show_bug.cgi?id=1428437

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428437] Review Request: golang-github-bkaradzic-go-lz4 - Port of LZ4 lossless compression algorithm to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428437

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-16 17:18:38



--- Comment #14 from Fedora Update System  ---
golang-github-bkaradzic-go-lz4-1.0.0-1.fc24 has been pushed to the Fedora 24
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433121] Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433121

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433121] New: Review Request: golang-github-grpc-ecosystem-go-grpc-prometheus - Prometheus monitoring for your gRPC Go servers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433121

Bug ID: 1433121
   Summary: Review Request:
golang-github-grpc-ecosystem-go-grpc-prometheus -
Prometheus monitoring for your gRPC Go servers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-grpc-ecosystem-go-grpc-prometheus/golang-github-grpc-ecosystem-go-grpc-prometheus.spec

SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-grpc-ecosystem-go-grpc-prometheus/golang-github-grpc-ecosystem-go-grpc-prometheus-0-0.1.git6b7015e.fc24.src.rpm

Description: Prometheus monitoring for your gRPC Go servers

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=18418505

$ rpmlint
golang-github-grpc-ecosystem-go-grpc-prometheus-0-0.1.git6b7015e.fc24.src.rpm
golang-github-grpc-ecosystem-go-grpc-prometheus-devel-0-0.1.git6b7015e.fc24.noarch.rpm
golang-github-grpc-ecosystem-go-grpc-prometheus-unit-test-devel-0-0.1.git6b7015e.fc24.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431952] Review Request: modules-tcl - Native Tcl version of the Environment Modules system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431952

Orion Poplawski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks|177841 (FE-NEEDSPONSOR) |
   Assignee|nob...@fedoraproject.org|or...@cora.nwra.com



--- Comment #3 from Orion Poplawski  ---
I'll take this and sponsor you.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #10 from Fedora Update System  ---
python-leather-0.3.3-2.gite85dd30.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-c04a15f2b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #9 from Fedora Update System  ---
python-leather-0.3.3-2.gite85dd30.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ceb5bfa9b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432975] Review Request: freerdp1.2 - Compatibility version of the FreeRDP client libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432975

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Dominik 'Rathann' Mierzejewski  ---
1.
[...]
%ifarch x86_64
-DWITH_SSE2=ON \
%else
-DWITH_SSE2=OFF \
%endif
%ifarch armv7hl
-DARM_FP_ABI=hard \
-DWITH_NEON=OFF \
%endif
%ifarch armv7hnl
-DARM_FP_ABI=hard \
-DWITH_NEON=ON \
%endif
%ifarch armv5tel armv6l armv7l
-DARM_FP_ABI=soft \
-DWITH_NEON=OFF \
%endif
%ifarch aarch64
-DWITH_SSE2=OFF \
%endif
[...]

The last %ifarch aarch64 is redundant, as that case is already handled by
%ifarch x86_64 ... %else above.

2. Redundant BuildRequires:
gstreamer1-devel (pulled in by gstreamer1-plugins-base-devel)
zlib-devel (pulled in by cups-devel and gstreamer1-plugins-base-devel)
libX11-devel (pulled in by libXcursor-devel, libXdamage-devel, libXext-devel,
libXrandr-devel and libXv-devel)
libXext-devel (pulled in by libXi-devel, libXinerama-devel, libXrandr-devel and
libXv-devel)

No other issues, package is APPROVED.

You can fix the above when importing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432975] Review Request: freerdp1.2 - Compatibility version of the FreeRDP client libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432975

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|domi...@greysector.net
  Flags||fedora-review?



--- Comment #1 from Dominik 'Rathann' Mierzejewski  ---
Taking review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428861] Review Request: xrdhttpvoms - Security extractor plugin for XrdHTTP. Extracts VOMS info from the presented proxy certificates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428861

michal.si...@cern.ch changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(michal.simon@cern |
   |.ch)|



--- Comment #6 from michal.si...@cern.ch ---
Thanks for addressing my comments!

Package Review
==

Legend:
[x] = Pass, [-] = Not applicable


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.


Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: %build honors applicable compiler flags.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Package contains desktop file if it is a GUI application.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Package builds in mock.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: The debuginfo package(s) has been tested with rpmlist.
[x]: All installed packages have been tested with rpmlint.
[x]: Large data in /usr/share should live in a noarch subpackage 

[Bug 1273471] Review Request: python-anymarkup-core - The core library for anymarkup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1273471
Bug 1273471 depends on bug 1275305, which changed state.

Bug 1275305 Summary: Please build python-flexmock for epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1275305

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-leather

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802



--- Comment #7 from Julien Enselme  ---
> Thank you for your well wishes again. I'm now a packager. :)

Thanks for the review and welcome to the club!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431451] Review Request: php-sebastian-object-reflector - Allows reflection of object attributes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431451



--- Comment #1 from Remi Collet  ---
Spec:
https://raw.githubusercontent.com/remicollet/remirepo/299f88bef59d696d602d0ab6a5cb7cc28d3f0ff7/php/phpunit/php-sebastian-object-reflector/php-sebastian-object-reflector.spec
Srpm:
http://rpms.remirepo.net/SRPMS/php-sebastian-object-reflector-1.1.0-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Dhanesh B. Sabane  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409802] Review Request: python-leather - Python charting for 80% of humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409802

Dhanesh B. Sabane  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|dhanes...@disroot.org



--- Comment #6 from Dhanesh B. Sabane  ---
(In reply to Julien Enselme from comment #5)
> Spec URL: http://dl.jujens.eu/SPECS/python-leather.spec
> SRPM URL:
> http://dl.jujens.eu/SRPMS/python-leather-0.3.3-2.gite85dd30.fc25.src.rpm

+ Package name - OK
+ Builds and installs - OK
+ License is acceptable
+ Latest version - OK
+ BuildRequires look sane
+ python macros are used
+ %python_provide is used

Package is APPROVED.


(In reply to Julien Enselme from comment #2)
> > Disclaimer : I'm not a packager yet. So this is an unofficial review.
> 
> I hope you will be soon!
> 

Thank you for your well wishes again. I'm now a packager. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426965] Review Request: go-i18n - Translate Go programs into multiple languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426965



--- Comment #11 from Fedora Update System  ---
go-i18n-1.7.0-5.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a8dc79a021

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433003] Review Request: openboardview - Software for viewing .brd files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433003

srakitnican  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433003] New: Review Request: openboardview - Software for viewing .brd files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433003

Bug ID: 1433003
   Summary: Review Request: openboardview - Software for viewing
.brd files
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: samuel.rakitni...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://drive.google.com/uc?export=download=0BzMS3N8RDtOITGd5V2ZJSW1TTU0
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/openboardview/fedora-25-x86_64/00471774-openboardview/openboardview-7.3-2.fc25.src.rpm

Description:
Software for viewing .brd files, intended as a drop-in replacement for
the "Test_Link" software.


Fedora Account System Username: srakitnican

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432995] New: Review Request: nodejs-grunt-contrib-copy - Copy files and folders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432995

Bug ID: 1432995
   Summary: Review Request: nodejs-grunt-contrib-copy - Copy files
and folders
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ra...@electronsweatshop.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://bowlofeggs.fedorapeople.org/nodejs-grunt-contrib-copy.spec
SRPM URL:
https://bowlofeggs.fedorapeople.org/nodejs-grunt-contrib-copy-1.0.0-1.fc27.src.rpm
Description: Copy files and folders.
Fedora Account System Username: bowlofeggs

Note that this package is currently retired, and so I am going through the
unretirement process:

https://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers#Claiming_Ownership_of_a_Retired_Package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432106] Review Request: perl-Reply - Plugin-based read-eval-print loop for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432106

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Reply-0.42-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-03-16 10:36:06



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432997] Review Request: multimc5 - Minecraft launcher with ability to manage multiple instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432997



--- Comment #1 from srakitnican  ---
Fedora Account System Username: srakitnican

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432995] Review Request: nodejs-grunt-contrib-copy - Copy files and folders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432995



--- Comment #1 from Randy Barlow  ---
*** Bug 1429209 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432997] Review Request: multimc5 - Minecraft launcher with ability to manage multiple instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432997

srakitnican  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432997] New: Review Request: multimc5 - Minecraft launcher with ability to manage multiple instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432997

Bug ID: 1432997
   Summary: Review Request: multimc5 - Minecraft launcher with
ability to manage multiple instances
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: samuel.rakitni...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://drive.google.com/uc?export=download=0BzMS3N8RDtOIdUI0VUx2T1NEWk0
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-26-x86_64/00523278-multimc5/multimc5-0.5.1-2.fc26.src.rpm

Description:
MultiMC is a free, open source launcher for Minecraft. It allows you to have
multiple, separate instances of Minecraft (each with their own mods, texture
packs, saves, etc) and helps you manage them and their associated options with
a simple interface.


Fedora Account System Username:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887



--- Comment #5 from Fedora Update System  ---
golang-github-remyoudompheng-bigfft-0-0.1.gita8e77dd.fc24 has been submitted as
an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-218bd43c5f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432993] Review Request: hd-idle - Spin down idle [USB] hard disks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432993

srakitnican  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432993] New: Review Request: hd-idle - Spin down idle [USB] hard disks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432993

Bug ID: 1432993
   Summary: Review Request: hd-idle - Spin down idle [USB] hard
disks
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: samuel.rakitni...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://drive.google.com/uc?export=download=0BzMS3N8RDtOIclg0VUVHbEk1ekE
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-25-x86_64/00519190-hd-idle/hd-idle-1.05-1.fc25.src.rpm

Description:
hd-idle is a utility program for spinning-down external disks after a period
of idle time. Since most external IDE disk enclosures don't support setting
the IDE idle timer, a program like hd-idle is required to spin down idle disks
automatically.

A word of caution: hard disks don't like spinning up too often. Laptop disks
are more robust in this respect than desktop disks but if you set your disks
to spin down after a few seconds you may damage the disk over time due to the
stress the spin-up causes on the spindle motor and bearings. It seems that
manufacturers recommend a minimum idle time of 3-5 minutes, the default in
hd-idle is 10 minutes.

One more word of caution: hd-idle will spin down any disk accessible via the
SCSI layer (USB, IEEE1394, ...) but it will not work with real SCSI disks
because they don't spin up automatically. Thus it's not called scsi-idle and
I don't recommend using it on a real SCSI system unless you have a kernel
patch that automatically starts the SCSI disks after receiving a sense buffer
indicating the disk has been stopped. Without such a patch, real SCSI disks
won't start again and you can as well pull the plug.


Fedora Account System Username:srakitnican

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390477

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
Schema compilation is not needed, see
https://bugzilla.redhat.com/show_bug.cgi?id=1396790#c9.

+ latest version
+ builds and installs and runs OK
+ license is acceptable (GPLv2)
+ license is specified correctly
+ package name is OK
+ no scriptlets needed
+ BR/R/P look correct

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432106] Review Request: perl-Reply - Plugin-based read-eval-print loop for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432106



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Reply

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
If you look at the scriptlet description
(http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema),
you'll see that this is only for Fedora <= 23. So that fedora-review advice is
obsolete, in current Fedora versions there's nothing to do, and compilation is
done through file triggers provided by some other package.

+ latest version
+ builds and installs and runs OK
+ license is acceptable (GPLv2)
+ license is specified correctly
+ package name is OK
+ no scriptlets needed
+ BR/R/P look correct

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887



--- Comment #4 from Fedora Update System  ---
golang-github-remyoudompheng-bigfft-0-0.1.gita8e77dd.fc25 has been submitted as
an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cef856b9f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887



--- Comment #3 from Fedora Update System  ---
golang-github-remyoudompheng-bigfft-0-0.1.gita8e77dd.fc26 has been submitted as
an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e104a2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432983] Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432983

srakitnican  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432983] New: Review Request: camotics - Open-Source Simulation & Computer Aided Machining - A 3-axis CNC GCode simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432983

Bug ID: 1432983
   Summary: Review Request: camotics - Open-Source Simulation &
Computer Aided Machining - A 3-axis CNC GCode
simulator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: samuel.rakitni...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://transfer.sh/yvaxy/camotics.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/default/fedora-25-x86_64/00525563-camotics/camotics-1.1.1-1.fc25.src.rpm

Description: 
CAMotics is an Open-Source software which can simulate
3-axis NC machining. It is a fast, flexible and user friendly simulation
software for the DIY and Open-Source community.

At home manufacturing is one of the next big technology revolutions. Much like
the PC was 30 years ago. There have been major advances in desktop 3D printing
(e.g.  Maker Bot) yet uptake of desktop CNCs has lagged despite the
availability of cheap CNC machines. One of the major reasons for this is a
lack of Open-Source simulation and CAM (model to tool path conversion)
software. CAM and NC machine simulation present some very difficult
programming problems as evidenced by 30+ years of academic papers on these
topics. Whereas 3D printing simulation and tool path generation is much
easier. However, such software is essential to using a CNC.

Being able to simulate is a critical part of creating usable CNC tool paths.
Programming a CNC with out a simulator is cutting with out measuring; it's
both dangerous and expensive. With CAMotics you can preview the results of
your cutting operations before you fire up your machine. This will
save you time and money and open up a world of creative possibilities by
allowing you to rapidly visualize and improve upon designs without wasting
material or breaking tools.


Fedora Account System Username: srakitnican

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431729] Review Request: perl-Class-Refresh - Refresh your classes during run time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431729

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Class-Refresh-0.07-1.f
   ||c27
 Resolution|--- |RAWHIDE
Last Closed||2017-03-16 09:52:17



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I added the optional dependency.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1179350] Review Request: python-pytest-beakerlib - A pytest plugin that reports test results to the BeakerLib framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1179350



--- Comment #17 from Iryna Shcherbina  ---
Thanks a lot for the review, Miro. I will make it Fedora only as per previous
comments and will fix all the issues.

(In reply to Miro Hrončok from comment #16)
> 
> - There are failures in the smoketest output, is that intentional?

It is. It's a demo for running both success and failure tests with beakerlib
plugin enabled. But I will add a comment for that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427341] Review Request: python-gamera - Gamera is a framework for building document analysis applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427341



--- Comment #19 from Miro Hrončok  ---
s/bee/be/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427341] Review Request: python-gamera - Gamera is a framework for building document analysis applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427341



--- Comment #18 from Miro Hrončok  ---
OK, let me have a look.

1) Summary. You don't have to set the %{sum} macro, you can write a summary
into the Summary field and then use %{summary} in the subpackages.

2) Description. I don't think an URL belongs there. Just use it as the URL
instead of the github one.

3) Since this is Python 2 only, I think you should have python2-gamera
subpackage instead of python-gamera package. Once python- will mean python3,
you would have trouble this way.

4) The summary of devel subpackage should definitely not bee the same as the
main package.

5) "Devel gamera package." is not verbose enough as description. "Development
package for gamera. Allows you to develop your apps on top of the gamera
framework." might be a little bit better. 

6) I'd add some whitespace to %install so the lines that do one thing are
together

7) Add comment to the shebang removal so it's obvious what's happening there
and WHY

8) I don't think the devel subpackage is a header only library per se, so the
-static provide here is bogus.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432106] Review Request: perl-Reply - Plugin-based read-eval-print loop for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432106

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Reply-0.42-1.fc27.noarch.rpm | sort | uniq -c
  1 /usr/bin/perl
  1 perl(:MODULE_COMPAT_5.24.1)
  1 perl(App::Nopaste)
  1 perl(B::Keywords)
  1 perl(Carp::Always)
  1 perl(Class::Refresh) >= 0.05
  1 perl(Config::INI::Reader::Ordered)
  1 perl(Data::Dump)
  1 perl(Data::Dumper)
  1 perl(Data::Printer)
  1 perl(Eval::Closure) >= 0.11
  1 perl(Exporter)
  1 perl(File::HomeDir)
  1 perl(File::Spec)
  1 perl(Getopt::Long) >= 2.36
  1 perl(IO::Pager)
  1 perl(Module::Runtime)
  1 perl(Package::Stash)
  1 perl(PadWalker)
  1 perl(Proc::InvokeEditor)
  1 perl(Reply)
  1 perl(Reply::App)
  1 perl(Reply::Config)
  1 perl(Reply::Plugin)
  1 perl(Reply::Util)
  1 perl(Scalar::Util)
  1 perl(Term::ANSIColor)
  1 perl(Term::ReadKey)
  1 perl(Term::ReadLine)
  1 perl(Time::HiRes)
  1 perl(Try::Tiny)
  1 perl(base)
  1 perl(mro)
  1 perl(overload)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Reply-0.42-1.fc27.noarch.rpm | sort | uniq -c
  1 perl(Reply) = 0.42
  1 perl(Reply::App) = 0.42
  1 perl(Reply::Config) = 0.42
  1 perl(Reply::Plugin) = 0.42
  1 perl(Reply::Plugin::AutoRefresh) = 0.42
  1 perl(Reply::Plugin::Autocomplete::Commands) = 0.42
  1 perl(Reply::Plugin::Autocomplete::Functions) = 0.42
  1 perl(Reply::Plugin::Autocomplete::Globals) = 0.42
  1 perl(Reply::Plugin::Autocomplete::Keywords) = 0.42
  1 perl(Reply::Plugin::Autocomplete::Lexicals) = 0.42
  1 perl(Reply::Plugin::Autocomplete::Methods) = 0.42
  1 perl(Reply::Plugin::Autocomplete::Packages) = 0.42
  1 perl(Reply::Plugin::CollapseStack) = 0.42
  1 perl(Reply::Plugin::Colors) = 0.42
  1 perl(Reply::Plugin::DataDump) = 0.42
  1 perl(Reply::Plugin::DataDumper) = 0.42
  1 perl(Reply::Plugin::DataPrinter) = 0.42
  1 perl(Reply::Plugin::Defaults) = 0.42
  1 perl(Reply::Plugin::Editor) = 0.42
  1 perl(Reply::Plugin::FancyPrompt) = 0.42
  1 perl(Reply::Plugin::Hints) = 0.42
  1 perl(Reply::Plugin::Interrupt) = 0.42
  1 perl(Reply::Plugin::LexicalPersistence) = 0.42
  1 perl(Reply::Plugin::LoadClass) = 0.42
  1 perl(Reply::Plugin::Nopaste) = 0.42
  1 perl(Reply::Plugin::Packages) = 0.42
  1 perl(Reply::Plugin::Pager) = 0.42
  1 perl(Reply::Plugin::ReadLine) = 0.42
  1 perl(Reply::Plugin::ResultCache) = 0.42
  1 perl(Reply::Plugin::Timer) = 0.42
  1 perl(Reply::Util) = 0.42
  1 perl-Reply = 0.42-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-Reply*
perl-Reply.noarch: W: spelling-error Summary(en_US) eval -> veal, vela, val
perl-Reply.noarch: W: spelling-error %description -l en_US eval -> veal, vela,
val
perl-Reply.noarch: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
perl-Reply.src: W: spelling-error Summary(en_US) eval -> veal, vela, val
perl-Reply.src: W: spelling-error %description -l en_US eval -> veal, vela, val
perl-Reply.src: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432975] New: Review Request: freerdp1.2 - Compatibility version of the FreeRDP client libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432975

Bug ID: 1432975
   Summary: Review Request: freerdp1.2 - Compatibility version of
the FreeRDP client libraries
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: negativ...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://slaanesh.fedorapeople.org/freerdp1.2.spec
SRPM URL: https://slaanesh.fedorapeople.org/freerdp1.2-1.2.0-5.fc25.src.rpm
Description: Free implementation of the Remote Desktop Protocol (RDP) protocol.
This compatibility package only contains client libraries.
Fedora Account System Username: slaanesh

Note: this is a re-review of the package previously approved as both me and the
reviewer missed the new packaging guidelines for compatibility libraries of
November 2016:

https://bugzilla.redhat.com/show_bug.cgi?id=1428383

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1179350] Review Request: python-pytest-beakerlib - A pytest plugin that reports test results to the BeakerLib framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1179350



--- Comment #16 from Miro Hrončok  ---
Created attachment 1263691
  --> https://bugzilla.redhat.com/attachment.cgi?id=1263691=edit
mock build.log

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- The source URL is bad, fedorahosted is not working any more.
  Update to https://releases.pagure.org/python-pytest-beakerlib/...
  (The 0.7 release is missing from there BTW)
  Or us PyPI.


- The test has this in the log:

:: [ 14:18:10 ] :: [ WARNING ] :: Please fix your test to have /bin/bash
shebang

Maybe run it with bash instead of sh?

- There are failures in the smoketest output, is that intentional?

build.log attached.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[-]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-remyoudompheng-bigfft

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431729] Review Request: perl-Class-Refresh - Refresh your classes during run time

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431729



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Class-Refresh

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389955] Review Request: gnome-shell-extension-no-topleft-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gnome-shell-extension-no-topleft-hot-corner

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887



--- Comment #1 from Fabio Valentini  ---
Thanks for the quick review! I just sent the pkgdb request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1424860] Review Request: nodejs-finalhandler - Node.js final http responder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1424860



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-finalhandler

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432955] New: Review Request: lld - The LLVM linker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432955

Bug ID: 1432955
   Summary: Review Request: lld - The LLVM linker
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tstel...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/tstellar/llvm-4.0/lld.git/tree/lld.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tstellar/llvm-4.0/fedora-rawhide-x86_64/00527694-lld/lld-4.0.0-1.fc27.src.rpm
Description: LLD is the system linker for the LLVM project.
Fedora Account System Username: tstellar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1272174] Review Request: golang-github-pmezard-go-difflib - Partial port of Python difflib package to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272174

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422555] Review Request: arduino-ctags - A mix of ctags and anjuta-tags for the perfect C++ ctags

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422555



--- Comment #15 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/arduino-ctags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1272174] Review Request: golang-github-pmezard-go-difflib - Partial port of Python difflib package to Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272174



--- Comment #8 from Fedora Update System  ---
golang-github-pmezard-go-difflib-0-0.6.gitd8ed262.el6 has been submitted as an
update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-1ecdc2a1bc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1422714] Review Request: yank - tool for yanking (copying) stdin to clipboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1422714



--- Comment #15 from Fedora Update System  ---
yank-0.8.2-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9679fa4df4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432887] Review Request: golang-github-remyoudompheng-bigfft - Big integer multiplication library using FFT for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432887

Jan Chaloupka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jchal...@redhat.com
   Assignee|nob...@fedoraproject.org|jchal...@redhat.com
  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421183] Review Request: ntetris - simple cli tetris game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421183

jiri vanek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from jiri vanek  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have
 unknown license. Detailed output of licensecheck in
 /home/jvanek/1421183-ntetris/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ntetris-
 debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[!]: Package should compile and build into binary 

[Bug 1432106] Review Request: perl-Reply - Plugin-based read-eval-print loop for Perl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432106

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421183] Review Request: ntetris - simple cli tetris game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421183

jiri vanek  changed:

   What|Removed |Added

 CC||jva...@redhat.com
   Assignee|nob...@fedoraproject.org|jva...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org