[Bug 1336168] Review Request: git-lfs - Git extension for versioning large files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336168



--- Comment #7 from Elliott Sales de Andrade  ---
git-lfs v2.0.1 is available in my copr I linked above. 2.0.2 currently fails to
build on F25 as it appears to use a function from Go 1.8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336168] Review Request: git-lfs - Git extension for versioning large files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336168

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Depends On|1336166 |
   |(golang-github-technoweenie |
   |-assert)|




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1336166
[Bug 1336166] Review Request: golang-github-technoweenie-assert - Asserts
to Go testomg
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1336166] Review Request: golang-github-technoweenie-assert - Asserts to Go testomg

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336166

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks|1336168 (git-lfs)   |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1336168
[Bug 1336168] Review Request: git-lfs - Git extension for versioning large
files
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427182] Review Request: libzypp - A package management library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427182

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-18 23:08:16



--- Comment #8 from Fedora Update System  ---
libzypp-16.6.1-1.fc26, zypper-1.13.22-1.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427185] Review Request: zypper - Command line package manager from SUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427185

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-18 23:08:12



--- Comment #9 from Fedora Update System  ---
libzypp-16.6.1-1.fc26, zypper-1.13.22-1.fc26 has been pushed to the Fedora 26
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427185] Review Request: zypper - Command line package manager from SUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427185
Bug 1427185 depends on bug 1427182, which changed state.

Bug 1427182 Summary: Review Request: libzypp - A package management library
https://bugzilla.redhat.com/show_bug.cgi?id=1427182

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436253] Review Request: pidgin-toobars - Adds toolbar and status bar to Pidgin buddy list

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436253

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-18 23:08:01



--- Comment #14 from Fedora Update System  ---
pidgin-toobars-1.14-5.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258542



--- Comment #28 from Shawn Starr  ---
I've poked Chris on twitter, you can certainly help with packaging, it's always
good to have co-maintainers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #35 from Fedora Update System  ---
superlu_dist-5.1.3-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-ba85d2bc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #34 from Fedora Update System  ---
superlu_dist-5.1.3-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-4b1f4593ad

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441729] Review Request: lizardfs - Distributed, fault tolerant file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441729



--- Comment #4 from greg.helli...@gmail.com ---
Summary of issues. Some of them have more details below in the output of the
tools.

[!] Looks like there is a bundled external library in external/crcutil-1.0,
which I don't find anywhere being packaged for Fedora. This should either be
packaged separately or removed from the code tree before building, in order to
ensure that it is not being built into this package. It looks like some code is
lifted from Boost as well. Potentially from other places, as well, although
tracing the exact pedigree of individual files can be difficult. The state of
such bundled files should be clearly defined.
[!] Licensing looks like it needs some clarifications to me. See below for more
details on that.
[!] /etc/mfs doesn't have anything taking ownership of it
[!] You're running an unnecessary rm -rf %{buildroot} at the start of %install.
This is obsolete and no longer needed
[!] Use of %define instead of %global to set common variables throughout the
package
[!] rpmlint output is mostly innocuous, but the errors relate to the sed
commands I asked you to update the previous round. Those macros only get
defined if there is a BR on python-devel and python3-devel. I'll leave it up to
your judgment whether you want to include those packages for the sake of the
macros or if you want to revert to the hard-coded values.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "GPL (v3 or later)", "Unknown or generated",
 "MIT/X11 (BSD like)", "BSL (v1.0)", "*No copyright* GPL (v3 or
 later)", "*No copyright* GPL (v3)", "GPL (v2 or later) (with incorrect
 FSF address)", "BSD (3 clause)", "GPL (v3)", "*No copyright* Apache
 (v2.0)". 415 files have unknown license. 

 There's lots of confusion about the licensing in these files, making it
 unclear where some of it all comes from. Some of these the tools picked
 up as being under a license that requires the license itself be
distributed
 with the application. Some of those make me think they were lifted from
 partially bundled libraries (e.g. common/coroutine.h references being
 under the Boost license and is similar to some names files that came
 out of that library)
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/mfs
 One of these packages should take ownership of /etc/mfs
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /etc/mfs
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
 The following config files have supporting reason why stated in package
 Note: No (noreplace) in %config /etc/mfs/mfsexports.cfg.dist %config
 /etc/mfs/mfstopology.cfg.dist %config /etc/mfs/mfsgoals.cfg.dist
 %config /etc/mfs/mfsmaster.cfg.dist %config
 /etc/mfs/globaliolimits.cfg.dist %config
 /etc/mfs/mfsmetalogger.cfg.dist %config
 /etc/mfs/mfschunkserver.cfg.dist %config /etc/mfs/mfshdd.cfg.dist
 %config /etc/mfs/mfsmount.cfg.dist %config /etc/mfs/iolimits.cfg.dist
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or 

[Bug 1433760] Review Request: python-cu2qu - Cubic-to-quadratic bezier curve conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433760

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433760] Review Request: python-cu2qu - Cubic-to-quadratic bezier curve conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433760



--- Comment #4 from Fedora Update System  ---
python-cu2qu-1.1.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ebcfdf0f75

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258542



--- Comment #27 from Adam Williamson  ---
Well, there's still the *general* packaging guidelines to consider. I don't
think the font guidelines supersede those, in fact the section on packaging
from source specifically references back to them. And they're quite specific
about when you get an exception from the requirement to build from source.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258542



--- Comment #26 from Randy Barlow  ---
After reading the scrollback it does sound like Shawn is lined up to do the
review so I'll defer, but I'm happy to be a standin. I'll memorize my lines.

My interpretation of the packaging rules is that SHOULD != MUST when it comes
to building the font from source. The font guidelines do use the word "MUST" in
other places so I take that to mean that this shouldn't block the package from
getting into Fedora. It's obviously better if we build the font from source,
but since there isn't a clear way to do that provided by upstream I don't think
we have to wait for https://github.com/chrissimpkins/Hack/issues/227 to be
solved to get this into Fedora. I would recommend allowing the package in with
the OTF files (and hopefully web files for me ☺) and then filing a BZ to build
from source if possible later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1258542] Review Request: hack-fonts - A typeface designed for source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1258542

Randy Barlow  changed:

   What|Removed |Added

 CC||ra...@electronsweatshop.com



--- Comment #25 from Randy Barlow  ---
The Hack license is now acceptable for Fedora:

https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/thread/MJ4Q3D6JLDVX4OHSF3YXY76Z6BYSKKQR/

Also, FWIW I could really use the web fonts for Bodhi (which is why I wanted to
package Hack) so I would appreciate if you could include a subpackage with
those files.

I'm willing to review this package if nobody else has a "claim" on reviewing
it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433744] Review Request: python-mutatormath - Python library for piecewise linear interpolation in multiple dimensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433744

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433744] Review Request: python-mutatormath - Python library for piecewise linear interpolation in multiple dimensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433744



--- Comment #6 from Fedora Update System  ---
python-mutatormath-2.0.4-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a2d6fe8196

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409382] Review Request: python36 - Version 3.6 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409382

Miro Hrončok  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-04-18 16:35:11



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

John Dulaney  changed:

   What|Removed |Added

  Flags|needinfo?(jdulaney@fedorapr |
   |oject.org)  |



--- Comment #5 from John Dulaney  ---
Spec URL: https://jdulaney.fedorapeople.org/guile22.spec
SRPM URL: https://jdulaney.fedorapeople.org/guile22-2.2.0-5.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1403417] Review Request: gsequencer - audio processing engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1403417

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-18 15:59:37



--- Comment #84 from Fedora Update System  ---
gsequencer-0.7.122.23-0.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441071] Review Request: perl-Mock-Config - Temporarily set Config or XSConfig values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441071

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-18 15:58:51



--- Comment #6 from Fedora Update System  ---
perl-Mock-Config-0.03-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433455] Review Request: python-os-win - Windows / Hyper-V library for OpenStack projects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433455

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-04-18 15:57:43



--- Comment #5 from Fedora Update System  ---
python-os-win-1.4.1-1.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427182] Review Request: libzypp - A package management library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427182

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
libzypp-16.6.1-1.fc26, zypper-1.13.22-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba82706aa3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1427185] Review Request: zypper - Command line package manager from SUSE

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1427185

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
libzypp-16.6.1-1.fc26, zypper-1.13.22-1.fc26 has been pushed to the Fedora 26
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ba82706aa3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853



--- Comment #10 from Fedora Update System  ---
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc26 has been pushed to the Fedora
26 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-7da348eda5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #12 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc26 has been
pushed to the Fedora 26 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-43dcb207fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
gsignond-1.0.6-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4cfec99e64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #33 from Fedora Update System  ---
superlu_dist-5.1.3-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e2b96ce208

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389



--- Comment #9 from Fedora Update System  ---
golang-github-ccding-go-stun-0-0.1.20170323.git04a4eed.fc26 has been pushed to
the Fedora 26 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-685af345e5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741



--- Comment #10 from Fedora Update System  ---
golang-github-cznic-b-0-0.1.20170413.git6955404.fc26 has been pushed to the
Fedora 26 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e740cb75e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1220451

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
> @Fabien, ya I planned to resync once we created a git remove on 
> fedoraproject.org.

Maybe I'm misunderstanding, but if you mean the repo like
http://pkgs.fedoraproject.org/cgit/rpms/zuul.git, that will be created only
after the package is approved. If you need an unofficial repo to coordinate
work, and you want it to be on fedora infrastructure, you can create one
yourself on https://pagure.io.

> This is a program that is used to gate the source code repository of a project
so that changes are only merged if they pass tests. The main component is
the scheduler. It receives events related to proposed changes, triggers tests
based on those events, and reports back. This software interacts between Gerrit
and Jenkins by listening the Gerrit events stream and triggering jobs.

This is a program that gates changes in a source code repository of a project,
so that changes are only merged if tests pass. The main component is
the scheduler. It receives events related to proposed changes, triggers tests
based on those events, and reports back. This software interacts with Gerrit
and Jenkins by listening to the Gerrit event stream and triggering jobs.

(grammar)

Looks good otherwise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442532] Review Request: nodejs-fs-promise - Filesystem methods as promises with fs-extra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442532



--- Comment #1 from Jared Smith  ---
Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-fs-promise/nodejs-fs-promise.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-fs-promise/nodejs-fs-promise-2.0.2-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441729] Review Request: lizardfs - Distributed, fault tolerant file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441729



--- Comment #3 from Jonathan Dieter  ---
Spec URL: https://www.lesbg.com/jdieter/lizardfs.spec
SRPM URL: https://www.lesbg.com/jdieter/lizardfs-3.10.6-3.fc25.src.rpm

Ok, done

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364656] Review Request: nodejs-resolve-dir - Resolve a directory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364656

Jared Smith  changed:

   What|Removed |Added

 Depends On|1364654 |1443211




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364654
[Bug 1364654] Review Request: nodejs-detect-file - Detect if a filepath
exists and resolves the full filepath
https://bugzilla.redhat.com/show_bug.cgi?id=1443211
[Bug 1443211] Review Request: nodejs-user-home - Get the path to the user
home directory
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443211] Review Request: nodejs-user-home - Get the path to the user home directory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443211

Jared Smith  changed:

   What|Removed |Added

 Blocks||1364656




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364656
[Bug 1364656] Review Request: nodejs-resolve-dir - Resolve a directory
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1364654] Review Request: nodejs-detect-file - Detect if a filepath exists and resolves the full filepath

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364654

Jared Smith  changed:

   What|Removed |Added

 Blocks|1364656 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364656
[Bug 1364656] Review Request: nodejs-resolve-dir - Resolve a directory
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443211] New: Review Request: nodejs-user-home - Get the path to the user home directory

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443211

Bug ID: 1443211
   Summary: Review Request: nodejs-user-home - Get the path to the
user home directory
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-user-home/nodejs-user-home.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-user-home/nodejs-user-home-2.0.0-1.fc27.src.rpm
Description: Get the path to the user home directory
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1387531
[Bug 1387531] Package tracker for supporting Node-RED
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1441841] Review Request: python-camel - Python serialization for adults

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1441841



--- Comment #4 from Jonathan Dieter  ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[!]: Package complies to the Packaging Guidelines

 The Release tag wasn't bumped on the last build, though it was in the
 changelog

[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.

 Technically this is passed because the source code doesn't include the
 license, but upstream has since added the file LICENSE to git.  After
 reading
 https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text,
 I think that we should include the upstream git version.  Alternatively,
 it might make more sense to just package the latest git snapshot since
 the package doesn't seem to see a lot of changes

[?]: License file installed when any subpackage combination is installed.
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license. 
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Package contains systemd file(s) if in need.

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
[-]: A package which is used by another package via an egg interface should
 provide egg info.

= SHOULD items =

Generic:
[!]: %check is present and all tests pass.

 %check is present, but it seems to be telling me that no tests were run
 From build.log:
 + /usr/bin/python3 setup.py test
 Python detected LC_CTYPE=C: LC_ALL & LANG coerced to C.UTF-8 (set another
   locale or PYTHONCOERCECLOCALE=0 to disable this locale coercion
   behaviour).
 running test
 running egg_info
 writing camel.egg-info/PKG-INFO
 writing dependency_links to camel.egg-info/dependency_links.txt
 writing requirements to camel.egg-info/requires.txt
 writing top-level names to camel.egg-info/top_level.txt
 reading manifest file 'camel.egg-info/SOURCES.txt'
 writing manifest file 'camel.egg-info/SOURCES.txt'
 running build_ext
 

[Bug 1443210] New: Review Request: nodejs-homedir-polyfill - Node.js os.homedir polyfill for older versions of node.js

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443210

Bug ID: 1443210
   Summary: Review Request: nodejs-homedir-polyfill - Node.js
os.homedir polyfill for older versions of node.js
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Depends On: 1442641
Blocks: 956806 (nodejs-reviews), 1387531 (Node-RED)



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-homedir-polyfill/nodejs-homedir-polyfill.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-homedir-polyfill/nodejs-homedir-polyfill-1.0.1-1.fc27.src.rpm
Description: Node.js os.homedir polyfill for older versions of node.js
Fedora Account System Username: jsmith


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1387531
[Bug 1387531] Package tracker for supporting Node-RED
https://bugzilla.redhat.com/show_bug.cgi?id=1442641
[Bug 1442641] Review Request: nodejs-parse-passwd - Parse a passwd file
into a list of users
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411962] Review Request: golang-github-milochristiansen-lua - A Lua 5.3 VM and compiler written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411962

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Fabio Valentini  ---
It's nice that is was possible to resolve the bug upstream!
The tests pass now:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19065240

My final review uncovered one last minor issue:


 Note: No known owner of
 /usr/share/gocode/src/github.com/milochristiansen/lua/vendor



You should add this as a %dir to the -devel subpackage before importing the
package (no additional changelog entry is necessary from my point of view).

For example, add something like the following at line 104 (similar to line
103):

echo "%%dir %%{gopath}/src/%%{import_path}/vendor" >> devel.file-list


But since it's only a very minor issue, the package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763



--- Comment #11 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc24 has been
pushed to the Fedora 24 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6261d56f95

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1411962] Review Request: golang-github-milochristiansen-lua - A Lua 5.3 VM and compiler written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1411962



--- Comment #10 from Ben Rosser  ---
Indeed; it turned out to be an integer conversion issue. The bug has now been
fixed in 1.1.3:

Spec URL:
https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-lua.spec
SRPM URL:
https://tc01.fedorapeople.org/dwarffortress/golang-github-milochristiansen-lua-1.1.3-1.fc25.src.rpm

I've also added the new provides, the supermeta tests, and the
commit/shortcommit macros to the header.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741



--- Comment #9 from Fedora Update System  ---
golang-github-cznic-b-0-0.1.20170413.git6955404.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-900cdba78a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389



--- Comment #8 from Fedora Update System  ---
golang-github-ccding-go-stun-0-0.1.20170323.git04a4eed.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f8fc1bd3f5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400



--- Comment #32 from Fedora Update System  ---
superlu_dist-5.1.3-2.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cbc1eb72fc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1434421] Review Request: golang-github-AudriusButkevicius-pfilter - Simple Packet Filtering package written in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1434421



--- Comment #10 from Fedora Update System  ---
golang-github-AudriusButkevicius-pfilter-0-0.1.20170209.git09b3cfd.fc24 has
been pushed to the Fedora 24 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a0940eda30

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440968] Review Request: python-setuptools_scm_git_archive - A setuptools_scm plugin that adds support for git archives

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440968

Eduardo Mayorga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||e...@mayorgalinux.com
   Assignee|nob...@fedoraproject.org|e...@mayorgalinux.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #14 from Fabio Valentini  ---
By the way, please select at least f24, f25, f26 and master when you submit the
package request. I need this package on those 4 releases :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547



--- Comment #14 from Fedora Update System  ---
gsignond-1.0.6-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-edda6d990d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063



--- Comment #30 from Jeremy Newton  ---
(In reply to Francesco Frassinelli (frafra) from comment #29)
> (In reply to Jeremy Newton from comment #28)
> > Are you still interested in submitting this package?
> > 
> > I have specified a few concerns in the review notes above, please let me
> > know if you need any clarifications or you feel my judgement is incorrect.
> 
> I am sorry Jeremy, I do not have time for this review request now and I
> would be glad to see someone else continue with it; otherwise I will do it
> when I'll have more free time, sorry.

That's alright, thank you for letting me know. We can put the review on hold
for now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #2 from jiri vanek  ---
https://pagure.io/copy_jdk_configs/c/ac945b7e2c6ea321c47f4d7568159a72fc9f1a77?branch=master

needed for multiple installs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 915791] Review Request: perl-MogileFS-Server - Server part of the MogileFS distributed file system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=915791



--- Comment #20 from Petr Pisar  ---
I received a license clarification from the author. He say "GPL+ or Artistic"
it the right interpretation. Updated package is on the same address.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #26 from Fedora Update System  ---
stress-ng-0.07.29-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9f60124841

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407



--- Comment #25 from Fedora Update System  ---
stress-ng-0.07.29-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e3d9412367

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442853] Review Request: libgsignon-glib - GLib API for the SSO framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442853

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
libgsignon-glib-2.4.1-1.20161228.git03d9c64.fc25 has been pushed to the Fedora
25 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-28e7fc0b45

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442547] Review Request: gsignond - GSignOn daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442547

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
gsignond-1.0.6-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-85a6084eee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1398400

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #31 from Fedora Update System  ---
superlu_dist-5.1.3-2.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-5a231b6b8b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1437389] Review Request: golang-github-ccding-go-stun - STUN client ( RFC 3489 and RFC 5389) implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1437389

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
golang-github-ccding-go-stun-0-0.1.20170323.git04a4eed.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc5bb1bc3a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431763] Review Request: golang-github-oschwald-geoip2-golang - GeoIP2 lookup library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431763

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
golang-github-oschwald-geoip2-golang-1.0.0-1.20170314.git0fd242d.fc25 has been
pushed to the Fedora 25 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-55388bed37

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431741] Review Request: golang-github-cznic-b - B+ Tree implementation in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431741

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
golang-github-cznic-b-0-0.1.20170413.git6955404.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d0f8f446c6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438881] Review Request: guile22 - A GNU implementation of Scheme for application extensibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438881

Miroslav Lichvar  changed:

   What|Removed |Added

  Flags||needinfo?(jdulaney@fedorapr
   ||oject.org)



--- Comment #4 from Miroslav Lichvar  ---
Thanks for the update. Except some issues with the info files I think all good.

- %preun is needed to uninstall the info files correctly,
https://fedoraproject.org/wiki/Packaging:Scriptlets#Texinfo
- the install-info commands should (un)install the info files in the package
(guile22 and r5rs22)
- the info files need to be modified, see Jan's comment #2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1220451



--- Comment #15 from Paul Belanger  ---
Haïkel: Updates per comments.

https://pabelanger.fedorapeople.org/zuul/zuul.spec
https://pabelanger.fedorapeople.org/zuul/zuul-2.1.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1220451



--- Comment #14 from Paul Belanger  ---
@Fabien, ya I planned to resync once we created a git remove on
fedoraproject.org. Will make things a little easier to collaborate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442976] Review Request: switchboard-plug-onlineaccounts - Online Account Plug for Switchboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442976

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076



--- Comment #1 from jiri vanek  ---
The srpm/spec are now missing, as they are work in progress. This bug was added
to: https://fedoraproject.org/wiki/Changes/Java9TechPreview
The jdk9 packages will be based on
https://copr.fedorainfracloud.org/coprs/omajid/openjdk9/package/java-9-openjdk/

Although the copr state is failed, the packages are in better state then they
look - the scratch builds passes outside copr ( == in koji) for f25 and up

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1443076] New: Review Request: java-9-openjdk - OpenJDK Runtime Environment in implementation of java 9 specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1443076

Bug ID: 1443076
   Summary: Review Request: java-9-openjdk - OpenJDK Runtime
Environment in implementation of java 9 specification
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jva...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: coming soon
SRPM URL: coming soon
Description: OpenJDK Runtime Environment in implementation of java 9
specification
Fedora Account System Username: jvanek

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1246278] Review Request: golang-github-bazil-fuse - FUSE library for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246278

Jan Chaloupka  changed:

   What|Removed |Added

  Flags||needinfo?(rosser.bjr@gmail.
   ||com)



--- Comment #2 from Jan Chaloupka  ---
Hi Ben,

given the spec file is outdated, it should be re-generated. What version of the
project are you interested in?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1220451



--- Comment #13 from Fabien Boucher  ---
Hi,

I suggest to re-consider the packaging by looking at the
work that have been done by Tristan there:
https://softwarefactory-project.io/r/gitweb?p=software-factory/zuul-distgit.git;a=blob;f=zuul.spec;hb=HEAD

This is a packaging known to work with centos7 + minor
integration stuff like additional patches (not yet merged upstream
patches) for SF.

Services are splitted server, merger, launcher.

That said I'm not against keeping it simple first and improve
it once approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421605] Container Review Request: nginx - Platform for running nginx or building nginx-based application

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421605

Honza Horak  changed:

   What|Removed |Added

  Flags||needinfo?(pzhu...@redhat.co
   ||m)



--- Comment #4 from Honza Horak  ---
A help file and label added:

Dockerfile URL: https://hhorak.fedorapeople.org/nginx-docker/Dockerfile
Other files URL: https://hhorak.fedorapeople.org/nginx-docker/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986

Fabio Valentini  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Fabio Valentini  ---
Looks good now. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #12 from Matthias Runge  ---
(In reply to Fabio Valentini from comment #11)

> > %if ! 0%{?with_bundled}
> > export GOPATH=%{buildroot}/%{gopath}:%{gopath}
> > %else
> > # No dependency directories so far
> > 
> > export GOPATH=%{buildroot}/%{gopath}:%{gopath}
> > %endif
> 
> with just this:
> 
> > export GOPATH=%{buildroot}/%{gopath}:%{gopath}

Good catch!

I fixed both.

Updated
SPEC: http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid.spec
SRPM:
http://www.matthias-runge.de/fedora/golang-github-klauspost-cpuid-1.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1220451] Review Request: zuul - Trunk gating system developed for the OpenStack Project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1220451



--- Comment #12 from Haïkel Guémar  ---
Few points:
* please use %license
* please use %{python2_sitelib}
* please fix Source0 URL, this one is not working anymore s/python.org/io/
should do the trick
* Group tag is not needed anymore
* does not install, drop Requires: python-argparse

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1282063] Review Request: xxhsum - Extremely fast hash algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282063

Francesco Frassinelli (frafra)  changed:

   What|Removed |Added

  Flags|needinfo?(frap...@gmail.com |
   |)   |



--- Comment #29 from Francesco Frassinelli (frafra)  ---
(In reply to Jeremy Newton from comment #28)
> Are you still interested in submitting this package?
> 
> I have specified a few concerns in the review notes above, please let me
> know if you need any clarifications or you feel my judgement is incorrect.

I am sorry Jeremy, I do not have time for this review request now and I would
be glad to see someone else continue with it; otherwise I will do it when I'll
have more free time, sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1442976] New: Review Request: switchboard-plug-onlineaccounts - Online Account Plug for Switchboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442976

Bug ID: 1442976
   Summary: Review Request: switchboard-plug-onlineaccounts -
Online Account Plug for Switchboard
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: decatho...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://decathorpe.fedorapeople.org/packages/switchboard-plug-onlineaccounts.spec

SRPM URL:
https://decathorpe.fedorapeople.org/packages/switchboard-plug-onlineaccounts-0.3.0.1-1.20170417.git5a0270a.fc26.src.rpm

Description: Online Account Plug for Switchboard. This package includes the
Pantheon Online Accounts system.

Fedora Account System Username: decathorpe


koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19058065

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375986] Review Request: golang-github-klauspost-cpuid - CPU feature identification for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375986



--- Comment #11 from Fabio Valentini  ---
There's only one major issue left as far as I can see: The Release: tag is "1",
when it should be "1%{?dist}". No other changes are necessary for this.

A cosmetic issue is that the conditional block between lines 141 and 147 is
redundant, since the expression is always the same, so you could replace this:

> %if ! 0%{?with_bundled}
> export GOPATH=%{buildroot}/%{gopath}:%{gopath}
> %else
> # No dependency directories so far
> 
> export GOPATH=%{buildroot}/%{gopath}:%{gopath}
> %endif

with just this:

> export GOPATH=%{buildroot}/%{gopath}:%{gopath}

Otherwise, the package looks good. If you fix the Release tag, I will approve
the package. I will leave it up to you if you want to clean up the redundant
conditional.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org