[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

David Hannequin  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|CURRENTRELEASE  |---



--- Comment #10 from David Hannequin  ---
This package don't work on Fedora 25. And you stole my work... 

Be serious and made this package work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450486] Review Request: pdoc - library and cli to discover the public documentation of a Python module or package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450486

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #1 from Raphael Groner  ---
Are you interested in a review swap? Maybe you can take a look into bug
#1462464.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440704] Review Request: cpprest - C++ REST SDK

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440704

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #16 from Raphael Groner  ---
I see in FAS you're already sponsored as a packager, no need any more to block
the tracker.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450122] Review Request: qt5-qtmidi - Qt 5 Multimedia Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450122

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms
 Blocks||928937 (qt-reviews)
  Alias||qt5-qtmidi




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=928937
[Bug 928937] Qt-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed|2017-05-01 14:16:40 |2017-06-18 17:56:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #9 from Björn "besser82" Esser  ---
*** Bug 1389346 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389346] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389346

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||besse...@fedoraproject.org
 Resolution|--- |DUPLICATE
  Flags|fedora-review+  |fedora-review-
Last Closed||2017-06-18 17:54:21



--- Comment #7 from Björn "besser82" Esser  ---
(In reply to David Hannequin from comment #6)
> What do you do with this package ? Why open an other bug 1445824 ?

This package is already present in Fedora;  my request for review was handled
faster.

*** This bug has been marked as a duplicate of bug 1445824 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447089] Review Request: python-XStatic-Patternfly-Bootstrap-Treeview - Patternfly Bootstrap Treeview CSS /JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447089



--- Comment #6 from Fedora Update System  ---
python-XStatic-Patternfly-Bootstrap-Treeview-2.1.3.2-1.fc25 has been pushed to
the Fedora 25 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3c751e6c6a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447089] Review Request: python-XStatic-Patternfly-Bootstrap-Treeview - Patternfly Bootstrap Treeview CSS /JS framework (XStatic packaging standard)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447089

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #5 from Fedora Update System  ---
python-XStatic-Patternfly-Bootstrap-Treeview-2.1.3.2-1.fc24 has been pushed to
the Fedora 24 testing repository. If problems still persist, please make note
of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-307bcae22f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1426193] Review Request: ara - Ansible Run Analysis, Record and visualize Ansible Playbook runs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1426193
Bug 1426193 depends on bug 1447089, which changed state.

Bug 1447089 Summary: Review Request: 
python-XStatic-Patternfly-Bootstrap-Treeview - Patternfly Bootstrap Treeview 
CSS/JS framework (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1447089

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377038] Review Request: sxhkd - Simple X hotkey daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377038



--- Comment #19 from Fedora Update System  ---
sxhkd-0.5.7-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-71f21cedb9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460630] Review Request: copr-rpmbuild - performs COPR builds

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460630

Jakub Kadlčík  changed:

   What|Removed |Added

 CC||jkadl...@redhat.com



--- Comment #2 from Jakub Kadlčík  ---
> Version: 0.2

As noted in previous comment, there is already a 0.3 version


> Summary: Run COPR build tasks
> Name: copr-rpmbuild

It is not wrong or forbidden but can we swap the lines, so Name is first?


> install -d %{buildroot}%{_sysconfdir}/copr-rpmbuild
> install -d %{buildroot}%{_sharedstatedir}/copr-rpmbuild
> install -d %{buildroot}%{_sharedstatedir}/copr-rpmbuild/results

There are lot of lines like this. Maybe it would be better to use %{name}
instead of typing the copr-rpmbuild over and over again?


> copr-rpmbuild.noarch: W: no-url-tag

Please add `Url:` tag with link to upstream URL


> copr-rpmbuild.noarch: E: wrong-script-interpreter /usr/bin/copr-rpmbuild 
> /usr/bin/env perl

AFAIK we should not use /usr/bin/env, but rather use e.g. /usr/bin/perl


> %description
> Provides command capable of running COPR build-task definitions.

Don't consider it as necessary, but I would like to see more information. I've
heard about this package on meetings and yet I hardly know what exactly it
does. I can imagine that people with no previous knowledge will not understand
it from such description either.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377038] Review Request: sxhkd - Simple X hotkey daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377038



--- Comment #18 from Fedora Update System  ---
sxhkd-0.5.7-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-824d1161bd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1384048] Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1384048



--- Comment #4 from David Hannequin  ---
Hi,

I fix naming :

Spec URL:
https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler.spec

SRPM URL:
https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-apscheduler-1.7.0-1.fc25.src.rpm

Could you approve this package ?

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377038] Review Request: sxhkd - Simple X hotkey daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377038



--- Comment #17 from Fedora Update System  ---
sxhkd-0.5.7-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-aef46593b7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1377038] Review Request: sxhkd - Simple X hotkey daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1377038

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #2 from Neal Gompa  ---
> rpkg.noarch: W: non-conffile-in-etc /etc/bash_completion.d/rpkg.bash

This should not be a config file, and this should not be in /etc. It should be
installed to `/usr/share/bash-completion/completions/`

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917

Jakub Kadlčík  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|jkadl...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460917] Review Request: rpkg - Command-line client tool to DistGit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460917

Jakub Kadlčík  changed:

   What|Removed |Added

 CC||jkadl...@redhat.com



--- Comment #1 from Jakub Kadlčík  ---
> Name: rpkg

Name of the package conflicts with already existing package.
https://admin.fedoraproject.org/pkgdb/package/rpms/rpkg/
May I suggest naming it rpkg-client as the upstream project names?


> BuildRequires: python-rpkg
> Requires: python-rpkg

There is no such package `python-rpkg`. Maybe you meant `python2-rpkg`?


> %if 0%{?fedora} >= 26
> ...
> %else
> BuildRequires: pyrpkg
> Requires: pyrpkg

python2-rpkg-1.49-3 which is even for F25 obsoletes pyrpkg < 1.49-2


> %description
> DistGit command-line client.

Can you please change the description text so it is not just a duplicate of
summary line?
I would also prefer more descriptive text. Using description from the first
comment in this BZ would be probably sufficient.


> Rpmlint
> ---
> Checking: rpkg-0.2-1.fc27.noarch.rpm
>   rpkg-0.2-1.fc27.src.rpm
> rpkg.noarch: W: non-conffile-in-etc /etc/bash_completion.d/rpkg.bash

Can you please mark the file as %config?
%config(noreplace) %{_sysconfdir}/bash_completion.d/rpkg.bash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388908] Review Request: python-Flask-Bootstrap - Python flask bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388908



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
The Summary cannot just repeat the package name. What about "
Ready-to-use Twitter-bootstrap for use in Flask" or my suggestion from comment
#c1?

There's a spurious whitespace at the beginning of %description, and the
terminating dot is missing.

http://github.com → https://github.com

This package bundles jquery and bootstrap. The license field must reflect this.
Also you need to add "Provides: bundled(bootstrap)", "Provides:
bundled(jquery)".

You must add %license LICENSE.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388908] Review Request: python-Flask-Bootstrap - Python flask bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388908



--- Comment #5 from David Hannequin  ---
Hi,

I fix naming issue : 

Spec URL:
https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-flask-bootstrap.spec

SRPM URL:
https://hvad.fedorapeople.org/fedora/python-Flask-Bootstrap/python-flask-bootstrap-3.3.7.0-1.fc25.src.rpm


Could you approved it ? 

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389404] Review Request: python-Flask-PyMongo - PyMongo support for Flask applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389404



--- Comment #4 from David Hannequin  ---
Hi Athos,

I fix naming and add tests :

Spec URL:
https://hvad.fedorapeople.org/fedora/python-Flask-PyMongo/python-flask-pymongo.spec

SRPM URL:
https://hvad.fedorapeople.org/fedora/python-Flask-PyMongo/python-flask-pymongo-0.5.1-1.fc25.src.rpm

I'll contact upstream. Could it pass anyway ? 

Best regard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382937] Review Request: python-dominate - Dominate is a Python library for HTML documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382937



--- Comment #8 from David Hannequin  ---
Any news ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

David Hannequin  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 CC||david.hanneq...@gmail.com
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #8 from David Hannequin  ---
Why 2 bug (Bug 1389346) for 1 package ???

What do you do ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389346] Review Request: python-testfixtures - A collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389346



--- Comment #6 from David Hannequin  ---
What do you do with this package ? Why open an other bug 1445824 ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library and BSD drop-in replacement for szlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #3 from Christoph Junghans  ---
(In reply to Igor Gnatenko from comment #2)
> Hmm, why am I on this review request?

Mainly because you are the hdf5 maintainer and I wanted to make you aware as
SZIP is an hdf thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1327635] Review Request: openstack-congress - OpenStack Congress Service

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327635
Bug 1327635 depends on bug 1418855, which changed state.

Bug 1418855 Summary: Review Request: python-PuLP - LP modeler written in python
https://bugzilla.redhat.com/show_bug.cgi?id=1418855

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library and BSD drop-in replacement for szlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #2 from Igor Gnatenko  ---
Hmm, why am I on this review request?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444428] Rename-Review Request: hardening-wrapper - Tool to check ELF for being built hardened

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=128



--- Comment #13 from Fedora Update System  ---
hardening-wrapper-2.6-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d40c1879cb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1461769] Review Request: module-macros - provides macros for module development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1461769



--- Comment #6 from Fedora Update System  ---
module-macros-0.1-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-00037c7e84

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org