[Bug 1421046] Review Request: deepin-go-lib - Go bindings for DDE development

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421046

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Some comments from #1421041 apply:
- "_" prefix in macro names is not necessary
- update to latest version (1.0.5 seems to be released)

> Group:  Development/Libraries
→ please remove
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

> %defattr(-,root,root,-)
Likewise.

Link to the guidelines: https://fedoraproject.org/wiki/PackagingDrafts/Go
(I think that's the right draft… Too bad this wasn't finalized.)

Unfortunately I don't know anything about go, so I cannot offer an opinion on
the go-specific packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421041] Review Request: deepin-gettext-tools - Deepin Gettext Tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421041

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
When linking to the spec file and srpm, link directly to the raw version
(https://raw.githubusercontent.com/FZUG/repo/master/rpms/deepin_project/deepin-gettext-tools.spec).
Otherwise fedora-review gets confused.

Why do you prefix your macros with "_"? Sometimes macros provided by rpm are
prefixed with "__" to avoid conflicts with user-defined macros. That's even
more reason not to prefix your macros like that.

I'm assuming that this is an effort to get the whole package set into Fedora,
not EPEL. If you are planning to use the same spec file also for EPEL, some
things will be more complicated. My comments below assume that this is for
Fedora only.

> %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from 
> distutils.sysconfig 

This shouldn't be necessary, %python2_sitelib is always defined when the
python2-devel is present.

>  - Package contains BR: python2-devel or python3-devel
@Felix: it's better to link to the relevant guidelines more often than not. In
this case: https://fedoraproject.org/wiki/Packaging:Python#Dependencies.

> BuildRequires: python-devel
... this should be either python2-devel or python3-devel.

Felix writes that Python3 is now supported. The guidelines say that Python3 is
preferred, so the package should be switched to it if possible.

> Requires: python
Normally that's not needed, because the dependency is generated automatically.

%description is too sparse. What does this package do? For "low level" packages
it's OK to just write on or two terse sentences, but just repeating %summary is
not enough, unless it's obvious (and in this case it's not obvious).

OK, so Requires are not generated properly, because the shebang lines use
#!/usr/bin/env. They should be changed to use #!/usr/bin/perl, #!%{__python2}
or #!%{__python3}. Then rpm will generate proper Requires automatically.

--

So... please update to the latest version, switch over to python3 if possible,
expand %description, fix shebang lines, and let rpm generate Requires
automatically.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

  Alias||review-astrometry



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470470] Review Request: astrometry-tycho2 - Tycho-2 catalogue for astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470470

Christian Dersch  changed:

   What|Removed |Added

 Blocks|1470436 |
 Depends On||1470436




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470436
[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of
arbitrary astronomical images
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Blocks||1470470
   ||(review-astrometry-tycho2)
 Depends On|1470470 |
   |(review-astrometry-tycho2)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470470
[Bug 1470470] Review Request: astrometry-tycho2 - Tycho-2 catalogue for
astrometry.net
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470470] Review Request: astrometry-tycho2 - Tycho-2 catalogue for astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470470

Christian Dersch  changed:

   What|Removed |Added

  Alias||review-astrometry-tycho2



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Depends On||1470470




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1470470
[Bug 1470470] Review Request: astrometry-tycho2 - Tycho-2 catalogue for
astrometry.net
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470470] Review Request: astrometry-tycho2 - Tycho-2 catalogue for astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470470

Christian Dersch  changed:

   What|Removed |Added

 Blocks||1470436, 115
   ||(Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1470436
[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of
arbitrary astronomical images
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470470] New: Review Request: astrometry-tycho2 - Tycho-2 catalogue for astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470470

Bug ID: 1470470
   Summary: Review Request: astrometry-tycho2 - Tycho-2 catalogue
for astrometry.net
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lupi...@mailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lupinix.fedorapeople.org/review/astrometry-tycho2.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/astrometry-tycho2-1.1.1-1.fc25.src.rpm

Description: Tycho-2 catalogue for the astrometry.net solver

Fedora Account System Username: lupinix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #21 from Fedora Update System  ---
fedrepo-req-0.1.9-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-9bb92313b4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #3 from Christian Dersch  ---
Note that fedora-review will complain about the should item "[!]: Uses parallel
make %{?_smp_mflags} macro." The handwritten Makefile from upstream does not
support parallel build very well and we get build issues then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #2 from Christian Dersch  ---
Licensing checked and updated, ready now.

Koji scratch build (rawhide):
https://koji.fedoraproject.org/koji/taskinfo?taskID=20484428

As a reference: Debian package where patches were taken from:
https://packages.debian.org/source/sid/astrometry.net

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470448] Review Request: php-simplesamlphp-saml2_3 - SAML2 PHP library from SimpleSAMLphp ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470448

Shawn Iwinski  changed:

   What|Removed |Added

  Alias||php-simplesamlphp-saml2_3



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470448] New: Review Request: php-simplesamlphp-saml2_3 - SAML2 PHP library from SimpleSAMLphp ( version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470448

Bug ID: 1470448
   Summary: Review Request: php-simplesamlphp-saml2_3 - SAML2 PHP
library from SimpleSAMLphp (version 3)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/258220f322a41eb3a50fa85dad830e086d849779/php-simplesamlphp-saml2_3/php-simplesamlphp-saml2_3.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-simplesamlphp-saml2_3-3.0.0-1.fc26.src.rpm

Description: 
A PHP library for SAML2 related functionality. Extracted from SimpleSAMLphp
[1],
used by OpenConext [2]. This library started as a collaboration between
UNINETT [3] and SURFnet [4] but everyone is invited to contribute.

[1] https://www.simplesamlphp.org/
[2] https://www.openconext.org/
[3] https://www.uninett.no/
[4] https://www.surfnet.nl/


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1409654] Review Request: python-pydocstyle - Python docstring style checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1409654



--- Comment #19 from Fedora Update System  ---
python-pydocstyle-2.0.0-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447

Shawn Iwinski  changed:

   What|Removed |Added

  Alias||php-robrichards-xmlseclibs3



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470447] New: Review Request: php-robrichards-xmlseclibs3 - A PHP library for XML Security (version 3)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470447

Bug ID: 1470447
   Summary: Review Request: php-robrichards-xmlseclibs3 - A PHP
library for XML Security (version 3)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/e0bf1c76abb250197e18dd0dce8a6628abd1e3fc/php-robrichards-xmlseclibs3/php-robrichards-xmlseclibs3.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-robrichards-xmlseclibs3-3.0.0-1.fc26.src.rpm

Description: 
xmlseclibs is a library written in PHP for working with XML Encryption and
Signatures.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436



--- Comment #1 from Christian Dersch  ---
NotReady means: Have to check the licensing in detail as there is also some GPL
code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1299139] Review Request: astrometry - Tools from Astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299139



--- Comment #35 from Christian Dersch  ---
Opened a new review based on your packaging effort, fixing some things like
conflicting names and unversioned soname.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)
 Whiteboard||NotReady




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Christian Dersch  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1299139



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1299139] Review Request: astrometry - Tools from Astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299139

Christian Dersch  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1470436



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470436] New: Review Request: astrometry - Blind astrometric calibration of arbitrary astronomical images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470436

Bug ID: 1470436
   Summary: Review Request: astrometry - Blind astrometric
calibration of arbitrary astronomical images
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lupi...@mailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lupinix.fedorapeople.org/review/astrometry.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/astrometry-0.72-0.1.fc25.src.rpm

Koji scratch build (rawhide):
https://koji.fedoraproject.org/koji/taskinfo?taskID=20483408

Description: The astrometry engine will take any image and return the
astrometry
world coordinate system (WCS), a standards-based description of the
transformation between image coordinates and sky coordinates.

Other tools included in the astrometry package can do much more, like
plotting astronomic information over solved images, convertion utilities
or generate statistics from FITS images.

Fedora Account System Username: lupinix

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662



--- Comment #10 from František Zatloukal  ---
SPEC:
https://copr-be.cloud.fedoraproject.org/results/frantisekz/fedora-developer-portal/fedora-25-x86_64/00578717-fedora-developer-portal/fedora-developer-portal.spec

I've added .desktop file checking and new description.

I've played with other options to kill jekyll but with no luck.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467322] Review Request: manifest-tool - A command line tool used for creating manifest list objects

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467322

Adam Miller  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Adam Miller  ---
+1 - I'm not going to block this while things are still up in the air on how
Fedora as a whole wants to handle this.

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #15 from Ilya Gradina  ---
I updated spec and removed BuildRequires: rubygem(backports):

srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-simple_oauth-0.3.1-3.fc26.src.rpm
spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-simple_oauth.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470358] Review Request: php-jms-serializer - Library for (de-) serializing data of any complexity

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470358

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1458576
   ||(phpdoc_v2_tracking)
  Alias||php-jms-serializer




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1458576
[Bug 1458576] v2 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470355] Review Request: php-zetacomponents-document - Provides a general conversion framework for different documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470355

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1458576
   ||(phpdoc_v2_tracking)
  Alias||php-zetacomponents-document




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1458576
[Bug 1458576] v2 tracking
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470358] New: Review Request: php-jms-serializer - Library for (de-) serializing data of any complexity

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470358

Bug ID: 1470358
   Summary: Review Request: php-jms-serializer - Library for
(de-)serializing data of any complexity
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/f463bb372674e9008c2ad6b11489e442898a73a3/php-jms-serializer/php-jms-serializer.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-jms-serializer-1.7.1-1.fc26.src.rpm

Description:
This library allows you to (de-)serialize data of any complexity. Currently, it
supports XML, JSON, and YAML.

It also provides you with a rich tool-set to adapt the output to your specific
needs.

Built-in features include:
* (De-)serialize data of any complexity; circular references are handled
  gracefully.
* Supports many built-in PHP types (such as dates)
* Integrates with Doctrine ORM, et. al.
* Supports versioning, e.g. for APIs
* Configurable via PHP, XML, YAML, or Doctrine Annotations


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470355] New: Review Request: php-zetacomponents-document - Provides a general conversion framework for different documents

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470355

Bug ID: 1470355
   Summary: Review Request: php-zetacomponents-document - Provides
a general conversion framework for different documents
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/e64688703e8cae1a9f6fc06b9289cb32749c5eca/php-zetacomponents-document/php-zetacomponents-document.spec

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-zetacomponents-document-1.3.1-1.fc26.src.rpm

Description:
The document component offers transformations between different semantic markup
languages, like:
* ReStructured text
* XHTML
* Docbook
* eZ Publish XML markup
* Wiki markup languages, like: Creole, Dokuwiki and Confluence
* Open Document Text as used by OpenOffice.org and other office suites

Each format supports conversions from and to docbook as a central intermediate
format and may implement additional shortcuts for conversions from and to other
formats. Not each format can express the same semantics, so there may be some
information lost.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #14 from Ilya Gradina  ---
Thx, for review.

I have a few questions.

1. "Use Fedora 27 dist tag to create srpm"
  - Why can not I use 26?

2. "Add `ruby` BuildRequire to ensure MRI is used for tests."
  - What did you mean? "BuildRequires: ruby(release)" - already available.

3. "Move all `%exclude` macros to main package"
  - you meant all `%exclude` macros move to section %files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468766] Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468766



--- Comment #12 from Fedora Update System  ---
openzwave-1.4.164-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-959b609e7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #20 from Fedora Update System  ---
fedrepo-req-0.1.9-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cc9edfb024

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470330] New: Review Request: nyx - Terminal status monitor for Tor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470330

Bug ID: 1470330
   Summary: Review Request: nyx - Terminal status monitor for Tor
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: j.orti.alca...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jorti.fedorapeople.org/nyx/nyx.spec
SRPM URL:
https://jorti.fedorapeople.org/nyx/nyx-1.4.6-2.20170712git08eec6f.fc26.src.rpm
Description: The anonymizing relay monitor (nyx) is a terminal status monitor
for Tor relays,
intended for command-line aficionados, ssh connections, and anyone with a tty
terminal. This works much like top does for system usage, providing real time
statistics for:

 - bandwidth, CPU, and memory usage
 - relay's current configuration
 - logged events
 - connection details (IP, host name, fingerprint, and consensus data)
 - etc.

Fedora Account System Username: jorti

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350884



--- Comment #12 from Brandon Nielsen  ---
New spec URL:
https://bitbucket.org/nielsenb/mspgcc-fedora/raw/d0f1b3ccb1611c8adf5aacf0f63e2681d9d5/msp430-elf-toolchain.spec

New SRPM URL:
https://bitbucket.org/nielsenb/mspgcc-fedora/downloads/msp430-elf-toolchain-5.0.0.0-1.src.rpm

(In reply to Elliott Sales de Andrade from comment #11)
> Bit weird that it's version 5.0.0, but 6.2.1 of gcc (and presumably some
> other
> version of the other tools). Not sure what should be done about that.
> 

I agree, their versioning scheme is incredibly confusing. Doubly so since they
changed from the Red Hat developed SDK to the new SOMNIUM one, some version
numbers have actually gone backwards. Since we haven't had the packages in
Fedora, it hasn't been an issue, but it did break my Copr for awhile until I
noticed. I'm not really positive which upstream we should use version numbers
for, upstream's upstream (GCC), or just upstream (SOMNIUM).

> Minor things out of the spec: Group tag and %defattr are no longer needed;
> g++ stuff should be its own subpackage, no?
> 

Got rid of the group tag and %defattr. g++ stuff was included in the now dead
msp430-gcc, I started out trying to match that as much as possible. I'm open to
changing it. Do you know of an example I could look at?

> Some issues I see out of fedora-review:
> 
> - Provides: bundled(gnulib) in place as required.
>   Note: Bundled gnulib but no Provides: bundled(gnulib)
>   See:
>  
> http://fedoraproject.org/wiki/Packaging:
> No_Bundled_Libraries#Requirement_if_you_bundle
> 

Fixed (I think). The bundled(gnulib) needs to be versioned, but which version
do I specify?

> - Package does not contain any libtool archives (.la)
>   Note: msp430-elf-gcc :
>   /usr/lib64/gcc/msp430-elf/6.2.1/plugin/libcc1plugin.la msp430-elf-gcc :
>   /usr/libexec/gcc/msp430-elf/6.2.1/liblto_plugin.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/430/libssp.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/430/libssp_nonshared.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/430/libstdc++.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/430/libsupc++.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/large/libssp.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/large/libssp_nonshared.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/large/libstdc++.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/large/libsupc++.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/libssp.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/libssp_nonshared.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/libstdc++.la msp430-elf-gcc :
>   /usr/msp430-elf/lib/libsupc++.la
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
> 

Fixed.

> - SHOULD items: Generic:
> [!]: Uses parallel make %{?_smp_mflags} macro.
> [!]: Sources can be downloaded from URI in Source: tag
>  Note: Could not download Source0: http://software-
> 
> dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/latest/exports/msp430-
> gcc-6.2.1
>  .16_source-full.tar.bz2
>  See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
> 

I now use parallel make, the download link works for me, so not sure what to
make of that.

> These match gcc, so probably fine, but I did not check every file:
> - Header files in -devel subpackage, if present.
> - Static libraries in -static or -devel subpackage, providing -devel if
>   present.
>   Note: Package has .a files: msp430-elf-gcc. Illegal package name:
> msp430-elf-gcc. Does not provide -static: msp430-elf-gcc.
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries
> 

Anything specific I should do to address these? I'm particular worried about
the illegal package name, especially since we've already looked at naming once.

> Possibly relevant things from rpmlint:
> msp430-elf-toolchain-debuginfo.x86_64: E: debuginfo-without-sources
> msp430-elf-gcc.x86_64: W: obsolete-not-provided msp430-gcc
> msp430-elf-toolchain.src:42: W: unversioned-explicit-obsoletes msp430-gcc
>

I don't see the debuginfo-without-sources warning on my system.

msp430-gcc isn't packaged in Fedora 26, and I used an unversioned obsolete
since this supersedes msp430-gcc in every way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468766] Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468766

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
openzwave-1.4.164-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e568d4629e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #19 from Fedora Update System  ---
fedrepo-req-0.1.9-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ceb22cc89a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #18 from Fedora Update System  ---
fedrepo-req-0.1.9-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2b2a87e5eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360



--- Comment #13 from Pavel Valena  ---
Package Review
==

Please solve the following issues

 Issues 
 - README.md and CONTRIBUTING.md should be in `doc` subpackage.
 - Release should be 1 (also remove changelog entries)
 - Move all `%exclude` macros to main package
 - Include Gemfile and Rakefile in `doc` subpackage
 - Add `ruby` BuildRequire to ensure MRI is used for tests.
 - Use Fedora 27 dist tag to create srpm
 - Remove rubygem(backports) BuildRequire, as it's intended for package to work
with older version of ruby


= MUST items =
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =
[x]: Avoid bundling fonts in non-fonts packages.
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1468766] Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468766

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1468766] Review Request: openzwave - OpenZWave is a library to support for Z-Wave home-automation devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1468766



--- Comment #10 from Fedora Update System  ---
openzwave-1.4.164-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-959b609e7d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-XML-LibXML-PrettyPrint-0.006-1.fc27.noarch.rpm | sort
| uniq -c
  1 perl(Carp) >= 0
  1 perl(constant)
  1 perl(Exporter::Tiny)
  1 perl(IO::Handle) >= 0
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(Scalar::Util) >= 0
  1 perl(strict)
  1 perl(utf8)
  1 perl(:VERSION) >= 5.8.1
  1 perl(warnings)
  1 perl(XML::LibXML) >= 1.62
  1 perl(XML::LibXML::PrettyPrint)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
  1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-XML-LibXML-PrettyPrint-0.006-1.fc27.noarch.rpm | sort
| uniq -c
  1 perl(XML::LibXML::PrettyPrint) = 0.006
  1 perl-XML-LibXML-PrettyPrint = 0.006-1.fc27
Binary provides are Ok.

$ rpmlint ./perl-XML-LibXML-PrettyPrint*
perl-XML-LibXML-PrettyPrint.noarch: W: invalid-license Artistic
perl-XML-LibXML-PrettyPrint.src: W: invalid-license Artistic
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok (It seems the license is not processed properly)

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to František Zatloukal from comment #8)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> > If you are still looking for a sponsor, I can do it — let me know if you are
> > interested.
> Sure, thanks!
> 
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> > It would be great if you could do (informal) reviews of two or three other 
> > packages from http://fedoraproject.org/PackageReviewStatus/NEW.html.
> Ok, I can try it, should I just add comments with review and nothing else?
Yes, look at the spec file and try to find issue and stuff that is wrong
according to the guidelines. It's also good to run fedora-review (it's very
strongly encouraged, especially if you're new to reviews), and look at all
the stuff it says. That gives you a very good idea of what to check for.
fedora-review builds the package in mock, and that is useful to verify
that build dependencies are not missing.

> I should have additional review requests ready by tomorrow if there are not
> many issues (I am not very experienced packager after all... :) ).
Great.

> 
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> > jekyll serve &
> > ...
> > kill $!
> 
> This didn't work (kill tried to kill completely different pid, not sure why
> though). But this is working just fine:
> jekyll serve --detach
> pkill -f jekyll
That's not idea, all solutions which grep the global process list are wrong.
Consider the case where you're doing two parallel builds in mock for amd64 and
i386 on the same machine: there are two jykylls running.

But OK, upload the latest spec file you have, and I'll see if I can patch it
to use $!. Otherwise we can ask for help on fedora-devel… I expect people to
have
had the same issue, e.g. in tests.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal - Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |fedora-developer-portal-|fedora-developer-portal -
   |Offline Fedora Developer|Offline Fedora Developer
   |Portal  |Portal



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469479] Review Request: perl-Locale-Utils-PlaceholderBabelFish - Utils to expand BabelFish placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469479

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Locale-Utils-Placehold
   ||erBabelFish-0.004-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-07-12 07:25:20



--- Comment #3 from Jitka Plesnikova  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469531] Review Request: perl-Locale-Utils-PlaceholderMaketext - Utils to expand maketext placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469531

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Locale-Utils-Placehold
   ||erMaketext-1.003-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-07-12 07:12:15



--- Comment #3 from Jitka Plesnikova  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1470057] New: Review Request: perl-Locale-Utils-PlaceholderNamed - Utils to expand named placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1470057

Bug ID: 1470057
   Summary: Review Request: perl-Locale-Utils-PlaceholderNamed -
Utils to expand named placeholders
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jples...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jplesnik.fedorapeople.org/perl-Locale-Utils-PlaceholderNamed/perl-Locale-Utils-PlaceholderNamed.spec
SRPM URL:
https://jplesnik.fedorapeople.org/perl-Locale-Utils-PlaceholderNamed/perl-Locale-Utils-PlaceholderNamed-1.002-1.fc27.src.rpm

Description:
This module provides utils to expand named placeholders.

Fedora Account System Username: jples...@redhat.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469479] Review Request: perl-Locale-Utils-PlaceholderBabelFish - Utils to expand BabelFish placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469479



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Locale-Utils-PlaceholderBabelFish

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469531] Review Request: perl-Locale-Utils-PlaceholderMaketext - Utils to expand maketext placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469531



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Locale-Utils-PlaceholderMaketext

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1341662] Review Request: fedora-developer-portal- Offline Fedora Developer Portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341662



--- Comment #8 from František Zatloukal  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> If you are still looking for a sponsor, I can do it — let me know if you are
> interested.
Sure, thanks!

(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> It would be great if you could do (informal) reviews of two or three other 
> packages from http://fedoraproject.org/PackageReviewStatus/NEW.html.
Ok, I can try it, should I just add comments with review and nothing else?

I should have additional review requests ready by tomorrow if there are not
many issues (I am not very experienced packager after all... :) ).

(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> jekyll serve &
> ...
> kill $!

This didn't work (kill tried to kill completely different pid, not sure why
though). But this is working just fine:
jekyll serve --detach
pkill -f jekyll

Is this solution better? I'll upload updated SPEC later today.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268360] Review Request: rubygem-simple_oauth - Simply builds and verifies OAuth headers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268360

Pavel Valena  changed:

   What|Removed |Added

  Flags|needinfo?(pval...@redhat.co |
   |m)  |



--- Comment #12 from Pavel Valena  ---
Sorry, I was a bit busy.

I'll review it now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469404] Review Request: perl-Locale-TextDomain-OO-Util - Lexical Utils for Locale::TextDomain::OO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469404

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Locale-TextDomain-OO-U
   ||til-3.006-1.fc27
 Resolution|--- |RAWHIDE
Last Closed||2017-07-12 06:25:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags|needinfo?(dominik@greysecto |
   |r.net)  |



--- Comment #14 from Dominik 'Rathann' Mierzejewski  ---
Thanks for the comments, Miro. I'll address them soon.

(In reply to Miro Hrončok from comment #13)
> (In reply to Germano Massullo from comment #11)
> > And another thing. Please remove the big comment block at the beginning of
> > spec file, because LICENSE file is the proper place to insert licensing 
> > stuff
> 
> I would think of that comment block as a license for the specfile itself,
> not the package content. This is not forbidden in Fedora.

That's correct. Also, I wanted to minimize divergence from RHEL spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1421413] Review Request: sysusage - System monitoring based on perl, rrdtool, and sysstat

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1421413

Marek Cermak  changed:

   What|Removed |Added

 CC||macer...@redhat.com
   Assignee|nob...@fedoraproject.org|macer...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1321449] Review Request: python-sshtunnel - SSH tunnels to remote server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321449

Marek Cermak  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #6 from Marek Cermak  ---

Initial fedora-review output 


+ py.test-2 -v tests/
= test session starts
==
platform linux2 -- Python 2.7.13, pytest-3.1.1, py-1.4.34, pluggy-0.4.0 --
/usr/bin/python2

tests/test_forwarder.py::SSHClientTest::test_connect_via_proxy FAILED
ts/test_forwarder.py::SSHClientTest::test_deprecate_warnings_are_shown FAILED
tests/test_forwarder.py::AuxiliaryTest::test_read_ssh_config FAILED

= FAILURES ===

_ SSHClientTest.test_connect_via_proxy
_


E   OSError: [Errno 2] No such file or directory
/usr/lib64/python2.7/subprocess.py:1024: OSError


___ SSHClientTest.test_deprecate_warnings_are_shown



E   IndexError: list index out of range
tests/test_forwarder.py:656: IndexError


__ AuxiliaryTest.test_read_ssh_config
__

E   AssertionError: None is not true
tests/test_forwarder.py:1183: AssertionError

=== 3 failed, 40 passed, 1 xpassed in 20.43 seconds



+ py.test-3 -v tests/
= test session starts
==
platform linux -- Python 3.6.1, pytest-3.1.1, py-1.4.34, pluggy-0.4.0 --
/usr/bin/python3

tests/test_forwarder.py::SSHClientTest::test_connect_via_proxy FAILED
tests/test_forwarder.py::SSHClientTest::test_gateway_ip_unresolvable_raises_exception
FAILED
tests/test_forwarder.py::AuxiliaryTest::test_read_ssh_config FAILED

=== FAILURES
===

_ SSHClientTest.test_connect_via_proxy
_

E   FileNotFoundError: [Errno 2] No such file or directory: 'ssh'
/usr/lib64/python3.6/subprocess.py:1326: FileNotFoundError


_ SSHClientTest.test_gateway_ip_unresolvable_raises_exception
__

Unexpected success


__ AuxiliaryTest.test_read_ssh_config
__

E   AssertionError: None is not true
tests/test_forwarder.py:1183: AssertionError

= 3 failed, 41 passed in 15.79 seconds
=


RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.Py7mcD (%check)
Bad exit status from /var/tmp/rpm-tmp.Py7mcD (%check)


Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/mockbuild/trace_decorator.py", line
96, in trace
result = func(*args, **kw)
  File "/usr/lib/python3.6/site-packages/mockbuild/util.py", line 590, in do
raise exception.Error("Command failed: \n # %s\n%s" % (command, output),
child.returncode)
mockbuild.exception.Error: Command failed:
 # /usr/bin/systemd-nspawn -q -M eea7d073d1694b8093e8b911268aa8b6 -D
/var/lib/mock/fedora-rawhide-x86_64/root -a --private-network
--setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/builddir
--setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin
--setenv=PROMPT_COMMAND=printf "\033]0;\007"
--setenv=PS1= \s-\v\$  --setenv=LANG=en_US.UTF-8 -u mockbuild bash
--login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps
/builddir/build/SPECS/python-sshtunnel.spec


-


Modified spec file to bypass %check errors in such manner that: 
=

$ diff python-sshtunnel.spec.old python-sshtunnel.spec
63c63
< py.test-3 -v tests/ 
---
> py.test-3 -v tests/ || :

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 20 files have
 unknown license. Detailed output of licensecheck in
 /home/macermak/RedHat/Fedora/Reviews/1321449/review-python-
 sshtunnel/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in 

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171



--- Comment #13 from Miro Hrončok  ---
(In reply to Germano Massullo from comment #11)
> And another thing. Please remove the big comment block at the beginning of
> spec file, because LICENSE file is the proper place to insert licensing stuff

I would think of that comment block as a license for the specfile itself, not
the package content. This is not forbidden in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #17 from Fedora Update System  ---
fedrepo-req-0.1.8-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-433da57bca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462472



--- Comment #9 from Fedora Update System  ---
qotd-0.11.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-2156b74af7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171



--- Comment #12 from Miro Hrončok  ---
See bz1470013

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #9 from Fedora Update System  ---
xoreos-tools-0.0.4-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f4ad70a91d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Germano Massullo  changed:

   What|Removed |Added

 CC||domi...@greysector.net
  Flags|needinfo?(germano.massullo@ |needinfo?(dominik@greysecto
   |gmail.com)  |r.net)



--- Comment #11 from Germano Massullo  ---
Ok so I wait for a new spec/srpm before proceeding.
And another thing. Please remove the big comment block at the beginning of spec
file, because LICENSE file is the proper place to insert licensing stuff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171



--- Comment #10 from Miro Hrončok  ---
Several other notes:

 * please use %py2_build and %py2_install, they are available on EPEL 6
 * while not necessary in EPEL6, please also provide python2-antlr to make it
easier if someone want's to require this on Both Fedora an EPEL in the future

Also, I realize that antlr-python is in Fedora as a subpackage of antlr, so you
use the same name, but that name is wrong. Feel free to provide it to make it
easier for others.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1189171] Review Request: antlr-python - Python runtime support for ANTLR-generated parsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189171

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #9 from Miro Hrončok  ---
Note that this should be called python-antlr, not antlr-python.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469331] Review Request: fedrepo-req - A CLI tool that provides an easy way to submit ticket requests for packaging tasks in Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469331



--- Comment #16 from Fedora Update System  ---
fedrepo-req-0.1.8-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e0e4e786b5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465676] Review Request: mingw-graphite2 - MinGW Windows graphite2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465676

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
mingw-graphite2-1.3.10-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b735e572b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1463797] Review Request: nodejs-irc-colors - Color and formatting for irc made easy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1463797

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
nodejs-irc-colors-1.3.3-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ff0e626a10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1463821] Review Request: nodejs-simple-markdown - Javascript markdown parsing, made simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1463821

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
nodejs-simple-markdown-0.2.1-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e72aded7ea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1461368] Review Request: mingw-pcre2 - MinGW Windows pcre2 library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1461368

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
mingw-pcre2-10.23-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6880e59ec3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462472] Review Request: qotd - A simple and lightweight Quote of the Day daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462472



--- Comment #8 from Fedora Update System  ---
qotd-0.11.3-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8ae3c81d37

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465588] Review Request: xoreos-tools - Tools to help the development of xoreos

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465588



--- Comment #8 from Fedora Update System  ---
xoreos-tools-0.0.4-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d5a8491e46

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469531] Review Request: perl-Locale-Utils-PlaceholderMaketext - Utils to expand maketext placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469531

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-256:
6429220659169c1e2172d61f9ca26335bc55ca0e0e5933fbfef60b8548fd55fa) is original.
Ok.
Summary verified from lib/Locale/Utils/PlaceholderMaketext.pm. Ok.
Description verified from lib/Locale/Utils/PlaceholderMaketext.pm. Ok.
License verified from lib/Locale/Utils/PlaceholderMaketext.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
Test::Exception and Test::Perl::Critic and Test::Prereq::Build not used. Ok.
All tests pass. Ok.

$ rpmlint perl-Locale-Utils-PlaceholderMaketext.spec
../SRPMS/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.src.rpm
../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm 
perl-Locale-Utils-PlaceholderMaketext.src: W: spelling-error Summary(en_US)
maketext -> make text, make-text, marketer
perl-Locale-Utils-PlaceholderMaketext.src: W: spelling-error %description -l
en_US maketext -> make text, make-text, marketer
perl-Locale-Utils-PlaceholderMaketext.src: W: spelling-error %description -l
en_US gettext -> get text, get-text, Georgette
perl-Locale-Utils-PlaceholderMaketext.noarch: W: spelling-error Summary(en_US)
maketext -> make text, make-text, marketer
perl-Locale-Utils-PlaceholderMaketext.noarch: W: spelling-error %description -l
en_US maketext -> make text, make-text, marketer
perl-Locale-Utils-PlaceholderMaketext.noarch: W: spelling-error %description -l
en_US gettext -> get text, get-text, Georgette
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm 
drwxr-xr-x2 rootroot0 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext
-rw-r--r--1 rootroot  696 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/Changes
-rw-r--r--1 rootroot  751 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/README
drwxr-xr-x2 rootroot0 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example
-rw-r--r--1 rootroot  851 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/01_maketext_to_gettext.pl
-rw-r--r--1 rootroot  793 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/02_gettext_to_maketext.pl
-rw-r--r--1 rootroot 2570 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/11_expand_maketext.pl
-rw-r--r--1 rootroot 1321 Jul 12 10:25
/usr/share/doc/perl-Locale-Utils-PlaceholderMaketext/example/12_expand_gettext.pl
-rw-r--r--1 rootroot 3022 Jul 12 10:25
/usr/share/man/man3/Locale::Utils::PlaceholderMaketext.3pm.gz
drwxr-xr-x2 rootroot0 Jul 12 10:25
/usr/share/perl5/vendor_perl/Locale
drwxr-xr-x2 rootroot0 Jul 12 10:25
/usr/share/perl5/vendor_perl/Locale/Utils
-rw-r--r--1 rootroot11295 Feb 24 14:28
/usr/share/perl5/vendor_perl/Locale/Utils/PlaceholderMaketext.pm
File layout and Permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(Carp)
  1 perl(Moo) >= 1.003001
  1 perl(MooX::StrictConstructor)
  1 perl(MooX::Types::MooseLike::Base)
  1 perl(namespace::autoclean)
  1 perl(Scalar::Util)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(Locale::Utils::PlaceholderMaketext) = 1.003
  1 perl-Locale-Utils-PlaceholderMaketext = 1.003-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Locale-Utils-PlaceholderMaketext-1.003-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

The package builds in F27
(https://koji.fedoraproject.org/koji/taskinfo?taskID=20472804). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1469531] Review Request: perl-Locale-Utils-PlaceholderMaketext - Utils to expand maketext placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469531

Petr Pisar  changed:

   What|Removed |Added

 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469479] Review Request: perl-Locale-Utils-PlaceholderBabelFish - Utils to expand BabelFish placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469479

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Petr Pisar  ---
URL and Source0 addresses are Ok.
Source0 archive (SHA-256:
ae54eeb899c81abbdc6188205e8067dcb52f5862fca79d297e1091f24f95) is original.
Ok.
Summary verified from lib/Locale/Utils/PlaceholderBabelFish.pm. Ok.
Description verified from lib/Locale/Utils/PlaceholderBabelFish.pm. Ok.
License verified from lib/Locale/Utils/PlaceholderBabelFish.pm and README. Ok.
No XS code, noarch BuildArch is Ok.
Test::Perl::Critic and Test::Prereq::Build not used. Ok.
All tests pass. Ok.

$ rpmlint perl-Locale-Utils-PlaceholderBabelFish.spec
../SRPMS/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.src.rpm
../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm 
drwxr-xr-x2 rootroot0 Jul 12 09:18
/usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish
-rw-r--r--1 rootroot  400 Jul 12 09:18
/usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/Changes
-rw-r--r--1 rootroot  668 Jul 12 09:18
/usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/README
drwxr-xr-x2 rootroot0 Jul 12 09:18
/usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/example
-rw-r--r--1 rootroot 2560 Jul 12 09:18
/usr/share/doc/perl-Locale-Utils-PlaceholderBabelFish/example/01_expand_babel_fish.pl
-rw-r--r--1 rootroot 2856 Jul 12 09:18
/usr/share/man/man3/Locale::Utils::PlaceholderBabelFish.3pm.gz
drwxr-xr-x2 rootroot0 Jul 12 09:18
/usr/share/perl5/vendor_perl/Locale
drwxr-xr-x2 rootroot0 Jul 12 09:18
/usr/share/perl5/vendor_perl/Locale/Utils
-rw-r--r--1 rootroot 9062 Feb 24 08:05
/usr/share/perl5/vendor_perl/Locale/Utils/PlaceholderBabelFish.pm
File layout and permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.0)
  1 perl(Carp)
  1 perl(HTML::Entities)
  1 perl(List::Util)
  1 perl(Moo) >= 1.003001
  1 perl(MooX::StrictConstructor)
  1 perl(MooX::Types::MooseLike::Base)
  1 perl(namespace::autoclean)
  1 perl(Scalar::Util)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm |
sort -f | uniq -c
  1 perl(Locale::Utils::PlaceholderBabelFish) = 0.004
  1 perl-Locale-Utils-PlaceholderBabelFish = 0.004-1.fc27
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-Locale-Utils-PlaceholderBabelFish-0.004-1.fc27.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F27
(https://koji.fedoraproject.org/koji/taskinfo?taskID=20472052). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467716] Review Request: reactfx - Reactive event streams for JavaFX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467716



--- Comment #6 from Jonny Heggheim  ---
There is one issue that have been brought up at bug 1145303#133

openjfx is only building for x86 and x86_64 for now, reactfx is noarch, so it
will fail on building on non Intel architecture.

Do you have any suggestion?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467716] Review Request: reactfx - Reactive event streams for JavaFX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467716



--- Comment #5 from Jonny Heggheim  ---
(In reply to Raphael Groner from comment #2)
> Are you interested in a review swap? Maybe you can take a look into bug #.
> 
> Some general hints:
> - Why disable tests completely? I can find one test only that needs the
> com.pholser dependencies, you should disable this single test instead:
> reactfx/src/test/java/org/reactfx/util/SparseListTest.java
I did think about that, thanks.


> - Please provide a changelog:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
Ups

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1467716] Review Request: reactfx - Reactive event streams for JavaFX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1467716



--- Comment #4 from Jonny Heggheim  ---
(In reply to Raphael Groner from comment #3)
> Are you interested in a review swap? Maybe you can take a look into bug
> #1462466.

Sure, I will review it during the weekend

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469479] Review Request: perl-Locale-Utils-PlaceholderBabelFish - Utils to expand BabelFish placeholders

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469479

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951



--- Comment #2 from Petr Pisar  ---
Updated package is on the same address.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Jitka Plesnikova  changed:

   What|Removed |Added

 CC||jples...@redhat.com



--- Comment #1 from Jitka Plesnikova  ---
perl-generators are missing in BR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1465889] Tracking: Deepin Desktop related package review tracker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1465889

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1469951




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1469951
[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant
white space to an XML tree
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1465889
   ||(DeepinDEPackageReview)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1465889
[Bug 1465889] Tracking: Deepin Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1469951] New: Review Request: perl-XML-LibXML-PrettyPrint - Add pleasant white space to an XML tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1469951

Bug ID: 1469951
   Summary: Review Request: perl-XML-LibXML-PrettyPrint - Add
pleasant white space to an XML tree
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-XML-LibXML-PrettyPrint/perl-XML-LibXML-PrettyPrint.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-XML-LibXML-PrettyPrint/perl-XML-LibXML-PrettyPrint-0.006-1.fc27.src.rpm
Description:
XML::LibXML::PrettyPrint is a Perl module that can be applied to an
XML::LibXML DOM tree to reformat it into a more readable result.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org