[Bug 1517006] Review Request: vimiv - An image viewer with vim-like keybindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517006

Christoph Junghans  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jungh...@votca.org
   Assignee|nob...@fedoraproject.org|jungh...@votca.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517006] New: Review Request: vimiv - An image viewer with vim-like keybindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517006

Bug ID: 1517006
   Summary: Review Request: vimiv - An image viewer with vim-like
keybindings
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sanjay.an...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ankursinha.fedorapeople.org/vimiv/vimiv.spec
SRPM URL: https://ankursinha.fedorapeople.org/vimiv/vimiv-0.9.1-1.fc27.src.rpm

Description: 
Vimiv is an image viewer with vim-like keybindings. It is written in python3
using the Gtk3 toolkit. Some of the features are:

- Thumbnail mode
- Simple library browser
- Basic image editing
- Command line with tab completion


Fedora Account System Username: ankursinha

There's a COPR for people to try out the package here:
https://copr.fedorainfracloud.org/coprs/ankursinha/vimiv/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1517000] New: Review Request: rubygem-notiffany - Notifier library ( extracted from Guard project)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517000

Bug ID: 1517000
   Summary: Review Request: rubygem-notiffany - Notifier library
(extracted from Guard project)
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jar.pro...@volny.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gitlab.com/jackorp/rubygem-notiffany/raw/63e0ce06aa54d93afcb17c5f7f93ced67463e90b/rubygem-notiffany.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/jackorp/rubygem-notiffany/fedora-rawhide-x86_64/00678843-rubygem-notiffany/rubygem-notiffany-0.1.1-1.fc28.src.rpm
Description: Wrapper libray for most popular notification
libraries such as Growl, Libnotify, Notifu.
Fedora Account System Username: jackorp
Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=23323650

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696
Bug 1268696 depends on bug 1268695, which changed state.

Bug 1268695 Summary: Review Request: rubygem-guard-compat - Tools for 
developing Guard compatible plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1268695

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268696

Ilya Gradina  changed:

   What|Removed |Added

 Depends On||1516328




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1516328
[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing
Guard compatible plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516328

Ilya Gradina  changed:

   What|Removed |Added

 Blocks||1268696
 CC||ilya.grad...@gmail.com



--- Comment #2 from Ilya Gradina  ---
*** Bug 1268695 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1268696
[Bug 1268696] Review Request: rubygem-guard-rspec - Guard gem for RSpec
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268695] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268695

Ilya Gradina  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2017-11-23 13:14:17



--- Comment #3 from Ilya Gradina  ---


*** This bug has been marked as a duplicate of bug 1516328 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268695] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268695



--- Comment #2 from Ilya Gradina  ---
Hi Vit,

Yes, I don't mind to give the package to Jaroslav.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506986] Review Request: mld2p4 - MultiLevel Domain Decomposition Parallel Preconditioners Package based on PSBLAS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506986

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506986] Review Request: mld2p4 - MultiLevel Domain Decomposition Parallel Preconditioners Package based on PSBLAS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506986



--- Comment #5 from Fedora Update System  ---
MUMPS-5.1.2-2.fc26 coin-or-Ipopt-3.12.8-5.fc26 mld2p4-2.1.0-5.fc26
petsc-3.8.1-1.fc26 petsc4py-3.8.1-1.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-afb986beb4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630

Hans de Goede  changed:

   What|Removed |Added

  Flags|needinfo?(hdegoede@redhat.c |
   |om) |



--- Comment #37 from Hans de Goede  ---
(In reply to Neal Gompa from comment #36)
> Hans,
> 
> Any news on vboxguest and vboxsf?

Actually I send a mail this morning asking another kernel developer if he would
be willing to help me out by reviewing the vboxguest driver, if he says yes
then I'm going to ask the misc. subsys maintainers if that works for them.
TL;DR: still in upstream review process limbo I'm afraid.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630

Neal Gompa  changed:

   What|Removed |Added

  Flags||needinfo?(hdegoede@redhat.c
   ||om)



--- Comment #36 from Neal Gompa  ---
Hans,

Any news on vboxguest and vboxsf?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373007] Review Request: rubygem-cool.io - A cool framework for doing high performance I/O in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373007

Sandro Bonazzola  changed:

   What|Removed |Added

External Bug ID||RDO 10683
 Blocks||1460625 (oVirt_on_Fedora)
  Flags||needinfo?(mru...@redhat.com
   ||)



--- Comment #2 from Sandro Bonazzola  ---
rebase on upstream 1.5.3
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sbonazzo/ovirt-fluentd/rubygem-cool.io.git/plain/rubygem-cool.io.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/ovirt-fluentd/fedora-rawhide-x86_64/00678787-rubygem-cool.io/rubygem-cool.io-1.5.3-1.fc28.src.rpm

Also pushed to https://review.rdoproject.org/r/#/c/10683/
Matthias, can you please review?


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1460625
[Bug 1460625] [Tracker] Fedora support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373004] Review Request: rubygem-tzinfo-data - Timezone Data for TZInfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373004

Matthias Runge  changed:

   What|Removed |Added

  Flags|needinfo?(mru...@redhat.com |
   |)   |



--- Comment #4 from Matthias Runge  ---
For requirements discussion, see 
https://github.com/fluent/fluentd/issues/1761

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1373004] Review Request: rubygem-tzinfo-data - Timezone Data for TZInfo

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1373004

Sandro Bonazzola  changed:

   What|Removed |Added

 CC||mru...@redhat.com,
   ||rmegg...@redhat.com
External Bug ID||RDO 10682
 Blocks||1460625 (oVirt_on_Fedora)
  Flags||needinfo?(mru...@redhat.com
   ||)



--- Comment #3 from Sandro Bonazzola  ---
Bump to 1.2017.3
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sbonazzo/ovirt-fluentd/rubygem-tzinfo-data.git/plain/rubygem-tzinfo-data.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/ovirt-fluentd/fedora-rawhide-x86_64/00678783-rubygem-tzinfo-data/rubygem-tzinfo-data-1.2017.3-1.fc28.src.rpm

Matthias can you please review?
Also pushed to https://review.rdoproject.org/r/#/c/10682/


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1460625
[Bug 1460625] [Tracker] Fedora support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Sandro Bonazzola  changed:

   What|Removed |Added

 Blocks||1460625 (oVirt_on_Fedora)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1460625
[Bug 1460625] [Tracker] Fedora support
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Sandro Bonazzola  changed:

   What|Removed |Added

External Bug ID||RDO 10681
  Flags||needinfo?(mru...@redhat.com
   ||)



--- Comment #20 from Sandro Bonazzola  ---
Matthias can you please review?
Also pushed to https://review.rdoproject.org/r/#/c/10681/

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351



--- Comment #19 from Sandro Bonazzola  ---
Bumped to 1.3.1.
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sbonazzo/ovirt-fluentd/rubygem-yajl-ruby.git/tree/rubygem-yajl-ruby.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/ovirt-fluentd/fedora-rawhide-x86_64/00678767-rubygem-yajl-ruby/rubygem-yajl-ruby-1.3.1-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1516328] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1516328

Vít Ondruch  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1268695



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268695] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268695

Vít Ondruch  changed:

   What|Removed |Added

 CC||vondr...@redhat.com



--- Comment #1 from Vít Ondruch  ---
Hi Ilya,

Are you still interested in this review? I am asking because there is now
opened duplicate review request in bug 1516328 ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1268695] Review Request: rubygem-guard-compat - Tools for developing Guard compatible plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268695

Vít Ondruch  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1516328



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1368855] Review Request: radare2 - The reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368855



--- Comment #23 from Lubomir Rintel  ---
(In reply to Michal Ambroz from comment #22)
>Bump to release 2.0.1
>https://rebus.fedorapeople.org/SPECS/radare2.spec
>https://rebus.fedorapeople.org/SRPMS/radare2-2.0.1-1.fc25.src.rpm
>
>I have addressed some of the your findings (comments, license, changelog), but 
>there is still more work to do on the area of minified JS code.

Thank you. This indeed looks better.

>The bundled JS libraries are not the core of the package functionality. These 
>are various templates to generated beautified reports out of the binary code. 
>I do not even know how to generate some of these in order to test the modified 
>functionality. I understand the reasons, simply I need some more time for that.

As I mentioned earlier, one option is to drop the affected functionality.

I've said above that fixing this almost certainly needs upstream to take
action. If you haven't talking to them about the way they track their third
party bundles please do so.

>> This is clearly a bug. Their SONAME is wrong:
>I would not call it bug. It is just not the double linking as you would expect.
>
>You expect that there would be (compare for example with libzip.so.4.0.0):
>libr_reg.so.2.0.1 with soname libr_reg.so.2
>libr_reg.so.2 link pointing to libr_reg.so.2.0.1
>and libr_reg.so in devel package pointing to libr_reg.so.2.0.1
>
>While they have:
>libr_reg.so.2.0.1 with soname libr_reg.so
>libr_reg.so link pointing to libr_reg.so.2.0.1
>
>The structure is the same, just one level shallower. They use the same link 
>for pointing to the library for runtime and for devel. The usual structure 
>allows changing devel link while keeping the runtime link operational with old 
>version.
>So you could be having trouble compiling new radare package on a machine where 
>already is old one (not something we would need in fedora).
>
>We can think of changing that in future, but right now I do not know how to do 
>that without breaking the stuff.

Is this an upstream opinion? Did they actually do this on purpose? My guess is
not.

To clarify, this absolutely needs fixing before the package can be imported.
Unless the ABI is kept stable (I presume it is not. But even if it were this is
still utterly useless) neither should be the SONAME and such .so files should
under no circumstances appear in libdir or in RPM's provides (otherwise, things
would link to it and inevitably break which is a huge no-no).

>> Also, please drop the last %changelog message.
>> tito is arguably something different from this package.
>Changing "tito" to "radare2" - originally I thought it is refering to some 
>nickname.
>The line came from the original radare2.spec from the project (and was 
>presumably created for the project by Pavel Odvody) so I would not like to 
>just drop it. He deserves credit as well.

Well I'm probably just nitpicking here, but that %changelog entry doesn't
reflect reality (perhaps Pavel would be surprised to learn that he did an
initial radare2 package?). A comment ("# based on tito package by ...") might
be a better way to credit the original author if his contributions are
significant.

There's also unanswered stuff from the last review:

(In reply to Lubomir Rintel from comment #17)
 %build
 %configure --with-sysmagic --with-syszip --with-syscapstone
>>>You don't enable openssl. Why? (no idea what is it used for)
>>Option is in the configure, but it is not working in radare for anything now.
>>At least that was answer from Pancake last time I asked about that (see 
>>sys/*.sh for the recommended build path - doesn't contain this option).
>
>Fair enough. I'm wondering if you add a comment explaining how do you 
>determine the right configure arguments?

This still requires action.

>2.2.) Bundling of C libraries

This is still a problem (perhaps rather easy) that needs to be addressed; in
particular the "provides" tags.

With the time slow turnaround time this review has I find it difficult to keep
track. What's a good way to track the unresolved issues? Should we start an
Etherpad?

In any case, a word on two on each of the items would ensure me you're not
ignoring them and they're not getting forgotten.

Thanks,
Lubo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1515885] Review Request: erlang-bbmustache - Binary pattern match-based Mustache template engine for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1515885



--- Comment #2 from Peter Lemenkov  ---
(In reply to Robert-André Mauchin from comment #1)
> No issue, package accepted.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1510565] Review Request: ntpstat - Utility to print NTP synchronization status

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1510565



--- Comment #9 from Miroslav Lichvar  ---
(In reply to Pavel Zhukov from comment #8)
> (In reply to Miroslav Lichvar from comment #7)
> > Wouldn't it better to just explicitly list the supported services in the
> > ntpstat spec using a rich dependency, e.g. "Requires: (ntp or chrony)" ?
> looks good for me. It's maintainer decision at the end :) 
> Are you going to update spec or it'll be done after formal review?

I've updated the spec and srpm:
https://mlichvar.fedorapeople.org/tmp/ntpstat.spec
https://mlichvar.fedorapeople.org/tmp/ntpstat-0.4-2.fc28.src.rpm

> > I tried adding "Obsoletes: ntp < 4.2.8p10-4" to ntpstat.spec, expecting ntp
> > would be dropped without replacement as chrony is installed, but the result
> > was the same as before.
> weird. maybe bug in libsolv?

I'm not sure. Maybe the obsoletes should be considered only if ntpstat is
already installed? I guess the other option is to simply add "Requires:
ntpstat" to ntp.

> Anyway I'll post formal review soon...

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1510565] Review Request: ntpstat - Utility to print NTP synchronization status

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1510565



--- Comment #8 from Pavel Zhukov  ---
(In reply to Miroslav Lichvar from comment #7)
> (In reply to Pavel Zhukov from comment #6)
> > (In reply to Miroslav Lichvar from comment #5)
> > > What if a third package was added to fedora, which provided this service?
> > > ntpstat can get the data from ntpd (using ntpq) and chronyd (using 
> > > chronyc),
> > > but that's all.
> > Well it's theoretical question which applies for mysql example as well. 
> > There're few options:
> > 1) Add support of the service to ntpstat
> > 2) Add "Conflicts:" to either the service or ntpstat spec.
> > In any case As far as ntpstat suggests chrony It's safe. In other words user
> > has to explicitly install ntpstat and "the service".
> 
> Wouldn't it better to just explicitly list the supported services in the
> ntpstat spec using a rich dependency, e.g. "Requires: (ntp or chrony)" ?
looks good for me. It's maintainer decision at the end :) 
Are you going to update spec or it'll be done after formal review?
> 
> > > If old ntp is installed, I think an upgrade should result in both new ntp
> > > and ntpstat installed. 
> > Something like Enhances: ntpstat in ntp.spec? 
> 
> That does not seem to work. I created a testing repo with ntp which
> "enhances" ntpstat and also contains the new ntpstat package, but dnf seems
> to ignore it:
> 
> # dnf update --disablerepo=* --enablerepo=local
> ...
> Upgrading:
>  ntp x86_64
> 4.2.8p10-4.nontpstat.fc28  local
> 670 k
>  ntpdate x86_64
> 4.2.8p10-4.nontpstat.fc28  local
> 85 k
> 
> I tried adding "Obsoletes: ntp < 4.2.8p10-4" to ntpstat.spec, expecting ntp
> would be dropped without replacement as chrony is installed, but the result
> was the same as before.
weird. maybe bug in libsolv?
Anyway I'll post formal review soon...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447517] Review Request: ddcutil - control monitor settings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447517



--- Comment #5 from sanford rockowitz  ---
New Spec and SRPM files to reflect recent upstream release 0.8.5.  For a
description of changes, see http://www.ddcutil.com/release_notes.

Updated file locations:

Spec URL: http://www.ddcutil.com/fedora/ddcutil.spec
SRPM URL: http://www.ddcutil.com/fedora/ddcutil-0.8.5-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1510565] Review Request: ntpstat - Utility to print NTP synchronization status

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1510565



--- Comment #7 from Miroslav Lichvar  ---
(In reply to Pavel Zhukov from comment #6)
> (In reply to Miroslav Lichvar from comment #5)
> > What if a third package was added to fedora, which provided this service?
> > ntpstat can get the data from ntpd (using ntpq) and chronyd (using chronyc),
> > but that's all.
> Well it's theoretical question which applies for mysql example as well. 
> There're few options:
> 1) Add support of the service to ntpstat
> 2) Add "Conflicts:" to either the service or ntpstat spec.
> In any case As far as ntpstat suggests chrony It's safe. In other words user
> has to explicitly install ntpstat and "the service".

Wouldn't it better to just explicitly list the supported services in the
ntpstat spec using a rich dependency, e.g. "Requires: (ntp or chrony)" ?

> > If old ntp is installed, I think an upgrade should result in both new ntp
> > and ntpstat installed. 
> Something like Enhances: ntpstat in ntp.spec? 

That does not seem to work. I created a testing repo with ntp which "enhances"
ntpstat and also contains the new ntpstat package, but dnf seems to ignore it:

# dnf update --disablerepo=* --enablerepo=local
...
Upgrading:
 ntp x86_64
4.2.8p10-4.nontpstat.fc28  local   
 670 k
 ntpdate x86_64
4.2.8p10-4.nontpstat.fc28  local   
  85 k

I tried adding "Obsoletes: ntp < 4.2.8p10-4" to ntpstat.spec, expecting ntp
would be dropped without replacement as chrony is installed, but the result was
the same as before.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org