[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534370




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534370
[Bug 1534370] Requires: lame, twolame for MP2, MP3 encoding
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1449467] Review Request: lame - MP3 encoder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1449467

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534370




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534370
[Bug 1534370] Requires: lame, twolame for MP2, MP3 encoding
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534335] New: Review Request: gap-pkg-groupoids - Groupoids, group graphs, and groupoid graphs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534335

Bug ID: 1534335
   Summary: Review Request: gap-pkg-groupoids - Groupoids, group
graphs, and groupoid graphs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jjames.fedorapeople.org/gap-pkg-groupoids/gap-pkg-groupoids.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-groupoids/gap-pkg-groupoids-1.54-1.fc28.src.rpm
Description: This is a rename of the existing gap-pkg-gpd package.  Upstream
changed the name from gpd to groupoids, so the Fedora package must follow suit.
Fedora Account System Username: jjames

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534336] New: Review Request: gap-pkg-laguna - Lie AlGebras and UNits of group Algebras

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534336

Bug ID: 1534336
   Summary: Review Request: gap-pkg-laguna - Lie AlGebras and
UNits of group Algebras
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jjames.fedorapeople.org/gap-pkg-laguna/gap-pkg-laguna.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-laguna/gap-pkg-laguna-3.8.0-1.fc28.src.rpm
Description: The LAGUNA package replaces the LAG package and provides
functionality for calculation of the normalized unit group of the modular group
algebra of the finite p-group and for investigation of Lie algebra associated
with group algebras and other associative algebras.
Fedora Account System Username: jjames

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533731] Review Request: ocaml-sedlex - Unicode-friendly lexer generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533731



--- Comment #3 from Andy Li  ---
Spec URL:
https://gist.github.com/andyli/775c716c5050b51e02c664557289dcc4/raw/37632057498dc1b797b2824a316fc9a1ffee16e1/ocaml-sedlex.spec
SRPM URL:
https://gist.github.com/andyli/775c716c5050b51e02c664557289dcc4/raw/37632057498dc1b797b2824a316fc9a1ffee16e1/ocaml-sedlex-1.99.4-1.fc28.src.rpm

Thanks for the review. Fixed the 2 issues as suggested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533929



--- Comment #14 from Björn "besser82" Esser  ---
Fixed scratch builds:

  Rawhide:  https://koji.fedoraproject.org/koji/taskinfo?taskID=24204151
  fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24204152
  fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24204153

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533929



--- Comment #13 from Björn "besser82" Esser  ---
Updated package:

  - Disable the -replacements package until we have a plan for it


Scratch builds:

  Rawhide:  https://koji.fedoraproject.org/koji/taskinfo?taskID=24203658
  fc27: https://koji.fedoraproject.org/koji/taskinfo?taskID=24203666
  fc26: https://koji.fedoraproject.org/koji/taskinfo?taskID=24203674


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/libkcapi.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/libkcapi-1.0.3-0.9.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533929



--- Comment #12 from Björn "besser82" Esser  ---
(In reply to Robert-André Mauchin from comment #11)
> As anticipated, the subpackage replacements conflicts with coreutils:

Allrighty, I'll disable it for now and until I could get an agreement with the
maintainer of coreutils…


> Also what is the purpose of all these hidden hmac files dropped into
> /usr/bin?

Those hidden hmac files are used by `fipscheck` to do some basic integrity
check on the binaries:

```
fipscheck will perform a FIPS-140-2 validation of a file using a stored
checksum of a file. The file containing the checksum value will be searched for
in the same directory as the file which is being checksummed.

The checksum file must have '.' prepended and '.hmac' appended to the original
file name.
```

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508126] Review Request: micro - A modern and intuitive terminal-based text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508126

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508126] Review Request: micro - A modern and intuitive terminal-based text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508126



--- Comment #7 from Fedora Update System  ---
micro-1.3.4-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8aee8cc4b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534067



--- Comment #1 from Athmane Madjoudj  ---
Looks good, here's few points to consider:

1. About license: it's preferable to ask upstream to include the license in the
tarball (reference the request in the spec)

2. For readability reasons, it's recommended to put one requirement per line
(Requires/BuildRequires and Recommends) 

3. It seems that there's a test suite, but not included in the pypi tarball
(not a blocker)

https://github.com/INCF/pybids/tree/master/bids/grabbids/tests


To fix point 1 and 3, you may want to switch to github tarball instead of
pypi's

Source0:
https://github.com/INCF/%{srcname}/archive/%{version}/%{srcname}-%{version}.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534169] Review Request: rust-tar - Rust implementation of a TAR file reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534169

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:59



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534163] Review Request: rust-curl - Rust bindings to libcurl for making HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534163

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:26:00



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534158] Review Request: rust-tokio-process - Implementation of an asynchronous process management backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534158
Bug 1534158 depends on bug 1534156, which changed state.

Bug 1534156 Summary: Review Request: rust-tokio-signal - Implementation of an 
asynchronous Unix signal handling backed futures
https://bugzilla.redhat.com/show_bug.cgi?id=1534156

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534143] Review Request: rust-xz2 - Rust bindings to liblzma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534143

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:50



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534169] Review Request: rust-tar - Rust implementation of a TAR file reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534169
Bug 1534169 depends on bug 1534166, which changed state.

Bug 1534166 Summary: Review Request: rust-xattr - UNIX extended filesystem 
attributes
https://bugzilla.redhat.com/show_bug.cgi?id=1534166

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534054] Review Request: rust-mio - Lightweight non-blocking IO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534054

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534158] Review Request: rust-tokio-process - Implementation of an asynchronous process management backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534158

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:39



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534156] Review Request: rust-tokio-signal - Implementation of an asynchronous Unix signal handling backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534156

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:55



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534166] Review Request: rust-xattr - UNIX extended filesystem attributes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534166

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:52



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534056] Review Request: rust-tokio-core - Core I/ O and event loop primitives for asynchronous I/O in Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534056
Bug 1534056 depends on bug 1534054, which changed state.

Bug 1534054 Summary: Review Request: rust-mio - Lightweight non-blocking IO
https://bugzilla.redhat.com/show_bug.cgi?id=1534054

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534162] Review Request: rust-socket2 - Utilities for handling networking sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534162

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:47



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534163] Review Request: rust-curl - Rust bindings to libcurl for making HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534163
Bug 1534163 depends on bug 1534162, which changed state.

Bug 1534162 Summary: Review Request: rust-socket2 - Utilities for handling 
networking sockets
https://bugzilla.redhat.com/show_bug.cgi?id=1534162

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534152] Review Request: rust-flate2 - DEFLATE compression and decompression exposed as Reader/ Writer streams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534152
Bug 1534152 depends on bug 1534056, which changed state.

Bug 1534056 Summary: Review Request: rust-tokio-core - Core I/O and event loop 
primitives for asynchronous I/O in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1534056

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534159] Review Request: rust-jobserver - Implementation of the GNU make jobserver for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534159

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:33



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534156] Review Request: rust-tokio-signal - Implementation of an asynchronous Unix signal handling backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534156
Bug 1534156 depends on bug 1534155, which changed state.

Bug 1534155 Summary: Review Request: rust-mio-uds - Unix domain socket bindings 
for mio
https://bugzilla.redhat.com/show_bug.cgi?id=1534155

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534152] Review Request: rust-flate2 - DEFLATE compression and decompression exposed as Reader/ Writer streams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534152

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534143] Review Request: rust-xz2 - Rust bindings to liblzma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534143
Bug 1534143 depends on bug 1534056, which changed state.

Bug 1534056 Summary: Review Request: rust-tokio-core - Core I/O and event loop 
primitives for asynchronous I/O in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1534056

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534141] Review Request: rust-lzma-sys - Raw bindings to liblzma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534141

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534159] Review Request: rust-jobserver - Implementation of the GNU make jobserver for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534159
Bug 1534159 depends on bug 1534158, which changed state.

Bug 1534158 Summary: Review Request: rust-tokio-process - Implementation of an 
asynchronous process management backed futures
https://bugzilla.redhat.com/show_bug.cgi?id=1534158

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534143] Review Request: rust-xz2 - Rust bindings to liblzma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534143
Bug 1534143 depends on bug 1534141, which changed state.

Bug 1534141 Summary: Review Request: rust-lzma-sys - Raw bindings to liblzma
https://bugzilla.redhat.com/show_bug.cgi?id=1534141

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534155] Review Request: rust-mio-uds - Unix domain socket bindings for mio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534155

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534161] Review Request: rust-hamcrest - Port of the Hamcrest testing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534161

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:31



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534152] Review Request: rust-flate2 - DEFLATE compression and decompression exposed as Reader/ Writer streams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534152
Bug 1534152 depends on bug 1534151, which changed state.

Bug 1534151 Summary: Review Request: rust-miniz_oxide_c_api - DEFLATE 
compression and decompression API, Rust drop-in replacement for miniz
https://bugzilla.redhat.com/show_bug.cgi?id=1534151

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534156] Review Request: rust-tokio-signal - Implementation of an asynchronous Unix signal handling backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534156
Bug 1534156 depends on bug 1534056, which changed state.

Bug 1534056 Summary: Review Request: rust-tokio-core - Core I/O and event loop 
primitives for asynchronous I/O in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1534056

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534159] Review Request: rust-jobserver - Implementation of the GNU make jobserver for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534159
Bug 1534159 depends on bug 1534056, which changed state.

Bug 1534056 Summary: Review Request: rust-tokio-core - Core I/O and event loop 
primitives for asynchronous I/O in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1534056

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534158] Review Request: rust-tokio-process - Implementation of an asynchronous process management backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534158
Bug 1534158 depends on bug 1534056, which changed state.

Bug 1534056 Summary: Review Request: rust-tokio-core - Core I/O and event loop 
primitives for asynchronous I/O in Rust
https://bugzilla.redhat.com/show_bug.cgi?id=1534056

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534056] Review Request: rust-tokio-core - Core I/ O and event loop primitives for asynchronous I/O in Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534056

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:17



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534151] Review Request: rust-miniz_oxide_c_api - DEFLATE compression and decompression API, Rust drop-in replacement for miniz

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534151

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:12



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534164] Review Request: rust-home - Shared definitions of home directories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534164

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534165] Review Request: rust-fs2 - Cross-platform file locks and file duplication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534165

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-14 17:25:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534297




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534297
[Bug 1534297] Use twolame for MP2 encoding
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1450227




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1450227
[Bug 1450227] audacity: enable MP2/MP3 output support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534291




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534291
[Bug 1534291] Enable MP2 encoding with twolame
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534067

Athmane Madjoudj  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534279] Review Request: catch1 - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534279



--- Comment #4 from Igor Gnatenko  ---
I think it should conflict, because people won't patch their packages given
that upstream doesn't differentiate between 1.x and 2.x...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268



--- Comment #3 from Randy Barlow  ---
I fixed the license string, thanks for noting that!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1534289




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534289
[Bug 1534289] Enable twolame element
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268



--- Comment #2 from Randy Barlow  ---
Waiting on https://pagure.io/releng/fedora-scm-requests/issue/4159

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432997] Review Request: multimc - Minecraft launcher with ability to manage multiple instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432997

srakitnican  changed:

   What|Removed |Added

Summary|Review Request: multimc5 -  |Review Request: multimc -
   |Minecraft launcher with |Minecraft launcher with
   |ability to manage multiple  |ability to manage multiple
   |instances   |instances



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1432997] Review Request: multimc5 - Minecraft launcher with ability to manage multiple instances

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1432997



--- Comment #2 from srakitnican  ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-27-x86_64/00701080-multimc/multimc.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/srakitnican/minecraft/fedora-27-x86_64/00701080-multimc/multimc-0.6.0-1.fc27.src.rpm

* Updated to a new upstream version (0.6.0)
* Renamed the package according to upstream preference
* Adapted to a new upstream build target 'lin-system'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533929] Review Request: libkcapi - User space interface to the Linux Kernel Crypto API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533929

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #11 from Robert-André Mauchin  ---
As anticipated, the subpackage replacements conflicts with coreutils:

DEBUG util.py:479:  Error: Transaction check error:
DEBUG util.py:479:file /usr/bin/md5sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha1sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha224sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha256sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha384sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64
DEBUG util.py:479:file /usr/bin/sha512sum from install of
libkcapi-replacements-1.0.3-0.8.fc28.x86_64 conflicts with file from package
coreutils-8.29-1.fc28.x86_64

Also what is the purpose of all these hidden hmac files dropped into /usr/bin?

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "*No copyright* GPL (v2 or later) (with incorrect FSF
 address)", "Unknown or generated", "BSD (3 clause) GPL", "*No
 copyright* BSD (3 clause)", "*No copyright* BSD (unspecified)", "BSD
 (unspecified)", "FSF All Permissive". 54 files have unknown license.
 Detailed output of licensecheck in /home/bob/packaging/review/libkcapi
 /review-libkcapi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either 

[Bug 1534279] Review Request: catch1 - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534279



--- Comment #3 from Tom Hughes  ---
Do you think we should make this conflict (as it does now) or should it install
in /usr/include/catch1? and if it does should the main package move to
/usr/include/catch2?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534279] Review Request: catch1 - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534279

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com
  Flags||fedora-review+



--- Comment #2 from Igor Gnatenko  ---
This actually doesn't need review because catch is already in fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268

Jeremy Cline  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #1 from Jeremy Cline  ---
One note, rpmlint doesn't like "MPL 2.0", I think it needs to be "MPLv2.0".

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "Unknown or generated", "*No copyright* MPL (v2.0)". 196
 files have unknown license. Detailed output of licensecheck in
 /home/vagrant/1534268-erlang-jose/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)

[Bug 1534116] Review Request: python-rasterio - Fast and direct raster I/ O for use with Numpy and SciPy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534116

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
Let me know once the deps are in Koji.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533719] Review Request: twolame - Optimized MPEG Audio Layer 2 encoding library based on tooLAME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533719

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #6 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD
 like)", "*No copyright* LGPL", "*No copyright* Public domain", "LGPL
 (v2.1 or later)", "GPL (v2.1 or later) (with incorrect FSF address)
 LGPL (v2.1 or later)". 71 files have unknown license. Detailed output
 of licensecheck in /home/bob/packaging/review/twolame/review-
 twolame/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 481280 bytes in 30 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} 

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268

Jeremy Cline  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jer...@jcline.org
   Assignee|nob...@fedoraproject.org|jer...@jcline.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||erlang-base64url-1.0-1.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1428202] Review Request: sirikali - GUI front end to encfs,cryfs, gocryptfs and securefs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1428202



--- Comment #22 from Raphael Groner  ---
Upstream added appdata:
https://github.com/mhogomchungu/sirikali/commit/ef54268108f0f04e5e1c8aaffd2bf4bdcca4d087

Possible FTBFS due to missing task.h is also fixed:
https://github.com/mhogomchungu/sirikali/commit/6dad4d1feb4f4f2f98ab4c02114cafd560cb61c0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 706199] Review Request: gnupg-pkcs11-scd - GnuPG-compatible smart-card daemon with PKCS#11 support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=706199



--- Comment #23 from W. Michael Petullo  ---
(In reply to Jakub Jelen from comment #22)
> Hello,
> can you do also a Fedora 27 build & update before Fedora 28 will be release?
> I would like to give it a try.

See https://bodhi.fedoraproject.org/updates/FEDORA-2018-bfc98963aa.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534052] Review Request: golang-github-mdlayher-netlink - Package netlink provides low-level access to Linux netlink sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534052

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - In case of git snapshot, you need to add the commit date to the Release
field:

%global commit  82077d593cd599c082317ceb5cfb22ee3fbc75ea
%global shortcommit %(c=%{commit}; echo ${c:0:7})
%global commitdate  20170915

Name:   golang-%{provider}-%{project}-%{repo}
Version:0
Release:1.%{commitdate}git%{shortcommit}%{?dist}

 - Packaging the latest git commit would be nice.

 - Again, why did you comment out all BR and R?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534044] Review Request: golang-github-beevik-ntp - A simple ntp client written in go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534044

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
- If you package a release, you don't need git snapshot info in the Release
field:

Release:1%{?dist}

   And:

* Fri Jan 12 2018 Paul Gier  - 0.2.0-1

 - Grab the correct release archive:

Source0:   
https://%{provider_prefix}/archive/v%{version}/%{repo}-%{version}.tar.gz

   And in %prep:

%setup -q -n %{repo}-%{version}

 - Why did you remove all BR and R to golang(golang.org/x/net/ipv4)? They are
needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508126] Review Request: micro - A modern and intuitive terminal-based text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508126



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/micro. You may commit to the branch "f27" in
about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/erlang-base64url

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532023] Review Request: ddupdate - A Dynamic DNS Updater

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532023



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ddupdate. You may commit to the branch "f27"
in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531955] Review Request: seqan2 - C++ library of efficient algorithms and data structures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531955



--- Comment #23 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/seqan2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534161] Review Request: rust-hamcrest - Port of the Hamcrest testing library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534161



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-hamcrest

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534163] Review Request: rust-curl - Rust bindings to libcurl for making HTTP requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534163



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-curl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534162] Review Request: rust-socket2 - Utilities for handling networking sockets

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534162



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-socket2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534164] Review Request: rust-home - Shared definitions of home directories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534164



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-home

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534165] Review Request: rust-fs2 - Cross-platform file locks and file duplication

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534165



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-fs2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534169] Review Request: rust-tar - Rust implementation of a TAR file reader and writer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534169



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534166] Review Request: rust-xattr - UNIX extended filesystem attributes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534166



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-xattr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534159] Review Request: rust-jobserver - Implementation of the GNU make jobserver for Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534159



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-jobserver

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534279] New: Review Request: catch1 - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534279

Bug ID: 1534279
   Summary: Review Request: catch1 - A modern, C++-native,
header-only, framework for unit-tests, TDD and BDD
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: t...@compton.nu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://tomh.fedorapeople.org//catch1.spec
SRPM URL: http://tomh.fedorapeople.org//catch1-1.12.0-1.fc27.src.rpm

Description:
Catch stands for C++ Automated Test Cases in Headers and is a
multi-paradigm automated test framework for C++ and Objective-C (and,
maybe, C). It is implemented entirely in a set of header files, but
is packaged up as a single header for extra convenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534158] Review Request: rust-tokio-process - Implementation of an asynchronous process management backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534158



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tokio-process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534279] Review Request: catch1 - A modern, C++-native, header-only, framework for unit-tests, TDD and BDD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534279



--- Comment #1 from Tom Hughes  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=24199891

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534156] Review Request: rust-tokio-signal - Implementation of an asynchronous Unix signal handling backed futures

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534156



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tokio-signal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534155] Review Request: rust-mio-uds - Unix domain socket bindings for mio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534155



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-mio-uds

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533777] Review Request: rust-crypto-hash - Wrapper for OS-level cryptographic hash functions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533777



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-crypto-hash

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533801] Review Request: ghc-call-stack - GHC call-stacks backward compatibility

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533801

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 8 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/ghc-call-stack/review-ghc-call-
 stack/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 

[Bug 1534152] Review Request: rust-flate2 - DEFLATE compression and decompression exposed as Reader/ Writer streams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534152



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-flate2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534151] Review Request: rust-miniz_oxide_c_api - DEFLATE compression and decompression API, Rust drop-in replacement for miniz

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534151



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-miniz_oxide_c_api

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534143] Review Request: rust-xz2 - Rust bindings to liblzma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534143



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-xz2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534141] Review Request: rust-lzma-sys - Raw bindings to liblzma

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534141



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-lzma-sys

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534056] Review Request: rust-tokio-core - Core I/ O and event loop primitives for asynchronous I/O in Rust

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534056



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-tokio-core

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534054] Review Request: rust-mio - Lightweight non-blocking IO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534054



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-mio

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534067] Review Request: python-pybids - Interface with datasets conforming to BIDS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534067

Athmane Madjoudj  changed:

   What|Removed |Added

 CC||athma...@gmail.com
   Assignee|nob...@fedoraproject.org|athma...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533731] Review Request: ocaml-sedlex - Unicode-friendly lexer generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533731

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Package uses either %{buildroot} or $RPM_BUILD_ROOT, not both.
   Note: Using both %{buildroot} and $RPM_BUILD_ROOT
   See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

 - Remove the executable bits for this file: /src/syntax/sedlex_cset.ml

ocaml-sedlex-debugsource.x86_64: W: spurious-executable-perm
/usr/src/debug/ocaml-sedlex-1.99.4-1.fc28.x86_64/src/syntax/sedlex_cset.ml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533731] Review Request: ocaml-sedlex - Unicode-friendly lexer generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533731

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Robert-André Mauchin  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 22 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/ocaml-sedlex/review-ocaml-
 sedlex/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into 

[Bug 1534041] Review Request: golang-github-alecthomas-units - Helpful unit multipliers and functions for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534041

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||zebo...@gmail.com
 Resolution|--- |ERRATA
Last Closed||2018-01-14 13:47:48



--- Comment #1 from Robert-André Mauchin  ---
Already packaged by the Deepin team:
https://src.fedoraproject.org/rpms/golang-github-alecthomas-units

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512702] Review Request: golang-github-prometheus-node_exporter - Prometheus exporter for hardware and OS metrics exposed by *NIX kernels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512702
Bug 1512702 depends on bug 1534041, which changed state.

Bug 1534041 Summary: Review Request: golang-github-alecthomas-units - Helpful 
unit multipliers and functions for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1534041

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1512702] Review Request: golang-github-prometheus-node_exporter - Prometheus exporter for hardware and OS metrics exposed by *NIX kernels

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1512702
Bug 1512702 depends on bug 1533980, which changed state.

Bug 1533980 Summary: Review Request: golang-github-alecthomas-template - Fork 
of Go's text/template adding newline elision
https://bugzilla.redhat.com/show_bug.cgi?id=1533980

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1533980] Review Request: golang-github-alecthomas-template - Fork of Go's text/ template adding newline elision

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1533980

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||zebo...@gmail.com
 Resolution|--- |ERRATA
Last Closed||2018-01-14 13:46:26



--- Comment #1 from Robert-André Mauchin  ---
Already packaged by the Deepin team:
https://src.fedoraproject.org/rpms/golang-github-alecthomas-template

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508126] Review Request: micro - A modern and intuitive terminal-based text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508126



--- Comment #5 from Robert-André Mauchin  ---
Thanks for the review! I activated the with_debug switch and it works fine in
Koji. https://koji.fedoraproject.org/koji/taskinfo?taskID=24198475

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534137] Review Request: fluxcapacitor - run programs without blocking on syscalls

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534137

Iwicki Artur  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |fluxcapacitor - run |fluxcapacitor - run
   |programs wihout blocking on |programs without blocking
   |syscalls|on syscalls



--- Comment #1 from Iwicki Artur  ---
Upstream accepted two of my patches, so I went ahead and updated the spec to
use the new git snapshot.

spec: https://svgames.pl/fedora/fluxcapacitor-0-3.spec
srpm: https://svgames.pl/fedora/fluxcapacitor-0-3.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=24197934

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261



--- Comment #2 from Randy Barlow  ---
Thanks for the review! Now waiting on
https://pagure.io/releng/fedora-scm-requests/issue/4157

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261

Jeremy Cline  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #1 from Jeremy Cline  ---
There's a difference in the changelog in the SRPM vs the specfile linked. The
one in the specfile is correct, so just make sure you get the right one when
you import it :)


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 4 files have
 unknown license. Detailed output of licensecheck in
 /home/vagrant/1534261-erlang-base64url/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261

Jeremy Cline  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jer...@jcline.org
   Assignee|nob...@fedoraproject.org|jer...@jcline.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org