[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #9 from Alexander Ploumistos  ---
(In reply to Antonio Trande from comment #7)
> (In reply to Alexander Ploumistos from comment #6)
> > The 0.5.1-4 build is missing the requirement on
> > libobabeliface-qt5.so.0()(64bit). But how did this happen?
> 
> Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
> 'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.

As far as I understand it, libobeliface is used to connect Molsketch with
OpenBabel, so it is very much needed.

It has been a busy week, when I get some spare time I'll try to revert some of
the changes incrementally and see what happens.


> >- Header files in -devel subpackage, if present.
> >  Note: molsketch-debugsource :
> >  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
> >  molsketch-debugsource :
> > ...
> 
> 'qmake' does not install all header files, i don't know why. Can you ask to
> upstream which headers must be provided?

I will send a message in a few minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #8 from Alexander Ploumistos  ---
Created attachment 1385256
  --> https://bugzilla.redhat.com/attachment.cgi?id=1385256=edit
OpenBabel-dependent features

(In reply to Antonio Trande from comment #7)
> (In reply to Alexander Ploumistos from comment #6)
> > The 0.5.1-4 build is missing the requirement on
> > libobabeliface-qt5.so.0()(64bit). But how did this happen?
> 
> Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
> 'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.
> 
> >There is one serious regression now. When the program starts, I can see that 
> >it >is not using OpenBabel, in the bottom right corner it shows everything 
> >with a >minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?
> 
> Does your latest release not provide all functions yet?
> Can you show me a screenshot?

The screenshot is from the 0.5.1-2 build. In the bottom left corner you can see
the plus signs in front of OpenBabel, InChI and gen2d, which means that
OpenBabel is found and enabled. The last button on the toolbar top right is for
cleaning up structures, with the help of OpenBabel. In 0.5.1-4 all these are
disabled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537071] Review Request: perl-curry - Create automatic curried method call closures for any class or object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537071

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||perl-curry-1.001000-1.fc28
 Resolution|--- |RAWHIDE
Last Closed||2018-01-24 01:39:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #64 from David Vásquez  ---
(In reply to Kevin Kofler from comment #63)
> The problem is that GStreamer will end up using fdk-aac (through some plugin
> that Fedora is going to ship) instead of FFmpeg (through gstreamer1-libav).

We should not worry about it; if we recently had many changes in gstreamer
"lame" ... twolame ... a52dec; maybe the future is gstreamer1-plugins-bad-free;
it can't replace gstreamer1-libav (it only uses ffmpeg); who use
gstreamer1-libav? Videos (totem), mpv... generally video players.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #63 from Kevin Kofler  ---
The problem is that GStreamer will end up using fdk-aac (through some plugin
that Fedora is going to ship) instead of FFmpeg (through gstreamer1-libav).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #62 from David Vásquez  ---
(In reply to Kevin Kofler from comment #61)
> (In reply to David Vásquez from comment #59)
> > If fdk-aac was approved, then welcome (I will give positive karma here). The
> > world is changing, and we must adapt. The user must choose; then we need
> > give the user the options. If some third-party repository does not want to
> > maintain the original fdk-aac, It is problem of the repository; other will
> > do...  This is how the world works.
> 
> The problem is that the third-party repository was previously shipping a
> different codec, the built-in one from FFmpeg, as the default, with nicer
> licensing and better FFmpeg integration. Now they'll have to deal with
> fdk-aac just because Fedora decided to ship a crippled version of it. And
> they'll have to do an fdk-aac-freeworld override without a real need for it.
> 
> And the other problem is that the decoder Fedora is going to ship silently
> produces wrong sound for some input files! That fits my definition of a
> broken decoder exactly.
> 
> (In reply to Dominik 'Rathann' Mierzejewski from comment #60)
> > (In reply to Kevin Kofler from comment #57)
> > > We still don't know the outcome of comment #52 (license review by the 
> > > FSF).
> > 
> > That's irrelevant. RH legal already cleared it.
> 
> So you would be happy to ship something the FSF considers non-free?

Hey! but the third-party repository isn't enable the support for fdk-aac by
default in ffmpeg...
https://github.com/rpmfusion/ffmpeg/blob/master/ffmpeg.spec#L91 . Then I can't
see a real problem here. Other, only the bundled ffmpeg in Handbrake use it... 
Maintain a fdk-aac-freeworld isn't  the death.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #3 from Kevin Kofler  ---
Correction: all 40 digits, not 64.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #2 from Kevin Kofler  ---
>  - Use cmake for your BR, as it is usual for KDE packages:
>
> BuildRequires:  cmake(Qt5Core)
> BuildRequires:  cmake(Qt5Qml)
> BuildRequires:  cmake(Qt5X11Extras)
> BuildRequires:  kf5-rpm-macros
> BuildRequires:  cmake(KF5CoreAddons)
> BuildRequires:  cmake(KF5KCMUtils)
> BuildRequires:  cmake(KF5I18n)
> BuildRequires:  cmake(KF5Plasma)
> BuildRequires:  cmake(KF5KDELibs4Support)
> BuildRequires:  cmake(KF5Declarative)
> BuildRequires:  cmake(KF5Auth)
> BuildRequires:  cmake(KF5Config)

Is it really? All the ones I have seen so far use package names or pkgconfig
BRs. But I guess that's because the cmake(*) Provides are a recent addition
(which is also why I haven't thought of using them). I don't like virtual BRs
all that much, but I can make this change if you think it is an improvement
(but I should probably use the full list of used modules then: e.g., the
CMakeLists.txt uses more than just Qt5Core from qt5-qtbase).

> - The short hash for Github is usually 7 characters long, not 13.

According to
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
"The packager MAY include up to 17 characters of additional information after
the date."
"git" is 3 characters, that leaves up to 14 for the commit version.

I think we should include as many digits as allowed of the commit hash to avoid
running into hash collisions. I'd put all 64 if I were allowed to. I should
change it from 13 to 14 characters though, some older version of the guidelines
only allowed up to 13 characters (which is why I picked that number in all my
git snapshot packages), now it allows up to 14.

You can note that for the GitHub Source0 URL itself (the only part that is ever
sent to GitHub), I actually use all 64 digits of the commit hash, not my 13
characters, which are only for the Release tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 970408] Review Request: mingw-libshout - Icecast source streaming library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970408

Steve  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |EOL
Last Closed||2018-01-23 21:31:51



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 970432] Review Request: mingw-portaudio - Free, cross platform, open-source, audio I/O library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970432

Steve  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |EOL
Last Closed||2018-01-23 21:31:58



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 970438] Review Request: mingw-phonon - Multimedia framework API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970438

Steve  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |EOL
  Flags|needinfo?(ulat...@yahoo.com |
   |)   |
Last Closed||2018-01-23 21:30:44



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #61 from Kevin Kofler  ---
(In reply to David Vásquez from comment #59)
> If fdk-aac was approved, then welcome (I will give positive karma here). The
> world is changing, and we must adapt. The user must choose; then we need
> give the user the options. If some third-party repository does not want to
> maintain the original fdk-aac, It is problem of the repository; other will
> do...  This is how the world works.

The problem is that the third-party repository was previously shipping a
different codec, the built-in one from FFmpeg, as the default, with nicer
licensing and better FFmpeg integration. Now they'll have to deal with fdk-aac
just because Fedora decided to ship a crippled version of it. And they'll have
to do an fdk-aac-freeworld override without a real need for it.

And the other problem is that the decoder Fedora is going to ship silently
produces wrong sound for some input files! That fits my definition of a broken
decoder exactly.

(In reply to Dominik 'Rathann' Mierzejewski from comment #60)
> (In reply to Kevin Kofler from comment #57)
> > We still don't know the outcome of comment #52 (license review by the FSF).
> 
> That's irrelevant. RH legal already cleared it.

So you would be happy to ship something the FSF considers non-free?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #26 from Robert-André Mauchin  ---
Benjamin Kircher needs to do it then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #25 from Thomas Moschny  ---
Can't create the repo:

The Bugzilla review bug creator didn't match the requester in Pagure.

https://pagure.io/releng/fedora-scm-requests/issue/4270

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787



--- Comment #10 from Fedora Update System  ---
python-fastavro-0.17.3-2.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3a013f7342

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050



--- Comment #12 from Fedora Update System  ---
python-nixio-1.4.3-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2bce70970a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
ejabberd-18.01-2.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534268] Review Request: erlang-jose - JSON Object Signing and Encryption (JOSE) for Erlang and Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534268

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
ejabberd-18.01-2.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534261] Review Request: erlang-base64url - URL safe base64-compatible codec

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534261

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
ejabberd-18.01-2.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537805] Review Request: python-josepy - JOSE protocol implementation in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537805

Eli Young  changed:

   What|Removed |Added

 CC||james.hoga...@gmail.com



--- Comment #1 from Eli Young  ---
Some notes:

The tests are currently disabled because they require various Python packages
that are not themselves packaged yet, including pytest-flake8 and pytest-isort.

Documentation building is disabled on EL7 because it requires
python-sphinx_rtd_theme, which has a dependency on fontawesome-fonts-web, which
despite being a noarch package is only in the Base repos for RHEL7 on x86_64.
This caused builds in Koji to fail.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537805] New: Review Request: python-josepy - JOSE protocol implementation in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537805

Bug ID: 1537805
   Summary: Review Request: python-josepy - JOSE protocol
implementation in Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: elysc...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://elyscape.fedorapeople.org//python-josepy.spec
SRPM URL: http://elyscape.fedorapeople.org//python-josepy-1.0.1-1.fc28.src.rpm

Description:
JOSE protocol implementation in Python using cryptography.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534050] Review Request: python-nixio - Python bindings for NIX

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534050

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
python-nixio-1.4.3-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-3381d175d6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534787] Review Request: python-fastavro - Fast Avro for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534787

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
python-fastavro-0.17.3-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-38b8e0f3ab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525900] Review Request: js-html5shiv - Enable use of HTML5 sectioning elements in legacy browsers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525900

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



--- Comment #9 from Fedora Update System  ---
js-html5shiv-3.7.3-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-ba20010674

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #60 from Dominik 'Rathann' Mierzejewski  ---
(In reply to Kevin Kofler from comment #57)
> We still don't know the outcome of comment #52 (license review by the FSF).

That's irrelevant. RH legal already cleared it.

(In reply to leigh scott from comment #58)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #56)
> 
> > I also assume Wim will co-maintain the corresponding RPMFusion package or at
> > least coordinate with its maintainer.
> 
> I guess that will be Han's now as I'm no longer going to it.

Who's "Han"?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: Botan - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067

Thomas Moschny  changed:

   What|Removed |Added

Summary|Review Request: Botan, a|Review Request: Botan - A
   |C++11 crypto and TLS|C++11 crypto and TLS
   |library, version 2  |library, version 2



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: botan2 - A C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067

Thomas Moschny  changed:

   What|Removed |Added

Summary|Review Request: Botan - A   |Review Request: botan2 - A
   |C++11 crypto and TLS|C++11 crypto and TLS
   |library, version 2  |library, version 2



--- Comment #24 from Thomas Moschny  ---
Love this tool.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: Botan, a C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: Botan, a C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: Botan, a C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #23 from Robert-André Mauchin  ---
Now retry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487067] Review Request: Botan, a C++11 crypto and TLS library, version 2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487067



--- Comment #22 from Thomas Moschny  ---
So, trying to create a request for a new package failed with:

  Error: The Bugzilla bug's review was approved over 60 days ago

:( Need to find out what to do in such a case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #5 from Iwicki Artur  ---
Quite a lot of stuff that's available from npm is available in Fedora repos as
'nodejs-*' packages. There's a chance that we might be already packaging all
the needed dependencies, though using this will probably mean you need to patch
the Makefile accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #4 from Christian Glombek  ---
One more thing that probably needs to be adressed before getting this into
Fedora:
The loleaflet part of the build invokes `npm install` in the build.
This isn't allowed in Fedora. There is a npm-shrinkwrap file for versioning the
deps.

Does anybody know of a good way to source these deps?

Maybe
add an individual source file for each of them 
or
`npm install` locally beforehand and tar node_modules to put it in one source
file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915



--- Comment #3 from Christian Glombek  ---
Thanks for the review, it's highly appreciated!

Do you have any ideas how to do the build without the env var?
My idea would be to patch the configure and make files so that configure
recognizes a --building-from-rpmbuild flag (or similar) instead of the makefile
using the env var.

Does that sound about right to you or do you see an easier way of doing it?

The other issues mentioned will be adressed shortly!
Cheers, Chris

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508126] Review Request: micro - A modern and intuitive terminal-based text editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508126

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:45:28



--- Comment #9 from Fedora Update System  ---
micro-1.3.4-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529027] Review Request: python-send2trash - Python library to natively send files to Trash

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529027

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:43:30



--- Comment #8 from Fedora Update System  ---
python-send2trash-1.4.2-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529025] Review Request: python-filetype - Infer file type and MIME type of any file/buffer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529025

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:43:25



--- Comment #6 from Fedora Update System  ---
python-filetype-1.0.0-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531464] Review Request: php-pecl-couchbase2 - Couchbase Server PHP extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531464



--- Comment #9 from Fedora Update System  ---
php-pecl-couchbase2-2.4.3-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529023] Review Request: python-validators - Data Validation in python for Humans

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529023

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:43:20



--- Comment #12 from Fedora Update System  ---
python-validators-0.12.0-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532082] Review Request: python-klusta - Spike detection and automatic clustering for spike sorting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532082



--- Comment #11 from Fedora Update System  ---
python-klusta-3.0.16-2.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529026] Review Request: python-googletrans - Google Translate API for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529026

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:43:27



--- Comment #6 from Fedora Update System  ---
python-googletrans-2.2.0-2.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529024] Review Request: python-tld - Extract the top level domain from the URL given

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529024

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:43:22



--- Comment #5 from Fedora Update System  ---
python-tld-0.7.9-3.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532082] Review Request: python-klusta - Spike detection and automatic clustering for spike sorting

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532082

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:17:58



--- Comment #10 from Fedora Update System  ---
python-klusta-3.0.16-2.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #14 from Fedora Update System  ---
persepolis-3.0.1-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1531464] Review Request: php-pecl-couchbase2 - Couchbase Server PHP extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1531464

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-23 16:17:15



--- Comment #8 from Fedora Update System  ---
php-pecl-couchbase2-2.4.3-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537727] Review Request: python-cattrs - Python library for structuring and unstructuring data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537727

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 38 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-cattrs/review-python-
 cattrs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-cattrs , python3-cattrs
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Use cmake for your BR, as it is usual for KDE packages:

BuildRequires:  cmake(Qt5Core)
BuildRequires:  cmake(Qt5Qml)
BuildRequires:  cmake(Qt5X11Extras)
BuildRequires:  kf5-rpm-macros
BuildRequires:  cmake(KF5CoreAddons)
BuildRequires:  cmake(KF5KCMUtils)
BuildRequires:  cmake(KF5I18n)
BuildRequires:  cmake(KF5Plasma)
BuildRequires:  cmake(KF5KDELibs4Support)
BuildRequires:  cmake(KF5Declarative)
BuildRequires:  cmake(KF5Auth)
BuildRequires:  cmake(KF5Config)

 - The short hash for Github is usually 7 characters long, not 13.

 - You should "Requires: dbus" to own these dbus directories
 Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms,
 /usr/share/kpackage/kcms, /usr/share/dbus-1/system-services,
 /usr/share/dbus-1, /etc/dbus-1, /etc/dbus-1/system.d


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 51 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/nomad-firewall/review-
 nomad-firewall/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/kpackage/kcms
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms,
 /usr/share/kpackage/kcms, /usr/share/dbus-1/system-services,
 /usr/share/dbus-1, /etc/dbus-1, /etc/dbus-1/system.d
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the 

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302



--- Comment #15 from Fedora Update System  ---
yuicompressor-2.4.8-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525906] Review Request: js-respond - A fast & lightweight polyfill for min/ max-width CSS3 Media Queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525906



--- Comment #15 from Fedora Update System  ---
js-respond-1.4.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #59 from David Vásquez  ---
If fdk-aac was approved, then welcome (I will give positive karma here). The
world is changing, and we must adapt. The user must choose; then we need give
the user the options. If some third-party repository does not want to maintain
the original fdk-aac, It is problem of the repository; other will do...  This
is how the world works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534799

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534799



--- Comment #6 from Fedora Update System  ---
python-hdfs-2.1.0-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-01ea1b966e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534799



--- Comment #5 from Fedora Update System  ---
python-hdfs-2.1.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-c93c8b9950

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536780] Review Request: swift-lang - Apple' s Swift Programming Language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536780



--- Comment #7 from Ron Olson  ---
There's an issue with excluding LLDB from being installed as part of the Swift
package, the one that is already available in Fedora does not know about Swift
(of course), but that makes the Swift REPL unavailable:

[root@2b87d31bfd74 home]# swift --version
Swift version 4.1-dev
Target: x86_64-unknown-linux-gnu
[root@2b87d31bfd74 home]# lldb --version
lldb version 5.0.1
[root@2b87d31bfd74 home]# rpm -qf /usr/bin/lldb
lldb-5.0.1-1.fc28.x86_64
[root@2b87d31bfd74 home]# rpm -qf /usr/bin/swift
swift-lang-4.1-0.20180117git1381d08.fc28.x86_64
[root@2b87d31bfd74 home]# swift
error: LLDB isn't configured with REPL support for any languages.
[root@2b87d31bfd74 home]#

Not sure how to resolve this in a polite way for the user (e.g. we don't want
to overwrite their existing version).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1523302] Review Request: yuicompressor - YUI Compressor - The Yahoo JavaScript and CSS Compressor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1523302



--- Comment #14 from Fedora Update System  ---
yuicompressor-2.4.8-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525906] Review Request: js-respond - A fast & lightweight polyfill for min/ max-width CSS3 Media Queries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525906



--- Comment #14 from Fedora Update System  ---
js-respond-1.4.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537398] Review Request: spectre-meltdown-checker - Spectre & Meltdown vulnerability/ mitigation checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537398

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags|needinfo?(zebo...@gmail.com |fedora-review+
   |)   |



--- Comment #4 from Robert-André Mauchin  ---
This package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537398] Review Request: spectre-meltdown-checker - Spectre & Meltdown vulnerability/ mitigation checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537398

Neal Gompa  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|zebo...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537398] Review Request: spectre-meltdown-checker - Spectre & Meltdown vulnerability/ mitigation checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537398

Neal Gompa  changed:

   What|Removed |Added

  Flags||needinfo?(zebo...@gmail.com
   ||)



--- Comment #3 from Neal Gompa  ---
ganto is now sponsored in the packagers group, good luck!

@Robert-Andre, please complete the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537398] Review Request: spectre-meltdown-checker - Spectre & Meltdown vulnerability/ mitigation checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537398

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #2 from Neal Gompa  ---
I will sponsor this packager into the packagers collection, provided this
package is accepted.

I have seen his work in other packages (primarily the LXD COPR repo), and he
does a good job with his packaging and trying to follow the Fedora packaging
guidelines.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534799



--- Comment #4 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-hdfs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537727] New: Review Request: python-cattrs - Python library for structuring and unstructuring data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537727

Bug ID: 1537727
   Summary: Review Request: python-cattrs - Python library for
structuring and unstructuring data
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: space...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~brouhaha/python-cattrs/python-cattrs.spec
SRPM URL:
https://fedorapeople.org/~brouhaha/python-cattrs/python-cattrs-0.6.0-1.fc27.src.rpm
Description: cattrs is an open source Python library for structuring and
unstructuring data. cattrs works best with attrs classes and the usual
Python collections, but other kinds of classes are supported by
manually registering converters.
Fedora Account System Username: brouhaha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501992] Review Request: opam - Source-based package manager for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501992



--- Comment #26 from Anil Madhavapeddy  ---
> We can push updates including complete new versions to Fedora 27 until
EOL so I don't think there's any problem here.

Oh that's perfect, thanks!  We're working hard on getting opam2 out of the door
:-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501992] Review Request: opam - Source-based package manager for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501992



--- Comment #25 from Anil Madhavapeddy  ---
> We can push updates including complete new versions to Fedora 27 until
EOL so I don't think there's any problem here.

Oh that's perfect, thanks!  We're working hard on getting opam2 out of the door
:-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501992] Review Request: opam - Source-based package manager for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501992



--- Comment #24 from Richard W.M. Jones  ---
F27 was released in November 2017.  F28 will be released in May.

We can push updates including complete new versions to Fedora 27 until
EOL so I don't think there's any problem here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #58 from leigh scott  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #56)

> I also assume Wim will co-maintain the corresponding RPMFusion package or at
> least coordinate with its maintainer.
> 

I guess that will be Han's now as I'm no longer going to it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501992] Review Request: opam - Source-based package manager for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501992

Anil Madhavapeddy  changed:

   What|Removed |Added

 CC||a...@recoil.org



--- Comment #23 from Anil Madhavapeddy  ---
While we appreciate Fedora packaging opam, please do note that the opam2 beta
series is still subject to backwards-incompatible changes until we release opam
2.0.0.  When do you anticipate Fedora 27 being released?

We would rather not have to support opam2 betas in the long term, so perhaps a
warning message in the RPM to this effect might be appropriate?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481913] Review Request: ocaml-zed - Abstract engine for text edition in OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481913

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481913] Review Request: ocaml-zed - Abstract engine for text edition in OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481913



--- Comment #5 from Fedora Update System  ---
ocaml-zed-1.6-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-63a1c63301

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487875] Review Request: ocaml-mccs - Multi Criteria CUDF Solver with OCaml bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487875

Ben Rosser  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-23 13:03:34



--- Comment #3 from Ben Rosser  ---
This has since been built for Rawhide, and more recently, stable branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1185099] Review Request: opam - A source-based package manager for OCaml

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1185099
Bug 1185099 depends on bug 1486068, which changed state.

Bug 1486068 Summary: Review Request: ocaml-dose3 - Framework for managing 
distribution packages and dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1486068

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1486068] Review Request: ocaml-dose3 - Framework for managing distribution packages and dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1486068

Ben Rosser  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-23 13:03:22



--- Comment #8 from Ben Rosser  ---
This has since been built for Rawhide, and more recently, stable branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536852] Review Request: molsketch - Molecular Structures Editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536852



--- Comment #7 from Antonio Trande  ---
(In reply to Alexander Ploumistos from comment #6)
> I ran a side by side comparison of the 0.5.1-2 and 0.5.1-4 x86_64 builds and
> I found the difference:
> 
> Processing files: molsketch-0.5.1-2.fc28.x86_64
> […]
> Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
> libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
> libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit)
> libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit)
> libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit)
> libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit)
> libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit)
> libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
> libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
> libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit)
> libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit)
> libobabeliface-qt5.so.0()(64bit) libopenbabel.so.5()(64bit)
> libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
> libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
> libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
> rtld(GNU_HASH)
> 
> 
> Processing files: molsketch-0.5.1-4.fc28.x86_64
> […]
> Requires: libGL.so.1()(64bit) libQt5Core.so.5()(64bit)
> libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.10)(64bit)
> libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit)
> libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit)
> libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit)
> libQt5Svg.so.5()(64bit) libQt5Svg.so.5(Qt_5)(64bit)
> libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit)
> libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
> libc.so.6(GLIBC_2.4)(64bit) libgcc_s.so.1()(64bit)
> libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit)
> libm.so.6(GLIBC_2.2.5)(64bit) libmolsketch-qt5.so.0()(64bit)
> libopenbabel.so.5()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit)
> libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit)
> libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit)
> rtld(GNU_HASH)
> 
> The 0.5.1-4 build is missing the requirement on
> libobabeliface-qt5.so.0()(64bit). But how did this happen?

Because in the release 2 there was the line "'Requires: lib%{name}-qt5'".
'molsketch-qt5' doesn't need 'libobabeliface-qt5', it seems.

>There is one serious regression now. When the program starts, I can see that 
>it >is not using OpenBabel, in the bottom right corner it shows everything 
>with a >minus (OpenBabel, InChI, gen2d). Can you tell where I've messed up?

Does your latest release not provide all functions yet?
Can you show me a screenshot?

>- Header files in -devel subpackage, if present.
>  Note: molsketch-debugsource :
>  /usr/src/debug/molsketch-0.5.1-2.fc28.x86_64/libmolsketch/TextInputItem.h
>  molsketch-debugsource :
> ...

'qmake' does not install all header files, i don't know why. Can you ask to
upstream which headers must be provided?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 972346] Review Request: ros-common_msgs - Common ROS Messages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972346



--- Comment #12 from Till Hofmann  ---
(In reply to Rich Mattes from comment #11)
> Hi Tim and Ankur,
> 
> I don't have nearly the time it would take to complete this packaging effort
> anymore.  I was actually considering retiring the few ROS 1 packages I did
> get through the review process.  If Till wants to take them over to move
> some of his work into Fedora proper, I would be happy to re-assign them

That would be nice. There are still some TODOs on my list before I can submit
the packages to Fedora, but I plan to do it eventually. If you give me access,
I can update/retire them when I have the generated SPECS ready.

Meanwhile, any help with the generator is appreciated, especially testing
packages and reporting bugs on [1]. Please also file a report if there's a
package missing.

IMHO continuing this review request does not make much sense as it's not
up-to-date and would probably not fit in the stack of generated ROS SPECS.

Regards,
Till 

[1] https://pagure.io/ros/issues

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1494915] Review Request: libreoffice-online - LibreOffice Online Web Socket Daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1494915

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #2 from Iwicki Artur  ---
>env BUILDING_FROM_RPMBUILD=yes make ...
I believe using /bin/env inside spec files is discouraged.

>%__install -D -m 444 loolwsd.service %{buildroot}%{_unitdir}/loolwsd.service
>install -d -m 755 %{buildroot}%{_localstatedir}/adm/fillup-templates
Why the mix of "install" and "%__install"? Non-macro forms of system
executables are preferred.

As for "%{buildroot}%{_sysconfdir}/cron.d/loolwsd.cron", I think it'd be
cleaner to use cat and a heredoc to create the file:
>cat > output_file Line 2 of file.
>EOF
You could, alternatively, just create said file and add it as Source1.

>%{_datadir}/%{name}/favicon.ico
>%{_datadir}/%{name}/discovery.xml
>%{_datadir}/%{name}/robots.txt
>%{_datadir}/%{name}/loleaflet/*
This makes the package own the files inside %{_datadir}/%{name}, but the
directory itself is unowned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522



--- Comment #57 from Kevin Kofler  ---
We still don't know the outcome of comment #52 (license review by the FSF).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537071] Review Request: perl-curry - Create automatic curried method call closures for any class or object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537071



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-curry

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Kevin Kofler  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Kevin Kofler  changed:

   What|Removed |Added

  Alias||nomad-firewall



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] New: Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Bug ID: 1537677
   Summary: Review Request: nomad-firewall - UFW control module
for KDE Plasma 5 and Nomad Desktop
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ke...@tigcc.ticalc.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://copr-be.cloud.fedoraproject.org/results/kkofler/kannolo/fedora-rawhide-x86_64/00704754-nomad-firewall/nomad-firewall.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/kkofler/kannolo/fedora-rawhide-x86_64/00704754-nomad-firewall/nomad-firewall-0.1-2.20180123gitdf1ae0e5de1c8.fc28.src.rpm
Description:
KDE Plasma 5 KControl Module to configure and control the Uncomplicated
Firewall
(UFW), by the Nomad Desktop project (a desktop environment based on Plasma 5
technologies).
Fedora Account System Username: kkofler

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541

Petr Viktorin  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-23 11:50:08



--- Comment #12 from Petr Viktorin  ---
Pushed and built in Rawhide.

https://koji.fedoraproject.org/koji/taskinfo?taskID=24400283

Thank you to all involved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1525570] Review Request: pew - Tool to manage multiple virtualenvs written in pure python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1525570



--- Comment #14 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/pew. You may commit to the branch "f28" in
about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537572] Review Request: corosync-qdevice - The Corosync Cluster Engine Qdevice

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537572

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Remove the old cruft, this is not needed in Fedora:

Group: 

BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)

rm -rf %{buildroot} in %install

%clean
rm -rf %{buildroot}

%defattr(-,root,root,-) in %files


 - Use the correct systemd macros:

Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd

   and

BuildRequires: systemd-units
BuildRequires: systemd-devel


  should be simplified to:

%{?systemd_requires}
BuildRequires: systemd

 - Requires(pre): /usr/sbin/useradd is not needed as it is provided by
shadow-utils just above.

 - %systemd_postun should be followed by the service file:

%systemd_postun corosync-qdevice.service

%systemd_postun corosync-qnetd.service

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python2-django1.11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1501522] Review Request: fdk-aac - Third-Party Modified Version of the Fraunhofer FDK AAC Codec Library for Android

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1501522

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



--- Comment #56 from Dominik 'Rathann' Mierzejewski  ---
There have been no new comments for 10 days and since FESCo (and I assume Wim
as well) is fine with dealing with the inevitable support issues, this package
is APPROVED.

I also assume Wim will co-maintain the corresponding RPMFusion package or at
least coordinate with its maintainer.

One small nit: please put each BuildRequires: in a separate line and sort them
alphabetically. You can do that upon importing the package.

A Fedora Community Blog post explaining what does and and what doesn't work
with this codec would also be a good idea.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1500958] Review Request: python-kiwi-gtk - Framework for Python GUI applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1500958

Haïkel Guémar  changed:

   What|Removed |Added

  Flags|needinfo?(karlthered@gmail. |
   |com)|



--- Comment #5 from Haïkel Guémar  ---
Ack for suggestion, I'll push a newer version of the spec this week (should be
ready but haven't finished to test it)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537071] Review Request: perl-curry - Create automatic curried method call closures for any class or object

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537071

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
URL and Source addresses are Ok.
Source archive (SHA-256:
8b186079202064fb3dcc25cf7290aa3f5d551d98d1b86d5844706a760c1f56d4) is original.
Ok.
Summary verified from lib/curry.pm. Ok.
Description verified from lib/curry.pm. Ok.
License verified from lib/curry.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

rpmlint perl-curry.spec
review-perl-curry/results/perl-curry-1.001000-1.fc28.noarch.rpm
review-perl-curry/results/perl-curry-1.001000-1.fc28.src.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

rpm -q -lv -p perl-curry-1.001000-1.fc28.noarch.rpm 
drwxr-xr-x2 rootroot0 janv. 23 16:00
/usr/share/doc/perl-curry
-rw-r--r--1 rootroot  136 juin 23  2017
/usr/share/doc/perl-curry/Changes
-rw-r--r--1 rootroot 2384 juin 23  2017
/usr/share/doc/perl-curry/README
-rw-r--r--1 rootroot 2080 janv. 23 16:00
/usr/share/man/man3/curry.3pm.gz
drwxr-xr-x2 rootroot0 janv. 23 16:00
/usr/share/perl5/vendor_perl/curry
-rw-r--r--1 rootroot 3131 juin 23  2017
/usr/share/perl5/vendor_perl/curry.pm
-rw-r--r--1 rootroot   37 juil. 30  2012
/usr/share/perl5/vendor_perl/curry/weak.pm
File permissions and layout are Ok.

rpm -q --requires -p perl-curry-1.001000-1.fc28.noarch.rpm | sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.1)
  1 perl(curry)
  1 perl(Scalar::Util)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

rpm -q --provides -p perl-curry-1.001000-1.fc28.noarch.rpm 
perl(curry) = 1.001000
perl(curry::weak)
perl-curry = 1.001000-1.fc28
Binary provides are Ok.

Package builds in F28
(https://koji.fedoraproject.org/koji/taskinfo?taskID=24398788)
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536993] Review Request: notejot - Stupidly-simple sticky notes applet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536993



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/notejot

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534799] Review Request: python-hdfs - HdfsCLI: API and command line interface for HDFS

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534799

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
You can use find with a for loop:

for lib in `find %{buildroot}%{python2_sitelib}/%{srcname}/ -name *.py`
do
…
done


Package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536993] Review Request: notejot - Stupidly-simple sticky notes applet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536993



--- Comment #2 from Fabio Valentini  ---
Thanks for the review! :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537403] Review Request: rust-intervaltree - Simple and generic implementation of an immutable interval tree

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537403

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in mock
 - No RPMLint errors

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536984] Review Request: sequeler - SQL Client built in Vala

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536984



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/sequeler

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536882] Review Request: harvey - Color contrast checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536882



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/harvey

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537398] Review Request: spectre-meltdown-checker - Spectre & Meltdown vulnerability/ mitigation checker

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537398

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #1 from Robert-André Mauchin  ---
You're not a member of the packager group, you'll need to find a sponsor. See
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Try introducing yourself on the devel mailing list too.

Package is fine otherwise, let me know whern

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 3 files have unknown license. Detailed
 output of licensecheck in /home/bob/packaging/review/spectre-meltdown-
 checker/review-spectre-meltdown-checker/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, 

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #5 from Robert-André Mauchin  ---
Done: https://github.com/opencryptoki/openssl-ibmpkcs11/pull/10

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536873] Review Request: dippi - Calculate display info like DPI and aspect ratio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536873



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/dippi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990



--- Comment #4 from Dan Horák  ---
Thanks for the review, could you submit a PR for the autotools fix at
https://github.com/opencryptoki/openssl-ibmpkcs11 ? They are handled promptly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537572] New: Review Request: corosync-qdevice - The Corosync Cluster Engine Qdevice

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537572

Bug ID: 1537572
   Summary: Review Request: corosync-qdevice - The Corosync
Cluster Engine Qdevice
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jfrie...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://honzaf.fedorapeople.org/corosync-qdevice/corosync-qdevice.spec
SRPM URL:
https://honzaf.fedorapeople.org/corosync-qdevice/corosync-qdevice-2.90.0-1.fc28.src.rpm

Description: 
Currently, corosync package
(https://admin.fedoraproject.org/pkgdb/package/rpms/corosync/) contains also
two subpackages corosync-qdevice and corosync-qnetd.

With next version of Corosync we are going to split Corosync qdevice out of
main project to it's own project
(https://github.com/corosync/corosync-qdevice). Because of this split it seems
to make sense to to have also separate fedora package instead of two source in
one spec.

Fedora Account System Username: honzaf (I'm both upstream and fedora maintainer
of Corosync package)

Test build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24396245

Known rpmlint "problems":
1. corosync-qnetd.x86_64: W: only-non-binary-in-usr-lib

^^ Systemd unit file

2. corosync-qnetd.x86_64: W: non-standard-uid /var/run/corosync-qnetd coroqnetd

^^ We are using
https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Dynamic_allocation

3. corosync-qnetd.x86_64: W: non-standard-gid /var/run/corosync-qnetd coroqnetd

Same as 2.

4. corosync-qnetd.x86_64: E: non-standard-dir-perm /var/run/corosync-qnetd
0770L

Idea is to allow whoever is member of coroqnetd user group to use
corosync-qnetd-tool via socket which is stored in /var/run

5. corosync-qnetd.x86_64: W: non-standard-uid /etc/corosync/qnetd coroqnetd

Same as 2.

6. corosync-qnetd.x86_64: W: non-standard-gid /etc/corosync/qnetd coroqnetd

Same as 2.

7. corosync-qnetd.x86_64: E: non-standard-dir-perm /etc/corosync/qnetd 0770L
Idea is to allow whoever is member of coroqnetd user group to manipulate with
certificates stored in /etc/corosync/qnetd

Similar problems are found by rpmlint also in corosync-qdevice package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536990] Review Request: openssl-ibmpkcs11 - IBM OpenSSL PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536990

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #3 from Robert-André Mauchin  ---
 - Nitpick, use this simplified Source0:

Source0:   
https://github.com/opencryptoki/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

 - Package use an obsolete M4 macro, patch it out:

AutoTools: Obsoleted m4s found
--
  AC_PROG_LIBTOOL found in: openssl-ibmpkcs11-1.0.1/configure.ac:45


   Here's a patch for it:

diff -up openssl-ibmpkcs11-1.0.1/configure.ac.fix_obsolete_m4s
openssl-ibmpkcs11-1.0.1/configure.ac
--- openssl-ibmpkcs11-1.0.1/configure.ac.fix_obsolete_m4s2017-12-08
17:01:52.0 +0100
+++ openssl-ibmpkcs11-1.0.1/configure.ac2018-01-23 14:40:26.962655055 +0100
@@ -42,7 +42,7 @@ AC_CHECK_LIB(crypto, RAND_add, [], \

 AC_DISABLE_STATIC
 AC_PROG_CC
-AC_PROG_LIBTOOL
+LT_INIT

 CFLAGS="$CFLAGS -Wall -DLINUX -DOPENCRYPTOKI"
 AC_SUBST(CFLAGS)



==
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "*No copyright* NTP", "Unknown or generated".
 16 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/openssl-ibmpkcs11/review-openssl-
 ibmpkcs11/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec 

[Bug 1517499] Review Request: kqoauth-qt5 - Qt OAuth support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1517499

mgans...@alice.de  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2018-01-23 07:04:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org