[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #15 from Fabio Massimo Di Nitto  ---
(In reply to Jan Pokorný from comment #14)
> re [comment 13]:
> 
> Mind that this is in the context of Fedora, OpenSUSE can have
> conflicting guidelines and that's generally out of scope here.

A lot of the basic rpm functionalities are the same. While the fedora spec file
needs/must match fedora guideline, it doesn´t prevent using some of those
recommendations upstream and have them converged to be more sane on both side
:-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #14 from Jan Pokorný  ---
re [comment 13]:

Mind that this is in the context of Fedora, OpenSUSE can have
conflicting guidelines and that's generally out of scope here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #13 from Fabio Massimo Di Nitto  ---
(In reply to Jan Pokorný from comment #11)
> I'll happily assign myself as a reviewer if there're no complaints.
> 
> For a start, the spec is needlessly overcomplicated around conditionals:

can you please propose a patch upstream too? I am very rusty on spec files and
stuff. Digimer probably used mine as template and there is some goodness in
having  them aligned. Just please make sure it builds also on opensuse.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 964437] Review Request: mingw-portmidi - Real-time Midi I/O Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=964437

Steve  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |EOL
Last Closed||2018-01-29 22:44:06



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 970411] Review Request: mingw-libid3tag - ID3 tag manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970411

Steve  changed:

   What|Removed |Added

  Flags|needinfo?(ulat...@yahoo.com |needinfo-
   |)   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 970416] Review Request: mingw-taglib - Audio Meta-Data Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=970416

Steve  changed:

   What|Removed |Added

  Flags|needinfo?(ulat...@yahoo.com |needinfo-
   |)   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506428



--- Comment #12 from Andrew Toskin  ---
Cool, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #57 from Sergio Monteiro Basto  ---
Hi , 
comment diff between specs 5.2.2 and 5.2.6 

1 -
+# Small compile fix 
 Patch1: VirtualBox-5.0.18-xserver_guest.patch

yeah something happened and upstream doesn't do the VBOX_NO_LEGACY_XORG_X11=1
that is not working as expect so we still need part of 
VirtualBox-5.0.18-xserver_guest.patch

2 -
+# Mainline vboxsf uses an option string rather then a custom binary data
struct
+Patch2: 0001-VBoxServiceAutoMount-Change-Linux-mount-code-to-use-.patch

-obj/bin/additions/mount.vboxsf

-%{_sbindir}/mount.vboxsf

Share folders still work ?

3- 
+Provides:   VirtualBox-kmod-common = %{version}-%{release}

haven't yet express my opinion , but I tested VirtualBox-kmod does not affect
the other kernel modules i.e if we have 2 voxvideo.ko the kernel one is loaded
first and other is not load so is pacific have both installed , if mount and
all kmod works with this package I think you just need 
delete Requires:   %{name}-kmod = %{version}
But I have think better and test it  ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #12 from digimer  ---
Thanks!!

I'll work on a new RPM shortly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161



--- Comment #2 from Carl George  ---
I came across this today.

https://github.com/moby/moby/pull/34226

I think it's worth considering starting this package with those binary names to
avoid having to change them later.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103



--- Comment #11 from Jan Pokorný  ---
I'll happily assign myself as a reviewer if there're no complaints.

For a start, the spec is needlessly overcomplicated around conditionals:

- instead of 

> %bcond_without sctp
> [...]
> %if %{with sctp}
> %global buildsctp 1
> %endif
> [...]
> %if %{defined buildsctp}
> BuildRequires: lksctp-tools-devel
> %endif
> 
> [...]
> 
> %build
> [...]
> %{configure} \
> %if %{defined buildsctp}
> --enable-libknet-sctp \
> %else
> --disable-libknet-sctp \
> %endif

  please use:

> %bcond_without sctp
> [...]
> %if %{with sctp}
> BuildRequires: lksctp-tools-devel
> %endif
> 
> [...]
> 
> %build
> [...]
> %{configure} \
>   %{?with_sctp:--enable-libknet-sctp} \
>   %{!?with_sctp:--disable-libknet-sctp} \

  where the latter part can even be compacted as:

> %build
> [...]
> %{configure} \
>   --%{?with_sctp:en}%{!?with_sctp:dis}able-libknet-sctp} \

See also:
http://rpm.org/user_doc/conditional_builds.html

* * *

Another spot from this first sight, there are various pieces
I believe are already obsolete in Fedora, e.g.:

> Requires(post):   systemd-sysv
> Requires(post):   systemd-units
> Requires(preun):  systemd-units
> Requires(postun): systemd-units

See e.g.:
https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/message/LLG4T53FW2BGVZLGLKNYTKPD5SQNBZ2Y/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506428

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #11 from Robert-André Mauchin  ---
Rex is probably very busy

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506429] Review Request: gnome-shell-extension-windowoverlay-icons - Show app icons on top of the windows thumbnails in Activities Overview

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506429

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506429] Review Request: gnome-shell-extension-windowoverlay-icons - Show app icons on top of the windows thumbnails in Activities Overview

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506429

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506428

Robert-André Mauchin  changed:

   What|Removed |Added

  Flags|fedora-review+  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1506428] Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1506428



--- Comment #10 from Andrew Toskin  ---
Rex, could you maybe mark this as approved again? Along with the other split
package, in Bug #1506429?

Or do I have to start over with a new review request, even though the packages
haven't changed since October?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537727] Review Request: python-cattrs - Python library for structuring and unstructuring data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537727



--- Comment #2 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-cattrs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539781] Review Request: ghc-fail - Forward-compatible MonadFail class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539781

Jens Petersen  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2018-01-29 16:25:36



--- Comment #1 from Jens Petersen  ---
fail is just a dummy package for ghc >= 8.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1177055] Tracker mesos - Cluster Manager to epel7

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1177055

Bugzilla account termination  changed:

   What|Removed |Added

   Assignee|tstcl...@redhat.com |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539920] Review Request: rocm-runtime - ROCm runtime driver for AMD compute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539920



--- Comment #1 from Tom Stellard  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/tstellar/rocm-1.6-userspace/rocm-runtime.git/plain/rocm-runtime.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-1.6-userspace/fedora-rawhide-x86_64/00706883-rocm-runtime/rocm-runtime-1.6.1-2.fc28.src.rpm

Fix Spec Ur.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539920] New: Review Request: rocm-runtime - ROCm runtime driver for AMD compute

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539920

Bug ID: 1539920
   Summary: Review Request: rocm-runtime - ROCm runtime driver for
AMD compute
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tstel...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/tstellar/rocm-1.6-userspace/rocm-runtime.git/tree/rocm-runtime.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/tstellar/rocm-1.6-userspace/fedora-rawhide-x86_64/00706883-rocm-runtime/rocm-runtime-1.6.1-2.fc28.src.rpm
Description: ROCm runtime driver for AMD compute
Fedora Account System Username: tstellar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536993] Review Request: notejot - Stupidly-simple sticky notes applet

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536993

Fabio Valentini  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-29 14:59:28



--- Comment #4 from Fabio Valentini  ---
Built in rawhide, updates for f27 and f26 pending.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Carl George  changed:

   What|Removed |Added

 CC||carl@george.computer



--- Comment #1 from Carl George  ---
Source3 in this spec file is containerd.  containerd is already packaged for
Fedora, and provides the commands containerd, containerd-shim, and ctr.  Based
on my current understanding of this brave new Moby world, Source3 and relevant
sections can be dropped and instead just require containerd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #26 from Fedora Update System  ---
timeshift-18.1.1-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-f67cb13026

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539281

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #7 from Fedora Update System  ---
rust-chan-0.1.20-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b1e007e911

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #25 from Fedora Update System  ---
timeshift-18.1.1-4.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-132058f52d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539366] Review Request: linux-driver-management - Generic driver management framework for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539366

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
linux-driver-management-1.0.2-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5dfcc2de15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534446] Review Request: timeshift - System restore tool for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534446



--- Comment #24 from Fedora Update System  ---
timeshift-18.1.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2034535a48

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 910699] Review Request: pagekite - makes localhost servers visible to the world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=910699
Bug 910699 depends on bug 910146, which changed state.

Bug 910146 Summary: Review Request: python-socksipychain - Python SOCKS/HTTP 
Proxy module
https://bugzilla.redhat.com/show_bug.cgi?id=910146

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 910146] Review Request: python-socksipychain - Python SOCKS/ HTTP Proxy module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=910146

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---



--- Comment #18 from Fedora Update System  ---
python-socksipychain-2.0.15-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2cf21e719f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #56 from Neal Gompa  ---
At this point, I see no remaining issues with the VirtualBox Guest Additions
packaging.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539831] New: Review Request: nheko - Desktop client for the Matrix protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539831

Bug ID: 1539831
   Summary: Review Request: nheko - Desktop client for the Matrix
protocol
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: vit...@easycoding.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://github.com/EasyCoding/nheko/raw/master/nheko.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/xvitaly/matrix/fedora-rawhide-x86_64/00706853-nheko/nheko-0.1.0-12.20180129git86aa409.fc28.src.rpm
Description: The motivation behind the project is to provide a native desktop
app for Matrix that feels more like a mainstream chat app (Riot, Telegram etc)
and less like an IRC client.
Fedora Account System Username: xvitaly

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1507103] Review Request: kronosnet - VPNs on steroids

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1507103

Andrew Price  changed:

   What|Removed |Added

 CC||anpr...@redhat.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539116] Review Request: grass - GRASS GIS - Geographic Resources Analysis Support System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539116



--- Comment #10 from Antonio Trande  ---
Please, post direct links to newest SPEC and SRPM (like
https://copr-be.cloud.fedoraproject.org/results/neteler/grass74/fedora-27-x86_64/00706613-grass/grass.spec,
we need them for using 'fedora-review' tool)

Explicate all changes in Changelog
(http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs).

This is not correct:

* Sun Jan 28 2018 Markus Neteler  - 7.4.0-2
- SPEC cleanup as per review in
https://bugzilla.redhat.com/show_bug.cgi?id=1539116

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539781] New: Review Request: ghc-fail - Forward-compatible MonadFail class

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539781

Bug ID: 1539781
   Summary: Review Request: ghc-fail - Forward-compatible
MonadFail class
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: peter...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://petersen.fedorapeople.org//ghc-fail.spec
SRPM URL: http://petersen.fedorapeople.org//ghc-fail-4.9.0.0-1.fc27.src.rpm

Description:
This package contains the "Control.Monad.Fail" module providing the
 class
that became available in  for older 'base' package versions.

This package turns into an empty package when used with GHC versions which
already provide the "Control.Monad.Fail" module to make way for GHC's own
"Control.Monad.Fail" module.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539161] Review Request: moby-engine - The open-source application container engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539161

Lokesh Mandvekar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1492331



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #55 from Hans de Goede  ---
(In reply to Nicolas Chauvet (kwizart) from comment #54)
> There is nothing holding review maybe except that the 4.16-rc1 kernel lands
> (or maybe even before rc1). Does it have everything needed ?

4.16-rc1 has the vboxguest driver, but it is lacking the vboxsf driver which is
necessary for shared folder support. I've submitted this upstream and it has
been reviewed and I've posted a new version addressing all review comments. So
hopefully vboxsf will get accepted into next soonish and then I can add it as a
downstream patch to Fedora. That is plan A, plan B is to ship without shared
folder support. If we end up with plan B we should probably have the
akmod-VirtualBox package build vboxsf instead of it not building any guest
modules at all. 

> I plan to do some runtime tests once everything has landed in the coming
> weeks.
> 
> Once this guest addition package will be created, I think it will be updated
> along the rpmfusion VirtualBox-guest-addition package. As I expect, this
> last will be disabled for f28+, but continue to exist for older fedora,rhel.
> Based on this I think it's indeed correct to have the obsoletes/provide to
> use a version macro. So everything is fine (maybe only to have a comment to
> schedule the removal of obsoletes/provides for f28+2 or whatever rhel
> version is relevant).

Ok, we also need to modify akmod-VirtualBox to not build the guest drivers on
F-28+, as discussed before we will keep it around on existing guests which
upgrade to F28 to avoid playing obsolete tricks which will cause problems on
vbox-host installations.

> One item I wonder if it can be improved is the "vboxsf" user/group creation:
> (which I think is the correct way to have this user/group created). But:
> 
> Is this really needed ? Can this be avoided in the long run so vbox
> graphical users don't need to add themselves to this group manually ?

The vboxsf user/group is used by shared folders marked as automount, these get
mounted under /media and are only readable/writable by users in the vboxsf
group.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #54 from Nicolas Chauvet (kwizart)  ---
There is nothing holding review maybe exept that the 4.16-rc1 kernel lands (or
maybe even before rc1). Does it have everything needed ?
I plan to do some runtime tests once everything has landed in the coming weeks.

Once this guest addition package will be created, I think it will be updated
along the rpmfusion VirtualBox-guest-addition package. As I expect, this last
will be disabled for f28+, but continue to exist for older fedora,rhel.
Based on this I think it's indeed correct to have the obsoletes/provide to use
a version macro. So everything is fine (maybe only to have a comment to
schedule the removal of obsoletes/provides for f28+2 or whatever rhel version
is relevant).

One item I wonder if it can be improved is the "vboxsf" user/group creation:
(which I think is the correct way to have this user/group created). But:

Is this really needed ? Can this be avoided in the long run so vbox graphical
users don't need to add themselves to this group manually ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #53 from Hans de Goede  ---
(In reply to Neal Gompa from comment #52)
> @Hans,
> 
> The spec file doesn't include this new change. Can you please upload it?

It is already there, but I messed up the link (Caps vs caps) because of the
name change, correct link:

https://fedorapeople.org/~jwrdegoede/virtualbox-guest-additions.spec

Sorry & Thank you,

Hans

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #52 from Neal Gompa  ---
@Hans,

The spec file doesn't include this new change. Can you please upload it?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539281] Review Request: rust-chan - Multi-producer, multi-consumer channels with select

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539281



--- Comment #6 from Fedora Update System  ---
rust-chan-0.1.20-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-b1e007e911

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: virtualbox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630

Hans de Goede  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |VirtualBox-guest-additions  |virtualbox-guest-additions
   |- VirtualBox Guest  |- VirtualBox Guest
   |Additions   |Additions



--- Comment #51 from Hans de Goede  ---
With the upcoming 4.16-rc1 coming to rawhide soon, which will include the
vboxguest driver, I believe we are ready to complete this review and get
virtualbox-guest-additions into Rawhide / Fedora 28 (and only there).

Here is a new version, addressing all review comments made:

Spec URL: https://fedorapeople.org/~jwrdegoede/VirtualBox-guest-additions.spec
SRPM URL:
https://fedorapeople.org/~jwrdegoede/virtualbox-guest-additions-5.2.6-3.fc27.src.rpm

Changelog:

* Mon Jan 29 2018 Hans de Goede  - 5.2.6-3
- Update to 5.2.6
- Drop VirtualBox-4.3.0-no-bundles.patch, set make variables instead
- Adjust automount vboxservice for mainline vboxsf filesystem driver
- Drop mount.vboxsf, the mainline vboxsf filesystem driver works with the
  regular mount binary
- Drop commented out Requires: kernel, this is bad idea (rhbz#1534595)
- Use pkgconfig to get include/libs instead of hardcoding (rhbz#1534595)
- Rename to lowercaps virtualbox-guest-additions, add Obsoletes / Provides
  for upgradepath from rpmfusion (rhbz#1534595)
- Add Provides: VirtualBox-kmod-common for rpmfusion upgradepath (rhbz#1534595)
- Latest rpmfusion Release is 2, set our Release field to 3

If someone can do an official review and approve this (or let me know what
needs to be fixed) then that would be great.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513774] Review Request: ghc-warp-tls - HTTP over TLS support for Warp via the TLS package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513774

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-warp-tls-3.2.4-1.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1513283] Review Request: ghc-tls-session-manager - In-memory TLS session manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1513283

Jens Petersen  changed:

   What|Removed |Added

 Status|POST|MODIFIED
   Fixed In Version||ghc-tls-session-manager-0.0
   ||.0.1-1.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481630] Review Request: VirtualBox-guest-additions - VirtualBox Guest Additions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481630



--- Comment #50 from Hans de Goede  ---
(In reply to Sergio Monteiro Basto from comment #33)
> kmk need this [1] all least in my case ... 
> 
> [1] 
> +VBOX_PATH_APP_PRIVATE=%{_libdir}/virtualbox \
> +VBOX_PATH_APP_DOCS=%{_docdir}/VirtualBox\

That is not needed when building just the additions, the additions do not
install any files into these paths.

(In reply to Nicolas Chauvet (kwizart) from comment #41)
> (In reply to Hans de Goede from comment #38)
> Quick review with few minors things:
> 
> * Keep from using requires on kernel from userspace. Most of the time this
> is invalid (you could be within a chroot , container or systemd-nspawn,
> etc). Also you need to select the appropriate variant (on x86_64
> kernel-debug exists or even kernel-rt).
> # FIXME once kernel modules have landed
> #Requires:   kernel >= 4.FIXME

Fixed in the next version.

> * Please use pkgconf --libs libpng and etc not to hardcode one particular
> library path. (say if there is a  need to use one particular scl at some
> point).

Fixed in the next version.

> * Is there a way "not to hardcode the vendor", such as:
> VBOX_BUILD_PUBLISHER=_%{?vendor}%{?!vendor:Unknown}

No that is not going to work, that would set the vendor to "_Fedora Project"
and it cannot contain spaces and I think that is too long too. vbox is very
picky about the version string into which this gets embedded. So it is best to
just hardcode this.

> * The replacement of the RPM Fusion package should works for the "userspace"
> but not much for the kmod-VirtualBox. Best is probably to keep a (virtual)
> Provides: VirtualBox-kmod-common = 5.2.2 (the last version of the rpmfusion
> counterpart before it is disabled). So that kmod-Virtualbox is kept while it
> will not try to seek the main VirtualBox(host) capability.
> Then, it will only be a matter for the kernel
> 
> Obsoletes/Provides for the akmod isn't an option because it will affect host
> kmod-VirtualBox and VirtualBox users.

Ok, I ve added a:

Provides:   VirtualBox-kmod-common

To the .spec for the next version.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #44)
> Package name should be virtualbox-guest-additions.

Fixed in the next version.

(In reply to Sergio Monteiro Basto from comment #49)
> why keep VirtualBox-5.0.18-xserver_guest.patch [1] ?

Even with VBOX_USE_SYSTEM_GL_HEADERS=1 there still is one small issue breaking
compilation, in my pkg this is a modified version of your original patch
keeping only the small chunk still necessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 910146] Review Request: python-socksipychain - Python SOCKS/ HTTP Proxy module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=910146



--- Comment #17 from Fedora Update System  ---
python-socksipychain-2.0.15-1.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-2cf21e719f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1519719] Review Request: php-phpunit-mock-objects5 - Mock Object library for PHPUnit

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1519719

Remi Collet  changed:

   What|Removed |Added

 Blocks||1539554




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1539554
[Bug 1539554] Review Request: php-phpunit-php-invoker2 - Invoke callables
with a timeout
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1539554] Review Request: php-phpunit-php-invoker2 - Invoke callables with a timeout

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1539554

Remi Collet  changed:

   What|Removed |Added

 Depends On||1519719, 1509856



--- Comment #1 from Remi Collet  ---
This is a new dependency for upcoming phpunit7

Changes from php-phpunit-PHP-Invoker
https://git.remirepo.net/cgit/rpms/php/phpunit/php-phpunit-php-invoker2.git/commit/?id=4cb460f06ef7c50e976069513e56d5699fe803a8

Blocked by reviews needed to update phpunit6 to 6.5


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1509856
[Bug 1509856] Review Request: php-phpunit-php-token-stream2 - Wrapper
around PHP tokenizer extension
https://bugzilla.redhat.com/show_bug.cgi?id=1519719
[Bug 1519719] Review Request: php-phpunit-mock-objects5 - Mock Object
library for PHPUnit
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1509856] Review Request: php-phpunit-php-token-stream2 - Wrapper around PHP tokenizer extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1509856

Remi Collet  changed:

   What|Removed |Added

 Blocks||1539554




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1539554
[Bug 1539554] Review Request: php-phpunit-php-invoker2 - Invoke callables
with a timeout
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org